)]}'
{"ironic/drivers/modules/amt/management.py":[{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"b3771c7cb2e8286749cb5b39daa1e0180f8b0186","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        Returns the current boot device of the node."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        :param task: a task from TaskManager."},{"line_number":162,"context_line":"        :returns: a dictionary containing::"},{"line_number":163,"context_line":"             boot_device: the boot device"},{"line_number":164,"context_line":"             persistent: Whether the boot device will persist to all"},{"line_number":165,"context_line":"             future boots or not, None if it is unknown."}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_1749b931","line":162,"updated":"2015-05-07 10:13:14.000000000","message":"This removes a build error but doesn\u0027t fix broken format of the document. I think it is enough to insert a blank line after this line like following:\n\n   :returns: a dictionary containing:\n\n       :boot_device: the boot device\n       ...","commit_id":"efe825415cbd3597a9370b6c2770e81979349440"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a54d74675e1aa25fc02aa807c423a3858b7a419e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        Returns the current boot device of the node."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        :param task: a task from TaskManager."},{"line_number":162,"context_line":"        :returns: a dictionary containing::"},{"line_number":163,"context_line":"             boot_device: the boot device"},{"line_number":164,"context_line":"             persistent: Whether the boot device will persist to all"},{"line_number":165,"context_line":"             future boots or not, None if it is unknown."}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_010df68f","line":162,"in_reply_to":"1aca2d91_1749b931","updated":"2015-05-07 10:49:49.000000000","message":"Agreed, looking at the docs it\u0027s not being rendered correctly. \n\nSee http://docs-draft.openstack.org/39/180339/2/check/gate-ironic-docs/fa10b86//doc/build/html/api/ironic.drivers.modules.amt.management.html?highlight\u003dget_boot_device#ironic.drivers.modules.amt.management.AMTManagement.get_boot_device","commit_id":"efe825415cbd3597a9370b6c2770e81979349440"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"7e1f49e607108d522cc6d154ac1fb54631ca9a14","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"             boot_device: the boot device"},{"line_number":165,"context_line":"             persistent: Whether the boot device will persist to all"},{"line_number":166,"context_line":"             future boots or not, None if it is unknown."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_2ef31bd8","line":166,"updated":"2015-05-08 02:00:35.000000000","message":"It\u0027s not being rendered correctly yet...\n\nhttp://docs-draft.openstack.org/39/180339/3/check/gate-ironic-docs/d290ec9//doc/build/html/api/ironic.drivers.modules.amt.management.html#ironic.drivers.modules.amt.management.AMTManagement.get_boot_device\n\nYou don\u0027t need to change above 3 lines. Just put them after a blank line like following:\n\n        :returns: a dictionary containing: \n        \u003c\u003c blank line \u003e\u003e\n             :boot_device: the boot device\n             :persistent: Whether the boot device will persist to all\n                 future boots or not, None if it is unknown.","commit_id":"a8f46b48ec520d47fc7941271bf9fac7bcc7d1d1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ccebd4dd5c93555bd0ba31b6c179a2933e6820b3","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"             boot_device: the boot device"},{"line_number":165,"context_line":"             persistent: Whether the boot device will persist to all"},{"line_number":166,"context_line":"             future boots or not, None if it is unknown."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_ebf3c39c","line":166,"in_reply_to":"1aca2d91_2ef31bd8","updated":"2015-05-08 14:21:22.000000000","message":"+1\n\nAlso Mario, you can generate the documentation locally to check if it\u0027s being  rendered correctly\n\nInside your venv, just run \"tox -egendocs\" and then open it with ur favorite browser. E.g\n\n (venv)[lucasagomes@lucasagomes ironic]$ tox -egendocs\n gendocs develop-inst-nodeps: /home/lucasagomes/Projects/ironic\n gendocs runtests: PYTHONHASHSEED\u003d\u00270\u0027\n gendocs runtests: commands[0] | python setup.py build_sphinx\n running build_sphinx\n ...\n\n (venv)[lucasagomes@lucasagomes ironic]$ firefox doc/build/html/index.html","commit_id":"a8f46b48ec520d47fc7941271bf9fac7bcc7d1d1"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"98265a6de695fd1d62a0ec59882152e5ab1652a6","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"             boot_device: the boot device"},{"line_number":165,"context_line":"             persistent: Whether the boot device will persist to all"},{"line_number":166,"context_line":"             future boots or not, None if it is unknown."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_8e9698ee","line":166,"in_reply_to":"1aca2d91_ebf3c39c","updated":"2015-05-08 16:45:31.000000000","message":"Oops - same problem as the other file - forgot that some lines were preceded by a :\n\nFixed.\n\nThanks Lucas - wasn\u0027t doing this before because I was developing on a cloud server, but I really should be doing that. Checked this time.","commit_id":"a8f46b48ec520d47fc7941271bf9fac7bcc7d1d1"}],"ironic/drivers/modules/msftocs/management.py":[{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"b3771c7cb2e8286749cb5b39daa1e0180f8b0186","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        Returns the current boot device of the node."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param task: a task from TaskManager."},{"line_number":100,"context_line":"        :returns: a dictionary containing::"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            boot_device: the boot device"},{"line_number":103,"context_line":"            persistent: Whether the boot device will persist to all"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_bc4aea81","line":100,"updated":"2015-05-07 10:13:14.000000000","message":"This fix introduces another warning. I think that it is enough to insert a blank line after the line like following:\n\n   :returns: a dictionary containing:\n\n       :boot_device: the boot device\n       ...","commit_id":"efe825415cbd3597a9370b6c2770e81979349440"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"7e1f49e607108d522cc6d154ac1fb54631ca9a14","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            boot_device: the boot device"},{"line_number":103,"context_line":"            persistent: Whether the boot device will persist to all"},{"line_number":104,"context_line":"            future boots or not, None if it is unknown."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        client, blade_id \u003d msftocs_common.get_client_info("}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_0e73bf4e","line":104,"updated":"2015-05-08 02:00:35.000000000","message":"It\u0027s not being rendered correctly yet.\nYou don\u0027t need to change above 3 lines. Just put them after a blank line.","commit_id":"a8f46b48ec520d47fc7941271bf9fac7bcc7d1d1"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"98265a6de695fd1d62a0ec59882152e5ab1652a6","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            boot_device: the boot device"},{"line_number":103,"context_line":"            persistent: Whether the boot device will persist to all"},{"line_number":104,"context_line":"            future boots or not, None if it is unknown."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        client, blade_id \u003d msftocs_common.get_client_info("}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_4e9ac064","line":104,"in_reply_to":"1aca2d91_0e73bf4e","updated":"2015-05-08 16:45:31.000000000","message":"Ah, sorry, I forgot that the : was behind some lines in the original code. Fixed.","commit_id":"a8f46b48ec520d47fc7941271bf9fac7bcc7d1d1"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2040d25a4b91f23b2b133f81926d02d0d17bd847","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        then it sets provisioning as failed and powers off the node."},{"line_number":573,"context_line":"        :param task: A TaskManager object."},{"line_number":574,"context_line":"        :param kwargs: The arguments sent with vendor passthru.  The expected"},{"line_number":575,"context_line":"        kwargs are::"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"                \u0027key\u0027: The deploy key for authorization"},{"line_number":578,"context_line":"                \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ad8896b_ae82d7c6","line":575,"updated":"2015-05-11 16:35:48.000000000","message":"It looks to me like there should be a blank line after line 572, and that this line should stay indented.\n\nI see that the line above has two blank spaces after \u0027passthru.\u0027. I was wondering why you changed some other lines (eg [1]) to only have one blank space, and this one you left alone. Are there warnings when two blank spaces are used?\n\n[1] https://review.openstack.org/#/c/180339/4/ironic/drivers/modules/ilo/deploy.py","commit_id":"bd832b7f9a352a455b423e4564ae9774fa5ea537"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"47ee3444740236b0acaf076bd4f82e3944b02308","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        then it sets provisioning as failed and powers off the node."},{"line_number":573,"context_line":"        :param task: A TaskManager object."},{"line_number":574,"context_line":"        :param kwargs: The arguments sent with vendor passthru.  The expected"},{"line_number":575,"context_line":"        kwargs are::"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"                \u0027key\u0027: The deploy key for authorization"},{"line_number":578,"context_line":"                \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_85b0ce44","line":575,"in_reply_to":"7ad8896b_ae82d7c6","updated":"2015-05-15 19:58:25.000000000","message":"Fixed. No reason to leave that alone, just missed it, thanks.\n\nFWIW when the bug this references is fixed we can just not let warnings pass tests, but there\u0027s a weird import error happening that needs to be fixed first that seemed to be more difficult to fix than these low-hanging fruit.","commit_id":"bd832b7f9a352a455b423e4564ae9774fa5ea537"}],"test-requirements.txt":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"907b80a340c17cc46e2f8d021fd063c972a0ab17","unresolved":false,"context_lines":[{"line_number":16,"context_line":"testtools\u003e\u003d0.9.36,!\u003d1.2.0"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Doc requirements"},{"line_number":19,"context_line":"sphinx\u003e\u003d1.3,\u003c\u003d1.4"},{"line_number":20,"context_line":"sphinxcontrib-pecanwsme\u003e\u003d0.8"},{"line_number":21,"context_line":"oslosphinx\u003e\u003d2.5.0  # Apache-2.0"},{"line_number":22,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"1aca2d91_349bbccb","line":19,"updated":"2015-05-06 12:36:43.000000000","message":"Seems to be incompatible with global-requirements https://github.com/openstack/requirements/blob/master/global-requirements.txt#L249","commit_id":"fee147657327cde3018d9ba2b433f213d87bceec"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"db36e307f391c73010b8a57697d8165d6bf6dce6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"testtools\u003e\u003d0.9.36,!\u003d1.2.0"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Doc requirements"},{"line_number":19,"context_line":"sphinx\u003e\u003d1.3,\u003c\u003d1.4"},{"line_number":20,"context_line":"sphinxcontrib-pecanwsme\u003e\u003d0.8"},{"line_number":21,"context_line":"oslosphinx\u003e\u003d2.5.0  # Apache-2.0"},{"line_number":22,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"1aca2d91_f8ec0e91","line":19,"in_reply_to":"1aca2d91_349bbccb","updated":"2015-05-06 15:26:45.000000000","message":"Oh, I didn\u0027t know that existed. Thanks for catching this.\n\nWhat\u0027s the process for getting this bumped globally? I\u0027d imagine some projects rely on the previous versioning.\n\nIf the process is just a review, would you recommend changing the global requirements to remove the version cap, instead of modifying the minimum requirement? That seems to be the recommendation for stable libraries in the README.","commit_id":"fee147657327cde3018d9ba2b433f213d87bceec"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"b4011a5ad4c745f7ff7a139212c39c0961331c72","unresolved":false,"context_lines":[{"line_number":16,"context_line":"testtools\u003e\u003d0.9.36,!\u003d1.2.0"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Doc requirements"},{"line_number":19,"context_line":"sphinx\u003e\u003d1.3,\u003c\u003d1.4"},{"line_number":20,"context_line":"sphinxcontrib-pecanwsme\u003e\u003d0.8"},{"line_number":21,"context_line":"oslosphinx\u003e\u003d2.5.0  # Apache-2.0"},{"line_number":22,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"1aca2d91_99d8721f","line":19,"in_reply_to":"1aca2d91_d3aff5e1","updated":"2015-05-06 20:28:22.000000000","message":"It looks like we can\u0027t update this without breaking some man pages.\n\nI\u0027ll update the change to just include a few warning fixes that don\u0027t need mocking.\n\nI think the mocking strategy was avoiding the root problem anyway. The imports that the documentation fails on seem to be ambiguous in whether they\u0027re relative or absolute imports.","commit_id":"fee147657327cde3018d9ba2b433f213d87bceec"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f704dbc8f824ff96c52b4ef848f813356f4f6af4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"testtools\u003e\u003d0.9.36,!\u003d1.2.0"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Doc requirements"},{"line_number":19,"context_line":"sphinx\u003e\u003d1.3,\u003c\u003d1.4"},{"line_number":20,"context_line":"sphinxcontrib-pecanwsme\u003e\u003d0.8"},{"line_number":21,"context_line":"oslosphinx\u003e\u003d2.5.0  # Apache-2.0"},{"line_number":22,"context_line":""}],"source_content_type":"text/plain","patch_set":1,"id":"1aca2d91_d3aff5e1","line":19,"in_reply_to":"1aca2d91_f8ec0e91","updated":"2015-05-06 15:32:36.000000000","message":"Changing global requirement is usual review process, though there might be reasons why it was capped, I\u0027d ask that in IRC channel as I haven\u0027t done this.","commit_id":"fee147657327cde3018d9ba2b433f213d87bceec"}]}