)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a8172e185eaf044b199b2f091fc6391717503fc8","unresolved":false,"context_lines":[{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"[ironic_lib]"},{"line_number":1817,"context_line":"#"},{"line_number":1818,"context_line":"# Optinos defined in ironic_lib.utils"},{"line_number":1819,"context_line":"#"},{"line_number":1820,"context_line":"# Path to the rootwrap configuration file to use for running"},{"line_number":1821,"context_line":"# commands as root. (string value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7a2fa921_1e163cf1","line":1818,"updated":"2015-10-08 12:36:32.000000000","message":"s/Optinos/Options","commit_id":"717e57a49f146ad0cb1398a083756d471582a7a4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"e971483dd01618043fe7a4eaa34c912a01ddcd1d","unresolved":false,"context_lines":[{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"[ironic_lib]"},{"line_number":1817,"context_line":"#"},{"line_number":1818,"context_line":"# Optinos defined in ironic_lib.utils"},{"line_number":1819,"context_line":"#"},{"line_number":1820,"context_line":"# Path to the rootwrap configuration file to use for running"},{"line_number":1821,"context_line":"# commands as root. (string value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7a2fa921_456fc6fb","line":1818,"in_reply_to":"7a2fa921_1e163cf1","updated":"2015-10-09 12:50:41.000000000","message":"Thanks, Will fix in next patch","commit_id":"717e57a49f146ad0cb1398a083756d471582a7a4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a8172e185eaf044b199b2f091fc6391717503fc8","unresolved":false,"context_lines":[{"line_number":1821,"context_line":"# commands as root. (string value)"},{"line_number":1822,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":1823,"context_line":""},{"line_number":1824,"context_line":"# Ptah to the rootwap helper command to use for running "},{"line_number":1825,"context_line":"# commands as root. (string value)"},{"line_number":1826,"context_line":"#rootwrap_helper_cmd\u003d\u0027sudo ironic-rootwrap\u0027"},{"line_number":1827,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7a2fa921_be2e2841","line":1824,"updated":"2015-10-08 12:36:32.000000000","message":"s/\"Ptah to the\" / \"The\"\n\nRemove exta space at end of line","commit_id":"717e57a49f146ad0cb1398a083756d471582a7a4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"e971483dd01618043fe7a4eaa34c912a01ddcd1d","unresolved":false,"context_lines":[{"line_number":1821,"context_line":"# commands as root. (string value)"},{"line_number":1822,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":1823,"context_line":""},{"line_number":1824,"context_line":"# Ptah to the rootwap helper command to use for running "},{"line_number":1825,"context_line":"# commands as root. (string value)"},{"line_number":1826,"context_line":"#rootwrap_helper_cmd\u003d\u0027sudo ironic-rootwrap\u0027"},{"line_number":1827,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7a2fa921_2543aa6d","line":1824,"in_reply_to":"7a2fa921_be2e2841","updated":"2015-10-09 12:50:41.000000000","message":"Sure, Will fix in next patch","commit_id":"717e57a49f146ad0cb1398a083756d471582a7a4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"28f7628e7bde8c0854b6433a852461451df6c3a4","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Path to the rootwrap configuration file to use for running"},{"line_number":127,"context_line":"# commands as root. (string value)"},{"line_number":128,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":131,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a2ca52d_276ea701","line":128,"updated":"2015-10-15 15:02:40.000000000","message":"we\u0027re going to have this twice because it is also in ironic-lib?","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1122290281ce4da412b410cc306752276e86edcf","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Path to the rootwrap configuration file to use for running"},{"line_number":127,"context_line":"# commands as root. (string value)"},{"line_number":128,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":131,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a29b11f_e496bb93","line":128,"in_reply_to":"3a29b11f_d786e1b8","updated":"2015-10-19 14:48:40.000000000","message":"I was asking why we have \u0027rootwrap_config\u0027 config in ironic.common.utils AND in ironic-lib.utils.\n\nIt seems to me that we should change the code in ironic.common.utils to use the code/configs from ironic-lib.\n\nI must be missing something because I don\u0027t understand which part of your comment answers this question.","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"55a5e62a960627bddc8fac238b19d039d034a901","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Path to the rootwrap configuration file to use for running"},{"line_number":127,"context_line":"# commands as root. (string value)"},{"line_number":128,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":131,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a29b11f_d786e1b8","line":128,"in_reply_to":"5a2ca52d_276ea701","updated":"2015-10-19 10:14:50.000000000","message":"We run system commands from ironic, as well as ironic-lib. so it is necessary to define these in two places. \n\nHowever ironic-lib will pick the values from the \"DEFAULT\" group, so we dont have to define it twice in ironic.conf file.\n\nI took this approach, because, I got duplicate definition error for these config parameters, when I tested ironic-lib for the entire solution, by using ironic-lib in ironic and ipa projects.  \n\nironic-lib will be used not just in ironic, but in ipa and other projects as well, so, rootwrap* config parameter would be different. I ended up defining rootwrap_config and rootwrap_helper_cmd in ironic-lib as empty string,  so that whoever used ironic-lib, they have to define them if the respective project config files if they are using rootwrap infrastructure to run system commands or leave it as undefined(as in ipa).\n\nWe can do the other way round as well. In ironic-lib use default values as that is being used in \"ironic\", and change the default values of ironic-lib to empty strings when used in ipa.\n\nLet me know which one to choose, or if we want to take a different approach for defining these config parameters.","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"28f7628e7bde8c0854b6433a852461451df6c3a4","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":131,"context_line":"# (string value)"},{"line_number":132,"context_line":"#tempdir\u003d/tmp"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a2ca52d_0774cbcc","line":132,"updated":"2015-10-15 15:02:40.000000000","message":"ditto","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"55a5e62a960627bddc8fac238b19d039d034a901","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":131,"context_line":"# (string value)"},{"line_number":132,"context_line":"#tempdir\u003d/tmp"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a29b11f_57c171e3","line":132,"in_reply_to":"5a2ca52d_0774cbcc","updated":"2015-10-19 10:14:50.000000000","message":"same comments as above.","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"28f7628e7bde8c0854b6433a852461451df6c3a4","unresolved":false,"context_lines":[{"line_number":806,"context_line":""},{"line_number":807,"context_line":"# Size of EFI system partition in MiB when configuring UEFI"},{"line_number":808,"context_line":"# systems for local boot. (integer value)"},{"line_number":809,"context_line":"#efi_system_partition_size\u003d200"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"# Block size to use when writing to the nodes disk. (string"},{"line_number":812,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a2ca52d_1dcbbca6","line":809,"updated":"2015-10-15 15:02:40.000000000","message":"this should have moved to a different group","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"55a5e62a960627bddc8fac238b19d039d034a901","unresolved":false,"context_lines":[{"line_number":806,"context_line":""},{"line_number":807,"context_line":"# Size of EFI system partition in MiB when configuring UEFI"},{"line_number":808,"context_line":"# systems for local boot. (integer value)"},{"line_number":809,"context_line":"#efi_system_partition_size\u003d200"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"# Block size to use when writing to the nodes disk. (string"},{"line_number":812,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a29b11f_32dde314","line":809,"in_reply_to":"5a2ca52d_1dcbbca6","updated":"2015-10-19 10:14:50.000000000","message":"yes, they will be moved to disk_utils group. \n\nI will update this file by running the tool.","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"28f7628e7bde8c0854b6433a852461451df6c3a4","unresolved":false,"context_lines":[{"line_number":810,"context_line":""},{"line_number":811,"context_line":"# Block size to use when writing to the nodes disk. (string"},{"line_number":812,"context_line":"# value)"},{"line_number":813,"context_line":"#dd_block_size\u003d1M"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"# Maximum attempts to verify an iSCSI connection is active,"},{"line_number":816,"context_line":"# sleeping 1 second between attempts. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a2ca52d_1d42dc10","line":813,"updated":"2015-10-15 15:02:40.000000000","message":"ditto","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"55a5e62a960627bddc8fac238b19d039d034a901","unresolved":false,"context_lines":[{"line_number":810,"context_line":""},{"line_number":811,"context_line":"# Block size to use when writing to the nodes disk. (string"},{"line_number":812,"context_line":"# value)"},{"line_number":813,"context_line":"#dd_block_size\u003d1M"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"# Maximum attempts to verify an iSCSI connection is active,"},{"line_number":816,"context_line":"# sleeping 1 second between attempts. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a29b11f_b2d1f3fd","line":813,"in_reply_to":"5a2ca52d_1d42dc10","updated":"2015-10-19 10:14:50.000000000","message":"same as above","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"28f7628e7bde8c0854b6433a852461451df6c3a4","unresolved":false,"context_lines":[{"line_number":1825,"context_line":"# commands as root. (string value)"},{"line_number":1826,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":"# Path to the rootwap helper command to use for running"},{"line_number":1829,"context_line":"# commands as root. (string value)"},{"line_number":1830,"context_line":"#rootwrap_helper_cmd\u003d\u0027sudo ironic-rootwrap\u0027"},{"line_number":1831,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a2ca52d_42863114","line":1828,"updated":"2015-10-15 15:02:40.000000000","message":"this is wrong, but I don\u0027t see this incorrect string in ironic-lib. How did you generate this file?","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1122290281ce4da412b410cc306752276e86edcf","unresolved":false,"context_lines":[{"line_number":1825,"context_line":"# commands as root. (string value)"},{"line_number":1826,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":"# Path to the rootwap helper command to use for running"},{"line_number":1829,"context_line":"# commands as root. (string value)"},{"line_number":1830,"context_line":"#rootwrap_helper_cmd\u003d\u0027sudo ironic-rootwrap\u0027"},{"line_number":1831,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a29b11f_490eaa35","line":1828,"in_reply_to":"3a29b11f_b289f3cc","updated":"2015-10-19 14:48:40.000000000","message":"You can add ironic_lib.disk_utils and ironic_lib.utils to tools/config/oslo.config.generator.rc (to IRONIC_...MODULES).","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"55a5e62a960627bddc8fac238b19d039d034a901","unresolved":false,"context_lines":[{"line_number":1825,"context_line":"# commands as root. (string value)"},{"line_number":1826,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":1827,"context_line":""},{"line_number":1828,"context_line":"# Path to the rootwap helper command to use for running"},{"line_number":1829,"context_line":"# commands as root. (string value)"},{"line_number":1830,"context_line":"#rootwrap_helper_cmd\u003d\u0027sudo ironic-rootwrap\u0027"},{"line_number":1831,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a29b11f_b289f3cc","line":1828,"in_reply_to":"5a2ca52d_42863114","updated":"2015-10-19 10:14:50.000000000","message":"I will update this sample file by running the tool and update the file with the default values as required in ironic.\n\ntools/config/generate_sample.sh --module\u003dironic_lib.disk_utils --module\u003dironic_lib.utils","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"065e6379c7ea1a8bb658fd417b55865903f66bf5","unresolved":false,"context_lines":[{"line_number":1862,"context_line":"# value)"},{"line_number":1863,"context_line":"#port\u003d18083"},{"line_number":1864,"context_line":""},{"line_number":1865,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3a29b11f_49e22a05","line":1865,"updated":"2015-10-19 14:39:39.000000000","message":"I don\u0027t see check_device_interval or check_device_max_retries configs from ironic-lib.","commit_id":"c3a2b042cf887ab6d0b89b7995881772b55f0a3c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"458783db68953fdcf112c6910c4bdc2554b1f082","unresolved":false,"context_lines":[{"line_number":1862,"context_line":"# value)"},{"line_number":1863,"context_line":"#port\u003d18083"},{"line_number":1864,"context_line":""},{"line_number":1865,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3a29b11f_575e1c13","line":1865,"in_reply_to":"3a29b11f_49e22a05","updated":"2015-10-20 06:12:33.000000000","message":"Sorry, My mistake. I did not included disk_partitioner module from ironic lib while generating sample config file.\n\nI will generate it again in my next patch.\n\nThanks.","commit_id":"c3a2b042cf887ab6d0b89b7995881772b55f0a3c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5059a8b6e45170732d448907d4f4d0ea51775648","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":131,"context_line":"# (string value)"},{"line_number":132,"context_line":"#tempdir\u003d/tmp"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3a29b11f_67a6f511","line":132,"updated":"2015-10-20 13:43:39.000000000","message":"This is wrong. If we moved the common bits of code to ironic-lib, then we should be using ironic-lib, and removing this from ironic.common.utils.","commit_id":"5a9b5b85fe46c810b864f7c5f8be57a15138468a"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"7f5bac6194e48d4253b5943448c8fbe5dba600ae","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":131,"context_line":"# (string value)"},{"line_number":132,"context_line":"#tempdir\u003d/tmp"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3a29b11f_e4fadf74","line":132,"in_reply_to":"3a29b11f_67a6f511","updated":"2015-10-21 12:37:18.000000000","message":"Yes, I agree. Let me make some more changes to the code.\nI will replace the above config parameter with ironic-lib\u0027s instead of ironic.","commit_id":"5a9b5b85fe46c810b864f7c5f8be57a15138468a"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"09dc1af9dff6982d477da32eca5c5194bbf700b1","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":135,"context_line":"# (string value)"},{"line_number":136,"context_line":"#tempdir\u003d/tmp"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a29b11f_e72b2893","side":"PARENT","line":136,"updated":"2015-10-26 06:35:00.000000000","message":"Why are these options removed?? Shouldn\u0027t they be set in Ironic and passed *into* the library, rather than set in the library and imported into the project?","commit_id":"16fd500a888227b401b0112f2ae2824d71770af7"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"f008fd16be0a10c63303998418cdb33445b19421","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":135,"context_line":"# (string value)"},{"line_number":136,"context_line":"#tempdir\u003d/tmp"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a29b11f_12c46090","side":"PARENT","line":136,"in_reply_to":"3a29b11f_e72b2893","updated":"2015-10-26 07:08:24.000000000","message":"Earlier, our focus was to move only disk_partitioner code into ironic-lib. Now since ironic-lib can be used to host all other common code from ironic, \n\nI think it is logical to move these options also into ironic-lib and import them along with ironic-lib into ironic.","commit_id":"16fd500a888227b401b0112f2ae2824d71770af7"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"09dc1af9dff6982d477da32eca5c5194bbf700b1","unresolved":false,"context_lines":[{"line_number":846,"context_line":"# Options defined in ironic.drivers.modules.deploy_utils"},{"line_number":847,"context_line":"#"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"# Size of EFI system partition in MiB when configuring UEFI"},{"line_number":850,"context_line":"# systems for local boot. (integer value)"},{"line_number":851,"context_line":"#efi_system_partition_size\u003d200"},{"line_number":852,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a29b11f_8717d453","side":"PARENT","line":849,"updated":"2015-10-26 06:35:00.000000000","message":"this looks like a breaking config file change\n\nwe need to deprecate options gracefully, not suddenly remove them","commit_id":"16fd500a888227b401b0112f2ae2824d71770af7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"da938dca360f51045dd7b9840baf916e1a120a30","unresolved":false,"context_lines":[{"line_number":846,"context_line":"# Options defined in ironic.drivers.modules.deploy_utils"},{"line_number":847,"context_line":"#"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"# Size of EFI system partition in MiB when configuring UEFI"},{"line_number":850,"context_line":"# systems for local boot. (integer value)"},{"line_number":851,"context_line":"#efi_system_partition_size\u003d200"},{"line_number":852,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a29b11f_7f2f9cf6","side":"PARENT","line":849,"in_reply_to":"3a29b11f_7213540e","updated":"2015-10-26 08:57:44.000000000","message":"+1, I think we need to file a bug, fix that first, release a new version of ironic-lib and then try to do this change.","commit_id":"16fd500a888227b401b0112f2ae2824d71770af7"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"e88e65d593de170d0e726df5ad285bc85381ae0a","unresolved":false,"context_lines":[{"line_number":846,"context_line":"# Options defined in ironic.drivers.modules.deploy_utils"},{"line_number":847,"context_line":"#"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"# Size of EFI system partition in MiB when configuring UEFI"},{"line_number":850,"context_line":"# systems for local boot. (integer value)"},{"line_number":851,"context_line":"#efi_system_partition_size\u003d200"},{"line_number":852,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a29b11f_d316e7f0","side":"PARENT","line":849,"in_reply_to":"3a29b11f_7f2f9cf6","updated":"2015-10-26 12:20:44.000000000","message":"I have already filed a bug for this.\nhttps://bugs.launchpad.net/ironic-lib/+bug/1509964\n\nI dont think we have to wait for ironic-lib to make these changes first, because ironic is not dependent on this change, as it is in-development for mitaka. We require the above fix in ironic-lib for final release of ironic.","commit_id":"16fd500a888227b401b0112f2ae2824d71770af7"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"f008fd16be0a10c63303998418cdb33445b19421","unresolved":false,"context_lines":[{"line_number":846,"context_line":"# Options defined in ironic.drivers.modules.deploy_utils"},{"line_number":847,"context_line":"#"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"# Size of EFI system partition in MiB when configuring UEFI"},{"line_number":850,"context_line":"# systems for local boot. (integer value)"},{"line_number":851,"context_line":"#efi_system_partition_size\u003d200"},{"line_number":852,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a29b11f_7213540e","side":"PARENT","line":849,"in_reply_to":"3a29b11f_8717d453","updated":"2015-10-26 07:08:24.000000000","message":"I think we can remove this option from here. \n\nWe need to add \"deploy\" as \"deprecated group\" in \"disk_utils\", which is part of ironic-lib. So that we dont break the config file change.\n\nI will file a bug on ironic-lib to add \"deprecated group\" for these options.","commit_id":"16fd500a888227b401b0112f2ae2824d71770af7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"573d0c987960da8ce405c90fa394b82fa737dd39","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Path to the rootwrap configuration file to use for running"},{"line_number":131,"context_line":"# commands as root. (string value)"},{"line_number":132,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":135,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"1a26ad4f_53981bc0","side":"PARENT","line":132,"updated":"2015-11-02 17:35:48.000000000","message":"I was thinking about this and I don\u0027t think this is correct. If we did this, we\u0027d need to deprecate this config and I\u0027m not convinced we want to move it to ironic-lib.\n\nIf I understand correctly, you moved this to ironic-lib because ipa and ironic shared similar code wrt utils.execute(). ipa doesn\u0027t use rootwrap and I don\u0027t know whether the plan is for it to use it or not -- in which case the rootwrap_config and (new) rootwrap_helper_cmd config makes no sense for ipa. Other than the rootwrap stuff, it seems to me that we should push up the changes in our execute() to oslo_concurrency\u0027s execute().\n\nUnless it is obvious (you\u0027ll have to convince me) that we really want to move this to ironic-lib, I think we should keep this code/configs. Or at least defer the move until later when it is more obvious that it is needed.","commit_id":"f05b139205661c65b9d8e3ed76e04cdaebddfe2f"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"bd217870e3ef36ebe66f3dda89efca093f7f2973","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Path to the rootwrap configuration file to use for running"},{"line_number":131,"context_line":"# commands as root. (string value)"},{"line_number":132,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":135,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"fa80f949_ff261ab9","side":"PARENT","line":132,"in_reply_to":"1a26ad4f_53981bc0","updated":"2015-11-05 05:09:39.000000000","message":"Yes, you are right. \nSince the disk partitoner commands need to be called with rootwrap and without-rootwrap commands in ironic and ipa, I took the below approach.\n\nI defined these root_wrap* config in ironic-lib under \"ironic_lib\" group and in earlier patch(patch set 5) I left it as is in ironic \"default\" group. \n\nI left the default value of these config as empty string in ironic-lib, so that when ironic-lib is used in ipa, the execute command does not use root-wrap. Where as for ironic use case, rootwrap* config values will pick up from \"default\" group. \n\nWe can leave these rootwrap* conif in ironic as is, but need to re-define a new set of these config in \"ironic_lib\" group. As in patch set [5].\n\nIf you are fine with this appraoch, I will revert back these changes.","commit_id":"f05b139205661c65b9d8e3ed76e04cdaebddfe2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"edacc69414a0e9892d8b70e770b712d1adfcd07a","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Path to the rootwrap configuration file to use for running"},{"line_number":131,"context_line":"# commands as root. (string value)"},{"line_number":132,"context_line":"#rootwrap_config\u003d/etc/ironic/rootwrap.conf"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":135,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da85f559_7db9f0e8","side":"PARENT","line":132,"in_reply_to":"fa80f949_ff261ab9","updated":"2015-11-09 15:47:37.000000000","message":"I\u0027m not sure you understood what I meant.\n\nI mean, do not use the code from ironic-lib for this. In fact, I am thinking of deleting ironic-lib/utils.py.","commit_id":"f05b139205661c65b9d8e3ed76e04cdaebddfe2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"573d0c987960da8ce405c90fa394b82fa737dd39","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":135,"context_line":"# (string value)"},{"line_number":136,"context_line":"#tempdir\u003d/tmp"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"1a26ad4f_93fb137b","side":"PARENT","line":136,"updated":"2015-11-02 17:35:48.000000000","message":"I have similar thoughts about this. Looking at ironic-lib, tempdir is only needed by work_on_disk(). Why not leave this and change work_on_disk() to have another parameter \u0027tempdir\u0027. If unspecified, the default could be tempfile.gettempdir().","commit_id":"f05b139205661c65b9d8e3ed76e04cdaebddfe2f"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"bd217870e3ef36ebe66f3dda89efca093f7f2973","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":135,"context_line":"# (string value)"},{"line_number":136,"context_line":"#tempdir\u003d/tmp"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"fa80f949_5f196678","side":"PARENT","line":136,"in_reply_to":"1a26ad4f_93fb137b","updated":"2015-11-05 05:09:39.000000000","message":"Yes, i have defined the same config parameter, but in a new \"ironic_lib\" group in patch set 5.","commit_id":"f05b139205661c65b9d8e3ed76e04cdaebddfe2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"edacc69414a0e9892d8b70e770b712d1adfcd07a","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Temporary working directory, default is Python temp dir."},{"line_number":135,"context_line":"# (string value)"},{"line_number":136,"context_line":"#tempdir\u003d/tmp"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da85f559_fdaac06f","side":"PARENT","line":136,"in_reply_to":"fa80f949_5f196678","updated":"2015-11-09 15:47:37.000000000","message":"I meant that ironic-lib/utils.py should not provide a tempdir config.","commit_id":"f05b139205661c65b9d8e3ed76e04cdaebddfe2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"573d0c987960da8ce405c90fa394b82fa737dd39","unresolved":false,"context_lines":[{"line_number":852,"context_line":""},{"line_number":853,"context_line":"# Block size to use when writing to the nodes disk. (string"},{"line_number":854,"context_line":"# value)"},{"line_number":855,"context_line":"#dd_block_size\u003d1M"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"# Maximum attempts to verify an iSCSI connection is active,"},{"line_number":858,"context_line":"# sleeping 1 second between attempts. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"1a26ad4f_f305a710","side":"PARENT","line":855,"updated":"2015-11-02 17:35:48.000000000","message":"Continuing the comments from revision 9. If you deprecate this on the ironic-lib side, what will the behaviour be as far as the user is concerned?\n\nI\u0027m guessing that this .sample won\u0027t have these two configs here, and the corresponding configs in the [disk_utils] group will have something like \u0027Deprecated group/name - [deploy]/dd_block_size.\u0027 And the oslo-related code will check both groups for the config values.\n\nSo any other project (ipa?) will also show the deprecated group/name stuff even though they had never used the original, but we\u0027re fine with that, right?\n\n[My comment here is just to clarify/make sure we understand what is going to happen...]","commit_id":"f05b139205661c65b9d8e3ed76e04cdaebddfe2f"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"bd217870e3ef36ebe66f3dda89efca093f7f2973","unresolved":false,"context_lines":[{"line_number":852,"context_line":""},{"line_number":853,"context_line":"# Block size to use when writing to the nodes disk. (string"},{"line_number":854,"context_line":"# value)"},{"line_number":855,"context_line":"#dd_block_size\u003d1M"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"# Maximum attempts to verify an iSCSI connection is active,"},{"line_number":858,"context_line":"# sleeping 1 second between attempts. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"fa80f949_3fba6224","side":"PARENT","line":855,"in_reply_to":"1a26ad4f_f305a710","updated":"2015-11-05 05:09:39.000000000","message":"For the existing user of ironic, their old config files should work without any modification - ironic-lib will pick the values for config parameters of new group \"disk_utils\" from the existing \"deploy\" group. \n\nWhere as for ipa users, since they do not define these values/have no config file defined, they the default values defined in ironic-lib will be used. \n\nFor ipa, since they will be using this code for the first time, they can define the values for these paramters in disk_utils group, if they want. I think deprecated group name appearing in the config file should not cause any concern to the user.","commit_id":"f05b139205661c65b9d8e3ed76e04cdaebddfe2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"573d0c987960da8ce405c90fa394b82fa737dd39","unresolved":false,"context_lines":[{"line_number":835,"context_line":""},{"line_number":836,"context_line":"# Maximum attempts to verify an iSCSI connection is active,"},{"line_number":837,"context_line":"# sleeping 1 second between attempts. (integer value)"},{"line_number":838,"context_line":"#iscsi_verify_attempts\u003d3"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"# ironic-conductor node\u0027s HTTP server URL. Example:"},{"line_number":841,"context_line":"# http://192.1.2.3:8080 (string value)"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"1a26ad4f_53dd7bde","line":838,"updated":"2015-11-02 17:35:48.000000000","message":"This is also in ironic-lib. Why is it still in ironic?","commit_id":"b0b9a8623e20bc9f06bacf94d51f19853fbc7802"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"bd217870e3ef36ebe66f3dda89efca093f7f2973","unresolved":false,"context_lines":[{"line_number":835,"context_line":""},{"line_number":836,"context_line":"# Maximum attempts to verify an iSCSI connection is active,"},{"line_number":837,"context_line":"# sleeping 1 second between attempts. (integer value)"},{"line_number":838,"context_line":"#iscsi_verify_attempts\u003d3"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"# ironic-conductor node\u0027s HTTP server URL. Example:"},{"line_number":841,"context_line":"# http://192.1.2.3:8080 (string value)"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"fa80f949_5fede6ed","line":838,"in_reply_to":"1a26ad4f_53dd7bde","updated":"2015-11-05 05:09:39.000000000","message":"Yes, we can use this config from ironic-lib.","commit_id":"b0b9a8623e20bc9f06bacf94d51f19853fbc7802"}],"ironic/common/utils.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"da938dca360f51045dd7b9840baf916e1a120a30","unresolved":false,"context_lines":[{"line_number":28,"context_line":"import shutil"},{"line_number":29,"context_line":"import tempfile"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from ironic_lib import utils as lib_utils"},{"line_number":32,"context_line":"import netaddr"},{"line_number":33,"context_line":"from oslo_concurrency import processutils"},{"line_number":34,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_bf1c54c2","line":31,"updated":"2015-10-26 08:57:44.000000000","message":"nit: better s/lib_utils/ironic_lib_utils","commit_id":"ffb074d1fef4ca0560900e4e133b9256e0ebea3c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"e88e65d593de170d0e726df5ad285bc85381ae0a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"import shutil"},{"line_number":29,"context_line":"import tempfile"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from ironic_lib import utils as lib_utils"},{"line_number":32,"context_line":"import netaddr"},{"line_number":33,"context_line":"from oslo_concurrency import processutils"},{"line_number":34,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_6e628c18","line":31,"in_reply_to":"3a29b11f_bf1c54c2","updated":"2015-10-26 12:20:44.000000000","message":"Ok. Will change it in next patch.","commit_id":"ffb074d1fef4ca0560900e4e133b9256e0ebea3c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a2965440de62c466aeb99a0fc0822f7633ec2f5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        env[\u0027LC_ALL\u0027] \u003d \u0027C\u0027"},{"line_number":69,"context_line":"        kwargs[\u0027env_variables\u0027] \u003d env"},{"line_number":70,"context_line":"    if kwargs.get(\u0027run_as_root\u0027) and \u0027root_helper\u0027 not in kwargs:"},{"line_number":71,"context_line":"        kwargs[\u0027root_helper\u0027] \u003d ironic_lib_utils._get_root_helper()"},{"line_number":72,"context_line":"    result \u003d processutils.execute(*cmd, **kwargs)"},{"line_number":73,"context_line":"    LOG.debug(\u0027Execution completed, command line is \"%s\"\u0027,"},{"line_number":74,"context_line":"              \u0027 \u0027.join(map(str, cmd)))"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_d3624dd8","line":71,"updated":"2015-11-09 16:09:26.000000000","message":"using private symbols (starting with _) from another library is a firm no. We should promote it to public API in ironic-lib to use it.\n\nalso I guess we should either move the whole execute() thing to ironic-lib or move rootwrap configuration back. I guess the former is easier.","commit_id":"b0b9a8623e20bc9f06bacf94d51f19853fbc7802"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"4fcc55637802b99a8d64384c04bf53435a7cb8ce","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        env[\u0027LC_ALL\u0027] \u003d \u0027C\u0027"},{"line_number":69,"context_line":"        kwargs[\u0027env_variables\u0027] \u003d env"},{"line_number":70,"context_line":"    if kwargs.get(\u0027run_as_root\u0027) and \u0027root_helper\u0027 not in kwargs:"},{"line_number":71,"context_line":"        kwargs[\u0027root_helper\u0027] \u003d ironic_lib_utils._get_root_helper()"},{"line_number":72,"context_line":"    result \u003d processutils.execute(*cmd, **kwargs)"},{"line_number":73,"context_line":"    LOG.debug(\u0027Execution completed, command line is \"%s\"\u0027,"},{"line_number":74,"context_line":"              \u0027 \u0027.join(map(str, cmd)))"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_5ff560ea","line":71,"in_reply_to":"da85f559_0e42e83e","updated":"2015-11-12 10:43:02.000000000","message":"Since concerns here is to retain rootwrap* of ironic and not to remove it, I would be changing the code again.\n\nWe can change the rootwrap/execute related code in ironic-lib, but cannot remove it completely.","commit_id":"b0b9a8623e20bc9f06bacf94d51f19853fbc7802"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"be74062aee273504d5deecb8f91ec94beaee1179","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        env[\u0027LC_ALL\u0027] \u003d \u0027C\u0027"},{"line_number":69,"context_line":"        kwargs[\u0027env_variables\u0027] \u003d env"},{"line_number":70,"context_line":"    if kwargs.get(\u0027run_as_root\u0027) and \u0027root_helper\u0027 not in kwargs:"},{"line_number":71,"context_line":"        kwargs[\u0027root_helper\u0027] \u003d ironic_lib_utils._get_root_helper()"},{"line_number":72,"context_line":"    result \u003d processutils.execute(*cmd, **kwargs)"},{"line_number":73,"context_line":"    LOG.debug(\u0027Execution completed, command line is \"%s\"\u0027,"},{"line_number":74,"context_line":"              \u0027 \u0027.join(map(str, cmd)))"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_0e42e83e","line":71,"in_reply_to":"da85f559_d3624dd8","updated":"2015-11-09 16:18:57.000000000","message":"I\u0027d prefer to leave the code in ironic alone and delete the rootwrap/execute-related code from ironic-lib.\n\nWe should look into updating oslo\u0027s execute() instead since this is a wrapper around the oslo one.","commit_id":"b0b9a8623e20bc9f06bacf94d51f19853fbc7802"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"28f7628e7bde8c0854b6433a852461451df6c3a4","unresolved":false,"context_lines":[{"line_number":77,"context_line":"CONF \u003d cfg.CONF"},{"line_number":78,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":81,"context_line":"CONF.set_default(\u0027rootwrap_helper_cmd\u0027, \u0027sudo ironic-rootwrap\u0027, \u0027ironic_lib\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_c251e1d9","line":80,"updated":"2015-10-15 15:02:40.000000000","message":"That\u0027s an odd comment. I\u0027d be more interested in knowing why we are setting the default value to \u0027sudo ironic-rootwrap\u0027.","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"55a5e62a960627bddc8fac238b19d039d034a901","unresolved":false,"context_lines":[{"line_number":77,"context_line":"CONF \u003d cfg.CONF"},{"line_number":78,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":81,"context_line":"CONF.set_default(\u0027rootwrap_helper_cmd\u0027, \u0027sudo ironic-rootwrap\u0027, \u0027ironic_lib\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_d8c13130","line":80,"in_reply_to":"5a2ca52d_c251e1d9","updated":"2015-10-19 10:14:50.000000000","message":"Please see my comments in ironic.conf.sample file.","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a2965440de62c466aeb99a0fc0822f7633ec2f5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":82,"context_line":"CONF.set_default(\u0027rootwrap_helper_cmd\u0027, \u0027sudo ironic-rootwrap\u0027, \u0027ironic_lib\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_33db997e","line":82,"updated":"2015-11-09 16:09:26.000000000","message":"why can\u0027t we do it in ironic-lib itself? you can use oslo-rootwrap IIRC","commit_id":"b0b9a8623e20bc9f06bacf94d51f19853fbc7802"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"be74062aee273504d5deecb8f91ec94beaee1179","unresolved":false,"context_lines":[{"line_number":79,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":82,"context_line":"CONF.set_default(\u0027rootwrap_helper_cmd\u0027, \u0027sudo ironic-rootwrap\u0027, \u0027ironic_lib\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_93ee058a","line":82,"in_reply_to":"da85f559_33db997e","updated":"2015-11-09 16:18:57.000000000","message":"I was in the middle of setting the default in ironic-lib (can\u0027t recall if I actually submitted the patch) when I started to think that having this in ironic-lib might not be the right thing to do.","commit_id":"b0b9a8623e20bc9f06bacf94d51f19853fbc7802"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"4fcc55637802b99a8d64384c04bf53435a7cb8ce","unresolved":false,"context_lines":[{"line_number":79,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":82,"context_line":"CONF.set_default(\u0027rootwrap_helper_cmd\u0027, \u0027sudo ironic-rootwrap\u0027, \u0027ironic_lib\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_3f341c48","line":82,"in_reply_to":"da85f559_93ee058a","updated":"2015-11-12 10:43:02.000000000","message":"I left rootwrap* config parametes in ironic_lib as empty, so that whoever uses ironic_lib to run disk partitioner code, they have to set the correct values for these config parameters. Otherwise the underlying commands (parted,etc) will run with the same user permission as that of the service(ironic/ipa).\n\nSo, I would prefer to leave this code this way. Please let me know if you want to change this code.","commit_id":"b0b9a8623e20bc9f06bacf94d51f19853fbc7802"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5863dc955bef1cfe4ea027c378901abf8692bf13","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":78,"context_line":"root_helper \u003d \u0027sudo ironic-rootwrap %s\u0027 % CONF.rootwrap_config"},{"line_number":79,"context_line":"CONF.set_default(\u0027root_helper\u0027, root_helper, \u0027ironic_lib\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba8a016a_4b8be468","line":79,"updated":"2015-11-23 16:07:48.000000000","message":"Hmm. The only problem now is that our generated ironic.conf.sample shows the default as \u003cNone\u003e.\n\nWhat if we don\u0027t expose it in ironic.conf.sample? Would that be cheating? Now I\u0027m wondering if instead of root-helper config in ironic-lib, we just had some method that allowed the setting of a global root-helper variable in ironic-lib. I\u0027m not sure how/if there is a standard way for libraries to handle such things.","commit_id":"74e295f4d6456b4b991ebfabf05d69d678b82e92"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"30df171f1ce8cb8ffc1bcc61fdd3551672242522","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":78,"context_line":"root_helper \u003d \u0027sudo ironic-rootwrap %s\u0027 % CONF.rootwrap_config"},{"line_number":79,"context_line":"CONF.set_default(\u0027root_helper\u0027, root_helper, \u0027ironic_lib\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_fed884f1","line":79,"in_reply_to":"9a8ffd7b_be00bcab","updated":"2015-11-25 01:48:13.000000000","message":"Jim and I discussed. We think that hiding root_helper config from our .sample (even though easy to do via not including it in oslo.config.generator.rc) is a hack. I am fine with his suggestion: change ironic-lib\u0027s default value for root_helper to be \u0027sudo ironic-rootwrap /etc/ironic/rootwrap.conf\u0027. we will then deprecate rootwrap_config. And handle both configs (if they are different...) until we delete rootwrap_config.\n\n[I\u0027ll think about this more tomorrow.]","commit_id":"74e295f4d6456b4b991ebfabf05d69d678b82e92"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"e8f8e265b36a597505e93621db971bfbb6ec1b09","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":78,"context_line":"root_helper \u003d \u0027sudo ironic-rootwrap %s\u0027 % CONF.rootwrap_config"},{"line_number":79,"context_line":"CONF.set_default(\u0027root_helper\u0027, root_helper, \u0027ironic_lib\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_59015369","line":79,"in_reply_to":"9a8ffd7b_fed884f1","updated":"2015-11-26 12:50:48.000000000","message":"We can hide the root_helper config from ironic, but the above code may still be required, unless the new ironic-lib 0.5.0 with default config as \"sudo ironic-rootwrap ...\" is in place.\n\nWe can add a set_default_root_helper() function in ironic-lib, to perform the above operation. I saw similar methods in some oslo libraries, like oslo_messaging, where they have provided methods to set the default values of config parameter.","commit_id":"74e295f4d6456b4b991ebfabf05d69d678b82e92"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"98abaabf56009362548f315760a99926538212c9","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":78,"context_line":"root_helper \u003d \u0027sudo ironic-rootwrap %s\u0027 % CONF.rootwrap_config"},{"line_number":79,"context_line":"CONF.set_default(\u0027root_helper\u0027, root_helper, \u0027ironic_lib\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a8ffd7b_be00bcab","line":79,"in_reply_to":"ba8a016a_4b8be468","updated":"2015-11-25 01:29:48.000000000","message":"So, right now the default for CONF.rootwrap_config is \u0027/etc/ironic/rootwrap.conf\u0027. What if we just made that the default for root_helper hardcoded to \u0027sudo ironic-rootwrap /etc/ironic/rootwrap.conf\u0027.\n\nThen if rootwrap_config is NOT the default value, we run this code to set the default accordingly. And if the user has set root_helper it will still take the user\u0027s value.","commit_id":"74e295f4d6456b4b991ebfabf05d69d678b82e92"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"12e273408d5bb96d80bd0a19689858532acaef00","unresolved":false,"context_lines":[{"line_number":74,"context_line":"CONF \u003d cfg.CONF"},{"line_number":75,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":78,"context_line":"root_helper \u003d \u0027sudo ironic-rootwrap %s\u0027 % CONF.rootwrap_config"},{"line_number":79,"context_line":"CONF.set_default(\u0027root_helper\u0027, root_helper, \u0027ironic_lib\u0027)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_855d047b","line":77,"updated":"2015-11-26 15:15:13.000000000","message":"Normally, I\u0027d say add a # TODO here, but 0.5.0 will be out soon so it should be ok; I don\u0027t think we\u0027ll forget...","commit_id":"09b6bfd2b2592d3f0d2db087059eb00144f0953f"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"eb4c5bf6d862b8425434c00e952d0a4061980a63","unresolved":false,"context_lines":[{"line_number":74,"context_line":"CONF \u003d cfg.CONF"},{"line_number":75,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":78,"context_line":"root_helper \u003d \u0027sudo ironic-rootwrap %s\u0027 % CONF.rootwrap_config"},{"line_number":79,"context_line":"CONF.set_default(\u0027root_helper\u0027, root_helper, \u0027ironic_lib\u0027)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a740942_0cdac178","line":77,"in_reply_to":"9a8ffd7b_855d047b","updated":"2015-12-07 07:43:51.000000000","message":"I am removing the below code, as we have set the default value of root_helper as \u0027sudo ironic-rootwrap /etc/ironic/rootwrap.conf\u0027.","commit_id":"09b6bfd2b2592d3f0d2db087059eb00144f0953f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34e587bf55ef0d1d82ee4c6e9c910eeee57902eb","unresolved":false,"context_lines":[{"line_number":77,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":78,"context_line":"# only if rootwrap_config does not contain the default value."},{"line_number":79,"context_line":"root_helper \u003d \u0027sudo ironic-rootwrap %s\u0027 % CONF.rootwrap_config"},{"line_number":80,"context_line":"if CONF.rootwrap_config !\u003d \u0027/etc/ironic/rootwrap.conf\u0027:"},{"line_number":81,"context_line":"    CONF.set_default(\u0027root_helper\u0027, root_helper, \u0027ironic_lib\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_808fe673","line":80,"updated":"2015-12-08 21:40:38.000000000","message":"Makes more sense to move line 79 to after this line but I guess we\u0027ll be moving it soon anyway.","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a65a46464fb1c320f220736b4a051124dbacddc6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"# only if rootwrap_config does not contain the default value."},{"line_number":79,"context_line":"root_helper \u003d \u0027sudo ironic-rootwrap %s\u0027 % CONF.rootwrap_config"},{"line_number":80,"context_line":"if CONF.rootwrap_config !\u003d \u0027/etc/ironic/rootwrap.conf\u0027:"},{"line_number":81,"context_line":"    CONF.set_default(\u0027root_helper\u0027, root_helper, \u0027ironic_lib\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_58bfc760","line":81,"updated":"2015-12-08 17:03:23.000000000","message":"Sigh. I think we should migrate to using root_helper first. Maybe in a separate patch before this one. Because this logic should be in common/utils.py, and we should mark rootwrap_config as being deprecated blah blah.","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34e587bf55ef0d1d82ee4c6e9c910eeee57902eb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"# only if rootwrap_config does not contain the default value."},{"line_number":79,"context_line":"root_helper \u003d \u0027sudo ironic-rootwrap %s\u0027 % CONF.rootwrap_config"},{"line_number":80,"context_line":"if CONF.rootwrap_config !\u003d \u0027/etc/ironic/rootwrap.conf\u0027:"},{"line_number":81,"context_line":"    CONF.set_default(\u0027root_helper\u0027, root_helper, \u0027ironic_lib\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_a0454243","line":81,"in_reply_to":"7a740942_58bfc760","updated":"2015-12-08 21:40:38.000000000","message":"I was thinking about this a bit more. I think it\u0027ll be OK to do this first as long as there is a \u0027TODO: move this logic to common/utils.py and deprecate rootwrap_config.\u0027 so that reviewers know what is going on.","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"7e2f9accd9fc43859af7c558969ab5870ea8ccbb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"# only if rootwrap_config does not contain the default value."},{"line_number":79,"context_line":"root_helper \u003d \u0027sudo ironic-rootwrap %s\u0027 % CONF.rootwrap_config"},{"line_number":80,"context_line":"if CONF.rootwrap_config !\u003d \u0027/etc/ironic/rootwrap.conf\u0027:"},{"line_number":81,"context_line":"    CONF.set_default(\u0027root_helper\u0027, root_helper, \u0027ironic_lib\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_066f83fc","line":81,"in_reply_to":"7a740942_a0454243","updated":"2015-12-09 06:17:27.000000000","message":"Sure. I will add a TODO as suggested.","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9869d0cefbecca1db84e06761596bd9ae99e7889","unresolved":false,"context_lines":[{"line_number":75,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# TODO(Faizan): Move this logic to common/utils.py and deprecate"},{"line_number":78,"context_line":"# rootwrap_config."},{"line_number":79,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":80,"context_line":"# only if rootwrap_config does not contain the default value."},{"line_number":81,"context_line":"if CONF.rootwrap_config !\u003d \u0027/etc/ironic/rootwrap.conf\u0027:"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a740942_6157aa5a","line":78,"updated":"2015-12-11 17:17:56.000000000","message":"please file a bug for this issue, describing why we did it this way and why and how it should be changed.","commit_id":"7c138f01a0085e49aab240eb2f7fc63601c348ff"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"2bd80fa399dc076b86cde562015285c5f705b4d3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# TODO(Faizan): Move this logic to common/utils.py and deprecate"},{"line_number":78,"context_line":"# rootwrap_config."},{"line_number":79,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":80,"context_line":"# only if rootwrap_config does not contain the default value."},{"line_number":81,"context_line":"if CONF.rootwrap_config !\u003d \u0027/etc/ironic/rootwrap.conf\u0027:"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a740942_d6795194","line":78,"in_reply_to":"7a740942_6157aa5a","updated":"2015-12-14 07:18:50.000000000","message":"Filed a bug https://bugs.launchpad.net/ironic/+bug/1525795.","commit_id":"7c138f01a0085e49aab240eb2f7fc63601c348ff"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9869d0cefbecca1db84e06761596bd9ae99e7889","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                                       target_iqn)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def check_file_system_for_iscsi_device(portal_address,"},{"line_number":135,"context_line":"                                       portal_port,"},{"line_number":136,"context_line":"                                       target_iqn):"},{"line_number":137,"context_line":"    \"\"\"Ensure the file system sees the iSCSI block device.\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a740942_815c167e","line":134,"updated":"2015-12-11 17:17:56.000000000","message":"what about moving this as well in the next ironic-lib release?","commit_id":"7c138f01a0085e49aab240eb2f7fc63601c348ff"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"2bd80fa399dc076b86cde562015285c5f705b4d3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                                       target_iqn)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def check_file_system_for_iscsi_device(portal_address,"},{"line_number":135,"context_line":"                                       portal_port,"},{"line_number":136,"context_line":"                                       target_iqn):"},{"line_number":137,"context_line":"    \"\"\"Ensure the file system sees the iSCSI block device.\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a740942_76f17d00","line":134,"in_reply_to":"7a740942_815c167e","updated":"2015-12-14 07:18:50.000000000","message":"We can move this as well.\nAnyway we have to make some addition to ironic-lib, to differentiate between an iscsi device and local device, to use ironic-lib in ipa.\nWe can take this refactoring at that time.","commit_id":"7c138f01a0085e49aab240eb2f7fc63601c348ff"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9869d0cefbecca1db84e06761596bd9ae99e7889","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def verify_iscsi_connection(target_iqn):"},{"line_number":158,"context_line":"    \"\"\"Verify iscsi connection.\"\"\""},{"line_number":159,"context_line":"    LOG.debug(\"Checking for iSCSI target to become active.\")"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a740942_2156825c","line":157,"updated":"2015-12-11 17:17:56.000000000","message":"ditto","commit_id":"7c138f01a0085e49aab240eb2f7fc63601c348ff"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a8172e185eaf044b199b2f091fc6391717503fc8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"CONF.register_opts(pxe_opts, group\u003d\u0027pxe\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":84,"context_line":"CONF.set_default(\u0027rootwrap_helper_cmd\u0027, \u0027sudo ironic-rootwrap\u0027, \u0027ironic_lib\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"DISK_LAYOUT_PARAMS \u003d (\u0027root_gb\u0027, \u0027swap_mb\u0027, \u0027ephemeral_gb\u0027)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_fe47c0b9","line":84,"updated":"2015-10-08 12:36:32.000000000","message":"This is already set in deploy_utils.py.","commit_id":"717e57a49f146ad0cb1398a083756d471582a7a4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"e971483dd01618043fe7a4eaa34c912a01ddcd1d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"CONF.register_opts(pxe_opts, group\u003d\u0027pxe\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":84,"context_line":"CONF.set_default(\u0027rootwrap_helper_cmd\u0027, \u0027sudo ironic-rootwrap\u0027, \u0027ironic_lib\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"DISK_LAYOUT_PARAMS \u003d (\u0027root_gb\u0027, \u0027swap_mb\u0027, \u0027ephemeral_gb\u0027)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_25b5ea7c","line":84,"in_reply_to":"7a2fa921_fe47c0b9","updated":"2015-10-09 12:50:41.000000000","message":"I have included this statement here, because we are importing disk_utils in this file also. Just to make sure that when any api from disk_utils is called, the ironic_lib option has got the default values.\n\nI would like to keep them in both the places.","commit_id":"717e57a49f146ad0cb1398a083756d471582a7a4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"28f7628e7bde8c0854b6433a852461451df6c3a4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":38,"context_line":"from ironic.drivers.modules import image_cache"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"from ironic_lib import disk_utils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_3d8798d8","line":40,"updated":"2015-10-15 15:02:40.000000000","message":"since this is a library, it should be above line 17","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"55a5e62a960627bddc8fac238b19d039d034a901","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":38,"context_line":"from ironic.drivers.modules import image_cache"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"from ironic_lib import disk_utils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_58ec41c7","line":40,"in_reply_to":"5a2ca52d_3d8798d8","updated":"2015-10-19 10:14:50.000000000","message":"Done","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"28f7628e7bde8c0854b6433a852461451df6c3a4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"CONF.register_opts(pxe_opts, group\u003d\u0027pxe\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":84,"context_line":"CONF.set_default(\u0027rootwrap_helper_cmd\u0027, \u0027sudo ironic-rootwrap\u0027, \u0027ironic_lib\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"DISK_LAYOUT_PARAMS \u003d (\u0027root_gb\u0027, \u0027swap_mb\u0027, \u0027ephemeral_gb\u0027)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_fde36003","line":84,"updated":"2015-10-15 15:02:40.000000000","message":"I don\u0027t like that we are setting the default for the same config in two different files.","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"55a5e62a960627bddc8fac238b19d039d034a901","unresolved":false,"context_lines":[{"line_number":81,"context_line":"CONF.register_opts(pxe_opts, group\u003d\u0027pxe\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# This is required to set the default value of ironic_lib option"},{"line_number":84,"context_line":"CONF.set_default(\u0027rootwrap_helper_cmd\u0027, \u0027sudo ironic-rootwrap\u0027, \u0027ironic_lib\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"DISK_LAYOUT_PARAMS \u003d (\u0027root_gb\u0027, \u0027swap_mb\u0027, \u0027ephemeral_gb\u0027)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_38fe256c","line":84,"in_reply_to":"5a2ca52d_fde36003","updated":"2015-10-19 10:14:50.000000000","message":"We can remove this from here, as we are importing deploy_utils in this file.\n\nI will remove it from this place.","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"}],"ironic/tests/base.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"da938dca360f51045dd7b9840baf916e1a120a30","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import eventlet"},{"line_number":30,"context_line":"eventlet.monkey_patch(os\u003dFalse)"},{"line_number":31,"context_line":"import fixtures"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from oslo_config import cfg"},{"line_number":34,"context_line":"from oslo_context import context as ironic_context"},{"line_number":35,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_bf73f414","line":32,"updated":"2015-10-26 08:57:44.000000000","message":"newline not required.","commit_id":"ffb074d1fef4ca0560900e4e133b9256e0ebea3c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"e88e65d593de170d0e726df5ad285bc85381ae0a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import eventlet"},{"line_number":30,"context_line":"eventlet.monkey_patch(os\u003dFalse)"},{"line_number":31,"context_line":"import fixtures"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from oslo_config import cfg"},{"line_number":34,"context_line":"from oslo_context import context as ironic_context"},{"line_number":35,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a29b11f_4eba3070","line":32,"in_reply_to":"3a29b11f_bf73f414","updated":"2015-10-26 12:20:44.000000000","message":"ok. Will remove it in next patch.","commit_id":"ffb074d1fef4ca0560900e4e133b9256e0ebea3c"}],"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"28f7628e7bde8c0854b6433a852461451df6c3a4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"DRV_INTERNAL_INFO_DICT \u003d db_utils.get_test_pxe_driver_internal_info()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"from ironic_lib import disk_utils"},{"line_number":50,"context_line":"from ironic_lib import utils as lib_utils"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"_PXECONF_DEPLOY \u003d b\"\"\""},{"line_number":53,"context_line":"default deploy"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_fdd7e0bc","line":50,"updated":"2015-10-15 15:02:40.000000000","message":"these should be above the oslo* ones.","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"55a5e62a960627bddc8fac238b19d039d034a901","unresolved":false,"context_lines":[{"line_number":47,"context_line":"DRV_INTERNAL_INFO_DICT \u003d db_utils.get_test_pxe_driver_internal_info()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"from ironic_lib import disk_utils"},{"line_number":50,"context_line":"from ironic_lib import utils as lib_utils"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"_PXECONF_DEPLOY \u003d b\"\"\""},{"line_number":53,"context_line":"default deploy"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_b8f23599","line":50,"in_reply_to":"5a2ca52d_fdd7e0bc","updated":"2015-10-19 10:14:50.000000000","message":"Done","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"065e6379c7ea1a8bb658fd417b55865903f66bf5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2012 NTT DOCOMO, INC.utils"},{"line_number":2,"context_line":"#    Copyright 2011 OpenStack Foundation"},{"line_number":3,"context_line":"#    Copyright 2011 Ilya Alekseyev"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_64606b36","line":1,"updated":"2015-10-19 14:39:39.000000000","message":"where did the \u0027utils\u0027 come from?","commit_id":"c3a2b042cf887ab6d0b89b7995881772b55f0a3c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"458783db68953fdcf112c6910c4bdc2554b1f082","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright (c) 2012 NTT DOCOMO, INC.utils"},{"line_number":2,"context_line":"#    Copyright 2011 OpenStack Foundation"},{"line_number":3,"context_line":"#    Copyright 2011 Ilya Alekseyev"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_d7a8ecdd","line":1,"in_reply_to":"3a29b11f_64606b36","updated":"2015-10-20 06:12:33.000000000","message":"Did not notice this change. Will remove it in my next patch.","commit_id":"c3a2b042cf887ab6d0b89b7995881772b55f0a3c"}],"ironic/tests/unit/drivers/modules/test_iscsi_deploy.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"28f7628e7bde8c0854b6433a852461451df6c3a4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from ironic.tests.unit.db import utils as db_utils"},{"line_number":43,"context_line":"from ironic.tests.unit.objects import utils as obj_utils"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"from ironic_lib import disk_utils"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"CONF \u003d cfg.CONF"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_dd26a4cd","line":45,"updated":"2015-10-15 15:02:40.000000000","message":"this should be above the mock one.","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"55a5e62a960627bddc8fac238b19d039d034a901","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from ironic.tests.unit.db import utils as db_utils"},{"line_number":43,"context_line":"from ironic.tests.unit.objects import utils as obj_utils"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"from ironic_lib import disk_utils"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"CONF \u003d cfg.CONF"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_98309958","line":45,"in_reply_to":"5a2ca52d_dd26a4cd","updated":"2015-10-19 10:14:50.000000000","message":"Done","commit_id":"1bc72bb43b03b43eca96250f0bbee2721a16d8f4"}],"releasenotes/notes/refactor-ironic-lib-22939896d8d46a77.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a65a46464fb1c320f220736b4a051124dbacddc6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    The disk partitioner related code from"},{"line_number":4,"context_line":"    ironic/common/disk_partitioner.py and"},{"line_number":5,"context_line":"    ironic/drivers/modules/deploy_utils.py were"},{"line_number":6,"context_line":"    replaced with ironic-lib."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - Add new configuration options from ironic-lib."},{"line_number":9,"context_line":"    [ironic_lib]root_helper, to specify the command that"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_8dc2cfe7","line":6,"updated":"2015-12-08 17:03:23.000000000","message":"Based on the existing release notes, I think this belongs under \u0027other\u0027 because it is a refactoring; it isn\u0027t a bug fix or a new feature.\n\nAlso, it should be more general (no need to mention files). eg, \u0027Code related to disk partitioning was moved to ironic-lib\u0027.","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"7e2f9accd9fc43859af7c558969ab5870ea8ccbb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    The disk partitioner related code from"},{"line_number":4,"context_line":"    ironic/common/disk_partitioner.py and"},{"line_number":5,"context_line":"    ironic/drivers/modules/deploy_utils.py were"},{"line_number":6,"context_line":"    replaced with ironic-lib."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - Add new configuration options from ironic-lib."},{"line_number":9,"context_line":"    [ironic_lib]root_helper, to specify the command that"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_4be4b3aa","line":6,"in_reply_to":"7a740942_8dc2cfe7","updated":"2015-12-09 06:17:27.000000000","message":"Done","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a65a46464fb1c320f220736b4a051124dbacddc6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ironic/drivers/modules/deploy_utils.py were"},{"line_number":6,"context_line":"    replaced with ironic-lib."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - Add new configuration options from ironic-lib."},{"line_number":9,"context_line":"    [ironic_lib]root_helper, to specify the command that"},{"line_number":10,"context_line":"    is prefixed to commands that are run as root."},{"line_number":11,"context_line":"    [disk_utils]efi_system_partition_size, dd_block_size"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_78e3a3d9","line":8,"updated":"2015-12-08 17:03:23.000000000","message":"s/Add/Adds/\n\ns/from ironic-lib//","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34e587bf55ef0d1d82ee4c6e9c910eeee57902eb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    [ironic_lib]root_helper, to specify the command that"},{"line_number":10,"context_line":"    is prefixed to commands that are run as root."},{"line_number":11,"context_line":"    [disk_utils]efi_system_partition_size, dd_block_size"},{"line_number":12,"context_line":"    and iscsi_verify_attempts."},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - The following configuration options from deploy"},{"line_number":15,"context_line":"    group is deprecated."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_0098d668","line":12,"updated":"2015-12-08 21:40:38.000000000","message":"Ok, instead of the above how about\n\n\u0027Adds new configuration option [ironic_lib]root_helper, to specify the command that is prefixed to commands that are run as root. Defaults to using the rootwrap config file at /etc/ironic/rootwrap.conf. \n\nMoves these configuration options from [deploy] group to the new [disk_utils] group: efi_system_partition_size, dd_block_size and iscsi_verify_attempts.\u0027","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"7e2f9accd9fc43859af7c558969ab5870ea8ccbb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    [ironic_lib]root_helper, to specify the command that"},{"line_number":10,"context_line":"    is prefixed to commands that are run as root."},{"line_number":11,"context_line":"    [disk_utils]efi_system_partition_size, dd_block_size"},{"line_number":12,"context_line":"    and iscsi_verify_attempts."},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - The following configuration options from deploy"},{"line_number":15,"context_line":"    group is deprecated."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_abd997f4","line":12,"in_reply_to":"7a740942_0098d668","updated":"2015-12-09 06:17:27.000000000","message":"Done","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a65a46464fb1c320f220736b4a051124dbacddc6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    and iscsi_verify_attempts."},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - The following configuration options from deploy"},{"line_number":15,"context_line":"    group is deprecated."},{"line_number":16,"context_line":"    [deploy]efi_system_partition_size, dd_block_size and"},{"line_number":17,"context_line":"    iscsi_verify_attempts."},{"line_number":18,"context_line":"    These configuration options have been moved to ironic-lib\u0027s"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_583a679a","line":15,"updated":"2015-12-08 17:03:23.000000000","message":"s/is/are/\n\ns/deprecated./deprecated:/\n\nInstead of the last sentence below at line 18, I think we can combine it with this sentence. eg:\n\n\u0027The following configuration options have been moved to the [disk_utils] group; they are deprecated from the [deploy] group: efi_system_partition_size, dd_block_size, and iscsi_verify_attempts.","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"7e2f9accd9fc43859af7c558969ab5870ea8ccbb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    and iscsi_verify_attempts."},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - The following configuration options from deploy"},{"line_number":15,"context_line":"    group is deprecated."},{"line_number":16,"context_line":"    [deploy]efi_system_partition_size, dd_block_size and"},{"line_number":17,"context_line":"    iscsi_verify_attempts."},{"line_number":18,"context_line":"    These configuration options have been moved to ironic-lib\u0027s"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_8bde1bdb","line":15,"in_reply_to":"7a740942_583a679a","updated":"2015-12-09 06:17:27.000000000","message":"Done","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a65a46464fb1c320f220736b4a051124dbacddc6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    [deploy]efi_system_partition_size, dd_block_size and"},{"line_number":17,"context_line":"    iscsi_verify_attempts."},{"line_number":18,"context_line":"    These configuration options have been moved to ironic-lib\u0027s"},{"line_number":19,"context_line":"    disk_utils group."},{"line_number":20,"context_line":"  - rootwrap_config is marked for deprecation. It will be"},{"line_number":21,"context_line":"    replaced by [ironic_lib]root_helper in future."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_b866ebb8","line":19,"updated":"2015-12-08 17:03:23.000000000","message":"I don\u0027t think we need to mention ironic-lib.","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a65a46464fb1c320f220736b4a051124dbacddc6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    iscsi_verify_attempts."},{"line_number":18,"context_line":"    These configuration options have been moved to ironic-lib\u0027s"},{"line_number":19,"context_line":"    disk_utils group."},{"line_number":20,"context_line":"  - rootwrap_config is marked for deprecation. It will be"},{"line_number":21,"context_line":"    replaced by [ironic_lib]root_helper in future."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_18a4df05","line":20,"updated":"2015-12-08 17:03:23.000000000","message":"what\u0027s the diff between \u0027is deprecated\u0027 and \u0027marked for deprecation\u0027?","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34e587bf55ef0d1d82ee4c6e9c910eeee57902eb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    These configuration options have been moved to ironic-lib\u0027s"},{"line_number":19,"context_line":"    disk_utils group."},{"line_number":20,"context_line":"  - rootwrap_config is marked for deprecation. It will be"},{"line_number":21,"context_line":"    replaced by [ironic_lib]root_helper in future."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_00af767d","line":21,"updated":"2015-12-08 21:40:38.000000000","message":"Maybe delete the rootwrap_config part -- it will be mentioned in a follow on patch that actually deprecates it.","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"7e2f9accd9fc43859af7c558969ab5870ea8ccbb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    These configuration options have been moved to ironic-lib\u0027s"},{"line_number":19,"context_line":"    disk_utils group."},{"line_number":20,"context_line":"  - rootwrap_config is marked for deprecation. It will be"},{"line_number":21,"context_line":"    replaced by [ironic_lib]root_helper in future."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a740942_ebd23fd0","line":21,"in_reply_to":"7a740942_00af767d","updated":"2015-12-09 06:17:27.000000000","message":"Done","commit_id":"76f1005e4adeb0df203d14de69c18387e48ff314"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd612e07fd5e2164295e9c5816369c9f091652bd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Adds new configuration [ironic_lib]root_helper, to specify"},{"line_number":4,"context_line":"    the command that is prefixed to commands that are run as root."},{"line_number":5,"context_line":"    Defaults to using the rootwrap config file at "},{"line_number":6,"context_line":"    /etc/ironic/rootwrap.conf."},{"line_number":7,"context_line":"  - Moves these configuration options from [deploy] group to the"},{"line_number":8,"context_line":"    new [disk_utils] group; efi_system_partition_size, dd_block_size"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a740942_dfd4c4be","line":5,"updated":"2015-12-09 15:23:48.000000000","message":"nit: blank space at the end","commit_id":"f865b3a5d54f4d9b2216daad68873699b2dcab37"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"f0dd6126a3b8b1fd717c3c7c1ea412ef177a69db","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Adds new configuration [ironic_lib]root_helper, to specify"},{"line_number":4,"context_line":"    the command that is prefixed to commands that are run as root."},{"line_number":5,"context_line":"    Defaults to using the rootwrap config file at "},{"line_number":6,"context_line":"    /etc/ironic/rootwrap.conf."},{"line_number":7,"context_line":"  - Moves these configuration options from [deploy] group to the"},{"line_number":8,"context_line":"    new [disk_utils] group; efi_system_partition_size, dd_block_size"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a740942_5e62f617","line":5,"in_reply_to":"7a740942_dfd4c4be","updated":"2015-12-10 05:32:48.000000000","message":"Done","commit_id":"f865b3a5d54f4d9b2216daad68873699b2dcab37"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd612e07fd5e2164295e9c5816369c9f091652bd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Defaults to using the rootwrap config file at "},{"line_number":6,"context_line":"    /etc/ironic/rootwrap.conf."},{"line_number":7,"context_line":"  - Moves these configuration options from [deploy] group to the"},{"line_number":8,"context_line":"    new [disk_utils] group; efi_system_partition_size, dd_block_size"},{"line_number":9,"context_line":"    and iscsi_verify_attempts."},{"line_number":10,"context_line":"deprecations:"},{"line_number":11,"context_line":"  - The following configuration options have been moved to"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a740942_5fe1b499","line":8,"updated":"2015-12-09 15:23:48.000000000","message":"nit: s/;/:/","commit_id":"f865b3a5d54f4d9b2216daad68873699b2dcab37"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"f0dd6126a3b8b1fd717c3c7c1ea412ef177a69db","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Defaults to using the rootwrap config file at "},{"line_number":6,"context_line":"    /etc/ironic/rootwrap.conf."},{"line_number":7,"context_line":"  - Moves these configuration options from [deploy] group to the"},{"line_number":8,"context_line":"    new [disk_utils] group; efi_system_partition_size, dd_block_size"},{"line_number":9,"context_line":"    and iscsi_verify_attempts."},{"line_number":10,"context_line":"deprecations:"},{"line_number":11,"context_line":"  - The following configuration options have been moved to"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a740942_636f1693","line":8,"in_reply_to":"7a740942_5fe1b499","updated":"2015-12-10 05:32:48.000000000","message":"Done. \n\nyaml parser had thrown up error earlier for \":\" in the text. \n\nNeed to add \"|\" at the beginning of the bullet item to retain the structure and avoid yaml parser.","commit_id":"f865b3a5d54f4d9b2216daad68873699b2dcab37"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd612e07fd5e2164295e9c5816369c9f091652bd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"deprecations:"},{"line_number":11,"context_line":"  - The following configuration options have been moved to"},{"line_number":12,"context_line":"    the [disk_utils] group; they are deprecated from the"},{"line_number":13,"context_line":"    [deploy] group; efi_system_partition_size, dd_block_size and"},{"line_number":14,"context_line":"    iscsi_verify_attempts."},{"line_number":15,"context_line":"othre:"},{"line_number":16,"context_line":"  - Code related to disk partitioning was moved to"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a740942_7f011039","line":13,"updated":"2015-12-09 15:23:48.000000000","message":"nit: s/;/:/","commit_id":"f865b3a5d54f4d9b2216daad68873699b2dcab37"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"f0dd6126a3b8b1fd717c3c7c1ea412ef177a69db","unresolved":false,"context_lines":[{"line_number":10,"context_line":"deprecations:"},{"line_number":11,"context_line":"  - The following configuration options have been moved to"},{"line_number":12,"context_line":"    the [disk_utils] group; they are deprecated from the"},{"line_number":13,"context_line":"    [deploy] group; efi_system_partition_size, dd_block_size and"},{"line_number":14,"context_line":"    iscsi_verify_attempts."},{"line_number":15,"context_line":"othre:"},{"line_number":16,"context_line":"  - Code related to disk partitioning was moved to"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a740942_c304cac7","line":13,"in_reply_to":"7a740942_7f011039","updated":"2015-12-10 05:32:48.000000000","message":"Done","commit_id":"f865b3a5d54f4d9b2216daad68873699b2dcab37"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd612e07fd5e2164295e9c5816369c9f091652bd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    the [disk_utils] group; they are deprecated from the"},{"line_number":13,"context_line":"    [deploy] group; efi_system_partition_size, dd_block_size and"},{"line_number":14,"context_line":"    iscsi_verify_attempts."},{"line_number":15,"context_line":"othre:"},{"line_number":16,"context_line":"  - Code related to disk partitioning was moved to"},{"line_number":17,"context_line":"    ironic-lib."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a740942_ff93c0fe","line":15,"updated":"2015-12-09 15:23:48.000000000","message":"s/othre/other/","commit_id":"f865b3a5d54f4d9b2216daad68873699b2dcab37"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"f0dd6126a3b8b1fd717c3c7c1ea412ef177a69db","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    the [disk_utils] group; they are deprecated from the"},{"line_number":13,"context_line":"    [deploy] group; efi_system_partition_size, dd_block_size and"},{"line_number":14,"context_line":"    iscsi_verify_attempts."},{"line_number":15,"context_line":"othre:"},{"line_number":16,"context_line":"  - Code related to disk partitioning was moved to"},{"line_number":17,"context_line":"    ironic-lib."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a740942_830ec2e3","line":15,"in_reply_to":"7a740942_ff93c0fe","updated":"2015-12-10 05:32:48.000000000","message":"Done","commit_id":"f865b3a5d54f4d9b2216daad68873699b2dcab37"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9869d0cefbecca1db84e06761596bd9ae99e7889","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Moves these configuration options from [deploy] group to the"},{"line_number":10,"context_line":"    new [disk_utils] group: efi_system_partition_size, dd_block_size"},{"line_number":11,"context_line":"    and iscsi_verify_attempts."},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    The following configuration options have been moved to"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7a740942_41538e6b","line":11,"updated":"2015-12-11 17:17:56.000000000","message":"maybe worth mentioning ironic-lib as a new dependency","commit_id":"7c138f01a0085e49aab240eb2f7fc63601c348ff"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"2bd80fa399dc076b86cde562015285c5f705b4d3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Moves these configuration options from [deploy] group to the"},{"line_number":10,"context_line":"    new [disk_utils] group: efi_system_partition_size, dd_block_size"},{"line_number":11,"context_line":"    and iscsi_verify_attempts."},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    The following configuration options have been moved to"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7a740942_36c77597","line":11,"in_reply_to":"7a740942_41538e6b","updated":"2015-12-14 07:18:50.000000000","message":"Is it possible to add this information in subsequent patch?","commit_id":"7c138f01a0085e49aab240eb2f7fc63601c348ff"}],"requirements.txt":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5863dc955bef1cfe4ea027c378901abf8692bf13","unresolved":false,"context_lines":[{"line_number":14,"context_line":"python-neutronclient\u003e\u003d2.6.0"},{"line_number":15,"context_line":"python-glanceclient\u003e\u003d0.18.0"},{"line_number":16,"context_line":"python-keystoneclient!\u003d1.8.0,\u003e\u003d1.6.0"},{"line_number":17,"context_line":"ironic-lib\u003e\u003d0.3.0"},{"line_number":18,"context_line":"python-swiftclient\u003e\u003d2.2.0"},{"line_number":19,"context_line":"pytz\u003e\u003d2013.6"},{"line_number":20,"context_line":"stevedore\u003e\u003d1.5.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":13,"id":"ba8a016a_ab57f0c8","line":17,"updated":"2015-11-23 16:07:48.000000000","message":"this needs to be 0.4.0 now. The library has been released; guess we need to up it in global requirements.","commit_id":"74e295f4d6456b4b991ebfabf05d69d678b82e92"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"e8f8e265b36a597505e93621db971bfbb6ec1b09","unresolved":false,"context_lines":[{"line_number":14,"context_line":"python-neutronclient\u003e\u003d2.6.0"},{"line_number":15,"context_line":"python-glanceclient\u003e\u003d0.18.0"},{"line_number":16,"context_line":"python-keystoneclient!\u003d1.8.0,\u003e\u003d1.6.0"},{"line_number":17,"context_line":"ironic-lib\u003e\u003d0.3.0"},{"line_number":18,"context_line":"python-swiftclient\u003e\u003d2.2.0"},{"line_number":19,"context_line":"pytz\u003e\u003d2013.6"},{"line_number":20,"context_line":"stevedore\u003e\u003d1.5.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":13,"id":"9a8ffd7b_f94127aa","line":17,"in_reply_to":"ba8a016a_ab57f0c8","updated":"2015-11-26 12:50:48.000000000","message":"Done","commit_id":"74e295f4d6456b4b991ebfabf05d69d678b82e92"}],"tools/config/oslo.config.generator.rc":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5059a8b6e45170732d448907d4f4d0ea51775648","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export IRONIC_CONFIG_GENERATOR_EXTRA_LIBRARIES\u003d\u0027oslo.db oslo.messaging oslo.middleware.cors keystonemiddleware.auth_token oslo.concurrency oslo.policy oslo.log oslo.service.service oslo.service.periodic_task\u0027"},{"line_number":2,"context_line":"export IRONIC_CONFIG_GENERATOR_EXTRA_MODULES\u003d\u0027ironic_lib.disk_utils ironic_lib.utils ironic_lib.disk_partitioner\u0027"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3a29b11f_35034611","line":2,"updated":"2015-10-20 13:43:39.000000000","message":"the only other module missing is exception. Do you know why exception is in ironic-lib and were you going to change ironic to use ironic-lib\u0027s exception?","commit_id":"5a9b5b85fe46c810b864f7c5f8be57a15138468a"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"7f5bac6194e48d4253b5943448c8fbe5dba600ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export IRONIC_CONFIG_GENERATOR_EXTRA_LIBRARIES\u003d\u0027oslo.db oslo.messaging oslo.middleware.cors keystonemiddleware.auth_token oslo.concurrency oslo.policy oslo.log oslo.service.service oslo.service.periodic_task\u0027"},{"line_number":2,"context_line":"export IRONIC_CONFIG_GENERATOR_EXTRA_MODULES\u003d\u0027ironic_lib.disk_utils ironic_lib.utils ironic_lib.disk_partitioner\u0027"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3a29b11f_44eab3ad","line":2,"in_reply_to":"3a29b11f_35034611","updated":"2015-10-21 12:37:18.000000000","message":"There were some disk_partitioner related exceptions defined in ironic, so I moved only the disk related exceptions to this module. This exception module is currently used with-in ironic-lib. I dont think we have any instance where it is require to use these exceptions in ironic. So we will not require to change ironic to use ironic-lib\u0027s exception, unless it is required by future functionalities in ironic.","commit_id":"5a9b5b85fe46c810b864f7c5f8be57a15138468a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"da938dca360f51045dd7b9840baf916e1a120a30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export IRONIC_CONFIG_GENERATOR_EXTRA_LIBRARIES\u003d\u0027oslo.db oslo.messaging oslo.middleware.cors keystonemiddleware.auth_token oslo.concurrency oslo.policy oslo.log oslo.service.service oslo.service.periodic_task\u0027"},{"line_number":2,"context_line":"export IRONIC_CONFIG_GENERATOR_EXTRA_MODULES\u003d\u0027ironic_lib.disk_utils ironic_lib.utils ironic_lib.disk_partitioner\u0027"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a29b11f_cda96d26","line":2,"updated":"2015-10-26 08:57:44.000000000","message":"Shouldn\u0027t this be above in IRONIC_CONFIG_GENERATOR_EXTRA_LIBRARIES ? I think then we need to give just ironic-lib. This is hard to maintain when we add one more file in ironic-lib, we will have to change this rc file.","commit_id":"ffb074d1fef4ca0560900e4e133b9256e0ebea3c"},{"author":{"_account_id":10574,"name":"Syed Ismail Faizan Barmawer","email":"faizan.barmawer@gmail.com","username":"barmawer"},"change_message_id":"e88e65d593de170d0e726df5ad285bc85381ae0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export IRONIC_CONFIG_GENERATOR_EXTRA_LIBRARIES\u003d\u0027oslo.db oslo.messaging oslo.middleware.cors keystonemiddleware.auth_token oslo.concurrency oslo.policy oslo.log oslo.service.service oslo.service.periodic_task\u0027"},{"line_number":2,"context_line":"export IRONIC_CONFIG_GENERATOR_EXTRA_MODULES\u003d\u0027ironic_lib.disk_utils ironic_lib.utils ironic_lib.disk_partitioner\u0027"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a29b11f_8ec048e2","line":2,"in_reply_to":"3a29b11f_cda96d26","updated":"2015-10-26 12:20:44.000000000","message":"I tried your suggestion. It did not work.","commit_id":"ffb074d1fef4ca0560900e4e133b9256e0ebea3c"}]}
