)]}'
{"ironic/common/context.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"b8b75ccb036e3be8409e198b22e79d73b12a82f3","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_admin_context(show_deleted\u003dFalse):"},{"line_number":76,"context_line":"    \"\"\"Create an administrator context.\"\"\""},{"line_number":77,"context_line":"    context \u003d RequestContext(None,"},{"line_number":78,"context_line":"                             tenant\u003dNone,"},{"line_number":79,"context_line":"                             is_admin\u003dTrue,"},{"line_number":80,"context_line":"                             show_deleted\u003dshow_deleted)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_cfe30ad8","line":77,"updated":"2015-05-22 01:31:37.000000000","message":"you mean auth_token \u003d None or user\u003dNone here? please specify the key, and since all parameters have a default value, seems you can only pass parameters with non default value.","commit_id":"1705e16cffdcd20b620ea35573891b29c6c0879c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6defeb27f64853897dabe58a36ea0c67be087dff","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_admin_context(show_deleted\u003dFalse):"},{"line_number":76,"context_line":"    \"\"\"Create an administrator context.\"\"\""},{"line_number":77,"context_line":"    context \u003d RequestContext(None,"},{"line_number":78,"context_line":"                             tenant\u003dNone,"},{"line_number":79,"context_line":"                             is_admin\u003dTrue,"},{"line_number":80,"context_line":"                             show_deleted\u003dshow_deleted)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_45b3524d","line":77,"in_reply_to":"7a016987_cfe30ad8","updated":"2015-05-25 07:53:11.000000000","message":"This is setting auth_token\u003dNone since that\u0027s the first parameter specified in the RequestContext init.\n\nBut yeah, I\u0027m +1 on making the key explicit here. it\u0027s confusing cause both auth_token and tenant already defaults to None. So I imagine this is like a safe guard around it in case the RequestContext class change its default values?\n\nAnother thing, on the previous code we were passing auth_token\u003d\"admin\" and user\u003d\"admin\"[1][2], is it OK to not pass it anymore?\n\n[1] https://github.com/openstack/oslo.context/blob/master/oslo_context/context.py#L45\n\n[2] (snippet from service.py) admin_context \u003d context.RequestContext(\u0027admin\u0027, \u0027admin\u0027, is_admin\u003dTrue)","commit_id":"1705e16cffdcd20b620ea35573891b29c6c0879c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"e0f4d2c32f5761d6d0bfe1691ef7c7e2cecff81a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                 user\u003dNone, tenant\u003dNone, is_admin\u003dFalse, is_public_api\u003dFalse,"},{"line_number":23,"context_line":"                 read_only\u003dFalse, show_deleted\u003dFalse, request_id\u003dNone,"},{"line_number":24,"context_line":"                 roles\u003dNone, show_password\u003dTrue, user_name\u003dNone,"},{"line_number":25,"context_line":"                 project_name\u003dNone):        "},{"line_number":26,"context_line":"        \"\"\"Stores several additional request parameters:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        :param domain_id: The ID of the domain."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_77ae052f","line":25,"updated":"2015-05-25 09:13:10.000000000","message":"please remove the trailing whitespace.","commit_id":"463fccef2b423c8c40ca00dc6be24ef470da7b61"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"36f5a77b6024b716bf311d90bc4742e198d2ddd6","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_admin_context(show_deleted\u003dFalse):"},{"line_number":76,"context_line":"    \"\"\"Create an administrator context.\"\"\""},{"line_number":77,"context_line":"    context \u003d RequestContext(auth_token\u003d\u0027admin\u0027,"},{"line_number":78,"context_line":"                             user\u003d\u0027admin\u0027,"},{"line_number":79,"context_line":"                             is_admin\u003dTrue,"},{"line_number":80,"context_line":"                             show_deleted\u003dshow_deleted)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_bab584ed","line":77,"updated":"2015-05-25 09:28:22.000000000","message":"It seems to me that it should be user\u003d\u0027admin\u0027 and tenant\u003d\u0027admin\u0027, as auth_token should be a token. Maybe it worked before because of is_admin\u003dTrue.","commit_id":"29879304baafc250ac166ee803fa7db49fcf15e2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fb0c1faea6a61caed94e4cb74f9b8f5da55130b3","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_admin_context(show_deleted\u003dFalse):"},{"line_number":76,"context_line":"    \"\"\"Create an administrator context.\"\"\""},{"line_number":77,"context_line":"    context \u003d RequestContext(auth_token\u003d\u0027admin\u0027,"},{"line_number":78,"context_line":"                             user\u003d\u0027admin\u0027,"},{"line_number":79,"context_line":"                             is_admin\u003dTrue,"},{"line_number":80,"context_line":"                             show_deleted\u003dshow_deleted)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_ad5b0c85","line":77,"updated":"2015-05-25 10:06:31.000000000","message":"This is context for \"internal\" usage, and we must have auth_token\u003dNone here, because a fake token here can broke our code, this fake token and Keystone token cannot be distinguished.","commit_id":"29879304baafc250ac166ee803fa7db49fcf15e2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f770c1341462a531bde621f6e82db0813100fb16","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_admin_context(show_deleted\u003dFalse):"},{"line_number":76,"context_line":"    \"\"\"Create an administrator context.\"\"\""},{"line_number":77,"context_line":"    context \u003d RequestContext(auth_token\u003d\u0027admin\u0027,"},{"line_number":78,"context_line":"                             user\u003d\u0027admin\u0027,"},{"line_number":79,"context_line":"                             is_admin\u003dTrue,"},{"line_number":80,"context_line":"                             show_deleted\u003dshow_deleted)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_adb78c83","line":77,"in_reply_to":"7a016987_ad5b0c85","updated":"2015-05-25 10:13:21.000000000","message":"Example of code: line 355 https://review.openstack.org/#/c/151958/19/ironic/drivers/modules/irmc/deploy.py","commit_id":"29879304baafc250ac166ee803fa7db49fcf15e2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"d116ca5659eda66667be45dd6535b61a9ab7a57c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    def __init__(self, auth_token\u003dNone, domain_id\u003dNone, domain_name\u003dNone,"},{"line_number":22,"context_line":"                 user\u003dNone, tenant\u003dNone, is_admin\u003dFalse, is_public_api\u003dFalse,"},{"line_number":23,"context_line":"                 read_only\u003dFalse, show_deleted\u003dFalse, request_id\u003dNone,"},{"line_number":24,"context_line":"                 roles\u003dNone, show_password\u003dTrue, user_name\u003dNone,"},{"line_number":25,"context_line":"                 project_name\u003dNone):"},{"line_number":26,"context_line":"        \"\"\"Stores several additional request parameters:"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_01641947","line":24,"updated":"2015-05-26 05:16:03.000000000","message":"Can we add them to docstring below ? What is user_name and project_name supposed to contain ? Are they same as user and tenant ? \n\nWhy is oslo.context.RequestContext not fixed yet if oslo_log uses them ?","commit_id":"4c9ffc3147375a038e467bd8ee9a7d819f46d78c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"775abd6568e482f0823916e14907219ba4496ba6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_context import context"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class RequestContext(context.RequestContext):"},{"line_number":19,"context_line":"    \"\"\"Extends security contexts from the OpenStack common library.\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def __init__(self, auth_token\u003dNone, domain_id\u003dNone, domain_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_1bb3faea","line":18,"updated":"2015-05-28 14:38:37.000000000","message":"Why can\u0027t this fix be done in oslo.context?\nI\u0027d prefer we drop our implementation instead of diverging even more...","commit_id":"98f5ad828637bda98f20d0de68ee7716ca837dc1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"775abd6568e482f0823916e14907219ba4496ba6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        :param show_password: Specifies whether passwords should be masked"},{"line_number":34,"context_line":"                              before sending back to API call."},{"line_number":35,"context_line":"        :param kwargs: Extra arguments that might be present, but we ignore"},{"line_number":36,"context_line":"                       because they possibly came in from older rpc messages."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        \"\"\""},{"line_number":39,"context_line":"        user \u003d kwargs.pop(\u0027user\u0027, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_fbca5e4e","line":36,"updated":"2015-05-28 14:38:37.000000000","message":"+1 please update the docstring","commit_id":"98f5ad828637bda98f20d0de68ee7716ca837dc1"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"3d4a0f911b4c1c467d419f25e669d7f09b0e2df4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        :param show_password: Specifies whether passwords should be masked"},{"line_number":34,"context_line":"                              before sending back to API call."},{"line_number":35,"context_line":"        :param kwargs: Extra arguments that might be present, but we ignore"},{"line_number":36,"context_line":"                       because they possibly came in from older rpc messages."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        \"\"\""},{"line_number":39,"context_line":"        user \u003d kwargs.pop(\u0027user\u0027, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_8fdd6b16","line":36,"updated":"2015-05-28 12:15:14.000000000","message":"Missed the new arguments doc strings here:\n\n:param user_id: \n\n:param project_id:\n\n:param user_name: \n\n:param project_name:","commit_id":"98f5ad828637bda98f20d0de68ee7716ca837dc1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"775abd6568e482f0823916e14907219ba4496ba6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def to_dict(self):"},{"line_number":58,"context_line":"        return {\u0027auth_token\u0027: self.auth_token,"},{"line_number":59,"context_line":"                \u0027user\u0027: self.user,"},{"line_number":60,"context_line":"                \u0027tenant\u0027: self.tenant,"},{"line_number":61,"context_line":"                \u0027is_admin\u0027: self.is_admin,"},{"line_number":62,"context_line":"                \u0027read_only\u0027: self.read_only,"},{"line_number":63,"context_line":"                \u0027show_deleted\u0027: self.show_deleted,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_dbc5623d","line":60,"updated":"2015-05-28 14:38:37.000000000","message":"should we change these to _id?","commit_id":"98f5ad828637bda98f20d0de68ee7716ca837dc1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0a88c7b719fb7475689dcb28721274252cdd6e51","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        :param project_name: The name of the project or tenant, used by"},{"line_number":40,"context_line":"                             the configuration option of"},{"line_number":41,"context_line":"                             logging_context_format_string."},{"line_number":42,"context_line":"        :param kwargs: Extra arguments that might be present, but we ignore"},{"line_number":43,"context_line":"                       because they possibly came in from older rpc messages."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5afe65bd_2b6d9404","line":42,"updated":"2015-06-02 14:37:58.000000000","message":"we don\u0027t ignore them, we actually use user and tenant","commit_id":"af419828fc5f587ffb77d475ceb93484173927d9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"37b86c4f3ee92af3f480840b22072a8977e761a1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        :param project_name: The name of the project or tenant, used by"},{"line_number":40,"context_line":"                             the configuration option of"},{"line_number":41,"context_line":"                             logging_context_format_string."},{"line_number":42,"context_line":"        :param kwargs: Extra arguments that might be present, but we ignore"},{"line_number":43,"context_line":"                       because they possibly came in from older rpc messages."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5afe65bd_bef04d92","line":42,"in_reply_to":"5afe65bd_0fc4fb5c","updated":"2015-06-04 09:11:52.000000000","message":"Right, I think the message is then a bit misleading. What about:\n\n:param kwargs: Extra arguments. Used to translate message differences between an old and new rpc message.\n\n?","commit_id":"af419828fc5f587ffb77d475ceb93484173927d9"},{"author":{"_account_id":11042,"name":"chenglch","email":"chenglch@cn.ibm.com","username":"chenglch"},"change_message_id":"11080e1e9f0e685266756f4781f6f23fa6fab088","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        :param project_name: The name of the project or tenant, used by"},{"line_number":40,"context_line":"                             the configuration option of"},{"line_number":41,"context_line":"                             logging_context_format_string."},{"line_number":42,"context_line":"        :param kwargs: Extra arguments that might be present, but we ignore"},{"line_number":43,"context_line":"                       because they possibly came in from older rpc messages."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5afe65bd_0fc4fb5c","line":42,"in_reply_to":"5afe65bd_2b6d9404","updated":"2015-06-03 10:10:20.000000000","message":"kwargs can be used to solve the difference between old rpc message and the new one. Not just user and tenant here.","commit_id":"af419828fc5f587ffb77d475ceb93484173927d9"},{"author":{"_account_id":11042,"name":"chenglch","email":"chenglch@cn.ibm.com","username":"chenglch"},"change_message_id":"0cf7941679dfa0d3ba6195234b94f1101c298398","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        :param project_name: The name of the project or tenant, used by"},{"line_number":40,"context_line":"                             the configuration option of"},{"line_number":41,"context_line":"                             logging_context_format_string."},{"line_number":42,"context_line":"        :param kwargs: Extra arguments that might be present, but we ignore"},{"line_number":43,"context_line":"                       because they possibly came in from older rpc messages."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_35486f5b","line":42,"in_reply_to":"5afe65bd_bef04d92","updated":"2015-06-05 03:32:27.000000000","message":"OK, thanks, I will update","commit_id":"af419828fc5f587ffb77d475ceb93484173927d9"}]}
