)]}'
{"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b51959de57cb7a424a2fa5c91d9c82679cd843d","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                         files_info\u003dfiles_info,"},{"line_number":257,"context_line":"                                         parameters\u003dparams)"},{"line_number":258,"context_line":"        else:"},{"line_number":259,"context_line":"            images.create_vfat_image(vfat_image_tmpfile, files_info\u003dfiles_info,"},{"line_number":260,"context_line":"                                     parameters\u003dparams)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        container \u003d CONF.ilo.swift_ilo_container"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_bba9d426","line":259,"updated":"2015-05-26 22:04:16.000000000","message":"not sure if this is a nit or not, but if you\u0027re going to separate it out, then it seems like we should \n\n1. omit files_info, or do \u0027files_info\u003dNone\u0027 (which is the default).\n\n2. move line 245 into the \"with tempfile...\" (after line 251)","commit_id":"50743ffee28948ad9685323f0272014c5e02ce5c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f2652724fbcbe5c9c502a19f1f91f7c11310374a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                         files_info\u003dfiles_info,"},{"line_number":257,"context_line":"                                         parameters\u003dparams)"},{"line_number":258,"context_line":"        else:"},{"line_number":259,"context_line":"            images.create_vfat_image(vfat_image_tmpfile, files_info\u003dfiles_info,"},{"line_number":260,"context_line":"                                     parameters\u003dparams)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        container \u003d CONF.ilo.swift_ilo_container"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_9e08432a","line":259,"in_reply_to":"7a016987_7bba3970","updated":"2015-05-27 00:13:11.000000000","message":"Correction: \n\ns/If the line of a variable definition and the line of the variable definition/If the line of a variable definition and the line of the variable usage/\n\n-\u003e the second \"definition\" is a typo of \"usage\"","commit_id":"50743ffee28948ad9685323f0272014c5e02ce5c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f7b830851022226386e8f1e72e1111aa3e9f05c","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                         files_info\u003dfiles_info,"},{"line_number":257,"context_line":"                                         parameters\u003dparams)"},{"line_number":258,"context_line":"        else:"},{"line_number":259,"context_line":"            images.create_vfat_image(vfat_image_tmpfile, files_info\u003dfiles_info,"},{"line_number":260,"context_line":"                                     parameters\u003dparams)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        container \u003d CONF.ilo.swift_ilo_container"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_d826ba15","line":259,"in_reply_to":"7a016987_9e08432a","updated":"2015-05-27 14:03:27.000000000","message":"Hi Naohiro, I\u0027m not quite sure what you mean by some of your comments.\n\nWhen I used \u0027not sure if this is a nit or not\u0027, I mean, I didn\u0027t know whether what I was going to mention was considered a nit or not.\n\nWhen I used \u0027we should ...\u0027, I meant that we should ...\n\neg if I had written \u0027Not sure if this is a nit or not, we should s/foobar/foobars/\u0027, I mean that we should s/foobar/foobars/. In this example though, I\u0027m pretty sure it is a nit, so I wouldn\u0027t have written \u0027not sure if this is a nit or not\u0027 :-)\n\nAnd no, your \u0027if the line of a variable definition ...\u0027 is NOT quite the reason. That variable had been used in more than one place before to introduce some commonality, but with your change, it isn\u0027t, so it doesn\u0027t quite make sense to do that.\n\nwrt your comment \u0027I strongly believe that comment/suggestion/assertion without presenting reason causes us to exchange just personal preference in each individual sense.\u0027 It is true that as time goes on and someone is involved with the community, they pick up \u0027ways of doing things\u0027 that aren\u0027t explicitly documented. It is hard to remember/know/take the time/whatever to explain everything all the time. Eg, I have to assume you know how to code in python, and you understand English. If I spent time explaining everything (and to what level of detail?), I would only get a few reviews done. And I am only human. It is a give and take and communication is the key. So thanks for asking :-)","commit_id":"50743ffee28948ad9685323f0272014c5e02ce5c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a524f6f6bf0ec30f727bd4504fcbced4fa9c8e7d","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                         files_info\u003dfiles_info,"},{"line_number":257,"context_line":"                                         parameters\u003dparams)"},{"line_number":258,"context_line":"        else:"},{"line_number":259,"context_line":"            images.create_vfat_image(vfat_image_tmpfile, files_info\u003dfiles_info,"},{"line_number":260,"context_line":"                                     parameters\u003dparams)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        container \u003d CONF.ilo.swift_ilo_container"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_7bba3970","line":259,"in_reply_to":"7a016987_bba9d426","updated":"2015-05-27 00:07:15.000000000","message":"Ruby, thanks for the review and the comment.\n\nI\u0027ll fix that.\n\nHowever I\u0027d like to know why you thought \"we should\" even though \"not sure\".\n\nI strongly believe that comment/suggestion/assertion without presenting reason causes us to exchange just personal preference in each individual sense.\n\nIf the line of a variable definition and the line of the variable definition is apart more than one editor screen, I think we \"should\" move the definition and the usage closely.\n\nIf such reason presented, it would be understandable.\n\nThis is just my little thought.\n\nThanks.\n\nNaohiro","commit_id":"50743ffee28948ad9685323f0272014c5e02ce5c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"e82ff95d69721262a8fae69753d431397d680ad6","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                         files_info\u003dfiles_info,"},{"line_number":257,"context_line":"                                         parameters\u003dparams)"},{"line_number":258,"context_line":"        else:"},{"line_number":259,"context_line":"            images.create_vfat_image(vfat_image_tmpfile, files_info\u003dfiles_info,"},{"line_number":260,"context_line":"                                     parameters\u003dparams)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        container \u003d CONF.ilo.swift_ilo_container"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_c166a828","line":259,"in_reply_to":"7a016987_d826ba15","updated":"2015-05-28 02:53:01.000000000","message":"Hi Ruby,\n\nThank you for your detailed explanation.\nBut frankly speaking, I\u0027m a little bit confused and puzzled.\nAs you know, English is not my native  tongue :)\n\n\nI just wondered why you said \"we should\" even though you said  \"not sure if this is a nit or not\".\n\nIf your comment were intended to be \"nits\", it\u0027s fine for me, I could take your comment as your preference which is just different from my preference.\n\nIf your comment were intended to be NOT \"nits\", I need reason to validate it by myself. \n\nIf your comment could be considered as \"nits\" or could be considered NOT \"nits\", I need reason with certain context or view for both \"nits\" case and NOT \"nits\" case respectively.\n\nThat is all what I thought :-)\n\nBest regards,\n\nNaohiro.","commit_id":"50743ffee28948ad9685323f0272014c5e02ce5c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"71b854298333e0486f0ce5577dd7c1bbdf6031e4","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                files_info \u003d {}"},{"line_number":252,"context_line":"                token_tmpfile \u003d token_tmpfile_obj.name"},{"line_number":253,"context_line":"                utils.write_to_file(token_tmpfile, task.context.auth_token)"},{"line_number":254,"context_line":"                files_info[token_tmpfile] \u003d \u0027token\u0027"},{"line_number":255,"context_line":"                images.create_vfat_image(vfat_image_tmpfile,"},{"line_number":256,"context_line":"                                         files_info\u003dfiles_info,"},{"line_number":257,"context_line":"                                         parameters\u003dparams)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_d89b6871","line":254,"updated":"2015-05-27 07:40:50.000000000","message":"nit: files_info \u003d {token_tmpfile: \u0027token\u0027}","commit_id":"f3285fbc1d6595fc8f18fe507a53468fce80500e"}]}