)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"dd91a9477d8ac37f8330f9e710acfd700f9cd4c2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"iLO deploy driver can works in standalone Ironic mode with direct"},{"line_number":10,"context_line":"HTTP links, w/o Glance. This patch fixes continue_deploy() method,"},{"line_number":11,"context_line":"it should use Keystone only if authentication enabled."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I68febcfb345200aa5b51ae6bbcd2a8e88d99e947"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_c4549d22","line":12,"updated":"2015-05-27 09:48:20.000000000","message":"Should we have a bug about it?","commit_id":"1f189f5b8299db71efacd0f1b7edc29672367b42"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a265dbf8a85f76936a513fdf976bd95f352ca087","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        else:"},{"line_number":873,"context_line":"            # Agent vendorpassthru are made without auth token."},{"line_number":874,"context_line":"            # We require auth_token to talk to glance while building boot iso."},{"line_number":875,"context_line":"            if CONF.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":876,"context_line":"                task.context.auth_token \u003d keystone.get_admin_auth_token()"},{"line_number":877,"context_line":"            self._configure_vmedia_boot(task, root_uuid)"},{"line_number":878,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_0e7773a0","line":875,"updated":"2015-05-27 09:54:36.000000000","message":"Oh actually I just released. This auth_strategy is for the Ironic API. We also have a auth_strategy for the Glance API [1], shouldn\u0027t we be looking at the it instead of the Ironic API one?\n\nCONF.glance.auth_strategy\n\nhttps://github.com/openstack/ironic/blob/master/ironic/common/image_service.py#L66-L70","commit_id":"1f189f5b8299db71efacd0f1b7edc29672367b42"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5fa83950c734b701a24963abb57cbea2f16da75b","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        else:"},{"line_number":873,"context_line":"            # Agent vendorpassthru are made without auth token."},{"line_number":874,"context_line":"            # We require auth_token to talk to glance while building boot iso."},{"line_number":875,"context_line":"            if CONF.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":876,"context_line":"                task.context.auth_token \u003d keystone.get_admin_auth_token()"},{"line_number":877,"context_line":"            self._configure_vmedia_boot(task, root_uuid)"},{"line_number":878,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_432bfceb","line":875,"in_reply_to":"7a016987_08abe38a","updated":"2015-05-27 13:11:35.000000000","message":"Looks good.","commit_id":"1f189f5b8299db71efacd0f1b7edc29672367b42"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4fd384392554f8f50f3a868b7e88fc451d0caad8","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        else:"},{"line_number":873,"context_line":"            # Agent vendorpassthru are made without auth token."},{"line_number":874,"context_line":"            # We require auth_token to talk to glance while building boot iso."},{"line_number":875,"context_line":"            if CONF.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":876,"context_line":"                task.context.auth_token \u003d keystone.get_admin_auth_token()"},{"line_number":877,"context_line":"            self._configure_vmedia_boot(task, root_uuid)"},{"line_number":878,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d7a1ee47","line":875,"in_reply_to":"7a016987_0e7773a0","updated":"2015-05-27 11:37:44.000000000","message":"Lucas, two cases are possible when token not needed here:\n\n1) Ironic works as a standalone service w/o Glance, Keystone etc.\n2) Glance service authentication disabled\n\n(2) Looks more rare because OpenStack\u0027s services work good \"out of box\" with Keystone.\n\nFor (1), why user should think about an option in \"glance\" group if he/she does not use Glance at all? This is the reason why \"CONF.auth_strategy\" used.\n\nAlternative: add separate conductor\u0027s option like \"standalone_mode\". There are some issues with standalone Ironic like fixed in this patch (for example Haomeng found that discoverd does not work w/o Keystone). Maybe this new option can help to resolve them.","commit_id":"1f189f5b8299db71efacd0f1b7edc29672367b42"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"faa65efa56e57b1a2d5121364af0ebd0cc48c09b","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        else:"},{"line_number":873,"context_line":"            # Agent vendorpassthru are made without auth token."},{"line_number":874,"context_line":"            # We require auth_token to talk to glance while building boot iso."},{"line_number":875,"context_line":"            if CONF.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":876,"context_line":"                task.context.auth_token \u003d keystone.get_admin_auth_token()"},{"line_number":877,"context_line":"            self._configure_vmedia_boot(task, root_uuid)"},{"line_number":878,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_08abe38a","line":875,"in_reply_to":"7a016987_d7a1ee47","updated":"2015-05-27 12:49:08.000000000","message":"Thanks for the reply.\n\nThe good part of the standalone is actually the plugability that allows users to chose which OS services they want to deploy and use in conjunction with Ironic.\n\nSince we want to investigate whether we have the right credentials to fetch the image from glance, but Ironic also allows to not use Glance at all. I think we can make a very fine grained condition here to:\n\n1) Test whether the image is coming from Glance\n\n2) Check if we need credentials to talk to Glance.\n\nWith that in mind, what about:\n\n if (service_utils.is_glance_image(node.instance_info[\u0027image_source\u0027]) and \n     CONF.glance.auth_strategy \u003d\u003d \"keystone\"):\n     task.context.auth_token \u003d keystone.get_admin_auth_token()","commit_id":"1f189f5b8299db71efacd0f1b7edc29672367b42"}]}