)]}'
{"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"24c1762b41cb7c01a0a4ef249718f420dde0bcfd","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    \"\"\"Generate the iSCSI iqn name.\"\"\""},{"line_number":433,"context_line":"    date \u003d timeutils.utcnow().strftime(\u0027%Y-%m\u0027)"},{"line_number":434,"context_line":"    return \u0027iqn.%(date)s.os.ironic:%(node)s\u0027 % {\u0027date\u0027: date,"},{"line_number":435,"context_line":"                                                \u0027node\u0027: node.uuid}"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"def build_deploy_ramdisk_options(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_c91b8a1b","line":435,"updated":"2015-05-27 14:38:51.000000000","message":"So the convention in the RFC (not sure if it\u0027s SHOULD or MUST) is to use an actual domain and the date the domain was established. And then a unique identifier (+1 for node uuid). Do we want to do that here?\n\nFor example, see what I\u0027m using here: https://review.openstack.org/#/c/184652/1/nova/virt/ironic/driver.py","commit_id":"292655db074b6e59c7bff4fb9cfdffa365e8bed3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e7cc95b92c4e7070bb77763bc9115900822ab3b0","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    \"\"\"Generate the iSCSI iqn name.\"\"\""},{"line_number":433,"context_line":"    date \u003d timeutils.utcnow().strftime(\u0027%Y-%m\u0027)"},{"line_number":434,"context_line":"    return \u0027iqn.%(date)s.os.ironic:%(node)s\u0027 % {\u0027date\u0027: date,"},{"line_number":435,"context_line":"                                                \u0027node\u0027: node.uuid}"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"def build_deploy_ramdisk_options(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_09ae4298","line":435,"in_reply_to":"7a016987_c91b8a1b","updated":"2015-05-27 14:41:54.000000000","message":"+1! Thanks I was unsure what to put here so I was just generating the date and all","commit_id":"292655db074b6e59c7bff4fb9cfdffa365e8bed3"}],"ironic/tests/drivers/test_iscsi_deploy.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d3cd3adc21f467115568ff0010597adb6c32c682","unresolved":false,"context_lines":[{"line_number":920,"context_line":""},{"line_number":921,"context_line":"    @mock.patch.object(timeutils, \u0027utcnow\u0027)"},{"line_number":922,"context_line":"    def test_generate_iqn_name(self, mock_utcnow):"},{"line_number":923,"context_line":"        mock_utcnow.return_value \u003d datetime.datetime(2014, 11, 21)"},{"line_number":924,"context_line":"        iqn \u003d iscsi_deploy.generate_iqn_name(self.node)"},{"line_number":925,"context_line":"        expected \u003d \u0027iqn.2014-11.os.ironic:%s\u0027 % self.node.uuid"},{"line_number":926,"context_line":"        self.assertEqual(expected, iqn)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_8e1a3816","line":923,"updated":"2015-05-27 14:24:09.000000000","message":"For those wondering this is the birthday date of our mascot, Pixe Boots.","commit_id":"292655db074b6e59c7bff4fb9cfdffa365e8bed3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"46db62baceabaad2546e0f6fc6bee6b03d959191","unresolved":false,"context_lines":[{"line_number":920,"context_line":""},{"line_number":921,"context_line":"    @mock.patch.object(timeutils, \u0027utcnow\u0027)"},{"line_number":922,"context_line":"    def test_generate_iqn_name(self, mock_utcnow):"},{"line_number":923,"context_line":"        mock_utcnow.return_value \u003d datetime.datetime(2014, 11, 21)"},{"line_number":924,"context_line":"        iqn \u003d iscsi_deploy.generate_iqn_name(self.node)"},{"line_number":925,"context_line":"        expected \u003d \u0027iqn.2014-11.os.ironic:%s\u0027 % self.node.uuid"},{"line_number":926,"context_line":"        self.assertEqual(expected, iqn)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_8e20f8f8","line":923,"in_reply_to":"7a016987_8e1a3816","updated":"2015-05-27 14:28:13.000000000","message":"oh good to know","commit_id":"292655db074b6e59c7bff4fb9cfdffa365e8bed3"}]}