)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee2e1fceef5a549376a765da8549b7ad966a83c0","unresolved":false,"context_lines":[{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    @expose.expose("},{"line_number":851,"context_line":"            NodeCollection, types.uuid, types.uuid, types.boolean,"},{"line_number":852,"context_line":"            types.boolean, types.uuid, int, wtypes.text, wtypes.text)"},{"line_number":853,"context_line":"    def get_all(self, chassis_uuid\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":854,"context_line":"                maintenance\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":855,"context_line":"                sort_dir\u003d\u0027asc\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_c407ef1b","line":852,"updated":"2015-05-27 15:09:32.000000000","message":"For the recond: I don\u0027t like this change","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    @expose.expose("},{"line_number":851,"context_line":"            NodeCollection, types.uuid, types.uuid, types.boolean,"},{"line_number":852,"context_line":"            types.boolean, types.uuid, int, wtypes.text, wtypes.text)"},{"line_number":853,"context_line":"    def get_all(self, chassis_uuid\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":854,"context_line":"                maintenance\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":855,"context_line":"                sort_dir\u003d\u0027asc\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_00dca5e2","line":852,"in_reply_to":"7a016987_10fe5eae","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"828ef72beec735b200b2b9eee6c02cfa085e850c","unresolved":false,"context_lines":[{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    @expose.expose("},{"line_number":851,"context_line":"            NodeCollection, types.uuid, types.uuid, types.boolean,"},{"line_number":852,"context_line":"            types.boolean, types.uuid, int, wtypes.text, wtypes.text)"},{"line_number":853,"context_line":"    def get_all(self, chassis_uuid\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":854,"context_line":"                maintenance\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":855,"context_line":"                sort_dir\u003d\u0027asc\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_dadd8a71","line":852,"in_reply_to":"7a016987_c407ef1b","updated":"2015-05-27 15:40:23.000000000","message":"Would you prefer I change it to this format?, this is also legal under E128: \n\n@expose.expose(NodeCollection, types.uuid, types.uuid, \n               types.boolean, types.boolean, types.uuid,\n               int, wtypes.text, wtypes.text)","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    @expose.expose("},{"line_number":851,"context_line":"            NodeCollection, types.uuid, types.uuid, types.boolean,"},{"line_number":852,"context_line":"            types.boolean, types.uuid, int, wtypes.text, wtypes.text)"},{"line_number":853,"context_line":"    def get_all(self, chassis_uuid\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":854,"context_line":"                maintenance\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":855,"context_line":"                sort_dir\u003d\u0027asc\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_10fe5eae","line":852,"in_reply_to":"7a016987_dadd8a71","updated":"2015-05-27 17:27:55.000000000","message":"That would look better to me.\n\nAlso I am surprised it is using 8 characters.\n\nWhy not:\n\n @expose.expose(\n     NodeCollection, types.uuid, types.uuid, \n     types.boolean, types.boolean, types.uuid,\n     int, wtypes.text, wtypes.text)","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"037220996a5518380ccec19bb2359f95c6e6bfec","unresolved":false,"context_lines":[{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    @expose.expose("},{"line_number":851,"context_line":"            NodeCollection, types.uuid, types.uuid, types.boolean,"},{"line_number":852,"context_line":"            types.boolean, types.uuid, int, wtypes.text, wtypes.text)"},{"line_number":853,"context_line":"    def get_all(self, chassis_uuid\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":854,"context_line":"                maintenance\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":855,"context_line":"                sort_dir\u003d\u0027asc\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_45aad61a","line":852,"in_reply_to":"7a016987_dadd8a71","updated":"2015-05-27 17:14:28.000000000","message":"yes, I prefer the latter. That also seems more in line with the original (ie, indent the last two lines but leave the first line alone).","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    @expose.expose("},{"line_number":878,"context_line":"            NodeCollection, types.uuid, types.uuid, types.boolean,"},{"line_number":879,"context_line":"            types.boolean, types.uuid, int, wtypes.text, wtypes.text)"},{"line_number":880,"context_line":"    def detail(self, chassis_uuid\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":881,"context_line":"               maintenance\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":882,"context_line":"               sort_dir\u003d\u0027asc\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_501bb61c","line":879,"updated":"2015-05-27 17:27:55.000000000","message":"Same as above","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    @expose.expose("},{"line_number":878,"context_line":"            NodeCollection, types.uuid, types.uuid, types.boolean,"},{"line_number":879,"context_line":"            types.boolean, types.uuid, int, wtypes.text, wtypes.text)"},{"line_number":880,"context_line":"    def detail(self, chassis_uuid\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":881,"context_line":"               maintenance\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":882,"context_line":"               sort_dir\u003d\u0027asc\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_c0e56da8","line":879,"in_reply_to":"7a016987_501bb61c","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/cmd/dbsync.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    command_object \u003d DBCommand()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    parser \u003d subparsers.add_parser("},{"line_number":58,"context_line":"            \u0027upgrade\u0027,"},{"line_number":59,"context_line":"            help\u003d\"Upgrade the database schema to the latest version. \""},{"line_number":60,"context_line":"                 \"Optionally, use --revision to specify an alembic revision \""},{"line_number":61,"context_line":"                 \"string to upgrade to.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_cb8a571a","line":58,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    command_object \u003d DBCommand()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    parser \u003d subparsers.add_parser("},{"line_number":58,"context_line":"            \u0027upgrade\u0027,"},{"line_number":59,"context_line":"            help\u003d\"Upgrade the database schema to the latest version. \""},{"line_number":60,"context_line":"                 \"Optionally, use --revision to specify an alembic revision \""},{"line_number":61,"context_line":"                 \"string to upgrade to.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_a0f71158","line":58,"in_reply_to":"7a016987_cb8a571a","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    parser.add_argument(\u0027--revision\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    parser \u003d subparsers.add_parser("},{"line_number":66,"context_line":"            \u0027downgrade\u0027,"},{"line_number":67,"context_line":"            help\u003d\"Downgrade the database schema to the oldest revision. \""},{"line_number":68,"context_line":"                 \"While optional, one should generally use --revision to \""},{"line_number":69,"context_line":"                 \"specify the alembic revision string to downgrade to.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_8b845f0b","line":66,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    parser.add_argument(\u0027--revision\u0027, nargs\u003d\u0027?\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    parser \u003d subparsers.add_parser("},{"line_number":66,"context_line":"            \u0027downgrade\u0027,"},{"line_number":67,"context_line":"            help\u003d\"Downgrade the database schema to the oldest revision. \""},{"line_number":68,"context_line":"                 \"While optional, one should generally use --revision to \""},{"line_number":69,"context_line":"                 \"specify the alembic revision string to downgrade to.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_809535e5","line":66,"in_reply_to":"7a016987_8b845f0b","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    parser.set_defaults(func\u003dcommand_object.stamp)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    parser \u003d subparsers.add_parser("},{"line_number":78,"context_line":"            \u0027revision\u0027,"},{"line_number":79,"context_line":"            help\u003d\"Create a new alembic revision. \""},{"line_number":80,"context_line":"                 \"Use --message to set the message string.\")"},{"line_number":81,"context_line":"    parser.add_argument(\u0027-m\u0027, \u0027--message\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4b77873b","line":78,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    parser.set_defaults(func\u003dcommand_object.stamp)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    parser \u003d subparsers.add_parser("},{"line_number":78,"context_line":"            \u0027revision\u0027,"},{"line_number":79,"context_line":"            help\u003d\"Create a new alembic revision. \""},{"line_number":80,"context_line":"                 \"Use --message to set the message string.\")"},{"line_number":81,"context_line":"    parser.add_argument(\u0027-m\u0027, \u0027--message\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_6098f91b","line":78,"in_reply_to":"7a016987_4b77873b","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    parser.set_defaults(func\u003dcommand_object.revision)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    parser \u003d subparsers.add_parser("},{"line_number":86,"context_line":"            \u0027version\u0027,"},{"line_number":87,"context_line":"            help\u003d\"Print the current version information and exit.\")"},{"line_number":88,"context_line":"    parser.set_defaults(func\u003dcommand_object.version)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_eb8e3326","line":86,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    parser.set_defaults(func\u003dcommand_object.revision)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    parser \u003d subparsers.add_parser("},{"line_number":86,"context_line":"            \u0027version\u0027,"},{"line_number":87,"context_line":"            help\u003d\"Print the current version information and exit.\")"},{"line_number":88,"context_line":"    parser.set_defaults(func\u003dcommand_object.version)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_409f3d03","line":86,"in_reply_to":"7a016987_eb8e3326","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    parser.set_defaults(func\u003dcommand_object.version)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    parser \u003d subparsers.add_parser("},{"line_number":91,"context_line":"            \u0027create_schema\u0027,"},{"line_number":92,"context_line":"            help\u003d\"Create the database schema.\")"},{"line_number":93,"context_line":"    parser.set_defaults(func\u003dcommand_object.create_schema)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_ab983b6b","line":91,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    parser.set_defaults(func\u003dcommand_object.version)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    parser \u003d subparsers.add_parser("},{"line_number":91,"context_line":"            \u0027create_schema\u0027,"},{"line_number":92,"context_line":"            help\u003d\"Create the database schema.\")"},{"line_number":93,"context_line":"    parser.set_defaults(func\u003dcommand_object.create_schema)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_20a2014c","line":91,"in_reply_to":"7a016987_ab983b6b","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/common/images.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        backing_file \u003d data.backing_file"},{"line_number":362,"context_line":"        if backing_file is not None:"},{"line_number":363,"context_line":"            raise exception.ImageUnacceptable("},{"line_number":364,"context_line":"                    image_id\u003dimage_href,"},{"line_number":365,"context_line":"                    reason\u003d_(\"fmt\u003d%(fmt)s backed by: %(backing_file)s\") %"},{"line_number":366,"context_line":"                    {\u0027fmt\u0027: fmt, \u0027backing_file\u0027: backing_file})"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4b90a74e","line":364,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        backing_file \u003d data.backing_file"},{"line_number":362,"context_line":"        if backing_file is not None:"},{"line_number":363,"context_line":"            raise exception.ImageUnacceptable("},{"line_number":364,"context_line":"                    image_id\u003dimage_href,"},{"line_number":365,"context_line":"                    reason\u003d_(\"fmt\u003d%(fmt)s backed by: %(backing_file)s\") %"},{"line_number":366,"context_line":"                    {\u0027fmt\u0027: fmt, \u0027backing_file\u0027: backing_file})"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_c0068d1f","line":364,"in_reply_to":"7a016987_4b90a74e","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"037220996a5518380ccec19bb2359f95c6e6bfec","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                    raise exception.ImageConvertFailed("},{"line_number":379,"context_line":"                        image_id\u003dimage_href,"},{"line_number":380,"context_line":"                        reason\u003d_(\"Converted to raw, but format is now %s\") %"},{"line_number":381,"context_line":"                        data.file_format)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"                os.rename(staged, path)"},{"line_number":384,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d028c687","line":381,"updated":"2015-05-27 17:14:28.000000000","message":"i liked how this last line was indented before :-(","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                    raise exception.ImageConvertFailed("},{"line_number":379,"context_line":"                        image_id\u003dimage_href,"},{"line_number":380,"context_line":"                        reason\u003d_(\"Converted to raw, but format is now %s\") %"},{"line_number":381,"context_line":"                        data.file_format)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"                os.rename(staged, path)"},{"line_number":384,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_e007491b","line":381,"in_reply_to":"7a016987_d028c687","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/common/keystone.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            return client.Client(token\u003dtoken, auth_url\u003dauth_url)"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            return client.Client("},{"line_number":68,"context_line":"                    username\u003dCONF.keystone_authtoken.admin_user,"},{"line_number":69,"context_line":"                    password\u003dCONF.keystone_authtoken.admin_password,"},{"line_number":70,"context_line":"                    tenant_name\u003dCONF.keystone_authtoken.admin_tenant_name,"},{"line_number":71,"context_line":"                    region_name\u003dCONF.keystone.region_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_cba377b0","line":68,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            return client.Client(token\u003dtoken, auth_url\u003dauth_url)"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            return client.Client("},{"line_number":68,"context_line":"                    username\u003dCONF.keystone_authtoken.admin_user,"},{"line_number":69,"context_line":"                    password\u003dCONF.keystone_authtoken.admin_password,"},{"line_number":70,"context_line":"                    tenant_name\u003dCONF.keystone_authtoken.admin_tenant_name,"},{"line_number":71,"context_line":"                    region_name\u003dCONF.keystone.region_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_9bb92a18","line":68,"in_reply_to":"7a016987_cba377b0","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    try:"},{"line_number":115,"context_line":"        endpoint \u003d ksclient.service_catalog.url_for("},{"line_number":116,"context_line":"                service_type\u003dservice_type,"},{"line_number":117,"context_line":"                endpoint_type\u003dendpoint_type,"},{"line_number":118,"context_line":"                region_name\u003dCONF.keystone.region_name)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_abaa7b83","line":116,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    try:"},{"line_number":115,"context_line":"        endpoint \u003d ksclient.service_catalog.url_for("},{"line_number":116,"context_line":"                service_type\u003dservice_type,"},{"line_number":117,"context_line":"                endpoint_type\u003dendpoint_type,"},{"line_number":118,"context_line":"                region_name\u003dCONF.keystone.region_name)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_5b3a9299","line":116,"in_reply_to":"7a016987_abaa7b83","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/db/sqlalchemy/alembic/versions/3cb628139ea4_nodes_add_console_enabled.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"037220996a5518380ccec19bb2359f95c6e6bfec","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def upgrade():"},{"line_number":30,"context_line":"    op.add_column("},{"line_number":31,"context_line":"        \u0027nodes\u0027, sa.Column(\u0027console_enabled\u0027, sa.Boolean))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_b0c9caae","line":31,"updated":"2015-05-27 17:14:28.000000000","message":"I\u0027d prefer if you combined this line with the one above.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def upgrade():"},{"line_number":30,"context_line":"    op.add_column("},{"line_number":31,"context_line":"        \u0027nodes\u0027, sa.Column(\u0027console_enabled\u0027, sa.Boolean))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_db1b221b","line":31,"in_reply_to":"7a016987_b0c9caae","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            # Prevent instance_uuid overwriting"},{"line_number":367,"context_line":"            if values.get(\"instance_uuid\") and ref.instance_uuid:"},{"line_number":368,"context_line":"                raise exception.NodeAssociated("},{"line_number":369,"context_line":"                        node\u003dnode_id, instance\u003dref.instance_uuid)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":372,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4be2e702","line":369,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            # Prevent instance_uuid overwriting"},{"line_number":367,"context_line":"            if values.get(\"instance_uuid\") and ref.instance_uuid:"},{"line_number":368,"context_line":"                raise exception.NodeAssociated("},{"line_number":369,"context_line":"                        node\u003dnode_id, instance\u003dref.instance_uuid)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":372,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_9b15aae6","line":369,"in_reply_to":"7a016987_4be2e702","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/drivers/modules/amt/common.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    protocol \u003d info.get(param, CONF.amt.get(param[4:]))"},{"line_number":168,"context_line":"    if protocol not in AMT_PROTOCOL_PORT_MAP:"},{"line_number":169,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":170,"context_line":"                _(\"Invalid protocol %s.\") % protocol)"},{"line_number":171,"context_line":"    if not isinstance(value, six.binary_type):"},{"line_number":172,"context_line":"        protocol \u003d protocol.encode()"},{"line_number":173,"context_line":"    d_info[param[4:]] \u003d protocol"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_abdcbb46","line":170,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    protocol \u003d info.get(param, CONF.amt.get(param[4:]))"},{"line_number":168,"context_line":"    if protocol not in AMT_PROTOCOL_PORT_MAP:"},{"line_number":169,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":170,"context_line":"                _(\"Invalid protocol %s.\") % protocol)"},{"line_number":171,"context_line":"    if not isinstance(value, six.binary_type):"},{"line_number":172,"context_line":"        protocol \u003d protocol.encode()"},{"line_number":173,"context_line":"    d_info[param[4:]] \u003d protocol"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_3bdd9642","line":170,"in_reply_to":"7a016987_abdcbb46","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/drivers/modules/amt/management.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"037220996a5518380ccec19bb2359f95c6e6bfec","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if device not in amt_common.BOOT_DEVICES_MAPPING:"},{"line_number":191,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":192,"context_line":"                \"set_boot_device called \""},{"line_number":193,"context_line":"                \"with invalid device %(device)s for node %(node_id)s.\") %"},{"line_number":194,"context_line":"                {\u0027device\u0027: device, \u0027node_id\u0027: node.uuid})"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        # AMT/vPro doesn\u0027t support set boot_device persistent, so we have to"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_301a7a18","line":193,"updated":"2015-05-27 17:14:28.000000000","message":"It looks odd now; I think we should reformat this and concatenate part of this line with the line above.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if device not in amt_common.BOOT_DEVICES_MAPPING:"},{"line_number":191,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":192,"context_line":"                \"set_boot_device called \""},{"line_number":193,"context_line":"                \"with invalid device %(device)s for node %(node_id)s.\") %"},{"line_number":194,"context_line":"                {\u0027device\u0027: device, \u0027node_id\u0027: node.uuid})"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        # AMT/vPro doesn\u0027t support set boot_device persistent, so we have to"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_db77a239","line":193,"in_reply_to":"7a016987_301a7a18","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/drivers/modules/console_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if (time.time() \u003e expiration):"},{"line_number":240,"context_line":"            locals[\u0027errstr\u0027] \u003d _("},{"line_number":241,"context_line":"                    \"Timeout while waiting for console\""},{"line_number":242,"context_line":"                    \" subprocess to start for node %s.\") % node_uuid"},{"line_number":243,"context_line":"            LOG.warning(locals[\u0027errstr\u0027])"},{"line_number":244,"context_line":"            raise loopingcall.LoopingCallDone()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_0b150fe4","line":241,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if (time.time() \u003e expiration):"},{"line_number":240,"context_line":"            locals[\u0027errstr\u0027] \u003d _("},{"line_number":241,"context_line":"                    \"Timeout while waiting for console\""},{"line_number":242,"context_line":"                    \" subprocess to start for node %s.\") % node_uuid"},{"line_number":243,"context_line":"            LOG.warning(locals[\u0027errstr\u0027])"},{"line_number":244,"context_line":"            raise loopingcall.LoopingCallDone()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_5b2e12fb","line":241,"in_reply_to":"7a016987_0b150fe4","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"037220996a5518380ccec19bb2359f95c6e6bfec","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        if (time.time() \u003e expiration):"},{"line_number":240,"context_line":"            locals[\u0027errstr\u0027] \u003d _("},{"line_number":241,"context_line":"                    \"Timeout while waiting for console\""},{"line_number":242,"context_line":"                    \" subprocess to start for node %s.\") % node_uuid"},{"line_number":243,"context_line":"            LOG.warning(locals[\u0027errstr\u0027])"},{"line_number":244,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d0d5661b","line":242,"updated":"2015-05-27 17:14:28.000000000","message":"this one too seems a bit odd; maybe move part of this line to the line above.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        if (time.time() \u003e expiration):"},{"line_number":240,"context_line":"            locals[\u0027errstr\u0027] \u003d _("},{"line_number":241,"context_line":"                    \"Timeout while waiting for console\""},{"line_number":242,"context_line":"                    \" subprocess to start for node %s.\") % node_uuid"},{"line_number":243,"context_line":"            LOG.warning(locals[\u0027errstr\u0027])"},{"line_number":244,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_7b2b0eec","line":242,"in_reply_to":"7a016987_d0d5661b","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/drivers/modules/fake.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"037220996a5518380ccec19bb2359f95c6e6bfec","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        if power_state not in [states.POWER_ON, states.POWER_OFF]:"},{"line_number":48,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":49,"context_line":"                \"set_power_state called \""},{"line_number":50,"context_line":"                \"with an invalid power state: %s.\") % power_state)"},{"line_number":51,"context_line":"        task.node.power_state \u003d power_state"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def reboot(self, task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_30203af7","line":50,"updated":"2015-05-27 17:14:28.000000000","message":"maybe combine part of this line with the one above\n\nthe original had this line indented 8 spaces. We don\u0027t have a rule about how much to indent, but I\u0027d like to keep the intention and have both these lines indented 8 instead of 4.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        if power_state not in [states.POWER_ON, states.POWER_OFF]:"},{"line_number":48,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":49,"context_line":"                \"set_power_state called \""},{"line_number":50,"context_line":"                \"with an invalid power state: %s.\") % power_state)"},{"line_number":51,"context_line":"        task.node.power_state \u003d power_state"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def reboot(self, task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_1b5d3a79","line":50,"in_reply_to":"7a016987_30203af7","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee2e1fceef5a549376a765da8549b7ad966a83c0","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"BOOT_MODE_GENERIC_TO_ILO \u003d {\u0027bios\u0027: \u0027legacy\u0027, \u0027uefi\u0027: \u0027uefi\u0027}"},{"line_number":88,"context_line":"BOOT_MODE_ILO_TO_GENERIC \u003d dict("},{"line_number":89,"context_line":"        (v, k) for (k, v) in BOOT_MODE_GENERIC_TO_ILO.items())"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def parse_driver_info(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_8401f708","line":89,"updated":"2015-05-27 15:09:32.000000000","message":"this should better be changed to dict comprehension","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"BOOT_MODE_GENERIC_TO_ILO \u003d {\u0027bios\u0027: \u0027legacy\u0027, \u0027uefi\u0027: \u0027uefi\u0027}"},{"line_number":88,"context_line":"BOOT_MODE_ILO_TO_GENERIC \u003d dict("},{"line_number":89,"context_line":"        (v, k) for (k, v) in BOOT_MODE_GENERIC_TO_ILO.items())"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def parse_driver_info(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_b0f2ea04","line":89,"in_reply_to":"7a016987_5c463722","updated":"2015-05-27 17:27:55.000000000","message":"I would vote against changing it in this patch.  This patch should only be for whitespace changes in my opinion.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"037220996a5518380ccec19bb2359f95c6e6bfec","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"BOOT_MODE_GENERIC_TO_ILO \u003d {\u0027bios\u0027: \u0027legacy\u0027, \u0027uefi\u0027: \u0027uefi\u0027}"},{"line_number":88,"context_line":"BOOT_MODE_ILO_TO_GENERIC \u003d dict("},{"line_number":89,"context_line":"        (v, k) for (k, v) in BOOT_MODE_GENERIC_TO_ILO.items())"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def parse_driver_info(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_30771a04","line":89,"in_reply_to":"7a016987_5c463722","updated":"2015-05-27 17:14:28.000000000","message":"no, please change this (if you do) in a separate patch.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"828ef72beec735b200b2b9eee6c02cfa085e850c","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"BOOT_MODE_GENERIC_TO_ILO \u003d {\u0027bios\u0027: \u0027legacy\u0027, \u0027uefi\u0027: \u0027uefi\u0027}"},{"line_number":88,"context_line":"BOOT_MODE_ILO_TO_GENERIC \u003d dict("},{"line_number":89,"context_line":"        (v, k) for (k, v) in BOOT_MODE_GENERIC_TO_ILO.items())"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"def parse_driver_info(node):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_5c463722","line":89,"in_reply_to":"7a016987_8401f708","updated":"2015-05-27 15:40:23.000000000","message":"Is this a change that I should include in this patch? its not directly related to the E128 change but it is still code cleanup","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    except ilo_error.IloError as ilo_exception:"},{"line_number":296,"context_line":"        operation \u003d _(\"Inserting virtual media %s\") % device"},{"line_number":297,"context_line":"        raise exception.IloOperationError("},{"line_number":298,"context_line":"                operation\u003doperation, error\u003dilo_exception)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    LOG.info(_LI(\"Attached virtual media %s successfully.\"), device)"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4bf427ce","line":298,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    except ilo_error.IloError as ilo_exception:"},{"line_number":296,"context_line":"        operation \u003d _(\"Inserting virtual media %s\") % device"},{"line_number":297,"context_line":"        raise exception.IloOperationError("},{"line_number":298,"context_line":"                operation\u003doperation, error\u003dilo_exception)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    LOG.info(_LI(\"Attached virtual media %s successfully.\"), device)"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_9be00a98","line":298,"in_reply_to":"7a016987_4bf427ce","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    except ilo_error.IloError as ilo_exception:"},{"line_number":326,"context_line":"        operation \u003d _(\"Setting %s as boot mode\") % boot_mode"},{"line_number":327,"context_line":"        raise exception.IloOperationError("},{"line_number":328,"context_line":"                operation\u003doperation, error\u003dilo_exception)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    LOG.info(_LI(\"Node %(uuid)s boot mode is set to %(boot_mode)s.\"),"},{"line_number":331,"context_line":"             {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_0bfe2fae","line":328,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    except ilo_error.IloError as ilo_exception:"},{"line_number":326,"context_line":"        operation \u003d _(\"Setting %s as boot mode\") % boot_mode"},{"line_number":327,"context_line":"        raise exception.IloOperationError("},{"line_number":328,"context_line":"                operation\u003doperation, error\u003dilo_exception)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    LOG.info(_LI(\"Node %(uuid)s boot mode is set to %(boot_mode)s.\"),"},{"line_number":331,"context_line":"             {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_3be8f67b","line":328,"in_reply_to":"7a016987_0bfe2fae","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"037220996a5518380ccec19bb2359f95c6e6bfec","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            container, object_name, timeout)"},{"line_number":426,"context_line":"    elif service_utils.is_glance_image(boot_iso):"},{"line_number":427,"context_line":"        boot_iso_url \u003d images.get_temp_url_for_glance_image("},{"line_number":428,"context_line":"            task.context, boot_iso)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    attach_vmedia(task.node, \u0027CDROM\u0027, boot_iso_url or boot_iso)"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_304efac1","line":428,"updated":"2015-05-27 17:14:28.000000000","message":"maybe I\u0027m being too picky, but I\u0027d like it if you indented this based on the indentation used in the original code, so 8 instead of 4.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5214bf5bc8ea34480f9deda38015ee67cde97b04","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            container, object_name, timeout)"},{"line_number":426,"context_line":"    elif service_utils.is_glance_image(boot_iso):"},{"line_number":427,"context_line":"        boot_iso_url \u003d images.get_temp_url_for_glance_image("},{"line_number":428,"context_line":"            task.context, boot_iso)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    attach_vmedia(task.node, \u0027CDROM\u0027, boot_iso_url or boot_iso)"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_abd03bca","line":428,"in_reply_to":"7a016987_304efac1","updated":"2015-05-27 17:32:25.000000000","message":"I disagree.  4 spaces is the standard Python indent.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ecd871b956d726b649a21d69683985c9d7e09ff3","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            container, object_name, timeout)"},{"line_number":426,"context_line":"    elif service_utils.is_glance_image(boot_iso):"},{"line_number":427,"context_line":"        boot_iso_url \u003d images.get_temp_url_for_glance_image("},{"line_number":428,"context_line":"            task.context, boot_iso)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    attach_vmedia(task.node, \u0027CDROM\u0027, boot_iso_url or boot_iso)"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f1174452","line":428,"in_reply_to":"7a016987_abd03bca","updated":"2015-05-27 18:28:03.000000000","message":"I think we should honor what the original code did. This patch isn\u0027t about changing all 8-char indentations to 4, is it?","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            container, object_name, timeout)"},{"line_number":426,"context_line":"    elif service_utils.is_glance_image(boot_iso):"},{"line_number":427,"context_line":"        boot_iso_url \u003d images.get_temp_url_for_glance_image("},{"line_number":428,"context_line":"            task.context, boot_iso)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    attach_vmedia(task.node, \u0027CDROM\u0027, boot_iso_url or boot_iso)"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_965d7f17","line":428,"in_reply_to":"7a016987_f1174452","updated":"2015-05-28 16:15:26.000000000","message":"I have updated this to a slightly different format which I hope is nicer to read.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8ec2fd99e28046b24dc8da387e06cd781eba1019","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            container, object_name, timeout)"},{"line_number":426,"context_line":"    elif service_utils.is_glance_image(boot_iso):"},{"line_number":427,"context_line":"        boot_iso_url \u003d images.get_temp_url_for_glance_image("},{"line_number":428,"context_line":"            task.context, boot_iso)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    attach_vmedia(task.node, \u0027CDROM\u0027, boot_iso_url or boot_iso)"},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_998a4f63","line":428,"in_reply_to":"7a016987_f1174452","updated":"2015-05-28 16:12:47.000000000","message":"Well if the follow on patches occur to fix the other E12* errors, then this line might need to be changed again.  I think when E126 and E127 are enabled then they will complain about it.\n\nEither do it now or later I guess.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/drivers/modules/ilo/management.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        # package. Raise exception to update the proliantutils package"},{"line_number":90,"context_line":"        # to newer version."},{"line_number":91,"context_line":"        raise exception.NodeCleaningFailure(_("},{"line_number":92,"context_line":"                \"Clean step \u0027%s\u0027 not \""},{"line_number":93,"context_line":"                \"found. \u0027proliantutils\u0027 package needs to be updated.\")"},{"line_number":94,"context_line":"                % step)"},{"line_number":95,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_2b6c4b9b","line":92,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        # package. Raise exception to update the proliantutils package"},{"line_number":90,"context_line":"        # to newer version."},{"line_number":91,"context_line":"        raise exception.NodeCleaningFailure(_("},{"line_number":92,"context_line":"                \"Clean step \u0027%s\u0027 not \""},{"line_number":93,"context_line":"                \"found. \u0027proliantutils\u0027 package needs to be updated.\")"},{"line_number":94,"context_line":"                % step)"},{"line_number":95,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_569ee7b8","line":92,"in_reply_to":"7a016987_2b6c4b9b","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":720,"context_line":"            state \u003d _power_off(driver_info)"},{"line_number":721,"context_line":"        else:"},{"line_number":722,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":723,"context_line":"                    _(\"set_power_state called \""},{"line_number":724,"context_line":"                      \"with invalid power state %s.\") % pstate)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        if state !\u003d pstate:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_8b433f13","line":723,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":720,"context_line":"            state \u003d _power_off(driver_info)"},{"line_number":721,"context_line":"        else:"},{"line_number":722,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":723,"context_line":"                    _(\"set_power_state called \""},{"line_number":724,"context_line":"                      \"with invalid power state %s.\") % pstate)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        if state !\u003d pstate:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_96b45f35","line":723,"in_reply_to":"7a016987_8b433f13","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        if CONF.pxe.ipxe_enabled:"},{"line_number":446,"context_line":"            # Copy the iPXE boot script to HTTP root directory"},{"line_number":447,"context_line":"            bootfile_path \u003d os.path.join("},{"line_number":448,"context_line":"                    CONF.pxe.http_root,"},{"line_number":449,"context_line":"                    os.path.basename(CONF.pxe.ipxe_boot_script))"},{"line_number":450,"context_line":"            shutil.copyfile(CONF.pxe.ipxe_boot_script, bootfile_path)"},{"line_number":451,"context_line":"        pxe_info \u003d _get_image_info(node, task.context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_2bbe8bff","line":448,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        if CONF.pxe.ipxe_enabled:"},{"line_number":446,"context_line":"            # Copy the iPXE boot script to HTTP root directory"},{"line_number":447,"context_line":"            bootfile_path \u003d os.path.join("},{"line_number":448,"context_line":"                    CONF.pxe.http_root,"},{"line_number":449,"context_line":"                    os.path.basename(CONF.pxe.ipxe_boot_script))"},{"line_number":450,"context_line":"            shutil.copyfile(CONF.pxe.ipxe_boot_script, bootfile_path)"},{"line_number":451,"context_line":"        pxe_info \u003d _get_image_info(node, task.context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_76820354","line":448,"in_reply_to":"7a016987_2bbe8bff","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/drivers/modules/ssh.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        \"\"\""},{"line_number":517,"context_line":"        if not driver_utils.get_node_mac_addresses(task):"},{"line_number":518,"context_line":"            raise exception.MissingParameterValue("},{"line_number":519,"context_line":"                    _(\"Node %s does not have \""},{"line_number":520,"context_line":"                      \"any port associated with it.\") % task.node.uuid)"},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            _get_connection(task.node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4bd8a77f","line":519,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        \"\"\""},{"line_number":517,"context_line":"        if not driver_utils.get_node_mac_addresses(task):"},{"line_number":518,"context_line":"            raise exception.MissingParameterValue("},{"line_number":519,"context_line":"                    _(\"Node %s does not have \""},{"line_number":520,"context_line":"                      \"any port associated with it.\") % task.node.uuid)"},{"line_number":521,"context_line":"        try:"},{"line_number":522,"context_line":"            _get_connection(task.node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_76e9e319","line":519,"in_reply_to":"7a016987_4bd8a77f","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            state \u003d _power_off(ssh_obj, driver_info)"},{"line_number":571,"context_line":"        else:"},{"line_number":572,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":573,"context_line":"                    _(\"set_power_state called \""},{"line_number":574,"context_line":"                      \"with invalid power state %s.\") % pstate)"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"        if state !\u003d pstate:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_0be2af2f","line":573,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            state \u003d _power_off(ssh_obj, driver_info)"},{"line_number":571,"context_line":"        else:"},{"line_number":572,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":573,"context_line":"                    _(\"set_power_state called \""},{"line_number":574,"context_line":"                      \"with invalid power state %s.\") % pstate)"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"        if state !\u003d pstate:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_56eca728","line":573,"in_reply_to":"7a016987_0be2af2f","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/drivers/modules/virtualbox.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                                 boot_devices.CDROM: \u0027DVD\u0027,"},{"line_number":38,"context_line":"                                }"},{"line_number":39,"context_line":"VIRTUALBOX_TO_IRONIC_DEVICE_MAPPING \u003d {"},{"line_number":40,"context_line":"        v: k for k, v in IRONIC_TO_VIRTUALBOX_DEVICE_MAPPING.items()}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"VIRTUALBOX_TO_IRONIC_POWER_MAPPING \u003d {"},{"line_number":43,"context_line":"                                \u0027PoweredOff\u0027: states.POWER_OFF,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4b91c799","line":40,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                                 boot_devices.CDROM: \u0027DVD\u0027,"},{"line_number":38,"context_line":"                                }"},{"line_number":39,"context_line":"VIRTUALBOX_TO_IRONIC_DEVICE_MAPPING \u003d {"},{"line_number":40,"context_line":"        v: k for k, v in IRONIC_TO_VIRTUALBOX_DEVICE_MAPPING.items()}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"VIRTUALBOX_TO_IRONIC_POWER_MAPPING \u003d {"},{"line_number":43,"context_line":"                                \u0027PoweredOff\u0027: states.POWER_OFF,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_36f36b0c","line":40,"in_reply_to":"7a016987_4b91c799","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/tests/api/test_base.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_parse_headers_bad_length(self):"},{"line_number":76,"context_line":"        self.assertRaises("},{"line_number":77,"context_line":"                exc.HTTPNotAcceptable,"},{"line_number":78,"context_line":"                cbase.Version.parse_headers,"},{"line_number":79,"context_line":"                {cbase.Version.string: \u00271\u0027},"},{"line_number":80,"context_line":"                mock.ANY,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_0bb4ef32","line":77,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_parse_headers_bad_length(self):"},{"line_number":76,"context_line":"        self.assertRaises("},{"line_number":77,"context_line":"                exc.HTTPNotAcceptable,"},{"line_number":78,"context_line":"                cbase.Version.parse_headers,"},{"line_number":79,"context_line":"                {cbase.Version.string: \u00271\u0027},"},{"line_number":80,"context_line":"                mock.ANY,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d6d89781","line":77,"in_reply_to":"7a016987_0bb4ef32","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                mock.ANY,"},{"line_number":81,"context_line":"                mock.ANY)"},{"line_number":82,"context_line":"        self.assertRaises("},{"line_number":83,"context_line":"                exc.HTTPNotAcceptable,"},{"line_number":84,"context_line":"                cbase.Version.parse_headers,"},{"line_number":85,"context_line":"                {cbase.Version.string: \u00271.2.3\u0027},"},{"line_number":86,"context_line":"                mock.ANY,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_eb81934e","line":83,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                mock.ANY,"},{"line_number":81,"context_line":"                mock.ANY)"},{"line_number":82,"context_line":"        self.assertRaises("},{"line_number":83,"context_line":"                exc.HTTPNotAcceptable,"},{"line_number":84,"context_line":"                cbase.Version.parse_headers,"},{"line_number":85,"context_line":"                {cbase.Version.string: \u00271.2.3\u0027},"},{"line_number":86,"context_line":"                mock.ANY,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_96e21f2e","line":83,"in_reply_to":"7a016987_eb81934e","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/tests/api/v1/test_nodes.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        node \u003d obj_utils.create_test_node(self.context,"},{"line_number":114,"context_line":"                                          chassis_id\u003dself.chassis.id)"},{"line_number":115,"context_line":"        data \u003d self.get_json("},{"line_number":116,"context_line":"                \u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":117,"context_line":"                headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":118,"context_line":"        self.assertEqual(node.uuid, data[\u0027uuid\u0027])"},{"line_number":119,"context_line":"        self.assertIn(\u0027driver\u0027, data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_6b412339","line":116,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        node \u003d obj_utils.create_test_node(self.context,"},{"line_number":114,"context_line":"                                          chassis_id\u003dself.chassis.id)"},{"line_number":115,"context_line":"        data \u003d self.get_json("},{"line_number":116,"context_line":"                \u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":117,"context_line":"                headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":118,"context_line":"        self.assertEqual(node.uuid, data[\u0027uuid\u0027])"},{"line_number":119,"context_line":"        self.assertIn(\u0027driver\u0027, data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_36ca4ba2","line":116,"in_reply_to":"7a016987_6b412339","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                                          provision_state\u003dstates.AVAILABLE)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        data \u003d self.get_json("},{"line_number":170,"context_line":"                \u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":171,"context_line":"                headers\u003d{api_base.Version.string: str(api_v1.MIN_VER)})"},{"line_number":172,"context_line":"        self.assertEqual(states.NOSTATE, data[\u0027provision_state\u0027])"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4b3c27bf","line":170,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                                          provision_state\u003dstates.AVAILABLE)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        data \u003d self.get_json("},{"line_number":170,"context_line":"                \u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":171,"context_line":"                headers\u003d{api_base.Version.string: str(api_v1.MIN_VER)})"},{"line_number":172,"context_line":"        self.assertEqual(states.NOSTATE, data[\u0027provision_state\u0027])"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_16cd0fb7","line":170,"in_reply_to":"7a016987_4b3c27bf","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        node \u003d obj_utils.create_test_node(self.context,"},{"line_number":204,"context_line":"                                          inspection_started_at\u003dsome_time)"},{"line_number":205,"context_line":"        data \u003d self.get_json("},{"line_number":206,"context_line":"                \u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":207,"context_line":"                headers\u003d{api_base.Version.string: str(api_v1.MIN_VER)})"},{"line_number":208,"context_line":"        self.assertNotIn(\u0027inspection_finished_at\u0027, data)"},{"line_number":209,"context_line":"        self.assertNotIn(\u0027inspection_started_at\u0027, data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_eb73d3b2","line":206,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        node \u003d obj_utils.create_test_node(self.context,"},{"line_number":204,"context_line":"                                          inspection_started_at\u003dsome_time)"},{"line_number":205,"context_line":"        data \u003d self.get_json("},{"line_number":206,"context_line":"                \u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":207,"context_line":"                headers\u003d{api_base.Version.string: str(api_v1.MIN_VER)})"},{"line_number":208,"context_line":"        self.assertNotIn(\u0027inspection_finished_at\u0027, data)"},{"line_number":209,"context_line":"        self.assertNotIn(\u0027inspection_started_at\u0027, data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d6bf77fa","line":206,"in_reply_to":"7a016987_eb73d3b2","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":1472,"context_line":"                self.context,"},{"line_number":1473,"context_line":"                instance_uuid\u003d\u0027aaaaaaaa-1111-bbbb-2222-cccccccccccc\u0027)"},{"line_number":1474,"context_line":"        mock_dn.side_effect \u003d exception.NodeAssociated("},{"line_number":1475,"context_line":"                node\u003dnode.uuid, instance\u003dnode.instance_uuid)"},{"line_number":1476,"context_line":""},{"line_number":1477,"context_line":"        response \u003d self.delete(\u0027/nodes/%s\u0027 % node.uuid, expect_errors\u003dTrue)"},{"line_number":1478,"context_line":"        self.assertEqual(409, response.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_cb9db7bc","line":1475,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":1472,"context_line":"                self.context,"},{"line_number":1473,"context_line":"                instance_uuid\u003d\u0027aaaaaaaa-1111-bbbb-2222-cccccccccccc\u0027)"},{"line_number":1474,"context_line":"        mock_dn.side_effect \u003d exception.NodeAssociated("},{"line_number":1475,"context_line":"                node\u003dnode.uuid, instance\u003dnode.instance_uuid)"},{"line_number":1476,"context_line":""},{"line_number":1477,"context_line":"        response \u003d self.delete(\u0027/nodes/%s\u0027 % node.uuid, expect_errors\u003dTrue)"},{"line_number":1478,"context_line":"        self.assertEqual(409, response.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_7637a3b0","line":1475,"in_reply_to":"7a016987_cb9db7bc","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":1517,"context_line":"    def setUp(self):"},{"line_number":1518,"context_line":"        super(TestPut, self).setUp()"},{"line_number":1519,"context_line":"        self.node \u003d obj_utils.create_test_node("},{"line_number":1520,"context_line":"                self.context,"},{"line_number":1521,"context_line":"                provision_state\u003dstates.AVAILABLE, name\u003d\u0027node-39\u0027)"},{"line_number":1522,"context_line":"        p \u003d mock.patch.object(rpcapi.ConductorAPI, \u0027get_topic_for\u0027)"},{"line_number":1523,"context_line":"        self.mock_gtf \u003d p.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4baae7d3","line":1520,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":1517,"context_line":"    def setUp(self):"},{"line_number":1518,"context_line":"        super(TestPut, self).setUp()"},{"line_number":1519,"context_line":"        self.node \u003d obj_utils.create_test_node("},{"line_number":1520,"context_line":"                self.context,"},{"line_number":1521,"context_line":"                provision_state\u003dstates.AVAILABLE, name\u003d\u0027node-39\u0027)"},{"line_number":1522,"context_line":"        p \u003d mock.patch.object(rpcapi.ConductorAPI, \u0027get_topic_for\u0027)"},{"line_number":1523,"context_line":"        self.mock_gtf \u003d p.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_563a6799","line":1520,"in_reply_to":"7a016987_4baae7d3","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/tests/api/v1/test_ports.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        ports \u003d []"},{"line_number":105,"context_line":"        for id_ in range(5):"},{"line_number":106,"context_line":"            port \u003d obj_utils.create_test_port("},{"line_number":107,"context_line":"                    self.context, node_id\u003dself.node.id,"},{"line_number":108,"context_line":"                    uuid\u003duuidutils.generate_uuid(),"},{"line_number":109,"context_line":"                    address\u003d\u002752:54:00:cf:2d:3%s\u0027 % id_)"},{"line_number":110,"context_line":"            ports.append(port.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4b3547d9","line":107,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        ports \u003d []"},{"line_number":105,"context_line":"        for id_ in range(5):"},{"line_number":106,"context_line":"            port \u003d obj_utils.create_test_port("},{"line_number":107,"context_line":"                    self.context, node_id\u003dself.node.id,"},{"line_number":108,"context_line":"                    uuid\u003duuidutils.generate_uuid(),"},{"line_number":109,"context_line":"                    address\u003d\u002752:54:00:cf:2d:3%s\u0027 % id_)"},{"line_number":110,"context_line":"            ports.append(port.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_1644ef18","line":107,"in_reply_to":"7a016987_4b3547d9","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        ports \u003d []"},{"line_number":132,"context_line":"        for id_ in range(5):"},{"line_number":133,"context_line":"            port \u003d obj_utils.create_test_port("},{"line_number":134,"context_line":"                    self.context,"},{"line_number":135,"context_line":"                    node_id\u003dself.node.id,"},{"line_number":136,"context_line":"                    uuid\u003duuidutils.generate_uuid(),"},{"line_number":137,"context_line":"                    address\u003d\u002752:54:00:cf:2d:3%s\u0027 % id_)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_2b344bdc","line":134,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        ports \u003d []"},{"line_number":132,"context_line":"        for id_ in range(5):"},{"line_number":133,"context_line":"            port \u003d obj_utils.create_test_port("},{"line_number":134,"context_line":"                    self.context,"},{"line_number":135,"context_line":"                    node_id\u003dself.node.id,"},{"line_number":136,"context_line":"                    uuid\u003duuidutils.generate_uuid(),"},{"line_number":137,"context_line":"                    address\u003d\u002752:54:00:cf:2d:3%s\u0027 % id_)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f64b9329","line":134,"in_reply_to":"7a016987_2b344bdc","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        ports \u003d []"},{"line_number":148,"context_line":"        for id_ in range(5):"},{"line_number":149,"context_line":"            port \u003d obj_utils.create_test_port("},{"line_number":150,"context_line":"                    self.context,"},{"line_number":151,"context_line":"                    node_id\u003dself.node.id,"},{"line_number":152,"context_line":"                    uuid\u003duuidutils.generate_uuid(),"},{"line_number":153,"context_line":"                    address\u003d\u002752:54:00:cf:2d:3%s\u0027 % id_)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_0b2f4f89","line":150,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        ports \u003d []"},{"line_number":148,"context_line":"        for id_ in range(5):"},{"line_number":149,"context_line":"            port \u003d obj_utils.create_test_port("},{"line_number":150,"context_line":"                    self.context,"},{"line_number":151,"context_line":"                    node_id\u003dself.node.id,"},{"line_number":152,"context_line":"                    uuid\u003duuidutils.generate_uuid(),"},{"line_number":153,"context_line":"                    address\u003d\u002752:54:00:cf:2d:3%s\u0027 % id_)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_b6551bc7","line":150,"in_reply_to":"7a016987_0b2f4f89","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        ports \u003d []"},{"line_number":190,"context_line":"        for id_ in range(3):"},{"line_number":191,"context_line":"            port \u003d obj_utils.create_test_port("},{"line_number":192,"context_line":"                    self.context,"},{"line_number":193,"context_line":"                    node_id\u003dself.node.id,"},{"line_number":194,"context_line":"                    uuid\u003duuidutils.generate_uuid(),"},{"line_number":195,"context_line":"                    address\u003d\u002752:54:00:cf:2d:3%s\u0027 % id_)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_cb4ff768","line":192,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        ports \u003d []"},{"line_number":190,"context_line":"        for id_ in range(3):"},{"line_number":191,"context_line":"            port \u003d obj_utils.create_test_port("},{"line_number":192,"context_line":"                    self.context,"},{"line_number":193,"context_line":"                    node_id\u003dself.node.id,"},{"line_number":194,"context_line":"                    uuid\u003duuidutils.generate_uuid(),"},{"line_number":195,"context_line":"                    address\u003d\u002752:54:00:cf:2d:3%s\u0027 % id_)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_9650dfd5","line":192,"in_reply_to":"7a016987_cb4ff768","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/tests/conductor/test_manager.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":806,"context_line":""},{"line_number":807,"context_line":"        vendor_args \u003d {\u0027test\u0027: \u0027arg\u0027}"},{"line_number":808,"context_line":"        got, is_async \u003d self.service.driver_vendor_passthru("},{"line_number":809,"context_line":"                self.context, \u0027fake\u0027, \u0027test_sync_method\u0027, \u0027POST\u0027, vendor_args)"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"        # Assert that the vendor interface has no custom"},{"line_number":812,"context_line":"        # driver_vendor_passthru()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_1001be06","line":809,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":806,"context_line":""},{"line_number":807,"context_line":"        vendor_args \u003d {\u0027test\u0027: \u0027arg\u0027}"},{"line_number":808,"context_line":"        got, is_async \u003d self.service.driver_vendor_passthru("},{"line_number":809,"context_line":"                self.context, \u0027fake\u0027, \u0027test_sync_method\u0027, \u0027POST\u0027, vendor_args)"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"        # Assert that the vendor interface has no custom"},{"line_number":812,"context_line":"        # driver_vendor_passthru()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_b66cfb9c","line":809,"in_reply_to":"7a016987_1001be06","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/tests/drivers/amt/test_management.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        amt_mgmt._set_boot_device_order(self.node, device)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        mock_pywsman.invoke.assert_called_once_with("},{"line_number":60,"context_line":"                mock.ANY, namespace, \u0027ChangeBootOrder\u0027, mock.ANY)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test__set_boot_device_order_fail(self, mock_client_pywsman):"},{"line_number":63,"context_line":"        namespace \u003d resource_uris.CIM_BootConfigSetting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_705eb246","line":60,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        amt_mgmt._set_boot_device_order(self.node, device)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        mock_pywsman.invoke.assert_called_once_with("},{"line_number":60,"context_line":"                mock.ANY, namespace, \u0027ChangeBootOrder\u0027, mock.ANY)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test__set_boot_device_order_fail(self, mock_client_pywsman):"},{"line_number":63,"context_line":"        namespace \u003d resource_uris.CIM_BootConfigSetting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_360febe2","line":60,"in_reply_to":"7a016987_705eb246","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.assertRaises(exception.AMTFailure,"},{"line_number":72,"context_line":"                          amt_mgmt._set_boot_device_order, self.node, device)"},{"line_number":73,"context_line":"        mock_pywsman.invoke.assert_called_once_with("},{"line_number":74,"context_line":"                mock.ANY, namespace, \u0027ChangeBootOrder\u0027, mock.ANY)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        mock_pywsman \u003d mock_client_pywsman.Client.return_value"},{"line_number":77,"context_line":"        mock_pywsman.invoke.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_30583a56","line":74,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.assertRaises(exception.AMTFailure,"},{"line_number":72,"context_line":"                          amt_mgmt._set_boot_device_order, self.node, device)"},{"line_number":73,"context_line":"        mock_pywsman.invoke.assert_called_once_with("},{"line_number":74,"context_line":"                mock.ANY, namespace, \u0027ChangeBootOrder\u0027, mock.ANY)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        mock_pywsman \u003d mock_client_pywsman.Client.return_value"},{"line_number":77,"context_line":"        mock_pywsman.invoke.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f6f953c9","line":74,"in_reply_to":"7a016987_30583a56","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.assertRaises(exception.AMTFailure,"},{"line_number":104,"context_line":"                          amt_mgmt._enable_boot_config, self.node)"},{"line_number":105,"context_line":"        mock_pywsman.invoke.assert_called_once_with("},{"line_number":106,"context_line":"                mock.ANY, namespace, \u0027SetBootConfigRole\u0027, mock.ANY)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        mock_pywsman \u003d mock_client_pywsman.Client.return_value"},{"line_number":109,"context_line":"        mock_pywsman.invoke.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d0332612","line":106,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.assertRaises(exception.AMTFailure,"},{"line_number":104,"context_line":"                          amt_mgmt._enable_boot_config, self.node)"},{"line_number":105,"context_line":"        mock_pywsman.invoke.assert_called_once_with("},{"line_number":106,"context_line":"                mock.ANY, namespace, \u0027SetBootConfigRole\u0027, mock.ANY)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        mock_pywsman \u003d mock_client_pywsman.Client.return_value"},{"line_number":109,"context_line":"        mock_pywsman.invoke.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_b603dbb7","line":106,"in_reply_to":"7a016987_d0332612","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/tests/drivers/amt/test_power.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        mock_client \u003d mock_client_pywsman.return_value"},{"line_number":56,"context_line":"        amt_power._set_power_state(self.node, states.POWER_ON)"},{"line_number":57,"context_line":"        mock_client.wsman_invoke.assert_called_once_with("},{"line_number":58,"context_line":"                mock.ANY, namespace, \u0027RequestPowerStateChange\u0027, mock.ANY)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @mock.patch.object(amt_common, \u0027get_wsman_client\u0027, spec_set\u003dTrue,"},{"line_number":61,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d04c469f","line":58,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        mock_client \u003d mock_client_pywsman.return_value"},{"line_number":56,"context_line":"        amt_power._set_power_state(self.node, states.POWER_ON)"},{"line_number":57,"context_line":"        mock_client.wsman_invoke.assert_called_once_with("},{"line_number":58,"context_line":"                mock.ANY, namespace, \u0027RequestPowerStateChange\u0027, mock.ANY)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @mock.patch.object(amt_common, \u0027get_wsman_client\u0027, spec_set\u003dTrue,"},{"line_number":61,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_562f073e","line":58,"in_reply_to":"7a016987_d04c469f","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/tests/drivers/amt/test_vendor.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        super(AMTPXEVendorPassthruTestCase, self).setUp()"},{"line_number":35,"context_line":"        mgr_utils.mock_the_extension_manager(driver\u003d\"pxe_amt\")"},{"line_number":36,"context_line":"        self.node \u003d obj_utils.create_test_node("},{"line_number":37,"context_line":"                self.context, driver\u003d\u0027pxe_amt\u0027, driver_info\u003dINFO_DICT)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_vendor_routes(self):"},{"line_number":40,"context_line":"        expected \u003d [\u0027heartbeat\u0027, \u0027pass_deploy_info\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_107c1eb4","line":37,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        super(AMTPXEVendorPassthruTestCase, self).setUp()"},{"line_number":35,"context_line":"        mgr_utils.mock_the_extension_manager(driver\u003d\"pxe_amt\")"},{"line_number":36,"context_line":"        self.node \u003d obj_utils.create_test_node("},{"line_number":37,"context_line":"                self.context, driver\u003d\u0027pxe_amt\u0027, driver_info\u003dINFO_DICT)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_vendor_routes(self):"},{"line_number":40,"context_line":"        expected \u003d [\u0027heartbeat\u0027, \u0027pass_deploy_info\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_16298f37","line":37,"in_reply_to":"7a016987_107c1eb4","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/tests/drivers/drac/test_client.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            mock_client_pywsman.FLAG_ENUMERATION_OPTIMIZATION)"},{"line_number":51,"context_line":"        mock_options.set_max_elements.assert_called_once_with(100)"},{"line_number":52,"context_line":"        mock_pywsman_client.enumerate.assert_called_once_with("},{"line_number":53,"context_line":"                mock_options, None, self.resource_uri)"},{"line_number":54,"context_line":"        mock_xml.context.assert_called_once_with()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_50abb61e","line":53,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            mock_client_pywsman.FLAG_ENUMERATION_OPTIMIZATION)"},{"line_number":51,"context_line":"        mock_options.set_max_elements.assert_called_once_with(100)"},{"line_number":52,"context_line":"        mock_pywsman_client.enumerate.assert_called_once_with("},{"line_number":53,"context_line":"                mock_options, None, self.resource_uri)"},{"line_number":54,"context_line":"        mock_xml.context.assert_called_once_with()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f620334b","line":53,"in_reply_to":"7a016987_50abb61e","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            mock_client_pywsman.FLAG_ENUMERATION_OPTIMIZATION)"},{"line_number":100,"context_line":"        mock_options.set_max_elements.assert_called_once_with(100)"},{"line_number":101,"context_line":"        mock_pywsman_client.enumerate.assert_called_once_with("},{"line_number":102,"context_line":"                mock_options, None, self.resource_uri)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_wsman_enumerate_filter_query(self, mock_client_pywsman):"},{"line_number":105,"context_line":"        mock_xml \u003d test_utils.mock_wsman_root(\u0027\u003ctest\u003e\u003c/test\u003e\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_90b80e77","line":102,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            mock_client_pywsman.FLAG_ENUMERATION_OPTIMIZATION)"},{"line_number":100,"context_line":"        mock_options.set_max_elements.assert_called_once_with(100)"},{"line_number":101,"context_line":"        mock_pywsman_client.enumerate.assert_called_once_with("},{"line_number":102,"context_line":"                mock_options, None, self.resource_uri)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_wsman_enumerate_filter_query(self, mock_client_pywsman):"},{"line_number":105,"context_line":"        mock_xml \u003d test_utils.mock_wsman_root(\u0027\u003ctest\u003e\u003c/test\u003e\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_d61bf71a","line":102,"in_reply_to":"7a016987_90b80e77","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        mock_filter \u003d mock_client_pywsman.Filter.return_value"},{"line_number":115,"context_line":"        mock_filter.simple.assert_called_once_with(mock.ANY, filter_query)"},{"line_number":116,"context_line":"        mock_pywsman_client.enumerate.assert_called_once_with("},{"line_number":117,"context_line":"                mock_options, mock_filter, self.resource_uri)"},{"line_number":118,"context_line":"        mock_xml.context.assert_called_once_with()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_wsman_enumerate_invalid_filter_dialect(self, mock_client_pywsman):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_30aa7a1a","line":117,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        mock_filter \u003d mock_client_pywsman.Filter.return_value"},{"line_number":115,"context_line":"        mock_filter.simple.assert_called_once_with(mock.ANY, filter_query)"},{"line_number":116,"context_line":"        mock_pywsman_client.enumerate.assert_called_once_with("},{"line_number":117,"context_line":"                mock_options, mock_filter, self.resource_uri)"},{"line_number":118,"context_line":"        mock_xml.context.assert_called_once_with()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_wsman_enumerate_invalid_filter_dialect(self, mock_client_pywsman):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_b61abb15","line":117,"in_reply_to":"7a016987_30aa7a1a","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        mock_options \u003d mock_client_pywsman.ClientOptions.return_value"},{"line_number":139,"context_line":"        mock_pywsman_client.invoke.assert_called_once_with("},{"line_number":140,"context_line":"                mock_options, self.resource_uri, method_name, None)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"},{"line_number":143,"context_line":"    def test_wsman_invoke_retry(self, mock_client_pywsman):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f062a215","line":140,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        mock_options \u003d mock_client_pywsman.ClientOptions.return_value"},{"line_number":139,"context_line":"        mock_pywsman_client.invoke.assert_called_once_with("},{"line_number":140,"context_line":"                mock_options, self.resource_uri, method_name, None)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"},{"line_number":143,"context_line":"    def test_wsman_invoke_retry(self, mock_client_pywsman):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_96157fe6","line":140,"in_reply_to":"7a016987_f062a215","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/tests/drivers/drac/test_management.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test__get_next_boot_mode(self, mock_client_pywsman):"},{"line_number":52,"context_line":"        result_xml \u003d test_utils.build_soap_xml("},{"line_number":53,"context_line":"                [{\u0027DCIM_BootConfigSetting\u0027:"},{"line_number":54,"context_line":"                    {\u0027InstanceID\u0027: \u0027IPL\u0027,"},{"line_number":55,"context_line":"                     \u0027IsNext\u0027: drac_mgmt.PERSISTENT}}],"},{"line_number":56,"context_line":"                resource_uris.DCIM_BootConfigSetting)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_30fcba3d","line":53,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test__get_next_boot_mode(self, mock_client_pywsman):"},{"line_number":52,"context_line":"        result_xml \u003d test_utils.build_soap_xml("},{"line_number":53,"context_line":"                [{\u0027DCIM_BootConfigSetting\u0027:"},{"line_number":54,"context_line":"                    {\u0027InstanceID\u0027: \u0027IPL\u0027,"},{"line_number":55,"context_line":"                     \u0027IsNext\u0027: drac_mgmt.PERSISTENT}}],"},{"line_number":56,"context_line":"                resource_uris.DCIM_BootConfigSetting)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_56d6e727","line":53,"in_reply_to":"7a016987_30fcba3d","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test__get_next_boot_mode_onetime(self, mock_client_pywsman):"},{"line_number":70,"context_line":"        result_xml \u003d test_utils.build_soap_xml("},{"line_number":71,"context_line":"                [{\u0027DCIM_BootConfigSetting\u0027:"},{"line_number":72,"context_line":"                    {\u0027InstanceID\u0027: \u0027IPL\u0027,"},{"line_number":73,"context_line":"                     \u0027IsNext\u0027: drac_mgmt.PERSISTENT}},"},{"line_number":74,"context_line":"                 {\u0027DCIM_BootConfigSetting\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_5084d6af","line":71,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test__get_next_boot_mode_onetime(self, mock_client_pywsman):"},{"line_number":70,"context_line":"        result_xml \u003d test_utils.build_soap_xml("},{"line_number":71,"context_line":"                [{\u0027DCIM_BootConfigSetting\u0027:"},{"line_number":72,"context_line":"                    {\u0027InstanceID\u0027: \u0027IPL\u0027,"},{"line_number":73,"context_line":"                     \u0027IsNext\u0027: drac_mgmt.PERSISTENT}},"},{"line_number":74,"context_line":"                 {\u0027DCIM_BootConfigSetting\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_36ddab42","line":71,"in_reply_to":"7a016987_5084d6af","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test__check_for_config_job_already_exist(self, mock_client_pywsman):"},{"line_number":108,"context_line":"        result_xml \u003d test_utils.build_soap_xml("},{"line_number":109,"context_line":"                [{\u0027DCIM_LifecycleJob\u0027:"},{"line_number":110,"context_line":"                    {\u0027Name\u0027: \u0027BIOS.Setup.1-1\u0027,"},{"line_number":111,"context_line":"                     \u0027JobStatus\u0027: \u0027scheduled\u0027,"},{"line_number":112,"context_line":"                     \u0027InstanceID\u0027: \u0027fake\u0027}}],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_b09e6a05","line":109,"updated":"2015-05-27 17:27:55.000000000","message":"Why 8 spaces?  I like 8 spaces for a \u0027def\u0027 line, but not here.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test__check_for_config_job_already_exist(self, mock_client_pywsman):"},{"line_number":108,"context_line":"        result_xml \u003d test_utils.build_soap_xml("},{"line_number":109,"context_line":"                [{\u0027DCIM_LifecycleJob\u0027:"},{"line_number":110,"context_line":"                    {\u0027Name\u0027: \u0027BIOS.Setup.1-1\u0027,"},{"line_number":111,"context_line":"                     \u0027JobStatus\u0027: \u0027scheduled\u0027,"},{"line_number":112,"context_line":"                     \u0027InstanceID\u0027: \u0027fake\u0027}}],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_16e06ff9","line":109,"in_reply_to":"7a016987_b09e6a05","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"ironic/tests/test_hash_ring.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        conductors \u003d [str(x) for x in range(num_conductors)]"},{"line_number":164,"context_line":"        new_conductors \u003d conductors + [\u0027new\u0027]"},{"line_number":165,"context_line":"        delta \u003d self._compare_rings("},{"line_number":166,"context_line":"                    nodes, conductors, hash_ring.HashRing(conductors),"},{"line_number":167,"context_line":"                    new_conductors, hash_ring.HashRing(new_conductors))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self.assertTrue(len(delta) \u003c num_nodes * redistribution_factor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_30adda88","line":166,"updated":"2015-05-27 17:27:55.000000000","message":"Why not 4 spaces?","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        conductors \u003d [str(x) for x in range(num_conductors)]"},{"line_number":164,"context_line":"        new_conductors \u003d conductors + [\u0027new\u0027]"},{"line_number":165,"context_line":"        delta \u003d self._compare_rings("},{"line_number":166,"context_line":"                    nodes, conductors, hash_ring.HashRing(conductors),"},{"line_number":167,"context_line":"                    new_conductors, hash_ring.HashRing(new_conductors))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self.assertTrue(len(delta) \u003c num_nodes * redistribution_factor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f695d33f","line":166,"in_reply_to":"7a016987_30adda88","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        new_conductors \u003d conductors[:]"},{"line_number":182,"context_line":"        new_conductors.pop()"},{"line_number":183,"context_line":"        delta \u003d self._compare_rings("},{"line_number":184,"context_line":"                    nodes, conductors, hash_ring.HashRing(conductors),"},{"line_number":185,"context_line":"                    new_conductors, hash_ring.HashRing(new_conductors))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.assertTrue(len(delta) \u003c num_nodes * redistribution_factor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f0b502d0","line":184,"updated":"2015-05-27 17:27:55.000000000","message":"Why not 4 spaces?","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        new_conductors \u003d conductors[:]"},{"line_number":182,"context_line":"        new_conductors.pop()"},{"line_number":183,"context_line":"        delta \u003d self._compare_rings("},{"line_number":184,"context_line":"                    nodes, conductors, hash_ring.HashRing(conductors),"},{"line_number":185,"context_line":"                    new_conductors, hash_ring.HashRing(new_conductors))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.assertTrue(len(delta) \u003c num_nodes * redistribution_factor)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_969a1f6d","line":184,"in_reply_to":"7a016987_f0b502d0","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}],"tox.ini":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee2e1fceef5a549376a765da8549b7ad966a83c0","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"[flake8]"},{"line_number":78,"context_line":"# E711: ignored because it is normal to use \"column \u003d\u003d None\" in sqlalchemy"},{"line_number":79,"context_line":"ignore \u003d E711,E129,E123,E126,E127"},{"line_number":80,"context_line":"exclude \u003d  .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,*ironic/nova*"},{"line_number":81,"context_line":"max-complexity\u003d17"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"7a016987_a406331e","line":79,"updated":"2015-05-27 15:09:32.000000000","message":"why reorder here?","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"828ef72beec735b200b2b9eee6c02cfa085e850c","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"[flake8]"},{"line_number":78,"context_line":"# E711: ignored because it is normal to use \"column \u003d\u003d None\" in sqlalchemy"},{"line_number":79,"context_line":"ignore \u003d E711,E129,E123,E126,E127"},{"line_number":80,"context_line":"exclude \u003d  .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,*ironic/nova*"},{"line_number":81,"context_line":"max-complexity\u003d17"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"7a016987_bf8400b1","line":79,"in_reply_to":"7a016987_a406331e","updated":"2015-05-27 15:40:23.000000000","message":"Not really sure why I reordered it, I think it made sense in my head at the time, I\u0027ll put it back to the right order and just have E128 removed.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e07f75b96e5b1c2ea6d32428bd3a3308c20d9428","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"[flake8]"},{"line_number":78,"context_line":"# E711: ignored because it is normal to use \"column \u003d\u003d None\" in sqlalchemy"},{"line_number":79,"context_line":"ignore \u003d E711,E129,E123,E126,E127"},{"line_number":80,"context_line":"exclude \u003d  .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,*ironic/nova*"},{"line_number":81,"context_line":"max-complexity\u003d17"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"7a016987_d0d2065b","line":79,"in_reply_to":"7a016987_bf8400b1","updated":"2015-05-27 17:27:55.000000000","message":"Please do go back to original order.","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bea995ebfd522553ace4efbd081569f850b9a875","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"[flake8]"},{"line_number":78,"context_line":"# E711: ignored because it is normal to use \"column \u003d\u003d None\" in sqlalchemy"},{"line_number":79,"context_line":"ignore \u003d E711,E129,E123,E126,E127"},{"line_number":80,"context_line":"exclude \u003d  .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,*ironic/nova*"},{"line_number":81,"context_line":"max-complexity\u003d17"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"7a016987_9671ff46","line":79,"in_reply_to":"7a016987_d0d2065b","updated":"2015-05-28 16:15:26.000000000","message":"Done","commit_id":"453c1fb4a01ae9eac1eb3d0966dcd577cbdacd84"}]}