)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b32e0403f4c1e6697456a38aa293e68435374e68","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add vendor-passthru to attach and boot an ISO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds a new vendor-passthru \u0027boot_into_iso\u0027 "},{"line_number":10,"context_line":"in iscsi_ilo driver to attach and boot from an ISO"},{"line_number":11,"context_line":"located in Glance or an HTTP(s) URL.  This vendor passthru"},{"line_number":12,"context_line":"can be invoked only when the node is in manage state or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afb71cf_61fbe647","line":9,"updated":"2015-06-11 09:33:41.000000000","message":"Trailing space. Btw, if you use VIM a cool thing to have on ur ~/.vimrc is:\n\n autocmd BufWritePre * :%s/\\s\\+$//e\n\nThis will remove all trailing spaces once you save the file.","commit_id":"f66d9d37c0faee3e2dd690deeb92a3d5c85b5d5b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b81e33fd581652a8c2ac12ad359ad4873590fae1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add vendor-passthru to attach and boot an ISO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds a new vendor-passthru \u0027boot_into_iso\u0027 "},{"line_number":10,"context_line":"in iscsi_ilo driver to attach and boot from an ISO"},{"line_number":11,"context_line":"located in Glance or an HTTP(s) URL.  This vendor passthru"},{"line_number":12,"context_line":"can be invoked only when the node is in manage state or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afb71cf_a17afeba","line":9,"in_reply_to":"3afb71cf_61fbe647","updated":"2015-06-11 09:36:23.000000000","message":"I have this in vimrc.  I had edited the commit message from gerrit itself :)","commit_id":"f66d9d37c0faee3e2dd690deeb92a3d5c85b5d5b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b32e0403f4c1e6697456a38aa293e68435374e68","unresolved":false,"context_lines":[{"line_number":13,"context_line":"in maintenance mode.  This vendor-passthru can help in"},{"line_number":14,"context_line":"debugging issues with bare metal node."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partial-Bug: 1464168"},{"line_number":17,"context_line":"Change-Id: I75c5363b1df13b12c8f025a4b45de02367229f8f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afb71cf_61e406ab","line":16,"updated":"2015-06-11 09:33:41.000000000","message":"This patch seems to close that bug, what else is needed to be done?\n\nCloses-Bug: #1464168","commit_id":"f66d9d37c0faee3e2dd690deeb92a3d5c85b5d5b"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b81e33fd581652a8c2ac12ad359ad4873590fae1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"in maintenance mode.  This vendor-passthru can help in"},{"line_number":14,"context_line":"debugging issues with bare metal node."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partial-Bug: 1464168"},{"line_number":17,"context_line":"Change-Id: I75c5363b1df13b12c8f025a4b45de02367229f8f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afb71cf_e1423667","line":16,"in_reply_to":"3afb71cf_61e406ab","updated":"2015-06-11 09:36:23.000000000","message":"Oh, I mentioned as a comment (looks like not the right place).  The same can be done for agent_ilo as well.  I will add it in a separate patch.","commit_id":"f66d9d37c0faee3e2dd690deeb92a3d5c85b5d5b"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ed7d8eb43d2de1c911676a9b019bfdcfa62052c4","unresolved":false,"context_lines":[{"line_number":740,"context_line":"            raise exception.InvalidStateRequested("},{"line_number":741,"context_line":"                action\u003daction, node\u003dtask.node.uuid,"},{"line_number":742,"context_line":"                state\u003dtask.node.provision_state)"},{"line_number":743,"context_line":"        d_info \u003d {\u0027image_source\u0027: kwargs.get(\u0027image_source\u0027)}"},{"line_number":744,"context_line":"        error_msg \u003d _(\"Error validating input for boot_into_iso vendor \""},{"line_number":745,"context_line":"                      \"passthru. Some parameters were not provided: \")"},{"line_number":746,"context_line":"        deploy_utils.check_for_missing_params(d_info, error_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_941449a0","line":743,"updated":"2015-06-09 11:40:11.000000000","message":"Better rename to \u0027iso_source\u0027 or \u0027boot_iso_source\u0027.","commit_id":"91229bbf3166ee8e5c01be580bf3c331ec47fdfa"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"8a6cfda0d583e02f34b6da307ddb71f13cb8b7da","unresolved":false,"context_lines":[{"line_number":740,"context_line":"            raise exception.InvalidStateRequested("},{"line_number":741,"context_line":"                action\u003daction, node\u003dtask.node.uuid,"},{"line_number":742,"context_line":"                state\u003dtask.node.provision_state)"},{"line_number":743,"context_line":"        d_info \u003d {\u0027image_source\u0027: kwargs.get(\u0027image_source\u0027)}"},{"line_number":744,"context_line":"        error_msg \u003d _(\"Error validating input for boot_into_iso vendor \""},{"line_number":745,"context_line":"                      \"passthru. Some parameters were not provided: \")"},{"line_number":746,"context_line":"        deploy_utils.check_for_missing_params(d_info, error_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_eaab9873","line":743,"in_reply_to":"3afb71cf_941449a0","updated":"2015-06-09 12:18:25.000000000","message":"Done","commit_id":"91229bbf3166ee8e5c01be580bf3c331ec47fdfa"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ed7d8eb43d2de1c911676a9b019bfdcfa62052c4","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":747,"context_line":"        iscsi_deploy.validate_image_properties(task.context, d_info, [])"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":750,"context_line":"    def boot_into_iso(self, task, **kwargs):"},{"line_number":751,"context_line":"        \"\"\"Attaches an ISO image in glance and reboots bare metal."},{"line_number":752,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_914c5b9f","line":749,"updated":"2015-06-09 11:40:11.000000000","message":"We do an \"exclusive\" action on a node. Please add @task_manager.require_exclusive_lock check.","commit_id":"91229bbf3166ee8e5c01be580bf3c331ec47fdfa"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"8a6cfda0d583e02f34b6da307ddb71f13cb8b7da","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":747,"context_line":"        iscsi_deploy.validate_image_properties(task.context, d_info, [])"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":750,"context_line":"    def boot_into_iso(self, task, **kwargs):"},{"line_number":751,"context_line":"        \"\"\"Attaches an ISO image in glance and reboots bare metal."},{"line_number":752,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_aab800c9","line":749,"in_reply_to":"3afb71cf_914c5b9f","updated":"2015-06-09 12:18:25.000000000","message":"Done","commit_id":"91229bbf3166ee8e5c01be580bf3c331ec47fdfa"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ed7d8eb43d2de1c911676a9b019bfdcfa62052c4","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        This method accepts an ISO image href (a Glance UUID or an HTTP(S) URL)"},{"line_number":754,"context_line":"        attaches it as virtual media and then reboots the node.  This is"},{"line_number":755,"context_line":"        useful for debugging purposes.  This can be invoked only when the node"},{"line_number":756,"context_line":"        is in manage state."},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        :param task: A TaskManager object."}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_74e42de0","line":755,"updated":"2015-06-09 11:40:11.000000000","message":"If it for debugging maybe makes sense allow it for error states (or for maintenance mode).","commit_id":"91229bbf3166ee8e5c01be580bf3c331ec47fdfa"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"8a6cfda0d583e02f34b6da307ddb71f13cb8b7da","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        This method accepts an ISO image href (a Glance UUID or an HTTP(S) URL)"},{"line_number":754,"context_line":"        attaches it as virtual media and then reboots the node.  This is"},{"line_number":755,"context_line":"        useful for debugging purposes.  This can be invoked only when the node"},{"line_number":756,"context_line":"        is in manage state."},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        :param task: A TaskManager object."}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_eac27833","line":755,"in_reply_to":"3afb71cf_74e42de0","updated":"2015-06-09 12:18:25.000000000","message":"I think I will go for maintenance mode.  manage state or maintenance flag set.  WDYT ?","commit_id":"91229bbf3166ee8e5c01be580bf3c331ec47fdfa"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"de1d243e54134ac7eb08253b0d2cdfca179cd1f8","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        This method accepts an ISO image href (a Glance UUID or an HTTP(S) URL)"},{"line_number":754,"context_line":"        attaches it as virtual media and then reboots the node.  This is"},{"line_number":755,"context_line":"        useful for debugging purposes.  This can be invoked only when the node"},{"line_number":756,"context_line":"        is in manage state."},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        :param task: A TaskManager object."}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_4a474c77","line":755,"in_reply_to":"3afb71cf_eac27833","updated":"2015-06-09 12:22:49.000000000","message":"Looks good.","commit_id":"91229bbf3166ee8e5c01be580bf3c331ec47fdfa"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"680ccc00cf59d1998019d8307af947b915c7e914","unresolved":false,"context_lines":[{"line_number":741,"context_line":"                     \"only when node %(node_uuid)s is in %(state)s state or \""},{"line_number":742,"context_line":"                     \"in \u0027maintenance\u0027 mode\") %"},{"line_number":743,"context_line":"                   {\u0027node_uuid\u0027: task.node.uuid,"},{"line_number":744,"context_line":"                    \u0027state\u0027: states.MANAGEABLE})"},{"line_number":745,"context_line":"            raise exception.InvalidStateRequested(msg)"},{"line_number":746,"context_line":"        d_info \u003d {\u0027boot_iso_href\u0027: kwargs.get(\u0027boot_iso_href\u0027)}"},{"line_number":747,"context_line":"        error_msg \u003d _(\"Error validating input for boot_into_iso vendor \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_79598834","line":744,"updated":"2015-06-10 13:12:38.000000000","message":"Looks like a type of rescue...","commit_id":"bec51ee01bca250415441925bda56d8f29eb10e4"}]}