)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ed9078c6d0cd9839940bf0abc1cc99d9ad2c4f8a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix failing unit tests under py34"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running the unit tests on Fedora 21 under py34, several of them"},{"line_number":10,"context_line":"fail with \"TypeError: \u0027xxx\u0027 object is not iterable\".  This is due to a"},{"line_number":11,"context_line":"bug in mock: http://bugs.python.org/issue23661."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1af86dd1_6d48525c","line":9,"updated":"2015-06-12 14:09:20.000000000","message":"btw perhaps we should update it and say Python \u003e\u003d 3.4.2, instead of Fedora 21","commit_id":"7d82c4c2358e503d6acd1d7a7d62993feeb5d639"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"65a64c38e12f0794ad725d1c3186389db36b33f8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix failing unit tests under py34"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running the unit tests on Fedora 21 under py34, several of them"},{"line_number":10,"context_line":"fail with \"TypeError: \u0027xxx\u0027 object is not iterable\".  This is due to a"},{"line_number":11,"context_line":"bug in mock: http://bugs.python.org/issue23661."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1af86dd1_1697a691","line":9,"in_reply_to":"1af86dd1_6d48525c","updated":"2015-06-12 17:15:08.000000000","message":"Sorry Lucas, didn\u0027t mean to overlook your comment.","commit_id":"7d82c4c2358e503d6acd1d7a7d62993feeb5d639"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c240ca36415ad3851c21a015d2aefc623c0937c9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix failing unit tests under py34"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running the unit tests on Fedora 21 under py34, several of them"},{"line_number":10,"context_line":"fail with \"TypeError: \u0027xxx\u0027 object is not iterable\".  This is due to a"},{"line_number":11,"context_line":"bug in mock: http://bugs.python.org/issue23661."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1af86dd1_e371f3e1","line":9,"updated":"2015-06-12 15:20:55.000000000","message":"I agree with Lucas\u0027 comment in patch set 1.  State that this is for Python \u003e\u003d 3.4.2","commit_id":"19de24cbc78e703e088d4d96f46006037fb233b6"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3c7c88b95f25f1dde5ce9606188719e7964386c8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix failing unit tests under py34"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running the unit tests on Fedora 21 under py34, several of them"},{"line_number":10,"context_line":"fail with \"TypeError: \u0027xxx\u0027 object is not iterable\".  This is due to a"},{"line_number":11,"context_line":"bug in mock: http://bugs.python.org/issue23661."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1af86dd1_db55b7c6","line":9,"updated":"2015-06-12 16:54:55.000000000","message":"I agree with Lucas\u0027 comment in patch set 1. State that this is for Python \u003e\u003d 3.4.2\n\nI don\u0027t think even need to mention Fedora.","commit_id":"66243661f6618338bf15a0d2ff35fb806a17aa79"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"32b9c8de00ecf3c4212ac5410d0d3197a2a72918","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix failing unit tests under py34"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When running the unit tests on Fedora 21 under py34, several of them"},{"line_number":10,"context_line":"fail with \"TypeError: \u0027xxx\u0027 object is not iterable\".  This is due to a"},{"line_number":11,"context_line":"bug in mock: http://bugs.python.org/issue23661."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1af86dd1_b6b6923b","line":9,"in_reply_to":"1af86dd1_db55b7c6","updated":"2015-06-12 17:14:28.000000000","message":"Sorry guys!  Don\u0027t know how I managed to overlook that comment twice.","commit_id":"66243661f6618338bf15a0d2ff35fb806a17aa79"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f3ed250af925f1de58a756b5b7bccd6c3c192f01","unresolved":false,"context_lines":[{"line_number":14,"context_line":"iterable.  This change makes the unit tests work on both py27 and py34."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4bcda02bb5756fea2a8daecc238ef7439ad43700"},{"line_number":17,"context_line":"Closes-Bug: #1463867"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_ab97cbea","line":17,"updated":"2015-07-01 16:15:06.000000000","message":"There are two more tests failing: http://paste.openstack.org/show/332510/\n\nAlso, I would leave this bug open even if this patch merges (Partial-Bug). Because we don\u0027t have a way to assert that new code that uses side_effect without an iterable object will actually fail. I was thinking here, maybe we should introduce a hacking rule for that? \n\nhttp://docs.openstack.org/developer/hacking","commit_id":"173438c667388437129c27d896e8f9c9ec26a63c"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"c496bc28e8adf0d186d895ce15658bd28ac8c3c9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"iterable.  This change makes the unit tests work on both py27 and py34."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4bcda02bb5756fea2a8daecc238ef7439ad43700"},{"line_number":17,"context_line":"Closes-Bug: #1463867"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_9f86bad9","line":17,"in_reply_to":"ba3cc151_ab97cbea","updated":"2015-07-01 18:29:59.000000000","message":"Fixed the 2 additional tests and changed to Partial-Bug.\n\nNo idea how to introduce a hacking rule.  I guess I\u0027ll bring this up in IRC.","commit_id":"173438c667388437129c27d896e8f9c9ec26a63c"}],"ironic/tests/drivers/test_inspector.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c240ca36415ad3851c21a015d2aefc623c0937c9","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        mock_acquire.side_effect \u003d iter([exception.NodeLocked(\"boom\")] *"},{"line_number":214,"context_line":"                                        len(iter_nodes_ret))"},{"line_number":215,"context_line":"        mgr \u003d mock.MagicMock(spec\u003d[\u0027iter_nodes\u0027])"},{"line_number":216,"context_line":"        mgr.iter_nodes.return_value \u003d [(\u00271\u0027, \u0027d1\u0027), (\u00272\u0027, \u0027d2\u0027)]"},{"line_number":217,"context_line":"        inspector.Inspector()._periodic_check_result("},{"line_number":218,"context_line":"            mgr, mock.sentinel.context)"},{"line_number":219,"context_line":"        self.assertFalse(mock_check.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af86dd1_0312cf62","line":216,"updated":"2015-06-12 15:20:55.000000000","message":"Shouldn\u0027t this use iter_nodes_ret?","commit_id":"19de24cbc78e703e088d4d96f46006037fb233b6"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"3a1cb88251bcaec05d128187375a080ae19ee1df","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        mock_acquire.side_effect \u003d iter([exception.NodeLocked(\"boom\")] *"},{"line_number":214,"context_line":"                                        len(iter_nodes_ret))"},{"line_number":215,"context_line":"        mgr \u003d mock.MagicMock(spec\u003d[\u0027iter_nodes\u0027])"},{"line_number":216,"context_line":"        mgr.iter_nodes.return_value \u003d [(\u00271\u0027, \u0027d1\u0027), (\u00272\u0027, \u0027d2\u0027)]"},{"line_number":217,"context_line":"        inspector.Inspector()._periodic_check_result("},{"line_number":218,"context_line":"            mgr, mock.sentinel.context)"},{"line_number":219,"context_line":"        self.assertFalse(mock_check.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af86dd1_db1db767","line":216,"in_reply_to":"1af86dd1_0312cf62","updated":"2015-06-12 16:52:24.000000000","message":"Thanks for the catch!","commit_id":"19de24cbc78e703e088d4d96f46006037fb233b6"}],"ironic/tests/drivers/test_ipmitool.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0304fcad44a72e2627c25345c543c51e308c898b","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        side_effects \u003d []"},{"line_number":303,"context_line":"        for opt in options:"},{"line_number":304,"context_line":"            side_effects.append(processutils.ProcessExecutionError())"},{"line_number":305,"context_line":"        mock_exc.side_effect \u003d iter(side_effects)"},{"line_number":306,"context_line":"        mock_support.return_value \u003d None"},{"line_number":307,"context_line":"        expected \u003d ["},{"line_number":308,"context_line":"            mock.call(\u0027timing\u0027), mock.call(\u0027timing\u0027, False),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_1848115b","line":305,"updated":"2015-06-12 01:09:50.000000000","message":"Would this work instead?\n\nmock_exc.side_effect \u003d iter((processutils.ProcessExecutionError(),) * len(options))\n\nWhat do you think?","commit_id":"7d82c4c2358e503d6acd1d7a7d62993feeb5d639"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"6692222d40784065d46b8ec1d055e289f86ae170","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        side_effects \u003d []"},{"line_number":303,"context_line":"        for opt in options:"},{"line_number":304,"context_line":"            side_effects.append(processutils.ProcessExecutionError())"},{"line_number":305,"context_line":"        mock_exc.side_effect \u003d iter(side_effects)"},{"line_number":306,"context_line":"        mock_support.return_value \u003d None"},{"line_number":307,"context_line":"        expected \u003d ["},{"line_number":308,"context_line":"            mock.call(\u0027timing\u0027), mock.call(\u0027timing\u0027, False),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_23302b56","line":305,"in_reply_to":"1af86dd1_1848115b","updated":"2015-06-12 15:12:34.000000000","message":"Thanks for the tip!","commit_id":"7d82c4c2358e503d6acd1d7a7d62993feeb5d639"}]}