)]}'
{"ironic/common/states.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d2f56b71f7d68122ce9fbbf038759804951dbe3a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"\"\"\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"ENROLL \u003d \u0027enroll\u0027"},{"line_number":69,"context_line":"\"\"\" Node is just enrolled."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"This state indicates that Ironic is aware of a node, but is not managing yet."},{"line_number":72,"context_line":"Node should be transitioned to MANAGEABLE before Ironic starts working with it."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_1488fa6f","line":69,"updated":"2015-06-18 21:14:04.000000000","message":"how about \u0027Node has been enrolled.\u0027\n\nOr \u0027Node is enrolled\u0027.\n\nThe \u0027just\u0027 is awkward. I think the description below provides more info.","commit_id":"1b32da01cb0af59b85e72e2f701c881d9e74e4c8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d2f56b71f7d68122ce9fbbf038759804951dbe3a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ENROLL \u003d \u0027enroll\u0027"},{"line_number":69,"context_line":"\"\"\" Node is just enrolled."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"This state indicates that Ironic is aware of a node, but is not managing yet."},{"line_number":72,"context_line":"Node should be transitioned to MANAGEABLE before Ironic starts working with it."},{"line_number":73,"context_line":"\"\"\""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_548a0265","line":71,"updated":"2015-06-18 21:14:04.000000000","message":"s/managing/managing it/","commit_id":"1b32da01cb0af59b85e72e2f701c881d9e74e4c8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d2f56b71f7d68122ce9fbbf038759804951dbe3a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"\"\"\" Node is just enrolled."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"This state indicates that Ironic is aware of a node, but is not managing yet."},{"line_number":72,"context_line":"Node should be transitioned to MANAGEABLE before Ironic starts working with it."},{"line_number":73,"context_line":"\"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"MANAGEABLE \u003d \u0027manageable\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f47b16f3","line":72,"updated":"2015-06-18 21:14:04.000000000","message":"I\u0027m wondering if this sentence is needed. But if we want to say more, how about something like \u0027While in this state, nothing can be done with the node. Once verification of its power management credentials is done, it can transition to the MANAGEABLE state.\u0027","commit_id":"1b32da01cb0af59b85e72e2f701c881d9e74e4c8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"37890f1f8b0e82ee64337028c35b720b3f2bb7f2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"\"\"\" Node is just enrolled."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"This state indicates that Ironic is aware of a node, but is not managing yet."},{"line_number":72,"context_line":"Node should be transitioned to MANAGEABLE before Ironic starts working with it."},{"line_number":73,"context_line":"\"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"MANAGEABLE \u003d \u0027manageable\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_0fdcca71","line":72,"in_reply_to":"fa32b979_f47b16f3","updated":"2015-06-23 15:20:13.000000000","message":"\"nothing can be done\" is a bit overstating, we can e.g. update node. I\u0027ll probably just drop this note.","commit_id":"1b32da01cb0af59b85e72e2f701c881d9e74e4c8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d2f56b71f7d68122ce9fbbf038759804951dbe3a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"\"\"\" Node inspection failed. \"\"\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"VERIFYING \u003d \u0027verifying\u0027"},{"line_number":162,"context_line":"\"\"\" Node power management credentials are being verified. \"\"\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f4beb663","line":161,"updated":"2015-06-18 21:14:04.000000000","message":"would be nice to put this after ENROLL since that\u0027s the order anyway.","commit_id":"1b32da01cb0af59b85e72e2f701c881d9e74e4c8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d2f56b71f7d68122ce9fbbf038759804951dbe3a","unresolved":false,"context_lines":[{"line_number":207,"context_line":"machine.add_state(ACTIVE, stable\u003dTrue, **watchers)"},{"line_number":208,"context_line":"machine.add_state(ERROR, stable\u003dTrue, **watchers)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"machine.add_state(VERIFYING, target\u003dMANAGEABLE, **watchers)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"# Add deploy* states"},{"line_number":213,"context_line":"# NOTE(deva): Juno shows a target_provision_state of DEPLOYDONE"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_1450fa30","line":210,"updated":"2015-06-18 21:14:04.000000000","message":"given the way the comments are, I think (even though unnecessary) it might be good to have \u0027# Add verifying state\u0027 to separate it more from the above \u0027stable states\u0027.","commit_id":"1b32da01cb0af59b85e72e2f701c881d9e74e4c8"}]}
