)]}'
{"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"e50d20bb2cb10600f4d642d7398bfb0555876c41","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"                \"Missing \u0027ipmi_terminal_port\u0027 parameter in node\u0027s\""},{"line_number":1033,"context_line":"                \" driver_info.\"))"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        if driver_info[\u0027protocol_version\u0027] !\u003d \u00272.0\u0027:"},{"line_number":1036,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":1037,"context_line":"                \"Serial over lan only works with IPMI protocol version 2.0. \""},{"line_number":1038,"context_line":"                \"Check the \u0027ipmi_protocol_version\u0027 parameter in \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_75b77cd8","line":1035,"updated":"2015-07-01 06:50:17.000000000","message":"Hi Lucas,\n\nI understand this protocol_version is set by manually, right?  correct me if I am wrong.\n\nAnd if this \"protocol_version\" value can be auto-populated based on the result of ipmitool \"mc info\" command?\n\nAny comments?\n\n[root@hbcontrol ~]# ipmitool -I lanplus -H $IP  -U $USR -P $PWD mc info\nDevice ID                 : 32\nDevice Revision           : 0\nFirmware Revision         : 1.97\nIPMI Version              : 2.0\nManufacturer ID           : 20301\nManufacturer Name         : Unknown (0x4F4D)\nProduct ID                : 323 (0x0143)\nProduct Name              : Unknown (0x143)\nDevice Available          : yes\nProvides Device SDRs      : no\nAdditional Device Support :\n    Sensor Device\n    SDR Repository Device\n    SEL Device\n    FRU Inventory Device\n    IPMB Event Receiver\n    IPMB Event Generator\n    Chassis Device\nAux Firmware Rev Info     :\n    0x00\n    0x00\n    0x2e\n    0x41\n[root@hbcontrol ~]#","commit_id":"39993a62e2a170e31fcf2c403108394ff5bcfbb5"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"9ffadd23a5a3ad0d35198e8f80bdd68a102e3bc7","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"                \"Missing \u0027ipmi_terminal_port\u0027 parameter in node\u0027s\""},{"line_number":1033,"context_line":"                \" driver_info.\"))"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        if driver_info[\u0027protocol_version\u0027] !\u003d \u00272.0\u0027:"},{"line_number":1036,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":1037,"context_line":"                \"Serial over lan only works with IPMI protocol version 2.0. \""},{"line_number":1038,"context_line":"                \"Check the \u0027ipmi_protocol_version\u0027 parameter in \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f36933fa","line":1035,"in_reply_to":"ba3cc151_1a208a47","updated":"2015-07-02 00:38:50.000000000","message":"Hi Lucas and Ruby,\n\nAgree with you.\n\nAnd this time, I run impitool with \u0027lan\u0027 option and can get the ipmi version 2.0 also, so how do you think, if we can use this \u0027lan\u0027 mode to detect the ipmi protocol version or not?\n\n[root@hbcontrol ~]# ipmitool -I lan -H 9.119.58.64  -U USERID -P passw1rd mc info\nDevice ID                 : 32\nDevice Revision           : 0\nFirmware Revision         : 1.97\nIPMI Version              : 2.0\nManufacturer ID           : 20301\nManufacturer Name         : Unknown (0x4F4D)\nProduct ID                : 323 (0x0143)\nProduct Name              : Unknown (0x143)\nDevice Available          : yes\nProvides Device SDRs      : no\nAdditional Device Support :\n    Sensor Device\n    SDR Repository Device\n    SEL Device\n    FRU Inventory Device\n    IPMB Event Receiver\n    IPMB Event Generator\n    Chassis Device\nAux Firmware Rev Info     :\n    0x00\n    0x00\n    0x2e\n    0x41\n[root@hbcontrol ~]#","commit_id":"39993a62e2a170e31fcf2c403108394ff5bcfbb5"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"754096b5e247ceeb92eb30ccf4fbd1d71d44f70a","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"                \"Missing \u0027ipmi_terminal_port\u0027 parameter in node\u0027s\""},{"line_number":1033,"context_line":"                \" driver_info.\"))"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        if driver_info[\u0027protocol_version\u0027] !\u003d \u00272.0\u0027:"},{"line_number":1036,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":1037,"context_line":"                \"Serial over lan only works with IPMI protocol version 2.0. \""},{"line_number":1038,"context_line":"                \"Check the \u0027ipmi_protocol_version\u0027 parameter in \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_80de800f","line":1035,"in_reply_to":"ba3cc151_75b77cd8","updated":"2015-07-01 07:10:47.000000000","message":"And if you agree with the solution, I would like to propose the patch.","commit_id":"39993a62e2a170e31fcf2c403108394ff5bcfbb5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"113902eb09f30c11dfdbc981623105aef10ff805","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"                \"Missing \u0027ipmi_terminal_port\u0027 parameter in node\u0027s\""},{"line_number":1033,"context_line":"                \" driver_info.\"))"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        if driver_info[\u0027protocol_version\u0027] !\u003d \u00272.0\u0027:"},{"line_number":1036,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":1037,"context_line":"                \"Serial over lan only works with IPMI protocol version 2.0. \""},{"line_number":1038,"context_line":"                \"Check the \u0027ipmi_protocol_version\u0027 parameter in \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_b7a89721","line":1035,"in_reply_to":"ba3cc151_80de800f","updated":"2015-07-01 13:26:50.000000000","message":"Hi Haomeng, that won\u0027t work. The use of the protocol version is to know whether to use \u0027lanplus\u0027 or \u0027lan\u0027 interface. Unless there is another ipmitool command that you can use to get the IPMI version.","commit_id":"39993a62e2a170e31fcf2c403108394ff5bcfbb5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"bc94db509830ed44d544800ac9fc6a8b0625d994","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"                \"Missing \u0027ipmi_terminal_port\u0027 parameter in node\u0027s\""},{"line_number":1033,"context_line":"                \" driver_info.\"))"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        if driver_info[\u0027protocol_version\u0027] !\u003d \u00272.0\u0027:"},{"line_number":1036,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":1037,"context_line":"                \"Serial over lan only works with IPMI protocol version 2.0. \""},{"line_number":1038,"context_line":"                \"Check the \u0027ipmi_protocol_version\u0027 parameter in \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_1a208a47","line":1035,"in_reply_to":"ba3cc151_b7a89721","updated":"2015-07-01 13:33:40.000000000","message":"Yeah, actually you also could have both versions enabled in a BMC at the same time. So it\u0027s a human decision about which one to use.","commit_id":"39993a62e2a170e31fcf2c403108394ff5bcfbb5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7da571ed876aed027d14f7f2fad516b4ad9ff66c","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"                \"Missing \u0027ipmi_terminal_port\u0027 parameter in node\u0027s\""},{"line_number":1033,"context_line":"                \" driver_info.\"))"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        if driver_info[\u0027protocol_version\u0027] !\u003d \u00272.0\u0027:"},{"line_number":1036,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":1037,"context_line":"                \"Serial over lan only works with IPMI protocol version 2.0. \""},{"line_number":1038,"context_line":"                \"Check the \u0027ipmi_protocol_version\u0027 parameter in \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_7c99f21e","line":1035,"in_reply_to":"ba3cc151_f36933fa","updated":"2015-07-06 14:14:19.000000000","message":"Haomeng, if both v1.5 \u0026 v2.0 are enabled in a BMC, and we can programmatically determine whether 1.5 and/or 2.0 are supported, which would we use if both were supported. I think Lucas wanted a human to explicitly specify which to use. It does seem like if v2.0 was supported we should always use lanplus interface but I guess this gives more flexibility.","commit_id":"39993a62e2a170e31fcf2c403108394ff5bcfbb5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a6c0e47eafc8e1c6fabe2ab7d77050716a87fa9a","unresolved":false,"context_lines":[{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        if driver_info[\u0027protocol_version\u0027] !\u003d \u00272.0\u0027:"},{"line_number":1036,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":1037,"context_line":"                \"Serial over lan only works with IPMI protocol version 2.0. \""},{"line_number":1038,"context_line":"                \"Check the \u0027ipmi_protocol_version\u0027 parameter in \""},{"line_number":1039,"context_line":"                \"node\u0027s driver_info\"))"},{"line_number":1040,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_8ff79af4","line":1037,"updated":"2015-07-01 00:33:34.000000000","message":"s/lan/LAN/","commit_id":"39993a62e2a170e31fcf2c403108394ff5bcfbb5"}]}