)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba77fb52548202b538ef4c4191921a222009a47e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the purpose of locking in"},{"line_number":10,"context_line":"one of the places in conductor/manager.py to"},{"line_number":11,"context_line":"give a more accurate reason."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2b7efe3e88c9d7823500603a9a327fb8a9ff4602"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_e1827dfe","line":11,"updated":"2015-07-09 15:57:16.000000000","message":"This is vague; might as well just mention what you\u0027re changing. (maybe just a nit on my part.)","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"451131f772e7e70757716a770ca4fe0a9199197e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the purpose of locking in"},{"line_number":10,"context_line":"one of the places in conductor/manager.py to"},{"line_number":11,"context_line":"give a more accurate reason."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2b7efe3e88c9d7823500603a9a327fb8a9ff4602"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_ec83f7ca","line":11,"in_reply_to":"9a41bdd9_0075c9f7","updated":"2015-07-13 14:09:50.000000000","message":"yes, use exact change then.\n\nsomething like \u0027change the purpose of locking at _fail_if_in_state() from ... to ... so that it gives a more accurate reason.","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"6c38be265046ad05f50ea5c2a85450a5f7bbd39d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the purpose of locking in"},{"line_number":10,"context_line":"one of the places in conductor/manager.py to"},{"line_number":11,"context_line":"give a more accurate reason."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2b7efe3e88c9d7823500603a9a327fb8a9ff4602"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_0075c9f7","line":11,"in_reply_to":"ba3cc151_e1827dfe","updated":"2015-07-13 11:50:49.000000000","message":"I need more suggestions.  I couldn\u0027t think of another commit message.  May be I could write the exact change instead.  :)","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"}],"ironic/conductor/manager.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0c3127579b5d8a057a57e7bc110140581cd05740","unresolved":false,"context_lines":[{"line_number":1799,"context_line":"        workers_count \u003d 0"},{"line_number":1800,"context_line":"        for node_uuid, driver in node_iter:"},{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                lock_purpose \u003d \u0027trying to fail the node\u0027"},{"line_number":1803,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":1804,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":1805,"context_line":"                    if (task.node.maintenance or"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_e1b4bdf1","line":1802,"updated":"2015-07-09 15:40:00.000000000","message":"+1 . This looks better.","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4b3a1562835c7d2b0a6ad8a946d70c3f1fe23971","unresolved":false,"context_lines":[{"line_number":1799,"context_line":"        workers_count \u003d 0"},{"line_number":1800,"context_line":"        for node_uuid, driver in node_iter:"},{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                lock_purpose \u003d \u0027trying to fail the node\u0027"},{"line_number":1803,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":1804,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":1805,"context_line":"                    if (task.node.maintenance or"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_de2bb280","line":1802,"updated":"2015-07-09 07:17:33.000000000","message":"I don\u0027t understand this \"fail the node\". I think previously you suggested something more specific using provision_state value. Maybe \"failing the current process if node is in %s state\" % provision_state?","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"451131f772e7e70757716a770ca4fe0a9199197e","unresolved":false,"context_lines":[{"line_number":1799,"context_line":"        workers_count \u003d 0"},{"line_number":1800,"context_line":"        for node_uuid, driver in node_iter:"},{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                lock_purpose \u003d \u0027trying to fail the node\u0027"},{"line_number":1803,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":1804,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":1805,"context_line":"                    if (task.node.maintenance or"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_6c94c7e1","line":1802,"in_reply_to":"9a41bdd9_8011d9ae","updated":"2015-07-13 14:09:50.000000000","message":"The description for this method is \u0027Fail nodes that are in specified state\u0027.\n\nAgain, what are you/we trying to convey with this changed string?\n\nI still think \u0027trying to\u0027 is odd. For every method we have, we\u0027re \u0027trying to do something\u0027.","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba77fb52548202b538ef4c4191921a222009a47e","unresolved":false,"context_lines":[{"line_number":1799,"context_line":"        workers_count \u003d 0"},{"line_number":1800,"context_line":"        for node_uuid, driver in node_iter:"},{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                lock_purpose \u003d \u0027trying to fail the node\u0027"},{"line_number":1803,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":1804,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":1805,"context_line":"                    if (task.node.maintenance or"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_c47f4715","line":1802,"in_reply_to":"ba3cc151_bed26e5a","updated":"2015-07-09 15:57:16.000000000","message":"I don\u0027t see the need to put \u0027trying ...\u0027. We don\u0027t eg \u0027trying to tear down node\u0027.\n\nI took a look at the other strings used for purpose. I would have used the name of the method to make it easier for me to debug!, but I don\u0027t know the intended audience for these strings. All of the strings are similar to the method name except for this one. But then, this method is a bit unusual.\n\nAlso, none of the other purpose strings provide any info pertaining to the operation.\n\nHere are two suggestions:\n1. \"fail nodes in specified provision state\"\n\n2. \"fail nodes in provision state %s\" % provision_state\n\nMy concern with 2, is that it sets a precedent for all the other purpose strings. Which might be a good thing I guess, if it helps to have more info in the strings.","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"6c38be265046ad05f50ea5c2a85450a5f7bbd39d","unresolved":false,"context_lines":[{"line_number":1799,"context_line":"        workers_count \u003d 0"},{"line_number":1800,"context_line":"        for node_uuid, driver in node_iter:"},{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                lock_purpose \u003d \u0027trying to fail the node\u0027"},{"line_number":1803,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":1804,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":1805,"context_line":"                    if (task.node.maintenance or"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_8011d9ae","line":1802,"in_reply_to":"ba3cc151_c1417964","updated":"2015-07-13 11:50:49.000000000","message":"I am not sure if different people\u0027s comments are contradicting or converge to a single thing.\n\nDmitry\u0027s comment as per IRC was his concern on \"failing the node\" rather than \"failing the process\".  I wasn\u0027t totally sure if process made more sense because if we reach till here, there is no process going on right now and it\u0027s the node that\u0027s going to failed state.\n\n@Ruby, \"trying to...\" was prefixed because we aren\u0027t totally sure if we would end up failing the node because there are checks below and code can raise exceptions as well.  That\u0027s why \"trying to..\" was added to \"fail node the node in %s state\".\n\n@Jim, do you meant what Dmitry meant above or something else ?","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1fe55964f4b960abef73f8eea769f9e5fc7e2c2c","unresolved":false,"context_lines":[{"line_number":1799,"context_line":"        workers_count \u003d 0"},{"line_number":1800,"context_line":"        for node_uuid, driver in node_iter:"},{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                lock_purpose \u003d \u0027trying to fail the node\u0027"},{"line_number":1803,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":1804,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":1805,"context_line":"                    if (task.node.maintenance or"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_bed26e5a","line":1802,"in_reply_to":"ba3cc151_de2bb280","updated":"2015-07-09 07:22:46.000000000","message":"May be then,\n\n  \"trying to fail the node in %s state\" % provision_state","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ea0067efa8096f2ef2bdd0dfb36526d47e5c6fb2","unresolved":false,"context_lines":[{"line_number":1799,"context_line":"        workers_count \u003d 0"},{"line_number":1800,"context_line":"        for node_uuid, driver in node_iter:"},{"line_number":1801,"context_line":"            try:"},{"line_number":1802,"context_line":"                lock_purpose \u003d \u0027trying to fail the node\u0027"},{"line_number":1803,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":1804,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":1805,"context_line":"                    if (task.node.maintenance or"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_c1417964","line":1802,"in_reply_to":"ba3cc151_e1b4bdf1","updated":"2015-07-09 15:45:43.000000000","message":"I like what Dmitry said. At this point it isn\u0027t trying to fail the node; it\u0027s checking if the node should be failed.","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba77fb52548202b538ef4c4191921a222009a47e","unresolved":false,"context_lines":[{"line_number":1806,"context_line":"                        task.node.provision_state !\u003d provision_state):"},{"line_number":1807,"context_line":"                        continue"},{"line_number":1808,"context_line":""},{"line_number":1809,"context_line":"                    # timeout has been reached - process the event \u0027fail\u0027"},{"line_number":1810,"context_line":"                    if callback_method:"},{"line_number":1811,"context_line":"                        task.process_event(\u0027fail\u0027,"},{"line_number":1812,"context_line":"                                           callback\u003dself._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_04076fca","line":1809,"updated":"2015-07-09 15:57:16.000000000","message":"ugh, this isn\u0027t true. \u0027timeout has been reached\u0027. It depends on the filters used. Sigh.","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"6c38be265046ad05f50ea5c2a85450a5f7bbd39d","unresolved":false,"context_lines":[{"line_number":1806,"context_line":"                        task.node.provision_state !\u003d provision_state):"},{"line_number":1807,"context_line":"                        continue"},{"line_number":1808,"context_line":""},{"line_number":1809,"context_line":"                    # timeout has been reached - process the event \u0027fail\u0027"},{"line_number":1810,"context_line":"                    if callback_method:"},{"line_number":1811,"context_line":"                        task.process_event(\u0027fail\u0027,"},{"line_number":1812,"context_line":"                                           callback\u003dself._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_e0e545a8","line":1809,"in_reply_to":"ba3cc151_04076fca","updated":"2015-07-13 11:50:49.000000000","message":"May be I can correct this in next patch.","commit_id":"a64445309a3eca074b3c401567c07e61c81eed93"}]}