)]}'
{"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4a54041ca11cc4ea6771f94efc7c78e690da6532","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        return {"},{"line_number":350,"context_line":"            \u0027heartbeat_timeout\u0027: CONF.agent.heartbeat_timeout,"},{"line_number":351,"context_line":"            \u0027node\u0027: node.as_dict()"},{"line_number":352,"context_line":"        }"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _get_completed_cleaning_command(self, task):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_26eebcb4","line":351,"updated":"2015-08-11 06:05:49.000000000","message":"Why do we need to change this ? I thought ironic.objects.Node which inherits from ironic.objects.base.IronicObject is a seizable entity.  It has a obj_to_primitive method which returns dictionary.","commit_id":"1bd5f7f3a1c6089d9bd0b8dce0a983f7b2e25e19"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"6d034d360cfe4205012990254624d8ff49569b6c","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        return {"},{"line_number":350,"context_line":"            \u0027heartbeat_timeout\u0027: CONF.agent.heartbeat_timeout,"},{"line_number":351,"context_line":"            \u0027node\u0027: node.as_dict()"},{"line_number":352,"context_line":"        }"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _get_completed_cleaning_command(self, task):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_6c78dec4","line":351,"in_reply_to":"1a4dcd0f_26eebcb4","updated":"2015-08-12 09:59:02.000000000","message":"From my understand,  it is only serializable for RPC which using objects_base.IronicObjectSerializer() as serializer like\nhttps://github.com/openstack/ironic/blob/master/ironic/conductor/rpcapi.py#L90\n\nBut  wsme is still using json.dumps as serializer, which will report object is not JSON seriablizable like\nhttps://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/utils.py#L149, response includes a node object\n\nWhy we don\u0027t have this issue before?\n\nThis is a bug of previous objects_base.IronicObjectSerializer, which is not considering dict situation.\nhttps://github.com/openstack/ironic/blob/master/ironic/objects/base.py#L461\nLookup() function returns a node object in a dict, but was not deserializer back to an object node in response, so we have no problem before.","commit_id":"1bd5f7f3a1c6089d9bd0b8dce0a983f7b2e25e19"}]}