)]}'
{"ironic/objects/base.py":[{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"b7a04ee6ddcd74268e8b1cedc82678008847586f","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    Checks for updated attributes in an object. Updates are applied from the"},{"line_number":545,"context_line":"    loaded object column by column in comparison with the current object."},{"line_number":546,"context_line":"    \"\"\""},{"line_number":547,"context_line":"    for field in obj.fields:"},{"line_number":548,"context_line":"        if (hasattr(obj, get_attrname(field)) and"},{"line_number":549,"context_line":"                obj[field] !\u003d current[field]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_cf2626ce","line":546,"updated":"2015-07-21 05:22:00.000000000","message":"can this function be defined under IronicObject class and can be called using self.refresh(..) in subsequent child classes?","commit_id":"31bd408162150c988a3587ce446fe758d7a7d222"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"4a8ac86a272cb51dd0c14e5c18a7b32358d3208c","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    for k in self.fields"},{"line_number":400,"context_line":"                    if hasattr(self, k))"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def refresh_object(self, current):"},{"line_number":403,"context_line":"        \"\"\"Applies updates for objects that inherit from base.IronicObject."},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        Checks for updated attributes in an object. Updates are applied from"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_597159df","line":402,"updated":"2015-07-21 17:58:56.000000000","message":"I\u0027d like to see a test case for this in tests/objects/test_objects.py","commit_id":"9d92cf739c2dff1da12c5d8e61f7679c9a107b49"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"8da174055a468180423856a39d8a2f4f140cf623","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    for k in self.fields"},{"line_number":400,"context_line":"                    if hasattr(self, k))"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def refresh_object(self, current):"},{"line_number":403,"context_line":"        \"\"\"Applies updates for objects that inherit from base.IronicObject."},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        Checks for updated attributes in an object. Updates are applied from"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_9b9107f4","line":402,"in_reply_to":"3a50d1a3_597159df","updated":"2015-07-22 00:25:09.000000000","message":"Done","commit_id":"9d92cf739c2dff1da12c5d8e61f7679c9a107b49"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a1845ef230a9706bb54da86c2dbb6033c8f37810","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    for k in self.fields"},{"line_number":400,"context_line":"                    if hasattr(self, k))"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def refresh_object(self, current):"},{"line_number":403,"context_line":"        \"\"\"Applies updates for objects that inherit from base.IronicObject."},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        Checks for updated attributes in an object. Updates are applied from"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_3ca3dbb3","line":402,"updated":"2015-07-22 17:59:37.000000000","message":"I was looking at the other methods here, and a lot of them are prefixed with \u0027obj_\u0027. What do you think about renaming this \u0027obj_refresh()\u0027; or do you think this is different from the other \u0027obj_\u0027 methods?","commit_id":"0b24093984830aaed906b1d989a285de001dc4d9"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"3e94e3ccd241854896d88fc8c2f90d0d9f9babfd","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    for k in self.fields"},{"line_number":400,"context_line":"                    if hasattr(self, k))"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def refresh_object(self, current):"},{"line_number":403,"context_line":"        \"\"\"Applies updates for objects that inherit from base.IronicObject."},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        Checks for updated attributes in an object. Updates are applied from"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_b34ab124","line":402,"in_reply_to":"3a50d1a3_3ca3dbb3","updated":"2015-07-22 21:09:45.000000000","message":"Done","commit_id":"0b24093984830aaed906b1d989a285de001dc4d9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a1845ef230a9706bb54da86c2dbb6033c8f37810","unresolved":false,"context_lines":[{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        Checks for updated attributes in an object. Updates are applied from"},{"line_number":406,"context_line":"        the loaded object column by column in comparison with the current"},{"line_number":407,"context_line":"        object."},{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        for field in self.fields:"},{"line_number":410,"context_line":"            if (hasattr(self, get_attrname(field)) and"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_dca2f798","line":407,"updated":"2015-07-22 17:59:37.000000000","message":"I\u0027m not sure this is correct (or maybe I am interpreting it differently).\n\n\u0027current\u0027 object is the loaded object, isn\u0027t it?","commit_id":"0b24093984830aaed906b1d989a285de001dc4d9"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"3e94e3ccd241854896d88fc8c2f90d0d9f9babfd","unresolved":false,"context_lines":[{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        Checks for updated attributes in an object. Updates are applied from"},{"line_number":406,"context_line":"        the loaded object column by column in comparison with the current"},{"line_number":407,"context_line":"        object."},{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        for field in self.fields:"},{"line_number":410,"context_line":"            if (hasattr(self, get_attrname(field)) and"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_ae124a55","line":407,"in_reply_to":"3a50d1a3_dca2f798","updated":"2015-07-22 21:09:45.000000000","message":"You\u0027re right, on the child\u0027s \"refresh\" method, \"current\" is an object loaded from DB, which the \"obj_refresh\" method receives as \"current\" too. Maybe renaming it to \"loaded_object\" would make it easier to understand?","commit_id":"0b24093984830aaed906b1d989a285de001dc4d9"}]}