)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e99c76b077a89aedf3c8b980a51abda5f17cc973","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"        # with old nova Ironic drivers that will attempt to remove the"},{"line_number":1041,"context_line":"        # instance even if it\u0027s already deleted in Ironic. This conditional"},{"line_number":1042,"context_line":"        # should be removed in the next cycle (M)."},{"line_number":1043,"context_line":"        if ((rpc_node.maintenance or"},{"line_number":1044,"context_line":"                rpc_node.provision_state \u003d\u003d ir_states.CLEANING) and"},{"line_number":1045,"context_line":"                patch \u003d\u003d [{\u0027op\u0027: \u0027remove\u0027, \u0027path\u0027: \u0027/instance_uuid\u0027}]):"},{"line_number":1046,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_2bb490cf","line":1043,"updated":"2015-07-24 09:16:55.000000000","message":"If user turn on maintenance mode from ACTIVE state and try to remove \u0027instance_uuid\u0027 update will be silently skipped.","commit_id":"467d8b46fd522f72759a772303e2838c80bf36ae"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6e85818ce88104c72755e82da07459b914ec9b93","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"        # with old nova Ironic drivers that will attempt to remove the"},{"line_number":1041,"context_line":"        # instance even if it\u0027s already deleted in Ironic. This conditional"},{"line_number":1042,"context_line":"        # should be removed in the next cycle (M)."},{"line_number":1043,"context_line":"        if ((rpc_node.maintenance or"},{"line_number":1044,"context_line":"                rpc_node.provision_state \u003d\u003d ir_states.CLEANING) and"},{"line_number":1045,"context_line":"                patch \u003d\u003d [{\u0027op\u0027: \u0027remove\u0027, \u0027path\u0027: \u0027/instance_uuid\u0027}]):"},{"line_number":1046,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_ca31db5a","line":1043,"in_reply_to":"3a50d1a3_2bb490cf","updated":"2015-07-28 13:00:24.000000000","message":"Oh good catch!","commit_id":"467d8b46fd522f72759a772303e2838c80bf36ae"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e99c76b077a89aedf3c8b980a51abda5f17cc973","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"                      {\u0027instance\u0027: rpc_node.instance_uuid,"},{"line_number":1048,"context_line":"                       \u0027node\u0027: rpc_node.uuid})"},{"line_number":1049,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1050,"context_line":"            # tears down, skip this update."},{"line_number":1051,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1052,"context_line":"        # Check if node is transitioning state, although nodes in some states"},{"line_number":1053,"context_line":"        # can be updated."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_2ba9f0df","line":1050,"updated":"2015-07-24 09:16:55.000000000","message":"Log message l1046 should be updated.","commit_id":"467d8b46fd522f72759a772303e2838c80bf36ae"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6e85818ce88104c72755e82da07459b914ec9b93","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"                      {\u0027instance\u0027: rpc_node.instance_uuid,"},{"line_number":1048,"context_line":"                       \u0027node\u0027: rpc_node.uuid})"},{"line_number":1049,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1050,"context_line":"            # tears down, skip this update."},{"line_number":1051,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1052,"context_line":"        # Check if node is transitioning state, although nodes in some states"},{"line_number":1053,"context_line":"        # can be updated."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_ea361750","line":1050,"in_reply_to":"3a50d1a3_2ba9f0df","updated":"2015-07-28 13:00:24.000000000","message":"Done","commit_id":"467d8b46fd522f72759a772303e2838c80bf36ae"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4860ea098ca21a922861ee8aedd4258bab1ee539","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"        # instance even if it\u0027s already deleted in Ironic. This conditional"},{"line_number":1042,"context_line":"        # should be removed in the next cycle (Mitaka)."},{"line_number":1043,"context_line":"        remove_inst_uuid_patch \u003d [{\u0027op\u0027: \u0027remove\u0027, \u0027path\u0027: \u0027/instance_uuid\u0027}]"},{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_c8b1a002","line":1044,"updated":"2015-07-29 16:15:11.000000000","message":"oh. don\u0027t we also want to do this in CLEANWAIT? and/or maybe outside the scope of this patch.","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c5f4fb416a840c57d4b726e62f7a1f8f0885ea5f","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"        # instance even if it\u0027s already deleted in Ironic. This conditional"},{"line_number":1042,"context_line":"        # should be removed in the next cycle (Mitaka)."},{"line_number":1043,"context_line":"        remove_inst_uuid_patch \u003d [{\u0027op\u0027: \u0027remove\u0027, \u0027path\u0027: \u0027/instance_uuid\u0027}]"},{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_ae6bd91e","line":1044,"in_reply_to":"3a50d1a3_63d426e8","updated":"2015-07-30 08:31:14.000000000","message":"Oh yes, you\u0027re absolute right! I\u0027m going to fix it","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9fefbb2b8d5d49d421e67fa5da2c092644dbb2fa","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"        # instance even if it\u0027s already deleted in Ironic. This conditional"},{"line_number":1042,"context_line":"        # should be removed in the next cycle (Mitaka)."},{"line_number":1043,"context_line":"        remove_inst_uuid_patch \u003d [{\u0027op\u0027: \u0027remove\u0027, \u0027path\u0027: \u0027/instance_uuid\u0027}]"},{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_63d426e8","line":1044,"in_reply_to":"3a50d1a3_c08090c1","updated":"2015-07-29 18:02:03.000000000","message":"I was going to say ok, but the elif at line 1055 will prevent CLEANWAIT so an error will be returned?","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"faa9c2a4a58edf206aecda9ec9952d7efbae007f","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"        # instance even if it\u0027s already deleted in Ironic. This conditional"},{"line_number":1042,"context_line":"        # should be removed in the next cycle (Mitaka)."},{"line_number":1043,"context_line":"        remove_inst_uuid_patch \u003d [{\u0027op\u0027: \u0027remove\u0027, \u0027path\u0027: \u0027/instance_uuid\u0027}]"},{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_c08090c1","line":1044,"in_reply_to":"3a50d1a3_c8b1a002","updated":"2015-07-29 17:50:59.000000000","message":"CLEANWAIT is fine because it doesn\u0027t hold any lock, so the update to the instance_info will just work. (There\u0027s no problem on setting it to None if it\u0027s already None)","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a142dda7c289642e24d5e3129e51d9e2675ecc53","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."},{"line_number":1048,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1049,"context_line":"        elif rpc_node.maintenance and patch \u003d\u003d remove_inst_uuid_patch:"},{"line_number":1050,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_1024a25d","line":1047,"updated":"2015-07-29 08:49:28.000000000","message":"can we check rpc_node that it was really removed?","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4860ea098ca21a922861ee8aedd4258bab1ee539","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."},{"line_number":1048,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1049,"context_line":"        elif rpc_node.maintenance and patch \u003d\u003d remove_inst_uuid_patch:"},{"line_number":1050,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_88a5d8a2","line":1047,"updated":"2015-07-29 16:15:11.000000000","message":"s/tears down/tear down/\n\nIs it possible for someone to be using an old nova, old ironic. nova issues patch to set provision state to delete so that do_node_tear_down is done and node is being cleaned. While cleaning, ironic is upgraded to this, nova issues this patch to remove the instance (where instance_uuid wasn\u0027t cleared)?","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3a28d9fd572b1c62227bd7c766427673d2be6cac","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."},{"line_number":1048,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1049,"context_line":"        elif rpc_node.maintenance and patch \u003d\u003d remove_inst_uuid_patch:"},{"line_number":1050,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_d0607a03","line":1047,"in_reply_to":"3a50d1a3_1024a25d","updated":"2015-07-29 09:06:37.000000000","message":"We could but would be redundant no? If the node is already at CLEANING stage means it has passed tear_down() which will be set the instance_uuid to None.\n\nWDYT?","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b4440a04fa25f11c1624d00b11ea4c12c83cec1b","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."},{"line_number":1048,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1049,"context_line":"        elif rpc_node.maintenance and patch \u003d\u003d remove_inst_uuid_patch:"},{"line_number":1050,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_5659bffb","line":1047,"in_reply_to":"3a50d1a3_1666d7ec","updated":"2015-07-29 10:39:18.000000000","message":"Right, I don\u0027t think it\u0027s possible (unless one changes the database directly) [1]\n\nBut I can\u0027t account to that and that would cause other stuff to be left uncleaned as well node.instance_info for example\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L804-L817","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9fefbb2b8d5d49d421e67fa5da2c092644dbb2fa","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."},{"line_number":1048,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1049,"context_line":"        elif rpc_node.maintenance and patch \u003d\u003d remove_inst_uuid_patch:"},{"line_number":1050,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_23ee1e22","line":1047,"in_reply_to":"3a50d1a3_20793493","updated":"2015-07-29 18:02:03.000000000","message":"ok, fair enough :)","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"faa9c2a4a58edf206aecda9ec9952d7efbae007f","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."},{"line_number":1048,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1049,"context_line":"        elif rpc_node.maintenance and patch \u003d\u003d remove_inst_uuid_patch:"},{"line_number":1050,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_20793493","line":1047,"in_reply_to":"3a50d1a3_88a5d8a2","updated":"2015-07-29 17:50:59.000000000","message":"That\u0027s tricky, because you should stop accepting workloads and wait the ones that are running to finish before you trigger update.\n\nBut if you don\u0027t, and you stop the ironic-conductor while the node is in CLEANING state (assuming CLEANWAIT is already implemented) the node will then be stuck on CLEANING and it will require you to change the database to move it out of there. We currently don\u0027t have any periodic task to check the nodes in CLEANING state like we do for DEPLOYING [1]. Nor we would fail a node in CLEANING at the start of the ironic-conductor service [2] like we have for DEPLOYING as well.\n\nThese are things that I\u0027ve in my TODO list to fix, I\u0027ve started by introducing CLEANWAIT to distinguish between when a conductor is doing something and when the agent is doing something. But still needs more work.  \n\n[1] https://github.com/openstack/ironic/blob/29dd15092f3263838b06d644f98f3b5543541a2f/ironic/conductor/manager.py#L1189\n\n[2] https://github.com/openstack/ironic/blob/29dd15092f3263838b06d644f98f3b5543541a2f/ironic/conductor/manager.py#L288-L302","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f02fcb6feaeceefdbd29e54359014e6577ea64b0","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"        if (rpc_node.provision_state \u003d\u003d ir_states.CLEANING and"},{"line_number":1045,"context_line":"            patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1046,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1047,"context_line":"            # tears down, skip this update."},{"line_number":1048,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1049,"context_line":"        elif rpc_node.maintenance and patch \u003d\u003d remove_inst_uuid_patch:"},{"line_number":1050,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_1666d7ec","line":1047,"in_reply_to":"3a50d1a3_d0607a03","updated":"2015-07-29 10:34:13.000000000","message":"I\u0027m afraid of it getting stuck if something went wrong, but I don\u0027t insist :)","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"7ebe7f3e1cc108ac3ba5c37b397e846b17f9c163","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"                       \u0027node\u0027: rpc_node.uuid})"},{"line_number":1053,"context_line":"        # Check if node is transitioning state, although nodes in some states"},{"line_number":1054,"context_line":"        # can be updated."},{"line_number":1055,"context_line":"        elif (rpc_node.target_provision_state and rpc_node.provision_state"},{"line_number":1056,"context_line":"              not in ir_states.UPDATE_ALLOWED_STATES):"},{"line_number":1057,"context_line":"            msg \u003d _(\"Node %s can not be updated while a state transition \""},{"line_number":1058,"context_line":"                    \"is in progress.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_398431d1","line":1055,"updated":"2015-07-29 06:30:29.000000000","message":"Why did you remove \"rpc_node.target_power_state or\" ?","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a142dda7c289642e24d5e3129e51d9e2675ecc53","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"                       \u0027node\u0027: rpc_node.uuid})"},{"line_number":1053,"context_line":"        # Check if node is transitioning state, although nodes in some states"},{"line_number":1054,"context_line":"        # can be updated."},{"line_number":1055,"context_line":"        elif (rpc_node.target_provision_state and rpc_node.provision_state"},{"line_number":1056,"context_line":"              not in ir_states.UPDATE_ALLOWED_STATES):"},{"line_number":1057,"context_line":"            msg \u003d _(\"Node %s can not be updated while a state transition \""},{"line_number":1058,"context_line":"                    \"is in progress.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_700ac6d3","line":1055,"in_reply_to":"3a50d1a3_398431d1","updated":"2015-07-29 08:49:28.000000000","message":"https://review.openstack.org/#/c/204565/ removed it","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"ccc2d90b3c2277e15555e77661d718ec018c79ad","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"                       \u0027node\u0027: rpc_node.uuid})"},{"line_number":1053,"context_line":"        # Check if node is transitioning state, although nodes in some states"},{"line_number":1054,"context_line":"        # can be updated."},{"line_number":1055,"context_line":"        elif (rpc_node.target_provision_state and rpc_node.provision_state"},{"line_number":1056,"context_line":"              not in ir_states.UPDATE_ALLOWED_STATES):"},{"line_number":1057,"context_line":"            msg \u003d _(\"Node %s can not be updated while a state transition \""},{"line_number":1058,"context_line":"                    \"is in progress.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_1d94ba88","line":1055,"in_reply_to":"3a50d1a3_700ac6d3","updated":"2015-07-29 09:31:49.000000000","message":"gotcha, thanks :)","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"12f8f2345257c0ad016d5856b2e4c95b63a37126","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"                                         ir_states.CLEANWAIT)"},{"line_number":1046,"context_line":"            and patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1047,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1048,"context_line":"            # tear down, skip this update."},{"line_number":1049,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1050,"context_line":"        elif rpc_node.maintenance and patch \u003d\u003d remove_inst_uuid_patch:"},{"line_number":1051,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_fdaacc18","line":1048,"updated":"2015-08-04 12:34:42.000000000","message":"Do we actually need to skip it? It should just work, right?","commit_id":"2894bcd84960e4133c8bd8552878e7e2c7efb240"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ad2cea1fab5162e4a413a01dfc65bbef352a31b2","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"                                         ir_states.CLEANWAIT)"},{"line_number":1046,"context_line":"            and patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1047,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1048,"context_line":"            # tear down, skip this update."},{"line_number":1049,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1050,"context_line":"        elif rpc_node.maintenance and patch \u003d\u003d remove_inst_uuid_patch:"},{"line_number":1051,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_90f84fe7","line":1048,"in_reply_to":"1a4dcd0f_1032fff1","updated":"2015-08-04 12:44:17.000000000","message":"Fair enough","commit_id":"2894bcd84960e4133c8bd8552878e7e2c7efb240"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1fd621e95642f73cb9d4919523ceeefca6917a13","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"                                         ir_states.CLEANWAIT)"},{"line_number":1046,"context_line":"            and patch \u003d\u003d remove_inst_uuid_patch):"},{"line_number":1047,"context_line":"            # The instance_uuid is already removed as part of the node\u0027s"},{"line_number":1048,"context_line":"            # tear down, skip this update."},{"line_number":1049,"context_line":"            return Node.convert_with_links(rpc_node)"},{"line_number":1050,"context_line":"        elif rpc_node.maintenance and patch \u003d\u003d remove_inst_uuid_patch:"},{"line_number":1051,"context_line":"            LOG.debug(\u0027Removing instance uuid %(instance)s from node %(node)s\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_1032fff1","line":1048,"in_reply_to":"1a4dcd0f_fdaacc18","updated":"2015-08-04 12:38:14.000000000","message":"It should work for CLEANWAIT but may not work for CLEANING (it may have a lock). \n\nBut since we know that instance_uuid with this version of the source is already cleaned (CLEAN* happens after DELETE where the instance_uuid will be set to None) skipping will also save a RPC and database call.","commit_id":"2894bcd84960e4133c8bd8552878e7e2c7efb240"}],"ironic/conductor/manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4860ea098ca21a922861ee8aedd4258bab1ee539","unresolved":false,"context_lines":[{"line_number":805,"context_line":"            # NOTE(deva): there is no need to unset conductor_affinity"},{"line_number":806,"context_line":"            # because it is a reference to the most recent conductor which"},{"line_number":807,"context_line":"            # deployed a node, and does not limit any future actions."},{"line_number":808,"context_line":"            # But we do need to clear the instance_info"},{"line_number":809,"context_line":"            node.instance_info \u003d {}"},{"line_number":810,"context_line":"            node.instance_uuid \u003d None"},{"line_number":811,"context_line":"            driver_internal_info \u003d node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_1e06de85","line":808,"updated":"2015-07-29 16:15:11.000000000","message":"maybe add \u0027and other instance-related fields\u0027?","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"faa9c2a4a58edf206aecda9ec9952d7efbae007f","unresolved":false,"context_lines":[{"line_number":805,"context_line":"            # NOTE(deva): there is no need to unset conductor_affinity"},{"line_number":806,"context_line":"            # because it is a reference to the most recent conductor which"},{"line_number":807,"context_line":"            # deployed a node, and does not limit any future actions."},{"line_number":808,"context_line":"            # But we do need to clear the instance_info"},{"line_number":809,"context_line":"            node.instance_info \u003d {}"},{"line_number":810,"context_line":"            node.instance_uuid \u003d None"},{"line_number":811,"context_line":"            driver_internal_info \u003d node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_20ccd433","line":808,"in_reply_to":"3a50d1a3_1e06de85","updated":"2015-07-29 17:50:59.000000000","message":"++","commit_id":"ee5508167a932e06b2ab58bf16b225450d291c79"}],"ironic/tests/api/v1/test_nodes.py":[{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"3c28b4be5ec6d14e446ece6974eb83d939c14c48","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"        self.mock_update_node.return_value \u003d node"},{"line_number":1020,"context_line":"        response \u003d self.patch_json(\u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":1021,"context_line":"                                   [{\u0027op\u0027: \u0027remove\u0027,"},{"line_number":1022,"context_line":"                                     \u0027path\u0027: \u0027/instance_uuid\u0027}])"},{"line_number":1023,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":1024,"context_line":"        self.assertEqual(200, response.status_code)"},{"line_number":1025,"context_line":"        # instance_uuid is already removed as part of node\u0027s tear down,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_4803250e","line":1022,"updated":"2015-07-24 07:36:21.000000000","message":"Here also need NOTE that this PATCH request will not come after M, so that should be removed in M cycle.","commit_id":"467d8b46fd522f72759a772303e2838c80bf36ae"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6e85818ce88104c72755e82da07459b914ec9b93","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"        self.mock_update_node.return_value \u003d node"},{"line_number":1020,"context_line":"        response \u003d self.patch_json(\u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":1021,"context_line":"                                   [{\u0027op\u0027: \u0027remove\u0027,"},{"line_number":1022,"context_line":"                                     \u0027path\u0027: \u0027/instance_uuid\u0027}])"},{"line_number":1023,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":1024,"context_line":"        self.assertEqual(200, response.status_code)"},{"line_number":1025,"context_line":"        # instance_uuid is already removed as part of node\u0027s tear down,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_6a43e7af","line":1022,"in_reply_to":"3a50d1a3_4803250e","updated":"2015-07-28 13:00:24.000000000","message":"Done","commit_id":"467d8b46fd522f72759a772303e2838c80bf36ae"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f48c6bb4f0cd39ebf50431cdcdbf9339c28ac9b2","unresolved":false,"context_lines":[{"line_number":1015,"context_line":"            node \u003d obj_utils.create_test_node("},{"line_number":1016,"context_line":"                self.context,"},{"line_number":1017,"context_line":"                uuid\u003duuidutils.generate_uuid(),"},{"line_number":1018,"context_line":"                provision_state \u003d state,"},{"line_number":1019,"context_line":"                target_provision_state\u003dstates.AVAILABLE)"},{"line_number":1020,"context_line":"            self.mock_update_node.return_value \u003d node"},{"line_number":1021,"context_line":"            response \u003d self.patch_json(\u0027/nodes/%s\u0027 % node.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_99471e77","line":1018,"updated":"2015-07-31 00:12:51.000000000","message":"please remove spaces. provision_state\u003dstate","commit_id":"9c07641f1f76083e428ad3cc32fce8bcf737f4ac"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fdb5ca7b265edaf1fa94760c4c371a2b40f07304","unresolved":false,"context_lines":[{"line_number":1015,"context_line":"            node \u003d obj_utils.create_test_node("},{"line_number":1016,"context_line":"                self.context,"},{"line_number":1017,"context_line":"                uuid\u003duuidutils.generate_uuid(),"},{"line_number":1018,"context_line":"                provision_state \u003d state,"},{"line_number":1019,"context_line":"                target_provision_state\u003dstates.AVAILABLE)"},{"line_number":1020,"context_line":"            self.mock_update_node.return_value \u003d node"},{"line_number":1021,"context_line":"            response \u003d self.patch_json(\u0027/nodes/%s\u0027 % node.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_8e4fc733","line":1018,"in_reply_to":"3a50d1a3_99471e77","updated":"2015-07-31 08:35:47.000000000","message":"T.T thanks! Removed","commit_id":"9c07641f1f76083e428ad3cc32fce8bcf737f4ac"}]}
