)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"432c77a4865248616819126e6dcd6d718d72aa6d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Spec available at:"},{"line_number":22,"context_line":"http://specs.openstack.org/openstack/ironic-specs/specs/liberty/"},{"line_number":23,"context_line":"ironic-ml2-integration.html"},{"line_number":24,"context_line":"Note: this is an initial draft only and is still work in progress."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Partial-bug: #1526403"},{"line_number":27,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":40,"id":"1a7b0d38_ec7c5e22","line":24,"updated":"2015-12-23 12:20:48.000000000","message":"I think this paragraph should be removed :)","commit_id":"a504689c911f0d38f7502e37d3b985a5607e58d4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bf175fe90d85c8e5ff68606e30bcfb9b9fabe678","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Spec available at:"},{"line_number":22,"context_line":"http://specs.openstack.org/openstack/ironic-specs/specs/liberty/"},{"line_number":23,"context_line":"ironic-ml2-integration.html"},{"line_number":24,"context_line":"Note: this is an initial draft only and is still work in progress."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Partial-bug: #1526403"},{"line_number":27,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":40,"id":"1a7b0d38_7e5df445","line":24,"in_reply_to":"1a7b0d38_ec7c5e22","updated":"2016-01-05 17:47:41.000000000","message":"Done","commit_id":"a504689c911f0d38f7502e37d3b985a5607e58d4"}],"ironic/objects/port.py":[{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"36e8104b440a075ac0cc2d35c481c804870ba791","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                                  sort_dir\u003dsort_dir)"},{"line_number":164,"context_line":"        return Port._from_db_object_list(db_ports, cls, context)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @object_base.remotable_classmethod"},{"line_number":167,"context_line":"    def list_by_portgroup_id(cls, context, portgroup_id, limit\u003dNone,"},{"line_number":168,"context_line":"                             marker\u003dNone, sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":169,"context_line":"        \"\"\"Return a list of Port objects associated with a given portgroup ID."}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_747d93e6","line":166,"updated":"2015-09-21 04:33:02.000000000","message":"This should be @base.remotable_classmethod","commit_id":"6b17e1d9dcec201f327fec8809502f8aca300ef2"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"36e8104b440a075ac0cc2d35c481c804870ba791","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                                       sort_dir\u003dsort_dir)"},{"line_number":185,"context_line":"        return Port._from_db_object_list(db_ports, cls, context)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @object_base.remotable"},{"line_number":188,"context_line":"    def create(self, context\u003dNone):"},{"line_number":189,"context_line":"        \"\"\"Create a Port record in the DB."},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_d46c9f38","line":187,"updated":"2015-09-21 04:33:02.000000000","message":"ditto","commit_id":"6b17e1d9dcec201f327fec8809502f8aca300ef2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d234744b4fe6002f84e617ca43c2c27ed0bb630c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    # Implications of calling new remote procedures should be thought through."},{"line_number":196,"context_line":"    # @object_base.remotable_classmethod"},{"line_number":197,"context_line":"    @classmethod"},{"line_number":198,"context_line":"    def list_by_portgroup_id(cls, context, portgroup_id, limit\u003dNone,"},{"line_number":199,"context_line":"                             marker\u003dNone, sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":200,"context_line":"        \"\"\"Return a list of Port objects associated with a given portgroup ID."},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a5ae5dd_cee553a4","line":198,"updated":"2016-02-05 18:21:44.000000000","message":"No unit test for this.","commit_id":"134ad4cbf6f1930de9c4dd7fd653fedb7decaf18"}],"ironic/objects/portgroup.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    fields \u003d {"},{"line_number":33,"context_line":"        \u0027id\u0027: object_fields.IntegerField(),"},{"line_number":34,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_c3f66f5c","line":34,"updated":"2015-08-07 07:06:25.000000000","message":"\u0027nullable\u003dTrue\u0027 should be removed, which is the same comment as [1]. The spec has been updated as [2].\n\n[1] https://review.openstack.org/#/c/206232/6/ironic/db/sqlalchemy/models.py\n\n[2] https://review.openstack.org/#/c/209729/","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    fields \u003d {"},{"line_number":33,"context_line":"        \u0027id\u0027: object_fields.IntegerField(),"},{"line_number":34,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_15297f37","line":34,"in_reply_to":"1a4dcd0f_c3f66f5c","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_a716ce49","line":37,"updated":"2015-08-07 07:06:25.000000000","message":"\u0027nullable\u003dTrue\u0027 should be removed, which is the same comment as [1]. The spec has been updated as [2].\n\n[1] https://review.openstack.org/#/c/206232/6/ironic/db/sqlalchemy/models.py\n\n[2] https://review.openstack.org/#/c/209729/","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_b520cb4a","line":37,"in_reply_to":"1a4dcd0f_a716ce49","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"\"\"Find a portgroup based on its id or uuid and return a Portgroup object."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        :param portgroup id: the id *or* uuid of a portgroup."},{"line_number":61,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        if strutils.is_int_like(portgroup_id):"},{"line_number":64,"context_line":"            return cls.get_by_id(context, portgroup_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_e70db6e8","line":61,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises: InvalidIdentity","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"\"\"Find a portgroup based on its id or uuid and return a Portgroup object."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        :param portgroup id: the id *or* uuid of a portgroup."},{"line_number":61,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        if strutils.is_int_like(portgroup_id):"},{"line_number":64,"context_line":"            return cls.get_by_id(context, portgroup_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_d51b171b","line":61,"in_reply_to":"1a4dcd0f_e70db6e8","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Find a portgroup based on its integer id and return a Portgroup object."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        :param portgroup id: the id of a portgroup."},{"line_number":77,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":78,"context_line":"        \"\"\""},{"line_number":79,"context_line":"        db_portgroup \u003d cls.dbapi.get_portgroup_by_id(portgroup_id)"},{"line_number":80,"context_line":"        portgroup \u003d Portgroup._from_db_object(cls(context), db_portgroup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_c7cf5a54","line":77,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises: PortgroupNotFound","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Find a portgroup based on its integer id and return a Portgroup object."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        :param portgroup id: the id of a portgroup."},{"line_number":77,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":78,"context_line":"        \"\"\""},{"line_number":79,"context_line":"        db_portgroup \u003d cls.dbapi.get_portgroup_by_id(portgroup_id)"},{"line_number":80,"context_line":"        portgroup \u003d Portgroup._from_db_object(cls(context), db_portgroup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_751a4319","line":77,"in_reply_to":"1a4dcd0f_c7cf5a54","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        :param uuid: the uuid of a portgroup."},{"line_number":88,"context_line":"        :param context: Security context"},{"line_number":89,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        db_portgroup \u003d cls.dbapi.get_portgroup_by_uuid(uuid)"},{"line_number":92,"context_line":"        portgroup \u003d Portgroup._from_db_object(cls(context), db_portgroup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_67da0619","line":89,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises: PortgroupNotFound","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        :param uuid: the uuid of a portgroup."},{"line_number":88,"context_line":"        :param context: Security context"},{"line_number":89,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        db_portgroup \u003d cls.dbapi.get_portgroup_by_uuid(uuid)"},{"line_number":92,"context_line":"        portgroup \u003d Portgroup._from_db_object(cls(context), db_portgroup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_95158fe6","line":89,"in_reply_to":"1a4dcd0f_67da0619","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param address: the address of a portgroup."},{"line_number":100,"context_line":"        :param context: Security context"},{"line_number":101,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        db_portgroup \u003d cls.dbapi.get_portgroup_by_address(address)"},{"line_number":104,"context_line":"        portgroup \u003d Portgroup._from_db_object(cls(context), db_portgroup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_e7fcd673","line":101,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises: PortgroupNotFound","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param address: the address of a portgroup."},{"line_number":100,"context_line":"        :param context: Security context"},{"line_number":101,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        db_portgroup \u003d cls.dbapi.get_portgroup_by_address(address)"},{"line_number":104,"context_line":"        portgroup \u003d Portgroup._from_db_object(cls(context), db_portgroup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_55d62728","line":101,"in_reply_to":"1a4dcd0f_e7fcd673","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        :param name: the name of a portgroup."},{"line_number":112,"context_line":"        :param context: Security context"},{"line_number":113,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":"        db_portgroup \u003d cls.dbapi.get_portgroup_by_name(name)"},{"line_number":116,"context_line":"        portgroup \u003d Portgroup._from_db_object(cls(context), db_portgroup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_67f1a694","line":113,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises: PortgroupNotFound","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        :param name: the name of a portgroup."},{"line_number":112,"context_line":"        :param context: Security context"},{"line_number":113,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":"        db_portgroup \u003d cls.dbapi.get_portgroup_by_name(name)"},{"line_number":116,"context_line":"        portgroup \u003d Portgroup._from_db_object(cls(context), db_portgroup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_15e09ff9","line":113,"in_reply_to":"1a4dcd0f_67f1a694","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        :param sort_key: column to sort results by."},{"line_number":128,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\"."},{"line_number":129,"context_line":"        :returns: a list of :class:`Portgroup` object."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        \"\"\""},{"line_number":132,"context_line":"        db_portgroups \u003d cls.dbapi.get_portgroup_list(limit\u003dlimit,"},{"line_number":133,"context_line":"                                                     marker\u003dmarker,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_c7243a0e","line":130,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises: InvalidParameterValue","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        :param sort_key: column to sort results by."},{"line_number":128,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\"."},{"line_number":129,"context_line":"        :returns: a list of :class:`Portgroup` object."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        \"\"\""},{"line_number":132,"context_line":"        db_portgroups \u003d cls.dbapi.get_portgroup_list(limit\u003dlimit,"},{"line_number":133,"context_line":"                                                     marker\u003dmarker,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_75f1e3cc","line":130,"in_reply_to":"1a4dcd0f_c7243a0e","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        :param marker: pagination marker for large data sets."},{"line_number":147,"context_line":"        :param sort_key: column to sort results by."},{"line_number":148,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\"."},{"line_number":149,"context_line":"        :returns: a list of :class:`Portgroup` object."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        db_portgroups \u003d cls.dbapi.get_portgroups_by_node_id(node_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_67768607","line":149,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises: InvalidParameterValue","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        :param marker: pagination marker for large data sets."},{"line_number":147,"context_line":"        :param sort_key: column to sort results by."},{"line_number":148,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\"."},{"line_number":149,"context_line":"        :returns: a list of :class:`Portgroup` object."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        db_portgroups \u003d cls.dbapi.get_portgroups_by_node_id(node_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_35ba7be2","line":149,"in_reply_to":"1a4dcd0f_67768607","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":167,"context_line":"                        A context should be set when instantiating the"},{"line_number":168,"context_line":"                        object, e.g.: Port(context)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        \"\"\""},{"line_number":171,"context_line":"        values \u003d self.obj_get_changes()"},{"line_number":172,"context_line":"        db_portgroup \u003d self.dbapi.create_portgroup(values)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_e7b4d682","line":169,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises: raise DuplicateName, MACAlreadyExists, PortgroupAlreadyExists","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":167,"context_line":"                        A context should be set when instantiating the"},{"line_number":168,"context_line":"                        object, e.g.: Port(context)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        \"\"\""},{"line_number":171,"context_line":"        values \u003d self.obj_get_changes()"},{"line_number":172,"context_line":"        db_portgroup \u003d self.dbapi.create_portgroup(values)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_55bdc7d5","line":169,"in_reply_to":"1a4dcd0f_e7b4d682","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                        Unfortunately, RPC requires context as the first"},{"line_number":182,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":183,"context_line":"                        A context should be set when instantiating the"},{"line_number":184,"context_line":"                        object, e.g.: Portgroup(context)"},{"line_number":185,"context_line":"        \"\"\""},{"line_number":186,"context_line":"        self.dbapi.destroy_portgroup(self.uuid)"},{"line_number":187,"context_line":"        self.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_e7429667","line":184,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises:PortgroupNotEmpty, PortgroupNotFound","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                        Unfortunately, RPC requires context as the first"},{"line_number":182,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":183,"context_line":"                        A context should be set when instantiating the"},{"line_number":184,"context_line":"                        object, e.g.: Portgroup(context)"},{"line_number":185,"context_line":"        \"\"\""},{"line_number":186,"context_line":"        self.dbapi.destroy_portgroup(self.uuid)"},{"line_number":187,"context_line":"        self.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_f5b3b308","line":184,"in_reply_to":"1a4dcd0f_e7429667","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                        Unfortunately, RPC requires context as the first"},{"line_number":199,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":200,"context_line":"                        A context should be set when instantiating the"},{"line_number":201,"context_line":"                        object, e.g.: Portgroup(context)"},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":204,"context_line":"        self.dbapi.update_portgroup(self.uuid, updates)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_aa169349","line":201,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises: PortgroupNotFound, DuplicateName, MACAlreadyExists","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                        Unfortunately, RPC requires context as the first"},{"line_number":199,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":200,"context_line":"                        A context should be set when instantiating the"},{"line_number":201,"context_line":"                        object, e.g.: Portgroup(context)"},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":204,"context_line":"        self.dbapi.update_portgroup(self.uuid, updates)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_b5ce8b81","line":201,"in_reply_to":"1a4dcd0f_aa169349","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d7e2d36cfbc5ed494fedaa48d732084d8abd89ac","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                        Unfortunately, RPC requires context as the first"},{"line_number":219,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":220,"context_line":"                        A context should be set when instantiating the"},{"line_number":221,"context_line":"                        object, e.g.: Portgroup(context)"},{"line_number":222,"context_line":"        \"\"\""},{"line_number":223,"context_line":"        current \u003d self.__class__.get_by_uuid(self._context, uuid\u003dself.uuid)"},{"line_number":224,"context_line":"        self.obj_refresh(current)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_8a2e378a","line":221,"updated":"2015-08-07 07:06:25.000000000","message":":raises: is missing.\n\n:raises: PortgroupNotFound","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":17465,"name":"William Stevenson","email":"will.stevenson@sap.com","username":"yhvh"},"change_message_id":"ceb7e30680f49fec34580ef0a41ca57b37da9ac0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                        Unfortunately, RPC requires context as the first"},{"line_number":219,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":220,"context_line":"                        A context should be set when instantiating the"},{"line_number":221,"context_line":"                        object, e.g.: Portgroup(context)"},{"line_number":222,"context_line":"        \"\"\""},{"line_number":223,"context_line":"        current \u003d self.__class__.get_by_uuid(self._context, uuid\u003dself.uuid)"},{"line_number":224,"context_line":"        self.obj_refresh(current)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a4dcd0f_d5c9d77a","line":221,"in_reply_to":"1a4dcd0f_8a2e378a","updated":"2015-08-10 16:04:27.000000000","message":"Done","commit_id":"c94cf8c3846f674a7c649da9dfd1fcafe69237c1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c8af1b5f74f4b660df9c130149533eea62dfb8a4","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        return portgroup"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @base.remotable_classmethod"},{"line_number":116,"context_line":"    def get_by_name(cls, context, name):"},{"line_number":117,"context_line":"        \"\"\"Find a portgroup based on name and return a :class:`Portgroup` object."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        :param name: the name of a portgroup."}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_ecc68c48","line":116,"updated":"2015-08-18 16:02:56.000000000","message":"no test for this method","commit_id":"181a13eed6831020040768534ef654eb6fe19501"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c8af1b5f74f4b660df9c130149533eea62dfb8a4","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        return Portgroup._from_db_object_list(db_portgroups, cls, context)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @base.remotable_classmethod"},{"line_number":150,"context_line":"    def list_by_node_id(cls, context, node_id, limit\u003dNone, marker\u003dNone,"},{"line_number":151,"context_line":"                        sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":152,"context_line":"        \"\"\"Return a list of Portgroup objects associated with a given node ID."},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_ecca0c6e","line":150,"updated":"2015-08-18 16:02:56.000000000","message":"no test for this method","commit_id":"181a13eed6831020040768534ef654eb6fe19501"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c8af1b5f74f4b660df9c130149533eea62dfb8a4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self._from_db_object(self, db_portgroup)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @base.remotable"},{"line_number":189,"context_line":"    def destroy(self, context\u003dNone):"},{"line_number":190,"context_line":"        \"\"\"Delete the Portgroup from the DB."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        :param context: Security context. NOTE: This should only"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_6cbefcd5","line":189,"updated":"2015-08-18 16:02:56.000000000","message":"no test for this method","commit_id":"181a13eed6831020040768534ef654eb6fe19501"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c8af1b5f74f4b660df9c130149533eea62dfb8a4","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    def refresh(self, context\u003dNone):"},{"line_number":227,"context_line":"        \"\"\"Loads updates for this Portgroup."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        Loads a port with the same uuid from the database and"},{"line_number":230,"context_line":"        checks for updated attributes. Updates are applied from"},{"line_number":231,"context_line":"        the loaded port column by column, if there are any updates."},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_2c2484ad","line":229,"updated":"2015-08-18 16:02:56.000000000","message":"s/port/portgroup","commit_id":"181a13eed6831020040768534ef654eb6fe19501"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"dcc9d323f37e7affba058778ea016779a6c4bb85","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from ironic.objects import fields as object_fields"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":28,"context_line":"class Portgroup(base.IronicObject, object_base.VersionedObjectDictCompat):"},{"line_number":29,"context_line":"    # Version 1.0: Initial version"},{"line_number":30,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_9480678d","line":27,"updated":"2015-09-21 05:05:11.000000000","message":"IronicObjectRegistery is not available in base or object_base. This should be fixed","commit_id":"6b17e1d9dcec201f327fec8809502f8aca300ef2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"432c77a4865248616819126e6dcd6d718d72aa6d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # @object_base.remotable_classmethod"},{"line_number":62,"context_line":"    @classmethod"},{"line_number":63,"context_line":"    def get(cls, context, portgroup_id):"},{"line_number":64,"context_line":"        \"\"\"Find a portgroup based on its id or uuid and return a Portgroup object."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        :param portgroup id: the id *or* uuid of a portgroup."},{"line_number":67,"context_line":"        :returns: a :class:`Portgroup` object."}],"source_content_type":"text/x-python","patch_set":40,"id":"1a7b0d38_716847f6","line":64,"updated":"2015-12-23 12:20:48.000000000","message":"It can be an address or name too.","commit_id":"a504689c911f0d38f7502e37d3b985a5607e58d4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bf175fe90d85c8e5ff68606e30bcfb9b9fabe678","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # @object_base.remotable_classmethod"},{"line_number":62,"context_line":"    @classmethod"},{"line_number":63,"context_line":"    def get(cls, context, portgroup_id):"},{"line_number":64,"context_line":"        \"\"\"Find a portgroup based on its id or uuid and return a Portgroup object."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        :param portgroup id: the id *or* uuid of a portgroup."},{"line_number":67,"context_line":"        :returns: a :class:`Portgroup` object."}],"source_content_type":"text/x-python","patch_set":40,"id":"1a7b0d38_017b358d","line":64,"in_reply_to":"1a7b0d38_716847f6","updated":"2016-01-05 17:47:41.000000000","message":"Done","commit_id":"a504689c911f0d38f7502e37d3b985a5607e58d4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"432c77a4865248616819126e6dcd6d718d72aa6d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        elif utils.is_valid_logical_name(portgroup_id):"},{"line_number":78,"context_line":"            return cls.get_by_name(context, portgroup_id)"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            raise exception.InvalidIdentity(identity\u003dportgroup_id)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # NOTE(xek): We don\u0027t want to enable RPC on this call just yet. Remotable"},{"line_number":83,"context_line":"    # methods can be used in the future to replace current explicit RPC calls."}],"source_content_type":"text/x-python","patch_set":40,"id":"1a7b0d38_cc0082ad","line":80,"updated":"2015-12-23 12:20:48.000000000","message":"I think a unittest for this case should be added.","commit_id":"a504689c911f0d38f7502e37d3b985a5607e58d4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bf175fe90d85c8e5ff68606e30bcfb9b9fabe678","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        elif utils.is_valid_logical_name(portgroup_id):"},{"line_number":78,"context_line":"            return cls.get_by_name(context, portgroup_id)"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            raise exception.InvalidIdentity(identity\u003dportgroup_id)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # NOTE(xek): We don\u0027t want to enable RPC on this call just yet. Remotable"},{"line_number":83,"context_line":"    # methods can be used in the future to replace current explicit RPC calls."}],"source_content_type":"text/x-python","patch_set":40,"id":"1a7b0d38_a16b41b8","line":80,"in_reply_to":"1a7b0d38_cc0082ad","updated":"2016-01-05 17:47:41.000000000","message":"Done","commit_id":"a504689c911f0d38f7502e37d3b985a5607e58d4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"432c77a4865248616819126e6dcd6d718d72aa6d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                        Unfortunately, RPC requires context as the first"},{"line_number":213,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":214,"context_line":"                        A context should be set when instantiating the"},{"line_number":215,"context_line":"                        object, e.g.: Port(context)"},{"line_number":216,"context_line":"        :raises: DuplicateName, MACAlreadyExists, PortgroupAlreadyExists"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":40,"id":"1a7b0d38_0c38cad2","line":215,"updated":"2015-12-23 12:20:48.000000000","message":"Portgroup","commit_id":"a504689c911f0d38f7502e37d3b985a5607e58d4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bf175fe90d85c8e5ff68606e30bcfb9b9fabe678","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                        Unfortunately, RPC requires context as the first"},{"line_number":213,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":214,"context_line":"                        A context should be set when instantiating the"},{"line_number":215,"context_line":"                        object, e.g.: Port(context)"},{"line_number":216,"context_line":"        :raises: DuplicateName, MACAlreadyExists, PortgroupAlreadyExists"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":40,"id":"1a7b0d38_2160b1ce","line":215,"in_reply_to":"1a7b0d38_0c38cad2","updated":"2016-01-05 17:47:41.000000000","message":"Done","commit_id":"a504689c911f0d38f7502e37d3b985a5607e58d4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \u0027id\u0027: object_fields.IntegerField(),"},{"line_number":36,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(),"},{"line_number":37,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(),"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_86e9e91c","line":36,"updated":"2016-01-12 21:57:14.000000000","message":"not \u0027nullable\u003dTrue\u0027? Our other objects have that.","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"069deb6163b6a1ad8bfa85cd68ab45980e868426","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \u0027id\u0027: object_fields.IntegerField(),"},{"line_number":36,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(),"},{"line_number":37,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(),"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_bc2739b5","line":36,"in_reply_to":"da6ed579_86e9e91c","updated":"2016-01-13 13:39:06.000000000","message":"But actually i think it\u0027s better to fix the \"other object\" as the uuid shouldn\u0027t be nullable, right?","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \u0027id\u0027: object_fields.IntegerField(),"},{"line_number":36,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(),"},{"line_number":37,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(),"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_1ce509db","line":36,"in_reply_to":"da6ed579_86e9e91c","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    fields \u003d {"},{"line_number":35,"context_line":"        \u0027id\u0027: object_fields.IntegerField(),"},{"line_number":36,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(),"},{"line_number":37,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(),"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_7c80c5c0","line":36,"in_reply_to":"da6ed579_86e9e91c","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(),"},{"line_number":37,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(),"},{"line_number":40,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_c6be01ff","line":39,"updated":"2016-01-12 21:57:14.000000000","message":"ditto","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(),"},{"line_number":37,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(),"},{"line_number":40,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_1c8189c3","line":39,"in_reply_to":"da6ed579_c6be01ff","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField(),"},{"line_number":37,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027node_id\u0027: object_fields.IntegerField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027address\u0027: object_fields.MACAddressField(),"},{"line_number":40,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_3cea4dad","line":39,"in_reply_to":"da6ed579_c6be01ff","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\"Find a portgroup based on its id, uuid, name or address."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        :param portgroup id: the id *or* uuid of a portgroup."},{"line_number":67,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":68,"context_line":"        :raises: InvalidIdentity"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_86dd6916","line":67,"updated":"2016-01-12 21:57:14.000000000","message":"nit, :param context: (you have that below)","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\"Find a portgroup based on its id, uuid, name or address."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        :param portgroup id: the id *or* uuid of a portgroup."},{"line_number":67,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":68,"context_line":"        :raises: InvalidIdentity"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_fc6cb536","line":67,"in_reply_to":"da6ed579_86dd6916","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def get_by_id(cls, context, portgroup_id):"},{"line_number":88,"context_line":"        \"\"\"Find a portgroup based on its integer id and return a Portgroup object."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        :param portgroup id: the id of a portgroup."},{"line_number":91,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":92,"context_line":"        :raises: PortgroupNotFound"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_46e771e4","line":90,"updated":"2016-01-12 21:57:14.000000000","message":"nit, :param context: (you have that below)","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def get_by_id(cls, context, portgroup_id):"},{"line_number":88,"context_line":"        \"\"\"Find a portgroup based on its integer id and return a Portgroup object."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        :param portgroup id: the id of a portgroup."},{"line_number":91,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":92,"context_line":"        :raises: PortgroupNotFound"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_3c5d6d79","line":90,"in_reply_to":"da6ed579_46e771e4","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def get_by_address(cls, context, address):"},{"line_number":123,"context_line":"        \"\"\"Find a portgroup based on address and return a :class:`Portgroup` object."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        :param address: the address of a portgroup."},{"line_number":126,"context_line":"        :param context: Security context"},{"line_number":127,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":128,"context_line":"        :raises: PortgroupNotFound"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_8604897e","line":125,"updated":"2016-01-12 21:57:14.000000000","message":"nit, s/address/MAC address/","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def get_by_address(cls, context, address):"},{"line_number":123,"context_line":"        \"\"\"Find a portgroup based on address and return a :class:`Portgroup` object."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        :param address: the address of a portgroup."},{"line_number":126,"context_line":"        :param context: Security context"},{"line_number":127,"context_line":"        :returns: a :class:`Portgroup` object."},{"line_number":128,"context_line":"        :raises: PortgroupNotFound"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_9ce339a4","line":125,"in_reply_to":"da6ed579_8604897e","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":262,"context_line":"        self.dbapi.update_portgroup(self.uuid, updates)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        self.obj_reset_changes()"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    # NOTE(xek): We don\u0027t want to enable RPC on this call just yet. Remotable"},{"line_number":267,"context_line":"    # methods can be used in the future to replace current explicit RPC calls."}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_c6584159","line":264,"updated":"2016-01-12 21:57:14.000000000","message":"the other objects use this pattern, wondering if we should use a similar one here for consistency:\n\nupdated_x \u003d self.dbapi.update_x()\nself._from_db_object(self, update_x)\n\nI suppose it is safer to do the above instead of a _reset_, in case the value gets transformed (although that doesn\u0027t happen here, I don\u0027t think).","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    def refresh(self, context\u003dNone):"},{"line_number":271,"context_line":"        \"\"\"Loads updates for this Portgroup."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        Loads a port with the same uuid from the database and"},{"line_number":274,"context_line":"        checks for updated attributes. Updates are applied from"},{"line_number":275,"context_line":"        the loaded port column by column, if there are any updates."},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_41dd1b41","line":273,"updated":"2016-01-12 21:57:14.000000000","message":"s/port/portgroup/","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    def refresh(self, context\u003dNone):"},{"line_number":271,"context_line":"        \"\"\"Loads updates for this Portgroup."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        Loads a port with the same uuid from the database and"},{"line_number":274,"context_line":"        checks for updated attributes. Updates are applied from"},{"line_number":275,"context_line":"        the loaded port column by column, if there are any updates."},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_dcb21194","line":273,"in_reply_to":"da6ed579_41dd1b41","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        Loads a port with the same uuid from the database and"},{"line_number":274,"context_line":"        checks for updated attributes. Updates are applied from"},{"line_number":275,"context_line":"        the loaded port column by column, if there are any updates."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        :param context: Security context. NOTE: This should only"},{"line_number":278,"context_line":"                        be used internally by the indirection_api."}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_21e58708","line":275,"updated":"2016-01-12 21:57:14.000000000","message":"s/port/portgroup/","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        Loads a port with the same uuid from the database and"},{"line_number":274,"context_line":"        checks for updated attributes. Updates are applied from"},{"line_number":275,"context_line":"        the loaded port column by column, if there are any updates."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        :param context: Security context. NOTE: This should only"},{"line_number":278,"context_line":"                        be used internally by the indirection_api."}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_fc76f5d5","line":275,"in_reply_to":"da6ed579_21e58708","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"994259f2ed1ed885d067b7d1b516d9248a480429","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def get(cls, context, portgroup_id):"},{"line_number":64,"context_line":"        \"\"\"Find a portgroup based on its id, uuid, name or address."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        :param portgroup id: The id *or* uuid of a portgroup."},{"line_number":67,"context_line":"        :param context: Security context"},{"line_number":68,"context_line":"        :returns: A :class:`Portgroup` object."},{"line_number":69,"context_line":"        :raises: InvalidIdentity"}],"source_content_type":"text/x-python","patch_set":45,"id":"da6ed579_0967b3e9","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":59},"updated":"2016-01-15 07:29:42.000000000","message":"portgroup_id could also be address and name, please add them here, and maybe change portgroup_id to portgroup_ident is better.","commit_id":"f7847c38a59038439da286575178a2df7a4c0d1e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2967d417dd2f10bb96f53c3ee7ff02559fbf16ab","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def get(cls, context, portgroup_id):"},{"line_number":64,"context_line":"        \"\"\"Find a portgroup based on its id, uuid, name or address."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        :param portgroup id: The id *or* uuid of a portgroup."},{"line_number":67,"context_line":"        :param context: Security context"},{"line_number":68,"context_line":"        :returns: A :class:`Portgroup` object."},{"line_number":69,"context_line":"        :raises: InvalidIdentity"}],"source_content_type":"text/x-python","patch_set":45,"id":"da6ed579_ec002804","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":59},"in_reply_to":"da6ed579_0967b3e9","updated":"2016-01-18 17:34:14.000000000","message":"portgroup_ident is more suitable name here.","commit_id":"f7847c38a59038439da286575178a2df7a4c0d1e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"439487fa41196871236f3c13ed82a7a723406414","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def get(cls, context, portgroup_ident):"},{"line_number":64,"context_line":"        \"\"\"Find a portgroup based on its id, uuid, name or address."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        :param portgroup_ident: The id, uuid, name or address  of a portgroup."},{"line_number":67,"context_line":"        :param context: Security context"},{"line_number":68,"context_line":"        :returns: A :class:`Portgroup` object."},{"line_number":69,"context_line":"        :raises: InvalidIdentity"}],"source_content_type":"text/x-python","patch_set":46,"id":"ba63e191_5a03f3b8","line":66,"updated":"2016-01-18 22:36:58.000000000","message":"nit (cuz I see it but don\u0027t update unless you have to do another revision, and even then I wouldn\u0027t care except that someone may submit a patch just to address this): s/address  /address /","commit_id":"cb7541c2b5e9719e1ee791fac3f8ebb032c3d6bf"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"579a53b898991245c4dc161a4eebc167b6855aeb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def get(cls, context, portgroup_ident):"},{"line_number":64,"context_line":"        \"\"\"Find a portgroup based on its id, uuid, name or address."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        :param portgroup_ident: The id, uuid, name or address  of a portgroup."},{"line_number":67,"context_line":"        :param context: Security context"},{"line_number":68,"context_line":"        :returns: A :class:`Portgroup` object."},{"line_number":69,"context_line":"        :raises: InvalidIdentity"}],"source_content_type":"text/x-python","patch_set":46,"id":"ba63e191_6a5e17eb","line":66,"in_reply_to":"ba63e191_5a03f3b8","updated":"2016-01-19 09:26:09.000000000","message":"Done","commit_id":"cb7541c2b5e9719e1ee791fac3f8ebb032c3d6bf"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d234744b4fe6002f84e617ca43c2c27ed0bb630c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    # @object_base.remotable_classmethod"},{"line_number":87,"context_line":"    @classmethod"},{"line_number":88,"context_line":"    def get_by_id(cls, context, portgroup_id):"},{"line_number":89,"context_line":"        \"\"\"Find a portgroup based on its integer id and return a Portgroup object."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :param portgroup id: The id of a portgroup."},{"line_number":92,"context_line":"        :param context: Security context"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a5ae5dd_53a83020","line":89,"updated":"2016-02-05 18:21:44.000000000","message":"This and some other docstrings are out of 79 chars line, might be worth fixing.","commit_id":"134ad4cbf6f1930de9c4dd7fd653fedb7decaf18"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d234744b4fe6002f84e617ca43c2c27ed0bb630c","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":216,"context_line":"                        A context should be set when instantiating the"},{"line_number":217,"context_line":"                        object, e.g.: Portgroup(context)"},{"line_number":218,"context_line":"        :raises: DuplicateName, MACAlreadyExists, PortgroupAlreadyExists"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        \"\"\""},{"line_number":221,"context_line":"        values \u003d self.obj_get_changes()"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a5ae5dd_2ebd07b7","line":218,"updated":"2016-02-05 18:21:44.000000000","message":"PortgroupDuplicateName PortgroupMACAlreadyExists","commit_id":"134ad4cbf6f1930de9c4dd7fd653fedb7decaf18"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d234744b4fe6002f84e617ca43c2c27ed0bb630c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                        argument, even though we don\u0027t use it."},{"line_number":258,"context_line":"                        A context should be set when instantiating the"},{"line_number":259,"context_line":"                        object, e.g.: Portgroup(context)"},{"line_number":260,"context_line":"        :raises: PortgroupNotFound, DuplicateName, MACAlreadyExists"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        updates \u003d self.obj_get_changes()"}],"source_content_type":"text/x-python","patch_set":52,"id":"5a5ae5dd_aea25797","line":260,"updated":"2016-02-05 18:21:44.000000000","message":"PortgroupDuplicateName PortgroupMACAlreadyExists\n\nAlso InvalidParameterValue when uuid is specified.","commit_id":"134ad4cbf6f1930de9c4dd7fd653fedb7decaf18"}],"ironic/tests/objects/test_portgroup.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c8af1b5f74f4b660df9c130149533eea62dfb8a4","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                               autospec\u003dTrue) as mock_get_list:"},{"line_number":103,"context_line":"            mock_get_list.return_value \u003d [self.fake_portgroup]"},{"line_number":104,"context_line":"            portgroups \u003d objects.Portgroup.list(self.context)"},{"line_number":105,"context_line":"            self.assertThat(portgroups, HasLength(1))"},{"line_number":106,"context_line":"            self.assertIsInstance(portgroups[0], objects.Portgroup)"},{"line_number":107,"context_line":"            self.assertEqual(self.context, portgroups[0]._context)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_4c38d8a0","line":105,"updated":"2015-08-18 16:02:56.000000000","message":"Why not just use len?","commit_id":"181a13eed6831020040768534ef654eb6fe19501"}],"ironic/tests/unit/objects/test_portgroup.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# coding\u003dutf-8"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_e1d8cf1f","line":1,"updated":"2016-01-12 21:57:14.000000000","message":"Older files may have this, but we don\u0027t want new files to have it unless it is needed.","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# coding\u003dutf-8"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_59063387","line":1,"in_reply_to":"da6ed579_e1d8cf1f","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                               autospec\u003dTrue) as mock_get_list:"},{"line_number":124,"context_line":"            mock_get_list.return_value \u003d [self.fake_portgroup]"},{"line_number":125,"context_line":"            node_id \u003d self.fake_portgroup[\u0027node_id\u0027]"},{"line_number":126,"context_line":"            portgroups \u003d objects.Portgroup.list(self.context, node_id)"},{"line_number":127,"context_line":"            self.assertThat(portgroups, HasLength(1))"},{"line_number":128,"context_line":"            self.assertIsInstance(portgroups[0], objects.Portgroup)"},{"line_number":129,"context_line":"            self.assertEqual(self.context, portgroups[0]._context)"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_11753497","line":126,"updated":"2016-01-12 21:57:14.000000000","message":"shouldn\u0027t this be list_by_node_id() ?","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                               autospec\u003dTrue) as mock_get_list:"},{"line_number":124,"context_line":"            mock_get_list.return_value \u003d [self.fake_portgroup]"},{"line_number":125,"context_line":"            node_id \u003d self.fake_portgroup[\u0027node_id\u0027]"},{"line_number":126,"context_line":"            portgroups \u003d objects.Portgroup.list(self.context, node_id)"},{"line_number":127,"context_line":"            self.assertThat(portgroups, HasLength(1))"},{"line_number":128,"context_line":"            self.assertIsInstance(portgroups[0], objects.Portgroup)"},{"line_number":129,"context_line":"            self.assertEqual(self.context, portgroups[0]._context)"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_b9e08f97","line":126,"in_reply_to":"da6ed579_11753497","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"994259f2ed1ed885d067b7d1b516d9248a480429","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            mock_get_portgroup.assert_called_once_with(name)"},{"line_number":70,"context_line":"            self.assertEqual(self.context, portgroup._context)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_get_bad_id_and_uuid_and_address(self):"},{"line_number":73,"context_line":"        self.assertRaises(exception.InvalidIdentity,"},{"line_number":74,"context_line":"                          objects.Portgroup.get,"},{"line_number":75,"context_line":"                          self.context,"}],"source_content_type":"text/x-python","patch_set":45,"id":"da6ed579_e98c9fdb","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":44},"updated":"2016-01-15 07:29:42.000000000","message":"and bad name.","commit_id":"f7847c38a59038439da286575178a2df7a4c0d1e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2967d417dd2f10bb96f53c3ee7ff02559fbf16ab","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            mock_get_portgroup.assert_called_once_with(name)"},{"line_number":70,"context_line":"            self.assertEqual(self.context, portgroup._context)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_get_bad_id_and_uuid_and_address(self):"},{"line_number":73,"context_line":"        self.assertRaises(exception.InvalidIdentity,"},{"line_number":74,"context_line":"                          objects.Portgroup.get,"},{"line_number":75,"context_line":"                          self.context,"}],"source_content_type":"text/x-python","patch_set":45,"id":"da6ed579_4757cfc9","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":44},"in_reply_to":"da6ed579_e98c9fdb","updated":"2016-01-18 17:34:14.000000000","message":"Done","commit_id":"f7847c38a59038439da286575178a2df7a4c0d1e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e2d7a120c3a1dce8d09bb762480d6e65d0f18837","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                    utils.get_test_portgroup(address\u003daddress,"},{"line_number":89,"context_line":"                                             updated_at\u003dtest_time))"},{"line_number":90,"context_line":"                p \u003d objects.Portgroup.get_by_uuid(self.context, uuid)"},{"line_number":91,"context_line":"                p.address \u003d \"b2:54:00:cf:2d:40\""},{"line_number":92,"context_line":"                p.save()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"                mock_get_portgroup.assert_called_once_with(uuid)"}],"source_content_type":"text/x-python","patch_set":45,"id":"da6ed579_6244971a","line":91,"updated":"2016-01-14 00:24:50.000000000","message":"if you do another revision, p.address \u003d address","commit_id":"f7847c38a59038439da286575178a2df7a4c0d1e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2967d417dd2f10bb96f53c3ee7ff02559fbf16ab","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                    utils.get_test_portgroup(address\u003daddress,"},{"line_number":89,"context_line":"                                             updated_at\u003dtest_time))"},{"line_number":90,"context_line":"                p \u003d objects.Portgroup.get_by_uuid(self.context, uuid)"},{"line_number":91,"context_line":"                p.address \u003d \"b2:54:00:cf:2d:40\""},{"line_number":92,"context_line":"                p.save()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"                mock_get_portgroup.assert_called_once_with(uuid)"}],"source_content_type":"text/x-python","patch_set":45,"id":"da6ed579_677e936b","line":91,"in_reply_to":"da6ed579_6244971a","updated":"2016-01-18 17:34:14.000000000","message":"Done","commit_id":"f7847c38a59038439da286575178a2df7a4c0d1e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d234744b4fe6002f84e617ca43c2c27ed0bb630c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import datetime"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":"from testtools.matchers import HasLength"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a5ae5dd_6e445fb6","line":13,"updated":"2016-02-05 18:21:44.000000000","message":"datetime should be in a separate import group.","commit_id":"134ad4cbf6f1930de9c4dd7fd653fedb7decaf18"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"11bd83b0b43109541f5b9de5089d0cb1d294d234","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import datetime"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":"from testtools.matchers import HasLength"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"5a5ae5dd_8d6af77f","line":13,"in_reply_to":"5a5ae5dd_6e445fb6","updated":"2016-02-06 00:05:05.000000000","message":"nit: agreed. For follow-up patch.\n\nJust add blank line after this line.","commit_id":"134ad4cbf6f1930de9c4dd7fd653fedb7decaf18"}],"ironic/tests/unit/objects/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d2f6ff4bd01a032da4003d96159f6e6edbf32ed","unresolved":false,"context_lines":[{"line_number":118,"context_line":"def create_test_portgroup(ctxt, **kw):"},{"line_number":119,"context_line":"    \"\"\"Create and return a test portgroup object."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    Create a port in the DB and return a Portgroup object with appropriate"},{"line_number":122,"context_line":"    attributes."},{"line_number":123,"context_line":"    \"\"\""},{"line_number":124,"context_line":"    portgroup \u003d get_test_portgroup(ctxt, **kw)"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_2193475d","line":121,"updated":"2016-01-12 21:57:14.000000000","message":"s/port/portgroup/","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a598ec149abcefa97ec200a103cd0718604e5122","unresolved":false,"context_lines":[{"line_number":118,"context_line":"def create_test_portgroup(ctxt, **kw):"},{"line_number":119,"context_line":"    \"\"\"Create and return a test portgroup object."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    Create a port in the DB and return a Portgroup object with appropriate"},{"line_number":122,"context_line":"    attributes."},{"line_number":123,"context_line":"    \"\"\""},{"line_number":124,"context_line":"    portgroup \u003d get_test_portgroup(ctxt, **kw)"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_99c26b33","line":121,"in_reply_to":"da6ed579_2193475d","updated":"2016-01-13 23:22:12.000000000","message":"Done","commit_id":"9f6246e88ccbbf316e7d046fd8d8e309715b2411"}]}
