)]}'
{"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4ec3e48f17d7384a132182caa2ef4d521bf9b820","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    except Exception:"},{"line_number":215,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":216,"context_line":"            if f is not None:"},{"line_number":217,"context_line":"                f.close()"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        # NOTE(jlvillal): This yield can not be in the try/except block above"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_76915b46","line":217,"updated":"2015-07-29 10:45:50.000000000","message":"I agree with your change, but this whole code should be organized differently:\n\n with tempfile.NamedTemporaryFile(...) as f:\n   # do everything else\n\nnot an action item for you, but worth fixing one day","commit_id":"18e8232be08a148721739fd2258bab1cd98a45c0"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"463ee5353caf383198c2177f2049ccbeedb7046e","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    except Exception:"},{"line_number":215,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":216,"context_line":"            if f is not None:"},{"line_number":217,"context_line":"                f.close()"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        # NOTE(jlvillal): This yield can not be in the try/except block above"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_510a2921","line":217,"in_reply_to":"3a50d1a3_76915b46","updated":"2015-07-29 11:01:01.000000000","message":"Dmitry, people had also problems with temporary file creations, existing exceptions handling is ok.","commit_id":"18e8232be08a148721739fd2258bab1cd98a45c0"}]}