)]}'
{"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f21ada2ad0066418869af54c9ee56b2ac6b5d66b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    cfg.StrOpt(\u0027trusted_boot_ipxe_script\u0027,"},{"line_number":84,"context_line":"               default\u003dpaths.basedir_def("},{"line_number":85,"context_line":"                   \u0027drivers/modules/trusted_boot.ipxe\u0027),"},{"line_number":86,"context_line":"               help\u003d\u0027Trusted boot needs a special iPXE script file.\u0027),"},{"line_number":87,"context_line":"    cfg.StrOpt(\u0027trusted_boot_ipxe_config_template\u0027,"},{"line_number":88,"context_line":"               default\u003dpaths.basedir_def("},{"line_number":89,"context_line":"                   \u0027drivers/modules/pxe_config.template\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_d1a14a95","line":86,"updated":"2015-08-21 07:09:57.000000000","message":"Can we make the help string tell what is this\n\n  This specifies the iPXE script file to be used when trusted boot is requested.","commit_id":"e3b2466b4affb5fe7d105d6f213579ec260cce64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f21ada2ad0066418869af54c9ee56b2ac6b5d66b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               default\u003dpaths.basedir_def("},{"line_number":85,"context_line":"                   \u0027drivers/modules/trusted_boot.ipxe\u0027),"},{"line_number":86,"context_line":"               help\u003d\u0027Trusted boot needs a special iPXE script file.\u0027),"},{"line_number":87,"context_line":"    cfg.StrOpt(\u0027trusted_boot_ipxe_config_template\u0027,"},{"line_number":88,"context_line":"               default\u003dpaths.basedir_def("},{"line_number":89,"context_line":"                   \u0027drivers/modules/pxe_config.template\u0027),"},{"line_number":90,"context_line":"               help\u003d\u0027Trusted boot still use pxe_config even with ipxe.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_b1985679","line":87,"updated":"2015-08-21 07:09:57.000000000","message":"Do we really need to define another CONF option for this ? Why would someone need a different one only for trusted boot with ipxe ? We are already making the change in the normal CONF.pxe.pxe_config_template as well.\n\nAnd the name is misleading too.  It says ipxe config template, but it is actually a pxelinux config template.","commit_id":"e3b2466b4affb5fe7d105d6f213579ec260cce64"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"37d92e09134b8a20f66714637ae2423407cb029d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               default\u003dpaths.basedir_def("},{"line_number":85,"context_line":"                   \u0027drivers/modules/trusted_boot.ipxe\u0027),"},{"line_number":86,"context_line":"               help\u003d\u0027Trusted boot needs a special iPXE script file.\u0027),"},{"line_number":87,"context_line":"    cfg.StrOpt(\u0027trusted_boot_ipxe_config_template\u0027,"},{"line_number":88,"context_line":"               default\u003dpaths.basedir_def("},{"line_number":89,"context_line":"                   \u0027drivers/modules/pxe_config.template\u0027),"},{"line_number":90,"context_line":"               help\u003d\u0027Trusted boot still use pxe_config even with ipxe.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_2a3a8299","line":87,"in_reply_to":"fa1b9901_b1985679","updated":"2015-09-01 07:53:04.000000000","message":"1. CONF.pxe.pxe_config_template will point to ipxe_config when using iPXE. So the use case here is that an admin should use ipxe_config in general and use trusted_boot_ipxe_config_template only for nodes which request trusted boot. It is potential to need both existed in one environment. \n\n2. Using the name is because it was used under ipxe environment. So user doesn\u0027t has to care about the parameter under pxe enviroment,","commit_id":"e3b2466b4affb5fe7d105d6f213579ec260cce64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f21ada2ad0066418869af54c9ee56b2ac6b5d66b","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        \u0027ari_path\u0027: ramdisk"},{"line_number":259,"context_line":"    }"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":262,"context_line":"        trusted_boot_opts \u003d ("},{"line_number":263,"context_line":"            {\u0027trusted_boot_http_url\u0027: CONF.deploy.http_url + \u0027/\u0027})"},{"line_number":264,"context_line":"        pxe_options.update(trusted_boot_opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_d424d80d","line":261,"updated":"2015-08-21 07:09:57.000000000","message":"Can we add a small comment above saying for trusted boot with ipxe, we use the pxe config template.","commit_id":"e3b2466b4affb5fe7d105d6f213579ec260cce64"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f21ada2ad0066418869af54c9ee56b2ac6b5d66b","unresolved":false,"context_lines":[{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        if deploy_utils.get_boot_mode_for_deploy(node) \u003d\u003d \u0027uefi\u0027:"},{"line_number":480,"context_line":"            pxe_config_template \u003d CONF.pxe.uefi_pxe_config_template"},{"line_number":481,"context_line":"        elif deploy_utils.is_trusted_boot_requested(node):"},{"line_number":482,"context_line":"            pxe_config_template \u003d ("},{"line_number":483,"context_line":"                CONF.trusted_boot.trusted_boot_ipxe_config_template)"},{"line_number":484,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_f19d6e0a","line":481,"updated":"2015-08-21 07:09:57.000000000","message":"If we avoided the need for a new CONF option, we don\u0027t need this check.","commit_id":"e3b2466b4affb5fe7d105d6f213579ec260cce64"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"37d92e09134b8a20f66714637ae2423407cb029d","unresolved":false,"context_lines":[{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        if deploy_utils.get_boot_mode_for_deploy(node) \u003d\u003d \u0027uefi\u0027:"},{"line_number":480,"context_line":"            pxe_config_template \u003d CONF.pxe.uefi_pxe_config_template"},{"line_number":481,"context_line":"        elif deploy_utils.is_trusted_boot_requested(node):"},{"line_number":482,"context_line":"            pxe_config_template \u003d ("},{"line_number":483,"context_line":"                CONF.trusted_boot.trusted_boot_ipxe_config_template)"},{"line_number":484,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_2592b54c","line":481,"in_reply_to":"fa1b9901_f19d6e0a","updated":"2015-09-01 07:53:04.000000000","message":"As I reply above, I think a new CONF option is necessary.","commit_id":"e3b2466b4affb5fe7d105d6f213579ec260cce64"}],"ironic/drivers/modules/pxe_config.template":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f21ada2ad0066418869af54c9ee56b2ac6b5d66b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"append mbr:{{ DISK_IDENTIFIER }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"label trusted_boot"},{"line_number":19,"context_line":"kernel {{pxe_options.trusted_boot_http_url}}mboot.c32"},{"line_number":20,"context_line":"append {{pxe_options.trusted_boot_http_url}}tboot.gz --- {{pxe_options.aki_path}} root\u003d{{ ROOT }} ro text {{ pxe_options.pxe_append_params|default(\"\", true) }} intel_iommu\u003don --- {{pxe_options.ari_path}}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa1b9901_d4f7f8d0","line":19,"updated":"2015-08-21 07:09:57.000000000","message":"Why are we adding .c32 at the end now ? Won\u0027t it break existing users who have put the file as mboot ? I don\u0027t see any instructions in docs though whether it is mboot or mboot.c32.","commit_id":"e3b2466b4affb5fe7d105d6f213579ec260cce64"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"37d92e09134b8a20f66714637ae2423407cb029d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"append mbr:{{ DISK_IDENTIFIER }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"label trusted_boot"},{"line_number":19,"context_line":"kernel {{pxe_options.trusted_boot_http_url}}mboot.c32"},{"line_number":20,"context_line":"append {{pxe_options.trusted_boot_http_url}}tboot.gz --- {{pxe_options.aki_path}} root\u003d{{ ROOT }} ro text {{ pxe_options.pxe_append_params|default(\"\", true) }} intel_iommu\u003don --- {{pxe_options.ari_path}}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da20952f_e5335d60","line":19,"in_reply_to":"fa1b9901_d4f7f8d0","updated":"2015-09-01 07:53:04.000000000","message":"mboot is accepted in PXE/TFTP. But I just found that it is not accepted in PXE/HTTP. It\u0027s so wired. Anyway, mboot.c32 does not have a such problem.","commit_id":"e3b2466b4affb5fe7d105d6f213579ec260cce64"}],"ironic/tests/test_pxe_utils.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f21ada2ad0066418869af54c9ee56b2ac6b5d66b","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            self.assertItemsEqual(expected_info,"},{"line_number":475,"context_line":"                                  pxe_utils.dhcp_options_for_instance(task))"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        self.config(trusted_boot_ipxe_script\u003d\u0027/test/trusted_boot.ipxe\u0027,"},{"line_number":478,"context_line":"                    group\u003d\u0027trusted_boot\u0027)"},{"line_number":479,"context_line":"        expected_boot_script_url \u003d \u0027http://192.0.3.2:1234/trusted_boot.ipxe\u0027"},{"line_number":480,"context_line":"        expected_info \u003d [{\u0027opt_name\u0027: \u0027tag:!ipxe,bootfile-name\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_f4aebc7f","line":477,"updated":"2015-08-21 07:09:57.000000000","message":"Please write a separate test method for this. This already has two test methods clubbed.","commit_id":"e3b2466b4affb5fe7d105d6f213579ec260cce64"}]}