)]}'
{"doc/source/deploy/install-guide.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c8f5246eae8142f4fa7323924bec9c80e680ee09","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"   For more information see the `Maintenance Mode`_ section below."},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":".. note::"},{"line_number":1277,"context_line":"   Please see `State machine and node creation`_ section for information on enrolling nodes using"},{"line_number":1278,"context_line":"   different API versions."},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"Some steps are shown separately for illustration purposes, and may be combined"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a4dcd0f_85877dd6","line":1277,"updated":"2015-08-05 08:38:26.000000000","message":"nit: please wrap at column 80","commit_id":"ddb4e9b01e61183566b47d6320e95ea0dd6d10a2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"563fe70747b0f6bdb200f23eb5a1a702361766e7","unresolved":false,"context_lines":[{"line_number":1950,"context_line":"In the Liberty cycle Ironic introduced a new initial state to it\u0027s state machine."},{"line_number":1951,"context_line":"Prior to API version 1.11 the initial state of a node was \u0027available\u0027."},{"line_number":1952,"context_line":"::"},{"line_number":1953,"context_line":"    ironic --ironic-api-version 1.10 node-create -d agent_ilo -n pre11"},{"line_number":1954,"context_line":"      +--------------+--------------------------------------+"},{"line_number":1955,"context_line":"      | Property     | Value                                |"},{"line_number":1956,"context_line":"      +--------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a4dcd0f_ac03810c","line":1953,"updated":"2015-08-05 09:05:13.000000000","message":"Perhaps it may be better to export the version as a env variable? Or have --ironic-api-version specified for both node-create and node-list commands. It\u0027s just bad-form to use two versions of the APIs for different actions in our examples","commit_id":"ddb4e9b01e61183566b47d6320e95ea0dd6d10a2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c8f5246eae8142f4fa7323924bec9c80e680ee09","unresolved":false,"context_lines":[{"line_number":1962,"context_line":"      | properties   | {}                                   |"},{"line_number":1963,"context_line":"      | name         | pre11                                |"},{"line_number":1964,"context_line":"      +--------------+--------------------------------------+"},{"line_number":1965,"context_line":"    ironic node-list"},{"line_number":1966,"context_line":"      +--------------------------------------+-------+---------------+-------------+--------------------+-------------+"},{"line_number":1967,"context_line":"      | UUID                                 | Name  | Instance UUID | Power State | Provisioning State | Maintenance |"},{"line_number":1968,"context_line":"      +--------------------------------------+-------+---------------+-------------+--------------------+-------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a4dcd0f_256f892c","line":1965,"updated":"2015-08-05 08:38:26.000000000","message":"nit: please separate outputs of 2 commands into own blocks (add new line with ::)","commit_id":"ddb4e9b01e61183566b47d6320e95ea0dd6d10a2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c8f5246eae8142f4fa7323924bec9c80e680ee09","unresolved":false,"context_lines":[{"line_number":1982,"context_line":"      | properties   | {}                                   |"},{"line_number":1983,"context_line":"      | name         | post11                               |"},{"line_number":1984,"context_line":"      +--------------+--------------------------------------+"},{"line_number":1985,"context_line":"    ironic node-list"},{"line_number":1986,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"},{"line_number":1987,"context_line":"      | UUID                                 | Name   | Instance UUID | Power State | Provisioning State | Maintenance |"},{"line_number":1988,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a4dcd0f_456ad51b","line":1985,"updated":"2015-08-05 08:38:26.000000000","message":"ditto","commit_id":"ddb4e9b01e61183566b47d6320e95ea0dd6d10a2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"563fe70747b0f6bdb200f23eb5a1a702361766e7","unresolved":false,"context_lines":[{"line_number":1987,"context_line":"      | UUID                                 | Name   | Instance UUID | Power State | Provisioning State | Maintenance |"},{"line_number":1988,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"},{"line_number":1989,"context_line":"      | 96abe9fd-7488-4188-8e4f-bd391ad3f9c6 | post11 | None          | None        | enroll             | False       |"},{"line_number":1990,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"},{"line_number":1991,"context_line":"Review the `State machine \u003chttps://github.com/openstack/ironic-specs/blob/master/specs/kilo/new-ironic-state-machine.rst\u003e`_"},{"line_number":1992,"context_line":"to see more details on the Ironic state machine."},{"line_number":1993,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a4dcd0f_8c27a5b5","line":1990,"updated":"2015-08-05 09:05:13.000000000","message":"nit: space","commit_id":"ddb4e9b01e61183566b47d6320e95ea0dd6d10a2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"563fe70747b0f6bdb200f23eb5a1a702361766e7","unresolved":false,"context_lines":[{"line_number":1991,"context_line":"Review the `State machine \u003chttps://github.com/openstack/ironic-specs/blob/master/specs/kilo/new-ironic-state-machine.rst\u003e`_"},{"line_number":1992,"context_line":"to see more details on the Ironic state machine."},{"line_number":1993,"context_line":""},{"line_number":1994,"context_line":"This change may impact any current tooling around node creation created before API version 1.11. As demonstrated in the above two"},{"line_number":1995,"context_line":"examples it is easy to overwrite the default API version built in to the client. If your tooling requires nodes be created in the"},{"line_number":1996,"context_line":"active state simply set the API version to 1.10 as in the first example."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a4dcd0f_ac786190","line":1994,"updated":"2015-08-05 09:05:13.000000000","message":"s/created//\n\nAlso I think the way it\u0027s worded seems that the client is going to default to a version \u003e\u003d 1.11 but that doesn\u0027t seem to be the case? By default if no version is specified it seems that the client will continue to use a version \u003c 1.11 (still under discussion but the potential versions are 1.1, 1.6 and 1.9)","commit_id":"ddb4e9b01e61183566b47d6320e95ea0dd6d10a2"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"bf6c839a81bb8e57313cd93c9b42fa191d62c971","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"State machine and node creation"},{"line_number":1281,"context_line":"-------------------------------"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"In the Liberty cycle Ironic introduced a new state to it\u0027s state machine. The"},{"line_number":1284,"context_line":"new initial state \u0027enroll\u0027 was added. Prior to API version 1.11 the initial"},{"line_number":1285,"context_line":"state for newly created nodes was \u0027available\u0027. This change may break existing"},{"line_number":1286,"context_line":"automation tooling with node creation. However because Ironic supports API"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_b731385c","line":1283,"updated":"2015-08-06 17:12:49.000000000","message":"its","commit_id":"355dbc0b0546b698964f2dc9d156e4066e1041f6"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"4bc8fbe1152c71f23fd231311a7834ad8700a9da","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"State machine and node creation"},{"line_number":1281,"context_line":"-------------------------------"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"In the Liberty cycle Ironic introduced a new state to it\u0027s state machine. The"},{"line_number":1284,"context_line":"new initial state \u0027enroll\u0027 was added. Prior to API version 1.11 the initial"},{"line_number":1285,"context_line":"state for newly created nodes was \u0027available\u0027. This change may break existing"},{"line_number":1286,"context_line":"automation tooling with node creation. However because Ironic supports API"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_f6c7b961","line":1283,"in_reply_to":"1a4dcd0f_b731385c","updated":"2015-08-06 19:57:34.000000000","message":"Done","commit_id":"355dbc0b0546b698964f2dc9d156e4066e1041f6"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"bf6c839a81bb8e57313cd93c9b42fa191d62c971","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"-------------------------------"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"In the Liberty cycle Ironic introduced a new state to it\u0027s state machine. The"},{"line_number":1284,"context_line":"new initial state \u0027enroll\u0027 was added. Prior to API version 1.11 the initial"},{"line_number":1285,"context_line":"state for newly created nodes was \u0027available\u0027. This change may break existing"},{"line_number":1286,"context_line":"automation tooling with node creation. However because Ironic supports API"},{"line_number":1287,"context_line":"versioning this behavor can be easly over written."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_17d58ce6","line":1284,"updated":"2015-08-06 17:12:49.000000000","message":"For consistency with the rest of the doc, I feel like we should mark up enroll and available with ``.","commit_id":"355dbc0b0546b698964f2dc9d156e4066e1041f6"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"4bc8fbe1152c71f23fd231311a7834ad8700a9da","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"-------------------------------"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"In the Liberty cycle Ironic introduced a new state to it\u0027s state machine. The"},{"line_number":1284,"context_line":"new initial state \u0027enroll\u0027 was added. Prior to API version 1.11 the initial"},{"line_number":1285,"context_line":"state for newly created nodes was \u0027available\u0027. This change may break existing"},{"line_number":1286,"context_line":"automation tooling with node creation. However because Ironic supports API"},{"line_number":1287,"context_line":"versioning this behavor can be easly over written."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_96ad159d","line":1284,"in_reply_to":"1a4dcd0f_17d58ce6","updated":"2015-08-06 19:57:34.000000000","message":"Done","commit_id":"355dbc0b0546b698964f2dc9d156e4066e1041f6"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"bf6c839a81bb8e57313cd93c9b42fa191d62c971","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"new initial state \u0027enroll\u0027 was added. Prior to API version 1.11 the initial"},{"line_number":1285,"context_line":"state for newly created nodes was \u0027available\u0027. This change may break existing"},{"line_number":1286,"context_line":"automation tooling with node creation. However because Ironic supports API"},{"line_number":1287,"context_line":"versioning this behavor can be easly over written."},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":".. note::"},{"line_number":1290,"context_line":"   The examples below set the API version for a single command. To"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_b22ce699","line":1287,"updated":"2015-08-06 17:12:49.000000000","message":"s/behavor/behavior/\ns/easly/easily/\ns/over written/overwritten/","commit_id":"355dbc0b0546b698964f2dc9d156e4066e1041f6"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"4bc8fbe1152c71f23fd231311a7834ad8700a9da","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"new initial state \u0027enroll\u0027 was added. Prior to API version 1.11 the initial"},{"line_number":1285,"context_line":"state for newly created nodes was \u0027available\u0027. This change may break existing"},{"line_number":1286,"context_line":"automation tooling with node creation. However because Ironic supports API"},{"line_number":1287,"context_line":"versioning this behavor can be easly over written."},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":".. note::"},{"line_number":1290,"context_line":"   The examples below set the API version for a single command. To"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_768169fa","line":1287,"in_reply_to":"1a4dcd0f_b22ce699","updated":"2015-08-06 19:57:34.000000000","message":"Done","commit_id":"355dbc0b0546b698964f2dc9d156e4066e1041f6"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"bf6c839a81bb8e57313cd93c9b42fa191d62c971","unresolved":false,"context_lines":[{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":".. note::"},{"line_number":1290,"context_line":"   The examples below set the API version for a single command. To"},{"line_number":1291,"context_line":"   set the API version for all commands you can set the ENV var:"},{"line_number":1292,"context_line":"   ``IRONIC_API_VERSION``"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"Set the API version to 1.10"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_d71f24b5","line":1291,"updated":"2015-08-06 17:12:49.000000000","message":"I would prefer \"environment variable\" to \"ENV var\" here.","commit_id":"355dbc0b0546b698964f2dc9d156e4066e1041f6"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"4bc8fbe1152c71f23fd231311a7834ad8700a9da","unresolved":false,"context_lines":[{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":".. note::"},{"line_number":1290,"context_line":"   The examples below set the API version for a single command. To"},{"line_number":1291,"context_line":"   set the API version for all commands you can set the ENV var:"},{"line_number":1292,"context_line":"   ``IRONIC_API_VERSION``"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"Set the API version to 1.10"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_7698896a","line":1291,"in_reply_to":"1a4dcd0f_d71f24b5","updated":"2015-08-06 19:57:34.000000000","message":"Done","commit_id":"355dbc0b0546b698964f2dc9d156e4066e1041f6"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"bf6c839a81bb8e57313cd93c9b42fa191d62c971","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"   The current default for the CLI is API version 1.6"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"The below is an example of creating a node with API version 1.10."},{"line_number":1300,"context_line":"::"},{"line_number":1301,"context_line":"   ironic --ironic-api-version 1.10 node-create -d agent_ilo -n pre11"},{"line_number":1302,"context_line":"      +--------------+--------------------------------------+"},{"line_number":1303,"context_line":"      | Property     | Value                                |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_d7e404ad","line":1300,"updated":"2015-08-06 17:12:49.000000000","message":"Either \"the following\" or \"Below\" rather than \"The below\"","commit_id":"355dbc0b0546b698964f2dc9d156e4066e1041f6"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"4bc8fbe1152c71f23fd231311a7834ad8700a9da","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"   The current default for the CLI is API version 1.6"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"The below is an example of creating a node with API version 1.10."},{"line_number":1300,"context_line":"::"},{"line_number":1301,"context_line":"   ironic --ironic-api-version 1.10 node-create -d agent_ilo -n pre11"},{"line_number":1302,"context_line":"      +--------------+--------------------------------------+"},{"line_number":1303,"context_line":"      | Property     | Value                                |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_16a82576","line":1300,"in_reply_to":"1a4dcd0f_d7e404ad","updated":"2015-08-06 19:57:34.000000000","message":"Done","commit_id":"355dbc0b0546b698964f2dc9d156e4066e1041f6"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e7b903b00341f65b1b2626cdc7abed5e5fb6c520","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"new initial state ``enroll`` was added. Prior to API version 1.11 the initial"},{"line_number":1285,"context_line":"state for newly created nodes was ``available``. This change may break existing"},{"line_number":1286,"context_line":"automation tooling with node creation. However because Ironic supports API"},{"line_number":1287,"context_line":"versioning this behavior can be easily overwritten."},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":".. note::"},{"line_number":1290,"context_line":"   The examples below set the API version for a single command. To"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_e11a8bc5","line":1287,"updated":"2015-08-07 01:41:05.000000000","message":"s/overwritten/overridden/","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8a99708dddbfc8c214851556e31b32d09a3e6f4c","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"new initial state ``enroll`` was added. Prior to API version 1.11 the initial"},{"line_number":1285,"context_line":"state for newly created nodes was ``available``. This change may break existing"},{"line_number":1286,"context_line":"automation tooling with node creation. However because Ironic supports API"},{"line_number":1287,"context_line":"versioning this behavior can be easily overwritten."},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":".. note::"},{"line_number":1290,"context_line":"   The examples below set the API version for a single command. To"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_3fc39139","line":1287,"in_reply_to":"1a4dcd0f_e11a8bc5","updated":"2015-08-10 19:51:20.000000000","message":"Done","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e7b903b00341f65b1b2626cdc7abed5e5fb6c520","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"   set the API version for all commands you can set the environment variable:"},{"line_number":1292,"context_line":"   ``IRONIC_API_VERSION``"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"Set the API version to 1.10"},{"line_number":1295,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1296,"context_line":".. note::"},{"line_number":1297,"context_line":"   The current default for the CLI is API version 1.6"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_61d3dbd5","line":1294,"updated":"2015-08-07 01:41:05.000000000","message":"This sounds more like a task, perhaps \"enrolling a node with API version 1.10\"?","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8a99708dddbfc8c214851556e31b32d09a3e6f4c","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"   set the API version for all commands you can set the environment variable:"},{"line_number":1292,"context_line":"   ``IRONIC_API_VERSION``"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"Set the API version to 1.10"},{"line_number":1295,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1296,"context_line":".. note::"},{"line_number":1297,"context_line":"   The current default for the CLI is API version 1.6"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_7fd4b9ea","line":1294,"in_reply_to":"1a4dcd0f_61d3dbd5","updated":"2015-08-10 19:51:20.000000000","message":"Done","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e7b903b00341f65b1b2626cdc7abed5e5fb6c520","unresolved":false,"context_lines":[{"line_number":1319,"context_line":"      +--------------------------------------+-------+---------------+-------------+--------------------+-------------+"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"Set the API version to 1.11"},{"line_number":1323,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1324,"context_line":"Beginning with API version 1.11 the initial state for newly created nodes is \u0027enroll\u0027."},{"line_number":1325,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_01df77d9","line":1322,"updated":"2015-08-07 01:41:05.000000000","message":"Ditto","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8a99708dddbfc8c214851556e31b32d09a3e6f4c","unresolved":false,"context_lines":[{"line_number":1319,"context_line":"      +--------------------------------------+-------+---------------+-------------+--------------------+-------------+"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"Set the API version to 1.11"},{"line_number":1323,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1324,"context_line":"Beginning with API version 1.11 the initial state for newly created nodes is \u0027enroll\u0027."},{"line_number":1325,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_1f0a558a","line":1322,"in_reply_to":"1a4dcd0f_01df77d9","updated":"2015-08-10 19:51:20.000000000","message":"Done","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e7b903b00341f65b1b2626cdc7abed5e5fb6c520","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1324,"context_line":"Beginning with API version 1.11 the initial state for newly created nodes is \u0027enroll\u0027."},{"line_number":1325,"context_line":"::"},{"line_number":1326,"context_line":"    ironic --ironic-api-version 1.11 node-create -d agent_ilo -n post112"},{"line_number":1327,"context_line":"      +--------------+--------------------------------------+"},{"line_number":1328,"context_line":"      | Property     | Value                                |"},{"line_number":1329,"context_line":"      +--------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_a17fa3de","line":1326,"updated":"2015-08-07 01:41:05.000000000","message":"Nit: this name supplied doesn\u0027t match with the response below.","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8a99708dddbfc8c214851556e31b32d09a3e6f4c","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1324,"context_line":"Beginning with API version 1.11 the initial state for newly created nodes is \u0027enroll\u0027."},{"line_number":1325,"context_line":"::"},{"line_number":1326,"context_line":"    ironic --ironic-api-version 1.11 node-create -d agent_ilo -n post112"},{"line_number":1327,"context_line":"      +--------------+--------------------------------------+"},{"line_number":1328,"context_line":"      | Property     | Value                                |"},{"line_number":1329,"context_line":"      +--------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_7ffb5979","line":1326,"in_reply_to":"1a4dcd0f_a17fa3de","updated":"2015-08-10 19:51:20.000000000","message":"Done","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e7b903b00341f65b1b2626cdc7abed5e5fb6c520","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"},{"line_number":1345,"context_line":""},{"line_number":1346,"context_line":"Review the `State machine \u003chttps://github.com/openstack/ironic-specs/blob/master/specs/kilo/new-ironic-state-machine.rst\u003e`_"},{"line_number":1347,"context_line":"to see more details on the Ironic state machine."},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"#. Create a Node in Ironic. At minimum, you must specify the driver name (eg,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_a19b2317","line":1347,"updated":"2015-08-07 01:41:05.000000000","message":"Do we want to mention how to put the node into the available state if it\u0027s enrolled with ENROLL? Perhaps a blurb near the \"node-validate\" command, since some validation will be done with the \"verify\" transition.","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8a99708dddbfc8c214851556e31b32d09a3e6f4c","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"},{"line_number":1345,"context_line":""},{"line_number":1346,"context_line":"Review the `State machine \u003chttps://github.com/openstack/ironic-specs/blob/master/specs/kilo/new-ironic-state-machine.rst\u003e`_"},{"line_number":1347,"context_line":"to see more details on the Ironic state machine."},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"#. Create a Node in Ironic. At minimum, you must specify the driver name (eg,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_d994a9e9","line":1347,"in_reply_to":"1a4dcd0f_a19b2317","updated":"2015-08-10 19:51:20.000000000","message":"Done","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e7b903b00341f65b1b2626cdc7abed5e5fb6c520","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"to see more details on the Ironic state machine."},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"#. Create a Node in Ironic. At minimum, you must specify the driver name (eg,"},{"line_number":1351,"context_line":"   \"pxe_ipmitool\"). This will return the node UUID::"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"    ironic node-create -d pxe_ipmitool"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_c14d0fc5","line":1350,"updated":"2015-08-07 01:41:05.000000000","message":"I think I\u0027d like some sort of header before this line - if you look at the rendered version of the docs, it looks like this is part of the \"Set the API version to 1.11\" section, which is kind of weird.","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8a99708dddbfc8c214851556e31b32d09a3e6f4c","unresolved":false,"context_lines":[{"line_number":1347,"context_line":"to see more details on the Ironic state machine."},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"#. Create a Node in Ironic. At minimum, you must specify the driver name (eg,"},{"line_number":1351,"context_line":"   \"pxe_ipmitool\"). This will return the node UUID::"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"    ironic node-create -d pxe_ipmitool"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_82284e9b","line":1350,"in_reply_to":"1a4dcd0f_c14d0fc5","updated":"2015-08-10 19:51:20.000000000","message":"Done","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e7b903b00341f65b1b2626cdc7abed5e5fb6c520","unresolved":false,"context_lines":[{"line_number":2013,"context_line":""},{"line_number":2014,"context_line":".. note::"},{"line_number":2015,"context_line":"   Please see `State machine and node creation`_ section for information on enrolling nodes using"},{"line_number":2016,"context_line":"   different API versions."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_e1484bb5","line":2016,"updated":"2015-08-07 01:41:05.000000000","message":"This seems a bit out of place, now that the enrollment section has the version info can we just drop this note?","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8a99708dddbfc8c214851556e31b32d09a3e6f4c","unresolved":false,"context_lines":[{"line_number":2013,"context_line":""},{"line_number":2014,"context_line":".. note::"},{"line_number":2015,"context_line":"   Please see `State machine and node creation`_ section for information on enrolling nodes using"},{"line_number":2016,"context_line":"   different API versions."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a4dcd0f_b9a19d48","line":2016,"in_reply_to":"1a4dcd0f_e1484bb5","updated":"2015-08-10 19:51:20.000000000","message":"Done","commit_id":"4bc27d60094336fa3858d22e3217c34dc3d3d5ae"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"89e98b98e374cf3f7fd7cda134191e525a3ba08a","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"    keep_ports \u003d present"},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"  .. note::"},{"line_number":1493,"context_line":"    During Kilo cycle we used on older verions of Inspector called"},{"line_number":1494,"context_line":"    ironic-discoverd_. Inspector is expected to be a mostly drop-in"},{"line_number":1495,"context_line":"    replacement, and the same client library should be used to connect to both."},{"line_number":1496,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_3d3330f8","side":"PARENT","line":1493,"updated":"2015-08-16 10:07:11.000000000","message":"s/verions/versions/","commit_id":"aa0808fc976327f22c28c6d0e30c429293e72c73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1b24f8328b521c6fe61921e86cf80b325b412478","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"   set the API version for all commands you can set the environment variable:"},{"line_number":1292,"context_line":"   ``IRONIC_API_VERSION``"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"Enrolling a node with API version 1.10"},{"line_number":1295,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1296,"context_line":".. note::"},{"line_number":1297,"context_line":"   The current default for the CLI is API version 1.6"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_74fea56c","line":1294,"updated":"2015-08-11 07:53:59.000000000","message":"Let us just call it \"Enrolling a node\" and consume the following chapter as well.","commit_id":"0c39de8a51127589e50a31d1a3fd2cba971e3d0e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1b24f8328b521c6fe61921e86cf80b325b412478","unresolved":false,"context_lines":[{"line_number":1296,"context_line":".. note::"},{"line_number":1297,"context_line":"   The current default for the CLI is API version 1.6"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"Below is an example of creating a node with API version 1.10."},{"line_number":1300,"context_line":"::"},{"line_number":1301,"context_line":"   ironic --ironic-api-version 1.10 node-create -d agent_ilo -n pre11"},{"line_number":1302,"context_line":"      +--------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_9401f16c","line":1299,"updated":"2015-08-11 07:53:59.000000000","message":"should state \"1.10 or older\". it\u0027s not different for 1.9 etc\n\nI also suggest putting it here as an old version of things, and using 1.11 for the remaining enrolling chapter. This is our future anyway :)","commit_id":"0c39de8a51127589e50a31d1a3fd2cba971e3d0e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1b24f8328b521c6fe61921e86cf80b325b412478","unresolved":false,"context_lines":[{"line_number":1321,"context_line":""},{"line_number":1322,"context_line":"Enrolling a node with API version 1.11"},{"line_number":1323,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":1324,"context_line":"Beginning with API version 1.11 the initial state for newly created nodes is \u0027enroll\u0027."},{"line_number":1325,"context_line":"::"},{"line_number":1326,"context_line":"    ironic --ironic-api-version 1.11 node-create -d agent_ilo -n post11"},{"line_number":1327,"context_line":"      +--------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_34f9fd80","line":1324,"updated":"2015-08-11 07:53:59.000000000","message":"nit: s/state/provision state/","commit_id":"0c39de8a51127589e50a31d1a3fd2cba971e3d0e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1b24f8328b521c6fe61921e86cf80b325b412478","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"      | UUID                                 | Name   | Instance UUID | Power State | Provisioning State | Maintenance |"},{"line_number":1342,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"},{"line_number":1343,"context_line":"      | 96abe9fd-7488-4188-8e4f-bd391ad3f9c6 | post11 | None          | None        | enroll             | False       |"},{"line_number":1344,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"},{"line_number":1345,"context_line":""},{"line_number":1346,"context_line":"Review the `State machine \u003chttps://github.com/openstack/ironic-specs/blob/master/specs/kilo/new-ironic-state-machine.rst\u003e`_"},{"line_number":1347,"context_line":"to see more details on the Ironic state machine."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_54f4c985","line":1344,"updated":"2015-08-11 07:53:59.000000000","message":"please add information how to get our of enroll state","commit_id":"0c39de8a51127589e50a31d1a3fd2cba971e3d0e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1b24f8328b521c6fe61921e86cf80b325b412478","unresolved":false,"context_lines":[{"line_number":1343,"context_line":"      | 96abe9fd-7488-4188-8e4f-bd391ad3f9c6 | post11 | None          | None        | enroll             | False       |"},{"line_number":1344,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"},{"line_number":1345,"context_line":""},{"line_number":1346,"context_line":"Review the `State machine \u003chttps://github.com/openstack/ironic-specs/blob/master/specs/kilo/new-ironic-state-machine.rst\u003e`_"},{"line_number":1347,"context_line":"to see more details on the Ironic state machine."},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"Enrollment process"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_f4f2b599","line":1346,"updated":"2015-08-11 07:53:59.000000000","message":"please link to http://specs.openstack.org/openstack/ironic-specs/specs/kilo-implemented/new-ironic-state-machine.html","commit_id":"0c39de8a51127589e50a31d1a3fd2cba971e3d0e"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"89e98b98e374cf3f7fd7cda134191e525a3ba08a","unresolved":false,"context_lines":[{"line_number":1458,"context_line":"   | power      | False  | Missing the following IPMI credentials in node\u0027s driver_info: [\u0027ipmi_address\u0027].                                                     |"},{"line_number":1459,"context_line":"   +------------+--------+-------------------------------------------------------------------------------------------------------------------------------------+"},{"line_number":1460,"context_line":""},{"line_number":1461,"context_line":".. note:: If the node was created in the ``enroll`` state it must be moved in to the ``managable`` state before the node can be made ``available`` for provisioning."},{"line_number":1462,"context_line":"         This can be done with the following command: \u0027ironic node-set-provision-state \u003cnode-uuid\u003e manage\u0027."},{"line_number":1463,"context_line":""},{"line_number":1464,"context_line":".. _ComputeCapabilitiesFilter: http://docs.openstack.org/developer/nova/devref/filter_scheduler.html?highlight\u003dcomputecapabilitiesfilter"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_7d39b8d7","line":1461,"updated":"2015-08-16 10:07:11.000000000","message":"s/managable/manageable/","commit_id":"0c39de8a51127589e50a31d1a3fd2cba971e3d0e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1b24f8328b521c6fe61921e86cf80b325b412478","unresolved":false,"context_lines":[{"line_number":1459,"context_line":"   +------------+--------+-------------------------------------------------------------------------------------------------------------------------------------+"},{"line_number":1460,"context_line":""},{"line_number":1461,"context_line":".. note:: If the node was created in the ``enroll`` state it must be moved in to the ``managable`` state before the node can be made ``available`` for provisioning."},{"line_number":1462,"context_line":"         This can be done with the following command: \u0027ironic node-set-provision-state \u003cnode-uuid\u003e manage\u0027."},{"line_number":1463,"context_line":""},{"line_number":1464,"context_line":".. _ComputeCapabilitiesFilter: http://docs.openstack.org/developer/nova/devref/filter_scheduler.html?highlight\u003dcomputecapabilitiesfilter"},{"line_number":1465,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_14ee41b4","line":1462,"updated":"2015-08-11 07:53:59.000000000","message":"We expect people to use ENROLL by default, so this should be a proper bullet item, not just a note","commit_id":"0c39de8a51127589e50a31d1a3fd2cba971e3d0e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1b24f8328b521c6fe61921e86cf80b325b412478","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"    ones provided above."},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"Inspection can be initiated using node-set-provision-state."},{"line_number":1578,"context_line":"The node should be in MANAGEABLE state before inspection is initiated."},{"line_number":1579,"context_line":""},{"line_number":1580,"context_line":"* Move node to manageable state::"},{"line_number":1581,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a4dcd0f_b42bcdea","line":1578,"updated":"2015-08-11 07:53:59.000000000","message":"While you\u0027re on it, could you please expand this to \"if node is in ENROLL or AVAILABLE provision state, then move...\"","commit_id":"0c39de8a51127589e50a31d1a3fd2cba971e3d0e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e95a7210865c513cd2266ba126d382b09ebebdde","unresolved":false,"context_lines":[{"line_number":1334,"context_line":"State machine and node creation"},{"line_number":1335,"context_line":"-------------------------------"},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"In the Liberty cycle Ironic introduced a new state to its state machine. The"},{"line_number":1338,"context_line":"new initial state ``enroll`` was added. Prior to API version 1.11 the initial"},{"line_number":1339,"context_line":"state for newly created nodes was ``available``. This change may break existing"},{"line_number":1340,"context_line":"automation tooling with node creation. However because Ironic supports API"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_d826b015","line":1337,"updated":"2015-08-25 13:51:37.000000000","message":"so we\u0027re not supposed to use \u0027Ironic\u0027 in external documents; it should be \u0027Bare Metal service\u0027.","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"15d32acd5bf4386f195f89ce44a131c53d884421","unresolved":false,"context_lines":[{"line_number":1334,"context_line":"State machine and node creation"},{"line_number":1335,"context_line":"-------------------------------"},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"In the Liberty cycle Ironic introduced a new state to its state machine. The"},{"line_number":1338,"context_line":"new initial state ``enroll`` was added. Prior to API version 1.11 the initial"},{"line_number":1339,"context_line":"state for newly created nodes was ``available``. This change may break existing"},{"line_number":1340,"context_line":"automation tooling with node creation. However because Ironic supports API"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_735529c0","line":1337,"in_reply_to":"fa1b9901_d826b015","updated":"2015-08-27 01:28:49.000000000","message":"Done","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e95a7210865c513cd2266ba126d382b09ebebdde","unresolved":false,"context_lines":[{"line_number":1350,"context_line":".. note::"},{"line_number":1351,"context_line":"   The current default for the CLI is API version 1.6"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"Below is an example of creating a node with API version up to 1.10."},{"line_number":1354,"context_line":"::"},{"line_number":1355,"context_line":"   ironic --ironic-api-version 1.10 node-create -d agent_ilo -n pre11"},{"line_number":1356,"context_line":"      +--------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_183bc8ec","line":1353,"updated":"2015-08-25 13:51:37.000000000","message":"The wording is awkward here. The example actually creates a node WITH 1.10. You could maybe add \u0027(Versions between 1.2 and 1.9 can also be done this way by replacing the version in the examples.)\u0027 Although I\u0027m not crazy about what I just suggested but that\u0027s an example :)","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"15d32acd5bf4386f195f89ce44a131c53d884421","unresolved":false,"context_lines":[{"line_number":1350,"context_line":".. note::"},{"line_number":1351,"context_line":"   The current default for the CLI is API version 1.6"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"Below is an example of creating a node with API version up to 1.10."},{"line_number":1354,"context_line":"::"},{"line_number":1355,"context_line":"   ironic --ironic-api-version 1.10 node-create -d agent_ilo -n pre11"},{"line_number":1356,"context_line":"      +--------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da20952f_87960593","line":1353,"in_reply_to":"fa1b9901_183bc8ec","updated":"2015-08-27 01:28:49.000000000","message":"I will take a stab at rewording this.","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e95a7210865c513cd2266ba126d382b09ebebdde","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"},{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"Nodes created with API version 1.11 and above must be moved from the provision state ``enroll`` to ``manageable`` and then to"},{"line_number":1401,"context_line":"``available`` in order to deploy a workload on to them. Nodes swtiching between ``enroll`` and ``manageable`` provision states"},{"line_number":1402,"context_line":"will call validate to ensure that ironic is capable of controlling the node, so basic driver and port information will need"},{"line_number":1403,"context_line":"to be configured on the node, adding this information is covered below in the next section."},{"line_number":1404,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_0a1dab61","line":1401,"updated":"2015-08-25 13:51:37.000000000","message":"s/swtiching/switching/\n\ns/on to/onto/ (I think)","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"15d32acd5bf4386f195f89ce44a131c53d884421","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"      +--------------------------------------+--------+---------------+-------------+--------------------+-------------+"},{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"Nodes created with API version 1.11 and above must be moved from the provision state ``enroll`` to ``manageable`` and then to"},{"line_number":1401,"context_line":"``available`` in order to deploy a workload on to them. Nodes swtiching between ``enroll`` and ``manageable`` provision states"},{"line_number":1402,"context_line":"will call validate to ensure that ironic is capable of controlling the node, so basic driver and port information will need"},{"line_number":1403,"context_line":"to be configured on the node, adding this information is covered below in the next section."},{"line_number":1404,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"da20952f_87c4c592","line":1401,"in_reply_to":"fa1b9901_0a1dab61","updated":"2015-08-27 01:28:49.000000000","message":"Done","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e95a7210865c513cd2266ba126d382b09ebebdde","unresolved":false,"context_lines":[{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"Nodes created with API version 1.11 and above must be moved from the provision state ``enroll`` to ``manageable`` and then to"},{"line_number":1401,"context_line":"``available`` in order to deploy a workload on to them. Nodes swtiching between ``enroll`` and ``manageable`` provision states"},{"line_number":1402,"context_line":"will call validate to ensure that ironic is capable of controlling the node, so basic driver and port information will need"},{"line_number":1403,"context_line":"to be configured on the node, adding this information is covered below in the next section."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if validation fails, so it is recamended that"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_aa459f43","line":1402,"updated":"2015-08-25 13:51:37.000000000","message":"The node doesn\u0027t call validate. The conductor does. How about\n\ns/will call validate/will be validated/\n\nI just remembered that I don\u0027t like to use the term \u0027validate\u0027 here because folks can confuse that with the actual validate() routines we have. I think we use \u0027verify\u0027 here[0].\n\n[0] http://docs.openstack.org/developer/ironic/_images/states.svg","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"15d32acd5bf4386f195f89ce44a131c53d884421","unresolved":false,"context_lines":[{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"Nodes created with API version 1.11 and above must be moved from the provision state ``enroll`` to ``manageable`` and then to"},{"line_number":1401,"context_line":"``available`` in order to deploy a workload on to them. Nodes swtiching between ``enroll`` and ``manageable`` provision states"},{"line_number":1402,"context_line":"will call validate to ensure that ironic is capable of controlling the node, so basic driver and port information will need"},{"line_number":1403,"context_line":"to be configured on the node, adding this information is covered below in the next section."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if validation fails, so it is recamended that"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da20952f_c725dd5c","line":1402,"in_reply_to":"fa1b9901_aa459f43","updated":"2015-08-27 01:28:49.000000000","message":"Done","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e95a7210865c513cd2266ba126d382b09ebebdde","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"Nodes created with API version 1.11 and above must be moved from the provision state ``enroll`` to ``manageable`` and then to"},{"line_number":1401,"context_line":"``available`` in order to deploy a workload on to them. Nodes swtiching between ``enroll`` and ``manageable`` provision states"},{"line_number":1402,"context_line":"will call validate to ensure that ironic is capable of controlling the node, so basic driver and port information will need"},{"line_number":1403,"context_line":"to be configured on the node, adding this information is covered below in the next section."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if validation fails, so it is recamended that"},{"line_number":1406,"context_line":"          ``ironic node-validate`` be run before attempting to move out of the enroll state. ``ironic node-show`` should also"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_aae11f2c","line":1403,"updated":"2015-08-25 13:51:37.000000000","message":"The sentence starts off with \u0027Nodes\u0027 yet this is a \u0027node\u0027. Maybe you can just change it to be \u0027A node switching...\u0027\n\nAlso, it might be good to chop this into 2 sentences. eg s/node, adding/node. Adding/","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"15d32acd5bf4386f195f89ce44a131c53d884421","unresolved":false,"context_lines":[{"line_number":1400,"context_line":"Nodes created with API version 1.11 and above must be moved from the provision state ``enroll`` to ``manageable`` and then to"},{"line_number":1401,"context_line":"``available`` in order to deploy a workload on to them. Nodes swtiching between ``enroll`` and ``manageable`` provision states"},{"line_number":1402,"context_line":"will call validate to ensure that ironic is capable of controlling the node, so basic driver and port information will need"},{"line_number":1403,"context_line":"to be configured on the node, adding this information is covered below in the next section."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if validation fails, so it is recamended that"},{"line_number":1406,"context_line":"          ``ironic node-validate`` be run before attempting to move out of the enroll state. ``ironic node-show`` should also"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da20952f_07dd1514","line":1403,"in_reply_to":"fa1b9901_aae11f2c","updated":"2015-08-27 01:28:49.000000000","message":"Done","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e95a7210865c513cd2266ba126d382b09ebebdde","unresolved":false,"context_lines":[{"line_number":1402,"context_line":"will call validate to ensure that ironic is capable of controlling the node, so basic driver and port information will need"},{"line_number":1403,"context_line":"to be configured on the node, adding this information is covered below in the next section."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if validation fails, so it is recamended that"},{"line_number":1406,"context_line":"          ``ironic node-validate`` be run before attempting to move out of the enroll state. ``ironic node-show`` should also"},{"line_number":1407,"context_line":"          be used to ensure that the provision state has changed before continuing. "},{"line_number":1408,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_0a55abc0","line":1405,"updated":"2015-08-25 13:51:37.000000000","message":"Is that true? It should report a failure.\n\ns/recamended/recommended/","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"15d32acd5bf4386f195f89ce44a131c53d884421","unresolved":false,"context_lines":[{"line_number":1402,"context_line":"will call validate to ensure that ironic is capable of controlling the node, so basic driver and port information will need"},{"line_number":1403,"context_line":"to be configured on the node, adding this information is covered below in the next section."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if validation fails, so it is recamended that"},{"line_number":1406,"context_line":"          ``ironic node-validate`` be run before attempting to move out of the enroll state. ``ironic node-show`` should also"},{"line_number":1407,"context_line":"          be used to ensure that the provision state has changed before continuing. "},{"line_number":1408,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"da20952f_c7fddd6f","line":1405,"in_reply_to":"fa1b9901_0a55abc0","updated":"2015-08-27 01:28:49.000000000","message":"Yes it is. edit done","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e95a7210865c513cd2266ba126d382b09ebebdde","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"to be configured on the node, adding this information is covered below in the next section."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if validation fails, so it is recamended that"},{"line_number":1406,"context_line":"          ``ironic node-validate`` be run before attempting to move out of the enroll state. ``ironic node-show`` should also"},{"line_number":1407,"context_line":"          be used to ensure that the provision state has changed before continuing. "},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"To move nodes out of the ``enroll`` state use the node-set-provision-state command."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_2a118f04","line":1406,"updated":"2015-08-25 13:51:37.000000000","message":"I don\u0027t think this is true. They could run node-validate, but an actual validate() call does more than the \u0027verifying\u0027 that is done between enroll-\u003emanageable.","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"15d32acd5bf4386f195f89ce44a131c53d884421","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"to be configured on the node, adding this information is covered below in the next section."},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if validation fails, so it is recamended that"},{"line_number":1406,"context_line":"          ``ironic node-validate`` be run before attempting to move out of the enroll state. ``ironic node-show`` should also"},{"line_number":1407,"context_line":"          be used to ensure that the provision state has changed before continuing. "},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"To move nodes out of the ``enroll`` state use the node-set-provision-state command."}],"source_content_type":"text/x-rst","patch_set":7,"id":"da20952f_f03c5331","line":1406,"in_reply_to":"fa1b9901_2a118f04","updated":"2015-08-27 01:28:49.000000000","message":"Done","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"15d32acd5bf4386f195f89ce44a131c53d884421","unresolved":false,"context_lines":[{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if validation fails, so it is recamended that"},{"line_number":1406,"context_line":"          ``ironic node-validate`` be run before attempting to move out of the enroll state. ``ironic node-show`` should also"},{"line_number":1407,"context_line":"          be used to ensure that the provision state has changed before continuing. "},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"To move nodes out of the ``enroll`` state use the node-set-provision-state command."},{"line_number":1410,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da20952f_7017e3a3","line":1407,"updated":"2015-08-27 01:28:49.000000000","message":"Done","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"5baa6d793b50d0c0cb842e2d875cb313cc8e6b2d","unresolved":false,"context_lines":[{"line_number":1419,"context_line":"      | management | True   |               |"},{"line_number":1420,"context_line":"      | power      | True   |               |"},{"line_number":1421,"context_line":"      | raid       | None   | not supported |"},{"line_number":1422,"context_line":"      +------------+--------+---------------+    "},{"line_number":1423,"context_line":"    ironic node-set-provision-state 0eb013bb-1e4b-4f4c-94b5-2e7468242611 manage"},{"line_number":1424,"context_line":"    ironic node-show 0eb013bb-1e4b-4f4c-94b5-2e7468242611"},{"line_number":1425,"context_line":"      +------------------------+--------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_708ebfd1","line":1422,"updated":"2015-08-24 21:17:38.000000000","message":"will correct whitespace with the next rev.","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"15d32acd5bf4386f195f89ce44a131c53d884421","unresolved":false,"context_lines":[{"line_number":1419,"context_line":"      | management | True   |               |"},{"line_number":1420,"context_line":"      | power      | True   |               |"},{"line_number":1421,"context_line":"      | raid       | None   | not supported |"},{"line_number":1422,"context_line":"      +------------+--------+---------------+    "},{"line_number":1423,"context_line":"    ironic node-set-provision-state 0eb013bb-1e4b-4f4c-94b5-2e7468242611 manage"},{"line_number":1424,"context_line":"    ironic node-show 0eb013bb-1e4b-4f4c-94b5-2e7468242611"},{"line_number":1425,"context_line":"      +------------------------+--------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da20952f_b046dbbd","line":1422,"in_reply_to":"fa1b9901_708ebfd1","updated":"2015-08-27 01:28:49.000000000","message":"Done","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e95a7210865c513cd2266ba126d382b09ebebdde","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"   | power      | False  | Missing the following IPMI credentials in node\u0027s driver_info: [\u0027ipmi_address\u0027].                                                     |"},{"line_number":1599,"context_line":"   +------------+--------+-------------------------------------------------------------------------------------------------------------------------------------+"},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":".. note:: If the node was created in the ``enroll`` state it must be moved in to the ``managable`` state before the node can be made ``available`` for provisioning."},{"line_number":1602,"context_line":"         This can be done with the following command: \u0027ironic node-set-provision-state \u003cnode-uuid\u003e manage\u0027."},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":".. _ComputeCapabilitiesFilter: http://docs.openstack.org/developer/nova/devref/filter_scheduler.html?highlight\u003dcomputecapabilitiesfilter"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_78d68428","line":1601,"updated":"2015-08-25 13:51:37.000000000","message":"s/in to/into/\n\ns/managable/manageable/\n\nAlso -- I thought we had a max line length which this line seems to exceed.","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"15d32acd5bf4386f195f89ce44a131c53d884421","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"   | power      | False  | Missing the following IPMI credentials in node\u0027s driver_info: [\u0027ipmi_address\u0027].                                                     |"},{"line_number":1599,"context_line":"   +------------+--------+-------------------------------------------------------------------------------------------------------------------------------------+"},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":".. note:: If the node was created in the ``enroll`` state it must be moved in to the ``managable`` state before the node can be made ``available`` for provisioning."},{"line_number":1602,"context_line":"         This can be done with the following command: \u0027ironic node-set-provision-state \u003cnode-uuid\u003e manage\u0027."},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":".. _ComputeCapabilitiesFilter: http://docs.openstack.org/developer/nova/devref/filter_scheduler.html?highlight\u003dcomputecapabilitiesfilter"}],"source_content_type":"text/x-rst","patch_set":7,"id":"da20952f_732b6d83","line":1601,"in_reply_to":"fa1b9901_78d68428","updated":"2015-08-27 01:28:49.000000000","message":"Done","commit_id":"a6908658e1784d5ec644e7b4c11caeab26073231"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7a8ce1945bd1126b3733e6e5e22dd2eebeed8f50","unresolved":false,"context_lines":[{"line_number":1351,"context_line":"   The current default for the CLI is API version 1.9"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"Below is an example of creating a node with API version 1.10. This is only"},{"line_number":1354,"context_line":"and example and other API versions may be substituted in its place.  "},{"line_number":1355,"context_line":"::"},{"line_number":1356,"context_line":"   ironic --ironic-api-version 1.10 node-create -d agent_ilo -n pre11"},{"line_number":1357,"context_line":"      +--------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da20952f_97905b97","line":1354,"updated":"2015-08-27 10:15:12.000000000","message":"nit - s/and example/an example, also whitespace error","commit_id":"44461a56126f327acb768e9e5f26ff2aed0749fb"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"57842b3f3d9bdd975821746dd3191fde9668a2c1","unresolved":false,"context_lines":[{"line_number":1351,"context_line":"   The current default for the CLI is API version 1.9"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"Below is an example of creating a node with API version 1.10. This is only"},{"line_number":1354,"context_line":"and example and other API versions may be substituted in its place.  "},{"line_number":1355,"context_line":"::"},{"line_number":1356,"context_line":"   ironic --ironic-api-version 1.10 node-create -d agent_ilo -n pre11"},{"line_number":1357,"context_line":"      +--------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da20952f_3bbd9f68","line":1354,"in_reply_to":"da20952f_97905b97","updated":"2015-08-27 17:58:05.000000000","message":"Done","commit_id":"44461a56126f327acb768e9e5f26ff2aed0749fb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7a8ce1945bd1126b3733e6e5e22dd2eebeed8f50","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"will verify that ironic is capable of controlling the node, so basic power and port information will need to be configured"},{"line_number":1404,"context_line":"on the node. Adding this information is covered below in the next section."},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if verify fails, so it is"},{"line_number":1407,"context_line":"          recommended that ``ironic node-show`` be used to ensure that the provision state has changed before continuing."},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"To move nodes out of the ``enroll`` state use the node-set-provision-state command."}],"source_content_type":"text/x-rst","patch_set":8,"id":"da20952f_326e3dca","line":1406,"updated":"2015-08-27 10:15:12.000000000","message":"Maybe omit \u0027it should be noted\u0027, as it is rendered as \u0027Note: It should be noted...\u0027","commit_id":"44461a56126f327acb768e9e5f26ff2aed0749fb"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"57842b3f3d9bdd975821746dd3191fde9668a2c1","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"will verify that ironic is capable of controlling the node, so basic power and port information will need to be configured"},{"line_number":1404,"context_line":"on the node. Adding this information is covered below in the next section."},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":".. note:: It should be noted that ``ironic node-set-provision-state`` will not report back if verify fails, so it is"},{"line_number":1407,"context_line":"          recommended that ``ironic node-show`` be used to ensure that the provision state has changed before continuing."},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"To move nodes out of the ``enroll`` state use the node-set-provision-state command."}],"source_content_type":"text/x-rst","patch_set":8,"id":"da20952f_9b54eb21","line":1406,"in_reply_to":"da20952f_326e3dca","updated":"2015-08-27 17:58:05.000000000","message":"Done","commit_id":"44461a56126f327acb768e9e5f26ff2aed0749fb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7a8ce1945bd1126b3733e6e5e22dd2eebeed8f50","unresolved":false,"context_lines":[{"line_number":1547,"context_line":".. note:: If a node was created in the ``enroll`` state it must be moved into"},{"line_number":1548,"context_line":"          the ``manageable`` state before the node can be made ``available``"},{"line_number":1549,"context_line":"          for provisioning. This can be done with the following command:"},{"line_number":1550,"context_line":"          ``ironic node-set-provision-state \u003cnode-uuid\u003e manage``."},{"line_number":1551,"context_line":""},{"line_number":1552,"context_line":".. _ComputeCapabilitiesFilter: http://docs.openstack.org/developer/nova/devref/filter_scheduler.html?highlight\u003dcomputecapabilitiesfilter"},{"line_number":1553,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"da20952f_52f891e5","line":1550,"updated":"2015-08-27 10:15:12.000000000","message":"Maybe mention provide here too?","commit_id":"44461a56126f327acb768e9e5f26ff2aed0749fb"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"57842b3f3d9bdd975821746dd3191fde9668a2c1","unresolved":false,"context_lines":[{"line_number":1547,"context_line":".. note:: If a node was created in the ``enroll`` state it must be moved into"},{"line_number":1548,"context_line":"          the ``manageable`` state before the node can be made ``available``"},{"line_number":1549,"context_line":"          for provisioning. This can be done with the following command:"},{"line_number":1550,"context_line":"          ``ironic node-set-provision-state \u003cnode-uuid\u003e manage``."},{"line_number":1551,"context_line":""},{"line_number":1552,"context_line":".. _ComputeCapabilitiesFilter: http://docs.openstack.org/developer/nova/devref/filter_scheduler.html?highlight\u003dcomputecapabilitiesfilter"},{"line_number":1553,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"da20952f_963042ea","line":1550,"in_reply_to":"da20952f_52f891e5","updated":"2015-08-27 17:58:05.000000000","message":"Done","commit_id":"44461a56126f327acb768e9e5f26ff2aed0749fb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5efa3966de0ff6d3326e099c0c73e3dbfe8aca35","unresolved":false,"context_lines":[{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"Some steps are shown separately for illustration purposes, and may be combined"},{"line_number":1332,"context_line":"if desired."},{"line_number":1333,"context_line":""},{"line_number":1334,"context_line":"State machine and node creation"},{"line_number":1335,"context_line":"-------------------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_4f38c4a0","line":1332,"updated":"2015-08-27 21:03:37.000000000","message":"I think it might make more sense if this sentence was moved to be after \u0027Enrollment process\u0027.","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8a7a41a3107fe3d7cbc481ff37edfc1ce0dd2fbb","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"the initial state for newly created nodes was ``available``. This change may"},{"line_number":1340,"context_line":"break existing automation tooling with node creation. However because the Bare"},{"line_number":1341,"context_line":"Metal service supports API versioning this behavior can be easily overridden."},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":".. note::"},{"line_number":1344,"context_line":"   The examples below set the API version for a single command. To"},{"line_number":1345,"context_line":"   set the API version for all commands you can set the environment variable:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_ea1c2e15","line":1342,"updated":"2015-08-27 18:48:50.000000000","message":"Now that we decided to set the default on client to 1.9, and the default on the server is 1.1 still, I wonder if we should mention that someone has to explicitly specify 1.11 or higher to get this behaviour.\n\nMaybe add a link to http://docs.openstack.org/developer/ironic/webapi/v1.html#api-versioning if someone wants more information about the versioning.","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"914044d112548de4a9c615f6bd6a986fcd1439e5","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"the initial state for newly created nodes was ``available``. This change may"},{"line_number":1340,"context_line":"break existing automation tooling with node creation. However because the Bare"},{"line_number":1341,"context_line":"Metal service supports API versioning this behavior can be easily overridden."},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":".. note::"},{"line_number":1344,"context_line":"   The examples below set the API version for a single command. To"},{"line_number":1345,"context_line":"   set the API version for all commands you can set the environment variable:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_be6b4a84","line":1342,"in_reply_to":"da20952f_ea1c2e15","updated":"2015-08-31 20:55:42.000000000","message":"There is a note below that the default is 1.9","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5efa3966de0ff6d3326e099c0c73e3dbfe8aca35","unresolved":false,"context_lines":[{"line_number":1343,"context_line":".. note::"},{"line_number":1344,"context_line":"   The examples below set the API version for a single command. To"},{"line_number":1345,"context_line":"   set the API version for all commands you can set the environment variable:"},{"line_number":1346,"context_line":"   ``IRONIC_API_VERSION``"},{"line_number":1347,"context_line":""},{"line_number":1348,"context_line":"Enrolling a node"},{"line_number":1349,"context_line":"~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_1445056f","line":1346,"updated":"2015-08-27 21:03:37.000000000","message":"missing and ending \u0027.\u0027.","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8a7a41a3107fe3d7cbc481ff37edfc1ce0dd2fbb","unresolved":false,"context_lines":[{"line_number":1345,"context_line":"   set the API version for all commands you can set the environment variable:"},{"line_number":1346,"context_line":"   ``IRONIC_API_VERSION``"},{"line_number":1347,"context_line":""},{"line_number":1348,"context_line":"Enrolling a node"},{"line_number":1349,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":1350,"context_line":".. note::"},{"line_number":1351,"context_line":"   The current default for the CLI is API version 1.9"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_8d04acc0","line":1348,"updated":"2015-08-27 18:48:50.000000000","message":"I have to look at the rendered page. I don\u0027t know if this should be changed to \u0027Enrolling a node with API version 1.10 and below\u0027 or whether we should have two subsections underneath this, one with \u0027Enrolling a node ...\u0027 (as above) and what you have at line 1377.","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5efa3966de0ff6d3326e099c0c73e3dbfe8aca35","unresolved":false,"context_lines":[{"line_number":1346,"context_line":"   ``IRONIC_API_VERSION``"},{"line_number":1347,"context_line":""},{"line_number":1348,"context_line":"Enrolling a node"},{"line_number":1349,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":1350,"context_line":".. note::"},{"line_number":1351,"context_line":"   The current default for the CLI is API version 1.9"},{"line_number":1352,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_ef0f582c","line":1349,"updated":"2015-08-27 21:03:37.000000000","message":"I took a look at the rendered page, and the Table of Contents is incorrect.\n\nYou need to use \u0027---\u0027 not \u0027~~~\u0027, if you want this to be at the same level as the \u0027State machine...\u0027 above.\n\nSame thing for all the other sections you added.","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"914044d112548de4a9c615f6bd6a986fcd1439e5","unresolved":false,"context_lines":[{"line_number":1401,"context_line":"Nodes created with API version 1.11 and above must be moved from the provision state ``enroll`` to ``manageable`` and then to"},{"line_number":1402,"context_line":"``available`` in order to deploy a workload onto them. A node switching between ``enroll`` and ``manageable`` provision states"},{"line_number":1403,"context_line":"will verify that ironic is capable of controlling the node, so basic power and port information will need to be configured"},{"line_number":1404,"context_line":"on the node. Adding this information is covered below in the next section."},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":".. note:: ``ironic node-set-provision-state`` will not directly report back if verify fails, so it is"},{"line_number":1407,"context_line":"          recommended that ``ironic node-show`` be used to ensure that the provision state has changed"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_7e2ff23e","line":1404,"updated":"2015-08-31 20:55:42.000000000","message":"This paragraph seems like it\u0027s wrapped too far... not a big deal but mind shortening it up?","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8a7a41a3107fe3d7cbc481ff37edfc1ce0dd2fbb","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"will verify that ironic is capable of controlling the node, so basic power and port information will need to be configured"},{"line_number":1404,"context_line":"on the node. Adding this information is covered below in the next section."},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":".. note:: ``ironic node-set-provision-state`` will not directly report back if verify fails, so it is"},{"line_number":1407,"context_line":"          recommended that ``ironic node-show`` be used to ensure that the provision state has changed"},{"line_number":1408,"context_line":"          before continuing."},{"line_number":1409,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_eaac2e37","line":1406,"updated":"2015-08-27 18:48:50.000000000","message":"Maybe preface this with \u0027Because it is an asynchronous call, ``ironic node-set-provision-state``...\n\nwell, how about\n\nBecause it is an asynchronous call, the response for ``ironic node-set-provision-state`` will not indicate whether the transition succeeded or not. You can check the status of the operation via an ``ironic node-show``. If it was successful, ``provision_state`` will be \u0027manageable\u0027. If the verification failed, there will be information in ``last_error``.","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"914044d112548de4a9c615f6bd6a986fcd1439e5","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"will verify that ironic is capable of controlling the node, so basic power and port information will need to be configured"},{"line_number":1404,"context_line":"on the node. Adding this information is covered below in the next section."},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":".. note:: ``ironic node-set-provision-state`` will not directly report back if verify fails, so it is"},{"line_number":1407,"context_line":"          recommended that ``ironic node-show`` be used to ensure that the provision state has changed"},{"line_number":1408,"context_line":"          before continuing."},{"line_number":1409,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_bec7ca62","line":1406,"in_reply_to":"da20952f_eaac2e37","updated":"2015-08-31 20:55:42.000000000","message":"I like these words, +1","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8a7a41a3107fe3d7cbc481ff37edfc1ce0dd2fbb","unresolved":false,"context_lines":[{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"To move nodes out of the ``enroll`` state use the node-set-provision-state command."},{"line_number":1411,"context_line":"::"},{"line_number":1412,"context_line":"    ironic node-set-provision-state 0eb013bb-1e4b-4f4c-94b5-2e7468242611 manage"},{"line_number":1413,"context_line":"    ironic node-show 0eb013bb-1e4b-4f4c-94b5-2e7468242611"},{"line_number":1414,"context_line":"      +------------------------+--------------------------------------------------------------------+"},{"line_number":1415,"context_line":"      | Property               | Value                                                              |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_2d5c80ec","line":1412,"updated":"2015-08-27 18:48:50.000000000","message":"I\u0027m not sure but maybe here, or around line 1381, maybe we can mention that it assumes the version is 1.11? Or explicitly put --ironic-api-version 1.11?","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"914044d112548de4a9c615f6bd6a986fcd1439e5","unresolved":false,"context_lines":[{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"To move nodes out of the ``enroll`` state use the node-set-provision-state command."},{"line_number":1411,"context_line":"::"},{"line_number":1412,"context_line":"    ironic node-set-provision-state 0eb013bb-1e4b-4f4c-94b5-2e7468242611 manage"},{"line_number":1413,"context_line":"    ironic node-show 0eb013bb-1e4b-4f4c-94b5-2e7468242611"},{"line_number":1414,"context_line":"      +------------------------+--------------------------------------------------------------------+"},{"line_number":1415,"context_line":"      | Property               | Value                                                              |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_5eb6aef9","line":1412,"in_reply_to":"da20952f_2d5c80ec","updated":"2015-08-31 20:55:42.000000000","message":"+1","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5efa3966de0ff6d3326e099c0c73e3dbfe8aca35","unresolved":false,"context_lines":[{"line_number":1456,"context_line":"   assigned to the node. This can be done when the node is created by"},{"line_number":1457,"context_line":"   adding the ``-n`` option to the ``node-create`` command or by updating an"},{"line_number":1458,"context_line":"   existing node with the ``node-update`` command. See `Logical Names`_ for"},{"line_number":1459,"context_line":"   examples."},{"line_number":1460,"context_line":""},{"line_number":1461,"context_line":"#. Update the node ``driver_info`` so that Bare Metal service can manage the"},{"line_number":1462,"context_line":"   node. Different drivers may require different information about the node."}],"source_content_type":"text/x-rst","patch_set":9,"id":"da20952f_4fd4441f","line":1459,"updated":"2015-08-27 21:03:37.000000000","message":"This step here is partially described above in the two new sections you added. I\u0027m not quite sure what the best way is, to tie this in with the above.\n\nNow I\u0027m wondering whether we should get rid of the above new sections you added, and add the two ways of creating a node here. Or have the create-a-node section somewhere, with a pointer here to that section and get rid of all this.\n\nAnd then where you have the NOTE at line 1548, put in two steps to move the node into available state, if using api version \u003e\u003d 1.11.","commit_id":"421def9c167b3a2212630390f3ac608ab9ce35df"}]}
