)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"ccb3d340a73c8a4cebdae39d932837dac0b7d37f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Resizing nodes.driver column"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While the compositon spec doesn\u0027t lands, we have the option to"},{"line_number":10,"context_line":"sppecify the boot interface using the driver name. This patch"},{"line_number":11,"context_line":"increases the \u0027driver\u0027 column on the nodes table to hold higher"},{"line_number":12,"context_line":"driver names."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_fd8dc82a","line":9,"updated":"2015-08-16 11:22:33.000000000","message":"s/compositon/composition/","commit_id":"2597ca86578145e18281b4f4e3ac61bd76d5af9e"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"ccb3d340a73c8a4cebdae39d932837dac0b7d37f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Resizing nodes.driver column"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While the compositon spec doesn\u0027t lands, we have the option to"},{"line_number":10,"context_line":"sppecify the boot interface using the driver name. This patch"},{"line_number":11,"context_line":"increases the \u0027driver\u0027 column on the nodes table to hold higher"},{"line_number":12,"context_line":"driver names."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_bd974039","line":10,"updated":"2015-08-16 11:22:33.000000000","message":"s/sppecify/specify/","commit_id":"2597ca86578145e18281b4f4e3ac61bd76d5af9e"}],"ironic/db/sqlalchemy/alembic/versions/516faf1bb9b1_resizing_column_nodes_driver.py":[{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"6d4d35d2ee374aafdf794b3c74b4b0227f7118e7","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":"import sqlalchemy as sa"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def upgrade():"},{"line_number":29,"context_line":"    op.alter_column(\u0027nodes\u0027, \u0027driver\u0027,"},{"line_number":30,"context_line":"                    existing_type\u003dsa.String(length\u003d15),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_6a0c39ed","line":27,"updated":"2015-08-06 11:06:05.000000000","message":"2 blank lines are required here. pep8 is failing because of it and ya, extra line at the end","commit_id":"3a266da1a8fd61fbfceeaf1461b7205f387c5033"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"09f0df8125d58b5d17bc064c67d341463e956932","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":"import sqlalchemy as sa"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def upgrade():"},{"line_number":29,"context_line":"    op.alter_column(\u0027nodes\u0027, \u0027driver\u0027,"},{"line_number":30,"context_line":"                    existing_type\u003dsa.String(length\u003d15),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_b6a5c8a2","line":27,"in_reply_to":"1a4dcd0f_6a0c39ed","updated":"2015-08-06 12:34:16.000000000","message":"Done","commit_id":"3a266da1a8fd61fbfceeaf1461b7205f387c5033"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"3c41dc329aa06549b852605d5e3276295d1b5cfd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def downgrade():"},{"line_number":35,"context_line":"    op.alter_column(\u0027nodes\u0027, \u0027driver\u0027,"},{"line_number":36,"context_line":"                    existing_type\u003dsa.String(length\u003d25),"},{"line_number":37,"context_line":"                    type_\u003dsa.String(length\u003d15))"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_0407b8ca","line":37,"updated":"2015-08-06 06:54:31.000000000","message":"We reduse the driver size to 15, will truncate driver name, and will not enable the driver I think, so can we do not support downgrade for this migration case?","commit_id":"3a266da1a8fd61fbfceeaf1461b7205f387c5033"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"09f0df8125d58b5d17bc064c67d341463e956932","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def downgrade():"},{"line_number":35,"context_line":"    op.alter_column(\u0027nodes\u0027, \u0027driver\u0027,"},{"line_number":36,"context_line":"                    existing_type\u003dsa.String(length\u003d25),"},{"line_number":37,"context_line":"                    type_\u003dsa.String(length\u003d15))"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_761e60bc","line":37,"in_reply_to":"1a4dcd0f_0407b8ca","updated":"2015-08-06 12:34:16.000000000","message":"Fair enough. Since raise an exception would break migrations to prior states, I\u0027ll let just a \u0027pass\u0027 here. What do you think?","commit_id":"3a266da1a8fd61fbfceeaf1461b7205f387c5033"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"3c41dc329aa06549b852605d5e3276295d1b5cfd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    op.alter_column(\u0027nodes\u0027, \u0027driver\u0027,"},{"line_number":36,"context_line":"                    existing_type\u003dsa.String(length\u003d25),"},{"line_number":37,"context_line":"                    type_\u003dsa.String(length\u003d15))"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_e4f5ecec","line":38,"updated":"2015-08-06 06:54:31.000000000","message":"The blank line in EOF is not required I think.","commit_id":"3a266da1a8fd61fbfceeaf1461b7205f387c5033"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"6d4d35d2ee374aafdf794b3c74b4b0227f7118e7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    op.alter_column(\u0027nodes\u0027, \u0027driver\u0027,"},{"line_number":36,"context_line":"                    existing_type\u003dsa.String(length\u003d25),"},{"line_number":37,"context_line":"                    type_\u003dsa.String(length\u003d15))"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_0a24955d","line":38,"in_reply_to":"1a4dcd0f_e4f5ecec","updated":"2015-08-06 11:06:05.000000000","message":"+1","commit_id":"3a266da1a8fd61fbfceeaf1461b7205f387c5033"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"09f0df8125d58b5d17bc064c67d341463e956932","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    op.alter_column(\u0027nodes\u0027, \u0027driver\u0027,"},{"line_number":36,"context_line":"                    existing_type\u003dsa.String(length\u003d25),"},{"line_number":37,"context_line":"                    type_\u003dsa.String(length\u003d15))"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_961becc9","line":38,"in_reply_to":"1a4dcd0f_e4f5ecec","updated":"2015-08-06 12:34:16.000000000","message":"Done","commit_id":"3a266da1a8fd61fbfceeaf1461b7205f387c5033"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5892eb7cce0739fdb2857369fe4a6b3969af53a2","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def downgrade():"},{"line_number":36,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_39d7644c","line":36,"updated":"2015-08-06 14:19:44.000000000","message":"We should downgrade here too right?\n\nAlso we need to add migration tests in this patch. Take a look at [1] for examples\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/tests/db/sqlalchemy/test_migrations.py#L279-L385","commit_id":"2597ca86578145e18281b4f4e3ac61bd76d5af9e"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"db132a3287cbde146c8b476efd960c7deb709aee","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def downgrade():"},{"line_number":36,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_c6e69c43","line":36,"in_reply_to":"1a4dcd0f_39d7644c","updated":"2015-08-06 15:20:37.000000000","message":"Hi Lucas, thanks for the review.\n\nThe previous patch had a downgrade, but some people argue that truncating the driver name on downgrade wouldn\u0027t be a good idea. What do you think?\n\nAbout the tests, I\u0027ll take a look and send a new patch addressing that. Thanks for noting (I didn\u0027t know migrations needed tests).","commit_id":"2597ca86578145e18281b4f4e3ac61bd76d5af9e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"51982295f6f9916d40f42a742f66896e5791775e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def downgrade():"},{"line_number":36,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_61ef25b1","line":36,"in_reply_to":"1a4dcd0f_c6e69c43","updated":"2015-08-17 13:21:48.000000000","message":"Right, yeah it may break people if we truncate indeed. Thanks for the update","commit_id":"2597ca86578145e18281b4f4e3ac61bd76d5af9e"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b8bca79aacd85712476f373cb00cbe98bc8978fe","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    last_error \u003d Column(Text, nullable\u003dTrue)"},{"line_number":159,"context_line":"    instance_info \u003d Column(JSONEncodedDict)"},{"line_number":160,"context_line":"    properties \u003d Column(JSONEncodedDict)"},{"line_number":161,"context_line":"    driver \u003d Column(String(25))"},{"line_number":162,"context_line":"    driver_info \u003d Column(JSONEncodedDict)"},{"line_number":163,"context_line":"    driver_internal_info \u003d Column(JSONEncodedDict)"},{"line_number":164,"context_line":"    clean_step \u003d Column(JSONEncodedDict)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_66e4133b","line":161,"updated":"2015-08-17 15:23:35.000000000","message":"I added a topic for the meeting today so we can see if people think that 25 characters are enough for the driver\u0027s name","commit_id":"48481c28dfabc9590a6e7a0b137795ebe494a79d"}]}