)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1a9fd899f63f63e2f05c4d998ba192e3e8243644","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Old value \u0027updated_at\u0027 field returned after update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After PATCH Operation, object doesn\u0027t reflect the new \u0027updated_at\u0027"},{"line_number":10,"context_line":"field. This commit is to return the updated field after the"},{"line_number":11,"context_line":"PATCH Operation"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_ad40a757","line":9,"updated":"2015-08-18 09:03:07.000000000","message":"How about:\n\n  chassis.save() and port.save() doesn\u0027t update object after save\n\n  chassis.save() and port.save() doesn\u0027t updat object from db after save \n  because of which update_at field for the object is not up-to-date after a \n  save(). This commit fixes this issue","commit_id":"f51d8437b4ef59230860d639128cd3bb7973cea3"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"eb6b406b1651cee1c683f57182dc83d6106e83c8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Old value \u0027updated_at\u0027 field returned after update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After PATCH Operation, object doesn\u0027t reflect the new \u0027updated_at\u0027"},{"line_number":10,"context_line":"field. This commit is to return the updated field after the"},{"line_number":11,"context_line":"PATCH Operation"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_1301b4ae","line":9,"in_reply_to":"fa1b9901_ad40a757","updated":"2015-08-18 09:30:04.000000000","message":"+1","commit_id":"f51d8437b4ef59230860d639128cd3bb7973cea3"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"2cef30a4e1492ad07ec8f86503a8c9951810f2ed","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Old value \u0027updated_at\u0027 field returned after update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After PATCH Operation, object doesn\u0027t reflect the new \u0027updated_at\u0027"},{"line_number":10,"context_line":"field. This commit is to return the updated field after the"},{"line_number":11,"context_line":"PATCH Operation"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug:#1281638"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_78ca4fa3","line":10,"updated":"2015-08-18 09:12:52.000000000","message":"\u0027Doesn\u0027t update object after save\u0027  doesn\u0027t seem to be correct , only part that is not reflected is updated_at field.\n\nHow about --\n\n\u0027updated_at\u0027 field shows old value after PATCH OP\n\nsave() method doesn\u0027t update the object from db because of which updated_at field shows old value. This commit fixes the issue for Chassis and Port objects.","commit_id":"f51d8437b4ef59230860d639128cd3bb7973cea3"}],"ironic/tests/objects/test_chassis.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"514b6ad48f729dedcd88854d6ebab1a8366de46a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            with mock.patch.object(self.dbapi, \u0027update_chassis\u0027,"},{"line_number":65,"context_line":"                                   autospec\u003dTrue) as mock_update_chassis:"},{"line_number":66,"context_line":"                mock_update_chassis.return_value \u003d ("},{"line_number":67,"context_line":"                    utils.get_test_chassis(extra\u003dextra))"},{"line_number":68,"context_line":"                c \u003d objects.Chassis.get_by_uuid(self.context, uuid)"},{"line_number":69,"context_line":"                c.extra \u003d extra"},{"line_number":70,"context_line":"                c.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_8ac5055d","line":67,"updated":"2015-08-12 11:12:40.000000000","message":"This test should prove that \u0027updated_at\u0027 value comes back from db api to object.\n\n mock_update_chassis.return_value \u003d utils.get_test_chassis(extra\u003dextra, updated_at\u003dnew_updated)\n\nand after save()\n\n self.assertEqual(new_updated, c.updated_at)","commit_id":"2ca9c4671c813b0c946c9ee902d540c0feb230d5"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"d4a4a3e4dfff852e1bbc5ff272d8027846cc4dcb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            with mock.patch.object(self.dbapi, \u0027update_chassis\u0027,"},{"line_number":65,"context_line":"                                   autospec\u003dTrue) as mock_update_chassis:"},{"line_number":66,"context_line":"                mock_update_chassis.return_value \u003d ("},{"line_number":67,"context_line":"                    utils.get_test_chassis(extra\u003dextra))"},{"line_number":68,"context_line":"                c \u003d objects.Chassis.get_by_uuid(self.context, uuid)"},{"line_number":69,"context_line":"                c.extra \u003d extra"},{"line_number":70,"context_line":"                c.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_4d6e0e01","line":67,"in_reply_to":"1a4dcd0f_8ac5055d","updated":"2015-08-13 08:22:57.000000000","message":"Done","commit_id":"2ca9c4671c813b0c946c9ee902d540c0feb230d5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"4848f1ade69b52e1f57ac5a1b98d1a898b6739da","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def test_save(self):"},{"line_number":60,"context_line":"        uuid \u003d self.fake_chassis[\u0027uuid\u0027]"},{"line_number":61,"context_line":"        extra \u003d {\"test\": 123}"},{"line_number":62,"context_line":"        test_time \u003d datetime.datetime(2000, 1, 1, 0, 0)"},{"line_number":63,"context_line":"        with mock.patch.object(self.dbapi, \u0027get_chassis_by_uuid\u0027,"},{"line_number":64,"context_line":"                               autospec\u003dTrue) as mock_get_chassis:"},{"line_number":65,"context_line":"            mock_get_chassis.return_value \u003d self.fake_chassis"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_cef38e72","line":62,"updated":"2015-08-18 10:58:11.000000000","message":"nit - might be better to add utc timezone here (like datetime.datetime(2000, 1, 1, 0, 0, tzinfo\u003dpytz.utc)) and not remove it on L78 as time is returned with timezone information now","commit_id":"1f4680ab23f531d052935d1ee1b73972406e2653"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"7a6fe76c6ebb731f90d25d980a3a04544f22d11d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def test_save(self):"},{"line_number":60,"context_line":"        uuid \u003d self.fake_chassis[\u0027uuid\u0027]"},{"line_number":61,"context_line":"        extra \u003d {\"test\": 123}"},{"line_number":62,"context_line":"        test_time \u003d datetime.datetime(2000, 1, 1, 0, 0)"},{"line_number":63,"context_line":"        with mock.patch.object(self.dbapi, \u0027get_chassis_by_uuid\u0027,"},{"line_number":64,"context_line":"                               autospec\u003dTrue) as mock_get_chassis:"},{"line_number":65,"context_line":"            mock_get_chassis.return_value \u003d self.fake_chassis"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_a112ebb2","line":62,"in_reply_to":"fa1b9901_cef38e72","updated":"2015-08-18 11:24:12.000000000","message":"yes, it can be done :) but all other tests in ironic uses in the same way, so updated accordingly.\neg: https://github.com/openstack/ironic/blob/master/ironic/tests/api/v1/test_nodes.py#L276\n\nBut in either case ( with or without the timezone ) solves the purpose of the test, that the latest time is reflected.","commit_id":"1f4680ab23f531d052935d1ee1b73972406e2653"}],"ironic/tests/objects/test_port.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"514b6ad48f729dedcd88854d6ebab1a8366de46a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            with mock.patch.object(self.dbapi, \u0027update_port\u0027,"},{"line_number":75,"context_line":"                                   autospec\u003dTrue) as mock_update_port:"},{"line_number":76,"context_line":"                mock_update_port.return_value \u003d ("},{"line_number":77,"context_line":"                    utils.get_test_port(address\u003daddress))"},{"line_number":78,"context_line":"                p \u003d objects.Port.get_by_uuid(self.context, uuid)"},{"line_number":79,"context_line":"                p.address \u003d address"},{"line_number":80,"context_line":"                p.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_aa000103","line":77,"updated":"2015-08-12 11:12:40.000000000","message":"Ditto as in chassis.","commit_id":"2ca9c4671c813b0c946c9ee902d540c0feb230d5"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"d4a4a3e4dfff852e1bbc5ff272d8027846cc4dcb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            with mock.patch.object(self.dbapi, \u0027update_port\u0027,"},{"line_number":75,"context_line":"                                   autospec\u003dTrue) as mock_update_port:"},{"line_number":76,"context_line":"                mock_update_port.return_value \u003d ("},{"line_number":77,"context_line":"                    utils.get_test_port(address\u003daddress))"},{"line_number":78,"context_line":"                p \u003d objects.Port.get_by_uuid(self.context, uuid)"},{"line_number":79,"context_line":"                p.address \u003d address"},{"line_number":80,"context_line":"                p.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_d6d866f1","line":77,"in_reply_to":"1a4dcd0f_aa000103","updated":"2015-08-13 08:22:57.000000000","message":"Done","commit_id":"2ca9c4671c813b0c946c9ee902d540c0feb230d5"}]}
