)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"abc243e72eb205ac25666e956c4c94235a39665b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the deploy drivers with network flipping logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch consumes the plubming work for network provider"},{"line_number":10,"context_line":"and thus provide support for tenant network isolation for baremetal."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f0a508973ff2f674c16f91d5dc440f9e8e667bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_cee5bcdc","line":9,"updated":"2015-08-16 01:38:44.000000000","message":"s/work/works/\ns/plubming/plumbing/","commit_id":"bf82430b6362bbd94032d376303c2165114e164f"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"abc243e72eb205ac25666e956c4c94235a39665b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update the deploy drivers with network flipping logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch consumes the plubming work for network provider"},{"line_number":10,"context_line":"and thus provide support for tenant network isolation for baremetal."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f0a508973ff2f674c16f91d5dc440f9e8e667bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_4eda0c19","line":10,"updated":"2015-08-16 01:38:44.000000000","message":"s/provide/provides/","commit_id":"bf82430b6362bbd94032d376303c2165114e164f"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"52b43c969595c83e62dc1a0b2b2b30be0794dc7c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the deploy drivers with network flipping logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch consumes the plubming work for network provider"},{"line_number":10,"context_line":"and thus provide support for tenant network isolation for baremetal."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f0a508973ff2f674c16f91d5dc440f9e8e667bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"fa69d971_a9dbbd1a","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":32},"updated":"2015-12-30 15:28:56.000000000","message":"plumbing","commit_id":"fdf39113423f0788d4280b93ed6899d32db9135e"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"83f1698dcafaf49d76de10961a99463aec8feab8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the deploy drivers with network flipping logic"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch consumes the plubming work for network provider"},{"line_number":10,"context_line":"and thus provide support for tenant network isolation for baremetal."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f0a508973ff2f674c16f91d5dc440f9e8e667bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"fa69d971_b42d1448","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":32},"in_reply_to":"fa69d971_a9dbbd1a","updated":"2016-01-04 10:44:02.000000000","message":"Done","commit_id":"fdf39113423f0788d4280b93ed6899d32db9135e"}],"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                e.code \u003d http_client.BAD_REQUEST  # BadRequest"},{"line_number":78,"context_line":"                raise"},{"line_number":79,"context_line":"        elif value \u003d\u003d wtypes.Unset:"},{"line_number":80,"context_line":"            # NOTE(jroll) wtypes.Unset is falsy, block above doesn\u0027t cover it"},{"line_number":81,"context_line":"            self._node_uuid \u003d wtypes.Unset"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    uuid \u003d types.uuid"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_b5217ba0","line":80,"updated":"2016-07-12 22:04:25.000000000","message":"I\u0027m not quite sure what this comment has to do with this patch, or for that matter, what this comment means. Anyway...","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    \"\"\"Indicates whether pxe is enabled or disabled on the node.\"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    local_link_connection \u003d types.locallinkconnectiontype"},{"line_number":103,"context_line":"    \"\"\"The port binding profile for each portgroup\"\"\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":106,"context_line":"    \"\"\"A list containing a self link and associated port links\"\"\""}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_95d27f5a","line":103,"updated":"2016-07-12 22:04:25.000000000","message":"for each portgroup?","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b140f64d8622e38ad6cfa7382ceece8667545472","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    \"\"\"Indicates whether pxe is enabled or disabled on the node.\"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    local_link_connection \u003d types.locallinkconnectiontype"},{"line_number":103,"context_line":"    \"\"\"The port binding profile for each portgroup\"\"\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":106,"context_line":"    \"\"\"A list containing a self link and associated port links\"\"\""}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_2198ad77","line":103,"range":{"start_line":103,"start_character":41,"end_line":103,"end_character":50},"updated":"2016-07-12 23:21:44.000000000","message":"s/portgroup/port/","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    \"\"\"Indicates whether pxe is enabled or disabled on the node.\"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    local_link_connection \u003d types.locallinkconnectiontype"},{"line_number":103,"context_line":"    \"\"\"The port binding profile for each portgroup\"\"\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":106,"context_line":"    \"\"\"A list containing a self link and associated port links\"\"\""}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_20b894c7","line":103,"range":{"start_line":103,"start_character":41,"end_line":103,"end_character":50},"in_reply_to":"1aa78d24_2198ad77","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            # explicitly using \u0027node\u0027.  Try and determine which one."},{"line_number":319,"context_line":"            # Make sure only one interface, node or node_uuid is used"},{"line_number":320,"context_line":"            if (not api_utils.allow_node_logical_names() and"},{"line_number":321,"context_line":"                    not uuidutils.is_uuid_like(node)):"},{"line_number":322,"context_line":"                raise exception.NotAcceptable()"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return self._get_ports_collection(node_uuid or node, address, marker,"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_15fb2f7a","line":321,"updated":"2016-07-12 22:04:25.000000000","message":"nit: you didn\u0027t need to change this line","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            # explicitly using \u0027node\u0027.  Try and determine which one."},{"line_number":319,"context_line":"            # Make sure only one interface, node or node_uuid is used"},{"line_number":320,"context_line":"            if (not api_utils.allow_node_logical_names() and"},{"line_number":321,"context_line":"                    not uuidutils.is_uuid_like(node)):"},{"line_number":322,"context_line":"                raise exception.NotAcceptable()"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        return self._get_ports_collection(node_uuid or node, address, marker,"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_a0d3e402","line":321,"in_reply_to":"1aa78d24_15fb2f7a","updated":"2016-07-13 10:41:33.000000000","message":"But I really hate when my editor highlights such places :D","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                   types.macaddress, types.uuid, int, wtypes.text,"},{"line_number":330,"context_line":"                   wtypes.text)"},{"line_number":331,"context_line":"    def detail(self, node\u003dNone, node_uuid\u003dNone, address\u003dNone, marker\u003dNone,"},{"line_number":332,"context_line":"               limit\u003dNone, sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027,):"},{"line_number":333,"context_line":"        \"\"\"Retrieve a list of ports with detail."},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_d5336760","line":332,"updated":"2016-07-12 22:04:25.000000000","message":"s/,)/)/","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                   types.macaddress, types.uuid, int, wtypes.text,"},{"line_number":330,"context_line":"                   wtypes.text)"},{"line_number":331,"context_line":"    def detail(self, node\u003dNone, node_uuid\u003dNone, address\u003dNone, marker\u003dNone,"},{"line_number":332,"context_line":"               limit\u003dNone, sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027,):"},{"line_number":333,"context_line":"        \"\"\"Retrieve a list of ports with detail."},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_202d34fe","line":332,"in_reply_to":"1aa78d24_d5336760","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            # explicitly using \u0027node\u0027.  Try and determine which one."},{"line_number":353,"context_line":"            # Make sure only one interface, node or node_uuid is used"},{"line_number":354,"context_line":"            if (not api_utils.allow_node_logical_names() and"},{"line_number":355,"context_line":"                    not uuidutils.is_uuid_like(node)):"},{"line_number":356,"context_line":"                raise exception.NotAcceptable()"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        # NOTE(lucasagomes): /detail should only work against collections"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_3543cbb0","line":355,"updated":"2016-07-12 22:04:25.000000000","message":"did you need to change this?","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            # explicitly using \u0027node\u0027.  Try and determine which one."},{"line_number":353,"context_line":"            # Make sure only one interface, node or node_uuid is used"},{"line_number":354,"context_line":"            if (not api_utils.allow_node_logical_names() and"},{"line_number":355,"context_line":"                    not uuidutils.is_uuid_like(node)):"},{"line_number":356,"context_line":"                raise exception.NotAcceptable()"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        # NOTE(lucasagomes): /detail should only work against collections"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_6033bc62","line":355,"in_reply_to":"1aa78d24_3543cbb0","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        :param port_uuid: UUID of a port."},{"line_number":373,"context_line":"        :param fields: Optional, a list with a specified set of fields"},{"line_number":374,"context_line":"            of the resource to be returned."},{"line_number":375,"context_line":"        :raises: NotAcceptable"},{"line_number":376,"context_line":"        \"\"\""},{"line_number":377,"context_line":"        if self.from_nodes:"},{"line_number":378,"context_line":"            raise exception.OperationNotPermitted()"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_f56ae318","line":375,"updated":"2016-07-12 22:04:25.000000000","message":"these should have been added in a separate patch but anyway, they are in now.","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        :param port_uuid: UUID of a port."},{"line_number":414,"context_line":"        :param patch: a json PATCH document to apply to this port."},{"line_number":415,"context_line":"        \"\"\""},{"line_number":416,"context_line":"        if self.from_nodes:"},{"line_number":417,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":418,"context_line":"        if not api_utils.allow_multitenancy_fields():"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_1505ef44","line":415,"updated":"2016-07-12 22:04:25.000000000","message":"now here, you could have added a \":raises: NotAcceptable\" :)","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        :param port_uuid: UUID of a port."},{"line_number":414,"context_line":"        :param patch: a json PATCH document to apply to this port."},{"line_number":415,"context_line":"        \"\"\""},{"line_number":416,"context_line":"        if self.from_nodes:"},{"line_number":417,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":418,"context_line":"        if not api_utils.allow_multitenancy_fields():"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_a0dda4e1","line":415,"in_reply_to":"1aa78d24_1505ef44","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                field_path \u003d \u0027/%s\u0027 % field"},{"line_number":421,"context_line":"                if (api_utils.get_patch_values(patch, field_path) or"},{"line_number":422,"context_line":"                        api_utils.is_path_removed(patch, field_path)):"},{"line_number":423,"context_line":"                    raise exception.NotAcceptable()"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(pecan.request.context, port_uuid)"},{"line_number":426,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_35290b9c","line":423,"updated":"2016-07-12 22:04:25.000000000","message":"Are we OK allowing changes to pxe_enabled and local_link_information any time, regardless of what the associated node\u0027s provision state is?","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                field_path \u003d \u0027/%s\u0027 % field"},{"line_number":421,"context_line":"                if (api_utils.get_patch_values(patch, field_path) or"},{"line_number":422,"context_line":"                        api_utils.is_path_removed(patch, field_path)):"},{"line_number":423,"context_line":"                    raise exception.NotAcceptable()"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(pecan.request.context, port_uuid)"},{"line_number":426,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_4b586131","line":423,"in_reply_to":"1aa78d24_018771b5","updated":"2016-07-13 10:41:33.000000000","message":"After talking with Vasyl, I think we can allow it - in states like deploying/cleaning we won\u0027t be able to update anyway, in case of active, if a node will be manually moved to another switchport and local_link_connection will be updated, everything will remain running and completely OK. So to allow this, I think we can leave this possibility.","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1fdab1868f4571e1e992b18dca303fdd7a8cdadc","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                field_path \u003d \u0027/%s\u0027 % field"},{"line_number":421,"context_line":"                if (api_utils.get_patch_values(patch, field_path) or"},{"line_number":422,"context_line":"                        api_utils.is_path_removed(patch, field_path)):"},{"line_number":423,"context_line":"                    raise exception.NotAcceptable()"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(pecan.request.context, port_uuid)"},{"line_number":426,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_018771b5","line":423,"in_reply_to":"1aa78d24_35290b9c","updated":"2016-07-12 23:28:19.000000000","message":"Controls around that are restricted to ironic/conductor/manager.py, update_port method.","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"}],"ironic/api/controllers/v1/types.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        :returns: A dictionary"},{"line_number":286,"context_line":"        :raises: Invalid if some of the keys in the dictionary being validated"},{"line_number":287,"context_line":"            are unknown or some required ones are missing, InvalidSwitchID if"},{"line_number":288,"context_line":"            the specified siwtch_id is invalid"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        \"\"\""},{"line_number":291,"context_line":"        wtypes.DictType(wtypes.text, wtypes.text).validate(value)"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_b0018907","line":288,"updated":"2016-07-12 22:04:25.000000000","message":"nit s/siwtch_id/switch_id/","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        :returns: A dictionary"},{"line_number":286,"context_line":"        :raises: Invalid if some of the keys in the dictionary being validated"},{"line_number":287,"context_line":"            are unknown or some required ones are missing, InvalidSwitchID if"},{"line_number":288,"context_line":"            the specified siwtch_id is invalid"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        \"\"\""},{"line_number":291,"context_line":"        wtypes.DictType(wtypes.text, wtypes.text).validate(value)"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_00bf58d0","line":288,"in_reply_to":"1aa78d24_b0018907","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        # OpenFlow datapath_id and normalize it."},{"line_number":313,"context_line":"        if utils.is_valid_mac(value[\u0027switch_id\u0027]):"},{"line_number":314,"context_line":"            value[\u0027switch_id\u0027] \u003d utils.validate_and_normalize_mac("},{"line_number":315,"context_line":"                value[\u0027switch_id\u0027])"},{"line_number":316,"context_line":"        elif utils.is_valid_datapath_id(value[\u0027switch_id\u0027]):"},{"line_number":317,"context_line":"            value[\u0027switch_id\u0027] \u003d utils.validate_and_normalize_datapath_id("},{"line_number":318,"context_line":"                value[\u0027switch_id\u0027])"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_7019e121","line":315,"updated":"2016-07-12 22:04:25.000000000","message":"I suppose it isn\u0027t a big deal, but utils.validate_and_normalize_mac() calls utils.is_valid_mac()\n\nMaybe just make this call in a try/except?","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        # OpenFlow datapath_id and normalize it."},{"line_number":313,"context_line":"        if utils.is_valid_mac(value[\u0027switch_id\u0027]):"},{"line_number":314,"context_line":"            value[\u0027switch_id\u0027] \u003d utils.validate_and_normalize_mac("},{"line_number":315,"context_line":"                value[\u0027switch_id\u0027])"},{"line_number":316,"context_line":"        elif utils.is_valid_datapath_id(value[\u0027switch_id\u0027]):"},{"line_number":317,"context_line":"            value[\u0027switch_id\u0027] \u003d utils.validate_and_normalize_datapath_id("},{"line_number":318,"context_line":"                value[\u0027switch_id\u0027])"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_806fc890","line":315,"in_reply_to":"1aa78d24_7019e121","updated":"2016-07-13 10:41:33.000000000","message":"It\u0027s OK to raise exceptions here, no need to handle them, furhermore they are all subclasses of Invalid, so docstring may be a bit easier.","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                value[\u0027switch_id\u0027])"},{"line_number":316,"context_line":"        elif utils.is_valid_datapath_id(value[\u0027switch_id\u0027]):"},{"line_number":317,"context_line":"            value[\u0027switch_id\u0027] \u003d utils.validate_and_normalize_datapath_id("},{"line_number":318,"context_line":"                value[\u0027switch_id\u0027])"},{"line_number":319,"context_line":"        else:"},{"line_number":320,"context_line":"            raise exception.InvalidSwitchID(switch_id\u003dvalue[\u0027switch_id\u0027])"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_70c72164","line":318,"updated":"2016-07-12 22:04:25.000000000","message":"ditto","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def is_path_removed(patch, path):"},{"line_number":103,"context_line":"    # We want to know is removal a part of a patch or not."},{"line_number":104,"context_line":"    # Catch subpath too (like /local_link_connection/switch_id)"},{"line_number":105,"context_line":"    for p in patch:"},{"line_number":106,"context_line":"        if p[\u0027path\u0027].startswith(path) and p[\u0027op\u0027] \u003d\u003d \u0027remove\u0027:"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_b006a983","line":103,"updated":"2016-07-12 22:04:25.000000000","message":"How about\n\nreturns whether the patch includes removal of the path (or subpath of)","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def is_path_removed(patch, path):"},{"line_number":103,"context_line":"    # We want to know is removal a part of a patch or not."},{"line_number":104,"context_line":"    # Catch subpath too (like /local_link_connection/switch_id)"},{"line_number":105,"context_line":"    for p in patch:"},{"line_number":106,"context_line":"        if p[\u0027path\u0027].startswith(path) and p[\u0027op\u0027] \u003d\u003d \u0027remove\u0027:"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_dd041719","line":103,"in_reply_to":"1aa78d24_b006a983","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    # We want to know is removal a part of a patch or not."},{"line_number":104,"context_line":"    # Catch subpath too (like /local_link_connection/switch_id)"},{"line_number":105,"context_line":"    for p in patch:"},{"line_number":106,"context_line":"        if p[\u0027path\u0027].startswith(path) and p[\u0027op\u0027] \u003d\u003d \u0027remove\u0027:"},{"line_number":107,"context_line":"            return True"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_f08151c4","line":106,"updated":"2016-07-12 22:04:25.000000000","message":"this works as long as we don\u0027t introduce some other path like \u0027local_link_connection_foo\u0027.","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    # We want to know is removal a part of a patch or not."},{"line_number":104,"context_line":"    # Catch subpath too (like /local_link_connection/switch_id)"},{"line_number":105,"context_line":"    for p in patch:"},{"line_number":106,"context_line":"        if p[\u0027path\u0027].startswith(path) and p[\u0027op\u0027] \u003d\u003d \u0027remove\u0027:"},{"line_number":107,"context_line":"            return True"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_bdff8b00","line":106,"in_reply_to":"1aa78d24_f08151c4","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"}],"ironic/api/controllers/v1/versions.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# v1.16: Add ability to filter nodes by driver."},{"line_number":49,"context_line":"# v1.17: Add \u0027adopt\u0027 verb for ADOPTING active nodes."},{"line_number":50,"context_line":"# v1.18: Add port.internal_info."},{"line_number":51,"context_line":"# v1.19: Add local_link_connection and pxe_enabled fields to a port API object."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"MINOR_0_JUNO \u003d 0"},{"line_number":54,"context_line":"MINOR_1_INITIAL_VERSION \u003d 1"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_b062293c","line":51,"updated":"2016-07-12 22:04:25.000000000","message":"this is all about the API so no need to mention it.\n\nMaybe something similar to the above, \u0027Add port.local_link_connection and port.pxe_enabled.","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# v1.16: Add ability to filter nodes by driver."},{"line_number":49,"context_line":"# v1.17: Add \u0027adopt\u0027 verb for ADOPTING active nodes."},{"line_number":50,"context_line":"# v1.18: Add port.internal_info."},{"line_number":51,"context_line":"# v1.19: Add local_link_connection and pxe_enabled fields to a port API object."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"MINOR_0_JUNO \u003d 0"},{"line_number":54,"context_line":"MINOR_1_INITIAL_VERSION \u003d 1"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_fa1c7978","line":51,"in_reply_to":"1aa78d24_b062293c","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"MINOR_16_DRIVER_FILTER \u003d 16"},{"line_number":70,"context_line":"MINOR_17_ADOPT_VERB \u003d 17"},{"line_number":71,"context_line":"MINOR_18_PORT_INTERNAL_INFO \u003d 18"},{"line_number":72,"context_line":"MINOR_19_MULTITENANCY \u003d 19"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# When adding another version, update MINOR_MAX_VERSION and also update"},{"line_number":75,"context_line":"# doc/source/webapi/v1.rst with a detailed explanation of what the version has"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_70e441ab","line":72,"updated":"2016-07-12 22:04:25.000000000","message":"I\u0027d prefer something that had \u0027PORT\u0027 in it because it is adding two port fields. PORT_NET_FIELDS? (Is it only specific to \u0027multitenancy\u0027?)","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":69,"context_line":"MINOR_16_DRIVER_FILTER \u003d 16"},{"line_number":70,"context_line":"MINOR_17_ADOPT_VERB \u003d 17"},{"line_number":71,"context_line":"MINOR_18_PORT_INTERNAL_INFO \u003d 18"},{"line_number":72,"context_line":"MINOR_19_MULTITENANCY \u003d 19"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# When adding another version, update MINOR_MAX_VERSION and also update"},{"line_number":75,"context_line":"# doc/source/webapi/v1.rst with a detailed explanation of what the version has"}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_1a1a257d","line":72,"in_reply_to":"1aa78d24_70e441ab","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"}],"ironic/common/exception.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"class InvalidSwitchID(Invalid):"},{"line_number":196,"context_line":"    _msg_fmt \u003d _(\"Expected a MAC address or OpenFlow datapath_id but \""},{"line_number":197,"context_line":"                 \"received %(switch_id)s.\")"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_b0f06968","line":196,"updated":"2016-07-12 22:04:25.000000000","message":"maybe s/datapath_id/data path ID/\n\nunless \u0027datapath_id\u0027 is a well known OpenFlow thing.","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"class InvalidSwitchID(Invalid):"},{"line_number":196,"context_line":"    _msg_fmt \u003d _(\"Expected a MAC address or OpenFlow datapath_id but \""},{"line_number":197,"context_line":"                 \"received %(switch_id)s.\")"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_7a86c9b9","line":196,"in_reply_to":"1aa78d24_b0f06968","updated":"2016-07-13 10:41:33.000000000","message":"Seems like it should be datapath ID, thanks, done!","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class InvalidDatapathId(Invalid):"},{"line_number":201,"context_line":"    _msg_fmt \u003d _(\"Expected an OpenFlow datapath_id but received \""},{"line_number":202,"context_line":"                 \"%(datapath_id)s.\")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_f09dd10a","line":201,"updated":"2016-07-12 22:04:25.000000000","message":"ditto","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class InvalidDatapathId(Invalid):"},{"line_number":201,"context_line":"    _msg_fmt \u003d _(\"Expected an OpenFlow datapath_id but received \""},{"line_number":202,"context_line":"                 \"%(datapath_id)s.\")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_ba8cb1d7","line":201,"in_reply_to":"1aa78d24_f09dd10a","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"}],"ironic/common/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"def validate_and_normalize_datapath_id(datapath_id):"},{"line_number":304,"context_line":"    \"\"\"Validate an OpenFlow datapath_id and return normalized form.a"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    Checks whether the supplied OpenFlow datapath_id is formally correct and"},{"line_number":307,"context_line":"    normalize it to all lower case."}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_709281f7","line":304,"updated":"2016-07-12 22:04:25.000000000","message":"s/.a/./","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2da410a06ad9785e00c4493d05c53806a33f33db","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"def validate_and_normalize_datapath_id(datapath_id):"},{"line_number":304,"context_line":"    \"\"\"Validate an OpenFlow datapath_id and return normalized form.a"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    Checks whether the supplied OpenFlow datapath_id is formally correct and"},{"line_number":307,"context_line":"    normalize it to all lower case."}],"source_content_type":"text/x-python","patch_set":125,"id":"1aa78d24_facbd91b","line":304,"in_reply_to":"1aa78d24_709281f7","updated":"2016-07-13 10:41:33.000000000","message":"Done","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"}],"ironic/dhcp/neutron.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"afd11fab504cb67bd424087cf1beea88c3fc8672","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NeutronDHCPApi(base.BaseDHCP):"},{"line_number":38,"context_line":"    \"\"\"API for communicating to neutron 2.x API.\"\"\""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":53,"id":"5a5ae5dd_ec0ce8ee","line":36,"updated":"2016-02-05 13:31:21.000000000","message":"nit: extra line getting introduced?","commit_id":"bd23d1f848c92941fe33eb1b78eb63bc05a68210"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2ae1eae87584ad92d3ea123a30a217d2ff8d343a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NeutronDHCPApi(base.BaseDHCP):"},{"line_number":38,"context_line":"    \"\"\"API for communicating to neutron 2.x API.\"\"\""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":53,"id":"5a5ae5dd_79df5369","line":36,"in_reply_to":"5a5ae5dd_ec0ce8ee","updated":"2016-02-05 17:06:25.000000000","message":"fixed it in previous patch.","commit_id":"bd23d1f848c92941fe33eb1b78eb63bc05a68210"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ac4d4eb8a434fa6686485a6c6e30cd1f8ef19edc","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    manager_utils.node_power_action(task, states.OFF)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":238,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    manager_utils.node_power_action(task, states.ON)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_e1ac638e","line":237,"updated":"2015-08-24 09:49:28.000000000","message":"We should not use an internal method like that","commit_id":"ccb71f7cc230cf25baf2e39494eca2a9f684da62"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"1d501684a3226526e217795b1254e95ef2f525b1","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    manager_utils.node_power_action(task, states.OFF)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":238,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    manager_utils.node_power_action(task, states.ON)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_3f6486e3","line":237,"in_reply_to":"fa1b9901_e1ac638e","updated":"2015-09-03 11:26:40.000000000","message":"Done","commit_id":"ccb71f7cc230cf25baf2e39494eca2a9f684da62"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"dea1ca1365075ee1b1baff47479082a08d51f495","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":238,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    manager_utils.node_power_action(task, states.ON)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def _clean_up_pxe(task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_19eeb5ec","line":240,"updated":"2015-08-24 08:33:01.000000000","message":"Looks like we have a lot of same lines/logic in other change files, so can we create new common method to share common logic?","commit_id":"ccb71f7cc230cf25baf2e39494eca2a9f684da62"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ac4d4eb8a434fa6686485a6c6e30cd1f8ef19edc","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":238,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    manager_utils.node_power_action(task, states.ON)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def _clean_up_pxe(task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_c1ba7fc0","line":240,"in_reply_to":"fa1b9901_19eeb5ec","updated":"2015-08-24 09:49:28.000000000","message":"+1\n\nWe can use the deploy_utils.py module and have the method there.","commit_id":"ccb71f7cc230cf25baf2e39494eca2a9f684da62"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"3065cdb910396cc0fc99fc302240ed226d20e716","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":238,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    manager_utils.node_power_action(task, states.ON)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def _clean_up_pxe(task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_4423dd05","line":240,"in_reply_to":"fa1b9901_c1ba7fc0","updated":"2015-08-24 10:13:43.000000000","message":"I would love to do that.. however, my guess is that it will move to boot interface when drivers get refactored.","commit_id":"ccb71f7cc230cf25baf2e39494eca2a9f684da62"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d9a5c785ff91a14fce88d7d13d050a9e06c32595","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":160,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":161,"context_line":"    if CONF.agent.manage_tftp:"},{"line_number":162,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":163,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":164,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_a63a7497","line":161,"updated":"2015-08-31 14:47:02.000000000","message":"\"manage_tftp\" agent option deprecated, please use \"manage_agent_boot\" instead.","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d9a5c785ff91a14fce88d7d13d050a9e06c32595","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    manager_utils.node_power_action(task, states.OFF)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":185,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    manager_utils.node_power_action(task, states.ON)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_e6daac16","line":184,"updated":"2015-08-31 14:47:02.000000000","message":"_get_network_provider() is an \"internal\" function (and Lucas commented the same on patchset 4).","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"6eb129e74d73ef7cb2bdb1d5e15bed9a1eb17890","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    manager_utils.node_power_action(task, states.OFF)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":185,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    manager_utils.node_power_action(task, states.ON)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_bf9e56b6","line":184,"in_reply_to":"da20952f_e6daac16","updated":"2015-09-03 16:41:05.000000000","message":"Done","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1362391c0fe007f31bdbf5eb1886e3b9b7792353","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \"\"\""},{"line_number":233,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":234,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":235,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":236,"context_line":"        return states.DELETED"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def prepare(self, task):"}],"source_content_type":"text/x-python","patch_set":25,"id":"fa80f949_0f8de17a","line":235,"updated":"2015-11-05 11:21:03.000000000","message":"AFAIK we should do unconfigure_tenant_networks here.","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"8ece837b135dd155fd41e6332f43c428f95c886c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \"\"\""},{"line_number":233,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":234,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":235,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":236,"context_line":"        return states.DELETED"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def prepare(self, task):"}],"source_content_type":"text/x-python","patch_set":25,"id":"fa80f949_187f4216","line":235,"in_reply_to":"fa80f949_0f8de17a","updated":"2015-11-06 08:09:26.000000000","message":"Sorry for short comment, more detailed question. tear_down() method can be called when node state is active or error. It\u0027s OK call remove_provisioning_network() for error state. Probably OK call remove_provisioning_network() for active state (it does nothing in this case except unneeded Neutron request). Node in active state is connected to tenant\u0027s network. Do we need unconfigure_tenant_networks() here?","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5f253edd9e90d7048603b84e4392aff91326f4c9","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \"\"\""},{"line_number":233,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":234,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":235,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":236,"context_line":"        return states.DELETED"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def prepare(self, task):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a7e1126_8cf4155b","line":235,"in_reply_to":"fa80f949_187f4216","updated":"2015-12-23 07:05:52.000000000","message":"You are right there is no need to call remove_provisioning_network() when node is in active state, since in active state node doesn\u0027t have port in provision network. It is removed at the reboot_and_finish_deploy().\nAll manipulation with tenant port are done on Nova side, so we don\u0027t have to call unconfigure_tenant_networks() here.","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"8ece837b135dd155fd41e6332f43c428f95c886c","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"            provider \u003d network.get_network_provider(task)"},{"line_number":253,"context_line":"            provider.add_provisioning_network(task)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"            node.instance_info \u003d build_instance_info_for_deploy(task)"},{"line_number":256,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":25,"id":"fa80f949_bd1948d9","line":253,"updated":"2015-11-06 08:09:26.000000000","message":"I\u0027m not sure that prepare() is a good place for add_provisioning_network(). \"If implemented, this method must be idempotent. It may be called multiple times for the same node on the same conductor\". Yes, it\u0027s impossible to create more that one port with the same MAC in Neutron, but maybe better move this to deploy()?","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5f253edd9e90d7048603b84e4392aff91326f4c9","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"            provider \u003d network.get_network_provider(task)"},{"line_number":253,"context_line":"            provider.add_provisioning_network(task)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"            node.instance_info \u003d build_instance_info_for_deploy(task)"},{"line_number":256,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a7e1126_4c006d66","line":253,"in_reply_to":"fa80f949_bd1948d9","updated":"2015-12-23 07:05:52.000000000","message":"We should update dhcp options after add_provisioning_network(). It is done in prepare_ramdisk(), so we can\u0027t call add_provisioning_network(task) at the deploy()","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f104fc40de7ee26e88b57542ec40292e98601d01","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        # is nothing to be done in prepare() when it\u0027s called during"},{"line_number":268,"context_line":"        # take over."},{"line_number":269,"context_line":"        node \u003d task.node"},{"line_number":270,"context_line":"        if node.provision_state !\u003d states.ACTIVE:"},{"line_number":271,"context_line":"            # Adding the node to provisioning network so that the dhcp options"},{"line_number":272,"context_line":"            # get added for the provisioning port."},{"line_number":273,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":42,"id":"5a5ae5dd_9ea06df6","line":270,"range":{"start_line":270,"start_character":7,"end_line":270,"end_character":49},"updated":"2016-02-03 15:36:11.000000000","message":"What about nodes in the process of deploying? cleaning? inspecting?  Mainly since this is called from _do_takeover in the conductor manager.","commit_id":"d503f6290da29db415c104df0b983769bd1e6b06"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"fbb9bb1d842fa2106c9588b40b2d8c8e2e4fc4ac","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        # is nothing to be done in prepare() when it\u0027s called during"},{"line_number":268,"context_line":"        # take over."},{"line_number":269,"context_line":"        node \u003d task.node"},{"line_number":270,"context_line":"        if node.provision_state !\u003d states.ACTIVE:"},{"line_number":271,"context_line":"            # Adding the node to provisioning network so that the dhcp options"},{"line_number":272,"context_line":"            # get added for the provisioning port."},{"line_number":273,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":42,"id":"5a5ae5dd_5f8709d7","line":270,"range":{"start_line":270,"start_character":7,"end_line":270,"end_character":49},"in_reply_to":"5a5ae5dd_9ea06df6","updated":"2016-02-04 18:16:55.000000000","message":"Added separate method so that the flow doesn\u0027t get effected.","commit_id":"d503f6290da29db415c104df0b983769bd1e6b06"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f63f4bcf2b2447ea0fea7b38a7b7924032ba2ec2","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        # is nothing to be done in prepare() when it\u0027s called during"},{"line_number":280,"context_line":"        # take over."},{"line_number":281,"context_line":"        node \u003d task.node"},{"line_number":282,"context_line":"        if node.provision_state !\u003d states.ACTIVE:"},{"line_number":283,"context_line":"            # Adding the node to provisioning network so that the dhcp options"},{"line_number":284,"context_line":"            # get added for the provisioning port."},{"line_number":285,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":288,"context_line":"            provider.add_provisioning_network(task)"}],"source_content_type":"text/x-python","patch_set":45,"id":"5a5ae5dd_dfe1b99b","line":285,"range":{"start_line":282,"start_character":0,"end_line":285,"end_character":67},"updated":"2016-02-04 18:38:17.000000000","message":"I\u0027m really not a fan of changing the use of prepare around from begin a generalized \"preparation\" when the deployment environment needs to be ensured to be ready, to a specific step being called for takeover cases when take_over is called.\n\nFrankly, I think all that is needed is a LIST of states where we absolutely should not cut power to the node because something else is occurring.  That makes more sense to me then duplicating code.","commit_id":"b78a87d5ec8d6b94f861f491275c24caef56d9a8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"afd11fab504cb67bd424087cf1beea88c3fc8672","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        # take over."},{"line_number":269,"context_line":"        node \u003d task.node"},{"line_number":270,"context_line":"        if node.provision_state !\u003d states.ACTIVE:"},{"line_number":271,"context_line":"            if node.provision_state not in [states.DEPLOYING,"},{"line_number":272,"context_line":"                                            states.CLEANING,"},{"line_number":273,"context_line":"                                            states.INSPECTING]:"},{"line_number":274,"context_line":"                # Adding the node to provisioning network so that the"}],"source_content_type":"text/x-python","patch_set":53,"id":"5a5ae5dd_afcd82b8","line":271,"range":{"start_line":271,"start_character":51,"end_line":271,"end_character":60},"updated":"2016-02-05 13:31:21.000000000","message":"I thought of an edge case to this, it should be in deploying state initially to get moved, but only that one time.  Then the node sits in \"wait call-back\" until it calls home.  :(\n\ntl;dr it may be wrong to put deploying in this list.","commit_id":"bd23d1f848c92941fe33eb1b78eb63bc05a68210"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2ae1eae87584ad92d3ea123a30a217d2ff8d343a","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        # take over."},{"line_number":269,"context_line":"        node \u003d task.node"},{"line_number":270,"context_line":"        if node.provision_state !\u003d states.ACTIVE:"},{"line_number":271,"context_line":"            if node.provision_state not in [states.DEPLOYING,"},{"line_number":272,"context_line":"                                            states.CLEANING,"},{"line_number":273,"context_line":"                                            states.INSPECTING]:"},{"line_number":274,"context_line":"                # Adding the node to provisioning network so that the"}],"source_content_type":"text/x-python","patch_set":53,"id":"5a5ae5dd_622a3892","line":271,"range":{"start_line":271,"start_character":51,"end_line":271,"end_character":60},"in_reply_to":"5a5ae5dd_5f1597e2","updated":"2016-02-05 17:06:25.000000000","message":"Vlad, you are right. With current code node will be never plugged to provision network. We should call add_provision_network only when node is in DEPLOYING state.","commit_id":"bd23d1f848c92941fe33eb1b78eb63bc05a68210"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"42e77a10fbdd0f6ee94b8a212f995b22052dddfc","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        # take over."},{"line_number":269,"context_line":"        node \u003d task.node"},{"line_number":270,"context_line":"        if node.provision_state !\u003d states.ACTIVE:"},{"line_number":271,"context_line":"            if node.provision_state not in [states.DEPLOYING,"},{"line_number":272,"context_line":"                                            states.CLEANING,"},{"line_number":273,"context_line":"                                            states.INSPECTING]:"},{"line_number":274,"context_line":"                # Adding the node to provisioning network so that the"}],"source_content_type":"text/x-python","patch_set":53,"id":"5a5ae5dd_5f1597e2","line":271,"range":{"start_line":271,"start_character":51,"end_line":271,"end_character":60},"in_reply_to":"5a5ae5dd_afcd82b8","updated":"2016-02-05 16:28:19.000000000","message":"Yep, deploying seems to be wrong, as this is the state the node is in during usual deployment. It means that during usual provision node won\u0027t be switched to provisioning network. Maybe it would be enough to have just:\n\n if node.provision_state \u003d\u003d states.DEPLOYING\n\n?","commit_id":"bd23d1f848c92941fe33eb1b78eb63bc05a68210"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"afd11fab504cb67bd424087cf1beea88c3fc8672","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        # take over."},{"line_number":269,"context_line":"        node \u003d task.node"},{"line_number":270,"context_line":"        if node.provision_state !\u003d states.ACTIVE:"},{"line_number":271,"context_line":"            if node.provision_state not in [states.DEPLOYING,"},{"line_number":272,"context_line":"                                            states.CLEANING,"},{"line_number":273,"context_line":"                                            states.INSPECTING]:"},{"line_number":274,"context_line":"                # Adding the node to provisioning network so that the"},{"line_number":275,"context_line":"                # dhcp options get added for the provisioning port."},{"line_number":276,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":53,"id":"5a5ae5dd_2c47604c","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":62},"updated":"2016-02-05 13:31:21.000000000","message":"Thank you!","commit_id":"bd23d1f848c92941fe33eb1b78eb63bc05a68210"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0b9aa9e31400900da072e5beedd73b7d4972ab54","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        :param task: a TaskManager instance."},{"line_number":241,"context_line":"        :returns: status of the deploy. One of ironic.common.states."},{"line_number":242,"context_line":"        \"\"\""},{"line_number":243,"context_line":"        manager_utils.node_power_action(task, states.POWER_ON)"},{"line_number":244,"context_line":"        return states.DEPLOYWAIT"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_0dea5074","line":243,"updated":"2016-02-08 15:29:15.000000000","message":"poweron does not ensure a reboot. i dont think you should change this","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"92520424dd0d0edb2d65375283ab8d096e8b943b","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        :param task: a TaskManager instance."},{"line_number":241,"context_line":"        :returns: status of the deploy. One of ironic.common.states."},{"line_number":242,"context_line":"        \"\"\""},{"line_number":243,"context_line":"        manager_utils.node_power_action(task, states.POWER_ON)"},{"line_number":244,"context_line":"        return states.DEPLOYWAIT"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_a750d05f","line":243,"in_reply_to":"5a5ae5dd_0dea5074","updated":"2016-02-09 06:41:35.000000000","message":"Done","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0b9aa9e31400900da072e5beedd73b7d4972ab54","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        \"\"\""},{"line_number":253,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if task.node.provision_state !\u003d states.ACTIVE:"},{"line_number":256,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":257,"context_line":"            provider.remove_provisioning_network(task)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_ad053c46","line":255,"updated":"2016-02-08 15:29:15.000000000","message":"why check state? its in tear-down...","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"92520424dd0d0edb2d65375283ab8d096e8b943b","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        \"\"\""},{"line_number":253,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if task.node.provision_state !\u003d states.ACTIVE:"},{"line_number":256,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":257,"context_line":"            provider.remove_provisioning_network(task)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_67f8984a","line":255,"in_reply_to":"5a5ae5dd_ad053c46","updated":"2016-02-09 06:41:35.000000000","message":"I guess this is done to ensure that node is having a provisioning network attached before calling remove network on it.","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e4af7de49cb7c08c62e1089505d16e6a2d92359a","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        \"\"\""},{"line_number":253,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if task.node.provision_state !\u003d states.ACTIVE:"},{"line_number":256,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":257,"context_line":"            provider.remove_provisioning_network(task)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_bf71b479","line":255,"in_reply_to":"5a5ae5dd_ad053c46","updated":"2016-02-09 12:04:47.000000000","message":"There is no need to check the state, we need only to remove all Neutron ports for node in provision network if they exist.","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":311,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        return states.DELETED"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_959d3cbe","line":311,"updated":"2016-02-12 00:46:56.000000000","message":"Isn\u0027t it the tenant networks we should be removing here? We shouldn\u0027t have the provisioning network attached at tear_down time.","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a19d9ee457b4e3600b2f87327aa3a408cfabaa06","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":311,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        return states.DELETED"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":67,"id":"dae33548_de0add20","line":311,"in_reply_to":"3a57f1b5_959d3cbe","updated":"2016-02-16 15:16:26.000000000","message":"Done","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"81fd17202df592bff7de6b838c1a7c7a67eac98e","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":311,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        return states.DELETED"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":67,"id":"dae33548_bb8c6280","line":311,"in_reply_to":"3a57f1b5_959d3cbe","updated":"2016-02-16 08:39:18.000000000","message":"deletion of tenant port is taken care of by nova I guess..","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"8f0169837361d7b0f6f83cab9a6e96cecb46672b","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                # Adding the node to provisioning network so that the dhcp"},{"line_number":333,"context_line":"                # options get added for the provisioning port."},{"line_number":334,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":335,"context_line":"                task.driver.network.add_provisioning_network(task)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"            node.instance_info \u003d build_instance_info_for_deploy(task)"},{"line_number":338,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":102,"id":"5a18252c_26ef9f88","line":335,"range":{"start_line":335,"start_character":16,"end_line":335,"end_character":66},"updated":"2016-04-13 08:15:53.000000000","message":"Why no try-catch here for fault-tolerant just like iscsi_deploy does?","commit_id":"cddc83f0687e11b178d6319a6b7b776d36468366"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fc4d6174aedadc09531b7b58d905dbb6b61dccdd","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                # Adding the node to provisioning network so that the dhcp"},{"line_number":333,"context_line":"                # options get added for the provisioning port."},{"line_number":334,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":335,"context_line":"                task.driver.network.add_provisioning_network(task)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"            node.instance_info \u003d build_instance_info_for_deploy(task)"},{"line_number":338,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":102,"id":"5a18252c_12424fae","line":335,"range":{"start_line":335,"start_character":16,"end_line":335,"end_character":66},"in_reply_to":"5a18252c_26ef9f88","updated":"2016-04-14 15:11:26.000000000","message":"Done","commit_id":"cddc83f0687e11b178d6319a6b7b776d36468366"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6a7d33b1daf150bb5be6adb03bc1131e5119ffc0","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        # take over."},{"line_number":316,"context_line":"        node \u003d task.node"},{"line_number":317,"context_line":"        if node.provision_state !\u003d states.ACTIVE:"},{"line_number":318,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":319,"context_line":"                # Adding the node to provisioning network so that the dhcp"},{"line_number":320,"context_line":"                # options get added for the provisioning port."},{"line_number":321,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":107,"id":"dab17558_37aeb398","line":318,"updated":"2016-05-13 12:48:04.000000000","message":"If node state is DEPLOYING line 317 will be always true, so please move this new code outside.","commit_id":"1e104f4dcee89b8d38d2cef41489c5fdde880417"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c624c87e9138112b382038bd902f6f3c57db9394","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":321,"context_line":"                try:"},{"line_number":322,"context_line":"                    task.driver.network.add_provisioning_network(task)"},{"line_number":323,"context_line":"                except neutron_exceptions.MacAddressInUseClient:"},{"line_number":324,"context_line":"                    LOG.warning(_LW(\"Neutron port already exists for node \""},{"line_number":325,"context_line":"                                    \"%(node) in provision network.\"),"},{"line_number":326,"context_line":"                                {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":109,"id":"bab6814e_769fc103","line":323,"updated":"2016-05-18 15:21:13.000000000","message":"The same about exception as commented in iscsi_deploy.py","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"639e3db78e17fa8b87396c239aab53f946c60bc2","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":321,"context_line":"                try:"},{"line_number":322,"context_line":"                    task.driver.network.add_provisioning_network(task)"},{"line_number":323,"context_line":"                except neutron_exceptions.MacAddressInUseClient:"},{"line_number":324,"context_line":"                    LOG.warning(_LW(\"Neutron port already exists for node \""},{"line_number":325,"context_line":"                                    \"%(node) in provision network.\"),"},{"line_number":326,"context_line":"                                {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":109,"id":"bab6814e_9e26b7b8","line":323,"in_reply_to":"bab6814e_769fc103","updated":"2016-05-18 16:56:24.000000000","message":"+1000","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1e8d6980635bc0fe8839030ed8bf907719a156f3","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":321,"context_line":"                try:"},{"line_number":322,"context_line":"                    task.driver.network.add_provisioning_network(task)"},{"line_number":323,"context_line":"                except neutron_exceptions.MacAddressInUseClient:"},{"line_number":324,"context_line":"                    LOG.warning(_LW(\"Neutron port already exists for node \""},{"line_number":325,"context_line":"                                    \"%(node) in provision network.\"),"},{"line_number":326,"context_line":"                                {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":109,"id":"bab6814e_935a374f","line":323,"in_reply_to":"bab6814e_769fc103","updated":"2016-05-24 16:15:39.000000000","message":"Done","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a1d7bb7118d37b255c0a213b52fdb605df7e6474","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    def prepare(self, task):"},{"line_number":307,"context_line":"        \"\"\"Prepare the deployment environment for this node."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        :param task: a TaskManager instance."},{"line_number":310,"context_line":"        \"\"\""},{"line_number":311,"context_line":"        # Nodes deployed by AgentDeploy always boot from disk now. So there"},{"line_number":312,"context_line":"        # is nothing to be done in prepare() when it\u0027s called during"}],"source_content_type":"text/x-python","patch_set":120,"id":"3aaa91ec_1b3faeb4","line":309,"updated":"2016-06-27 11:28:43.000000000","message":":raises: NetworkError","commit_id":"583de0848d57082eef15620b3f5e3567920ceb0c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a1d7bb7118d37b255c0a213b52fdb605df7e6474","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        # take over."},{"line_number":314,"context_line":"        node \u003d task.node"},{"line_number":315,"context_line":"        if node.provision_state !\u003d states.ACTIVE:"},{"line_number":316,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":317,"context_line":"                # Adding the node to provisioning network so that the dhcp"},{"line_number":318,"context_line":"                # options get added for the provisioning port."},{"line_number":319,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":120,"id":"3aaa91ec_c02d35ff","line":316,"updated":"2016-06-27 11:28:43.000000000","message":"Please move this \"if\" outside external, if state is DEPLOYING it\u0027s not active.","commit_id":"583de0848d57082eef15620b3f5e3567920ceb0c"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d9a5c785ff91a14fce88d7d13d050a9e06c32595","unresolved":false,"context_lines":[{"line_number":518,"context_line":"                     \u0027error\u0027: e})"},{"line_number":519,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"            provider \u003d network._get_network_provider(task)"},{"line_number":522,"context_line":"            provider.remove_provisioning_network(task)"},{"line_number":523,"context_line":"            provider.configure_tenant_networks(task)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_e6486cce","line":521,"updated":"2015-08-31 14:47:02.000000000","message":"_get_network_provider() is an \"internal\" function.","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"6eb129e74d73ef7cb2bdb1d5e15bed9a1eb17890","unresolved":false,"context_lines":[{"line_number":518,"context_line":"                     \u0027error\u0027: e})"},{"line_number":519,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"            provider \u003d network._get_network_provider(task)"},{"line_number":522,"context_line":"            provider.remove_provisioning_network(task)"},{"line_number":523,"context_line":"            provider.configure_tenant_networks(task)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_0a08502c","line":521,"in_reply_to":"da20952f_e6486cce","updated":"2015-09-03 16:41:05.000000000","message":"Done","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0b9aa9e31400900da072e5beedd73b7d4972ab54","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                    {\u0027node_uuid\u0027: node.uuid,"},{"line_number":608,"context_line":"                     \u0027timeout\u0027: (wait * (attempts - 1)) / 1000,"},{"line_number":609,"context_line":"                     \u0027error\u0027: e})"},{"line_number":610,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":613,"context_line":"            provider.remove_provisioning_network(task)"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_ede6d4ae","line":610,"updated":"2016-02-08 15:29:15.000000000","message":"move this into except block","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"92520424dd0d0edb2d65375283ab8d096e8b943b","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                    {\u0027node_uuid\u0027: node.uuid,"},{"line_number":608,"context_line":"                     \u0027timeout\u0027: (wait * (attempts - 1)) / 1000,"},{"line_number":609,"context_line":"                     \u0027error\u0027: e})"},{"line_number":610,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":613,"context_line":"            provider.remove_provisioning_network(task)"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_e747a875","line":610,"in_reply_to":"5a5ae5dd_ede6d4ae","updated":"2016-02-09 06:41:35.000000000","message":"Done","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"59684f503fe8196fdc1c19c36cd462ada49bfb18","unresolved":false,"context_lines":[{"line_number":703,"context_line":"                     \u0027error\u0027: e})"},{"line_number":704,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":707,"context_line":"            provider.remove_provisioning_network(task)"},{"line_number":708,"context_line":"            provider.configure_tenant_networks(task)"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":79,"id":"5aef4532_22e096cc","line":706,"updated":"2016-03-10 12:53:30.000000000","message":"There is a problem in case of iscsi deploy. continue_deploy method updates dhcp opts for the neutron port mentioned in vif_port_id, and then here it is deleted and substituted by the one that was in tenant_vif_port_id, which does not contain any dhcp opts. This leads to not being able to boot a node with pxe.","commit_id":"d39b33a1f10db95162d4ecd579ea63eff1f6c898"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"30044ab981b0498f02755e9d31a514a8e9a5b5f5","unresolved":false,"context_lines":[{"line_number":703,"context_line":"                     \u0027error\u0027: e})"},{"line_number":704,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":707,"context_line":"            provider.remove_provisioning_network(task)"},{"line_number":708,"context_line":"            provider.configure_tenant_networks(task)"},{"line_number":709,"context_line":""}],"source_content_type":"text/x-python","patch_set":79,"id":"ba0121b8_52d89b53","line":706,"in_reply_to":"5aef4532_22e096cc","updated":"2016-03-29 16:30:24.000000000","message":"tested with pxe.. didn\u0027t find any issues.","commit_id":"d39b33a1f10db95162d4ecd579ea63eff1f6c898"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"47661a83c94f66cdf2993b6e5a3eb1706984b260","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                        {\u0027node_uuid\u0027: node.uuid,"},{"line_number":763,"context_line":"                         \u0027timeout\u0027: (wait * (attempts - 1)) / 1000,"},{"line_number":764,"context_line":"                         \u0027error\u0027: e})"},{"line_number":765,"context_line":"                    manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":766,"context_line":"            else:"},{"line_number":767,"context_line":"                # Flush the file system prior to hard rebooting the node"},{"line_number":768,"context_line":"                result \u003d self._client.sync(node)"}],"source_content_type":"text/x-python","patch_set":109,"id":"dab17558_9cd8dbf0","line":765,"updated":"2016-05-17 11:50:37.000000000","message":"I think we can replace POWER_OFF calls in both branches and simply replace reboot by power_off on line 779 (outside the if).","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2245335025b14823bab3881814ba45b4f5837a66","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                        {\u0027node_uuid\u0027: node.uuid,"},{"line_number":763,"context_line":"                         \u0027timeout\u0027: (wait * (attempts - 1)) / 1000,"},{"line_number":764,"context_line":"                         \u0027error\u0027: e})"},{"line_number":765,"context_line":"                    manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":766,"context_line":"            else:"},{"line_number":767,"context_line":"                # Flush the file system prior to hard rebooting the node"},{"line_number":768,"context_line":"                result \u003d self._client.sync(node)"}],"source_content_type":"text/x-python","patch_set":109,"id":"bab6814e_c174ecd0","line":765,"in_reply_to":"dab17558_9cd8dbf0","updated":"2016-05-18 14:54:02.000000000","message":"If in-band power off complete successfully we will need extra OOB operation for this case.","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"64ebf104369a13f17af0781880ab50a0f5e50a53","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                        \u0027Failed to flush the file system prior to hard \u0027"},{"line_number":783,"context_line":"                        \u0027rebooting the node %(node)s. Error: %(error)s\u0027),"},{"line_number":784,"context_line":"                        {\u0027node\u0027: node.uuid, \u0027error\u0027: error})"},{"line_number":785,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"            task.driver.network.remove_provisioning_network(task)"},{"line_number":788,"context_line":"            task.driver.network.configure_tenant_networks(task)"}],"source_content_type":"text/x-python","patch_set":123,"id":"1aa78d24_7e80ddf7","line":785,"updated":"2016-07-05 22:52:12.000000000","message":"I\u0027m slightly concerned by issuing the power off immediately since some block devices can actually reply that everything has been written, when it really has not been written to disk, and thus be lost upon power_off if enough time has not been given for buffers to flush.  This is generally not an issue with O_DIRECT/Direct IO, but any can be an issue with buffered IO operations which are the default form of IO operation.  I seem to remember this presented itself in TripleO with VMs last year.\n\nAdditionally, we should likely wait a short period of time to power off the node if we are unable to issue a sync command to IPA.  If direct IO operations are not used, bytes could still be in the in-memory buffers pending write-out to disk.","commit_id":"af898cebb06fd30c7e5eb4a54fa475067cd8d744"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"83a15060cd120b8a26df10f2eb76893bceb3d217","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                        \u0027Failed to flush the file system prior to hard \u0027"},{"line_number":783,"context_line":"                        \u0027rebooting the node %(node)s. Error: %(error)s\u0027),"},{"line_number":784,"context_line":"                        {\u0027node\u0027: node.uuid, \u0027error\u0027: error})"},{"line_number":785,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"            task.driver.network.remove_provisioning_network(task)"},{"line_number":788,"context_line":"            task.driver.network.configure_tenant_networks(task)"}],"source_content_type":"text/x-python","patch_set":123,"id":"1aa78d24_724f2992","line":785,"in_reply_to":"1aa78d24_5e7f6b14","updated":"2016-07-12 21:10:47.000000000","message":"I\u0027m agreeable with that in interest of getting this functionality landed espescially since since sync() landed in the standby extension in IPA in Mitaka, so as long as nobody is trying to use a liberty or older IPA image, the risk of data corruption risk is hopefully kept to a minimum with the  power_off","commit_id":"af898cebb06fd30c7e5eb4a54fa475067cd8d744"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0c3153f11d85a67dbdb4adc38be77271f6f29be4","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                        \u0027Failed to flush the file system prior to hard \u0027"},{"line_number":783,"context_line":"                        \u0027rebooting the node %(node)s. Error: %(error)s\u0027),"},{"line_number":784,"context_line":"                        {\u0027node\u0027: node.uuid, \u0027error\u0027: error})"},{"line_number":785,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"            task.driver.network.remove_provisioning_network(task)"},{"line_number":788,"context_line":"            task.driver.network.configure_tenant_networks(task)"}],"source_content_type":"text/x-python","patch_set":123,"id":"1aa78d24_5e7f6b14","line":785,"in_reply_to":"1aa78d24_7e80ddf7","updated":"2016-07-07 18:10:21.000000000","message":"OK, but it seems it was the case previously with hard reboot, so I\u0027d fix it separately.","commit_id":"af898cebb06fd30c7e5eb4a54fa475067cd8d744"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d9a5c785ff91a14fce88d7d13d050a9e06c32595","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    manager_utils.node_set_boot_device(task, boot_devices.CDROM)"},{"line_number":272,"context_line":"    manager_utils.node_power_action(task, states.OFF)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":275,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    manager_utils.node_power_action(task, states.ON)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_66821cca","line":274,"updated":"2015-08-31 14:47:02.000000000","message":"ditto","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"6eb129e74d73ef7cb2bdb1d5e15bed9a1eb17890","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    manager_utils.node_set_boot_device(task, boot_devices.CDROM)"},{"line_number":272,"context_line":"    manager_utils.node_power_action(task, states.OFF)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":275,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    manager_utils.node_power_action(task, states.ON)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_ad1dbe67","line":274,"in_reply_to":"da20952f_66821cca","updated":"2015-09-03 16:41:05.000000000","message":"Done","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d9a5c785ff91a14fce88d7d13d050a9e06c32595","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        :raises: IloOperationError, if some operation on iLO failed."},{"line_number":486,"context_line":"        \"\"\""},{"line_number":487,"context_line":"        _prepare_node_for_deploy(task)"},{"line_number":488,"context_line":"        provider \u003d network._get_network_provider(task)"},{"line_number":489,"context_line":"        provider.add_provisioning_network(task)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def clean_up(self, task):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_8685f0cf","line":488,"updated":"2015-08-31 14:47:02.000000000","message":"ditto","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"6eb129e74d73ef7cb2bdb1d5e15bed9a1eb17890","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        :raises: IloOperationError, if some operation on iLO failed."},{"line_number":486,"context_line":"        \"\"\""},{"line_number":487,"context_line":"        _prepare_node_for_deploy(task)"},{"line_number":488,"context_line":"        provider \u003d network._get_network_provider(task)"},{"line_number":489,"context_line":"        provider.add_provisioning_network(task)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def clean_up(self, task):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_8d29da8b","line":488,"in_reply_to":"da20952f_8685f0cf","updated":"2015-09-03 16:41:05.000000000","message":"Done","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1362391c0fe007f31bdbf5eb1886e3b9b7792353","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":551,"context_line":"        task.node.save()"},{"line_number":552,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":553,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":554,"context_line":"        return states.DELETED"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":25,"id":"fa80f949_af3855a1","line":553,"updated":"2015-11-05 11:21:03.000000000","message":"AFAIK we should do unconfigure_tenant_networks here.","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5f253edd9e90d7048603b84e4392aff91326f4c9","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":551,"context_line":"        task.node.save()"},{"line_number":552,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":553,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":554,"context_line":"        return states.DELETED"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a7e1126_4c462d7c","line":553,"in_reply_to":"fa80f949_af3855a1","updated":"2015-12-23 07:05:52.000000000","message":"changes to vendor specific drivers are no longer needed after code refactoring","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1362391c0fe007f31bdbf5eb1886e3b9b7792353","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        \"\"\""},{"line_number":641,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":642,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":643,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":644,"context_line":"        _disable_secure_boot_if_supported(task)"},{"line_number":645,"context_line":"        return states.DELETED"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"fa80f949_6f426d12","line":643,"updated":"2015-11-05 11:21:03.000000000","message":"ditto","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5f253edd9e90d7048603b84e4392aff91326f4c9","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        \"\"\""},{"line_number":641,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":642,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":643,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":644,"context_line":"        _disable_secure_boot_if_supported(task)"},{"line_number":645,"context_line":"        return states.DELETED"},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a7e1126_4f5a9ff3","line":643,"in_reply_to":"fa80f949_6f426d12","updated":"2015-12-23 07:05:52.000000000","message":"changes to vendor specific drivers are no longer needed after code refactoring","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"}],"ironic/drivers/modules/irmc/deploy.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d9a5c785ff91a14fce88d7d13d050a9e06c32595","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    manager_utils.node_set_boot_device(task, boot_devices.CDROM)"},{"line_number":237,"context_line":"    manager_utils.node_power_action(task, states.OFF)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":240,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    manager_utils.node_power_action(task, states.ON)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_865c107e","line":239,"updated":"2015-08-31 14:47:02.000000000","message":"ditto","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"6eb129e74d73ef7cb2bdb1d5e15bed9a1eb17890","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    manager_utils.node_set_boot_device(task, boot_devices.CDROM)"},{"line_number":237,"context_line":"    manager_utils.node_power_action(task, states.OFF)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    provider \u003d network._get_network_provider(task)"},{"line_number":240,"context_line":"    provider.add_provisioning_network(task)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    manager_utils.node_power_action(task, states.ON)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_ed3ad6cc","line":239,"in_reply_to":"da20952f_865c107e","updated":"2015-09-03 16:41:05.000000000","message":"Done","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1362391c0fe007f31bdbf5eb1886e3b9b7792353","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        task.node.save()"},{"line_number":636,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":637,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":638,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":639,"context_line":"        return states.DELETED"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"    def prepare(self, task):"}],"source_content_type":"text/x-python","patch_set":25,"id":"fa80f949_0f0081a9","line":638,"updated":"2015-11-05 11:21:03.000000000","message":"AFAIK we should do unconfigure_tenant_networks here.","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5f253edd9e90d7048603b84e4392aff91326f4c9","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        task.node.save()"},{"line_number":636,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":637,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":638,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":639,"context_line":"        return states.DELETED"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"    def prepare(self, task):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a7e1126_4f437f13","line":638,"in_reply_to":"fa80f949_0f0081a9","updated":"2015-12-23 07:05:52.000000000","message":"changes to vendor specific drivers are no longer needed after code refactoring","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1362391c0fe007f31bdbf5eb1886e3b9b7792353","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        \"\"\""},{"line_number":730,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":731,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":732,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":733,"context_line":"        return states.DELETED"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def prepare(self, task):"}],"source_content_type":"text/x-python","patch_set":25,"id":"fa80f949_4f1d290e","line":732,"updated":"2015-11-05 11:21:03.000000000","message":"ditto","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5f253edd9e90d7048603b84e4392aff91326f4c9","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        \"\"\""},{"line_number":730,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":731,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":732,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":733,"context_line":"        return states.DELETED"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def prepare(self, task):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a7e1126_ef4eeb39","line":732,"in_reply_to":"fa80f949_4f1d290e","updated":"2015-12-23 07:05:52.000000000","message":"changes to vendor specific drivers are no longer needed after code refactoring","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"4c56cde8c886a79c415577ca7f5e930a3a2f0924","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from ironic.common import boot_devices"},{"line_number":25,"context_line":"from ironic.common import exception"},{"line_number":26,"context_line":"from ironic.common.glance_service import service_utils as glance_service_utils"},{"line_number":27,"context_line":"from ironic.common import network"},{"line_number":28,"context_line":"from ironic.common.i18n import _"},{"line_number":29,"context_line":"from ironic.common.i18n import _LE"},{"line_number":30,"context_line":"from ironic.common.i18n import _LI"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_f8edcd25","line":27,"updated":"2015-08-19 06:30:10.000000000","message":"this line should be between \"from ironic.common import keystone\" and \"from ironic.common import states\"","commit_id":"bf82430b6362bbd94032d376303c2165114e164f"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"b6fb2657572448a392f95abfe8a1a0c4ea56791e","unresolved":false,"context_lines":[{"line_number":688,"context_line":"        cache_instance_image(task.context, node)"},{"line_number":689,"context_line":"        check_image_size(task)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        manager_utils.node_power_action(task, states.OFF)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        provider \u003d network._get_network_provider(task)"},{"line_number":694,"context_line":"        provider.add_provisioning_network(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_5c84145c","line":691,"updated":"2015-08-19 06:07:46.000000000","message":"No states.OFF","commit_id":"bf82430b6362bbd94032d376303c2165114e164f"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"21e664344f2dc385413f16d1da5a71ebdfda8171","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from ironic.common import boot_devices"},{"line_number":25,"context_line":"from ironic.common import exception"},{"line_number":26,"context_line":"from ironic.common.glance_service import service_utils as glance_service_utils"},{"line_number":27,"context_line":"from ironic.common import network"},{"line_number":28,"context_line":"from ironic.common.i18n import _"},{"line_number":29,"context_line":"from ironic.common.i18n import _LE"},{"line_number":30,"context_line":"from ironic.common.i18n import _LI"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_9f9592e5","line":27,"updated":"2015-09-03 11:44:17.000000000","message":"this line should be in L32 for pep8.","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"6eb129e74d73ef7cb2bdb1d5e15bed9a1eb17890","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from ironic.common import boot_devices"},{"line_number":25,"context_line":"from ironic.common import exception"},{"line_number":26,"context_line":"from ironic.common.glance_service import service_utils as glance_service_utils"},{"line_number":27,"context_line":"from ironic.common import network"},{"line_number":28,"context_line":"from ironic.common.i18n import _"},{"line_number":29,"context_line":"from ironic.common.i18n import _LE"},{"line_number":30,"context_line":"from ironic.common.i18n import _LI"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_ad34dedd","line":27,"in_reply_to":"da20952f_9f9592e5","updated":"2015-09-03 16:41:05.000000000","message":"Done","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d9a5c785ff91a14fce88d7d13d050a9e06c32595","unresolved":false,"context_lines":[{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        manager_utils.node_power_action(task, states.OFF)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        provider \u003d network._get_network_provider(task)"},{"line_number":694,"context_line":"        provider.add_provisioning_network(task)"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"        manager_utils.node_power_action(task, states.ON)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_0649e0b6","line":693,"updated":"2015-08-31 14:47:02.000000000","message":"ditto","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"6eb129e74d73ef7cb2bdb1d5e15bed9a1eb17890","unresolved":false,"context_lines":[{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        manager_utils.node_power_action(task, states.OFF)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        provider \u003d network._get_network_provider(task)"},{"line_number":694,"context_line":"        provider.add_provisioning_network(task)"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"        manager_utils.node_power_action(task, states.ON)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_2d576e03","line":693,"in_reply_to":"da20952f_0649e0b6","updated":"2015-09-03 16:41:05.000000000","message":"Done","commit_id":"62280abceb4cfc42b1ee231c6029c9cf42d9b66e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1362391c0fe007f31bdbf5eb1886e3b9b7792353","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":711,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":712,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":713,"context_line":"        return states.DELETED"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":25,"id":"fa80f949_4f6f6992","line":712,"updated":"2015-11-05 11:21:03.000000000","message":"AFAIK we should do unconfigure_tenant_networks here.","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5f253edd9e90d7048603b84e4392aff91326f4c9","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":711,"context_line":"        provider \u003d network.get_network_provider(task)"},{"line_number":712,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":713,"context_line":"        return states.DELETED"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a7e1126_2ff2b306","line":712,"in_reply_to":"fa80f949_4f6f6992","updated":"2015-12-23 07:05:52.000000000","message":"same reply as in agent.py","commit_id":"8e33e26398603c437c5351921e796302edb8dcfc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f104fc40de7ee26e88b57542ec40292e98601d01","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        else:"},{"line_number":733,"context_line":"            # Adding the node to provisioning network so that the dhcp options"},{"line_number":734,"context_line":"            # get added for the provisioning port."},{"line_number":735,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":738,"context_line":"            provider.add_provisioning_network(task)"}],"source_content_type":"text/x-python","patch_set":42,"id":"5a5ae5dd_5eb995e8","line":735,"range":{"start_line":735,"start_character":11,"end_line":735,"end_character":67},"updated":"2016-02-03 15:36:11.000000000","message":"I have the same concern as agent prepare()","commit_id":"d503f6290da29db415c104df0b983769bd1e6b06"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"fbb9bb1d842fa2106c9588b40b2d8c8e2e4fc4ac","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        else:"},{"line_number":733,"context_line":"            # Adding the node to provisioning network so that the dhcp options"},{"line_number":734,"context_line":"            # get added for the provisioning port."},{"line_number":735,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":738,"context_line":"            provider.add_provisioning_network(task)"}],"source_content_type":"text/x-python","patch_set":42,"id":"5a5ae5dd_7f61a538","line":735,"range":{"start_line":735,"start_character":11,"end_line":735,"end_character":67},"in_reply_to":"5a5ae5dd_5eb995e8","updated":"2016-02-04 18:16:55.000000000","message":"Done","commit_id":"d503f6290da29db415c104df0b983769bd1e6b06"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"afd11fab504cb67bd424087cf1beea88c3fc8672","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":731,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":732,"context_line":"        else:"},{"line_number":733,"context_line":"            if node.provision_state not in [states.DEPLOYING,"},{"line_number":734,"context_line":"                                            states.CLEANING,"},{"line_number":735,"context_line":"                                            states.INSPECTING]:"},{"line_number":736,"context_line":"                # Adding the node to provisioning network so that"},{"line_number":737,"context_line":"                # dhcp options get added for the provisioning port."},{"line_number":738,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":53,"id":"5a5ae5dd_ec3e288b","line":735,"range":{"start_line":733,"start_character":8,"end_line":735,"end_character":63},"updated":"2016-02-05 13:31:21.000000000","message":"Thank you!","commit_id":"bd23d1f848c92941fe33eb1b78eb63bc05a68210"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0b9aa9e31400900da072e5beedd73b7d4972ab54","unresolved":false,"context_lines":[{"line_number":640,"context_line":"    # machine is powered off and on again. So the code below is enforcing"},{"line_number":641,"context_line":"    # it. For Liberty we need to change the DIB ramdisk so that Ironic"},{"line_number":642,"context_line":"    # always controls the power state of the node for all drivers."},{"line_number":643,"context_line":"    if deploy_utils.get_boot_option(node) \u003d\u003d \"local\" and \u0027ssh\u0027 in node.driver:"},{"line_number":644,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    LOG.info(_LI(\u0027Deployment to node %s done\u0027), node.uuid)"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_8ddf20d5","side":"PARENT","line":643,"updated":"2016-02-08 15:29:15.000000000","message":"this change will affect all drivers now, which is not necessarily good ....\n\ncan we get ilo_iscsi to weigh in?","commit_id":"8bafefbec659ceec18680dd3f47f4ddcf23db950"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e4af7de49cb7c08c62e1089505d16e6a2d92359a","unresolved":false,"context_lines":[{"line_number":640,"context_line":"    # machine is powered off and on again. So the code below is enforcing"},{"line_number":641,"context_line":"    # it. For Liberty we need to change the DIB ramdisk so that Ironic"},{"line_number":642,"context_line":"    # always controls the power state of the node for all drivers."},{"line_number":643,"context_line":"    if deploy_utils.get_boot_option(node) \u003d\u003d \"local\" and \u0027ssh\u0027 in node.driver:"},{"line_number":644,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    LOG.info(_LI(\u0027Deployment to node %s done\u0027), node.uuid)"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_92baaf09","side":"PARENT","line":643,"in_reply_to":"5a5ae5dd_8ddf20d5","updated":"2016-02-09 12:04:47.000000000","message":"Before booting the node we need to be sure that interface is already plugged to tenant network. Otherwise there is no guarantee that node will receive correct IP address.","commit_id":"8bafefbec659ceec18680dd3f47f4ddcf23db950"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"92520424dd0d0edb2d65375283ab8d096e8b943b","unresolved":false,"context_lines":[{"line_number":640,"context_line":"    # machine is powered off and on again. So the code below is enforcing"},{"line_number":641,"context_line":"    # it. For Liberty we need to change the DIB ramdisk so that Ironic"},{"line_number":642,"context_line":"    # always controls the power state of the node for all drivers."},{"line_number":643,"context_line":"    if deploy_utils.get_boot_option(node) \u003d\u003d \"local\" and \u0027ssh\u0027 in node.driver:"},{"line_number":644,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    LOG.info(_LI(\u0027Deployment to node %s done\u0027), node.uuid)"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_a20f5e2d","side":"PARENT","line":643,"in_reply_to":"5a5ae5dd_8ddf20d5","updated":"2016-02-09 06:41:35.000000000","message":"we\u0027ll need to do this now irrespective of the driver I guess.","commit_id":"8bafefbec659ceec18680dd3f47f4ddcf23db950"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0b9aa9e31400900da072e5beedd73b7d4972ab54","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        deploy_utils.set_failed_state(task, msg)"},{"line_number":636,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    # TODO(lucasagomes): When deploying a node with the DIB ramdisk"},{"line_number":639,"context_line":"    # Ironic will not power control the node at the end of the deployment,"},{"line_number":640,"context_line":"    # it\u0027s the DIB ramdisk that reboots the node. But, for the SSH driver"},{"line_number":641,"context_line":"    # some changes like setting the boot device only gets applied when the"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_6de424ab","line":638,"updated":"2016-02-08 15:29:15.000000000","message":"should update this note","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"92520424dd0d0edb2d65375283ab8d096e8b943b","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        deploy_utils.set_failed_state(task, msg)"},{"line_number":636,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    # TODO(lucasagomes): When deploying a node with the DIB ramdisk"},{"line_number":639,"context_line":"    # Ironic will not power control the node at the end of the deployment,"},{"line_number":640,"context_line":"    # it\u0027s the DIB ramdisk that reboots the node. But, for the SSH driver"},{"line_number":641,"context_line":"    # some changes like setting the boot device only gets applied when the"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_271ce076","line":638,"in_reply_to":"5a5ae5dd_6de424ab","updated":"2016-02-09 06:41:35.000000000","message":"Done","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0b9aa9e31400900da072e5beedd73b7d4972ab54","unresolved":false,"context_lines":[{"line_number":696,"context_line":"        cache_instance_image(task.context, node)"},{"line_number":697,"context_line":"        check_image_size(task)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        manager_utils.node_power_action(task, states.POWER_ON)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        return states.DEPLOYWAIT"},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_2df14c6b","line":699,"updated":"2016-02-08 15:29:15.000000000","message":"why change this? just setting power_on does not ensure a reboot","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"92520424dd0d0edb2d65375283ab8d096e8b943b","unresolved":false,"context_lines":[{"line_number":696,"context_line":"        cache_instance_image(task.context, node)"},{"line_number":697,"context_line":"        check_image_size(task)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        manager_utils.node_power_action(task, states.POWER_ON)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        return states.DEPLOYWAIT"},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_c2f13a03","line":699,"in_reply_to":"5a5ae5dd_2df14c6b","updated":"2016-02-09 06:41:35.000000000","message":"Done","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"0b9aa9e31400900da072e5beedd73b7d4972ab54","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        :returns: deploy state DELETED."},{"line_number":712,"context_line":"        \"\"\""},{"line_number":713,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":714,"context_line":"        if task.node.provision_state !\u003d states.ACTIVE:"},{"line_number":715,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":716,"context_line":"            provider.remove_provisioning_network(task)"},{"line_number":717,"context_line":"        return states.DELETED"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_4df4c859","line":714,"updated":"2016-02-08 15:29:15.000000000","message":"why check state? its in tear-down....","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e4af7de49cb7c08c62e1089505d16e6a2d92359a","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        :returns: deploy state DELETED."},{"line_number":712,"context_line":"        \"\"\""},{"line_number":713,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":714,"context_line":"        if task.node.provision_state !\u003d states.ACTIVE:"},{"line_number":715,"context_line":"            provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":716,"context_line":"            provider.remove_provisioning_network(task)"},{"line_number":717,"context_line":"        return states.DELETED"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a5ae5dd_d2690727","line":714,"in_reply_to":"5a5ae5dd_4df4c859","updated":"2016-02-09 12:04:47.000000000","message":"No need to check the state here.","commit_id":"4186f2769d532bc809d9fcc4ef89b652ae586bc3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        \"\"\""},{"line_number":711,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":712,"context_line":"        provider \u003d network.get_network_provider(task.node.network_provider)"},{"line_number":713,"context_line":"        provider.remove_provisioning_network(task)"},{"line_number":714,"context_line":"        return states.DELETED"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_15238c57","line":713,"updated":"2016-02-12 00:46:56.000000000","message":"Ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":730,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":731,"context_line":"                # Adding the node to provisioning network so that the dhcp"},{"line_number":732,"context_line":"                # options get added for the provisioning port."},{"line_number":733,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":734,"context_line":"                provider \u003d network.get_network_provider("},{"line_number":735,"context_line":"                    task.node.network_provider)"},{"line_number":736,"context_line":"                provider.add_provisioning_network(task)"}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_55db444f","line":733,"updated":"2016-02-12 00:46:56.000000000","message":"We don\u0027t need a power off call here, right? It hasn\u0027t been powered on yet.","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a19d9ee457b4e3600b2f87327aa3a408cfabaa06","unresolved":false,"context_lines":[{"line_number":730,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":731,"context_line":"                # Adding the node to provisioning network so that the dhcp"},{"line_number":732,"context_line":"                # options get added for the provisioning port."},{"line_number":733,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":734,"context_line":"                provider \u003d network.get_network_provider("},{"line_number":735,"context_line":"                    task.node.network_provider)"},{"line_number":736,"context_line":"                provider.add_provisioning_network(task)"}],"source_content_type":"text/x-python","patch_set":67,"id":"dae33548_5a4f27bd","line":733,"in_reply_to":"3a57f1b5_55db444f","updated":"2016-02-16 15:16:26.000000000","message":"IIUC, this is for the case of take over, when node may be powered on. We need to ensure that it is rebooted.","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1befd768bfd18373428b5ff9456ccc371b2f8ec3","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"@task_manager.require_exclusive_lock"},{"line_number":616,"context_line":"def finish_deploy(task, address):"},{"line_number":617,"context_line":"    \"\"\"Notifies the ramdisk to reboot the node and makes the instance active."},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    This method notifies the ramdisk to proceed to reboot and then"}],"source_content_type":"text/x-python","patch_set":72,"id":"bae84128_0dafe881","line":616,"updated":"2016-02-22 17:03:51.000000000","message":"Now more logic is being added to this function to do with when the networking is configured and when the node is powered up and down, its is becoming more important that we can override this function for those inheriting the iscsi deploy driver, so can we move this function into the vendor pass through or one of the other classes so it is overridable","commit_id":"2b6c6d4e7bca396fd6a6e79453a34d835f72e1be"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"045a52fd37a39d5d4d32dba403b829c2d1d09180","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"@task_manager.require_exclusive_lock"},{"line_number":616,"context_line":"def finish_deploy(task, address):"},{"line_number":617,"context_line":"    \"\"\"Notifies the ramdisk to reboot the node and makes the instance active."},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    This method notifies the ramdisk to proceed to reboot and then"}],"source_content_type":"text/x-python","patch_set":72,"id":"bae84128_63ad8a9a","line":616,"in_reply_to":"bae84128_0dafe881","updated":"2016-02-24 05:32:12.000000000","message":"Done","commit_id":"2b6c6d4e7bca396fd6a6e79453a34d835f72e1be"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c064401009995933b2bbeb18be52a03a05d52c6d","unresolved":false,"context_lines":[{"line_number":961,"context_line":"        self.reboot_and_finish_deploy(task)"},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":964,"context_line":"    def finish_deploy(self, task, address):"},{"line_number":965,"context_line":"        \"\"\"Notifies the ramdisk to reboot the node and makes the instance active."},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"        This method notifies the ramdisk to proceed to reboot and then"}],"source_content_type":"text/x-python","patch_set":74,"id":"bae84128_211fe55b","line":964,"updated":"2016-02-24 12:41:43.000000000","message":"Sam, I\u0027m not sure if this move is necessary. IIUC this function is used only in case of using bash ramdisk, which is being deprecated (and maybe not moving this function to passthrough would be one more stimulation for people to switch to IPA :)). Anyway, I find this misleading now - there are 2 methods in this passthrough - reboot_and_finish_deploy and just finish_deploy. I think it should be at least renamed.","commit_id":"8018d4b76bdb2da45c45a16a7c5e100ce33f179d"},{"author":{"_account_id":7933,"name":"Philippe Godin","email":"godp1301@gmail.com","username":"godp1301"},"change_message_id":"06050ad2028aa72ad906de1ed0fd3d48a5569dfe","unresolved":false,"context_lines":[{"line_number":868,"context_line":""},{"line_number":869,"context_line":"        # NOTE(Siva): When deploying a node on provision network node\u0027s port"},{"line_number":870,"context_line":"        # should be plugged to tenant network before booting the node. It is"},{"line_number":871,"context_line":"        # needed to ensure that node recieve IP address from tenant network."},{"line_number":872,"context_line":"        # Also for SSH driver some changes like setting the boot device only"},{"line_number":873,"context_line":"        # gets applied when the machine is powered off and on again."},{"line_number":874,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":84,"id":"fa0719c6_0c0099a9","line":871,"range":{"start_line":871,"start_character":37,"end_line":871,"end_character":44},"updated":"2016-03-22 19:30:36.000000000","message":"s/recieve/receive","commit_id":"75558e8578e3172f8d84ac4c6a5711f6d6e0c817"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e0e4a6c12b3e3c37c2b2903fc426afe1a01a7d08","unresolved":false,"context_lines":[{"line_number":868,"context_line":""},{"line_number":869,"context_line":"        # NOTE(Siva): When deploying a node on provision network node\u0027s port"},{"line_number":870,"context_line":"        # should be plugged to tenant network before booting the node. It is"},{"line_number":871,"context_line":"        # needed to ensure that node recieve IP address from tenant network."},{"line_number":872,"context_line":"        # Also for SSH driver some changes like setting the boot device only"},{"line_number":873,"context_line":"        # gets applied when the machine is powered off and on again."},{"line_number":874,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":84,"id":"fa0719c6_cc698127","line":871,"range":{"start_line":871,"start_character":37,"end_line":871,"end_character":44},"in_reply_to":"fa0719c6_0c0099a9","updated":"2016-03-22 19:33:17.000000000","message":"Done","commit_id":"75558e8578e3172f8d84ac4c6a5711f6d6e0c817"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ee94c970869ffc49e04491ca674771945249705b","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":581,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":582,"context_line":"        else:"},{"line_number":583,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":584,"context_line":"                # Adding the node to provisioning network so that the dhcp"},{"line_number":585,"context_line":"                # options get added for the provisioning port."},{"line_number":586,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":96,"id":"ba0121b8_16efa21e","line":583,"updated":"2016-03-31 23:13:41.000000000","message":"This seems like it\u0027s dangerous? Prepare must be idempotent per https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L296, and this is very much not.","commit_id":"5d058ea742c49503a7d89a5260eac4da67ed3d73"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"acf37662c35392fd0ee4ecd2dd35b42c5fc956ca","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":581,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":582,"context_line":"        else:"},{"line_number":583,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":584,"context_line":"                # Adding the node to provisioning network so that the dhcp"},{"line_number":585,"context_line":"                # options get added for the provisioning port."},{"line_number":586,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":96,"id":"ba0121b8_0792b94b","line":583,"in_reply_to":"ba0121b8_16efa21e","updated":"2016-04-01 12:49:03.000000000","message":"add_provisioning_network is not idempotent. It may rise MacAddressInUseClient in case port already exist. I have wrap call of add_provisioning_network with try: except.","commit_id":"5d058ea742c49503a7d89a5260eac4da67ed3d73"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f92bb8b40537ef71261eb8f042f177c9907addf9","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                try:"},{"line_number":590,"context_line":"                    task.driver.network.add_provisioning_network(task)"},{"line_number":591,"context_line":"                except neutron_exceptions.MacAddressInUseClient:"},{"line_number":592,"context_line":"                    LOG.warning(_LW(\"Neutron port already exists for node \""},{"line_number":593,"context_line":"                                    \"%(node) in provision network.\"),"},{"line_number":594,"context_line":"                                {\u0027node\u0027: node.uuid})"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":98,"id":"ba0121b8_2ce34b07","line":592,"updated":"2016-04-01 20:11:45.000000000","message":"Given this method is designed to be idempotent, warning here seems like overkill.","commit_id":"23026ba36be5b81c6b8120fb05509a7e5fcc0d6f"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"8f0169837361d7b0f6f83cab9a6e96cecb46672b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutronclient.common import exceptions as neutron_exceptions"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from ironic_lib import disk_utils"},{"line_number":21,"context_line":"from ironic_lib import utils as ironic_utils"}],"source_content_type":"text/x-python","patch_set":102,"id":"5a18252c_b2edaef1","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":65},"updated":"2016-04-13 08:15:53.000000000","message":"It should be grouped into the third-party lib.","commit_id":"cddc83f0687e11b178d6319a6b7b776d36468366"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fc4d6174aedadc09531b7b58d905dbb6b61dccdd","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutronclient.common import exceptions as neutron_exceptions"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from ironic_lib import disk_utils"},{"line_number":21,"context_line":"from ironic_lib import utils as ironic_utils"}],"source_content_type":"text/x-python","patch_set":102,"id":"5a18252c_7fe42ce0","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":65},"in_reply_to":"5a18252c_b2edaef1","updated":"2016-04-14 15:11:26.000000000","message":"Done","commit_id":"cddc83f0687e11b178d6319a6b7b776d36468366"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6a7d33b1daf150bb5be6adb03bc1131e5119ffc0","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        node \u003d task.node"},{"line_number":596,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":597,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":598,"context_line":"        else:"},{"line_number":599,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":600,"context_line":"                # Adding the node to provisioning network so that the dhcp"},{"line_number":601,"context_line":"                # options get added for the provisioning port."}],"source_content_type":"text/x-python","patch_set":107,"id":"dab17558_bc01e808","line":598,"updated":"2016-05-13 12:48:04.000000000","message":"nit: elif: ...","commit_id":"1e104f4dcee89b8d38d2cef41489c5fdde880417"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"47661a83c94f66cdf2993b6e5a3eb1706984b260","unresolved":false,"context_lines":[{"line_number":582,"context_line":"        task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":583,"context_line":"        return states.DELETED"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":586,"context_line":"    def prepare(self, task):"},{"line_number":587,"context_line":"        \"\"\"Prepare the deployment environment for this task\u0027s node."},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":109,"id":"dab17558_bc603f02","line":585,"updated":"2016-05-17 11:50:37.000000000","message":"https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L298 says that this must not require an exclusive lock.","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1e8d6980635bc0fe8839030ed8bf907719a156f3","unresolved":false,"context_lines":[{"line_number":582,"context_line":"        task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":583,"context_line":"        return states.DELETED"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":586,"context_line":"    def prepare(self, task):"},{"line_number":587,"context_line":"        \"\"\"Prepare the deployment environment for this task\u0027s node."},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":109,"id":"bab6814e_4cb4b0d0","line":585,"in_reply_to":"dab17558_bc603f02","updated":"2016-05-24 16:15:39.000000000","message":"Now it is require exclusive lock.","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c624c87e9138112b382038bd902f6f3c57db9394","unresolved":false,"context_lines":[{"line_number":602,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":603,"context_line":"                try:"},{"line_number":604,"context_line":"                    task.driver.network.add_provisioning_network(task)"},{"line_number":605,"context_line":"                except neutron_exceptions.MacAddressInUseClient:"},{"line_number":606,"context_line":"                    LOG.warning(_LW(\"Neutron port already exists for node \""},{"line_number":607,"context_line":"                                    \"%(node) in provision network.\"),"},{"line_number":608,"context_line":"                                {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":109,"id":"bab6814e_569efd56","line":605,"updated":"2016-05-18 15:21:13.000000000","message":"IMO we should not catch specific neutron exception at this level, because add_provisioning_network() is generic method. I think this code can be moved in Neutron driver w/o converting to Ironic exception.","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"639e3db78e17fa8b87396c239aab53f946c60bc2","unresolved":false,"context_lines":[{"line_number":602,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":603,"context_line":"                try:"},{"line_number":604,"context_line":"                    task.driver.network.add_provisioning_network(task)"},{"line_number":605,"context_line":"                except neutron_exceptions.MacAddressInUseClient:"},{"line_number":606,"context_line":"                    LOG.warning(_LW(\"Neutron port already exists for node \""},{"line_number":607,"context_line":"                                    \"%(node) in provision network.\"),"},{"line_number":608,"context_line":"                                {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":109,"id":"bab6814e_feac23ef","line":605,"in_reply_to":"bab6814e_569efd56","updated":"2016-05-18 16:56:24.000000000","message":"+1000","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1e8d6980635bc0fe8839030ed8bf907719a156f3","unresolved":false,"context_lines":[{"line_number":602,"context_line":"                manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":603,"context_line":"                try:"},{"line_number":604,"context_line":"                    task.driver.network.add_provisioning_network(task)"},{"line_number":605,"context_line":"                except neutron_exceptions.MacAddressInUseClient:"},{"line_number":606,"context_line":"                    LOG.warning(_LW(\"Neutron port already exists for node \""},{"line_number":607,"context_line":"                                    \"%(node) in provision network.\"),"},{"line_number":608,"context_line":"                                {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":109,"id":"bab6814e_3378abf8","line":605,"in_reply_to":"bab6814e_569efd56","updated":"2016-05-24 16:15:39.000000000","message":"Done","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"47661a83c94f66cdf2993b6e5a3eb1706984b260","unresolved":false,"context_lines":[{"line_number":858,"context_line":"        self.reboot_and_finish_deploy(task)"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":861,"context_line":"    def bash_finish_deploy(self, task, address):"},{"line_number":862,"context_line":"        \"\"\"Notifies the ramdisk to reboot the node and makes the instance active."},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        This method notifies the ramdisk to proceed to reboot and then"}],"source_content_type":"text/x-python","patch_set":109,"id":"dab17558_d06fe78f","line":861,"updated":"2016-05-17 11:50:37.000000000","message":"Could you move this to the top where finish_deploy was for easier diffing?","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1e8d6980635bc0fe8839030ed8bf907719a156f3","unresolved":false,"context_lines":[{"line_number":858,"context_line":"        self.reboot_and_finish_deploy(task)"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":861,"context_line":"    def bash_finish_deploy(self, task, address):"},{"line_number":862,"context_line":"        \"\"\"Notifies the ramdisk to reboot the node and makes the instance active."},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        This method notifies the ramdisk to proceed to reboot and then"}],"source_content_type":"text/x-python","patch_set":109,"id":"bab6814e_5371efdf","line":861,"in_reply_to":"dab17558_d06fe78f","updated":"2016-05-24 16:15:39.000000000","message":"Sam Betts PS72\nFeb 22 7:03 PM\n\nNow more logic is being added to this function to do with when the networking is configured and when the node is powered up and down, its is becoming more important that we can override this function for those inheriting the iscsi deploy driver, so can we move this function into the vendor pass through or one of the other classes so it is overridable","commit_id":"9d534b73d2cf30fbda8b28f316505b29dccc330b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a1d7bb7118d37b255c0a213b52fdb605df7e6474","unresolved":false,"context_lines":[{"line_number":461,"context_line":"        task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":462,"context_line":"        return states.DELETED"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":465,"context_line":"    def prepare(self, task):"},{"line_number":466,"context_line":"        \"\"\"Prepare the deployment environment for this task\u0027s node."},{"line_number":467,"context_line":""}],"source_content_type":"text/x-python","patch_set":120,"id":"3aaa91ec_80616dd5","line":464,"updated":"2016-06-27 11:28:43.000000000","message":"As Mathieu Mitchell wrote in review there is conflict with documentation https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L298 We should change the doc.","commit_id":"583de0848d57082eef15620b3f5e3567920ceb0c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a1d7bb7118d37b255c0a213b52fdb605df7e6474","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        and user images, fetches the TFTP image from Glance and add it to the"},{"line_number":470,"context_line":"        local cache."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":473,"context_line":"        \"\"\""},{"line_number":474,"context_line":"        node \u003d task.node"},{"line_number":475,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"}],"source_content_type":"text/x-python","patch_set":120,"id":"3aaa91ec_8005ed14","line":472,"updated":"2016-06-27 11:28:43.000000000","message":":raises: NetworkError","commit_id":"583de0848d57082eef15620b3f5e3567920ceb0c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a1d7bb7118d37b255c0a213b52fdb605df7e6474","unresolved":false,"context_lines":[{"line_number":474,"context_line":"        node \u003d task.node"},{"line_number":475,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":476,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":477,"context_line":"        else:"},{"line_number":478,"context_line":"            if node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":479,"context_line":"                # Adding the node to provisioning network so that the dhcp"},{"line_number":480,"context_line":"                # options get added for the provisioning port."}],"source_content_type":"text/x-python","patch_set":120,"id":"3aaa91ec_4005c543","line":477,"updated":"2016-06-27 11:28:43.000000000","message":"nit: elif","commit_id":"583de0848d57082eef15620b3f5e3567920ceb0c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a1d7bb7118d37b255c0a213b52fdb605df7e6474","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                task.driver.network.add_provisioning_network(task)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"            deploy_opts \u003d deploy_utils.build_agent_options(node)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"            task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    def clean_up(self, task):"}],"source_content_type":"text/x-python","patch_set":120,"id":"3aaa91ec_c065351e","line":485,"updated":"2016-06-27 11:28:43.000000000","message":"This empty string is not related to this patch.","commit_id":"583de0848d57082eef15620b3f5e3567920ceb0c"}],"ironic/networks/neutron_plugin.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"58da128be0cfda10a15ba0bed2f7e47c7c2d8847","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        :raises: NetworkError"},{"line_number":319,"context_line":"        \"\"\""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        pass"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _rollback_ports(self, task, network_uuid):"},{"line_number":324,"context_line":"        \"\"\"Attempts to delete any ports created by cleaning"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a7b0d38_c06359b0","line":321,"updated":"2015-12-23 17:55:44.000000000","message":"eh? If it is not needed at all it might be worth not adding it in the first place in previous patches.","commit_id":"8b8418e7e3b92c110de80382818b0635b3990cc7"}],"ironic/tests/unit/drivers/modules/test_agent.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"afd11fab504cb67bd424087cf1beea88c3fc8672","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                     build_options_mock, pxe_prepare_ramdisk_mock):"},{"line_number":339,"context_line":"        with task_manager.acquire("},{"line_number":340,"context_line":"                self.context, self.node[\u0027uuid\u0027], shared\u003dFalse) as task:"},{"line_number":341,"context_line":"            task.node.provision_state \u003d states.AVAILABLE"},{"line_number":342,"context_line":"            build_instance_info_mock.return_value \u003d {\u0027foo\u0027: \u0027bar\u0027}"},{"line_number":343,"context_line":"            build_options_mock.return_value \u003d {\u0027a\u0027: \u0027b\u0027}"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-python","patch_set":53,"id":"5a5ae5dd_2c9be073","line":341,"range":{"start_line":341,"start_character":47,"end_line":341,"end_character":56},"updated":"2016-02-05 13:31:21.000000000","message":"I don\u0027t think this should have changed from DEPLOYING as the first time this method should be triggered for a host is when the node is in deploying state.\n\nBecause of the delineation between the two possible calls for prepare, It think the test needs to be split into two separate tests.","commit_id":"bd23d1f848c92941fe33eb1b78eb63bc05a68210"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    @mock.patch.object(deploy_utils, \u0027build_agent_options\u0027)"},{"line_number":350,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"},{"line_number":351,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":352,"context_line":"                \u0027add_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":353,"context_line":"    def test_prepare(self, add_provisioning_net_mock, build_instance_info_mock,"},{"line_number":354,"context_line":"                     build_options_mock, pxe_prepare_ramdisk_mock):"},{"line_number":355,"context_line":"        with task_manager.acquire("}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_75b760f5","line":352,"updated":"2016-02-12 00:46:56.000000000","message":"Shouldn\u0027t we patch ironic.common.network...add_provisioning_network?","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a19d9ee457b4e3600b2f87327aa3a408cfabaa06","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    @mock.patch.object(deploy_utils, \u0027build_agent_options\u0027)"},{"line_number":350,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"},{"line_number":351,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":352,"context_line":"                \u0027add_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":353,"context_line":"    def test_prepare(self, add_provisioning_net_mock, build_instance_info_mock,"},{"line_number":354,"context_line":"                     build_options_mock, pxe_prepare_ramdisk_mock):"},{"line_number":355,"context_line":"        with task_manager.acquire("}],"source_content_type":"text/x-python","patch_set":67,"id":"dae33548_f8d9b984","line":352,"in_reply_to":"3a57f1b5_75b760f5","updated":"2016-02-16 15:16:26.000000000","message":"It\u0027s not called in case of noop provider, so I think it\u0027s ok to test it this way (and noop does not call network.add_provisioning_network).","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            self.assertFalse(pxe_prepare_ramdisk_mock.called)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":410,"context_line":"                \u0027add_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":411,"context_line":"    def test_active(self, add_provisioning_net_mock):"},{"line_number":412,"context_line":"        with task_manager.acquire("},{"line_number":413,"context_line":"                self.context, self.node[\u0027uuid\u0027], shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_d5c65467","line":410,"updated":"2016-02-12 00:46:56.000000000","message":"Ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a19d9ee457b4e3600b2f87327aa3a408cfabaa06","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            self.assertFalse(pxe_prepare_ramdisk_mock.called)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":410,"context_line":"                \u0027add_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":411,"context_line":"    def test_active(self, add_provisioning_net_mock):"},{"line_number":412,"context_line":"        with task_manager.acquire("},{"line_number":413,"context_line":"                self.context, self.node[\u0027uuid\u0027], shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":67,"id":"dae33548_d8cb15a4","line":410,"in_reply_to":"3a57f1b5_d5c65467","updated":"2016-02-16 15:16:26.000000000","message":"ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e40dd57ce6af397179bf37fe1a85960c83ff5dfd","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"},{"line_number":457,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.network.flat.FlatNetwork.\u0027"},{"line_number":458,"context_line":"                \u0027add_provisioning_network\u0027, autospec\u003dTrue)"},{"line_number":459,"context_line":"    def test_prepare(self, add_provisioning_net_mock, build_instance_info_mock,"},{"line_number":460,"context_line":"                     build_options_mock, pxe_prepare_ramdisk_mock):"},{"line_number":461,"context_line":"        with task_manager.acquire("},{"line_number":462,"context_line":"                self.context, self.node[\u0027uuid\u0027], shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":126,"id":"1aa78d24_32e4530b","line":459,"updated":"2016-07-13 15:46:14.000000000","message":"should also mock ironic.conductor.utils.node_power_action","commit_id":"5041703401ded33fc0b54409d60667900a319403"}],"ironic/tests/unit/drivers/modules/test_agent_base_vendor.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":555,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027power_off\u0027,"},{"line_number":556,"context_line":"                       spec\u003dtypes.FunctionType)"},{"line_number":557,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":558,"context_line":"                \u0027remove_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":559,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":560,"context_line":"                \u0027configure_tenant_networks\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":561,"context_line":"    def test_reboot_and_finish_deploy_soft_poweroff_doesnt_complete("}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_b596383d","line":558,"updated":"2016-02-12 00:46:56.000000000","message":"Ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":557,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":558,"context_line":"                \u0027remove_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":559,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":560,"context_line":"                \u0027configure_tenant_networks\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":561,"context_line":"    def test_reboot_and_finish_deploy_soft_poweroff_doesnt_complete("},{"line_number":562,"context_line":"            self, remove_provisioning_net_mock, configure_tenant_net_mock,"},{"line_number":563,"context_line":"            power_off_mock, get_power_state_mock,"}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_f5711045","line":560,"updated":"2016-02-12 00:46:56.000000000","message":"Ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":584,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027power_off\u0027,"},{"line_number":585,"context_line":"                       spec\u003dtypes.FunctionType)"},{"line_number":586,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":587,"context_line":"                \u0027remove_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":588,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":589,"context_line":"                \u0027configure_tenant_networks\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":590,"context_line":"    def test_reboot_and_finish_deploy_soft_poweroff_fails("}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_759c405d","line":587,"updated":"2016-02-12 00:46:56.000000000","message":"Ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":586,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":587,"context_line":"                \u0027remove_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":588,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":589,"context_line":"                \u0027configure_tenant_networks\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":590,"context_line":"    def test_reboot_and_finish_deploy_soft_poweroff_fails("},{"line_number":591,"context_line":"            self, remove_provisioning_net_mock, configure_tenant_net_mock,"},{"line_number":592,"context_line":"            power_off_mock, node_power_action_mock):"}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_35a3289f","line":589,"updated":"2016-02-12 00:46:56.000000000","message":"Ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":614,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027power_off\u0027,"},{"line_number":615,"context_line":"                       spec\u003dtypes.FunctionType)"},{"line_number":616,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":617,"context_line":"                \u0027remove_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":618,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":619,"context_line":"                \u0027configure_tenant_networks\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":620,"context_line":"    def test_reboot_and_finish_deploy_get_power_state_fails("}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_95b8dcc9","line":617,"updated":"2016-02-12 00:46:56.000000000","message":"Ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":617,"context_line":"                \u0027remove_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":618,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":619,"context_line":"                \u0027configure_tenant_networks\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":620,"context_line":"    def test_reboot_and_finish_deploy_get_power_state_fails("},{"line_number":621,"context_line":"            self, remove_provisioning_net_mock, configure_tenant_net_mock,"},{"line_number":622,"context_line":"            power_off_mock, get_power_state_mock, node_power_action_mock):"}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_55aee481","line":619,"updated":"2016-02-12 00:46:56.000000000","message":"Ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e40dd57ce6af397179bf37fe1a85960c83ff5dfd","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                       spec\u003dtypes.FunctionType)"},{"line_number":572,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027power_off\u0027,"},{"line_number":573,"context_line":"                       spec\u003dtypes.FunctionType)"},{"line_number":574,"context_line":"    def test_reboot_and_finish_deploy(self, power_off_mock,"},{"line_number":575,"context_line":"                                      get_power_state_mock,"},{"line_number":576,"context_line":"                                      node_power_action_mock):"},{"line_number":577,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"}],"source_content_type":"text/x-python","patch_set":126,"id":"1aa78d24_d54e996d","line":574,"updated":"2016-07-13 15:46:14.000000000","message":"mock ...FlatNetwork.remove_provisioning_network \u0026 configure_tenant_networks","commit_id":"5041703401ded33fc0b54409d60667900a319403"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e40dd57ce6af397179bf37fe1a85960c83ff5dfd","unresolved":false,"context_lines":[{"line_number":734,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, autospec\u003dTrue)"},{"line_number":735,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027sync\u0027,"},{"line_number":736,"context_line":"                       spec\u003dtypes.FunctionType)"},{"line_number":737,"context_line":"    def test_reboot_and_finish_deploy_power_action_oob_power_off_failed("},{"line_number":738,"context_line":"            self, sync_mock, node_power_action_mock, log_mock):"},{"line_number":739,"context_line":"        # Enable force power off"},{"line_number":740,"context_line":"        driver_info \u003d self.node.driver_info"}],"source_content_type":"text/x-python","patch_set":126,"id":"1aa78d24_f582b5fd","line":737,"updated":"2016-07-13 15:46:14.000000000","message":"for all the test_reboot_and_finish_deploy_* tests, shouldn\u0027t we mock ...FlatNetwork.remove_provisioning_network \u0026 configure_tenant_networks","commit_id":"5041703401ded33fc0b54409d60667900a319403"}],"ironic/tests/unit/drivers/modules/test_iscsi_deploy.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"afd11fab504cb67bd424087cf1beea88c3fc8672","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027build_deploy_ramdisk_options\u0027,"},{"line_number":1002,"context_line":"                       autospec\u003dTrue)"},{"line_number":1003,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":1004,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":1005,"context_line":"                \u0027add_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":1006,"context_line":"    def test_prepare_node_deploying(self, add_provisioning_net_mock,"},{"line_number":1007,"context_line":"                                    mock_prepare_ramdisk,"},{"line_number":1008,"context_line":"                                    mock_iscsi_options, mock_agent_options):"}],"source_content_type":"text/x-python","patch_set":53,"id":"5a5ae5dd_8fdbe64e","line":1005,"range":{"start_line":1004,"start_character":16,"end_line":1005,"end_character":73},"updated":"2016-02-05 13:31:21.000000000","message":"I think this same mock should be added to the test above as it tests prepared being called when the node is active, and that the we should ensure that we\u0027re not trying to flip network connectivity while the machine is active in the unit test.","commit_id":"bd23d1f848c92941fe33eb1b78eb63bc05a68210"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2ae1eae87584ad92d3ea123a30a217d2ff8d343a","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027build_deploy_ramdisk_options\u0027,"},{"line_number":1002,"context_line":"                       autospec\u003dTrue)"},{"line_number":1003,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":1004,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":1005,"context_line":"                \u0027add_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":1006,"context_line":"    def test_prepare_node_deploying(self, add_provisioning_net_mock,"},{"line_number":1007,"context_line":"                                    mock_prepare_ramdisk,"},{"line_number":1008,"context_line":"                                    mock_iscsi_options, mock_agent_options):"}],"source_content_type":"text/x-python","patch_set":53,"id":"5a5ae5dd_22bd20b7","line":1005,"range":{"start_line":1004,"start_character":16,"end_line":1005,"end_character":73},"in_reply_to":"5a5ae5dd_8fdbe64e","updated":"2016-02-05 17:06:25.000000000","message":"Done","commit_id":"bd23d1f848c92941fe33eb1b78eb63bc05a68210"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":988,"context_line":"            validate_mock.assert_called_once_with(task)"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":991,"context_line":"                \u0027add_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":992,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_instance\u0027, autospec\u003dTrue)"},{"line_number":993,"context_line":"    def test_prepare_node_active(self, prepare_instance_mock,"},{"line_number":994,"context_line":"                                 add_provisioning_net_mock):"}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_75b3e0e9","line":991,"updated":"2016-02-12 00:46:56.000000000","message":"Ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"08455f7bb4b40c5dc0573c4df6c62343611ffa77","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"                       autospec\u003dTrue)"},{"line_number":1007,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":1008,"context_line":"    @mock.patch(\u0027ironic.networks.none.NoopNetworkProvider.\u0027"},{"line_number":1009,"context_line":"                \u0027add_provisioning_network\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":1010,"context_line":"    def test_prepare_node_deploying(self, add_provisioning_net_mock,"},{"line_number":1011,"context_line":"                                    mock_prepare_ramdisk,"},{"line_number":1012,"context_line":"                                    mock_iscsi_options, mock_agent_options):"}],"source_content_type":"text/x-python","patch_set":67,"id":"3a57f1b5_35ca484f","line":1009,"updated":"2016-02-12 00:46:56.000000000","message":"Ditto","commit_id":"a4bd3919195f23b8650e8a2ba1cae94b3be1ffac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e40dd57ce6af397179bf37fe1a85960c83ff5dfd","unresolved":false,"context_lines":[{"line_number":539,"context_line":""},{"line_number":540,"context_line":"            prepare_instance_mock.assert_called_once_with("},{"line_number":541,"context_line":"                task.driver.boot, task)"},{"line_number":542,"context_line":"            self.assertEqual(0, add_provisioning_net_mock.call_count)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    @mock.patch.object(deploy_utils, \u0027build_agent_options\u0027, autospec\u003dTrue)"},{"line_number":545,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":126,"id":"1aa78d24_15e661af","line":542,"updated":"2016-07-13 15:46:14.000000000","message":"hmm, or self.assertFalse(add_provisioning_net_mock.called)","commit_id":"5041703401ded33fc0b54409d60667900a319403"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e40dd57ce6af397179bf37fe1a85960c83ff5dfd","unresolved":false,"context_lines":[{"line_number":557,"context_line":"            mock_agent_options.assert_called_once_with(task.node)"},{"line_number":558,"context_line":"            mock_prepare_ramdisk.assert_called_once_with("},{"line_number":559,"context_line":"                task.driver.boot, task, {\u0027c\u0027: \u0027d\u0027})"},{"line_number":560,"context_line":"            add_provisioning_net_mock.assert_called_once_with(mock.ANY, task)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, autospec\u003dTrue)"},{"line_number":563,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027check_image_size\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":126,"id":"1aa78d24_35227db9","line":560,"updated":"2016-07-13 15:46:14.000000000","message":"manager_utils.node_power_action() is also called, so we should mock that.","commit_id":"5041703401ded33fc0b54409d60667900a319403"}],"releasenotes/notes/add-port-multitenancy-fields-55465091f019d962.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b140f64d8622e38ad6cfa7382ceece8667545472","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion is bumped to 1.18. In this version"},{"line_number":5,"context_line":"    ``local_link_connection`` and ``pxe_enabled`` fields were added to a port"},{"line_number":6,"context_line":"    API object:"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":125,"id":"1aa78d24_5052e535","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":20},"updated":"2016-07-12 23:21:44.000000000","message":"nit: s/microversion/version/ since we don\u0027t refer to it as a microversion in other documentation.","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion is bumped to 1.18. In this version"},{"line_number":5,"context_line":"    ``local_link_connection`` and ``pxe_enabled`` fields were added to a port"},{"line_number":6,"context_line":"    API object:"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":125,"id":"1aa78d24_2b440c48","line":4,"updated":"2016-07-12 22:04:25.000000000","message":"s/1.18/1.19/","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b140f64d8622e38ad6cfa7382ceece8667545472","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion is bumped to 1.18. In this version"},{"line_number":5,"context_line":"    ``local_link_connection`` and ``pxe_enabled`` fields were added to a port"},{"line_number":6,"context_line":"    API object:"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":125,"id":"1aa78d24_21deeddc","line":4,"range":{"start_line":4,"start_character":34,"end_line":4,"end_character":38},"updated":"2016-07-12 23:21:44.000000000","message":"s/1.18/1/1.19","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6caf64d6deaf28796e36bc17d61b96ca4d948bd9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    API microversion is bumped to 1.18. In this version"},{"line_number":5,"context_line":"    ``local_link_connection`` and ``pxe_enabled`` fields were added to a port"},{"line_number":6,"context_line":"    API object:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * ``pxe_enabled`` indicates whether PXE is enabled for the port;"},{"line_number":9,"context_line":"    * ``local_link_connection`` contains the port binding profile."}],"source_content_type":"text/x-yaml","patch_set":125,"id":"1aa78d24_2bb24c4c","line":6,"updated":"2016-07-12 22:04:25.000000000","message":"Maybe instead of the above,\n\n    In API microversion 1.18, these fields were added to a Port:","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b140f64d8622e38ad6cfa7382ceece8667545472","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``local_link_connection`` and ``pxe_enabled`` fields were added to a port"},{"line_number":6,"context_line":"    API object:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * ``pxe_enabled`` indicates whether PXE is enabled for the port;"},{"line_number":9,"context_line":"    * ``local_link_connection`` contains the port binding profile."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":125,"id":"1aa78d24_7033a1f6","line":8,"range":{"start_line":8,"start_character":67,"end_line":8,"end_character":68},"updated":"2016-07-12 23:21:44.000000000","message":"nit: s/;/./","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b140f64d8622e38ad6cfa7382ceece8667545472","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * ``pxe_enabled`` indicates whether PXE is enabled for the port;"},{"line_number":9,"context_line":"    * ``local_link_connection`` contains the port binding profile."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":125,"id":"1aa78d24_f01e715d","line":10,"updated":"2016-07-12 23:21:44.000000000","message":"nit: excess line","commit_id":"05395b4cdf454c1de04ffc4251d611b5a7c8f764"}]}
