)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a075b36e5b2299e2bbd8415ccd4d5f9b0124315","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Create a microversions.py file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create constants for the microversions and put them into"},{"line_number":10,"context_line":"microversions.py.  Use these constants instead of \u0027magic numbers\u0027"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In the future, microversions.py, could possibly contain more than"},{"line_number":13,"context_line":"constants. Possibly helper functions related to versioning could be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_cd6a5781","line":10,"updated":"2015-08-19 23:01:29.000000000","message":"I object to \u0027magic numbers\u0027. They aren\u0027t magic, they are the actual versions.","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"77b77b5bcaba64afa3f949cdd13e0b96a82bd2f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Create a microversions.py file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create constants for the microversions and put them into"},{"line_number":10,"context_line":"microversions.py.  Use these constants instead of \u0027magic numbers\u0027"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In the future, microversions.py, could possibly contain more than"},{"line_number":13,"context_line":"constants. Possibly helper functions related to versioning could be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_478103fa","line":10,"in_reply_to":"fa1b9901_8df0df68","updated":"2015-08-21 02:40:34.000000000","message":"I didn\u0027t know about this use (and maybe not any) described in the wiki.\n\nWrt unnamed numerical constants, I\u0027m not convinced that it describes our use of the versions. Each version means exactly that -- a version number. But not a big deal.","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cc2a1506e935b3c6a1a61ab5a3e21849f2ca61ae","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Create a microversions.py file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create constants for the microversions and put them into"},{"line_number":10,"context_line":"microversions.py.  Use these constants instead of \u0027magic numbers\u0027"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In the future, microversions.py, could possibly contain more than"},{"line_number":13,"context_line":"constants. Possibly helper functions related to versioning could be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_8df0df68","line":10,"in_reply_to":"fa1b9901_cd6a5781","updated":"2015-08-20 00:30:23.000000000","message":"https://en.wikipedia.org/wiki/Magic_number_%28programming%29#Unnamed_numerical_constants\n\nI\u0027ll change it to \u0027unnamed numerical constants\u0027","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"}],"ironic/api/controllers/v1/__init__.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a075b36e5b2299e2bbd8415ccd4d5f9b0124315","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from ironic.api.controllers import link"},{"line_number":32,"context_line":"from ironic.api.controllers.v1 import chassis"},{"line_number":33,"context_line":"from ironic.api.controllers.v1 import driver"},{"line_number":34,"context_line":"from ironic.api.controllers.v1 import microversions as mv"},{"line_number":35,"context_line":"from ironic.api.controllers.v1 import node"},{"line_number":36,"context_line":"from ironic.api.controllers.v1 import port"},{"line_number":37,"context_line":"from ironic.api import expose"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_f2013a07","line":34,"updated":"2015-08-19 23:01:29.000000000","message":"Maybe this is a nit, but \u0027mv\u0027 to me \u003d\u003d \u0027move\u0027.\n\nWhat about \u0027mversion\u0027 or \u0027version\u0027?","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cc2a1506e935b3c6a1a61ab5a3e21849f2ca61ae","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from ironic.api.controllers import link"},{"line_number":32,"context_line":"from ironic.api.controllers.v1 import chassis"},{"line_number":33,"context_line":"from ironic.api.controllers.v1 import driver"},{"line_number":34,"context_line":"from ironic.api.controllers.v1 import microversions as mv"},{"line_number":35,"context_line":"from ironic.api.controllers.v1 import node"},{"line_number":36,"context_line":"from ironic.api.controllers.v1 import port"},{"line_number":37,"context_line":"from ironic.api import expose"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_3f7f7a16","line":34,"in_reply_to":"fa1b9901_f2013a07","updated":"2015-08-20 00:30:23.000000000","message":"Changed to versions","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"}],"ironic/api/controllers/v1/microversions.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"a0b71354bb769c39349827b1009078965e8f9f55","unresolved":false,"context_lines":[{"line_number":46,"context_line":"V1_02_AVAILABLE \u003d 2"},{"line_number":47,"context_line":"V1_03_INT_INFO \u003d 3"},{"line_number":48,"context_line":"V1_04_MANAGEABLE \u003d 4"},{"line_number":49,"context_line":"V1_05_LOGICAL \u003d 5"},{"line_number":50,"context_line":"V1_06_INSPECT \u003d 6"},{"line_number":51,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":52,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_fe94dde2","line":49,"updated":"2015-08-19 02:32:22.000000000","message":"Sorry to be a pain, but this is probably better as V1_05_NAME","commit_id":"d34ac87f230c67424d6f03d1377f875663b02d06"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"c50815fdfb59d61c4b06f3aa31635ac3d7f7c67a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"V1_02_AVAILABLE \u003d 2"},{"line_number":47,"context_line":"V1_03_INT_INFO \u003d 3"},{"line_number":48,"context_line":"V1_04_MANAGEABLE \u003d 4"},{"line_number":49,"context_line":"V1_05_LOGICAL \u003d 5"},{"line_number":50,"context_line":"V1_06_INSPECT \u003d 6"},{"line_number":51,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":52,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_e12f5cf4","line":49,"in_reply_to":"fa1b9901_61482c2e","updated":"2015-08-19 02:55:53.000000000","message":"I\u0027d probably suggest V1_05_NODE_NAME","commit_id":"d34ac87f230c67424d6f03d1377f875663b02d06"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0439de6876994a790cc56f82c91438e9f6775c99","unresolved":false,"context_lines":[{"line_number":46,"context_line":"V1_02_AVAILABLE \u003d 2"},{"line_number":47,"context_line":"V1_03_INT_INFO \u003d 3"},{"line_number":48,"context_line":"V1_04_MANAGEABLE \u003d 4"},{"line_number":49,"context_line":"V1_05_LOGICAL \u003d 5"},{"line_number":50,"context_line":"V1_06_INSPECT \u003d 6"},{"line_number":51,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":52,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_81e9c082","line":49,"in_reply_to":"fa1b9901_e12f5cf4","updated":"2015-08-19 03:02:33.000000000","message":"Done","commit_id":"d34ac87f230c67424d6f03d1377f875663b02d06"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"aa5c6f5ce6238a856db792f1778f97d7a603e7c0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"V1_02_AVAILABLE \u003d 2"},{"line_number":47,"context_line":"V1_03_INT_INFO \u003d 3"},{"line_number":48,"context_line":"V1_04_MANAGEABLE \u003d 4"},{"line_number":49,"context_line":"V1_05_LOGICAL \u003d 5"},{"line_number":50,"context_line":"V1_06_INSPECT \u003d 6"},{"line_number":51,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":52,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_61482c2e","line":49,"in_reply_to":"fa1b9901_fe94dde2","updated":"2015-08-19 02:40:25.000000000","message":"Any of these sound good? I wasn\u0027t sure if just \u0027NAME\u0027 is descriptive enough.\n\n V1_05_NODE_NAMES\n V1_05_NODE_NAME\n V1_05_LOGICAL_NAMES\n  V1_05_LOGICAL_NAME","commit_id":"d34ac87f230c67424d6f03d1377f875663b02d06"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"a0b71354bb769c39349827b1009078965e8f9f55","unresolved":false,"context_lines":[{"line_number":51,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":52,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":53,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":54,"context_line":"V1_10_NODE_NAMES_RFC_3986 \u003d 10"},{"line_number":55,"context_line":"V1_11_ENROLL \u003d 11"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_1ea75150","line":54,"updated":"2015-08-19 02:32:22.000000000","message":"or V1_10_UNRESTRICTED_NAME ?","commit_id":"d34ac87f230c67424d6f03d1377f875663b02d06"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0439de6876994a790cc56f82c91438e9f6775c99","unresolved":false,"context_lines":[{"line_number":51,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":52,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":53,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":54,"context_line":"V1_10_NODE_NAMES_RFC_3986 \u003d 10"},{"line_number":55,"context_line":"V1_11_ENROLL \u003d 11"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_a1ec0490","line":54,"in_reply_to":"fa1b9901_014b70ca","updated":"2015-08-19 03:02:33.000000000","message":"Done","commit_id":"d34ac87f230c67424d6f03d1377f875663b02d06"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"aa5c6f5ce6238a856db792f1778f97d7a603e7c0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":52,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":53,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":54,"context_line":"V1_10_NODE_NAMES_RFC_3986 \u003d 10"},{"line_number":55,"context_line":"V1_11_ENROLL \u003d 11"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_8159c000","line":54,"in_reply_to":"fa1b9901_1ea75150","updated":"2015-08-19 02:40:25.000000000","message":"Could do. I would be interested in some other opinions too.  Ah variable naming!  Joy joy :)","commit_id":"d34ac87f230c67424d6f03d1377f875663b02d06"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"c50815fdfb59d61c4b06f3aa31635ac3d7f7c67a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":52,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":53,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":54,"context_line":"V1_10_NODE_NAMES_RFC_3986 \u003d 10"},{"line_number":55,"context_line":"V1_11_ENROLL \u003d 11"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_014b70ca","line":54,"in_reply_to":"fa1b9901_8159c000","updated":"2015-08-19 02:55:53.000000000","message":"I think that V1_10_NODE_NAMES_RFC_3986 is a bit convoluted, whereas V1_10_UNRESTRICTED_NODE_NAME (following on from above) is self-explanatory.  But as you say, naming is hard :)","commit_id":"d34ac87f230c67424d6f03d1377f875663b02d06"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a075b36e5b2299e2bbd8415ccd4d5f9b0124315","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Here goes a short log of changes in every version."},{"line_number":17,"context_line":"# Refer to doc/source/webapi/v1.rst for a detailed explanation of what"},{"line_number":18,"context_line":"# each version contains, and don\u0027t forget to update it when introducing"},{"line_number":19,"context_line":"# a new version."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# v1.0: corresponds to Juno API, not supported since Kilo"},{"line_number":22,"context_line":"# v1.1: API at the point in time when versioning support was added,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_2d419338","line":19,"updated":"2015-08-19 23:01:29.000000000","message":"What do you think about naming the file \u0027versions.py\u0027 instead of \u0027microversions.py\u0027? If you look here, the term \u0027microversion\u0027 doesn\u0027t appear anywhere. I also saw somewhere (maybe in an email thread), that Devananda doesn\u0027t like the term \u0027microversion\u0027. Anyway, just a thought.","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cc2a1506e935b3c6a1a61ab5a3e21849f2ca61ae","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Here goes a short log of changes in every version."},{"line_number":17,"context_line":"# Refer to doc/source/webapi/v1.rst for a detailed explanation of what"},{"line_number":18,"context_line":"# each version contains, and don\u0027t forget to update it when introducing"},{"line_number":19,"context_line":"# a new version."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# v1.0: corresponds to Juno API, not supported since Kilo"},{"line_number":22,"context_line":"# v1.1: API at the point in time when versioning support was added,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_7f8092f7","line":19,"in_reply_to":"fa1b9901_2d419338","updated":"2015-08-20 00:30:23.000000000","message":"Changed to versions.py","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a075b36e5b2299e2bbd8415ccd4d5f9b0124315","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# v1.11: Nodes appear in ENROLL state by default"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"MIN_VER_STR \u003d \u00271.1\u0027"},{"line_number":42,"context_line":"MAX_VER_STR \u003d \u00271.11\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"V1_00_JUNO \u003d 0"},{"line_number":45,"context_line":"V1_01_INITVER \u003d 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_4d7ac778","line":42,"updated":"2015-08-19 23:01:29.000000000","message":"This seems odd. If we\u0027re going to go to the trouble to get rid of \u0027magic numbers\u0027, why would we use these, instead of generating them from eg V1_01_INITVER \u0026 V1_11_ENROLL respectively?","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cc2a1506e935b3c6a1a61ab5a3e21849f2ca61ae","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# v1.11: Nodes appear in ENROLL state by default"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"MIN_VER_STR \u003d \u00271.1\u0027"},{"line_number":42,"context_line":"MAX_VER_STR \u003d \u00271.11\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"V1_00_JUNO \u003d 0"},{"line_number":45,"context_line":"V1_01_INITVER \u003d 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_7fb41281","line":42,"in_reply_to":"fa1b9901_4d7ac778","updated":"2015-08-20 00:30:23.000000000","message":"I will re-order and do it like that. Also added some unit tests.","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a075b36e5b2299e2bbd8415ccd4d5f9b0124315","unresolved":false,"context_lines":[{"line_number":52,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":53,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":54,"context_line":"V1_10_UNRESTRICTED_NODE_NAME \u003d 10"},{"line_number":55,"context_line":"V1_11_ENROLL \u003d 11"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_8d60dfa6","line":55,"updated":"2015-08-19 23:01:29.000000000","message":"maybe it is just me, but when I see \u0027V1_11_ENROLL\u0027, I think the value is 1.11, not 11. I\u0027d be happy if we got rid of \u0027V1_\u0027. You\u0027ll know it is a version cuz you have to import this file so there will be some \u003cprefix\u003e.\u003cversion\u003e anyway.","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cc2a1506e935b3c6a1a61ab5a3e21849f2ca61ae","unresolved":false,"context_lines":[{"line_number":52,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":53,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":54,"context_line":"V1_10_UNRESTRICTED_NODE_NAME \u003d 10"},{"line_number":55,"context_line":"V1_11_ENROLL \u003d 11"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_ff9102f2","line":55,"in_reply_to":"fa1b9901_8d60dfa6","updated":"2015-08-20 00:30:23.000000000","message":"Can\u0027t have a variable name start with a number.  So can\u0027t get rid of \u0027V1_\u0027.\n\nNot sure what would be a better name. Open to suggestions.","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a075b36e5b2299e2bbd8415ccd4d5f9b0124315","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from ironic.api.controllers import base"},{"line_number":29,"context_line":"from ironic.api.controllers import link"},{"line_number":30,"context_line":"from ironic.api.controllers.v1 import collection"},{"line_number":31,"context_line":"from ironic.api.controllers.v1 import microversions as mv"},{"line_number":32,"context_line":"from ironic.api.controllers.v1 import port"},{"line_number":33,"context_line":"from ironic.api.controllers.v1 import types"},{"line_number":34,"context_line":"from ironic.api.controllers.v1 import utils as api_utils"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_0d992fc4","line":31,"updated":"2015-08-19 23:01:29.000000000","message":"ditto about \u0027mv\u0027","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cc2a1506e935b3c6a1a61ab5a3e21849f2ca61ae","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from ironic.api.controllers import base"},{"line_number":29,"context_line":"from ironic.api.controllers import link"},{"line_number":30,"context_line":"from ironic.api.controllers.v1 import collection"},{"line_number":31,"context_line":"from ironic.api.controllers.v1 import microversions as mv"},{"line_number":32,"context_line":"from ironic.api.controllers.v1 import port"},{"line_number":33,"context_line":"from ironic.api.controllers.v1 import types"},{"line_number":34,"context_line":"from ironic.api.controllers.v1 import utils as api_utils"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_1f9b9673","line":31,"in_reply_to":"fa1b9901_0d992fc4","updated":"2015-08-20 00:30:23.000000000","message":"Changed to versions","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a075b36e5b2299e2bbd8415ccd4d5f9b0124315","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from webob.static import FileIter"},{"line_number":22,"context_line":"import wsme"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic.api.controllers.v1 import microversions as mv"},{"line_number":25,"context_line":"from ironic.common import exception"},{"line_number":26,"context_line":"from ironic.common.i18n import _"},{"line_number":27,"context_line":"from ironic.common import states"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_4dc887a8","line":24,"updated":"2015-08-19 23:01:29.000000000","message":"ditto","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"cc2a1506e935b3c6a1a61ab5a3e21849f2ca61ae","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from webob.static import FileIter"},{"line_number":22,"context_line":"import wsme"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic.api.controllers.v1 import microversions as mv"},{"line_number":25,"context_line":"from ironic.common import exception"},{"line_number":26,"context_line":"from ironic.common.i18n import _"},{"line_number":27,"context_line":"from ironic.common import states"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_3f98da77","line":24,"in_reply_to":"fa1b9901_4dc887a8","updated":"2015-08-20 00:30:23.000000000","message":"Changed to versions","commit_id":"6945109b51606f31fb471bc64994d027e4b7cf48"}],"ironic/api/controllers/v1/versions.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abe16c86292f72ac9ab842fcd85acf41c4315a32","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# v1.11: Nodes appear in ENROLL state by default"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"V1_00_JUNO \u003d 0"},{"line_number":42,"context_line":"V1_01_INITVER \u003d 1"},{"line_number":43,"context_line":"V1_02_AVAILABLE \u003d 2"},{"line_number":44,"context_line":"V1_03_INT_INFO \u003d 3"},{"line_number":45,"context_line":"V1_04_MANAGEABLE \u003d 4"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_e3c07952","line":42,"updated":"2015-08-20 09:03:01.000000000","message":"INITIAL_VERSION","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a3446df909c76b60314dc9adfd53c2f5ac2b0392","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# v1.11: Nodes appear in ENROLL state by default"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"V1_00_JUNO \u003d 0"},{"line_number":42,"context_line":"V1_01_INITVER \u003d 1"},{"line_number":43,"context_line":"V1_02_AVAILABLE \u003d 2"},{"line_number":44,"context_line":"V1_03_INT_INFO \u003d 3"},{"line_number":45,"context_line":"V1_04_MANAGEABLE \u003d 4"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_0ce02395","line":42,"in_reply_to":"fa1b9901_e3c07952","updated":"2015-08-20 18:01:43.000000000","message":"Done","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abe16c86292f72ac9ab842fcd85acf41c4315a32","unresolved":false,"context_lines":[{"line_number":41,"context_line":"V1_00_JUNO \u003d 0"},{"line_number":42,"context_line":"V1_01_INITVER \u003d 1"},{"line_number":43,"context_line":"V1_02_AVAILABLE \u003d 2"},{"line_number":44,"context_line":"V1_03_INT_INFO \u003d 3"},{"line_number":45,"context_line":"V1_04_MANAGEABLE \u003d 4"},{"line_number":46,"context_line":"V1_05_NODE_NAME \u003d 5"},{"line_number":47,"context_line":"V1_06_INSPECT \u003d 6"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_83b17d03","line":44,"updated":"2015-08-20 09:03:01.000000000","message":"DRIVER_INTERNAL_INFO","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a3446df909c76b60314dc9adfd53c2f5ac2b0392","unresolved":false,"context_lines":[{"line_number":41,"context_line":"V1_00_JUNO \u003d 0"},{"line_number":42,"context_line":"V1_01_INITVER \u003d 1"},{"line_number":43,"context_line":"V1_02_AVAILABLE \u003d 2"},{"line_number":44,"context_line":"V1_03_INT_INFO \u003d 3"},{"line_number":45,"context_line":"V1_04_MANAGEABLE \u003d 4"},{"line_number":46,"context_line":"V1_05_NODE_NAME \u003d 5"},{"line_number":47,"context_line":"V1_06_INSPECT \u003d 6"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_acf1f76c","line":44,"in_reply_to":"fa1b9901_83b17d03","updated":"2015-08-20 18:01:43.000000000","message":"Done","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abe16c86292f72ac9ab842fcd85acf41c4315a32","unresolved":false,"context_lines":[{"line_number":46,"context_line":"V1_05_NODE_NAME \u003d 5"},{"line_number":47,"context_line":"V1_06_INSPECT \u003d 6"},{"line_number":48,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":49,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":50,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":51,"context_line":"V1_10_UNRESTRICTED_NODE_NAME \u003d 10"},{"line_number":52,"context_line":"V1_11_ENROLL \u003d 11"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_a3b601f7","line":49,"updated":"2015-08-20 09:03:01.000000000","message":"FETCHING_SUBSET_OF_FIELDS","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a3446df909c76b60314dc9adfd53c2f5ac2b0392","unresolved":false,"context_lines":[{"line_number":46,"context_line":"V1_05_NODE_NAME \u003d 5"},{"line_number":47,"context_line":"V1_06_INSPECT \u003d 6"},{"line_number":48,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":49,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":50,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":51,"context_line":"V1_10_UNRESTRICTED_NODE_NAME \u003d 10"},{"line_number":52,"context_line":"V1_11_ENROLL \u003d 11"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_ecfb6f45","line":49,"in_reply_to":"fa1b9901_a3b601f7","updated":"2015-08-20 18:01:43.000000000","message":"Done","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abe16c86292f72ac9ab842fcd85acf41c4315a32","unresolved":false,"context_lines":[{"line_number":47,"context_line":"V1_06_INSPECT \u003d 6"},{"line_number":48,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":49,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":50,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":51,"context_line":"V1_10_UNRESTRICTED_NODE_NAME \u003d 10"},{"line_number":52,"context_line":"V1_11_ENROLL \u003d 11"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_43d0451f","line":50,"updated":"2015-08-20 09:03:01.000000000","message":"PROVISION_STATE_FILTER","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a3446df909c76b60314dc9adfd53c2f5ac2b0392","unresolved":false,"context_lines":[{"line_number":47,"context_line":"V1_06_INSPECT \u003d 6"},{"line_number":48,"context_line":"V1_07_NODE_CLEAN \u003d 7"},{"line_number":49,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":50,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":51,"context_line":"V1_10_UNRESTRICTED_NODE_NAME \u003d 10"},{"line_number":52,"context_line":"V1_11_ENROLL \u003d 11"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_0cf7c359","line":50,"in_reply_to":"fa1b9901_43d0451f","updated":"2015-08-20 18:01:43.000000000","message":"Done","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abe16c86292f72ac9ab842fcd85acf41c4315a32","unresolved":false,"context_lines":[{"line_number":49,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":50,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":51,"context_line":"V1_10_UNRESTRICTED_NODE_NAME \u003d 10"},{"line_number":52,"context_line":"V1_11_ENROLL \u003d 11"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# When adding another version, update MAX_VER_STR"},{"line_number":55,"context_line":"MAX_VER_STR \u003d \u00271.{}\u0027.format(V1_11_ENROLL)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_63cd4984","line":52,"updated":"2015-08-20 09:03:01.000000000","message":"ENROLL_STATE","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a3446df909c76b60314dc9adfd53c2f5ac2b0392","unresolved":false,"context_lines":[{"line_number":49,"context_line":"V1_08_RES_FIELDS_SUB \u003d 8"},{"line_number":50,"context_line":"V1_09_PROV_FILTER \u003d 9"},{"line_number":51,"context_line":"V1_10_UNRESTRICTED_NODE_NAME \u003d 10"},{"line_number":52,"context_line":"V1_11_ENROLL \u003d 11"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# When adding another version, update MAX_VER_STR"},{"line_number":55,"context_line":"MAX_VER_STR \u003d \u00271.{}\u0027.format(V1_11_ENROLL)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_ac98171d","line":52,"in_reply_to":"fa1b9901_63cd4984","updated":"2015-08-20 18:01:43.000000000","message":"Done","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abe16c86292f72ac9ab842fcd85acf41c4315a32","unresolved":false,"context_lines":[{"line_number":52,"context_line":"V1_11_ENROLL \u003d 11"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# When adding another version, update MAX_VER_STR"},{"line_number":55,"context_line":"MAX_VER_STR \u003d \u00271.{}\u0027.format(V1_11_ENROLL)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# MIN_VER_STR should not change."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_03c6cd67","line":55,"updated":"2015-08-20 09:03:01.000000000","message":"as you\u0027re on it, could you please drop the shortening VER (I\u0027m fine with MAX/MIN, they\u0027re more common): MAX_VERSION_STRING","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a3446df909c76b60314dc9adfd53c2f5ac2b0392","unresolved":false,"context_lines":[{"line_number":52,"context_line":"V1_11_ENROLL \u003d 11"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# When adding another version, update MAX_VER_STR"},{"line_number":55,"context_line":"MAX_VER_STR \u003d \u00271.{}\u0027.format(V1_11_ENROLL)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# MIN_VER_STR should not change."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_6c9e7f08","line":55,"in_reply_to":"fa1b9901_03c6cd67","updated":"2015-08-20 18:01:43.000000000","message":"Done","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abe16c86292f72ac9ab842fcd85acf41c4315a32","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# MIN_VER_STR should not change."},{"line_number":59,"context_line":"MIN_VER_STR \u003d \u00271.{}\u0027.format(V1_01_INITVER)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_23c3d158","line":59,"updated":"2015-08-20 09:03:01.000000000","message":"ditto, MIN_VERSION_STRING","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a3446df909c76b60314dc9adfd53c2f5ac2b0392","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# MIN_VER_STR should not change."},{"line_number":59,"context_line":"MIN_VER_STR \u003d \u00271.{}\u0027.format(V1_01_INITVER)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_2c8de7d5","line":59,"in_reply_to":"fa1b9901_23c3d158","updated":"2015-08-20 18:01:43.000000000","message":"Done","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b7fadb88bef358c3dcd599839bbcbce99879369c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"V1_00_JUNO \u003d 0"},{"line_number":45,"context_line":"V1_01_INITIAL_VERSION \u003d 1"},{"line_number":46,"context_line":"V1_02_AVAILABLE \u003d 2"},{"line_number":47,"context_line":"V1_03_DRIVER_INTERNAL_INFO \u003d 3"},{"line_number":48,"context_line":"V1_04_MANAGEABLE \u003d 4"},{"line_number":49,"context_line":"V1_05_NODE_NAME \u003d 5"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_bd6b5284","line":46,"updated":"2015-08-21 02:47:28.000000000","message":"We have ENROLL_STATE, but not AVAILABLE_STATE or MANAGEABLE_STATE or INSPECT_STATE.","commit_id":"69d884bc1da0dd6f799a93fc7cf7c888b2b526a1"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"88f8693cb0afe839d42c861b361dff0b1805ec09","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"V1_00_JUNO \u003d 0"},{"line_number":45,"context_line":"V1_01_INITIAL_VERSION \u003d 1"},{"line_number":46,"context_line":"V1_02_AVAILABLE \u003d 2"},{"line_number":47,"context_line":"V1_03_DRIVER_INTERNAL_INFO \u003d 3"},{"line_number":48,"context_line":"V1_04_MANAGEABLE \u003d 4"},{"line_number":49,"context_line":"V1_05_NODE_NAME \u003d 5"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_97e7cd11","line":46,"in_reply_to":"fa1b9901_bd6b5284","updated":"2015-08-24 20:07:55.000000000","message":"Done","commit_id":"69d884bc1da0dd6f799a93fc7cf7c888b2b526a1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"43b0cb4822fb427b8a00f85c93e6fb2d0877aa5f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"V1_08_FETCHING_SUBSET_OF_FIELDS \u003d 8"},{"line_number":53,"context_line":"V1_09_PROVISION_STATE_FILTER \u003d 9"},{"line_number":54,"context_line":"V1_10_UNRESTRICTED_NODE_NAME \u003d 10"},{"line_number":55,"context_line":"V1_11_ENROLL_STATE \u003d 11"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# When adding another version, update MAX_VERSION_STRING"},{"line_number":58,"context_line":"MAX_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, V1_11_ENROLL_STATE)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_8a98821d","line":55,"updated":"2015-08-21 02:43:28.000000000","message":"(Continuing comments from previous version)\nHow about MINOR_0_JUNO, MINOR_1_INITIAL_VERSION,...\n\nThe \u002700\u0027, \u002701\u0027, threw me for a bit, and then I thought maybe people liked that cuz things lined up better, but then I thought what happens when/if we make it to 1.100?","commit_id":"69d884bc1da0dd6f799a93fc7cf7c888b2b526a1"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"88f8693cb0afe839d42c861b361dff0b1805ec09","unresolved":false,"context_lines":[{"line_number":52,"context_line":"V1_08_FETCHING_SUBSET_OF_FIELDS \u003d 8"},{"line_number":53,"context_line":"V1_09_PROVISION_STATE_FILTER \u003d 9"},{"line_number":54,"context_line":"V1_10_UNRESTRICTED_NODE_NAME \u003d 10"},{"line_number":55,"context_line":"V1_11_ENROLL_STATE \u003d 11"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# When adding another version, update MAX_VERSION_STRING"},{"line_number":58,"context_line":"MAX_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, V1_11_ENROLL_STATE)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_57f135cc","line":55,"in_reply_to":"fa1b9901_8a98821d","updated":"2015-08-24 20:07:55.000000000","message":"I like it.  Changed.","commit_id":"69d884bc1da0dd6f799a93fc7cf7c888b2b526a1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"43b0cb4822fb427b8a00f85c93e6fb2d0877aa5f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"V1_11_ENROLL_STATE \u003d 11"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# When adding another version, update MAX_VERSION_STRING"},{"line_number":58,"context_line":"MAX_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, V1_11_ENROLL_STATE)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# MIN_VER_STR should not change."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_6a6f2efc","line":58,"updated":"2015-08-21 02:43:28.000000000","message":"interesting that you put MAX before MIN. Let\u0027s see how that goes.\n\nI was just wondering. What do you think about adding another constant eg MINOR_11_ENROLL_STATE \u003d MINOR_MAX_VERSION \u003d 11?\nIt will make it more \u0027in your face\u0027 for someone adding a new version, and this line here can always be MINOR_MAX_VERSION and not have to be edit\u0027d. (This could also be outside the scope of this patch ;))","commit_id":"69d884bc1da0dd6f799a93fc7cf7c888b2b526a1"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"88f8693cb0afe839d42c861b361dff0b1805ec09","unresolved":false,"context_lines":[{"line_number":55,"context_line":"V1_11_ENROLL_STATE \u003d 11"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# When adding another version, update MAX_VERSION_STRING"},{"line_number":58,"context_line":"MAX_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, V1_11_ENROLL_STATE)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# MIN_VER_STR should not change."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_b7c9b17b","line":58,"in_reply_to":"fa1b9901_6a6f2efc","updated":"2015-08-24 20:07:55.000000000","message":"I did something sort of like that.","commit_id":"69d884bc1da0dd6f799a93fc7cf7c888b2b526a1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fd378d963e9d67e799b283ebfd76d4be6d46cb9b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"MINOR_11_ENROLL_STATE \u003d 11"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# When adding another version, update MINOR_MAX_VERSION"},{"line_number":58,"context_line":"MINOR_MAX_VERSION \u003d MINOR_11_ENROLL_STATE"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# String representations of the minor and maximum versions"},{"line_number":61,"context_line":"MIN_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, MINOR_1_INITIAL_VERSION)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_0d32a55e","line":58,"updated":"2015-08-25 14:07:43.000000000","message":"I was thinking MINOR_MAX_VERSION \u003d MINOR_11_ENROLL_STATE \u003d 11 so that it was more in your face, and more obvious for reviewers to see if it was missed when doing a diff, but I guess this is ok.\n\nHmm, or MINOR_11_ENROLL_STATE \u003d MINOR_MAX_VERSION \u003d 11.","commit_id":"3c5dde4ea5c56d844a0486602da242398d1f30cd"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"d507314b4559292d255ea1f9bf3e4ce432c4abff","unresolved":false,"context_lines":[{"line_number":55,"context_line":"MINOR_11_ENROLL_STATE \u003d 11"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# When adding another version, update MINOR_MAX_VERSION"},{"line_number":58,"context_line":"MINOR_MAX_VERSION \u003d MINOR_11_ENROLL_STATE"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# String representations of the minor and maximum versions"},{"line_number":61,"context_line":"MIN_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, MINOR_1_INITIAL_VERSION)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_9c9b1e17","line":58,"in_reply_to":"fa1b9901_0d32a55e","updated":"2015-08-26 09:05:35.000000000","message":"I guess it\u0027s fine as we have some good unit tests in this patch that would help people catch such a mistake even before they raise review.","commit_id":"3c5dde4ea5c56d844a0486602da242398d1f30cd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fd378d963e9d67e799b283ebfd76d4be6d46cb9b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# When adding another version, update MINOR_MAX_VERSION"},{"line_number":58,"context_line":"MINOR_MAX_VERSION \u003d MINOR_11_ENROLL_STATE"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# String representations of the minor and maximum versions"},{"line_number":61,"context_line":"MIN_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, MINOR_1_INITIAL_VERSION)"},{"line_number":62,"context_line":"MAX_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, MINOR_MAX_VERSION)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa1b9901_ad4379ae","line":60,"updated":"2015-08-25 14:07:43.000000000","message":"I think s/minor/minimum/","commit_id":"3c5dde4ea5c56d844a0486602da242398d1f30cd"}],"ironic/tests/api/v1/test_versions.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"39efc018476111b30820167431bd961fb1fb75dc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # constant"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        # Get all of our named constants.  They all begin with V1_"},{"line_number":29,"context_line":"        consts \u003d [x for x in sorted(dir(versions)) if x.startswith(\u0027V1_\u0027)]"},{"line_number":30,"context_line":"        max_ver \u003d \u00271.{}\u0027.format(getattr(versions, consts[-1]))"},{"line_number":31,"context_line":"        self.assertEqual(max_ver, getattr(versions, \u0027MAX_VER_STR\u0027))"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_a9c91028","line":29,"updated":"2015-08-20 03:09:40.000000000","message":"nit: you could take \u0027consts\u0027 and add that to a setUp() method instead as it\u0027s common to all but one test. I think it\u0027s only worth addressing if you need to push another revision.","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a3446df909c76b60314dc9adfd53c2f5ac2b0392","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # constant"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        # Get all of our named constants.  They all begin with V1_"},{"line_number":29,"context_line":"        consts \u003d [x for x in sorted(dir(versions)) if x.startswith(\u0027V1_\u0027)]"},{"line_number":30,"context_line":"        max_ver \u003d \u00271.{}\u0027.format(getattr(versions, consts[-1]))"},{"line_number":31,"context_line":"        self.assertEqual(max_ver, getattr(versions, \u0027MAX_VER_STR\u0027))"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_cc646bba","line":29,"in_reply_to":"fa1b9901_a9c91028","updated":"2015-08-20 18:01:43.000000000","message":"Good idea.  Will do.","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abe16c86292f72ac9ab842fcd85acf41c4315a32","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        # Get all of our named constants.  They all begin with V1_"},{"line_number":29,"context_line":"        consts \u003d [x for x in sorted(dir(versions)) if x.startswith(\u0027V1_\u0027)]"},{"line_number":30,"context_line":"        max_ver \u003d \u00271.{}\u0027.format(getattr(versions, consts[-1]))"},{"line_number":31,"context_line":"        self.assertEqual(max_ver, getattr(versions, \u0027MAX_VER_STR\u0027))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_min_ver_str(self):"},{"line_number":34,"context_line":"        # Try to make sure someone doesn\u0027t change the MIN_VER_STR by accident"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_23ec31f2","line":31,"updated":"2015-08-20 09:03:01.000000000","message":"getattr is not needed, just versions.MAX_VER_STR","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a3446df909c76b60314dc9adfd53c2f5ac2b0392","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        # Get all of our named constants.  They all begin with V1_"},{"line_number":29,"context_line":"        consts \u003d [x for x in sorted(dir(versions)) if x.startswith(\u0027V1_\u0027)]"},{"line_number":30,"context_line":"        max_ver \u003d \u00271.{}\u0027.format(getattr(versions, consts[-1]))"},{"line_number":31,"context_line":"        self.assertEqual(max_ver, getattr(versions, \u0027MAX_VER_STR\u0027))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_min_ver_str(self):"},{"line_number":34,"context_line":"        # Try to make sure someone doesn\u0027t change the MIN_VER_STR by accident"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_0c5023d3","line":31,"in_reply_to":"fa1b9901_23ec31f2","updated":"2015-08-20 18:01:43.000000000","message":"Uh, whoops on my part :)  Once I used the first \u0027getattr\u0027 which was needed, I got on a roll...","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"abe16c86292f72ac9ab842fcd85acf41c4315a32","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def test_min_ver_str(self):"},{"line_number":34,"context_line":"        # Try to make sure someone doesn\u0027t change the MIN_VER_STR by accident"},{"line_number":35,"context_line":"        # and make sure it exists"},{"line_number":36,"context_line":"        self.assertEqual(\u00271.1\u0027, getattr(versions, \u0027MIN_VER_STR\u0027))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_name_value_match(self):"},{"line_number":39,"context_line":"        # Test to make sure variable name matches the value.  For example"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_c3bbf5e3","line":36,"updated":"2015-08-20 09:03:01.000000000","message":"getattr is not needed, just versions.MIN_VER_STR","commit_id":"b48ef3dfcba46987a1311cf8f2f5f433df910794"}]}
