)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"7b61c48d7bfc18bd71e70986c4b57f59b31eba6e","unresolved":false,"context_lines":[{"line_number":902,"context_line":"        If it does, is necessary to prevent updating it because the new driver"},{"line_number":903,"context_line":"        will not be able to stop a console started by the previous one."},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        :param rpc_node: RPC Node object to be veryfied."},{"line_number":906,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":907,"context_line":"        :raises: wsme.exc.ClientSideError"},{"line_number":908,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_26e1edd0","side":"PARENT","line":905,"updated":"2015-08-19 00:33:33.000000000","message":"s/veryfied/verified/ It\u0027s not your fault, but please fix it.","commit_id":"4dbf176ad4708e8c802d42e5dfd306f5a0e12ada"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"010d55ad5ae1e674c9aff477dadf81f2154e90fb","unresolved":false,"context_lines":[{"line_number":902,"context_line":"        If it does, is necessary to prevent updating it because the new driver"},{"line_number":903,"context_line":"        will not be able to stop a console started by the previous one."},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        :param rpc_node: RPC Node object to be veryfied."},{"line_number":906,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":907,"context_line":"        :raises: wsme.exc.ClientSideError"},{"line_number":908,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_21931751","side":"PARENT","line":905,"in_reply_to":"fa1b9901_26e1edd0","updated":"2015-08-19 01:05:38.000000000","message":"I think I will leave that out of this patch set.  Please submit a patch to fix it though!","commit_id":"4dbf176ad4708e8c802d42e5dfd306f5a0e12ada"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4c4c4865bbc09499f368f6394569b3f8be713e05","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            except exception.ChassisNotFound as e:"},{"line_number":479,"context_line":"                # Change error code because 404 (NotFound) is inappropriate"},{"line_number":480,"context_line":"                # response for a POST request to create a Port"},{"line_number":481,"context_line":"                e.code \u003d http_client.BAD_REQUEST  # BadRequest"},{"line_number":482,"context_line":"                raise e"},{"line_number":483,"context_line":"        elif value \u003d\u003d wtypes.Unset:"},{"line_number":484,"context_line":"            self._chassis_uuid \u003d wtypes.Unset"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_03d9ed21","line":481,"updated":"2015-08-20 09:07:58.000000000","message":"nit: the comment is no longer needed","commit_id":"d0c6d84880e4f59dc2e9f7c087354b1f910ff49f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d2d1ca4dc41b9f59e677dfe780f0aaae412d9310","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            except exception.ChassisNotFound as e:"},{"line_number":479,"context_line":"                # Change error code because 404 (NotFound) is inappropriate"},{"line_number":480,"context_line":"                # response for a POST request to create a Port"},{"line_number":481,"context_line":"                e.code \u003d http_client.BAD_REQUEST  # BadRequest"},{"line_number":482,"context_line":"                raise e"},{"line_number":483,"context_line":"        elif value \u003d\u003d wtypes.Unset:"},{"line_number":484,"context_line":"            self._chassis_uuid \u003d wtypes.Unset"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_9404474a","line":481,"in_reply_to":"fa1b9901_03d9ed21","updated":"2015-08-20 14:46:14.000000000","message":"I will fix if need to respin this patch. Otherwise I will do a follow up patch to fix nits.","commit_id":"d0c6d84880e4f59dc2e9f7c087354b1f910ff49f"}],"ironic/api/hooks.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4c4c4865bbc09499f368f6394569b3f8be713e05","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Do nothing if there is no error."},{"line_number":138,"context_line":"        if (http_client.OK \u003c\u003d state.response.status_int \u003c"},{"line_number":139,"context_line":"                http_client.BAD_REQUEST):"},{"line_number":140,"context_line":"            return"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        json_body \u003d state.response.json"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_c305357a","line":139,"updated":"2015-08-20 09:07:58.000000000","message":"I\u0027m not sure about this one, this place assumes OK \u003d\u003d 200 and BAD_REQUEST \u003d\u003d 400, I would leave it as it was...","commit_id":"d0c6d84880e4f59dc2e9f7c087354b1f910ff49f"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e259e1b3e30616fd9001797d46d1a1b8532a4f36","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Do nothing if there is no error."},{"line_number":138,"context_line":"        if (http_client.OK \u003c\u003d state.response.status_int \u003c"},{"line_number":139,"context_line":"                http_client.BAD_REQUEST):"},{"line_number":140,"context_line":"            return"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        json_body \u003d state.response.json"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_9279c584","line":139,"in_reply_to":"fa1b9901_c305357a","updated":"2015-08-20 10:47:45.000000000","message":"+1, numbers will make more sense here :)","commit_id":"d0c6d84880e4f59dc2e9f7c087354b1f910ff49f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d2d1ca4dc41b9f59e677dfe780f0aaae412d9310","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Do nothing if there is no error."},{"line_number":138,"context_line":"        if (http_client.OK \u003c\u003d state.response.status_int \u003c"},{"line_number":139,"context_line":"                http_client.BAD_REQUEST):"},{"line_number":140,"context_line":"            return"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        json_body \u003d state.response.json"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_74a5f344","line":139,"in_reply_to":"fa1b9901_c305357a","updated":"2015-08-20 14:46:14.000000000","message":"I will fix if need to respin this patch. Otherwise I will do a follow up patch to fix nits.\n\nI would lean toward commenting about 200 and 400, and leaving the variable names.","commit_id":"d0c6d84880e4f59dc2e9f7c087354b1f910ff49f"}],"ironic/common/exception.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4c4c4865bbc09499f368f6394569b3f8be713e05","unresolved":false,"context_lines":[{"line_number":443,"context_line":"class NoFreeConductorWorker(TemporaryFailure):"},{"line_number":444,"context_line":"    message \u003d _(\u0027Requested action cannot be performed due to lack of free \u0027"},{"line_number":445,"context_line":"                \u0027conductor workers.\u0027)"},{"line_number":446,"context_line":"    code \u003d http_client.SERVICE_UNAVAILABLE  # Service Unavailable (temporary)."},{"line_number":447,"context_line":""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"class VendorPassthruException(IronicException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_23d671f1","line":446,"updated":"2015-08-20 09:07:58.000000000","message":"nit: the comment is no longer needed IMO","commit_id":"d0c6d84880e4f59dc2e9f7c087354b1f910ff49f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d2d1ca4dc41b9f59e677dfe780f0aaae412d9310","unresolved":false,"context_lines":[{"line_number":443,"context_line":"class NoFreeConductorWorker(TemporaryFailure):"},{"line_number":444,"context_line":"    message \u003d _(\u0027Requested action cannot be performed due to lack of free \u0027"},{"line_number":445,"context_line":"                \u0027conductor workers.\u0027)"},{"line_number":446,"context_line":"    code \u003d http_client.SERVICE_UNAVAILABLE  # Service Unavailable (temporary)."},{"line_number":447,"context_line":""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"class VendorPassthruException(IronicException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_346a1bef","line":446,"in_reply_to":"fa1b9901_23d671f1","updated":"2015-08-20 14:46:14.000000000","message":"I will fix if need to respin this patch. Otherwise I will do a follow up patch to fix nits.","commit_id":"d0c6d84880e4f59dc2e9f7c087354b1f910ff49f"}]}