)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"3caed016df022db1c6be313f3545b2a5f8413c5a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce new RPCs to support volume connector operation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces following two new rpc in order to support volume"},{"line_number":10,"context_line":"connector operation in Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- update_volume_connector()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa1b9901_94050e15","line":9,"updated":"2015-08-20 23:52:14.000000000","message":"s/rpc/RPCs/","commit_id":"8a0c49b3e25d9e26670886a9829f8d2284dceb42"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e38554b357044d5817cc448da772a4b81b4bc6c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce new RPCs to support volume connector operation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch introduces following two new rpc in order to support volume"},{"line_number":10,"context_line":"connector operation in Ironic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- update_volume_connector()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa1b9901_558bf01e","line":9,"in_reply_to":"fa1b9901_94050e15","updated":"2015-08-21 01:08:16.000000000","message":"Done","commit_id":"8a0c49b3e25d9e26670886a9829f8d2284dceb42"}],"ironic/conductor/manager.py":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"3caed016df022db1c6be313f3545b2a5f8413c5a","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":1464,"context_line":"                                   exception.NodeNotFound)"},{"line_number":1465,"context_line":"    def destroy_volume_connector(self, context, connector):"},{"line_number":1466,"context_line":"        \"\"\"Delete a port."},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"        :param context: request context."},{"line_number":1469,"context_line":"        :param connector: volume connector object"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_2f22aba3","line":1466,"updated":"2015-08-20 23:52:14.000000000","message":"Delete a volume connector.","commit_id":"8a0c49b3e25d9e26670886a9829f8d2284dceb42"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e38554b357044d5817cc448da772a4b81b4bc6c1","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":1464,"context_line":"                                   exception.NodeNotFound)"},{"line_number":1465,"context_line":"    def destroy_volume_connector(self, context, connector):"},{"line_number":1466,"context_line":"        \"\"\"Delete a port."},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"        :param context: request context."},{"line_number":1469,"context_line":"        :param connector: volume connector object"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_d57f0013","line":1466,"in_reply_to":"fa1b9901_2f22aba3","updated":"2015-08-21 01:08:16.000000000","message":"Oops, I\u0027ll update it.","commit_id":"8a0c49b3e25d9e26670886a9829f8d2284dceb42"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"3caed016df022db1c6be313f3545b2a5f8413c5a","unresolved":false,"context_lines":[{"line_number":1480,"context_line":"            connector.destroy()"},{"line_number":1481,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume connector\u0027"},{"line_number":1482,"context_line":"                         \u0027%(connector)s. \u0027"},{"line_number":1483,"context_line":"                         \u0027The node associated with the port was \u0027"},{"line_number":1484,"context_line":"                         \u0027%(node)s\u0027),"},{"line_number":1485,"context_line":"                     {\u0027connector\u0027: connector.uuid, \u0027node\u0027: task.node.uuid})"},{"line_number":1486,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_0f400706","line":1483,"updated":"2015-08-20 23:52:14.000000000","message":"s/port/connector/","commit_id":"8a0c49b3e25d9e26670886a9829f8d2284dceb42"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e38554b357044d5817cc448da772a4b81b4bc6c1","unresolved":false,"context_lines":[{"line_number":1480,"context_line":"            connector.destroy()"},{"line_number":1481,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume connector\u0027"},{"line_number":1482,"context_line":"                         \u0027%(connector)s. \u0027"},{"line_number":1483,"context_line":"                         \u0027The node associated with the port was \u0027"},{"line_number":1484,"context_line":"                         \u0027%(node)s\u0027),"},{"line_number":1485,"context_line":"                     {\u0027connector\u0027: connector.uuid, \u0027node\u0027: task.node.uuid})"},{"line_number":1486,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_7595d430","line":1483,"in_reply_to":"fa1b9901_0f400706","updated":"2015-08-21 01:08:16.000000000","message":"Done","commit_id":"8a0c49b3e25d9e26670886a9829f8d2284dceb42"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"3caed016df022db1c6be313f3545b2a5f8413c5a","unresolved":false,"context_lines":[{"line_number":1628,"context_line":""},{"line_number":1629,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":1630,"context_line":"    def update_volume_connector(self, context, connector):"},{"line_number":1631,"context_line":"        \"\"\"Update a port."},{"line_number":1632,"context_line":""},{"line_number":1633,"context_line":"        :param context: request context."},{"line_number":1634,"context_line":"        :param connector: a changed (but not saved) volume connector object."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_2f5aabf2","line":1631,"updated":"2015-08-20 23:52:14.000000000","message":"Update a volume connector.","commit_id":"8a0c49b3e25d9e26670886a9829f8d2284dceb42"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"e38554b357044d5817cc448da772a4b81b4bc6c1","unresolved":false,"context_lines":[{"line_number":1628,"context_line":""},{"line_number":1629,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":1630,"context_line":"    def update_volume_connector(self, context, connector):"},{"line_number":1631,"context_line":"        \"\"\"Update a port."},{"line_number":1632,"context_line":""},{"line_number":1633,"context_line":"        :param context: request context."},{"line_number":1634,"context_line":"        :param connector: a changed (but not saved) volume connector object."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_f5a1e494","line":1631,"in_reply_to":"fa1b9901_2f5aabf2","updated":"2015-08-21 01:08:16.000000000","message":"Done","commit_id":"8a0c49b3e25d9e26670886a9829f8d2284dceb42"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"60bc220e1c25fa413e602bd34134911b2199bd4d","unresolved":false,"context_lines":[{"line_number":1839,"context_line":"        \"\"\"Update a volume connector."},{"line_number":1840,"context_line":""},{"line_number":1841,"context_line":"        :param context: request context."},{"line_number":1842,"context_line":"        :param connector: a changed (but not saved) volume connector object."},{"line_number":1843,"context_line":"        \"\"\""},{"line_number":1844,"context_line":"        connector_uuid \u003d connector.uuid"},{"line_number":1845,"context_line":"        LOG.debug(\"RPC update_volume_connector called for connector %s.\","},{"line_number":1846,"context_line":"                  connector_uuid)"}],"source_content_type":"text/x-python","patch_set":17,"id":"bae84128_7c867d14","line":1843,"range":{"start_line":1842,"start_character":8,"end_line":1843,"end_character":11},"updated":"2016-02-25 06:28:05.000000000","message":":raises: NodeLocked is missing because of 1837.\n:returns: is missing because of L. 1852.","commit_id":"618d52c18c4997349b693471191d81e9ce805cdd"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"392592e472eb95fa38330c1a2cc6bf979f8a5c2b","unresolved":false,"context_lines":[{"line_number":1839,"context_line":"        \"\"\"Update a volume connector."},{"line_number":1840,"context_line":""},{"line_number":1841,"context_line":"        :param context: request context."},{"line_number":1842,"context_line":"        :param connector: a changed (but not saved) volume connector object."},{"line_number":1843,"context_line":"        \"\"\""},{"line_number":1844,"context_line":"        connector_uuid \u003d connector.uuid"},{"line_number":1845,"context_line":"        LOG.debug(\"RPC update_volume_connector called for connector %s.\","},{"line_number":1846,"context_line":"                  connector_uuid)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_6ee8887d","line":1843,"range":{"start_line":1842,"start_character":8,"end_line":1843,"end_character":11},"in_reply_to":"bae84128_7c867d14","updated":"2016-02-26 03:50:37.000000000","message":"Done","commit_id":"618d52c18c4997349b693471191d81e9ce805cdd"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"abdeeaabbec4c07b277642b4f3f666218363846e","unresolved":false,"context_lines":[{"line_number":1829,"context_line":""},{"line_number":1830,"context_line":"            return portgroup_obj"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":1833,"context_line":"    def update_volume_connector(self, context, connector):"},{"line_number":1834,"context_line":"        \"\"\"Update a volume connector."},{"line_number":1835,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1af94dfe_4b00ba01","line":1832,"range":{"start_line":1832,"start_character":55,"end_line":1832,"end_character":56},"updated":"2016-03-17 09:55:03.000000000","message":"VolumeConnectorValueAlreadyExists, .VolumeConnectorNotFound","commit_id":"d928335656b90196ab69c714fdd7a02e775dc0c9"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"abdeeaabbec4c07b277642b4f3f666218363846e","unresolved":false,"context_lines":[{"line_number":1836,"context_line":"        :param context: request context."},{"line_number":1837,"context_line":"        :param connector: a changed (but not saved) volume connector object."},{"line_number":1838,"context_line":"        :returns: a updated volume connector object."},{"line_number":1839,"context_line":"        :raises: NodeLocked if the node is already locked."},{"line_number":1840,"context_line":"        \"\"\""},{"line_number":1841,"context_line":"        connector_uuid \u003d connector.uuid"},{"line_number":1842,"context_line":"        LOG.debug(\"RPC update_volume_connector called for connector %s.\","}],"source_content_type":"text/x-python","patch_set":20,"id":"1af94dfe_283574f6","line":1839,"range":{"start_line":1839,"start_character":57,"end_line":1839,"end_character":58},"updated":"2016-03-17 09:55:03.000000000","message":"VolumeConnectorValueAlreadyExists, .VolumeConnectorNotFound","commit_id":"d928335656b90196ab69c714fdd7a02e775dc0c9"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"155fcb9d3540b99bade8e9a621f3a47259d486e8","unresolved":false,"context_lines":[{"line_number":1600,"context_line":"                 not exist."},{"line_number":1601,"context_line":""},{"line_number":1602,"context_line":"        \"\"\""},{"line_number":1603,"context_line":"        LOG.debug(\u0027RPC destroy_volume_connector called for volume connector\u0027"},{"line_number":1604,"context_line":"                  \u0027%(connector)s\u0027,"},{"line_number":1605,"context_line":"                  {\u0027connector\u0027: connector.uuid})"},{"line_number":1606,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1607,"context_line":"                                  purpose\u003d\u0027volume connector deletion\u0027) as task:"}],"source_content_type":"text/x-python","patch_set":21,"id":"bab6814e_efdd6b43","line":1604,"range":{"start_line":1603,"start_character":75,"end_line":1604,"end_character":19},"updated":"2016-05-19 11:04:45.000000000","message":"there has to be a space in b/w","commit_id":"a45ce55354051fb2a4f76bcf83479fe7c741ba02"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d6d512a95566171a159314ce8262162568113f60","unresolved":false,"context_lines":[{"line_number":1600,"context_line":"                 not exist."},{"line_number":1601,"context_line":""},{"line_number":1602,"context_line":"        \"\"\""},{"line_number":1603,"context_line":"        LOG.debug(\u0027RPC destroy_volume_connector called for volume connector\u0027"},{"line_number":1604,"context_line":"                  \u0027%(connector)s\u0027,"},{"line_number":1605,"context_line":"                  {\u0027connector\u0027: connector.uuid})"},{"line_number":1606,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1607,"context_line":"                                  purpose\u003d\u0027volume connector deletion\u0027) as task:"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_e4fb45bf","line":1604,"range":{"start_line":1603,"start_character":75,"end_line":1604,"end_character":19},"in_reply_to":"bab6814e_efdd6b43","updated":"2016-06-14 15:13:41.000000000","message":"Done","commit_id":"a45ce55354051fb2a4f76bcf83479fe7c741ba02"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"155fcb9d3540b99bade8e9a621f3a47259d486e8","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"                  \u0027%(connector)s\u0027,"},{"line_number":1605,"context_line":"                  {\u0027connector\u0027: connector.uuid})"},{"line_number":1606,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1607,"context_line":"                                  purpose\u003d\u0027volume connector deletion\u0027) as task:"},{"line_number":1608,"context_line":"            connector.destroy()"},{"line_number":1609,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume connector\u0027"},{"line_number":1610,"context_line":"                         \u0027%(connector)s. \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"bab6814e_4f4597b1","line":1607,"updated":"2016-05-19 11:04:45.000000000","message":"IIRC there were some conditions/states mentioned in the spec during which the volume connector cannot be deleted. If I\u0027am right, then I dont see thsoe checks here. Please verify.","commit_id":"a45ce55354051fb2a4f76bcf83479fe7c741ba02"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d6d512a95566171a159314ce8262162568113f60","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"                  \u0027%(connector)s\u0027,"},{"line_number":1605,"context_line":"                  {\u0027connector\u0027: connector.uuid})"},{"line_number":1606,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1607,"context_line":"                                  purpose\u003d\u0027volume connector deletion\u0027) as task:"},{"line_number":1608,"context_line":"            connector.destroy()"},{"line_number":1609,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume connector\u0027"},{"line_number":1610,"context_line":"                         \u0027%(connector)s. \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_5f3946a3","line":1607,"in_reply_to":"bab6814e_4f4597b1","updated":"2016-06-14 15:13:41.000000000","message":"I\u0027ve looked through the specification and I don\u0027t see an explicit list of states where the connector can be deleted.  The restriction appears to be on target information: https://review.openstack.org/#/c/200496/38/specs/approved/volume-connection-information.rst@506","commit_id":"a45ce55354051fb2a4f76bcf83479fe7c741ba02"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"155fcb9d3540b99bade8e9a621f3a47259d486e8","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1607,"context_line":"                                  purpose\u003d\u0027volume connector deletion\u0027) as task:"},{"line_number":1608,"context_line":"            connector.destroy()"},{"line_number":1609,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume connector\u0027"},{"line_number":1610,"context_line":"                         \u0027%(connector)s. \u0027"},{"line_number":1611,"context_line":"                         \u0027The node associated with the connector was \u0027"},{"line_number":1612,"context_line":"                         \u0027%(node)s\u0027),"}],"source_content_type":"text/x-python","patch_set":21,"id":"bab6814e_6f77bb3a","line":1609,"range":{"start_line":1609,"start_character":63,"end_line":1609,"end_character":64},"updated":"2016-05-19 11:04:45.000000000","message":"no space","commit_id":"a45ce55354051fb2a4f76bcf83479fe7c741ba02"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d6d512a95566171a159314ce8262162568113f60","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1607,"context_line":"                                  purpose\u003d\u0027volume connector deletion\u0027) as task:"},{"line_number":1608,"context_line":"            connector.destroy()"},{"line_number":1609,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume connector\u0027"},{"line_number":1610,"context_line":"                         \u0027%(connector)s. \u0027"},{"line_number":1611,"context_line":"                         \u0027The node associated with the connector was \u0027"},{"line_number":1612,"context_line":"                         \u0027%(node)s\u0027),"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_a4249d5f","line":1609,"range":{"start_line":1609,"start_character":63,"end_line":1609,"end_character":64},"in_reply_to":"bab6814e_6f77bb3a","updated":"2016-06-14 15:13:41.000000000","message":"Done","commit_id":"a45ce55354051fb2a4f76bcf83479fe7c741ba02"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"155fcb9d3540b99bade8e9a621f3a47259d486e8","unresolved":false,"context_lines":[{"line_number":1842,"context_line":"                  connector_uuid)"},{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1845,"context_line":"                                  purpose\u003d\u0027volume connector update\u0027):"},{"line_number":1846,"context_line":"            connector.save()"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"            return connector"}],"source_content_type":"text/x-python","patch_set":21,"id":"bab6814e_4f2bd794","line":1845,"updated":"2016-05-19 11:04:45.000000000","message":"Please verify the conditions as stated in my above comment:\nhttps://review.openstack.org/#/c/214585/21/ironic/conductor/manager.py@1607","commit_id":"a45ce55354051fb2a4f76bcf83479fe7c741ba02"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d6d512a95566171a159314ce8262162568113f60","unresolved":false,"context_lines":[{"line_number":1842,"context_line":"                  connector_uuid)"},{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1845,"context_line":"                                  purpose\u003d\u0027volume connector update\u0027):"},{"line_number":1846,"context_line":"            connector.save()"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"            return connector"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_3f639ab2","line":1845,"in_reply_to":"bab6814e_4f2bd794","updated":"2016-06-14 15:13:41.000000000","message":"See reply above.","commit_id":"a45ce55354051fb2a4f76bcf83479fe7c741ba02"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"155fcb9d3540b99bade8e9a621f3a47259d486e8","unresolved":false,"context_lines":[{"line_number":1844,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1845,"context_line":"                                  purpose\u003d\u0027volume connector update\u0027):"},{"line_number":1846,"context_line":"            connector.save()"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"            return connector"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"    @messaging.expected_exceptions(exception.DriverNotFound)"}],"source_content_type":"text/x-python","patch_set":21,"id":"bab6814e_c102fb08","line":1847,"updated":"2016-05-19 11:04:45.000000000","message":"Info log missing.","commit_id":"a45ce55354051fb2a4f76bcf83479fe7c741ba02"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d6d512a95566171a159314ce8262162568113f60","unresolved":false,"context_lines":[{"line_number":1844,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1845,"context_line":"                                  purpose\u003d\u0027volume connector update\u0027):"},{"line_number":1846,"context_line":"            connector.save()"},{"line_number":1847,"context_line":""},{"line_number":1848,"context_line":"            return connector"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"    @messaging.expected_exceptions(exception.DriverNotFound)"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_1f1fbeb7","line":1847,"in_reply_to":"bab6814e_c102fb08","updated":"2016-06-14 15:13:41.000000000","message":"Done","commit_id":"a45ce55354051fb2a4f76bcf83479fe7c741ba02"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4aedade4359d11528777f9a8d1b373f8e2d9535b","unresolved":false,"context_lines":[{"line_number":1547,"context_line":"                         \u0027%(node)s\u0027),"},{"line_number":1548,"context_line":"                     {\u0027portgroup\u0027: portgroup.uuid, \u0027node\u0027: task.node.uuid})"},{"line_number":1549,"context_line":""},{"line_number":1550,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":1551,"context_line":"                                   exception.NodeNotFound)"},{"line_number":1552,"context_line":"    def destroy_volume_connector(self, context, connector):"},{"line_number":1553,"context_line":"        \"\"\"Delete a volume connector."}],"source_content_type":"text/x-python","patch_set":40,"id":"fa7ab95a_f0a15eaa","line":1550,"updated":"2016-09-02 14:00:32.000000000","message":"Don\u0027t we need to add @METRICS.timer like other methods?","commit_id":"eee69369701f8618c47289a61d167b64425670a8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4aedade4359d11528777f9a8d1b373f8e2d9535b","unresolved":false,"context_lines":[{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"            return portgroup_obj"},{"line_number":1871,"context_line":""},{"line_number":1872,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":1873,"context_line":"    def update_volume_connector(self, context, connector):"},{"line_number":1874,"context_line":"        \"\"\"Update a volume connector."},{"line_number":1875,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa7ab95a_50adaa99","line":1872,"updated":"2016-09-02 14:00:32.000000000","message":"ditto","commit_id":"eee69369701f8618c47289a61d167b64425670a8"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"e0bd586ada59047edb2da2641dc4cc45617b4217","unresolved":false,"context_lines":[{"line_number":1546,"context_line":"        :param context: request context."},{"line_number":1547,"context_line":"        :param connector: volume connector object"},{"line_number":1548,"context_line":"        :raises: NodeLocked if node is locked by another conductor."},{"line_number":1549,"context_line":"        :raises: NodeNotFound if the node associated with the connector does"},{"line_number":1550,"context_line":"                 not exist."},{"line_number":1551,"context_line":""},{"line_number":1552,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":49,"id":"ba5da102_343b5b9e","line":1549,"updated":"2016-11-04 17:02:27.000000000","message":"How is this possible? Whenever a node is deleted, all its volume connectors are also deleted (see L385 here: https://review.openstack.org/#/c/200983/48/ironic/db/sqlalchemy/api.py)\n\nIf this is possible, I\u0027d like a unit test added for this case","commit_id":"0e507059a080d37a8c1f85df7eef09677329679f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"58a177e800999fe5129bcf30868c15c1a106f7cc","unresolved":false,"context_lines":[{"line_number":1859,"context_line":"            return portgroup_obj"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"    @METRICS.timer(\u0027ConductorManager.update_volume_connector\u0027)"},{"line_number":1862,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":1863,"context_line":"    def update_volume_connector(self, context, connector):"},{"line_number":1864,"context_line":"        \"\"\"Update a volume connector."},{"line_number":1865,"context_line":""}],"source_content_type":"text/x-python","patch_set":54,"id":"5a74a57a_80ddc572","line":1862,"updated":"2016-11-23 12:49:15.000000000","message":"VolumeConnectorConnectorIdAlreadyExists and VolumeConnectorNotFound right (looking at the dbapi)? Maybe no need to add InvalidParameterValue as we can validate it on the api side.","commit_id":"a3bd12e27d4b3f189d1e6297e274ea930ea004b4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"539a20aacda9f0230892e09525df6c5ff1fdc117","unresolved":false,"context_lines":[{"line_number":1859,"context_line":"            return portgroup_obj"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"    @METRICS.timer(\u0027ConductorManager.update_volume_connector\u0027)"},{"line_number":1862,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":1863,"context_line":"    def update_volume_connector(self, context, connector):"},{"line_number":1864,"context_line":"        \"\"\"Update a volume connector."},{"line_number":1865,"context_line":""}],"source_content_type":"text/x-python","patch_set":54,"id":"5a74a57a_4372b2ae","line":1862,"in_reply_to":"5a74a57a_80ddc572","updated":"2016-11-24 03:14:11.000000000","message":"I added them all including the InvalidParameterValue (don\u0027t want to assume that the API handles it)","commit_id":"a3bd12e27d4b3f189d1e6297e274ea930ea004b4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4006375c68531c33cd779f39e292a798ac7e903a","unresolved":false,"context_lines":[{"line_number":1890,"context_line":""},{"line_number":1891,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1892,"context_line":"                                  purpose\u003d\u0027volume connector update\u0027):"},{"line_number":1893,"context_line":"            connector.save()"},{"line_number":1894,"context_line":"            LOG.info(_LI(\"Successfully updated volume connector \""},{"line_number":1895,"context_line":"                         \"%(connector)s.\"),"},{"line_number":1896,"context_line":"                     {\u0027connector\u0027: connector.uuid})"}],"source_content_type":"text/x-python","patch_set":57,"id":"5a74a57a_a3e626b2","line":1893,"updated":"2016-11-24 03:40:16.000000000","message":"before I forget. We don\u0027t allow the user to modify the uuid. What about node_id? Only if the node is in certain states?","commit_id":"e88d80689a3cd447a21421633c770b41ade60337"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6f621458fad368697a327f8b56350cda9d2feb0c","unresolved":false,"context_lines":[{"line_number":1890,"context_line":""},{"line_number":1891,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1892,"context_line":"                                  purpose\u003d\u0027volume connector update\u0027):"},{"line_number":1893,"context_line":"            connector.save()"},{"line_number":1894,"context_line":"            LOG.info(_LI(\"Successfully updated volume connector \""},{"line_number":1895,"context_line":"                         \"%(connector)s.\"),"},{"line_number":1896,"context_line":"                     {\u0027connector\u0027: connector.uuid})"}],"source_content_type":"text/x-python","patch_set":57,"id":"5a74a57a_815c347e","line":1893,"in_reply_to":"5a74a57a_5907c317","updated":"2016-11-28 20:21:09.000000000","message":"Thx Julia.","commit_id":"e88d80689a3cd447a21421633c770b41ade60337"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e02b3fc40abf775035703d0b7f1b8d5a0914245","unresolved":false,"context_lines":[{"line_number":1890,"context_line":""},{"line_number":1891,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1892,"context_line":"                                  purpose\u003d\u0027volume connector update\u0027):"},{"line_number":1893,"context_line":"            connector.save()"},{"line_number":1894,"context_line":"            LOG.info(_LI(\"Successfully updated volume connector \""},{"line_number":1895,"context_line":"                         \"%(connector)s.\"),"},{"line_number":1896,"context_line":"                     {\u0027connector\u0027: connector.uuid})"}],"source_content_type":"text/x-python","patch_set":57,"id":"5a74a57a_5907c317","line":1893,"in_reply_to":"5a74a57a_a3e626b2","updated":"2016-11-25 15:00:09.000000000","message":"Realistically, we should allow updates of connectors at any time, although the change just won\u0027t become effective until the node is power cycled with the storage interface work.  It is targets we need to be careful about.\n\nAs for node_id.  I think it is fine as is.  We have consistency with ports by using node_id, which the API looks up and sets for the user visible uuid mapping.  It then becomes more of a question where do we want to do the lookup, and since we currently do it in the API, I would prefer consistency of that moving forward until we change it all at one time, as opposed to changing connectors or targets, and maybe one day getting to the rest.","commit_id":"e88d80689a3cd447a21421633c770b41ade60337"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"abdeeaabbec4c07b277642b4f3f666218363846e","unresolved":false,"context_lines":[{"line_number":749,"context_line":"        :param connector: a changed (but not saved) volume connector object."},{"line_number":750,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":751,"context_line":"        :returns: updated volume connector object, including all fields."},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        \"\"\""},{"line_number":754,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.34\u0027)"},{"line_number":755,"context_line":"        return cctxt.call(context, \u0027update_volume_connector\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1af94dfe_cb420a3e","line":752,"range":{"start_line":752,"start_character":0,"end_line":752,"end_character":0},"updated":"2016-03-17 09:55:03.000000000","message":"add possible exceptions here.","commit_id":"d928335656b90196ab69c714fdd7a02e775dc0c9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"e0bd586ada59047edb2da2641dc4cc45617b4217","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        :param connector: a changed (but not saved) volume connector object."},{"line_number":763,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":764,"context_line":"        :returns: updated volume connector object, including all fields."},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"        \"\"\""},{"line_number":767,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.35\u0027)"},{"line_number":768,"context_line":"        return cctxt.call(context, \u0027update_volume_connector\u0027,"}],"source_content_type":"text/x-python","patch_set":49,"id":"ba5da102_d4b85f2d","line":765,"updated":"2016-11-04 17:02:27.000000000","message":"This can also raise a NodeLocked exception like destroy_volume_connector","commit_id":"0e507059a080d37a8c1f85df7eef09677329679f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"58a177e800999fe5129bcf30868c15c1a106f7cc","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                          connector\u003dconnector)"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    def update_volume_connector(self, context, connector, topic\u003dNone):"},{"line_number":755,"context_line":"        \"\"\"Synchronously, have a conductor update the connector\u0027s information."},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"        Update the volume connector\u0027s information in the database and return"},{"line_number":758,"context_line":"        a volume connector object. The conductor will lock related node and"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a74a57a_0588e721","line":755,"range":{"start_line":755,"start_character":11,"end_line":755,"end_character":24},"updated":"2016-11-23 12:49:15.000000000","message":"Why do you mention synchronously here? destroy is synchronous too.","commit_id":"a3bd12e27d4b3f189d1e6297e274ea930ea004b4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"539a20aacda9f0230892e09525df6c5ff1fdc117","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                          connector\u003dconnector)"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    def update_volume_connector(self, context, connector, topic\u003dNone):"},{"line_number":755,"context_line":"        \"\"\"Synchronously, have a conductor update the connector\u0027s information."},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"        Update the volume connector\u0027s information in the database and return"},{"line_number":758,"context_line":"        a volume connector object. The conductor will lock related node and"}],"source_content_type":"text/x-python","patch_set":54,"id":"5a74a57a_a3baa621","line":755,"range":{"start_line":755,"start_character":11,"end_line":755,"end_character":24},"in_reply_to":"5a74a57a_0588e721","updated":"2016-11-24 03:14:11.000000000","message":"I\u0027m guessing because they cut/paste from some existing function. Early on, someone added \u0027Synchronously\u0027 to some of the function descriptions. I removed it.","commit_id":"a3bd12e27d4b3f189d1e6297e274ea930ea004b4"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"abdeeaabbec4c07b277642b4f3f666218363846e","unresolved":false,"context_lines":[{"line_number":4811,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":4812,"context_line":"        self.assertEqual(exception.NodeLocked, exc.exc_info[0])"},{"line_number":4813,"context_line":""},{"line_number":4814,"context_line":"    def test_update_volume_connector_type(self):"},{"line_number":4815,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"},{"line_number":4816,"context_line":"        volume_connector \u003d obj_utils.create_test_volume_connector("},{"line_number":4817,"context_line":"            self.context, node_id\u003dnode.id, extra\u003d{\u0027vol_id\u0027: \u0027fake-id\u0027})"}],"source_content_type":"text/x-python","patch_set":20,"id":"1af94dfe_cbcfaa7d","line":4814,"range":{"start_line":4814,"start_character":8,"end_line":4814,"end_character":41},"updated":"2016-03-17 09:55:03.000000000","message":"missing test case for update volume_connector_type_value_already_exist.","commit_id":"d928335656b90196ab69c714fdd7a02e775dc0c9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"aad0e7401fc22c57ea0ccf3c4eec5096a0a75513","unresolved":false,"context_lines":[{"line_number":4904,"context_line":"    def test_update_volume_connector_type(self):"},{"line_number":4905,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"},{"line_number":4906,"context_line":"        volume_connector \u003d obj_utils.create_test_volume_connector("},{"line_number":4907,"context_line":"            self.context, node_id\u003dnode.id, extra\u003d{\u0027vol_id\u0027: \u0027fake-id\u0027})"},{"line_number":4908,"context_line":"        new_type \u003d \u0027wwnn\u0027"},{"line_number":4909,"context_line":"        volume_connector.type \u003d new_type"},{"line_number":4910,"context_line":"        res \u003d self.service.update_volume_connector(self.context,"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_c6a8ee79","line":4907,"range":{"start_line":4907,"start_character":51,"end_line":4907,"end_character":57},"updated":"2016-07-20 20:46:43.000000000","message":"not defined in the spec but it is in extra so *shrug*","commit_id":"f7247b93f415ca9e1559410232d9356ec2b419b6"}],"ironic/tests/unit/conductor/test_rpcapi.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"abdeeaabbec4c07b277642b4f3f666218363846e","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                          portgroup\u003dself.fake_portgroup)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def test_destroy_volume_connector(self):"},{"line_number":398,"context_line":"        fake_volume_connector \u003d dbutils.get_test_volume_connector()"},{"line_number":399,"context_line":"        self._test_rpcapi(\u0027destroy_volume_connector\u0027,"},{"line_number":400,"context_line":"                          \u0027call\u0027,"},{"line_number":401,"context_line":"                          version\u003d\u00271.34\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1af94dfe_2b3bae9d","line":398,"range":{"start_line":398,"start_character":8,"end_line":398,"end_character":67},"updated":"2016-03-17 09:55:03.000000000","message":"move this to setUp(), then we don\u0027t have to do it in every volume connector test case.","commit_id":"d928335656b90196ab69c714fdd7a02e775dc0c9"}]}
