)]}'
{"doc/source/deploy/notifications.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6bf074d8943fdaf1d2e2b3ed78449f29782f4d99","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    \"publisher_id\":\"ironic-api.hostname02\""},{"line_number":286,"context_line":"   }"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"List of CRUD notifications for volume taraget:"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"* ``baremetal.volumetarget.create.start``"},{"line_number":291,"context_line":"* ``baremetal.volumetarget.create.end``"}],"source_content_type":"text/x-rst","patch_set":95,"id":"5f201791_012e04fa","line":288,"updated":"2017-06-27 19:41:07.000000000","message":"nit, s/taraget/target/","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    \"publisher_id\":\"ironic-api.hostname02\""},{"line_number":286,"context_line":"   }"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"List of CRUD notifications for volume taraget:"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"* ``baremetal.volumetarget.create.start``"},{"line_number":291,"context_line":"* ``baremetal.volumetarget.create.end``"}],"source_content_type":"text/x-rst","patch_set":95,"id":"5f201791_a96e0afd","line":288,"in_reply_to":"5f201791_012e04fa","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e9f095c79b818404ca47edc57cabc946a0fe2","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    \"publisher_id\":\"ironic-api.hostname02\""},{"line_number":252,"context_line":"   }"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"List of CRUD notifications for volume connector:"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"* ``baremetal.volumeconnector.create.start``"},{"line_number":257,"context_line":"* ``baremetal.volumeconnector.create.end``"}],"source_content_type":"text/x-rst","patch_set":99,"id":"3f1d235d_88bbdc70","line":254,"updated":"2017-07-02 11:07:01.000000000","message":"this looks unrelated to the topic, but dunno","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    \"publisher_id\":\"ironic-api.hostname02\""},{"line_number":252,"context_line":"   }"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"List of CRUD notifications for volume connector:"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"* ``baremetal.volumeconnector.create.start``"},{"line_number":257,"context_line":"* ``baremetal.volumeconnector.create.end``"}],"source_content_type":"text/x-rst","patch_set":99,"id":"3f1d235d_750e0d8e","line":254,"in_reply_to":"3f1d235d_88bbdc70","updated":"2017-07-03 06:56:14.000000000","message":"I thought it might be useful that notifications get available at the same time that the API gets available. But, I\u0027m fine with splitting notifications if necessary.","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"53956aebca394e3ff57fe8728c7ff970985ae0ce","unresolved":false,"context_lines":[{"line_number":399,"context_line":"------------------------------"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"Node console notifications"},{"line_number":402,"context_line":"------------------------------"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"These notifications are emitted by the ironic-conductor service when conductor"},{"line_number":405,"context_line":"service starts or stops console for the node. The notification event types for"}],"source_content_type":"text/x-rst","patch_set":101,"id":"3f1d235d_ab59ba35","line":402,"range":{"start_line":402,"start_character":26,"end_line":402,"end_character":30},"updated":"2017-07-04 13:49:08.000000000","message":"nit: excess - characters?","commit_id":"c380e05dbf84079b01fb3b0ea099ef9b293b9b3d"}],"doc/source/dev/webapi-version-history.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6bf074d8943fdaf1d2e2b3ed78449f29782f4d99","unresolved":false,"context_lines":[{"line_number":5,"context_line":"**1.32** (Pike)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Added the ``/v1/volume/connectors`` endpoints and node"},{"line_number":8,"context_line":"    ``volume/connectors`` field."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Added the ``/v1/volume/targets`` endpoints and node ``volume/targets``"},{"line_number":11,"context_line":"    field."}],"source_content_type":"text/x-rst","patch_set":95,"id":"5f201791_01f3a475","line":8,"updated":"2017-06-27 19:41:07.000000000","message":"not sure what a node \u0027volume/connectors\u0027 field means.","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":5,"context_line":"**1.32** (Pike)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Added the ``/v1/volume/connectors`` endpoints and node"},{"line_number":8,"context_line":"    ``volume/connectors`` field."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Added the ``/v1/volume/targets`` endpoints and node ``volume/targets``"},{"line_number":11,"context_line":"    field."}],"source_content_type":"text/x-rst","patch_set":95,"id":"5f201791_144e36c0","line":8,"in_reply_to":"5f201791_01f3a475","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6bf074d8943fdaf1d2e2b3ed78449f29782f4d99","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    ``volume/connectors`` field."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Added the ``/v1/volume/targets`` endpoints and node ``volume/targets``"},{"line_number":11,"context_line":"    field."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"**1.31** (Ocata)"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":95,"id":"5f201791_a1a07043","line":11,"updated":"2017-06-27 19:41:07.000000000","message":"Do we want to add more information? (Just wondering). Eg, GET/POST/DELETE? (I haven\u0027t yet looked at the code).","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    ``volume/connectors`` field."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Added the ``/v1/volume/targets`` endpoints and node ``volume/targets``"},{"line_number":11,"context_line":"    field."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"**1.31** (Ocata)"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":95,"id":"5f201791_74d20ad3","line":11,"in_reply_to":"5f201791_a1a07043","updated":"2017-06-28 08:00:14.000000000","message":"I agree. I added description.","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9b30d7ba92d7e0b28192c7d0c273a077455ea5b6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    * GET /v1/nodes/\u003cnode identifier\u003e/volume"},{"line_number":24,"context_line":"    * GET /v1/nodes/\u003cnode identifier\u003e/volume/connectors"},{"line_number":25,"context_line":"    * GET /v1/nodes/\u003cnode identifier\u003e/volume/targets"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"**1.31** (Ocata)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    Added the following fields to the node object, to allow getting and"}],"source_content_type":"text/x-rst","patch_set":96,"id":"5f201791_d238b3d3","line":26,"updated":"2017-06-28 20:58:41.000000000","message":"I do really like the verbose listing here. :)","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"4d546b2606d74ad8823364ba3d791b8dec7e8124","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Added new endpoints for remote volume configuration:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * GET /v1/volume as a root for volume resources"},{"line_number":10,"context_line":"    * GET /v1/volume/connectors for listing volume connectors"},{"line_number":11,"context_line":"    * POST /v1/volume/connectors for creating a volume connector"},{"line_number":12,"context_line":"    * GET /v1/volume/connectors/\u003cUUID\u003e for showing a volume connector"}],"source_content_type":"text/x-rst","patch_set":101,"id":"3f1d235d_68d612c6","line":9,"updated":"2017-07-04 10:29:58.000000000","message":"might be worth clarifying that the response only contains the links.","commit_id":"c380e05dbf84079b01fb3b0ea099ef9b293b9b3d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"53956aebca394e3ff57fe8728c7ff970985ae0ce","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Added new endpoints for remote volume configuration:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * GET /v1/volume as a root for volume resources"},{"line_number":10,"context_line":"    * GET /v1/volume/connectors for listing volume connectors"},{"line_number":11,"context_line":"    * POST /v1/volume/connectors for creating a volume connector"},{"line_number":12,"context_line":"    * GET /v1/volume/connectors/\u003cUUID\u003e for showing a volume connector"}],"source_content_type":"text/x-rst","patch_set":101,"id":"3f1d235d_f9966bf0","line":9,"in_reply_to":"3f1d235d_68d612c6","updated":"2017-07-04 13:49:08.000000000","message":"+1","commit_id":"c380e05dbf84079b01fb3b0ea099ef9b293b9b3d"}],"doc/source/webapi/v1.rst":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":33,"context_line":"--------------------"},{"line_number":34,"context_line":"**1.17**"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Add the ``/v1/volume_connectors`` endpoints and node ``volume_connectors``"},{"line_number":37,"context_line":"    field."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"**1.16**"}],"source_content_type":"text/x-rst","patch_set":24,"id":"dada55a8_8b7b5fbd","line":36,"range":{"start_line":36,"start_character":18,"end_line":36,"end_character":35},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors according to the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":254,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":".. rest-controller:: ironic.api.controllers.v1.volume_connector:VolumeConnectorsController"},{"line_number":257,"context_line":"   :webprefix: /v1/volume_connectors"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":".. autotype:: ironic.api.controllers.v1.volume_connector.VolumeConnectorCollection"},{"line_number":260,"context_line":"   :members:"}],"source_content_type":"text/x-rst","patch_set":24,"id":"dada55a8_6b28ab9a","line":257,"range":{"start_line":257,"start_character":19,"end_line":257,"end_character":36},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors according to the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"}],"ironic/api/controllers/v1/__init__.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from ironic.api.controllers.v1 import node"},{"line_number":31,"context_line":"from ironic.api.controllers.v1 import port"},{"line_number":32,"context_line":"from ironic.api.controllers.v1 import versions"},{"line_number":33,"context_line":"from ironic.api.controllers.v1 import volume_connector"},{"line_number":34,"context_line":"from ironic.api import expose"},{"line_number":35,"context_line":"from ironic.common.i18n import _"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_cb36f701","line":33,"updated":"2016-07-21 21:20:43.000000000","message":"Spec calls for volume/connectors, so likely this will need some restructuring. :(","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    drivers \u003d [link.Link]"},{"line_number":80,"context_line":"    \"\"\"Links to the drivers resource\"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    volume_connectors \u003d [link.Link]"},{"line_number":83,"context_line":"    \"\"\"Links to the volume connectors resource\"\"\""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_6b0f0b37","line":82,"updated":"2016-07-21 21:20:43.000000000","message":"I think this will need to be volume, and then connectors and targets built inside of it.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                                          \u0027drivers\u0027, \u0027\u0027,"},{"line_number":125,"context_line":"                                          bookmark\u003dTrue)"},{"line_number":126,"context_line":"                      ]"},{"line_number":127,"context_line":"        v1.volume_connectors \u003d [link.Link.make_link(\u0027self\u0027,"},{"line_number":128,"context_line":"                                                    pecan.request.public_url,"},{"line_number":129,"context_line":"                                                    \u0027volume_connectors\u0027, \u0027\u0027),"},{"line_number":130,"context_line":"                                link.Link.make_link(\u0027bookmark\u0027,"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_8b007f03","line":127,"range":{"start_line":127,"start_character":11,"end_line":127,"end_character":29},"updated":"2016-07-21 21:20:43.000000000","message":"needs to be refactored :(","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    ports \u003d port.PortsController()"},{"line_number":143,"context_line":"    chassis \u003d chassis.ChassisController()"},{"line_number":144,"context_line":"    drivers \u003d driver.DriversController()"},{"line_number":145,"context_line":"    volume_connectors \u003d volume_connector.VolumeConnectorsController()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @expose.expose(V1)"},{"line_number":148,"context_line":"    def get(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_0e0bfd24","line":145,"updated":"2016-07-21 21:20:43.000000000","message":"refactoring required","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    heartbeat \u003d [link.Link]"},{"line_number":92,"context_line":"    \"\"\"Links to the heartbeat resource\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    volume \u003d [link.Link]"},{"line_number":95,"context_line":"    \"\"\"Links to the volume resource\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_adaa04cf","line":94,"updated":"2017-04-03 22:16:26.000000000","message":"It would be better to place it under drivers or chassis\n(please see ln 183 comments).\nAlso - I think it will be more compliant if the resource name is plural - volumes","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    heartbeat \u003d [link.Link]"},{"line_number":92,"context_line":"    \"\"\"Links to the heartbeat resource\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    volume \u003d [link.Link]"},{"line_number":95,"context_line":"    \"\"\"Links to the volume resource\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_da0cc9a6","line":94,"in_reply_to":"dfeb2761_adaa04cf","updated":"2017-04-05 16:04:08.000000000","message":"As a result of reconsideration, I added links to volume_connectors and volume_targets instead of volume.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        if utils.allow_volume():"},{"line_number":163,"context_line":"            v1.volume \u003d [link.Link.make_link(\u0027self\u0027,"},{"line_number":164,"context_line":"                                             pecan.request.public_url,"},{"line_number":165,"context_line":"                                             \u0027volume\u0027, \u0027\u0027),"},{"line_number":166,"context_line":"                         link.Link.make_link(\u0027bookmark\u0027,"},{"line_number":167,"context_line":"                                             pecan.request.public_url,"},{"line_number":168,"context_line":"                                             \u0027volume\u0027, \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_cd98a8c1","line":165,"updated":"2017-04-03 22:16:26.000000000","message":"I think plural \u0027volumes\u0027 would be better.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        if utils.allow_volume():"},{"line_number":163,"context_line":"            v1.volume \u003d [link.Link.make_link(\u0027self\u0027,"},{"line_number":164,"context_line":"                                             pecan.request.public_url,"},{"line_number":165,"context_line":"                                             \u0027volume\u0027, \u0027\u0027),"},{"line_number":166,"context_line":"                         link.Link.make_link(\u0027bookmark\u0027,"},{"line_number":167,"context_line":"                                             pecan.request.public_url,"},{"line_number":168,"context_line":"                                             \u0027volume\u0027, \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_5a3d5929","line":165,"in_reply_to":"dfeb2761_cd98a8c1","updated":"2017-04-05 16:04:08.000000000","message":"ditto","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    drivers \u003d driver.DriversController()"},{"line_number":181,"context_line":"    lookup \u003d ramdisk.LookupController()"},{"line_number":182,"context_line":"    heartbeat \u003d ramdisk.HeartbeatController()"},{"line_number":183,"context_line":"    volume \u003d volume.VolumeController()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @expose.expose(V1)"},{"line_number":186,"context_line":"    def get(self):"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_2d9f14b5","line":183,"updated":"2017-04-03 22:16:26.000000000","message":"this line should be placed above IPA endpoints (e.g. line 180)","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    drivers \u003d driver.DriversController()"},{"line_number":181,"context_line":"    lookup \u003d ramdisk.LookupController()"},{"line_number":182,"context_line":"    heartbeat \u003d ramdisk.HeartbeatController()"},{"line_number":183,"context_line":"    volume \u003d volume.VolumeController()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @expose.expose(V1)"},{"line_number":186,"context_line":"    def get(self):"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_f708d6d9","line":183,"in_reply_to":"dfeb2761_2d9f14b5","updated":"2017-04-05 16:04:08.000000000","message":"Done","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"a4d9680567394aa94d04c82f15e18ff462cac0a8","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            v1.volume_connectors \u003d ["},{"line_number":151,"context_line":"                link.Link.make_link(\u0027self\u0027,"},{"line_number":152,"context_line":"                                    pecan.request.public_url,"},{"line_number":153,"context_line":"                                    \u0027volume/connectors\u0027, \u0027\u0027),"},{"line_number":154,"context_line":"                link.Link.make_link(\u0027bookmark\u0027,"},{"line_number":155,"context_line":"                                    pecan.request.public_url,"},{"line_number":156,"context_line":"                                    \u0027volume/connectors\u0027, \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":74,"id":"bff0334d_1274bf34","line":153,"updated":"2017-04-06 00:23:43.000000000","message":"why not use volume_connectors?\nFor me it seems like it would make more sense, since volume is not a resource anymore and such form may be misleading. VolumeController is only a fake stub of actual REST resource so it would make things simpler.\nWhat do you think :)?","commit_id":"d59c0aa71880d304426e01233fd3684d21a1976e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"b0c350bf94b093cbded03c11eaf26ab9b2e28c28","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            v1.volume_connectors \u003d ["},{"line_number":151,"context_line":"                link.Link.make_link(\u0027self\u0027,"},{"line_number":152,"context_line":"                                    pecan.request.public_url,"},{"line_number":153,"context_line":"                                    \u0027volume/connectors\u0027, \u0027\u0027),"},{"line_number":154,"context_line":"                link.Link.make_link(\u0027bookmark\u0027,"},{"line_number":155,"context_line":"                                    pecan.request.public_url,"},{"line_number":156,"context_line":"                                    \u0027volume/connectors\u0027, \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":74,"id":"bff0334d_43695b23","line":153,"in_reply_to":"bff0334d_1274bf34","updated":"2017-04-06 05:24:15.000000000","message":"I agree volume is a little confusing. This endpoint was changed in SPEC review[1]. volume-connectors might be better.\n\n[1] https://review.openstack.org/#/c/200496/37/specs/approved/volume-connection-information.rst@206","commit_id":"d59c0aa71880d304426e01233fd3684d21a1976e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"00ee55434cb6fb55bbcb72e228f674d898fe1189","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            v1.volume_connectors \u003d ["},{"line_number":151,"context_line":"                link.Link.make_link(\u0027self\u0027,"},{"line_number":152,"context_line":"                                    pecan.request.public_url,"},{"line_number":153,"context_line":"                                    \u0027volume/connectors\u0027, \u0027\u0027),"},{"line_number":154,"context_line":"                link.Link.make_link(\u0027bookmark\u0027,"},{"line_number":155,"context_line":"                                    pecan.request.public_url,"},{"line_number":156,"context_line":"                                    \u0027volume/connectors\u0027, \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":74,"id":"bff0334d_0e5c7e7c","line":153,"in_reply_to":"bff0334d_43695b23","updated":"2017-04-06 16:04:09.000000000","message":"/volume/connectors allows for easier future expansion, if needed, so dunno. I like it slightly more.\n\noh, now I see that we have volume/targets. then we should use volume/connectors at least for logical grouping.","commit_id":"d59c0aa71880d304426e01233fd3684d21a1976e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e9f095c79b818404ca47edc57cabc946a0fe2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"\"\"Links to the volume connectors resource\"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    volume_targets \u003d [link.Link]"},{"line_number":92,"context_line":"    \"\"\"Links to the volume targets resource\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    lookup \u003d [link.Link]"},{"line_number":95,"context_line":"    \"\"\"Links to the lookup resource\"\"\""}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_a8b8d875","line":92,"updated":"2017-07-02 11:07:01.000000000","message":"this should be a link to the \"volumes\" resource, not to its children","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    \"\"\"Links to the volume connectors resource\"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    volume_targets \u003d [link.Link]"},{"line_number":92,"context_line":"    \"\"\"Links to the volume targets resource\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    lookup \u003d [link.Link]"},{"line_number":95,"context_line":"    \"\"\"Links to the lookup resource\"\"\""}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_f77108e0","line":92,"in_reply_to":"3f1d235d_a8b8d875","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7346e9cc81f0e32dc529cb0d9ae826d231999e48","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                                              node_uuid + \"/ports\","},{"line_number":608,"context_line":"                                              bookmark\u003dTrue)"},{"line_number":609,"context_line":"                          ]"},{"line_number":610,"context_line":"            node.volume_connectors \u003d \\"},{"line_number":611,"context_line":"                [link.Link.make_link(\u0027self\u0027, url, \u0027nodes\u0027,"},{"line_number":612,"context_line":"                                     node_uuid + \"/volume_connectors\"),"},{"line_number":613,"context_line":"                 link.Link.make_link(\u0027bookmark\u0027, url, \u0027nodes\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_852588af","line":610,"updated":"2015-08-23 06:29:44.000000000","message":"I believe this should only be exposed if API \u003e\u003d 1.12\n\n-1","commit_id":"982dc3b8b97ed6e0f978882b9d639ee66b693c20"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"63bd3fa7baa84e6db89a5bbcfe3303df452da7c1","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                                              node_uuid + \"/ports\","},{"line_number":608,"context_line":"                                              bookmark\u003dTrue)"},{"line_number":609,"context_line":"                          ]"},{"line_number":610,"context_line":"            node.volume_connectors \u003d \\"},{"line_number":611,"context_line":"                [link.Link.make_link(\u0027self\u0027, url, \u0027nodes\u0027,"},{"line_number":612,"context_line":"                                     node_uuid + \"/volume_connectors\"),"},{"line_number":613,"context_line":"                 link.Link.make_link(\u0027bookmark\u0027, url, \u0027nodes\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_0ab9792e","line":610,"in_reply_to":"fa1b9901_852588af","updated":"2015-08-24 10:19:54.000000000","message":"Done","commit_id":"982dc3b8b97ed6e0f978882b9d639ee66b693c20"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7278b11ea788e0423eb93ed4e790243088ff6c3d","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                                              node_uuid + \"/ports\","},{"line_number":612,"context_line":"                                              bookmark\u003dTrue)"},{"line_number":613,"context_line":"                          ]"},{"line_number":614,"context_line":"            node.volume_connectors \u003d \\"},{"line_number":615,"context_line":"                [link.Link.make_link(\u0027self\u0027, url, \u0027nodes\u0027,"},{"line_number":616,"context_line":"                                     node_uuid + \"/volume_connectors\"),"},{"line_number":617,"context_line":"                 link.Link.make_link(\u0027bookmark\u0027, url, \u0027nodes\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_df07ac1b","line":614,"updated":"2015-08-24 15:13:26.000000000","message":"Should not need to use a \\\n\nPut the [ instead of the backslash","commit_id":"2e676153ac8398d9a82bacdd34f535436e9cc05a"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"3feffcd163f264f337879cadefd8f6bea9221acd","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                                              node_uuid + \"/ports\","},{"line_number":612,"context_line":"                                              bookmark\u003dTrue)"},{"line_number":613,"context_line":"                          ]"},{"line_number":614,"context_line":"            node.volume_connectors \u003d \\"},{"line_number":615,"context_line":"                [link.Link.make_link(\u0027self\u0027, url, \u0027nodes\u0027,"},{"line_number":616,"context_line":"                                     node_uuid + \"/volume_connectors\"),"},{"line_number":617,"context_line":"                 link.Link.make_link(\u0027bookmark\u0027, url, \u0027nodes\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_38859e06","line":614,"in_reply_to":"fa1b9901_df07ac1b","updated":"2015-08-24 15:57:39.000000000","message":"Done","commit_id":"2e676153ac8398d9a82bacdd34f535436e9cc05a"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"c11e9af63d7f60914f6bd7b6f98c7ce7a83872d3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        obj.raid_config \u003d wsme.Unset"},{"line_number":100,"context_line":"        obj.target_raid_config \u003d wsme.Unset"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # If requested version is \u003c 1.15, hide volume_connectors."},{"line_number":103,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_16_VOLUME_CONNECTOR:"},{"line_number":104,"context_line":"        obj.volume_connectors \u003d wsme.Unset"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9aed3d3a_5f58ccfa","line":102,"range":{"start_line":102,"start_character":34,"end_line":102,"end_character":36},"updated":"2016-02-26 04:22:23.000000000","message":"s/1.15/1.16/","commit_id":"b44855cb9ee2fd7013ad27e5682decd7ae268c86"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"c11e9af63d7f60914f6bd7b6f98c7ce7a83872d3","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        show_password \u003d pecan.request.context.show_password"},{"line_number":787,"context_line":"        show_states_links \u003d ("},{"line_number":788,"context_line":"            api_utils.allow_links_node_states_and_driver_properties())"},{"line_number":789,"context_line":"        hide_fields_in_newer_versions(node)"},{"line_number":790,"context_line":"        node \u003d cls._convert_with_links(node, pecan.request.public_url,"},{"line_number":791,"context_line":"                                       fields\u003dfields,"},{"line_number":792,"context_line":"                                       show_password\u003dshow_password,"}],"source_content_type":"text/x-python","patch_set":20,"id":"9aed3d3a_df033cb7","line":789,"range":{"start_line":789,"start_character":0,"end_line":789,"end_character":43},"updated":"2016-02-26 04:22:23.000000000","message":"This should be removed because it\u0027s called in L794.","commit_id":"b44855cb9ee2fd7013ad27e5682decd7ae268c86"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"838ef06378c30e2cc457967410a6b889ef2c925d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        obj.target_raid_config \u003d wsme.Unset"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # If requested version is \u003c 1.16, hide volume_connectors."},{"line_number":122,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_16_VOLUME_CONNECTOR:"},{"line_number":123,"context_line":"        obj.volume_connectors \u003d wsme.Unset"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_b3f6b08c","line":122,"range":{"start_line":122,"start_character":36,"end_line":122,"end_character":62},"updated":"2016-05-23 06:28:10.000000000","message":"++","commit_id":"6586aa75e56c68d4a1d1745c815c48de3aee2f21"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"c95b00aa678d9c1671cfb4561aba87cb303d15c2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        obj.target_raid_config \u003d wsme.Unset"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # If requested version is \u003c 1.16, hide volume_connectors."},{"line_number":122,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_16_VOLUME_CONNECTOR:"},{"line_number":123,"context_line":"        obj.volume_connectors \u003d wsme.Unset"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9a061dce_33896376","line":122,"updated":"2016-04-06 12:06:25.000000000","message":"1.17","commit_id":"6586aa75e56c68d4a1d1745c815c48de3aee2f21"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c317643de614fc065e369f5e382ca4ea6ed554ca","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        obj.target_raid_config \u003d wsme.Unset"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # If requested version is \u003c 1.16, hide volume_connectors."},{"line_number":122,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_16_VOLUME_CONNECTOR:"},{"line_number":123,"context_line":"        obj.volume_connectors \u003d wsme.Unset"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"7aa08908_703c2fe1","line":122,"range":{"start_line":122,"start_character":36,"end_line":122,"end_character":62},"in_reply_to":"bab6814e_b3f6b08c","updated":"2016-06-14 15:45:45.000000000","message":"Done","commit_id":"6586aa75e56c68d4a1d1745c815c48de3aee2f21"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"838ef06378c30e2cc457967410a6b889ef2c925d","unresolved":false,"context_lines":[{"line_number":770,"context_line":"                                       fields\u003dfields,"},{"line_number":771,"context_line":"                                       show_password\u003dshow_password,"},{"line_number":772,"context_line":"                                       show_states_links\u003dshow_states_links)"},{"line_number":773,"context_line":"        hide_fields_in_newer_versions(node)"},{"line_number":774,"context_line":"        return node"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    @classmethod"},{"line_number":777,"context_line":"    def sample(cls, expand\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_93828cc6","line":774,"range":{"start_line":773,"start_character":8,"end_line":774,"end_character":19},"updated":"2016-05-23 06:28:10.000000000","message":"why is this deferred?","commit_id":"6586aa75e56c68d4a1d1745c815c48de3aee2f21"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        obj.raid_config \u003d wsme.Unset"},{"line_number":129,"context_line":"        obj.target_raid_config \u003d wsme.Unset"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # If requested version is \u003c 1.16, hide volume_connectors."},{"line_number":132,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_17_VOLUME_CONNECTOR:"},{"line_number":133,"context_line":"        obj.volume_connectors \u003d wsme.Unset"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_4bd967f2","line":131,"range":{"start_line":131,"start_character":33,"end_line":131,"end_character":36},"updated":"2016-07-21 21:20:43.000000000","message":"minor 21 would be the next I think","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        obj.target_raid_config \u003d wsme.Unset"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # If requested version is \u003c 1.16, hide volume_connectors."},{"line_number":132,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_17_VOLUME_CONNECTOR:"},{"line_number":133,"context_line":"        obj.volume_connectors \u003d wsme.Unset"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_cbcc3737","line":132,"range":{"start_line":132,"start_character":46,"end_line":132,"end_character":71},"updated":"2016-07-21 21:20:43.000000000","message":"Minor version ?21?","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":749,"context_line":"                                                   bookmark\u003dTrue)]"},{"line_number":750,"context_line":"            node.volume_connectors \u003d ["},{"line_number":751,"context_line":"                link.Link.make_link(\u0027self\u0027, url, \u0027nodes\u0027,"},{"line_number":752,"context_line":"                                    node_uuid + \"/volume_connectors\"),"},{"line_number":753,"context_line":"                link.Link.make_link(\u0027bookmark\u0027, url, \u0027nodes\u0027,"},{"line_number":754,"context_line":"                                    node_uuid + \"/volume_connectors\","},{"line_number":755,"context_line":"                                    bookmark\u003dTrue)]"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_ee282988","line":752,"range":{"start_line":752,"start_character":50,"end_line":752,"end_character":67},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors according to the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"06a5408f1b55c4d53578cfdf497be2e3d0c80b17","unresolved":false,"context_lines":[{"line_number":815,"context_line":"                                       fields\u003dfields,"},{"line_number":816,"context_line":"                                       show_password\u003dshow_password,"},{"line_number":817,"context_line":"                                       show_states_links\u003dshow_states_links)"},{"line_number":818,"context_line":"        hide_fields_in_newer_versions(node)"},{"line_number":819,"context_line":"        return node"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_062f0b3f","line":818,"updated":"2016-08-03 15:46:48.000000000","message":"This method is already called in L810.","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a1277471a3bde928031c522d24c9f1d7b015b9f3","unresolved":false,"context_lines":[{"line_number":815,"context_line":"                                       fields\u003dfields,"},{"line_number":816,"context_line":"                                       show_password\u003dshow_password,"},{"line_number":817,"context_line":"                                       show_states_links\u003dshow_states_links)"},{"line_number":818,"context_line":"        hide_fields_in_newer_versions(node)"},{"line_number":819,"context_line":"        return node"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_987176ab","line":818,"in_reply_to":"bacf61ea_062f0b3f","updated":"2016-08-04 11:27:24.000000000","message":"In order to hide volume links, it would be better to use the same manner as show_states_links because hide_fields_in_newer_versions method is used for hide fields a rpc object has.","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a1277471a3bde928031c522d24c9f1d7b015b9f3","unresolved":false,"context_lines":[{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"    volume \u003d volume.VolumeController()"},{"line_number":1004,"context_line":"    \"\"\"Expose volume as a sub-element of nodes\"\"\""},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"    management \u003d NodeManagementController()"},{"line_number":1007,"context_line":"    \"\"\"Expose management as a sub-element of nodes\"\"\""},{"line_number":1008,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_28075282","line":1005,"updated":"2016-08-04 11:27:24.000000000","message":"It would be necessary to create instances of VolumeConnectorsController and VolumeTargetsController for setting from_nodes flag.\n\nvolume.connectors \u003d volume_connector.VolumeConnectorsController()           \nvolume.targets \u003d volume_target.VolumeTargetsController()\n\nvolume.connectors.from_nodes \u003d True\nvolume.targets.from_nodes \u003d True","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"    ports \u003d port.PortsController()"},{"line_number":1042,"context_line":"    \"\"\"Expose ports as a sub-element of nodes\"\"\""},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    volume \u003d volume.VolumeController()"},{"line_number":1045,"context_line":"    \"\"\"Expose volume as a sub-element of nodes\"\"\""},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    management \u003d NodeManagementController()"},{"line_number":1048,"context_line":"    \"\"\"Expose management as a sub-element of nodes\"\"\""},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_3bf27d06","line":1046,"range":{"start_line":1044,"start_character":0,"end_line":1046,"end_character":0},"updated":"2016-08-18 14:57:17.000000000","message":"remove","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"    # Set the flag to indicate that the requests to this resource are"},{"line_number":1054,"context_line":"    # coming from a top-level resource"},{"line_number":1055,"context_line":"    ports.from_nodes \u003d True"},{"line_number":1056,"context_line":"    volume.from_nodes \u003d True"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"    from_chassis \u003d False"},{"line_number":1059,"context_line":"    \"\"\"A flag to indicate if the requests to this controller are coming"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_7be07529","line":1056,"range":{"start_line":1056,"start_character":0,"end_line":1056,"end_character":28},"updated":"2016-08-18 14:57:17.000000000","message":"remove","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"    invalid_sort_key_list \u003d [\u0027properties\u0027, \u0027driver_info\u0027, \u0027extra\u0027,"},{"line_number":1068,"context_line":"                             \u0027instance_info\u0027, \u0027driver_internal_info\u0027,"},{"line_number":1069,"context_line":"                             \u0027clean_step\u0027, \u0027raid_config\u0027, \u0027target_raid_config\u0027]"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    def _get_nodes_collection(self, chassis_uuid, instance_uuid, associated,"},{"line_number":1072,"context_line":"                              maintenance, provision_state, marker, limit,"},{"line_number":1073,"context_line":"                              sort_key, sort_dir, driver\u003dNone,"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_7b751562","line":1070,"updated":"2016-08-18 14:57:17.000000000","message":"add:\n\n    _subcontroller_map \u003d {\n        \u0027volume\u0027: volume.VolumeController\n    }\n\n    @pecan.expose()\n    def _lookup(self, ident, subres, *remainder):\n        ident \u003d types.uuid_or_name.validate(ident)\n        subcontroller \u003d self._subcontroller_map.get(subres)\n        if subcontroller:\n            return subcontroller(node_id\u003dident), remainder","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"class NodesController(rest.RestController):"},{"line_number":1026,"context_line":"    \"\"\"REST controller for Nodes.\"\"\""},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    # NOTE(lucasagomes): For future reference. If we happen"},{"line_number":1029,"context_line":"    # to need to add another sub-controller in this class let\u0027s"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_7c7ab678","line":1026,"range":{"start_line":1026,"start_character":7,"end_line":1026,"end_character":33},"updated":"2016-08-29 12:43:49.000000000","message":"Do we need to add a controller here for node?","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"34eff1af1bb51e1b3228f0b8f920305f82917041","unresolved":false,"context_lines":[{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"class NodesController(rest.RestController):"},{"line_number":1026,"context_line":"    \"\"\"REST controller for Nodes.\"\"\""},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    # NOTE(lucasagomes): For future reference. If we happen"},{"line_number":1029,"context_line":"    # to need to add another sub-controller in this class let\u0027s"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_ec623b3d","line":1026,"range":{"start_line":1026,"start_character":7,"end_line":1026,"end_character":33},"in_reply_to":"fa7ab95a_7c7ab678","updated":"2016-08-30 15:03:57.000000000","message":"This patch follows a way introduced by the patch[1] to process sub resources. It is not necessary to define sub controllers as class attributes.\n\n[1] https://review.openstack.org/#/c/314514/","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":844,"context_line":"    vendor_interface \u003d wsme.wsattr(wtypes.text)"},{"line_number":845,"context_line":"    \"\"\"The vendor interface to be used for this node\"\"\""},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"    volume \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":848,"context_line":"    \"\"\"Links to the collection of volume on this node\"\"\""},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    # NOTE(deva): \"conductor_affinity\" shouldn\u0027t be presented on the"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_cdc6689b","line":847,"updated":"2017-04-03 22:16:26.000000000","message":"s/volume/volumes/\nthis is a collection, not a single object","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":844,"context_line":"    vendor_interface \u003d wsme.wsattr(wtypes.text)"},{"line_number":845,"context_line":"    \"\"\"The vendor interface to be used for this node\"\"\""},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"    volume \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":848,"context_line":"    \"\"\"Links to the collection of volume on this node\"\"\""},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    # NOTE(deva): \"conductor_affinity\" shouldn\u0027t be presented on the"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_a502066e","line":847,"in_reply_to":"dfeb2761_cdc6689b","updated":"2017-04-05 16:04:08.000000000","message":"I changed it to links to volume_connectors and volume_targets.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    @staticmethod"},{"line_number":875,"context_line":"    def _convert_with_links(node, url, fields\u003dNone, show_states_links\u003dTrue,"},{"line_number":876,"context_line":"                            show_portgroups\u003dTrue, show_volume\u003dTrue):"},{"line_number":877,"context_line":"        # NOTE(lucasagomes): Since we are able to return a specified set of"},{"line_number":878,"context_line":"        # fields the \"uuid\" can be unset, so we need to save it in another"},{"line_number":879,"context_line":"        # variable to use when building the links"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_4dea580f","line":876,"updated":"2017-04-03 22:16:26.000000000","message":"s/volume/volumes/","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":873,"context_line":""},{"line_number":874,"context_line":"    @staticmethod"},{"line_number":875,"context_line":"    def _convert_with_links(node, url, fields\u003dNone, show_states_links\u003dTrue,"},{"line_number":876,"context_line":"                            show_portgroups\u003dTrue, show_volume\u003dTrue):"},{"line_number":877,"context_line":"        # NOTE(lucasagomes): Since we are able to return a specified set of"},{"line_number":878,"context_line":"        # fields the \"uuid\" can be unset, so we need to save it in another"},{"line_number":879,"context_line":"        # variable to use when building the links"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_85fb8277","line":876,"in_reply_to":"dfeb2761_4dea580f","updated":"2017-04-05 16:04:08.000000000","message":"Done","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"742799e3e829f0abb3db2806facfa0f57bdad8a3","unresolved":false,"context_lines":[{"line_number":1275,"context_line":"        if ((remainder[0] \u003d\u003d \u0027portgroups\u0027 and"},{"line_number":1276,"context_line":"                not api_utils.allow_portgroups_subcontrollers()) or"},{"line_number":1277,"context_line":"            (remainder[0] \u003d\u003d \u0027vifs\u0027 and"},{"line_number":1278,"context_line":"                not api_utils.allow_vifs_subcontroller())):"},{"line_number":1279,"context_line":"            pecan.abort(http_client.NOT_FOUND)"},{"line_number":1280,"context_line":"        subcontroller \u003d self._subcontroller_map.get(remainder[0])"},{"line_number":1281,"context_line":"        if subcontroller:"}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_248b4e68","line":1278,"updated":"2017-06-27 20:01:28.000000000","message":"do we need to add something similar for (remainder[0] \u003d\u003d \u0027volume\u0027 and not api_utils.allow_volume())?","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":1275,"context_line":"        if ((remainder[0] \u003d\u003d \u0027portgroups\u0027 and"},{"line_number":1276,"context_line":"                not api_utils.allow_portgroups_subcontrollers()) or"},{"line_number":1277,"context_line":"            (remainder[0] \u003d\u003d \u0027vifs\u0027 and"},{"line_number":1278,"context_line":"                not api_utils.allow_vifs_subcontroller())):"},{"line_number":1279,"context_line":"            pecan.abort(http_client.NOT_FOUND)"},{"line_number":1280,"context_line":"        subcontroller \u003d self._subcontroller_map.get(remainder[0])"},{"line_number":1281,"context_line":"        if subcontroller:"}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_a9428a0d","line":1278,"in_reply_to":"5f201791_248b4e68","updated":"2017-06-28 08:00:14.000000000","message":"I don\u0027t think it is necessary here.\n\nPortgroup subcontroller was added with an independent API version(1.24) from the version for portgroup(1.23) resource. This validation is necessary for a request with version 1.23.\n\nVIF can be accessed only as a subresource of a node. All accesses to VIF can be blocked here with this validation.\n\nThis change introduces both /v1/volume and /v1/nodes/node_ident/volume with one new API version. So, it would be better to validate API version in VolumeController. I moved the validation to VolumeController from each method in VolumeConnectorsController and VolumeTargetsController.","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":550,"context_line":""},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"def allow_volume():"},{"line_number":553,"context_line":"    \"\"\"Check if we should support volume connectors and targets."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    Version 1.32 of the API added support for volume connectors and targets"},{"line_number":556,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_ed448c1d","line":553,"updated":"2017-04-03 22:16:26.000000000","message":"I\u0027d prefer:\n\u0027Check if volume connectors and targets are allowed.\u0027","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":550,"context_line":""},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"def allow_volume():"},{"line_number":553,"context_line":"    \"\"\"Check if we should support volume connectors and targets."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    Version 1.32 of the API added support for volume connectors and targets"},{"line_number":556,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_faa2edad","line":553,"in_reply_to":"dfeb2761_ed448c1d","updated":"2017-04-05 16:04:08.000000000","message":"Done","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"}],"ironic/api/controllers/v1/versions.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"4463f67fb7445766dfaa8acd33176a5f25f63058","unresolved":false,"context_lines":[{"line_number":63,"context_line":"MINOR_13_ABORT_VERB \u003d 13"},{"line_number":64,"context_line":"MINOR_14_LINKS_NODESTATES_DRIVERPROPERTIES \u003d 14"},{"line_number":65,"context_line":"MINOR_15_MANUAL_CLEAN \u003d 15"},{"line_number":66,"context_line":"MINOR_16_VOLUME_CONNECTOR \u003d 16"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# When adding another version, update MINOR_MAX_VERSION and also update"},{"line_number":69,"context_line":"# doc/source/webapi/v1.rst with a detailed explanation of what the version has"}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_ab733ee6","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":30},"updated":"2016-03-17 13:25:34.000000000","message":"16 is already taken by others, should be 17 or higher.","commit_id":"155b611b8ee929c69307af0b470537109daa4dcf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# When adding another version, update MINOR_MAX_VERSION and also update"},{"line_number":71,"context_line":"# doc/source/webapi/v1.rst with a detailed explanation of what the version has"},{"line_number":72,"context_line":"# changed."},{"line_number":73,"context_line":"MINOR_MAX_VERSION \u003d MINOR_17_VOLUME_CONNECTOR"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# String representations of the minor and maximum versions"},{"line_number":76,"context_line":"MIN_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, MINOR_1_INITIAL_VERSION)"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_cb655745","line":73,"range":{"start_line":73,"start_character":20,"end_line":73,"end_character":45},"updated":"2016-07-21 21:20:43.000000000","message":"Some days I wonder why we increment this as part of main patches....  Naturally, this would end up being a minor number of 21 at this point.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"6346a8399812bb1ba9cbe439716eda1b09911e69","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# String representations of the minor and maximum versions"},{"line_number":86,"context_line":"MIN_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, MINOR_1_INITIAL_VERSION)"},{"line_number":87,"context_line":"MAX_VERS"}],"source_content_type":"text/x-python","patch_set":34,"id":"bacf61ea_68b38d98","line":87,"updated":"2016-08-02 09:16:40.000000000","message":"This file is broken.","commit_id":"27fc0115b5c532e2aede4ea595abf35b54b6b6bb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c0ab80a100ef5197f380a3825e86f486112e5ce4","unresolved":false,"context_lines":[{"line_number":83,"context_line":"MINOR_MAX_VERSION \u003d MINOR_22_VOLUME"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# String representations of the minor and maximum versions"},{"line_number":86,"context_line":"MAX_VERSMIN_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION,"},{"line_number":87,"context_line":"                                            MINOR_1_INITIAL_VERSION)"},{"line_number":88,"context_line":"MAX_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, MINOR_MAX_VERSION)"}],"source_content_type":"text/x-python","patch_set":35,"id":"bacf61ea_3a9d345a","line":86,"updated":"2016-08-02 19:16:45.000000000","message":"typo? should be MAX_VERSION_STRING","commit_id":"83d571a0e483b1a5ed278d30fe2db8923ad06f27"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"478ef4dd07d0f793c16309b487dd6d5125b0846b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"MINOR_MAX_VERSION \u003d MINOR_22_VOLUME"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# String representations of the minor and maximum versions"},{"line_number":86,"context_line":"MAX_VERSMIN_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION,"},{"line_number":87,"context_line":"                                            MINOR_1_INITIAL_VERSION)"},{"line_number":88,"context_line":"MAX_VERSION_STRING \u003d \u0027{}.{}\u0027.format(BASE_VERSION, MINOR_MAX_VERSION)"}],"source_content_type":"text/x-python","patch_set":35,"id":"bacf61ea_dac33837","line":86,"in_reply_to":"bacf61ea_3a9d345a","updated":"2016-08-02 19:17:24.000000000","message":"err, MIN","commit_id":"83d571a0e483b1a5ed278d30fe2db8923ad06f27"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7cc5b8aee6f3303a22d952667311513e41cb2af0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"MINOR_23_VOLUME \u003d 23"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# When adding another version, update MINOR_MAX_VERSION and also update"},{"line_number":83,"context_line":"# doc/source/webapi/v1.rst with a detailed explanation of what the version has"},{"line_number":84,"context_line":"# changed."},{"line_number":85,"context_line":"MINOR_MAX_VERSION \u003d MINOR_23_VOLUME"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"9a89bdaa_9ea43558","line":83,"range":{"start_line":83,"start_character":1,"end_line":83,"end_character":27},"updated":"2016-09-05 07:26:25.000000000","message":"I think this should consistent with line 20 and it should be doc/source/dev/webapi-version-history.rst .","commit_id":"0602204f9feb547284cca8e5038228b3f661bfc2"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9806bc6bece31b670a1b366447b3b02bf9ca51a7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"MINOR_23_VOLUME \u003d 23"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# When adding another version, update MINOR_MAX_VERSION and also update"},{"line_number":83,"context_line":"# doc/source/webapi/v1.rst with a detailed explanation of what the version has"},{"line_number":84,"context_line":"# changed."},{"line_number":85,"context_line":"MINOR_MAX_VERSION \u003d MINOR_23_VOLUME"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"ba5da102_7d0abd22","line":83,"range":{"start_line":83,"start_character":1,"end_line":83,"end_character":27},"in_reply_to":"9a89bdaa_9ea43558","updated":"2016-11-05 14:20:57.000000000","message":"Done","commit_id":"0602204f9feb547284cca8e5038228b3f661bfc2"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# v1.29: Add inject nmi."},{"line_number":63,"context_line":"# v1.30: Add dynamic driver interactions."},{"line_number":64,"context_line":"# v1.31: Add dynamic interfaces fields to node."},{"line_number":65,"context_line":"# v1.32: Add volume resource"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"MINOR_0_JUNO \u003d 0"},{"line_number":68,"context_line":"MINOR_1_INITIAL_VERSION \u003d 1"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_6d507cd5","line":65,"updated":"2017-04-03 22:16:26.000000000","message":"Maybe \"Add volume support\"?","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# v1.29: Add inject nmi."},{"line_number":63,"context_line":"# v1.30: Add dynamic driver interactions."},{"line_number":64,"context_line":"# v1.31: Add dynamic interfaces fields to node."},{"line_number":65,"context_line":"# v1.32: Add volume resource"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"MINOR_0_JUNO \u003d 0"},{"line_number":68,"context_line":"MINOR_1_INITIAL_VERSION \u003d 1"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_37fe3eae","line":65,"in_reply_to":"dfeb2761_6d507cd5","updated":"2017-04-05 16:04:08.000000000","message":"Done","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"}],"ironic/api/controllers/v1/volume.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"73e34925616f37bc1f31a269480ffbd9314f5422","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ironic.api.controllers import link"},{"line_number":21,"context_line":"from ironic.api.controllers.v1 import volume_connector"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# note dlenwell: commented out until I know what minor version this actually is"},{"line_number":24,"context_line":"# If requested version is \u003c 1.21, hide volume_connectors."},{"line_number":25,"context_line":"# if pecan.request.version.minor \u003c versions.MINOR_21_VOLUME_CONNECTOR:"},{"line_number":26,"context_line":"#    obj.volume_connectors \u003d wsme.Unset"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"volume \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":29,"context_line":"\"\"\"Links to the volume connector\"\"\""}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_58f15b6a","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":39},"updated":"2016-08-01 15:59:39.000000000","message":"The minor version will need to be incremented as time goes on, so this should should be present since the object likely needs to be unset if not available.","commit_id":"29e8010151c4c6e1de900a79c290ea2dcc14b624"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class VolumeController(rest.RestController):"},{"line_number":54,"context_line":"    \"\"\"volume root controller connects to the volume_connectors controller\"\"\""},{"line_number":55,"context_line":"    connectors \u003d volume_connector.VolumeConnectorsController()"},{"line_number":56,"context_line":"    \"\"\"Expose volume connectors as a sub-element of volumes\"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    targets \u003d volume_target.VolumeTargetsController()"},{"line_number":59,"context_line":"    \"\"\"Expose volume target as a sub-element of volumes\"\"\""}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_7b57d557","line":59,"range":{"start_line":54,"start_character":0,"end_line":59,"end_character":58},"updated":"2016-08-18 14:57:17.000000000","message":"replace:\n\n    def __init__(self, node_id\u003dNone):\n        super(VolumeController, self).__init__()\n        self.node_id_from_node \u003d node_id\n\n    _subcontroller_map \u003d {\n        \u0027connectors\u0027: volume_connector.VolumeConnectorsController,\n        \u0027targets\u0027: volume_target.VolumeTargetsController\n    }\n\n    @pecan.expose()\n    def _lookup(self, subres, *remainder):\n        subcontroller \u003d self._subcontroller_map.get(subres)\n        if subcontroller:\n            return subcontroller(node_id\u003dself.node_id_from_node), remainder","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hitachi, Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_cd74286b","line":1,"updated":"2017-04-03 22:16:26.000000000","message":"turbonit: this seems outdated ;)","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hitachi, Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_6093cc5c","line":1,"in_reply_to":"dfeb2761_cd74286b","updated":"2017-04-05 16:04:08.000000000","message":"Done","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class Volume(base.APIBase):"},{"line_number":33,"context_line":"    \"\"\"API representation of a volume."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    This class exists as a root class for the connectors and target controllers"},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_cd22e852","line":35,"updated":"2017-04-03 22:16:26.000000000","message":"s/connectors/volume connectors/\ns/target/volume targets/","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \"\"\"Links to the volume connectors resource\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    volume_targets \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":45,"context_line":"    \"\"\"Links to the volumetargets resourece\"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @staticmethod"},{"line_number":48,"context_line":"    def convert(node_ident\u003dNone):"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_ede00cfd","line":45,"updated":"2017-04-03 22:16:26.000000000","message":"s/volumetargets/volume targets/","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \"\"\"Links to the volumetargets resourece\"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @staticmethod"},{"line_number":48,"context_line":"    def convert(node_ident\u003dNone):"},{"line_number":49,"context_line":"        url \u003d pecan.request.public_url"},{"line_number":50,"context_line":"        volume \u003d Volume()"},{"line_number":51,"context_line":"        if node_ident:"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_4d8b781e","line":48,"updated":"2017-04-03 22:16:26.000000000","message":"This method seems to be usually named _convert_with_links.\nAlso - this function does not convert anything, it creates a new volume. It should take the volume as a param or be renamed to indicate that it creates the volume.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \"\"\"Links to the volumetargets resourece\"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @staticmethod"},{"line_number":48,"context_line":"    def convert(node_ident\u003dNone):"},{"line_number":49,"context_line":"        url \u003d pecan.request.public_url"},{"line_number":50,"context_line":"        volume \u003d Volume()"},{"line_number":51,"context_line":"        if node_ident:"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_40d8c81c","line":48,"in_reply_to":"dfeb2761_4d8b781e","updated":"2017-04-05 16:04:08.000000000","message":"I\u0027ve been considering how to treat the volume. I decided not to create volume resource because volume is not a resource but a word for grouping connectors and targets.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        volume \u003d Volume()"},{"line_number":51,"context_line":"        if node_ident:"},{"line_number":52,"context_line":"            resource \u003d \u0027nodes\u0027"},{"line_number":53,"context_line":"            args \u003d \u0027%s/volume/\u0027 % node_ident"},{"line_number":54,"context_line":"        else:"},{"line_number":55,"context_line":"            resource \u003d \u0027volume\u0027"},{"line_number":56,"context_line":"            args \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_cd7e6818","line":53,"updated":"2017-04-03 22:16:26.000000000","message":"I\u0027d prefer the API path to be plural to be compliant with other ones.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return volume"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class VolumeController(rest.RestController):"},{"line_number":77,"context_line":"    \"\"\"Rest controller for volume\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    _subcontroller_map \u003d {"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_0d9a1062","line":76,"updated":"2017-04-03 22:16:26.000000000","message":"s/Volume/Volumes/","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return volume"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class VolumeController(rest.RestController):"},{"line_number":77,"context_line":"    \"\"\"Rest controller for volume\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    _subcontroller_map \u003d {"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_c0e738ac","line":76,"in_reply_to":"dfeb2761_0d9a1062","updated":"2017-04-05 16:04:08.000000000","message":"I keep using singular. Volume is similar to NodeManagement, which is a parent of sub elements.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class VolumeController(rest.RestController):"},{"line_number":77,"context_line":"    \"\"\"Rest controller for volume\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    _subcontroller_map \u003d {"},{"line_number":80,"context_line":"        \u0027connectors\u0027: volume_connector.VolumeConnectorsController,"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_ad9e8451","line":77,"updated":"2017-04-03 22:16:26.000000000","message":"turbo nit: \ns/Rest/REST/\ns/volume/Volumes./","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class VolumeController(rest.RestController):"},{"line_number":77,"context_line":"    \"\"\"Rest controller for volume\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    _subcontroller_map \u003d {"},{"line_number":80,"context_line":"        \u0027connectors\u0027: volume_connector.VolumeConnectorsController,"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_8096d04b","line":77,"in_reply_to":"dfeb2761_ad9e8451","updated":"2017-04-05 16:04:08.000000000","message":"Done","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        volume \u003d Volume()"},{"line_number":52,"context_line":"        if node_ident:"},{"line_number":53,"context_line":"            resource \u003d \u0027nodes\u0027"},{"line_number":54,"context_line":"            args \u003d \u0027%s/volume/\u0027 % node_ident"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            resource \u003d \u0027volume\u0027"},{"line_number":57,"context_line":"            args \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_f76d3332","line":54,"range":{"start_line":54,"start_character":29,"end_line":54,"end_character":30},"updated":"2017-05-23 14:09:46.000000000","message":"any reason we need this? in other case args does not contain a trailing slash","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        volume \u003d Volume()"},{"line_number":52,"context_line":"        if node_ident:"},{"line_number":53,"context_line":"            resource \u003d \u0027nodes\u0027"},{"line_number":54,"context_line":"            args \u003d \u0027%s/volume/\u0027 % node_ident"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            resource \u003d \u0027volume\u0027"},{"line_number":57,"context_line":"            args \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_0d0f2888","line":54,"range":{"start_line":54,"start_character":29,"end_line":54,"end_character":30},"in_reply_to":"ff0f0b1f_f76d3332","updated":"2017-05-26 05:06:45.000000000","message":"Done","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"331ce08e47d7364e3f39df55af173b0fc0981f6f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"API representation of a volume root."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    This class exists as a root class for the volume connectors and volume"},{"line_number":36,"context_line":"    targets controllers"},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_137c11ea","line":36,"updated":"2017-06-28 03:33:47.000000000","message":"nit, missing period at end of sentence.","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"API representation of a volume root."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    This class exists as a root class for the volume connectors and volume"},{"line_number":36,"context_line":"    targets controllers"},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_f7a5fc9f","line":36,"in_reply_to":"5f201791_137c11ea","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"331ce08e47d7364e3f39df55af173b0fc0981f6f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Links to the volume connectors resource\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    volume_targets \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":46,"context_line":"    \"\"\"Links to the volume targets resourece\"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def convert(node_ident\u003dNone):"}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_33702d08","line":46,"updated":"2017-06-28 03:33:47.000000000","message":"s/resourece/resource/","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Links to the volume connectors resource\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    volume_targets \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":46,"context_line":"    \"\"\"Links to the volume targets resourece\"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def convert(node_ident\u003dNone):"}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_17c4f83e","line":46,"in_reply_to":"5f201791_33702d08","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"331ce08e47d7364e3f39df55af173b0fc0981f6f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        volume.volume_connectors \u003d ["},{"line_number":65,"context_line":"            link.Link.make_link(\u0027self\u0027, url, resource, args + \u0027connectors\u0027),"},{"line_number":66,"context_line":"            link.Link.make_link(\u0027bookmark\u0027, url, resource, args + \u0027connectors\u0027,"},{"line_number":67,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_b3a0bd43","line":65,"updated":"2017-06-28 03:33:47.000000000","message":"i didn\u0027t test this but I think you are missing / in \u0027/connectors\u0027. If you want something like \u0027volume/connectors\u0027","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        volume.volume_connectors \u003d ["},{"line_number":65,"context_line":"            link.Link.make_link(\u0027self\u0027, url, resource, args + \u0027connectors\u0027),"},{"line_number":66,"context_line":"            link.Link.make_link(\u0027bookmark\u0027, url, resource, args + \u0027connectors\u0027,"},{"line_number":67,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_f7417ca7","line":65,"in_reply_to":"5f201791_b3a0bd43","updated":"2017-06-28 08:00:14.000000000","message":"Good catch!\nI added assertion to unit tests for /v1/volume and /v1/nodes/node_ident/volume. Then, I added \u0027/\u0027 to args for /v1/nodes/node_ident/volume.","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"331ce08e47d7364e3f39df55af173b0fc0981f6f","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        volume.volume_connectors \u003d ["},{"line_number":65,"context_line":"            link.Link.make_link(\u0027self\u0027, url, resource, args + \u0027connectors\u0027),"},{"line_number":66,"context_line":"            link.Link.make_link(\u0027bookmark\u0027, url, resource, args + \u0027connectors\u0027,"},{"line_number":67,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        volume.volume_targets \u003d ["}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_539169f0","line":66,"updated":"2017-06-28 03:33:47.000000000","message":"ditto","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        volume.volume_connectors \u003d ["},{"line_number":65,"context_line":"            link.Link.make_link(\u0027self\u0027, url, resource, args + \u0027connectors\u0027),"},{"line_number":66,"context_line":"            link.Link.make_link(\u0027bookmark\u0027, url, resource, args + \u0027connectors\u0027,"},{"line_number":67,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        volume.volume_targets \u003d ["}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_b719c4d7","line":66,"in_reply_to":"5f201791_539169f0","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"331ce08e47d7364e3f39df55af173b0fc0981f6f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        volume.volume_targets \u003d ["},{"line_number":70,"context_line":"            link.Link.make_link(\u0027self\u0027, url, resource, args + \u0027targets\u0027),"},{"line_number":71,"context_line":"            link.Link.make_link(\u0027bookmark\u0027, url, resource, args + \u0027targets\u0027,"},{"line_number":72,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_338cadd5","line":70,"updated":"2017-06-28 03:33:47.000000000","message":"ditto","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        volume.volume_targets \u003d ["},{"line_number":70,"context_line":"            link.Link.make_link(\u0027self\u0027, url, resource, args + \u0027targets\u0027),"},{"line_number":71,"context_line":"            link.Link.make_link(\u0027bookmark\u0027, url, resource, args + \u0027targets\u0027,"},{"line_number":72,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_970c8894","line":70,"in_reply_to":"5f201791_338cadd5","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"331ce08e47d7364e3f39df55af173b0fc0981f6f","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        volume.volume_targets \u003d ["},{"line_number":70,"context_line":"            link.Link.make_link(\u0027self\u0027, url, resource, args + \u0027targets\u0027),"},{"line_number":71,"context_line":"            link.Link.make_link(\u0027bookmark\u0027, url, resource, args + \u0027targets\u0027,"},{"line_number":72,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return volume"}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_13c1b1e5","line":71,"updated":"2017-06-28 03:33:47.000000000","message":"ditto","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        volume.volume_targets \u003d ["},{"line_number":70,"context_line":"            link.Link.make_link(\u0027self\u0027, url, resource, args + \u0027targets\u0027),"},{"line_number":71,"context_line":"            link.Link.make_link(\u0027bookmark\u0027, url, resource, args + \u0027targets\u0027,"},{"line_number":72,"context_line":"                                bookmark\u003dTrue)]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return volume"}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_770fac87","line":71,"in_reply_to":"5f201791_13c1b1e5","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"331ce08e47d7364e3f39df55af173b0fc0981f6f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        super(VolumeController, self).__init__()"},{"line_number":87,"context_line":"        self.parent_node_ident \u003d node_ident"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @METRICS.timer(\u0027VolumeController.get\u0027)"},{"line_number":90,"context_line":"    @expose.expose(Volume)"},{"line_number":91,"context_line":"    def get(self):"},{"line_number":92,"context_line":"        if not api_utils.allow_volume():"}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_cea38cff","line":89,"updated":"2017-06-28 03:33:47.000000000","message":"hmm, I wonder how useful this metric is. All it is doing is returning links?","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        super(VolumeController, self).__init__()"},{"line_number":87,"context_line":"        self.parent_node_ident \u003d node_ident"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @METRICS.timer(\u0027VolumeController.get\u0027)"},{"line_number":90,"context_line":"    @expose.expose(Volume)"},{"line_number":91,"context_line":"    def get(self):"},{"line_number":92,"context_line":"        if not api_utils.allow_volume():"}],"source_content_type":"text/x-python","patch_set":95,"id":"5f201791_97e8087c","line":89,"in_reply_to":"5f201791_cea38cff","updated":"2017-06-28 08:00:14.000000000","message":"Yes, just returning links.\nAs you told, it doesn\u0027t seem useful. I removed it.","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from ironic.common import exception"},{"line_number":28,"context_line":"from ironic.common import policy"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"METRICS \u003d metrics_utils.get_metrics_logger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class Volume(base.APIBase):"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_219af760","line":30,"updated":"2017-06-28 21:13:00.000000000","message":"can delete this and L15","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from ironic.common import exception"},{"line_number":28,"context_line":"from ironic.common import policy"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"METRICS \u003d metrics_utils.get_metrics_logger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class Volume(base.APIBase):"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_5a5b832d","line":30,"in_reply_to":"5f201791_219af760","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9b30d7ba92d7e0b28192c7d0c273a077455ea5b6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    @pecan.expose()"},{"line_number":101,"context_line":"    def _lookup(self, subres, *remainder):"},{"line_number":102,"context_line":"        if not api_utils.allow_volume():"},{"line_number":103,"context_line":"            pecan.abort(http_client.NOT_FOUND)"},{"line_number":104,"context_line":"        subcontroller \u003d self._subcontroller_map.get(subres)"},{"line_number":105,"context_line":"        if subcontroller:"},{"line_number":106,"context_line":"            return subcontroller(node_ident\u003dself.parent_node_ident), remainder"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_92b11b47","line":103,"range":{"start_line":103,"start_character":24,"end_line":103,"end_character":45},"updated":"2017-06-28 20:58:41.000000000","message":"I guess this is okay.  It makes sense since it is expected behavior, and I do like not raising the exceptions unless we really need to.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e9f095c79b818404ca47edc57cabc946a0fe2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":38,"context_line":"    \"\"\"A list containing a self link and associated volume links\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    volume_connectors \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":41,"context_line":"    \"\"\"Links to the volume connectors resource\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    volume_targets \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_a89fb801","line":40,"updated":"2017-07-02 11:07:01.000000000","message":"just \"connectors\", \"volume\" is redundant","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":38,"context_line":"    \"\"\"A list containing a self link and associated volume links\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    volume_connectors \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":41,"context_line":"    \"\"\"Links to the volume connectors resource\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    volume_targets \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_1725a4c2","line":40,"in_reply_to":"3f1d235d_a89fb801","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e9f095c79b818404ca47edc57cabc946a0fe2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    volume_connectors \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":41,"context_line":"    \"\"\"Links to the volume connectors resource\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    volume_targets \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":44,"context_line":"    \"\"\"Links to the volume targets resource\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_88a2bc4a","line":43,"updated":"2017-07-02 11:07:01.000000000","message":"ditto","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    volume_connectors \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":41,"context_line":"    \"\"\"Links to the volume connectors resource\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    volume_targets \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":44,"context_line":"    \"\"\"Links to the volume targets resource\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_d72e0ca4","line":43,"in_reply_to":"3f1d235d_88a2bc4a","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"}],"ironic/api/controllers/v1/volume_connector.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"4463f67fb7445766dfaa8acd33176a5f25f63058","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        :param fields: Optional, a list with a specified set of fields"},{"line_number":258,"context_line":"                       of the resource to be returned."},{"line_number":259,"context_line":"        \"\"\""},{"line_number":260,"context_line":"        api_utils.check_allow_specify_fields(fields)"},{"line_number":261,"context_line":"        if fields is None:"},{"line_number":262,"context_line":"            fields \u003d _DEFAULT_RETURN_FIELDS"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_0505f612","line":260,"range":{"start_line":260,"start_character":8,"end_line":260,"end_character":52},"updated":"2016-03-17 13:25:34.000000000","message":"should also add a similar check about the api version to verify whether allowed to do this volume connectors action and raise exceptions.","commit_id":"155b611b8ee929c69307af0b470537109daa4dcf"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"4463f67fb7445766dfaa8acd33176a5f25f63058","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    @expose.expose(VolumeConnectorCollection, types.uuid_or_name, types.uuid,"},{"line_number":278,"context_line":"                   types.uuid, int, wtypes.text, wtypes.text)"},{"line_number":279,"context_line":"    def detail(self, node\u003dNone, node_uuid\u003dNone, marker\u003dNone,"},{"line_number":280,"context_line":"               limit\u003dNone, sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027):"},{"line_number":281,"context_line":"        \"\"\"Retrieve a list of volume connectors with detail."},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_602308a8","line":279,"range":{"start_line":279,"start_character":8,"end_line":279,"end_character":14},"updated":"2016-03-17 13:25:34.000000000","message":"ditto","commit_id":"155b611b8ee929c69307af0b470537109daa4dcf"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"4463f67fb7445766dfaa8acd33176a5f25f63058","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                                                      resource_url)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    @expose.expose(VolumeConnector, types.uuid, types.listtype)"},{"line_number":315,"context_line":"    def get_one(self, connector_uuid, fields\u003dNone):"},{"line_number":316,"context_line":"        \"\"\"Retrieve information about the given volume connector."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        :param connector_uuid: UUID of a volume connector."}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_60a828dc","line":315,"range":{"start_line":315,"start_character":8,"end_line":315,"end_character":15},"updated":"2016-03-17 13:25:34.000000000","message":"ditto","commit_id":"155b611b8ee929c69307af0b470537109daa4dcf"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"4463f67fb7445766dfaa8acd33176a5f25f63058","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    @expose.expose(VolumeConnector, body\u003dVolumeConnector,"},{"line_number":332,"context_line":"                   status_code\u003dhttp_client.CREATED)"},{"line_number":333,"context_line":"    def post(self, connector):"},{"line_number":334,"context_line":"        \"\"\"Create a new volume connector."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        :param connector: a volume connector within the request body."}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_00b84429","line":333,"range":{"start_line":333,"start_character":8,"end_line":333,"end_character":12},"updated":"2016-03-17 13:25:34.000000000","message":"ditto","commit_id":"155b611b8ee929c69307af0b470537109daa4dcf"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"4463f67fb7445766dfaa8acd33176a5f25f63058","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    @wsme.validate(types.uuid, [VolumeConnectorPatchType])"},{"line_number":350,"context_line":"    @expose.expose(VolumeConnector, types.uuid,"},{"line_number":351,"context_line":"                   body\u003d[VolumeConnectorPatchType])"},{"line_number":352,"context_line":"    def patch(self, connector_uuid, patch):"},{"line_number":353,"context_line":"        \"\"\"Update an existing volume connector."},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        :param connector_uuid: UUID of a volume connector."}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_a0951088","line":352,"range":{"start_line":352,"start_character":8,"end_line":352,"end_character":13},"updated":"2016-03-17 13:25:34.000000000","message":"ditto","commit_id":"155b611b8ee929c69307af0b470537109daa4dcf"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"4463f67fb7445766dfaa8acd33176a5f25f63058","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        return VolumeConnector.convert_with_links(new_connector)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @expose.expose(None, types.uuid, status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":397,"context_line":"    def delete(self, connector_uuid):"},{"line_number":398,"context_line":"        \"\"\"Delete a volume connector."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        :param connector_uuid: UUID of a volume connector."}],"source_content_type":"text/x-python","patch_set":21,"id":"1af94dfe_20f0e0fd","line":397,"range":{"start_line":397,"start_character":8,"end_line":397,"end_character":14},"updated":"2016-03-17 13:25:34.000000000","message":"ditto","commit_id":"155b611b8ee929c69307af0b470537109daa4dcf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hitachi, Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_ae4ab152","line":1,"updated":"2016-07-21 21:20:43.000000000","message":"This file likely ought to be renamed volume.py and then refactored so the rest API interaction for connectors is via /v1/volume/connectors","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a1277471a3bde928031c522d24c9f1d7b015b9f3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from ironic import objects"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_DEFAULT_RETURN_FIELDS \u003d (\u0027uuid\u0027, \u0027node_uuid\u0027, \u0027type\u0027, \u0027value\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class VolumeConnector(base.APIBase):"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_9e5aff81","line":35,"range":{"start_line":35,"start_character":56,"end_line":35,"end_character":61},"updated":"2016-08-04 11:27:24.000000000","message":"connector_id","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"06a5408f1b55c4d53578cfdf497be2e3d0c80b17","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    type \u003d wsme.wsattr(wtypes.text, mandatory\u003dTrue)"},{"line_number":74,"context_line":"    \"\"\"The type of volume connector\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    value \u003d wsme.wsattr(wtypes.text, mandatory\u003dTrue)"},{"line_number":77,"context_line":"    \"\"\"The value for this volume connector\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    extra \u003d {wtypes.text: types.jsontype}"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_390cfb93","line":76,"updated":"2016-08-03 15:46:48.000000000","message":"\u0027value\u0027 needs to be changed to \u0027connector_id\u0027.","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a1277471a3bde928031c522d24c9f1d7b015b9f3","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # never expose the node_id attribute"},{"line_number":119,"context_line":"        connector.node_id \u003d wtypes.Unset"},{"line_number":120,"context_line":"        connector.links \u003d [link.Link.make_link(\u0027self\u0027, url,"},{"line_number":121,"context_line":"                                               \u0027volume_connectors\u0027,"},{"line_number":122,"context_line":"                                               connector_uuid),"},{"line_number":123,"context_line":"                           link.Link.make_link(\u0027bookmark\u0027, url,"},{"line_number":124,"context_line":"                                               \u0027volume_connectors\u0027,"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_ded62cf0","line":121,"range":{"start_line":121,"start_character":48,"end_line":121,"end_character":65},"updated":"2016-08-04 11:27:24.000000000","message":"volume/connectors","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a1277471a3bde928031c522d24c9f1d7b015b9f3","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                               \u0027volume_connectors\u0027,"},{"line_number":122,"context_line":"                                               connector_uuid),"},{"line_number":123,"context_line":"                           link.Link.make_link(\u0027bookmark\u0027, url,"},{"line_number":124,"context_line":"                                               \u0027volume_connectors\u0027,"},{"line_number":125,"context_line":"                                               connector_uuid,"},{"line_number":126,"context_line":"                                               bookmark\u003dTrue)"},{"line_number":127,"context_line":"                           ]"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_5e019c69","line":124,"range":{"start_line":124,"start_character":48,"end_line":124,"end_character":65},"updated":"2016-08-04 11:27:24.000000000","message":"ditto","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"06a5408f1b55c4d53578cfdf497be2e3d0c80b17","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        :param fields: Optional, a list with a specified set of fields"},{"line_number":258,"context_line":"                       of the resource to be returned."},{"line_number":259,"context_line":"        \"\"\""},{"line_number":260,"context_line":"        api_utils.check_allow_specify_fields(fields)"},{"line_number":261,"context_line":"        if fields is None:"},{"line_number":262,"context_line":"            fields \u003d _DEFAULT_RETURN_FIELDS"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_457c6072","line":260,"updated":"2016-08-03 15:46:48.000000000","message":"It is necessary validate if microversion allows volume_connector. Then, this validation gets unnecessary because volume_connector requires newer microversion.","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"06a5408f1b55c4d53578cfdf497be2e3d0c80b17","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            # We\u0027re invoking this interface using positional notation, or"},{"line_number":266,"context_line":"            # explicitly using \u0027node\u0027.  Try and determine which one."},{"line_number":267,"context_line":"            # Make sure only one interface, node or node_uuid is used"},{"line_number":268,"context_line":"            if (not api_utils.allow_node_logical_names() and"},{"line_number":269,"context_line":"                not uuidutils.is_uuid_like(node)):"},{"line_number":270,"context_line":"                raise exception.NotAcceptable()"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_770e7733","line":268,"range":{"start_line":268,"start_character":20,"end_line":268,"end_character":54},"updated":"2016-08-03 15:46:48.000000000","message":"This validation sees if microversion is newer than 1.4. It always returns True if the microversion allows volume_connector. Then, we can remove this block(L264-270).","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"06a5408f1b55c4d53578cfdf497be2e3d0c80b17","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":293,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: \"asc\"."},{"line_number":294,"context_line":"        \"\"\""},{"line_number":295,"context_line":"        if not node_uuid and node:"},{"line_number":296,"context_line":"            # We\u0027re invoking this interface using positional notation, or"},{"line_number":297,"context_line":"            # explicitly using \u0027node\u0027.  Try and determine which one."},{"line_number":298,"context_line":"            # Make sure only one interface, node or node_uuid is used"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_d7c80377","line":295,"updated":"2016-08-03 15:46:48.000000000","message":"There also should be validation to check whether volume_connector is allowed.\nThen, we can remove this block.","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a1277471a3bde928031c522d24c9f1d7b015b9f3","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # NOTE(smoriya): /detail should only work against collections"},{"line_number":304,"context_line":"        parent \u003d pecan.request.path.split(\u0027/\u0027)[:-1][-1]"},{"line_number":305,"context_line":"        if parent !\u003d \"volume_connectors\":"},{"line_number":306,"context_line":"            raise exception.HTTPNotFound"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027volume_connectors\u0027, \u0027detail\u0027])"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_8812be60","line":305,"range":{"start_line":305,"start_character":22,"end_line":305,"end_character":39},"updated":"2016-08-04 11:27:24.000000000","message":"\"collectors\" is correct because request.path is \u0027.../volume/connectors/detail\u0027.","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"06a5408f1b55c4d53578cfdf497be2e3d0c80b17","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        if self.from_nodes:"},{"line_number":323,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        api_utils.check_allow_specify_fields(fields)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid("},{"line_number":328,"context_line":"            pecan.request.context, connector_uuid)"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_fa9d2ebc","line":325,"updated":"2016-08-03 15:46:48.000000000","message":"This also can be replaced with microversion validation for volume_connector.","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"06a5408f1b55c4d53578cfdf497be2e3d0c80b17","unresolved":false,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        :param connector: a volume connector within the request body."},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        if self.from_nodes:"},{"line_number":339,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        new_connector \u003d objects.VolumeConnector(pecan.request.context,"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_7a777e3b","line":338,"updated":"2016-08-03 15:46:48.000000000","message":"Need to check if microversion allows volume_connector.","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"06a5408f1b55c4d53578cfdf497be2e3d0c80b17","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        :param connector_uuid: UUID of a volume connector."},{"line_number":356,"context_line":"        :param patch: a json PATCH document to apply to this volume connector."},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        if self.from_nodes:"},{"line_number":359,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_baa57648","line":357,"updated":"2016-08-03 15:46:48.000000000","message":"ditto","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"06a5408f1b55c4d53578cfdf497be2e3d0c80b17","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        \"\"\"Delete a volume connector."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        :param connector_uuid: UUID of a volume connector."},{"line_number":401,"context_line":"        \"\"\""},{"line_number":402,"context_line":"        if self.from_nodes:"},{"line_number":403,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":404,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid("}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_5a443a73","line":401,"updated":"2016-08-03 15:46:48.000000000","message":"ditto","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8c4fc4738452cecc80a802aa0b6b66f111e44795","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def _get_node_uuid(self):"},{"line_number":49,"context_line":"        return self._node_uuid"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _set_node_uuid(self, connector_id):"},{"line_number":52,"context_line":"        if connector_id and self._node_uuid !\u003d connector_id:"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                # FIXME(smoriya): One should only allow UUID here, but"}],"source_content_type":"text/x-python","patch_set":38,"id":"bacf61ea_1762f73d","line":51,"range":{"start_line":51,"start_character":29,"end_line":51,"end_character":41},"updated":"2016-08-08 00:05:07.000000000","message":"We don\u0027t need to rename this argument to connector_id. This argument doesn\u0027t represent a member of volume_connector.","commit_id":"e6dd3589d54cbba4a2582cacdce8c335342e9729"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8c4fc4738452cecc80a802aa0b6b66f111e44795","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # NOTE(smoriya): /detail should only work against collections"},{"line_number":304,"context_line":"        parent \u003d pecan.request.path.split(\u0027/\u0027)[:-1][-1]"},{"line_number":305,"context_line":"        if parent !\u003d \"volume/connectors\":"},{"line_number":306,"context_line":"            raise exception.HTTPNotFound"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027volume/connectors\u0027, \u0027detail\u0027])"}],"source_content_type":"text/x-python","patch_set":38,"id":"bacf61ea_37e9fb7f","line":305,"range":{"start_line":305,"start_character":22,"end_line":305,"end_character":39},"updated":"2016-08-08 00:05:07.000000000","message":"It should be \u0027connectors\u0027. \u0027parent\u0027 consists of a result of split, which doesn\u0027t contain a separator(\u0027/\u0027).","commit_id":"e6dd3589d54cbba4a2582cacdce8c335342e9729"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9a4a7c054e0da6c9c4d9a8e37e79c3ee90ed87e0","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        # NOTE(smoriya): /detail should only work against collections"},{"line_number":304,"context_line":"        parent \u003d pecan.request.path.split(\u0027/\u0027)[:-1][-1]"},{"line_number":305,"context_line":"        if parent !\u003d \"volume/connectors\":"},{"line_number":306,"context_line":"            raise exception.HTTPNotFound"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027volume/connectors\u0027, \u0027detail\u0027])"}],"source_content_type":"text/x-python","patch_set":39,"id":"3ac371cc_b722ceb7","line":305,"updated":"2016-08-15 14:06:31.000000000","message":"This should be : if parent !\u003d \"connectors\".\n\nIf pecan.request.path is \u0027/v1/volume/connectors/detail\u0027,\nsplit returns [\u0027v1\u0027, \u0027volume\u0027, \u0027connectors\u0027, \u0027detail\u0027].\nThen, parent is \u0027connectors\u0027, which doesn\u0027t include \u0027/\u0027.","commit_id":"6a776abd480e83646efb3357864b5f678cb2875e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":185,"context_line":"class VolumeConnectorsController(rest.RestController):"},{"line_number":186,"context_line":"    \"\"\"REST controller for VolumeConnectors.\"\"\""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    from_nodes \u003d False"},{"line_number":189,"context_line":"    \"\"\"A flag to indicate if the requests to this controller are coming"},{"line_number":190,"context_line":"    from the top-level resource Nodes.\"\"\""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    _custom_actions \u003d {"},{"line_number":193,"context_line":"        \u0027detail\u0027: [\u0027GET\u0027],"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_7bb35598","line":190,"range":{"start_line":188,"start_character":0,"end_line":190,"end_character":41},"updated":"2016-08-18 14:57:17.000000000","message":"remove","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    }"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    invalid_sort_key_list \u003d [\u0027extra\u0027]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _get_volume_connectors_collection(self, node_ident, marker, limit,"},{"line_number":199,"context_line":"                                          sort_key, sort_dir,"},{"line_number":200,"context_line":"                                          resource_url\u003dNone,"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_5b75b9c8","line":197,"updated":"2016-08-18 14:57:17.000000000","message":"add:\n\n    def __init__(self, node_id\u003dNone):\n        super(VolumeConnectorsController, self).__init__()\n        self.node_id_from_node \u003d node_id","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                          sort_key, sort_dir,"},{"line_number":200,"context_line":"                                          resource_url\u003dNone,"},{"line_number":201,"context_line":"                                          fields\u003dNone):"},{"line_number":202,"context_line":"        if self.from_nodes and not node_ident:"},{"line_number":203,"context_line":"            raise exception.MissingParameterValue("},{"line_number":204,"context_line":"                _(\"Node identifier not specified.\"))"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        limit \u003d api_utils.validate_limit(limit)"},{"line_number":207,"context_line":"        sort_dir \u003d api_utils.validate_sort_dir(sort_dir)"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_1b46a17a","line":204,"range":{"start_line":202,"start_character":0,"end_line":204,"end_character":52},"updated":"2016-08-18 14:57:17.000000000","message":"remove","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":216,"context_line":"                _(\"The sort_key value %(key)s is an invalid field for \""},{"line_number":217,"context_line":"                  \"sorting\") % {\u0027key\u0027: sort_key})"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        if node_ident:"},{"line_number":220,"context_line":"            # FIXME(comstud): Since all we need is the node ID, we can"},{"line_number":221,"context_line":"            #                 make this more efficient by only querying"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_1b14e14a","line":218,"updated":"2016-08-18 14:57:17.000000000","message":"add:\n\nnode_ident \u003d self.node_id_from_node or node_ident","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        :param fields: Optional, a list with a specified set of fields"},{"line_number":320,"context_line":"            of the resource to be returned."},{"line_number":321,"context_line":"        \"\"\""},{"line_number":322,"context_line":"        if self.from_nodes:"},{"line_number":323,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        api_utils.check_allow_specify_fields(fields)"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_8617d843","line":322,"range":{"start_line":322,"start_character":9,"end_line":322,"end_character":27},"updated":"2016-08-18 14:57:17.000000000","message":"replace:\n\nif self.node_id_from_node:","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        :param connector: a volume connector within the request body."},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        if self.from_nodes:"},{"line_number":339,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        new_connector \u003d objects.VolumeConnector(pecan.request.context,"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_463840d3","line":338,"range":{"start_line":338,"start_character":8,"end_line":338,"end_character":27},"updated":"2016-08-18 14:57:17.000000000","message":"replace:\n\nif self.node_id_from_node:","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        :param connector_uuid: UUID of a volume connector."},{"line_number":356,"context_line":"        :param patch: a json PATCH document to apply to this volume connector."},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        if self.from_nodes:"},{"line_number":359,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid("}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_66445c49","line":358,"range":{"start_line":358,"start_character":8,"end_line":358,"end_character":27},"updated":"2016-08-18 14:57:17.000000000","message":"replace:\n\nif self.node_id_from_node:","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        :param connector_uuid: UUID of a volume connector."},{"line_number":401,"context_line":"        \"\"\""},{"line_number":402,"context_line":"        if self.from_nodes:"},{"line_number":403,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":404,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid("},{"line_number":405,"context_line":"            pecan.request.context, connector_uuid)"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_466680ed","line":402,"range":{"start_line":402,"start_character":8,"end_line":402,"end_character":27},"updated":"2016-08-18 14:57:17.000000000","message":"if self.node_id_from_node:","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def _get_node_uuid(self):"},{"line_number":49,"context_line":"        return self._node_uuid"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _set_node_uuid(self, connector_id):"},{"line_number":52,"context_line":"        if connector_id and self._node_uuid !\u003d connector_id:"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                # FIXME(smoriya): One should only allow UUID here, but"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_41bd0cb6","line":51,"range":{"start_line":51,"start_character":29,"end_line":51,"end_character":41},"updated":"2016-08-29 12:43:49.000000000","message":"Is this node_uuid?","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"34eff1af1bb51e1b3228f0b8f920305f82917041","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def _get_node_uuid(self):"},{"line_number":49,"context_line":"        return self._node_uuid"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _set_node_uuid(self, connector_id):"},{"line_number":52,"context_line":"        if connector_id and self._node_uuid !\u003d connector_id:"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                # FIXME(smoriya): One should only allow UUID here, but"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_c94809b6","line":51,"range":{"start_line":51,"start_character":29,"end_line":51,"end_character":41},"in_reply_to":"fa7ab95a_41bd0cb6","updated":"2016-08-30 15:03:57.000000000","message":"It should be \u0027value\u0027.\nThis mistake seems to have happened when renaming \u0027value\u0027 to \u0027connector_id\u0027 in volume_connector object.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def _get_node_uuid(self):"},{"line_number":49,"context_line":"        return self._node_uuid"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _set_node_uuid(self, connector_id):"},{"line_number":52,"context_line":"        if connector_id and self._node_uuid !\u003d connector_id:"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                # FIXME(smoriya): One should only allow UUID here, but"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_bdcff57d","line":51,"range":{"start_line":51,"start_character":29,"end_line":51,"end_character":41},"in_reply_to":"fa7ab95a_c94809b6","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return self._node_uuid"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _set_node_uuid(self, connector_id):"},{"line_number":52,"context_line":"        if connector_id and self._node_uuid !\u003d connector_id:"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                # FIXME(smoriya): One should only allow UUID here, but"},{"line_number":55,"context_line":"                # there seems to be a bug in that tests are passing an"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_9b2867e4","line":52,"range":{"start_line":52,"start_character":34,"end_line":52,"end_character":59},"updated":"2016-08-29 12:43:49.000000000","message":"Sorry, I can\u0027t understand why are we comparing node_uuid with connector_id.\nIn which condition can these two values equals to each other?\n\nreference: https://review.openstack.org/#/c/200983/37/ironic/db/sqlalchemy/alembic/versions/daa1ba02d98_add_volume_connectors_table.py@37","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return self._node_uuid"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _set_node_uuid(self, connector_id):"},{"line_number":52,"context_line":"        if connector_id and self._node_uuid !\u003d connector_id:"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                # FIXME(smoriya): One should only allow UUID here, but"},{"line_number":55,"context_line":"                # there seems to be a bug in that tests are passing an"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_ddcae96d","line":52,"range":{"start_line":52,"start_character":34,"end_line":52,"end_character":59},"in_reply_to":"fa7ab95a_9b2867e4","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    def __init__(self, node_id\u003dNone):"},{"line_number":195,"context_line":"        \"\"\" \"\"\""},{"line_number":196,"context_line":"        super(VolumeConnectorsController, self).__init__()"},{"line_number":197,"context_line":"        self.node_id_from_node \u003d node_id"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_volume_connectors_collection(self, node_ident, marker, limit,"},{"line_number":200,"context_line":"                                          sort_key, sort_dir,"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_5c96d23f","line":197,"range":{"start_line":197,"start_character":8,"end_line":197,"end_character":40},"updated":"2016-08-29 12:43:49.000000000","message":"Is there any reason why this and another one[1] does not consistent with each other?\n\n[1]: https://review.openstack.org/#/c/214586/42/ironic/api/controllers/v1/volume_target.py@195","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"34eff1af1bb51e1b3228f0b8f920305f82917041","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    def __init__(self, node_id\u003dNone):"},{"line_number":195,"context_line":"        \"\"\" \"\"\""},{"line_number":196,"context_line":"        super(VolumeConnectorsController, self).__init__()"},{"line_number":197,"context_line":"        self.node_id_from_node \u003d node_id"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_volume_connectors_collection(self, node_ident, marker, limit,"},{"line_number":200,"context_line":"                                          sort_key, sort_dir,"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_ac4af352","line":197,"range":{"start_line":197,"start_character":8,"end_line":197,"end_character":40},"in_reply_to":"fa7ab95a_5c96d23f","updated":"2016-08-30 15:03:57.000000000","message":"We should fix VolumeTargetController.\n\nNow, \u0027parent_node_ident\u0027 would a better name because the name in referred patch was changed[1].\n\n[1] https://review.openstack.org/#/c/314514/20/ironic/api/controllers/v1/port.py@228","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    def __init__(self, node_id\u003dNone):"},{"line_number":195,"context_line":"        \"\"\" \"\"\""},{"line_number":196,"context_line":"        super(VolumeConnectorsController, self).__init__()"},{"line_number":197,"context_line":"        self.node_id_from_node \u003d node_id"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_volume_connectors_collection(self, node_ident, marker, limit,"},{"line_number":200,"context_line":"                                          sort_key, sort_dir,"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_bd7d351e","line":197,"range":{"start_line":197,"start_character":8,"end_line":197,"end_character":40},"in_reply_to":"fa7ab95a_ac4af352","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            of the resource to be returned."},{"line_number":320,"context_line":"        \"\"\""},{"line_number":321,"context_line":"        if self.node_id_from_node:"},{"line_number":322,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        api_utils.check_allow_specify_fields(fields)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_a7fb48c0","line":322,"range":{"start_line":322,"start_character":28,"end_line":322,"end_character":49},"updated":"2016-08-29 12:43:49.000000000","message":"This should be OperationNotPermitted(), IMO.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            of the resource to be returned."},{"line_number":320,"context_line":"        \"\"\""},{"line_number":321,"context_line":"        if self.node_id_from_node:"},{"line_number":322,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        api_utils.check_allow_specify_fields(fields)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_ddf589cb","line":322,"range":{"start_line":322,"start_character":28,"end_line":322,"end_character":49},"in_reply_to":"fa7ab95a_a7fb48c0","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        :param connector: a volume connector within the request body."},{"line_number":336,"context_line":"        \"\"\""},{"line_number":337,"context_line":"        if self.node_id_from_node:"},{"line_number":338,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        new_connector \u003d objects.VolumeConnector(pecan.request.context,"},{"line_number":341,"context_line":"                                                **connector.as_dict())"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_c7f84cc6","line":338,"range":{"start_line":338,"start_character":28,"end_line":338,"end_character":49},"updated":"2016-08-29 12:43:49.000000000","message":"Ditto.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        :param connector: a volume connector within the request body."},{"line_number":336,"context_line":"        \"\"\""},{"line_number":337,"context_line":"        if self.node_id_from_node:"},{"line_number":338,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        new_connector \u003d objects.VolumeConnector(pecan.request.context,"},{"line_number":341,"context_line":"                                                **connector.as_dict())"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_fd040dc1","line":338,"range":{"start_line":338,"start_character":28,"end_line":338,"end_character":49},"in_reply_to":"fa7ab95a_c7f84cc6","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        :param patch: a json PATCH document to apply to this volume connector."},{"line_number":356,"context_line":"        \"\"\""},{"line_number":357,"context_line":"        if self.node_id_from_node:"},{"line_number":358,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid("},{"line_number":361,"context_line":"            pecan.request.context, connector_uuid)"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_e718f020","line":358,"range":{"start_line":358,"start_character":28,"end_line":358,"end_character":49},"updated":"2016-08-29 12:43:49.000000000","message":"Ditto.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        :param patch: a json PATCH document to apply to this volume connector."},{"line_number":356,"context_line":"        \"\"\""},{"line_number":357,"context_line":"        if self.node_id_from_node:"},{"line_number":358,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid("},{"line_number":361,"context_line":"            pecan.request.context, connector_uuid)"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_1d00e1a9","line":358,"range":{"start_line":358,"start_character":28,"end_line":358,"end_character":49},"in_reply_to":"fa7ab95a_e718f020","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        :param connector_uuid: UUID of a volume connector."},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        if self.node_id_from_node:"},{"line_number":402,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":403,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid("},{"line_number":404,"context_line":"            pecan.request.context, connector_uuid)"},{"line_number":405,"context_line":"        rpc_node \u003d objects.Node.get_by_id(pecan.request.context,"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_07c4f45c","line":402,"range":{"start_line":402,"start_character":28,"end_line":402,"end_character":49},"updated":"2016-08-29 12:43:49.000000000","message":"Ditto.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        :param connector_uuid: UUID of a volume connector."},{"line_number":400,"context_line":"        \"\"\""},{"line_number":401,"context_line":"        if self.node_id_from_node:"},{"line_number":402,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":403,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid("},{"line_number":404,"context_line":"            pecan.request.context, connector_uuid)"},{"line_number":405,"context_line":"        rpc_node \u003d objects.Node.get_by_id(pecan.request.context,"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_5d30999e","line":402,"range":{"start_line":402,"start_character":28,"end_line":402,"end_character":49},"in_reply_to":"fa7ab95a_07c4f45c","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a1f48846996b7efb9379f7ba715477334792c597","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    @expose.expose(VolumeConnectorCollection, types.uuid_or_name, types.uuid,"},{"line_number":239,"context_line":"                   types.uuid, int, wtypes.text, wtypes.text, types.listtype)"},{"line_number":240,"context_line":"    def get_all(self, node\u003dNone, node_uuid\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":241,"context_line":"                sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027, fields\u003dNone):"},{"line_number":242,"context_line":"        \"\"\"Retrieve a list of volume connectors."},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":57,"id":"1a6eadb0_c8450818","line":240,"updated":"2016-12-19 20:07:15.000000000","message":"take a look at existing API-level code for nodes, etc. Since this was written, we\u0027ve added decorators for metrics (@METRICS.timer()) as well as policy checks (policy.authorize(...))","commit_id":"7dc1bd19293b02a3e0141a1fc0d7150eb063bab7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7b0799c83b26fc3718a05c554e590d15afc8ac32","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    @expose.expose(VolumeConnectorCollection, types.uuid_or_name, types.uuid,"},{"line_number":239,"context_line":"                   types.uuid, int, wtypes.text, wtypes.text, types.listtype)"},{"line_number":240,"context_line":"    def get_all(self, node\u003dNone, node_uuid\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":241,"context_line":"                sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027, fields\u003dNone):"},{"line_number":242,"context_line":"        \"\"\"Retrieve a list of volume connectors."},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":57,"id":"1a6eadb0_4bd8121e","line":240,"in_reply_to":"1a6eadb0_c8450818","updated":"2016-12-19 20:47:50.000000000","message":"Oh, I see you have the policy checks; I\u0027ve added a comment about that below.","commit_id":"7dc1bd19293b02a3e0141a1fc0d7150eb063bab7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7b0799c83b26fc3718a05c554e590d15afc8ac32","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if not api_utils.allow_volume():"},{"line_number":259,"context_line":"            raise exception.NotFound()"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        cdict \u003d pecan.request.context.to_dict()"},{"line_number":262,"context_line":"        policy.authorize(\u0027baremetal:volume:get\u0027, cdict, cdict)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        if fields is None:"}],"source_content_type":"text/x-python","patch_set":57,"id":"1a6eadb0_8be14ad3","line":261,"updated":"2016-12-19 20:47:50.000000000","message":"and this should be pecan.request.context.to_policy_values(). (See https://review.openstack.org/#/c/411764/ which just merged.)","commit_id":"7dc1bd19293b02a3e0141a1fc0d7150eb063bab7"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def _set_node_uuid(self, value):"},{"line_number":56,"context_line":"        if value and self._node_uuid !\u003d value:"},{"line_number":57,"context_line":"            try:"},{"line_number":58,"context_line":"                # FIXME(smoriya): One should only allow UUID here, but"},{"line_number":59,"context_line":"                # there seems to be a bug in that tests are passing an"},{"line_number":60,"context_line":"                # ID. See bug #1301046 for more details."},{"line_number":61,"context_line":"                node \u003d objects.Node.get(pecan.request.context, value)"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_6def5cb0","line":58,"updated":"2017-04-03 22:16:26.000000000","message":"it\u0027s not the issue with tests passing with non-uuid. It\u0027s the issue with *allowing* non-uuid values for patch methods for ports and portgroups. Please do not make this error also here. Please see:\nhttps://review.openstack.org/#/c/403910/ for a fix (also - feel welcome to review :))","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def _set_node_uuid(self, value):"},{"line_number":56,"context_line":"        if value and self._node_uuid !\u003d value:"},{"line_number":57,"context_line":"            try:"},{"line_number":58,"context_line":"                # FIXME(smoriya): One should only allow UUID here, but"},{"line_number":59,"context_line":"                # there seems to be a bug in that tests are passing an"},{"line_number":60,"context_line":"                # ID. See bug #1301046 for more details."},{"line_number":61,"context_line":"                node \u003d objects.Node.get(pecan.request.context, value)"}],"source_content_type":"text/x-python","patch_set":72,"id":"bff0334d_145f2442","line":58,"in_reply_to":"dfeb2761_6def5cb0","updated":"2017-04-05 16:04:08.000000000","message":"Done\n\nI will update this patch when the patch for port and portgroup is changed.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":259,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: \"asc\"."},{"line_number":260,"context_line":"        :param fields: Optional, a list with a specified set of fields"},{"line_number":261,"context_line":"                       of the resource to be returned."},{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        if not api_utils.allow_volume():"},{"line_number":264,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_4d637843","line":261,"updated":"2017-04-03 22:16:26.000000000","message":"please add :raises","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":259,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: \"asc\"."},{"line_number":260,"context_line":"        :param fields: Optional, a list with a specified set of fields"},{"line_number":261,"context_line":"                       of the resource to be returned."},{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        if not api_utils.allow_volume():"},{"line_number":264,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":72,"id":"bff0334d_6a98c869","line":261,"in_reply_to":"dfeb2761_4d637843","updated":"2017-04-05 16:04:08.000000000","message":"Done","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        # NOTE(smoriya): /detail should only work against collections"},{"line_number":303,"context_line":"        parent \u003d pecan.request.path.split(\u0027/\u0027)[:-1][-1]"},{"line_number":304,"context_line":"        if parent !\u003d \"connectors\":"},{"line_number":305,"context_line":"            raise exception.HTTPNotFound()"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027volume/connectors\u0027, \u0027detail\u0027])"},{"line_number":308,"context_line":"        return self._get_volume_connectors_collection(node_uuid or node,"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_8d50605f","line":305,"updated":"2017-04-03 22:16:26.000000000","message":"what is the difference between this and lines 297 and 264?","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        # NOTE(smoriya): /detail should only work against collections"},{"line_number":303,"context_line":"        parent \u003d pecan.request.path.split(\u0027/\u0027)[:-1][-1]"},{"line_number":304,"context_line":"        if parent !\u003d \"connectors\":"},{"line_number":305,"context_line":"            raise exception.HTTPNotFound()"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027volume/connectors\u0027, \u0027detail\u0027])"},{"line_number":308,"context_line":"        return self._get_volume_connectors_collection(node_uuid or node,"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_37551e1e","line":305,"in_reply_to":"dfeb2761_8d50605f","updated":"2017-04-05 16:04:08.000000000","message":"There is no difference. Just coded same as portgroup.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        policy.authorize(\u0027baremetal:volume:get\u0027, cdict, cdict)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if self.parent_node_ident:"},{"line_number":329,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid("},{"line_number":332,"context_line":"            pecan.request.context, connector_uuid)"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_ededac8b","line":329,"updated":"2017-04-03 22:16:26.000000000","message":"This exception inherits from NotAuthorized which results in http error 403 Forbidden. I don\u0027t think it is a right exception here. It should be 400 invalid.\nhttps://bugs.launchpad.net/ironic/+bug/1673877","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        policy.authorize(\u0027baremetal:volume:create\u0027, cdict, cdict)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        if self.parent_node_ident:"},{"line_number":351,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        connector_dict \u003d connector.as_dict()"},{"line_number":354,"context_line":"        # NOTE(hshiina): UUID is mandatory for notification payload"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_cd04284d","line":351,"updated":"2017-04-03 22:16:26.000000000","message":"ditto","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        policy.authorize(\u0027baremetal:volume:update\u0027, cdict, cdict)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        if self.parent_node_ident:"},{"line_number":391,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid(context,"},{"line_number":394,"context_line":"                                                            connector_uuid)"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_4d96d8f2","line":391,"updated":"2017-04-03 22:16:26.000000000","message":"ditto","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            if rpc_connector[field] !\u003d patch_val:"},{"line_number":417,"context_line":"                rpc_connector[field] \u003d patch_val"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        rpc_node \u003d objects.Node.get_by_id(context,"},{"line_number":420,"context_line":"                                          rpc_connector.node_id)"},{"line_number":421,"context_line":"        notify.emit_start_notification(context, rpc_connector, \u0027update\u0027,"},{"line_number":422,"context_line":"                                       node_uuid\u003drpc_node.uuid)"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_cd89c8ca","line":419,"updated":"2017-04-03 22:16:26.000000000","message":"if the node_uuid was part of the update, shouldn\u0027t we notify new node?","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            if rpc_connector[field] !\u003d patch_val:"},{"line_number":417,"context_line":"                rpc_connector[field] \u003d patch_val"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        rpc_node \u003d objects.Node.get_by_id(context,"},{"line_number":420,"context_line":"                                          rpc_connector.node_id)"},{"line_number":421,"context_line":"        notify.emit_start_notification(context, rpc_connector, \u0027update\u0027,"},{"line_number":422,"context_line":"                                       node_uuid\u003drpc_node.uuid)"}],"source_content_type":"text/x-python","patch_set":72,"id":"bff0334d_d4aadc17","line":419,"in_reply_to":"dfeb2761_cd89c8ca","updated":"2017-04-05 16:04:08.000000000","message":"I don\u0027t think it\u0027s necessary. For the old node, the volume connector is deleted. We need to be confirm the connector is not used. For the new node, it\u0027s the same case as created a new connector, which can be created without notification.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        policy.authorize(\u0027baremetal:volume:delete\u0027, cdict, cdict)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        if self.parent_node_ident:"},{"line_number":449,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid(context,"},{"line_number":452,"context_line":"                                                            connector_uuid)"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_2d99541e","line":449,"updated":"2017-04-03 22:16:26.000000000","message":"ditto","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"a4d9680567394aa94d04c82f15e18ff462cac0a8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def _get_node_uuid(self):"},{"line_number":54,"context_line":"        return self._node_uuid"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _set_node_identifiers(self, value):"},{"line_number":57,"context_line":"        \"\"\"Set both UUID and ID of a node for VolumeConnector object"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        :param value: UUID or ID of a node"}],"source_content_type":"text/x-python","patch_set":74,"id":"bff0334d_f22a7be5","line":56,"updated":"2017-04-06 00:23:43.000000000","message":"that is good enough, thanks!","commit_id":"d59c0aa71880d304426e01233fd3684d21a1976e"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"a4d9680567394aa94d04c82f15e18ff462cac0a8","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                  connector is found."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":274,"context_line":"        :raises: HTTPForbidden If access is not allowed by the policy."},{"line_number":275,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":276,"context_line":"        :raises: InvalidParameterValue If sort key is invalid for sorting."},{"line_number":277,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":74,"id":"bff0334d_9239ef42","line":274,"updated":"2017-04-06 00:23:43.000000000","message":"this is sort of obvious and can be applied to any method. I don\u0027t think it\u0027s necessary.","commit_id":"d59c0aa71880d304426e01233fd3684d21a1976e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"b0c350bf94b093cbded03c11eaf26ab9b2e28c28","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                  connector is found."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":274,"context_line":"        :raises: HTTPForbidden If access is not allowed by the policy."},{"line_number":275,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":276,"context_line":"        :raises: InvalidParameterValue If sort key is invalid for sorting."},{"line_number":277,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":74,"id":"bff0334d_635fbf41","line":274,"in_reply_to":"bff0334d_9239ef42","updated":"2017-04-06 05:24:15.000000000","message":"Done","commit_id":"d59c0aa71880d304426e01233fd3684d21a1976e"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"a4d9680567394aa94d04c82f15e18ff462cac0a8","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        :raises: NotFound if requested with specifying a volume connector UUID."},{"line_number":316,"context_line":"        :raises: HTTPForbidden If access is not allowed by the policy."},{"line_number":317,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":318,"context_line":"        :raises: InvalidParameterValue If sort key is invalid for sorting."},{"line_number":319,"context_line":"        \"\"\""},{"line_number":320,"context_line":"        if not api_utils.allow_volume():"},{"line_number":321,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":74,"id":"bff0334d_f2139bb7","line":318,"updated":"2017-04-06 00:23:43.000000000","message":"this single uppercase letter bothers me a little :( \ns/If/if/ to make it look like everywhere else (same in line 316 and in docstrings below)","commit_id":"d59c0aa71880d304426e01233fd3684d21a1976e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"b0c350bf94b093cbded03c11eaf26ab9b2e28c28","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        :raises: NotFound if requested with specifying a volume connector UUID."},{"line_number":316,"context_line":"        :raises: HTTPForbidden If access is not allowed by the policy."},{"line_number":317,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":318,"context_line":"        :raises: InvalidParameterValue If sort key is invalid for sorting."},{"line_number":319,"context_line":"        \"\"\""},{"line_number":320,"context_line":"        if not api_utils.allow_volume():"},{"line_number":321,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":74,"id":"bff0334d_0356b32a","line":318,"in_reply_to":"bff0334d_f2139bb7","updated":"2017-04-06 05:24:15.000000000","message":"Done","commit_id":"d59c0aa71880d304426e01233fd3684d21a1976e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        :param value: UUID or ID of a node"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        if value \u003d\u003d wtypes.Unset or not api_utils.allow_volume():"},{"line_number":62,"context_line":"            self._node_uuid \u003d wtypes.Unset"},{"line_number":63,"context_line":"        elif value and self._node_uuid !\u003d value:"},{"line_number":64,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_978cb7d7","line":61,"range":{"start_line":61,"start_character":40,"end_line":61,"end_character":64},"updated":"2017-05-23 14:09:46.000000000","message":"What\u0027s the point of having this check here? I think it should be done in the methods exposed in the API, not in the setters.","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        :param value: UUID or ID of a node"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        if value \u003d\u003d wtypes.Unset or not api_utils.allow_volume():"},{"line_number":62,"context_line":"            self._node_uuid \u003d wtypes.Unset"},{"line_number":63,"context_line":"        elif value and self._node_uuid !\u003d value:"},{"line_number":64,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_7a93f901","line":61,"range":{"start_line":61,"start_character":40,"end_line":61,"end_character":64},"in_reply_to":"ff0f0b1f_978cb7d7","updated":"2017-05-26 05:06:45.000000000","message":"Done\nYes, it\u0027s unnecessary here.","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        # was passed to the constructor."},{"line_number":116,"context_line":"        node_ident \u003d kwargs.get(\u0027node_uuid\u0027) or kwargs.get(\u0027node_id\u0027,"},{"line_number":117,"context_line":"                                                           wtypes.Unset)"},{"line_number":118,"context_line":"        self._set_node_identifiers(node_ident)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @staticmethod"},{"line_number":121,"context_line":"    def _convert_with_links(connector, url, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_f213015b","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":46},"updated":"2017-05-23 14:09:46.000000000","message":"nit - I\u0027d prefer using setattr here instead of directly calling private setter.","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        # was passed to the constructor."},{"line_number":116,"context_line":"        node_ident \u003d kwargs.get(\u0027node_uuid\u0027) or kwargs.get(\u0027node_id\u0027,"},{"line_number":117,"context_line":"                                                           wtypes.Unset)"},{"line_number":118,"context_line":"        self._set_node_identifiers(node_ident)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @staticmethod"},{"line_number":121,"context_line":"    def _convert_with_links(connector, url, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_3aa34103","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":46},"in_reply_to":"ff0f0b1f_f213015b","updated":"2017-05-26 05:06:45.000000000","message":"Done","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    @METRICS.timer(\u0027VolumeConnectorsController.get_all\u0027)"},{"line_number":250,"context_line":"    @expose.expose(VolumeConnectorCollection, types.uuid_or_name, types.uuid,"},{"line_number":251,"context_line":"                   types.uuid, int, wtypes.text, wtypes.text, types.listtype)"},{"line_number":252,"context_line":"    def get_all(self, node\u003dNone, node_uuid\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":253,"context_line":"                sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027, fields\u003dNone):"},{"line_number":254,"context_line":"        \"\"\"Retrieve a list of volume connectors."},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_f222e151","line":252,"range":{"start_line":252,"start_character":33,"end_line":252,"end_character":47},"updated":"2017-05-23 14:09:46.000000000","message":"Let\u0027s not have this, node_uuid was left in older controller for backwards compatibility with old api versions, I\u0027d just leave the node argument.","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    @METRICS.timer(\u0027VolumeConnectorsController.get_all\u0027)"},{"line_number":250,"context_line":"    @expose.expose(VolumeConnectorCollection, types.uuid_or_name, types.uuid,"},{"line_number":251,"context_line":"                   types.uuid, int, wtypes.text, wtypes.text, types.listtype)"},{"line_number":252,"context_line":"    def get_all(self, node\u003dNone, node_uuid\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":253,"context_line":"                sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027, fields\u003dNone):"},{"line_number":254,"context_line":"        \"\"\"Retrieve a list of volume connectors."},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_3a9d810a","line":252,"range":{"start_line":252,"start_character":33,"end_line":252,"end_character":47},"in_reply_to":"ff0f0b1f_f222e151","updated":"2017-05-26 05:06:45.000000000","message":"Done","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _set_node_identifiers(self, value):"},{"line_number":57,"context_line":"        \"\"\"Set both UUID and ID of a node for VolumeConnector object"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        :param value: UUID or ID of a node"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        if value \u003d\u003d wtypes.Unset:"},{"line_number":62,"context_line":"            self._node_uuid \u003d wtypes.Unset"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_f78a81bc","line":59,"updated":"2017-06-28 21:13:00.000000000","message":"could also be wtypes.Unset","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _set_node_identifiers(self, value):"},{"line_number":57,"context_line":"        \"\"\"Set both UUID and ID of a node for VolumeConnector object"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        :param value: UUID or ID of a node"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        if value \u003d\u003d wtypes.Unset:"},{"line_number":62,"context_line":"            self._node_uuid \u003d wtypes.Unset"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_5ae143fe","line":59,"in_reply_to":"5f201791_f78a81bc","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        \"\"\"Retrieve a list of volume connectors."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"},{"line_number":256,"context_line":"        of the \u0027node\u0027 interface"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        :param node: UUID or name of a node, to get only volume connectors"},{"line_number":259,"context_line":"                     for that node."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_379d9909","line":256,"updated":"2017-06-28 21:13:00.000000000","message":"I think these two lines are a copy/paste from node.py? Anyway, they don\u0027t apply here so you can delete them.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        \"\"\"Retrieve a list of volume connectors."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"},{"line_number":256,"context_line":"        of the \u0027node\u0027 interface"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        :param node: UUID or name of a node, to get only volume connectors"},{"line_number":259,"context_line":"                     for that node."}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_1a918b53","line":256,"in_reply_to":"5f201791_379d9909","updated":"2017-06-30 08:42:19.000000000","message":"Thanks. I didn\u0027t remove it when I removed node_uuid from parameters.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        :param node: UUID or name of a node, to get only volume connectors"},{"line_number":259,"context_line":"                     for that node."},{"line_number":260,"context_line":"        :param marker: pagination marker for large data sets."},{"line_number":261,"context_line":"        :param limit: maximum number of resources to return in a single result."},{"line_number":262,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":263,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: \"asc\"."},{"line_number":264,"context_line":"        :param fields: Optional, a list with a specified set of fields"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_978b4dbe","line":261,"updated":"2017-06-28 21:13:00.000000000","message":"nit, we have this additional description in most of the other objects, might want to add it here too. I guess it caused confusion before so someone wanted it clarified.\n\n                      This value cannot be larger than the value of max_limit\n                      in the [api] section of the ironic configuration, or only\n                      max_limit resources will be returned.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        :param node: UUID or name of a node, to get only volume connectors"},{"line_number":259,"context_line":"                     for that node."},{"line_number":260,"context_line":"        :param marker: pagination marker for large data sets."},{"line_number":261,"context_line":"        :param limit: maximum number of resources to return in a single result."},{"line_number":262,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":263,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: \"asc\"."},{"line_number":264,"context_line":"        :param fields: Optional, a list with a specified set of fields"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_b3af4b93","line":261,"in_reply_to":"5f201791_978b4dbe","updated":"2017-06-30 08:42:19.000000000","message":"Done, Thanks.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        :returns: a list of volume connectors, or an empty list if no volume"},{"line_number":268,"context_line":"                  connector is found."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":271,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":272,"context_line":"        :raises: InvalidParameterValue if sort key is invalid for sorting."},{"line_number":273,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_97a46d4c","line":270,"updated":"2017-06-28 21:13:00.000000000","message":"i think you can delete this","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        :returns: a list of volume connectors, or an empty list if no volume"},{"line_number":268,"context_line":"                  connector is found."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":271,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":272,"context_line":"        :raises: InvalidParameterValue if sort key is invalid for sorting."},{"line_number":273,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_7a83df05","line":270,"in_reply_to":"5f201791_97a46d4c","updated":"2017-06-30 08:42:19.000000000","message":"Done, thanks.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        resource_url \u003d \u0027volume/connectors\u0027"},{"line_number":281,"context_line":"        return self._get_volume_connectors_collection(node, marker, limit,"},{"line_number":282,"context_line":"                                                      sort_key, sort_dir,"},{"line_number":283,"context_line":"                                                      resource_url,"},{"line_number":284,"context_line":"                                                      fields\u003dfields)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @METRICS.timer(\u0027VolumeConnectorsController.detail\u0027)"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_f7616106","line":283,"updated":"2017-06-28 21:13:00.000000000","message":"nit, s/resource_url/resource_url\u003dresource_url/","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        resource_url \u003d \u0027volume/connectors\u0027"},{"line_number":281,"context_line":"        return self._get_volume_connectors_collection(node, marker, limit,"},{"line_number":282,"context_line":"                                                      sort_key, sort_dir,"},{"line_number":283,"context_line":"                                                      resource_url,"},{"line_number":284,"context_line":"                                                      fields\u003dfields)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @METRICS.timer(\u0027VolumeConnectorsController.detail\u0027)"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_7ae63feb","line":283,"in_reply_to":"5f201791_f7616106","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        \"\"\"Retrieve a list of volume connectors with detail."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"},{"line_number":294,"context_line":"        of the \u0027node\u0027 interface"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        :param node: UUID or name of a node, to get only connectors for that"},{"line_number":297,"context_line":"                     node."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_17b97d77","line":294,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        \"\"\"Retrieve a list of volume connectors with detail."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"},{"line_number":294,"context_line":"        of the \u0027node\u0027 interface"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        :param node: UUID or name of a node, to get only connectors for that"},{"line_number":297,"context_line":"                     node."}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_5a04a37b","line":294,"in_reply_to":"5f201791_17b97d77","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        :returns: a list of volume connectors with detail, or an empty list if"},{"line_number":304,"context_line":"                  no volume connector is found."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":307,"context_line":"        :raises: NotFound if requested with specifying a volume connector UUID."},{"line_number":308,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":309,"context_line":"        :raises: InvalidParameterValue if sort key is invalid for sorting."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_576815f3","line":306,"updated":"2017-06-28 21:13:00.000000000","message":"i think you can delete this","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        :returns: a list of volume connectors with detail, or an empty list if"},{"line_number":304,"context_line":"                  no volume connector is found."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":307,"context_line":"        :raises: NotFound if requested with specifying a volume connector UUID."},{"line_number":308,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":309,"context_line":"        :raises: InvalidParameterValue if sort key is invalid for sorting."}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_1af62b91","line":306,"in_reply_to":"5f201791_576815f3","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        return self._get_volume_connectors_collection(node,"},{"line_number":321,"context_line":"                                                      marker, limit,"},{"line_number":322,"context_line":"                                                      sort_key, sort_dir,"},{"line_number":323,"context_line":"                                                      resource_url)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    @METRICS.timer(\u0027VolumeConnectorsController.get_one\u0027)"},{"line_number":326,"context_line":"    @expose.expose(VolumeConnector, types.uuid, types.listtype)"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_d77305e6","line":323,"updated":"2017-06-28 21:13:00.000000000","message":"nit, s/resource_url/resource_url\u003dresource_url/","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        return self._get_volume_connectors_collection(node,"},{"line_number":321,"context_line":"                                                      marker, limit,"},{"line_number":322,"context_line":"                                                      sort_key, sort_dir,"},{"line_number":323,"context_line":"                                                      resource_url)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    @METRICS.timer(\u0027VolumeConnectorsController.get_one\u0027)"},{"line_number":326,"context_line":"    @expose.expose(VolumeConnector, types.uuid, types.listtype)"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_9f5e98e4","line":323,"in_reply_to":"5f201791_d77305e6","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        :returns: API-serializable volume connector object."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":337,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a parent"},{"line_number":338,"context_line":"                 node."},{"line_number":339,"context_line":"        :raises: VolumeConnectorNotFound if no volume connector exists with"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_77331115","line":336,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        :returns: API-serializable volume connector object."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":337,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a parent"},{"line_number":338,"context_line":"                 node."},{"line_number":339,"context_line":"        :raises: VolumeConnectorNotFound if no volume connector exists with"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_5f700073","line":336,"in_reply_to":"5f201791_77331115","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        :returns: API-serializable volume connector object."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":363,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a parent"},{"line_number":364,"context_line":"                 node."},{"line_number":365,"context_line":"        :raises: VolumeConnectorTypeAndIdAlreadyExists if a volume"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_b72c09ac","line":362,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        :returns: API-serializable volume connector object."},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":363,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a parent"},{"line_number":364,"context_line":"                 node."},{"line_number":365,"context_line":"        :raises: VolumeConnectorTypeAndIdAlreadyExists if a volume"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_1f6a887f","line":362,"in_reply_to":"5f201791_b72c09ac","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"421f1638a61c5ca9471b4bd1da85adb8ef81f568","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    @wsme.validate(types.uuid, [VolumeConnectorPatchType])"},{"line_number":399,"context_line":"    @expose.expose(VolumeConnector, types.uuid,"},{"line_number":400,"context_line":"                   body\u003d[VolumeConnectorPatchType])"},{"line_number":401,"context_line":"    def patch(self, connector_uuid, patch):"},{"line_number":402,"context_line":"        \"\"\"Update an existing volume connector."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        :param connector_uuid: UUID of a volume connector."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_6d621eb0","line":401,"updated":"2017-06-28 21:33:22.000000000","message":"Like delete below, I don\u0027t see us blocking this to only when the node is powered off.  The spec calls for the node to be powered off.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    @wsme.validate(types.uuid, [VolumeConnectorPatchType])"},{"line_number":399,"context_line":"    @expose.expose(VolumeConnector, types.uuid,"},{"line_number":400,"context_line":"                   body\u003d[VolumeConnectorPatchType])"},{"line_number":401,"context_line":"    def patch(self, connector_uuid, patch):"},{"line_number":402,"context_line":"        \"\"\"Update an existing volume connector."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        :param connector_uuid: UUID of a volume connector."}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_5f1ec00c","line":401,"in_reply_to":"5f201791_6d621eb0","updated":"2017-06-30 08:42:19.000000000","message":"I submitted a patch for power validation in conductor.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        :returns: API-serializable volume connector object."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":410,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a"},{"line_number":411,"context_line":"                 parent node."},{"line_number":412,"context_line":"        :raises: PatchError if a given patch can not be applied."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_b21ad76b","line":409,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        :returns: API-serializable volume connector object."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":410,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a"},{"line_number":411,"context_line":"                 parent node."},{"line_number":412,"context_line":"        :raises: PatchError if a given patch can not be applied."}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_9fe1f801","line":409,"in_reply_to":"5f201791_b21ad76b","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        values \u003d api_utils.get_patch_values(patch, \u0027/node_uuid\u0027)"},{"line_number":433,"context_line":"        for value in values:"},{"line_number":434,"context_line":"            if not uuidutils.is_uuid_like(value):"},{"line_number":435,"context_line":"                raise exception.InvalidUUID(uuid\u003dsix.text_type(value))"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid(context,"},{"line_number":438,"context_line":"                                                            connector_uuid)"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_12586b2e","line":435,"updated":"2017-06-28 21:13:00.000000000","message":"might be useful if the exception mentioned that it is the node_uuid that is invalid.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        values \u003d api_utils.get_patch_values(patch, \u0027/node_uuid\u0027)"},{"line_number":433,"context_line":"        for value in values:"},{"line_number":434,"context_line":"            if not uuidutils.is_uuid_like(value):"},{"line_number":435,"context_line":"                raise exception.InvalidUUID(uuid\u003dsix.text_type(value))"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        rpc_connector \u003d objects.VolumeConnector.get_by_uuid(context,"},{"line_number":438,"context_line":"                                                            connector_uuid)"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_9fb698d9","line":435,"in_reply_to":"5f201791_12586b2e","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    @METRICS.timer(\u0027VolumeConnectorsController.delete\u0027)"},{"line_number":479,"context_line":"    @expose.expose(None, types.uuid, status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":480,"context_line":"    def delete(self, connector_uuid):"},{"line_number":481,"context_line":"        \"\"\"Delete a volume connector."},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        :param connector_uuid: UUID of a volume connector."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_12106bff","line":480,"updated":"2017-06-28 21:13:00.000000000","message":"I was just wondering if we allow deletion at any time, regardless of what state the node is in or whatever. but perhaps that is addressed in some future patch.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"df2fde2beb6b2b96fc2f5927f3bab01be0be6fa5","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    @METRICS.timer(\u0027VolumeConnectorsController.delete\u0027)"},{"line_number":479,"context_line":"    @expose.expose(None, types.uuid, status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":480,"context_line":"    def delete(self, connector_uuid):"},{"line_number":481,"context_line":"        \"\"\"Delete a volume connector."},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        :param connector_uuid: UUID of a volume connector."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_2d20a69a","line":480,"in_reply_to":"5f201791_12106bff","updated":"2017-06-28 21:21:13.000000000","message":"That is a really good question.  I feel like that was discussed quite a bit with the spec, but I think we would have to go dig through the volume connection info spec discussion for clarity.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1ad47e4a8c893235a3394053d6785f57b12951c8","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    @METRICS.timer(\u0027VolumeConnectorsController.delete\u0027)"},{"line_number":479,"context_line":"    @expose.expose(None, types.uuid, status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":480,"context_line":"    def delete(self, connector_uuid):"},{"line_number":481,"context_line":"        \"\"\"Delete a volume connector."},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        :param connector_uuid: UUID of a volume connector."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_6d9d7eba","line":480,"in_reply_to":"5f201791_2d20a69a","updated":"2017-06-28 21:28:59.000000000","message":"The spec calls for 204 on success, 404 if not found, or 405 if not in power_off.  So it makes sense to guard in the API I guess since we are looking up the node object and should as a result have the current power state as represented in the DB.  The conductor code appears not to guard power state for the destroy call.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    @METRICS.timer(\u0027VolumeConnectorsController.delete\u0027)"},{"line_number":479,"context_line":"    @expose.expose(None, types.uuid, status_code\u003dhttp_client.NO_CONTENT)"},{"line_number":480,"context_line":"    def delete(self, connector_uuid):"},{"line_number":481,"context_line":"        \"\"\"Delete a volume connector."},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        :param connector_uuid: UUID of a volume connector."}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_bfff1466","line":480,"in_reply_to":"5f201791_6d9d7eba","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        :param connector_uuid: UUID of a volume connector."},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":486,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a"},{"line_number":487,"context_line":"                 parent node."},{"line_number":488,"context_line":"        :raises: NodeLocked if node is locked by another conductor"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_52eee321","line":485,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        :param connector_uuid: UUID of a volume connector."},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":486,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a"},{"line_number":487,"context_line":"                 parent node."},{"line_number":488,"context_line":"        :raises: NodeLocked if node is locked by another conductor"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_df0ad088","line":485,"in_reply_to":"5f201791_52eee321","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"892f6ccd95e97c9cc8c53c9d589fed905bb7db67","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    \"\"\"REST controller for VolumeConnectors.\"\"\""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    _custom_actions \u003d {"},{"line_number":199,"context_line":"        \u0027detail\u0027: [\u0027GET\u0027],"},{"line_number":200,"context_line":"    }"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    invalid_sort_key_list \u003d [\u0027extra\u0027]"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_2e0cd139","line":199,"updated":"2017-07-02 11:26:37.000000000","message":"ouch. I know we do this horrible thing in other places (sigh), but let\u0027s please not introduce it again. the right way to do it is to create a \"detail\" URL paremeter.","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    \"\"\"REST controller for VolumeConnectors.\"\"\""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    _custom_actions \u003d {"},{"line_number":199,"context_line":"        \u0027detail\u0027: [\u0027GET\u0027],"},{"line_number":200,"context_line":"    }"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    invalid_sort_key_list \u003d [\u0027extra\u0027]"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_c8c54d3e","line":199,"in_reply_to":"3f1d235d_2e0cd139","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"892f6ccd95e97c9cc8c53c9d589fed905bb7db67","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    @expose.expose(VolumeConnectorCollection, types.uuid_or_name, types.uuid,"},{"line_number":250,"context_line":"                   int, wtypes.text, wtypes.text, types.listtype)"},{"line_number":251,"context_line":"    def get_all(self, node\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":252,"context_line":"                sort_dir\u003d\u0027asc\u0027, fields\u003dNone):"},{"line_number":253,"context_line":"        \"\"\"Retrieve a list of volume connectors."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        :param node: UUID or name of a node, to get only volume connectors"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_0e13555e","line":252,"updated":"2017-07-02 11:26:37.000000000","message":"detail has to go here ^^^","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    @expose.expose(VolumeConnectorCollection, types.uuid_or_name, types.uuid,"},{"line_number":250,"context_line":"                   int, wtypes.text, wtypes.text, types.listtype)"},{"line_number":251,"context_line":"    def get_all(self, node\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":252,"context_line":"                sort_dir\u003d\u0027asc\u0027, fields\u003dNone):"},{"line_number":253,"context_line":"        \"\"\"Retrieve a list of volume connectors."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        :param node: UUID or name of a node, to get only volume connectors"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_a8c0d12b","line":252,"in_reply_to":"3f1d235d_0e13555e","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"892f6ccd95e97c9cc8c53c9d589fed905bb7db67","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    @expose.expose(VolumeConnectorCollection, types.uuid_or_name, types.uuid,"},{"line_number":286,"context_line":"                   int, wtypes.text, wtypes.text)"},{"line_number":287,"context_line":"    def detail(self, node\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":288,"context_line":"               sort_dir\u003d\u0027asc\u0027):"},{"line_number":289,"context_line":"        \"\"\"Retrieve a list of volume connectors with detail."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        :param node: UUID or name of a node, to get only connectors for that"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_ee0db935","line":288,"updated":"2017-07-02 11:26:37.000000000","message":"and this should go away","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    @expose.expose(VolumeConnectorCollection, types.uuid_or_name, types.uuid,"},{"line_number":286,"context_line":"                   int, wtypes.text, wtypes.text)"},{"line_number":287,"context_line":"    def detail(self, node\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":288,"context_line":"               sort_dir\u003d\u0027asc\u0027):"},{"line_number":289,"context_line":"        \"\"\"Retrieve a list of volume connectors with detail."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        :param node: UUID or name of a node, to get only connectors for that"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_68e079cd","line":288,"in_reply_to":"3f1d235d_ee0db935","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"4d546b2606d74ad8823364ba3d791b8dec7e8124","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                   int, wtypes.text, wtypes.text, types.listtype,"},{"line_number":250,"context_line":"                   types.boolean)"},{"line_number":251,"context_line":"    def get_all(self, node\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":252,"context_line":"                sort_dir\u003d\u0027asc\u0027, fields\u003dNone, detail\u003dNone):"},{"line_number":253,"context_line":"        \"\"\"Retrieve a list of volume connectors."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        :param node: UUID or name of a node, to get only volume connectors"}],"source_content_type":"text/x-python","patch_set":101,"id":"3f1d235d_07ee68b3","line":252,"range":{"start_line":252,"start_character":45,"end_line":252,"end_character":56},"updated":"2017-07-04 10:29:58.000000000","message":"need to reflect this change in the spec","commit_id":"c380e05dbf84079b01fb3b0ea099ef9b293b9b3d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"53956aebca394e3ff57fe8728c7ff970985ae0ce","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                   int, wtypes.text, wtypes.text, types.listtype,"},{"line_number":250,"context_line":"                   types.boolean)"},{"line_number":251,"context_line":"    def get_all(self, node\u003dNone, marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027,"},{"line_number":252,"context_line":"                sort_dir\u003d\u0027asc\u0027, fields\u003dNone, detail\u003dNone):"},{"line_number":253,"context_line":"        \"\"\"Retrieve a list of volume connectors."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        :param node: UUID or name of a node, to get only volume connectors"}],"source_content_type":"text/x-python","patch_set":101,"id":"3f1d235d_392ce3aa","line":252,"range":{"start_line":252,"start_character":45,"end_line":252,"end_character":56},"in_reply_to":"3f1d235d_07ee68b3","updated":"2017-07-04 13:49:08.000000000","message":"I think the api-ref entries would be more important.  This kind of just follows existing api patterns in our API.","commit_id":"c380e05dbf84079b01fb3b0ea099ef9b293b9b3d"}],"ironic/api/controllers/v1/volume_target.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9a4a7c054e0da6c9c4d9a8e37e79c3ee90ed87e0","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        # NOTE(smoriya): /detail should only work against collections"},{"line_number":308,"context_line":"        parent \u003d pecan.request.path.split(\u0027/\u0027)[:-1][-1]"},{"line_number":309,"context_line":"        if parent !\u003d \"volume_targets\":"},{"line_number":310,"context_line":"            raise exception.HTTPNotFound"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027volume_targets\u0027, \u0027detail\u0027])"}],"source_content_type":"text/x-python","patch_set":39,"id":"3ac371cc_8281524d","line":309,"updated":"2016-08-15 14:06:31.000000000","message":"This line should be: if parent !\u003d \"targets\":","commit_id":"6a776abd480e83646efb3357864b5f678cb2875e"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            of the resource to be returned."},{"line_number":324,"context_line":"        \"\"\""},{"line_number":325,"context_line":"        if self.from_nodes:"},{"line_number":326,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        api_utils.check_allow_specify_fields(fields)"},{"line_number":329,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_fc4c06ca","line":326,"range":{"start_line":326,"start_character":28,"end_line":326,"end_character":49},"updated":"2016-08-29 12:43:49.000000000","message":"OperationNotPermitted(), IMO.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            of the resource to be returned."},{"line_number":324,"context_line":"        \"\"\""},{"line_number":325,"context_line":"        if self.from_nodes:"},{"line_number":326,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        api_utils.check_allow_specify_fields(fields)"},{"line_number":329,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_7d42bd11","line":326,"range":{"start_line":326,"start_character":28,"end_line":326,"end_character":49},"in_reply_to":"9a89bdaa_c43a70cd","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"9386726cf05af5334fbad863ee2d4205eec40534","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            of the resource to be returned."},{"line_number":324,"context_line":"        \"\"\""},{"line_number":325,"context_line":"        if self.from_nodes:"},{"line_number":326,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        api_utils.check_allow_specify_fields(fields)"},{"line_number":329,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"9a89bdaa_c43a70cd","line":326,"range":{"start_line":326,"start_character":28,"end_line":326,"end_character":49},"in_reply_to":"fa7ab95a_fc4c06ca","updated":"2016-09-05 07:27:08.000000000","message":"I find that according to the doc[1]. Raising an exception instance and raising an exception class are both valid.\n\n[1]: https://docs.python.org/2/tutorial/errors.html#raising-exceptions\n\nBut I grep the whole ironic code and find no any other place that raises an exception class.\nSo I suggestion to make it consistent with others.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        :param target: a volume target within the request body."},{"line_number":340,"context_line":"        \"\"\""},{"line_number":341,"context_line":"        if self.from_nodes:"},{"line_number":342,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        new_target \u003d objects.VolumeTarget(pecan.request.context,"},{"line_number":345,"context_line":"                                          **target.as_dict())"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_9cd4dabd","line":342,"range":{"start_line":342,"start_character":28,"end_line":342,"end_character":49},"updated":"2016-08-29 12:43:49.000000000","message":"Ditto.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        :param target: a volume target within the request body."},{"line_number":340,"context_line":"        \"\"\""},{"line_number":341,"context_line":"        if self.from_nodes:"},{"line_number":342,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        new_target \u003d objects.VolumeTarget(pecan.request.context,"},{"line_number":345,"context_line":"                                          **target.as_dict())"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_bd4c5543","line":342,"range":{"start_line":342,"start_character":28,"end_line":342,"end_character":49},"in_reply_to":"fa7ab95a_9cd4dabd","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        :param patch: a json PATCH document to apply to this volume target."},{"line_number":360,"context_line":"        \"\"\""},{"line_number":361,"context_line":"        if self.from_nodes:"},{"line_number":362,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid("},{"line_number":365,"context_line":"            pecan.request.context, target_uuid)"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_fce326a2","line":362,"range":{"start_line":362,"start_character":28,"end_line":362,"end_character":49},"updated":"2016-08-29 12:43:49.000000000","message":"Ditto.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        :param patch: a json PATCH document to apply to this volume target."},{"line_number":360,"context_line":"        \"\"\""},{"line_number":361,"context_line":"        if self.from_nodes:"},{"line_number":362,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid("},{"line_number":365,"context_line":"            pecan.request.context, target_uuid)"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_fd56cdd0","line":362,"range":{"start_line":362,"start_character":28,"end_line":362,"end_character":49},"in_reply_to":"fa7ab95a_fce326a2","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7d6a7ac6213ed14df8eec08a104623cda1bf9c33","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        :param target_uuid: UUID of a volume target."},{"line_number":404,"context_line":"        \"\"\""},{"line_number":405,"context_line":"        if self.from_nodes:"},{"line_number":406,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":407,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid("},{"line_number":408,"context_line":"            pecan.request.context, target_uuid)"},{"line_number":409,"context_line":"        rpc_node \u003d objects.Node.get_by_id(pecan.request.context,"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_7ce636b1","line":406,"range":{"start_line":406,"start_character":28,"end_line":406,"end_character":49},"updated":"2016-08-29 12:43:49.000000000","message":"Ditto.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        :param target_uuid: UUID of a volume target."},{"line_number":404,"context_line":"        \"\"\""},{"line_number":405,"context_line":"        if self.from_nodes:"},{"line_number":406,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":407,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid("},{"line_number":408,"context_line":"            pecan.request.context, target_uuid)"},{"line_number":409,"context_line":"        rpc_node \u003d objects.Node.get_by_id(pecan.request.context,"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_dd47491b","line":406,"range":{"start_line":406,"start_character":28,"end_line":406,"end_character":49},"in_reply_to":"fa7ab95a_7ce636b1","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        :param limit: maximum number of resources to return in a single result."},{"line_number":263,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":264,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: \"asc\"."},{"line_number":265,"context_line":"        :param fields: Optional, a list with a specified set of fields"},{"line_number":266,"context_line":"                       of the resource to be returned."},{"line_number":267,"context_line":"        \"\"\""},{"line_number":268,"context_line":"        if not api_utils.allow_volume():"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_6d8e3cd1","line":265,"updated":"2017-04-03 22:16:26.000000000","message":"please add :raises","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        :param limit: maximum number of resources to return in a single result."},{"line_number":263,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":264,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: \"asc\"."},{"line_number":265,"context_line":"        :param fields: Optional, a list with a specified set of fields"},{"line_number":266,"context_line":"                       of the resource to be returned."},{"line_number":267,"context_line":"        \"\"\""},{"line_number":268,"context_line":"        if not api_utils.allow_volume():"}],"source_content_type":"text/x-python","patch_set":72,"id":"bff0334d_c7e22d30","line":265,"in_reply_to":"dfeb2761_6d8e3cd1","updated":"2017-04-05 16:04:08.000000000","message":"Done","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        # NOTE(smoriya): /detail should only work against collections"},{"line_number":307,"context_line":"        parent \u003d pecan.request.path.split(\u0027/\u0027)[:-1][-1]"},{"line_number":308,"context_line":"        if parent !\u003d \"targets\":"},{"line_number":309,"context_line":"            raise exception.HTTPNotFound()"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027volume_targets\u0027, \u0027detail\u0027])"},{"line_number":312,"context_line":"        return self._get_volume_targets_collection(node_uuid or node, marker,"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_cdb2e894","line":309,"updated":"2017-04-03 22:16:26.000000000","message":"same as in previous file: what is the difference between these exceptions?","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        # NOTE(smoriya): /detail should only work against collections"},{"line_number":307,"context_line":"        parent \u003d pecan.request.path.split(\u0027/\u0027)[:-1][-1]"},{"line_number":308,"context_line":"        if parent !\u003d \"targets\":"},{"line_number":309,"context_line":"            raise exception.HTTPNotFound()"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027volume_targets\u0027, \u0027detail\u0027])"},{"line_number":312,"context_line":"        return self._get_volume_targets_collection(node_uuid or node, marker,"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_001c0076","line":309,"in_reply_to":"dfeb2761_cdb2e894","updated":"2017-04-05 16:04:08.000000000","message":"No difference. Just mimicked portgroup.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        target_dict \u003d target.as_dict()"},{"line_number":359,"context_line":"        # NOTE(hshiina): UUID is mandatory for notificatin payload"},{"line_number":360,"context_line":"        if not target_dict.get(\u0027uuid\u0027):"},{"line_number":361,"context_line":"            target_dict[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_4d649822","line":359,"updated":"2017-04-03 22:16:26.000000000","message":"s/notificatin/notifications/","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9fe0cd9cf0768931dbffbbc079485a9ffe4426ea","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        target_dict \u003d target.as_dict()"},{"line_number":359,"context_line":"        # NOTE(hshiina): UUID is mandatory for notificatin payload"},{"line_number":360,"context_line":"        if not target_dict.get(\u0027uuid\u0027):"},{"line_number":361,"context_line":"            target_dict[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_b2449c1c","line":359,"in_reply_to":"dfeb2761_4d649822","updated":"2017-04-05 16:04:08.000000000","message":"Done","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        policy.authorize(\u0027baremetal:volume:delete\u0027, cdict, cdict)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        if self.parent_node_ident:"},{"line_number":451,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid(context, target_uuid)"},{"line_number":454,"context_line":"        rpc_node \u003d objects.Node.get_by_id(context, rpc_target.node_id)"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_ed700cdf","line":451,"updated":"2017-04-03 22:16:26.000000000","message":"Please apply my general comments from previous file to this file, also.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        :param value: UUID or ID of a node"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        if value \u003d\u003d wtypes.Unset or not api_utils.allow_volume():"},{"line_number":63,"context_line":"            self._node_uuid \u003d wtypes.Unset"},{"line_number":64,"context_line":"        elif value and self._node_uuid !\u003d value:"},{"line_number":65,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_f2954141","line":62,"range":{"start_line":62,"start_character":36,"end_line":62,"end_character":64},"updated":"2017-05-23 14:09:46.000000000","message":"ditto","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        :param value: UUID or ID of a node"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        if value \u003d\u003d wtypes.Unset or not api_utils.allow_volume():"},{"line_number":63,"context_line":"            self._node_uuid \u003d wtypes.Unset"},{"line_number":64,"context_line":"        elif value and self._node_uuid !\u003d value:"},{"line_number":65,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_ba9071ef","line":62,"range":{"start_line":62,"start_character":36,"end_line":62,"end_character":64},"in_reply_to":"ff0f0b1f_f2954141","updated":"2017-05-26 05:06:45.000000000","message":"Done","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # was passed to the constructor."},{"line_number":123,"context_line":"        node_ident \u003d kwargs.get(\u0027node_uuid\u0027) or kwargs.get(\u0027node_id\u0027,"},{"line_number":124,"context_line":"                                                           wtypes.Unset)"},{"line_number":125,"context_line":"        self._set_node_identifiers(node_ident)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @staticmethod"},{"line_number":128,"context_line":"    def _convert_with_links(target, url, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_92984575","line":125,"updated":"2017-05-23 14:09:46.000000000","message":"ditto","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        # was passed to the constructor."},{"line_number":123,"context_line":"        node_ident \u003d kwargs.get(\u0027node_uuid\u0027) or kwargs.get(\u0027node_id\u0027,"},{"line_number":124,"context_line":"                                                           wtypes.Unset)"},{"line_number":125,"context_line":"        self._set_node_identifiers(node_ident)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @staticmethod"},{"line_number":128,"context_line":"    def _convert_with_links(target, url, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_7abc196c","line":125,"in_reply_to":"ff0f0b1f_92984575","updated":"2017-05-26 05:06:45.000000000","message":"Done","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @classmethod"},{"line_number":159,"context_line":"    def sample(cls, expand\u003dTrue):"},{"line_number":160,"context_line":"        sample \u003d cls(uuid\u003d\u002786cfd480-0842-4abb-8386-e46149beb82f\u0027,"},{"line_number":161,"context_line":"                     type\u003d\u0027iqn\u0027,"},{"line_number":162,"context_line":"                     value\u003d\u0027iqn.2010-10.org.openstack:51332b70524\u0027,"},{"line_number":163,"context_line":"                     extra\u003d{\u0027foo\u0027: \u0027bar\u0027},"},{"line_number":164,"context_line":"                     created_at\u003ddatetime.datetime.utcnow(),"},{"line_number":165,"context_line":"                     updated_at\u003ddatetime.datetime.utcnow())"},{"line_number":166,"context_line":"        sample._node_uuid \u003d \u00277ae81bb3-dec3-4289-8d6c-da80bd8001ae\u0027"},{"line_number":167,"context_line":"        fields \u003d None if expand else _DEFAULT_RETURN_FIELDS"},{"line_number":168,"context_line":"        return cls._convert_with_links(sample, \u0027http://localhost:6385\u0027,"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_72b931ca","line":165,"range":{"start_line":160,"start_character":21,"end_line":165,"end_character":58},"updated":"2017-05-23 14:09:46.000000000","message":"Hrm, it needs to contain things that are listed in the fields of this class like properties, boot_index etc.","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @classmethod"},{"line_number":159,"context_line":"    def sample(cls, expand\u003dTrue):"},{"line_number":160,"context_line":"        sample \u003d cls(uuid\u003d\u002786cfd480-0842-4abb-8386-e46149beb82f\u0027,"},{"line_number":161,"context_line":"                     type\u003d\u0027iqn\u0027,"},{"line_number":162,"context_line":"                     value\u003d\u0027iqn.2010-10.org.openstack:51332b70524\u0027,"},{"line_number":163,"context_line":"                     extra\u003d{\u0027foo\u0027: \u0027bar\u0027},"},{"line_number":164,"context_line":"                     created_at\u003ddatetime.datetime.utcnow(),"},{"line_number":165,"context_line":"                     updated_at\u003ddatetime.datetime.utcnow())"},{"line_number":166,"context_line":"        sample._node_uuid \u003d \u00277ae81bb3-dec3-4289-8d6c-da80bd8001ae\u0027"},{"line_number":167,"context_line":"        fields \u003d None if expand else _DEFAULT_RETURN_FIELDS"},{"line_number":168,"context_line":"        return cls._convert_with_links(sample, \u0027http://localhost:6385\u0027,"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_a9df09d5","line":165,"range":{"start_line":160,"start_character":21,"end_line":165,"end_character":58},"in_reply_to":"ff0f0b1f_72b931ca","updated":"2017-05-26 05:06:45.000000000","message":"Good catch, Thanks!","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    \"\"\"A list containing volume target objects\"\"\""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def __init__(self, **kwargs):"},{"line_number":184,"context_line":"        self._type \u003d \u0027targets\u0027"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @staticmethod"},{"line_number":187,"context_line":"    def convert_with_links(rpc_targets, limit, url\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_7207f183","line":184,"updated":"2017-05-23 14:09:46.000000000","message":"I\u0027m not sure where this is used but I see the same pattern across all api objects","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    \"\"\"A list containing volume target objects\"\"\""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def __init__(self, **kwargs):"},{"line_number":184,"context_line":"        self._type \u003d \u0027targets\u0027"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @staticmethod"},{"line_number":187,"context_line":"    def convert_with_links(rpc_targets, limit, url\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_1493ac5e","line":184,"in_reply_to":"ff0f0b1f_7207f183","updated":"2017-05-26 05:06:45.000000000","message":"This is used as a name of collection and used for creating \u0027next\u0027 link as a default resource URL when limit is given[1]. I noticed this can not used for volume connectors and targets because they contain a slash in resource URL. I fixed to pass url to convert_with_links. \n\n[1] https://github.com/openstack/ironic/blob/13d91bd7b43e0e1a931fe6b5f7338a64b627ff50/ironic/api/controllers/v1/collection.py#L41\n\nThanks!","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    @METRICS.timer(\u0027VolumeTargetsController.get_all\u0027)"},{"line_number":255,"context_line":"    @expose.expose(VolumeTargetCollection, types.uuid_or_name, types.uuid,"},{"line_number":256,"context_line":"                   types.uuid, int, wtypes.text, wtypes.text, types.listtype)"},{"line_number":257,"context_line":"    def get_all(self, node\u003dNone, node_uuid\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":258,"context_line":"                sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027, fields\u003dNone):"},{"line_number":259,"context_line":"        \"\"\"Retrieve a list of volume targets."},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_521aadcb","line":257,"range":{"start_line":257,"start_character":33,"end_line":257,"end_character":47},"updated":"2017-05-23 14:09:46.000000000","message":"ditto","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    @METRICS.timer(\u0027VolumeTargetsController.get_all\u0027)"},{"line_number":255,"context_line":"    @expose.expose(VolumeTargetCollection, types.uuid_or_name, types.uuid,"},{"line_number":256,"context_line":"                   types.uuid, int, wtypes.text, wtypes.text, types.listtype)"},{"line_number":257,"context_line":"    def get_all(self, node\u003dNone, node_uuid\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":258,"context_line":"                sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027, fields\u003dNone):"},{"line_number":259,"context_line":"        \"\"\"Retrieve a list of volume targets."},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_9aa6cd53","line":257,"range":{"start_line":257,"start_character":33,"end_line":257,"end_character":47},"in_reply_to":"ff0f0b1f_521aadcb","updated":"2017-05-26 05:06:45.000000000","message":"Done","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    @METRICS.timer(\u0027VolumeTargetsController.detail\u0027)"},{"line_number":297,"context_line":"    @expose.expose(VolumeTargetCollection, types.uuid_or_name, types.uuid,"},{"line_number":298,"context_line":"                   types.uuid, int, wtypes.text, wtypes.text)"},{"line_number":299,"context_line":"    def detail(self, node\u003dNone, node_uuid\u003dNone, marker\u003dNone,"},{"line_number":300,"context_line":"               limit\u003dNone, sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027):"},{"line_number":301,"context_line":"        \"\"\"Retrieve a list of volume targets with detail."},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_d2259d0a","line":299,"range":{"start_line":299,"start_character":32,"end_line":299,"end_character":46},"updated":"2017-05-23 14:09:46.000000000","message":"ditto","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    @METRICS.timer(\u0027VolumeTargetsController.detail\u0027)"},{"line_number":297,"context_line":"    @expose.expose(VolumeTargetCollection, types.uuid_or_name, types.uuid,"},{"line_number":298,"context_line":"                   types.uuid, int, wtypes.text, wtypes.text)"},{"line_number":299,"context_line":"    def detail(self, node\u003dNone, node_uuid\u003dNone, marker\u003dNone,"},{"line_number":300,"context_line":"               limit\u003dNone, sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027):"},{"line_number":301,"context_line":"        \"\"\"Retrieve a list of volume targets with detail."},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_7a61b911","line":299,"range":{"start_line":299,"start_character":32,"end_line":299,"end_character":46},"in_reply_to":"ff0f0b1f_d2259d0a","updated":"2017-05-26 05:06:45.000000000","message":"Done","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"188810fbde01acb2790e77cb2243f08215e65aad","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        if self.parent_node_ident:"},{"line_number":362,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        api_utils.check_allow_specify_fields(fields)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid("},{"line_number":367,"context_line":"            pecan.request.context, target_uuid)"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_128555cf","line":364,"range":{"start_line":364,"start_character":8,"end_line":364,"end_character":52},"updated":"2017-05-23 14:09:46.000000000","message":"fields are allowed since 1.8, this whole controller is triggered only for \u003e\u003d 1.32, this is unnecessary :)","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f44718ecad5c8ce051785b21bf4e68879e4bbb77","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        if self.parent_node_ident:"},{"line_number":362,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        api_utils.check_allow_specify_fields(fields)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid("},{"line_number":367,"context_line":"            pecan.request.context, target_uuid)"}],"source_content_type":"text/x-python","patch_set":80,"id":"ff0f0b1f_3a446174","line":364,"range":{"start_line":364,"start_character":8,"end_line":364,"end_character":52},"in_reply_to":"ff0f0b1f_128555cf","updated":"2017-05-26 05:06:45.000000000","message":"Done","commit_id":"a35cc3928d719e4f21623c95a60f98178e876d51"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def _set_node_identifiers(self, value):"},{"line_number":58,"context_line":"        \"\"\"Set both UUID and ID of a node for VolumeTarget object"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        :param value: UUID or ID of a node"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        if value \u003d\u003d wtypes.Unset:"},{"line_number":63,"context_line":"            self._node_uuid \u003d wtypes.Unset"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_52d82351","line":60,"updated":"2017-06-28 21:13:00.000000000","message":"can be wtypes.Unset too","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def _set_node_identifiers(self, value):"},{"line_number":58,"context_line":"        \"\"\"Set both UUID and ID of a node for VolumeTarget object"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        :param value: UUID or ID of a node"},{"line_number":61,"context_line":"        \"\"\""},{"line_number":62,"context_line":"        if value \u003d\u003d wtypes.Unset:"},{"line_number":63,"context_line":"            self._node_uuid \u003d wtypes.Unset"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_9fa33850","line":60,"in_reply_to":"5f201791_52d82351","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                # Change error code because 404 (NotFound) is inappropriate"},{"line_number":73,"context_line":"                # response for a POST request to create a VolumeTarget"},{"line_number":74,"context_line":"                e.code \u003d http_client.BAD_REQUEST  # BadRequest"},{"line_number":75,"context_line":"                raise"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    uuid \u003d types.uuid"},{"line_number":78,"context_line":"    \"\"\"Unique UUID for this volume target\"\"\""}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_72be7fd5","line":75,"updated":"2017-06-28 21:13:00.000000000","message":"I\u0027m not crazy about all this copy/paste, but will leave that for someone to clean up on a rainy day.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        \u0027detail\u0027: [\u0027GET\u0027],"},{"line_number":218,"context_line":"    }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    invalid_sort_key_list \u003d [\u0027extra\u0027]"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def __init__(self, node_ident\u003dNone):"},{"line_number":223,"context_line":"        super(VolumeTargetsController, self).__init__()"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_3297e73c","line":220,"updated":"2017-06-28 21:13:00.000000000","message":"also \u0027properties\u0027","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        \u0027detail\u0027: [\u0027GET\u0027],"},{"line_number":218,"context_line":"    }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    invalid_sort_key_list \u003d [\u0027extra\u0027]"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def __init__(self, node_ident\u003dNone):"},{"line_number":223,"context_line":"        super(VolumeTargetsController, self).__init__()"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_9fbc586a","line":220,"in_reply_to":"5f201791_3297e73c","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        \"\"\"Retrieve a list of volume targets."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"},{"line_number":272,"context_line":"        of the \u0027node\u0027 interface"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        :param node: UUID or name of a node, to get only volume targets"},{"line_number":275,"context_line":"                     for that node."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_92d35b01","line":272,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        \"\"\"Retrieve a list of volume targets."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"},{"line_number":272,"context_line":"        of the \u0027node\u0027 interface"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        :param node: UUID or name of a node, to get only volume targets"},{"line_number":275,"context_line":"                     for that node."}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_ff622c16","line":272,"in_reply_to":"5f201791_92d35b01","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        :returns: a list of volume targets, or an empty list if no volume"},{"line_number":284,"context_line":"                  target is found."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":287,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":288,"context_line":"        :raises: InvalidParameterValue if sort key is invalid for sorting."},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_f2fbaf75","line":286,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        :returns: a list of volume targets, or an empty list if no volume"},{"line_number":284,"context_line":"                  target is found."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":287,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":288,"context_line":"        :raises: InvalidParameterValue if sort key is invalid for sorting."},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_bf6cb408","line":286,"in_reply_to":"5f201791_f2fbaf75","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        resource_url \u003d \u0027volume/targets\u0027"},{"line_number":298,"context_line":"        return self._get_volume_targets_collection(node, marker, limit,"},{"line_number":299,"context_line":"                                                   sort_key, sort_dir,"},{"line_number":300,"context_line":"                                                   resource_url,"},{"line_number":301,"context_line":"                                                   fields\u003dfields)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @METRICS.timer(\u0027VolumeTargetsController.detail\u0027)"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_52302356","line":300,"updated":"2017-06-28 21:13:00.000000000","message":"nit s/resource_url\u003dresource_url/","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        resource_url \u003d \u0027volume/targets\u0027"},{"line_number":298,"context_line":"        return self._get_volume_targets_collection(node, marker, limit,"},{"line_number":299,"context_line":"                                                   sort_key, sort_dir,"},{"line_number":300,"context_line":"                                                   resource_url,"},{"line_number":301,"context_line":"                                                   fields\u003dfields)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @METRICS.timer(\u0027VolumeTargetsController.detail\u0027)"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_5f7360e8","line":300,"in_reply_to":"5f201791_52302356","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        \"\"\"Retrieve a list of volume targets with detail."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"},{"line_number":311,"context_line":"        of the \u0027node\u0027 interface"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        :param node: UUID or name of a node, to get only targets for that"},{"line_number":314,"context_line":"                     node."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_d23b1335","line":311,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        \"\"\"Retrieve a list of volume targets with detail."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"},{"line_number":311,"context_line":"        of the \u0027node\u0027 interface"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        :param node: UUID or name of a node, to get only targets for that"},{"line_number":314,"context_line":"                     node."}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_ff4b4c84","line":311,"in_reply_to":"5f201791_d23b1335","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        :returns: a list of volume targets with detail, or an empty list if"},{"line_number":321,"context_line":"                  no volume target is found."},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":324,"context_line":"        :raises: NotFound if requested with specifying a volume target UUID."},{"line_number":325,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":326,"context_line":"        :raises: InvalidParameterValue if sort key is invalid for sorting."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_521943d4","line":323,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        :returns: a list of volume targets with detail, or an empty list if"},{"line_number":321,"context_line":"                  no volume target is found."},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":324,"context_line":"        :raises: NotFound if requested with specifying a volume target UUID."},{"line_number":325,"context_line":"        :raises: InvalidParameterValue if sort_key does not exist"},{"line_number":326,"context_line":"        :raises: InvalidParameterValue if sort key is invalid for sorting."}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_df509035","line":323,"in_reply_to":"5f201791_521943d4","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027volume_targets\u0027, \u0027detail\u0027])"},{"line_number":337,"context_line":"        return self._get_volume_targets_collection(node, marker, limit,"},{"line_number":338,"context_line":"                                                   sort_key, sort_dir,"},{"line_number":339,"context_line":"                                                   resource_url)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    @METRICS.timer(\u0027VolumeTargetsController.get_one\u0027)"},{"line_number":342,"context_line":"    @expose.expose(VolumeTarget, types.uuid, types.listtype)"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_921a3bc3","line":339,"updated":"2017-06-28 21:13:00.000000000","message":"nit s/resource_url/resource_url\u003dresource_url/","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        resource_url \u003d \u0027/\u0027.join([\u0027volume_targets\u0027, \u0027detail\u0027])"},{"line_number":337,"context_line":"        return self._get_volume_targets_collection(node, marker, limit,"},{"line_number":338,"context_line":"                                                   sort_key, sort_dir,"},{"line_number":339,"context_line":"                                                   resource_url)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    @METRICS.timer(\u0027VolumeTargetsController.get_one\u0027)"},{"line_number":342,"context_line":"    @expose.expose(VolumeTarget, types.uuid, types.listtype)"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_5f5c804a","line":339,"in_reply_to":"5f201791_921a3bc3","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        :returns: API-serializable volume target object."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":378,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a parent"},{"line_number":379,"context_line":"                 node."},{"line_number":380,"context_line":"        :raises: VolumeTargetBootIndexAlreadyExists if a volume target already"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_125d0b78","line":377,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        :returns: API-serializable volume target object."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":378,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a parent"},{"line_number":379,"context_line":"                 node."},{"line_number":380,"context_line":"        :raises: VolumeTargetBootIndexAlreadyExists if a volume target already"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_bf3a74e4","line":377,"in_reply_to":"5f201791_125d0b78","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        :returns: API-serializable volume target object."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":424,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a"},{"line_number":425,"context_line":"                 parent node."},{"line_number":426,"context_line":"        :raises: PatchError if a given patch can not be applied."}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_72979fed","line":423,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        :returns: API-serializable volume target object."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":424,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a"},{"line_number":425,"context_line":"                 parent node."},{"line_number":426,"context_line":"        :raises: PatchError if a given patch can not be applied."}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_5f2120b4","line":423,"in_reply_to":"5f201791_72979fed","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"421f1638a61c5ca9471b4bd1da85adb8ef81f568","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        if self.parent_node_ident:"},{"line_number":442,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        values \u003d api_utils.get_patch_values(patch, \u0027/node_uuid\u0027)"},{"line_number":445,"context_line":"        for value in values:"},{"line_number":446,"context_line":"            if not uuidutils.is_uuid_like(value):"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_4d3c0292","line":443,"updated":"2017-06-28 21:33:22.000000000","message":"I don\u0027t see us guarding from target updates while state is not POWER_OFF as indicated in the spec.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        if self.parent_node_ident:"},{"line_number":442,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        values \u003d api_utils.get_patch_values(patch, \u0027/node_uuid\u0027)"},{"line_number":445,"context_line":"        for value in values:"},{"line_number":446,"context_line":"            if not uuidutils.is_uuid_like(value):"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_ff190c88","line":443,"in_reply_to":"5f201791_4d3c0292","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        values \u003d api_utils.get_patch_values(patch, \u0027/node_uuid\u0027)"},{"line_number":445,"context_line":"        for value in values:"},{"line_number":446,"context_line":"            if not uuidutils.is_uuid_like(value):"},{"line_number":447,"context_line":"                raise exception.InvalidUUID(uuid\u003dsix.text_type(value))"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid(context, target_uuid)"},{"line_number":450,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_529a6313","line":447,"updated":"2017-06-28 21:13:00.000000000","message":"would it be useful to mention that it is node_uuid?","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        values \u003d api_utils.get_patch_values(patch, \u0027/node_uuid\u0027)"},{"line_number":445,"context_line":"        for value in values:"},{"line_number":446,"context_line":"            if not uuidutils.is_uuid_like(value):"},{"line_number":447,"context_line":"                raise exception.InvalidUUID(uuid\u003dsix.text_type(value))"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid(context, target_uuid)"},{"line_number":450,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_a20dbb38","line":447,"in_reply_to":"5f201791_529a6313","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        :param target_uuid: UUID of a volume target."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":496,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a"},{"line_number":497,"context_line":"                 parent node."},{"line_number":498,"context_line":"        :raises: NodeLocked if node is locked by another conductor"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_f2b3af96","line":495,"updated":"2017-06-28 21:13:00.000000000","message":"ditto","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        :param target_uuid: UUID of a volume target."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        :raises: NotFound if requested API version doesn\u0027t support volumes."},{"line_number":496,"context_line":"        :raises: OperationNotPermitted if accessed with specifying a"},{"line_number":497,"context_line":"                 parent node."},{"line_number":498,"context_line":"        :raises: NodeLocked if node is locked by another conductor"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_8212bf57","line":495,"in_reply_to":"5f201791_f2b3af96","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1ad47e4a8c893235a3394053d6785f57b12951c8","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        if self.parent_node_ident:"},{"line_number":508,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid(context, target_uuid)"},{"line_number":511,"context_line":"        rpc_node \u003d objects.Node.get_by_id(context, rpc_target.node_id)"},{"line_number":512,"context_line":"        notify.emit_start_notification(context, rpc_target, \u0027delete\u0027,"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_4dee4222","line":509,"updated":"2017-06-28 21:28:59.000000000","message":"Power state should be guarded, either here or in the conductor.  Per the specification, the power state must be POWER_OFF. It is not guarded in the conductor.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        if self.parent_node_ident:"},{"line_number":508,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        rpc_target \u003d objects.VolumeTarget.get_by_uuid(context, target_uuid)"},{"line_number":511,"context_line":"        rpc_node \u003d objects.Node.get_by_id(context, rpc_target.node_id)"},{"line_number":512,"context_line":"        notify.emit_start_notification(context, rpc_target, \u0027delete\u0027,"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_2232cbf2","line":509,"in_reply_to":"5f201791_4dee4222","updated":"2017-06-30 08:42:19.000000000","message":"I will add a guard to the conductor by another patch.","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        with notify.handle_error_notification(context, rpc_target, \u0027delete\u0027,"},{"line_number":515,"context_line":"                                              node_uuid\u003drpc_node.uuid):"},{"line_number":516,"context_line":"            topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":517,"context_line":"            pecan.request.rpcapi.destroy_volume_target(pecan.request.context,"},{"line_number":518,"context_line":"                                                       rpc_target, topic)"},{"line_number":519,"context_line":"        notify.emit_end_notification(context, rpc_target, \u0027delete\u0027,"},{"line_number":520,"context_line":"                                     node_uuid\u003drpc_node.uuid)"}],"source_content_type":"text/x-python","patch_set":96,"id":"5f201791_d27313e6","line":517,"updated":"2017-06-28 21:13:00.000000000","message":"nit s/pecan.request.context/context/","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        with notify.handle_error_notification(context, rpc_target, \u0027delete\u0027,"},{"line_number":515,"context_line":"                                              node_uuid\u003drpc_node.uuid):"},{"line_number":516,"context_line":"            topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":517,"context_line":"            pecan.request.rpcapi.destroy_volume_target(pecan.request.context,"},{"line_number":518,"context_line":"                                                       rpc_target, topic)"},{"line_number":519,"context_line":"        notify.emit_end_notification(context, rpc_target, \u0027delete\u0027,"},{"line_number":520,"context_line":"                                     node_uuid\u003drpc_node.uuid)"}],"source_content_type":"text/x-python","patch_set":96,"id":"3f1d235d_a226dbb6","line":517,"in_reply_to":"5f201791_d27313e6","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"892f6ccd95e97c9cc8c53c9d589fed905bb7db67","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    \"\"\"REST controller for VolumeTargets.\"\"\""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    _custom_actions \u003d {"},{"line_number":217,"context_line":"        \u0027detail\u0027: [\u0027GET\u0027],"},{"line_number":218,"context_line":"    }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    invalid_sort_key_list \u003d [\u0027extra\u0027, \u0027properties\u0027]"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_4e094d2a","line":217,"updated":"2017-07-02 11:26:37.000000000","message":"ditto about detail","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    \"\"\"REST controller for VolumeTargets.\"\"\""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    _custom_actions \u003d {"},{"line_number":217,"context_line":"        \u0027detail\u0027: [\u0027GET\u0027],"},{"line_number":218,"context_line":"    }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    invalid_sort_key_list \u003d [\u0027extra\u0027, \u0027properties\u0027]"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_03a326a0","line":217,"in_reply_to":"3f1d235d_4e094d2a","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"}],"ironic/common/policy.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ea8723fdbd10553ffb142aac7665c2c9b64b3e2","unresolved":false,"context_lines":[{"line_number":207,"context_line":"volume_policies \u003d ["},{"line_number":208,"context_line":"    policy.RuleDefault(\u0027baremetal:volume:get\u0027,"},{"line_number":209,"context_line":"                       \u0027rule:is_admin or rule:is_observer\u0027,"},{"line_number":210,"context_line":"                       description\u003d\u0027Retrieve Volume connector and target \u0027"},{"line_number":211,"context_line":"                                   \u0027records\u0027),"},{"line_number":212,"context_line":"    policy.RuleDefault(\u0027baremetal:volume:create\u0027,"},{"line_number":213,"context_line":"                       \u0027rule:is_admin\u0027,"},{"line_number":214,"context_line":"                       description\u003d\u0027Create Volume connector and target \u0027"}],"source_content_type":"text/x-python","patch_set":91,"id":"7f231b9d_9b1a5ac3","line":211,"range":{"start_line":210,"start_character":36,"end_line":211,"end_character":43},"updated":"2017-06-19 16:17:35.000000000","message":"I\u0027m kind of conflicted on the dual use of the policy, although I don\u0027t have strong feelings either way.\n\nI guess the use case might be some administrators would set connectors, where as others would set targets.  Likely not exactly worth splitting apart in this patch, given how large this has become. :(","commit_id":"f5bb90aebe3dea99cb82cb3b8acfc112e8bdb9c6"}],"ironic/tests/api/test_root.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0f6aa94ecbb7ba0fc62fc04ed7bf6bfdd61c627d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        not_resources \u003d (\u0027id\u0027, \u0027links\u0027, \u0027media_types\u0027)"},{"line_number":38,"context_line":"        actual_resources \u003d tuple(set(data.keys()) - set(not_resources))"},{"line_number":39,"context_line":"        expected_resources \u003d (\u0027chassis\u0027, \u0027drivers\u0027, \u0027nodes\u0027, \u0027ports\u0027,"},{"line_number":40,"context_line":"                              \u0027volume_connectors\u0027)"},{"line_number":41,"context_line":"        self.assertEqual(sorted(expected_resources), sorted(actual_resources))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self.assertIn({\u0027type\u0027: \u0027application/vnd.openstack.ironic.v1+json\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_995e5e11","line":40,"updated":"2015-08-22 16:37:22.000000000","message":"Wouldn\u0027t it make sense to test for presence of volume_connectors only if the API version was of a particular version?  Granted, that may not make sense, but it does provide insight into when that was added when someone is looking at the tests.","commit_id":"982dc3b8b97ed6e0f978882b9d639ee66b693c20"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"63bd3fa7baa84e6db89a5bbcfe3303df452da7c1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        not_resources \u003d (\u0027id\u0027, \u0027links\u0027, \u0027media_types\u0027)"},{"line_number":38,"context_line":"        actual_resources \u003d tuple(set(data.keys()) - set(not_resources))"},{"line_number":39,"context_line":"        expected_resources \u003d (\u0027chassis\u0027, \u0027drivers\u0027, \u0027nodes\u0027, \u0027ports\u0027,"},{"line_number":40,"context_line":"                              \u0027volume_connectors\u0027)"},{"line_number":41,"context_line":"        self.assertEqual(sorted(expected_resources), sorted(actual_resources))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self.assertIn({\u0027type\u0027: \u0027application/vnd.openstack.ironic.v1+json\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_41c74f45","line":40,"in_reply_to":"fa1b9901_995e5e11","updated":"2015-08-24 10:19:54.000000000","message":"I may miss something... we can access the end point \"/v1/volume_connectors\" regardless of api minor version after this patch is merged. \n\nI think it is enough to add comments for providing that kind of information.","commit_id":"982dc3b8b97ed6e0f978882b9d639ee66b693c20"}],"ironic/tests/api/v1/test_nodes.py":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"9c86becf62cf6f87ebd635efb5a5fb8e69350c97","unresolved":false,"context_lines":[{"line_number":400,"context_line":"    def test_ports_subresource_noid(self):"},{"line_number":401,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"},{"line_number":402,"context_line":"        obj_utils.create_test_port(self.context, node_id\u003dnode.id)"},{"line_number":403,"context_line":"        # No node id specified"},{"line_number":404,"context_line":"        response \u003d self.get_json(\u0027/nodes/ports\u0027, expect_errors\u003dTrue)"},{"line_number":405,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_ddaef8e6","side":"PARENT","line":403,"updated":"2015-08-23 12:58:50.000000000","message":"s/node id/node_id/","commit_id":"d19441e979e8520ae56195e27e287a5a12148465"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"63bd3fa7baa84e6db89a5bbcfe3303df452da7c1","unresolved":false,"context_lines":[{"line_number":400,"context_line":"    def test_ports_subresource_noid(self):"},{"line_number":401,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"},{"line_number":402,"context_line":"        obj_utils.create_test_port(self.context, node_id\u003dnode.id)"},{"line_number":403,"context_line":"        # No node id specified"},{"line_number":404,"context_line":"        response \u003d self.get_json(\u0027/nodes/ports\u0027, expect_errors\u003dTrue)"},{"line_number":405,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_840b407d","side":"PARENT","line":403,"in_reply_to":"fa1b9901_ddaef8e6","updated":"2015-08-24 10:19:54.000000000","message":"This is not related to this topic and so I leave it as it is. I think it should be fixed separately.","commit_id":"d19441e979e8520ae56195e27e287a5a12148465"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"9c86becf62cf6f87ebd635efb5a5fb8e69350c97","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    def test_volume_connectors_subresource_noid(self):"},{"line_number":436,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"},{"line_number":437,"context_line":"        obj_utils.create_test_volume_connector(self.context, node_id\u003dnode.id)"},{"line_number":438,"context_line":"        # No node id specified"},{"line_number":439,"context_line":"        response \u003d self.get_json(\u0027/nodes/volume_connectors\u0027,"},{"line_number":440,"context_line":"                                 expect_errors\u003dTrue)"},{"line_number":441,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_fdabbcd4","line":438,"updated":"2015-08-23 12:58:50.000000000","message":"s/node id/node_id/","commit_id":"982dc3b8b97ed6e0f978882b9d639ee66b693c20"},{"author":{"_account_id":9066,"name":"Satoru Moriya","email":"satoru.moriya.br@hitachi.com","username":"satoru-moriya-br"},"change_message_id":"63bd3fa7baa84e6db89a5bbcfe3303df452da7c1","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    def test_volume_connectors_subresource_noid(self):"},{"line_number":436,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"},{"line_number":437,"context_line":"        obj_utils.create_test_volume_connector(self.context, node_id\u003dnode.id)"},{"line_number":438,"context_line":"        # No node id specified"},{"line_number":439,"context_line":"        response \u003d self.get_json(\u0027/nodes/volume_connectors\u0027,"},{"line_number":440,"context_line":"                                 expect_errors\u003dTrue)"},{"line_number":441,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_6a10354f","line":438,"in_reply_to":"fa1b9901_fdabbcd4","updated":"2015-08-24 10:19:54.000000000","message":"Done","commit_id":"982dc3b8b97ed6e0f978882b9d639ee66b693c20"}],"ironic/tests/unit/api/test_root.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        not_resources \u003d (\u0027id\u0027, \u0027links\u0027, \u0027media_types\u0027)"},{"line_number":48,"context_line":"        actual_resources \u003d tuple(set(data.keys()) - set(not_resources))"},{"line_number":49,"context_line":"        expected_resources \u003d (\u0027chassis\u0027, \u0027drivers\u0027, \u0027nodes\u0027, \u0027ports\u0027,"},{"line_number":50,"context_line":"                              \u0027volume_connectors\u0027)"},{"line_number":51,"context_line":"        self.assertEqual(sorted(expected_resources), sorted(actual_resources))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.assertIn({\u0027type\u0027: \u0027application/vnd.openstack.ironic.v1+json\u0027,"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_ee2e6941","line":50,"range":{"start_line":50,"start_character":31,"end_line":50,"end_character":48},"updated":"2016-07-21 21:20:43.000000000","message":"this should just be volume","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e9f095c79b818404ca47edc57cabc946a0fe2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                                           \u0027lookup\u0027,"},{"line_number":77,"context_line":"                                                           \u0027portgroups\u0027,"},{"line_number":78,"context_line":"                                                           \u0027volume_connectors\u0027,"},{"line_number":79,"context_line":"                                                           \u0027volume_targets\u0027])"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_6889a0c8","line":79,"updated":"2017-07-02 11:07:01.000000000","message":"as noted above, should be just \u0027volume\u0027 + we need a new test on getting /v1/volume","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                                           \u0027lookup\u0027,"},{"line_number":77,"context_line":"                                                           \u0027portgroups\u0027,"},{"line_number":78,"context_line":"                                                           \u0027volume_connectors\u0027,"},{"line_number":79,"context_line":"                                                           \u0027volume_targets\u0027])"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_1777e4d6","line":79,"in_reply_to":"3f1d235d_6889a0c8","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"}],"ironic/tests/unit/api/v1/test_nodes.py":[{"author":{"_account_id":6287,"name":"David Lenwell","email":"dlenwell@gmail.com","username":"dlenwell"},"change_message_id":"416e2f032f70b7224eaccb618383474de5aff4c9","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                             headers\u003d{api_base.Version.string: \"1.7\"})"},{"line_number":304,"context_line":"        self.assertEqual({\"foo\": \"bar\"}, data[\u0027clean_step\u0027])"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def test_hide_fields_in_newer_versions_volume_connectors(self):"},{"line_number":307,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"},{"line_number":308,"context_line":"        data \u003d self.get_json("},{"line_number":309,"context_line":"            \u0027/nodes/%s\u0027 % node.uuid,"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_f1012e06","line":306,"range":{"start_line":306,"start_character":8,"end_line":306,"end_character":60},"updated":"2016-07-21 21:22:57.000000000","message":"I find this test name exhausting and not very descriptive something like \"test_volume_connectors_min_version\" seems more clear.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                             headers\u003d{api_base.Version.string: \"1.7\"})"},{"line_number":304,"context_line":"        self.assertEqual({\"foo\": \"bar\"}, data[\u0027clean_step\u0027])"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def test_hide_fields_in_newer_versions_volume_connectors(self):"},{"line_number":307,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"},{"line_number":308,"context_line":"        data \u003d self.get_json("},{"line_number":309,"context_line":"            \u0027/nodes/%s\u0027 % node.uuid,"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_4e521568","line":306,"updated":"2016-07-21 21:20:43.000000000","message":"I think there will need to be two tests here, one for /nodes/volume, and then one for /nodes/volume/connectors.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"},{"line_number":308,"context_line":"        data \u003d self.get_json("},{"line_number":309,"context_line":"            \u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":310,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MIN_VER)})"},{"line_number":311,"context_line":"        self.assertNotIn(\u0027volume_connectors\u0027, data)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        data \u003d self.get_json(\u0027/nodes/%s\u0027 % node.uuid,"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_8e436dae","line":310,"range":{"start_line":310,"start_character":50,"end_line":310,"end_character":64},"updated":"2016-07-21 21:20:43.000000000","message":"I think this should be \"1.20\" if the microversion is 1.21.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a1277471a3bde928031c522d24c9f1d7b015b9f3","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        for id_ in range(2):"},{"line_number":509,"context_line":"            obj_utils.create_test_volume_connector("},{"line_number":510,"context_line":"                self.context, node_id\u003dnode.id, uuid\u003duuidutils.generate_uuid(),"},{"line_number":511,"context_line":"                value\u003d\u0027test-value-%s\u0027 % id_)"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        data \u003d self.get_json("},{"line_number":514,"context_line":"            \u0027/nodes/%s/volume/connectors\u0027 % node.uuid,"}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_1ec56f3b","line":511,"range":{"start_line":511,"start_character":16,"end_line":511,"end_character":21},"updated":"2016-08-04 11:27:24.000000000","message":"rename to connector_id","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            \u0027/nodes/volume/connectors\u0027,"},{"line_number":533,"context_line":"            expect_errors\u003dTrue,"},{"line_number":534,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":535,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    def test_volume_connectors_subresource_node_not_found(self):"},{"line_number":538,"context_line":"        non_existent_uuid \u003d \u0027eeeeeeee-cccc-aaaa-bbbb-cccccccccccc\u0027"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_e6396ca5","line":535,"range":{"start_line":535,"start_character":37,"end_line":535,"end_character":48},"updated":"2016-08-18 14:57:17.000000000","message":"NOT_FOUND","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"                                     \u0027op\u0027: \u0027add\u0027}], expect_errors\u003dTrue)"},{"line_number":1248,"context_line":"        self.assertEqual(http_client.FORBIDDEN, response.status_int)"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":"    def test_patch_volume_connectors_subresource(self):"},{"line_number":1251,"context_line":"        response \u003d self.patch_json("},{"line_number":1252,"context_line":"            \u0027/nodes/%s/volume/connectors\u0027 % self.node.uuid,"},{"line_number":1253,"context_line":"            [{\u0027path\u0027: \u0027/extra/foo\u0027, \u0027value\u0027: \u0027bar\u0027, \u0027op\u0027: \u0027add\u0027}],"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_46ccc088","line":1250,"range":{"start_line":1250,"start_character":8,"end_line":1250,"end_character":48},"updated":"2016-08-18 14:57:17.000000000","message":"test_patch_volume_connectors_subresource_no_connector_id","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"            [{\u0027path\u0027: \u0027/extra/foo\u0027, \u0027value\u0027: \u0027bar\u0027, \u0027op\u0027: \u0027add\u0027}],"},{"line_number":1254,"context_line":"            expect_errors\u003dTrue,"},{"line_number":1255,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":1256,"context_line":"        self.assertEqual(http_client.FORBIDDEN, response.status_int)"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    def test_remove_uuid(self):"},{"line_number":1259,"context_line":"        response \u003d self.patch_json(\u0027/nodes/%s\u0027 % self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_46704072","line":1256,"range":{"start_line":1256,"start_character":37,"end_line":1256,"end_character":46},"updated":"2016-08-18 14:57:17.000000000","message":"BAD_REQUEST","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"            expect_errors\u003dTrue,"},{"line_number":1255,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":1256,"context_line":"        self.assertEqual(http_client.FORBIDDEN, response.status_int)"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    def test_remove_uuid(self):"},{"line_number":1259,"context_line":"        response \u003d self.patch_json(\u0027/nodes/%s\u0027 % self.node.uuid,"},{"line_number":1260,"context_line":"                                   [{\u0027path\u0027: \u0027/uuid\u0027, \u0027op\u0027: \u0027remove\u0027}],"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_26342448","line":1257,"updated":"2016-08-18 14:57:17.000000000","message":"add test for FORBIDDEN\n\n    def test_patch_volume_connectors_subresource(self):\n        connector \u003d (\n            obj_utils.create_test_volume_connector(self.context,\n                                                   node_id\u003dself.node.id))\n        response \u003d self.patch_json(\n            \u0027/nodes/%s/volume/connectors/%s\u0027 % (self.node.uuid,\n                                                connector.uuid),\n            [{\u0027path\u0027: \u0027/extra/foo\u0027, \u0027value\u0027: \u0027bar\u0027, \u0027op\u0027: \u0027add\u0027}],\n            expect_errors\u003dTrue,\n            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})\n        self.assertEqual(http_client.FORBIDDEN, response.status_int)","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":1949,"context_line":"                                  expect_errors\u003dTrue)"},{"line_number":1950,"context_line":"        self.assertEqual(http_client.FORBIDDEN, response.status_int)"},{"line_number":1951,"context_line":""},{"line_number":1952,"context_line":"    def test_post_volume_connectors_subresource(self):"},{"line_number":1953,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"},{"line_number":1954,"context_line":"        pdict \u003d test_api_utils.volume_connector_post_data(node_id\u003dNone)"},{"line_number":1955,"context_line":"        pdict[\u0027node_uuid\u0027] \u003d node.uuid"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_a6765403","line":1952,"range":{"start_line":1952,"start_character":8,"end_line":1952,"end_character":47},"updated":"2016-08-18 14:57:17.000000000","message":"test_post_volume_connectors_subresource_no_node_id","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"            \u0027/nodes/volume/connectors\u0027, pdict,"},{"line_number":1958,"context_line":"            expect_errors\u003dTrue,"},{"line_number":1959,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":1960,"context_line":"        self.assertEqual(http_client.FORBIDDEN, response.status_int)"},{"line_number":1961,"context_line":""},{"line_number":1962,"context_line":"    def test_create_node_no_mandatory_field_driver(self):"},{"line_number":1963,"context_line":"        ndict \u003d test_api_utils.post_get_test_node()"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_a6e494ab","line":1960,"range":{"start_line":1960,"start_character":37,"end_line":1960,"end_character":46},"updated":"2016-08-18 14:57:17.000000000","message":"NOT_FOUND","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":1958,"context_line":"            expect_errors\u003dTrue,"},{"line_number":1959,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":1960,"context_line":"        self.assertEqual(http_client.FORBIDDEN, response.status_int)"},{"line_number":1961,"context_line":""},{"line_number":1962,"context_line":"    def test_create_node_no_mandatory_field_driver(self):"},{"line_number":1963,"context_line":"        ndict \u003d test_api_utils.post_get_test_node()"},{"line_number":1964,"context_line":"        del ndict[\u0027driver\u0027]"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_e6f04c69","line":1961,"updated":"2016-08-18 14:57:17.000000000","message":"add test for FORBIDDEN\n\n    def test_post_volume_connectors_subresource(self):\n        node \u003d obj_utils.create_test_node(self.context)\n        pdict \u003d test_api_utils.volume_connector_post_data(node_id\u003dNone)\n        pdict[\u0027node_uuid\u0027] \u003d node.uuid\n        response \u003d self.post_json(\n            \u0027/nodes/%s/volume/connectors\u0027 % node.uuid, pdict,\n            expect_errors\u003dTrue,\n            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})\n         self.assertEqual(http_client.FORBIDDEN, response.status_int)","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":2155,"context_line":"                               expect_errors\u003dTrue)"},{"line_number":2156,"context_line":"        self.assertEqual(http_client.FORBIDDEN, response.status_int)"},{"line_number":2157,"context_line":""},{"line_number":2158,"context_line":"    def test_delete_volume_connectors_subresource(self):"},{"line_number":2159,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"},{"line_number":2160,"context_line":"        response \u003d self.delete("},{"line_number":2161,"context_line":"            \u0027/nodes/%s/volume/connectors\u0027 % node.uuid,"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_668c5cda","line":2158,"range":{"start_line":2158,"start_character":8,"end_line":2158,"end_character":50},"updated":"2016-08-18 14:57:17.000000000","message":"test_delete_volume_connectors_subresource_no_connector_id","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":2161,"context_line":"            \u0027/nodes/%s/volume/connectors\u0027 % node.uuid,"},{"line_number":2162,"context_line":"            expect_errors\u003dTrue,"},{"line_number":2163,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":2164,"context_line":"        self.assertEqual(http_client.FORBIDDEN, response.status_int)"},{"line_number":2165,"context_line":""},{"line_number":2166,"context_line":"    @mock.patch.object(rpcapi.ConductorAPI, \u0027destroy_node\u0027)"},{"line_number":2167,"context_line":"    def test_delete_associated(self, mock_dn):"}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_266c2407","line":2164,"range":{"start_line":2164,"start_character":37,"end_line":2164,"end_character":46},"updated":"2016-08-18 14:57:17.000000000","message":"BAD_REQUEST","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"330abe4933967f69f753f405dd22e7e1260eb9e6","unresolved":false,"context_lines":[{"line_number":2162,"context_line":"            expect_errors\u003dTrue,"},{"line_number":2163,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":2164,"context_line":"        self.assertEqual(http_client.FORBIDDEN, response.status_int)"},{"line_number":2165,"context_line":""},{"line_number":2166,"context_line":"    @mock.patch.object(rpcapi.ConductorAPI, \u0027destroy_node\u0027)"},{"line_number":2167,"context_line":"    def test_delete_associated(self, mock_dn):"},{"line_number":2168,"context_line":"        node \u003d obj_utils.create_test_node("}],"source_content_type":"text/x-python","patch_set":41,"id":"3ac371cc_8629989d","line":2165,"updated":"2016-08-18 14:57:17.000000000","message":"add test for FORBIDDEN\n\n    def test_delete_volume_connectors_subresource(self):\n        node \u003d obj_utils.create_test_node(self.context)\n        connector \u003d obj_utils.create_test_volume_connector(self.context,\n                                                           node_id\u003dnode.id)\n        response \u003d self.delete(\n            \u0027/nodes/%s/volume/connectors/%s\u0027 % (node.uuid, connector.uuid),\n            expect_errors\u003dTrue,\n            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})\n        self.assertEqual(http_client.FORBIDDEN, response.status_int)","commit_id":"948c0e1c85b79518705399154e9e0ef3543d4764"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e9f095c79b818404ca47edc57cabc946a0fe2","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        data \u003d self.get_json(\u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":413,"context_line":"                             headers\u003d{api_base.Version.string: \"1.32\"})"},{"line_number":414,"context_line":"        self.assertIn(\u0027volume\u0027, data.keys())"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def test_many(self):"},{"line_number":417,"context_line":"        nodes \u003d []"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_2893a8fc","line":414,"updated":"2017-07-02 11:07:01.000000000","message":".keys() is redundant","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        data \u003d self.get_json(\u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":413,"context_line":"                             headers\u003d{api_base.Version.string: \"1.32\"})"},{"line_number":414,"context_line":"        self.assertIn(\u0027volume\u0027, data.keys())"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def test_many(self):"},{"line_number":417,"context_line":"        nodes \u003d []"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_c3dace15","line":414,"in_reply_to":"3f1d235d_2893a8fc","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e9f095c79b818404ca47edc57cabc946a0fe2","unresolved":false,"context_lines":[{"line_number":646,"context_line":"        data \u003d self.get_json("},{"line_number":647,"context_line":"            \u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":648,"context_line":"            headers\u003d{api_base.Version.string: \u00271.32\u0027})"},{"line_number":649,"context_line":"        self.assertIn(\u0027volume\u0027, data.keys())"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def test_volume_subresource(self):"},{"line_number":652,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_088eaccf","line":649,"updated":"2017-07-02 11:07:01.000000000","message":"ditto","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":646,"context_line":"        data \u003d self.get_json("},{"line_number":647,"context_line":"            \u0027/nodes/%s\u0027 % node.uuid,"},{"line_number":648,"context_line":"            headers\u003d{api_base.Version.string: \u00271.32\u0027})"},{"line_number":649,"context_line":"        self.assertIn(\u0027volume\u0027, data.keys())"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def test_volume_subresource(self):"},{"line_number":652,"context_line":"        node \u003d obj_utils.create_test_node(self.context)"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_4300fe67","line":649,"in_reply_to":"3f1d235d_088eaccf","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e9f095c79b818404ca47edc57cabc946a0fe2","unresolved":false,"context_lines":[{"line_number":653,"context_line":"        data \u003d self.get_json(\u0027/nodes/%s/volume\u0027 % node.uuid,"},{"line_number":654,"context_line":"                             headers\u003d{api_base.Version.string: \u00271.32\u0027})"},{"line_number":655,"context_line":"        self.assertIn(\u0027volume_connectors\u0027, data.keys())"},{"line_number":656,"context_line":"        self.assertIn(\u0027volume_targets\u0027, data.keys())"},{"line_number":657,"context_line":"        self.assertIn(\u0027/volume/connectors\u0027,"},{"line_number":658,"context_line":"                      data[\u0027volume_connectors\u0027][0][\u0027href\u0027])"},{"line_number":659,"context_line":"        self.assertIn(\u0027/volume/connectors\u0027,"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_e8bed063","line":656,"updated":"2017-07-02 11:07:01.000000000","message":"ditto + it should be just \"connectors\" and \"targets\"","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":653,"context_line":"        data \u003d self.get_json(\u0027/nodes/%s/volume\u0027 % node.uuid,"},{"line_number":654,"context_line":"                             headers\u003d{api_base.Version.string: \u00271.32\u0027})"},{"line_number":655,"context_line":"        self.assertIn(\u0027volume_connectors\u0027, data.keys())"},{"line_number":656,"context_line":"        self.assertIn(\u0027volume_targets\u0027, data.keys())"},{"line_number":657,"context_line":"        self.assertIn(\u0027/volume/connectors\u0027,"},{"line_number":658,"context_line":"                      data[\u0027volume_connectors\u0027][0][\u0027href\u0027])"},{"line_number":659,"context_line":"        self.assertIn(\u0027/volume/connectors\u0027,"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_e3f4aa89","line":656,"in_reply_to":"3f1d235d_e8bed063","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e9f095c79b818404ca47edc57cabc946a0fe2","unresolved":false,"context_lines":[{"line_number":682,"context_line":"            \u0027/nodes/%s/volume/connectors\u0027 % node.uuid,"},{"line_number":683,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":684,"context_line":"        self.assertEqual(2, len(data[\u0027connectors\u0027]))"},{"line_number":685,"context_line":"        self.assertNotIn(\u0027next\u0027, data.keys())"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        # Test collection pagination"},{"line_number":688,"context_line":"        data \u003d self.get_json("}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_c8c1d4e6","line":685,"updated":"2017-07-02 11:07:01.000000000","message":".keys() redundant here and below","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":682,"context_line":"            \u0027/nodes/%s/volume/connectors\u0027 % node.uuid,"},{"line_number":683,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MAX_VER)})"},{"line_number":684,"context_line":"        self.assertEqual(2, len(data[\u0027connectors\u0027]))"},{"line_number":685,"context_line":"        self.assertNotIn(\u0027next\u0027, data.keys())"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        # Test collection pagination"},{"line_number":688,"context_line":"        data \u003d self.get_json("}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_832bb6e9","line":685,"in_reply_to":"3f1d235d_c8c1d4e6","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"}],"ironic/tests/unit/api/v1/test_utils.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"779c22236c201fb027eb6c35228dfd6aab898518","unresolved":false,"context_lines":[{"line_number":464,"context_line":"    def test_get_controller_reserved_names(self):"},{"line_number":465,"context_line":"        expected \u003d [\u0027maintenance\u0027, \u0027management\u0027, \u0027ports\u0027, \u0027states\u0027,"},{"line_number":466,"context_line":"                    \u0027vendor_passthru\u0027, \u0027validate\u0027, \u0027detail\u0027,"},{"line_number":467,"context_line":"                    \u0027volume\u0027]"},{"line_number":468,"context_line":"        self.assertEqual(sorted(expected),"},{"line_number":469,"context_line":"                         sorted(utils.get_controller_reserved_names("},{"line_number":470,"context_line":"                                api_node.NodesController)))"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_22dcd111","line":467,"range":{"start_line":467,"start_character":20,"end_line":467,"end_character":28},"updated":"2016-08-26 16:34:53.000000000","message":"\u0027Volume\u0027 can be removed from reserved names by the new sub-resource processing.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a2f8eef52ee146f6680f2aa8d9959a3cb54e7794","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    def test_get_controller_reserved_names(self):"},{"line_number":599,"context_line":"        expected \u003d [\u0027maintenance\u0027, \u0027management\u0027, \u0027states\u0027,"},{"line_number":600,"context_line":"                    \u0027vendor_passthru\u0027, \u0027validate\u0027, \u0027detail\u0027]"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        self.assertEqual(sorted(expected),"},{"line_number":603,"context_line":"                         sorted(utils.get_controller_reserved_names("},{"line_number":604,"context_line":"                                api_node.NodesController)))"}],"source_content_type":"text/x-python","patch_set":83,"id":"bf091321_052b6394","line":601,"updated":"2017-06-08 12:32:14.000000000","message":"nit: excess line added","commit_id":"1dfd8bfba5da0c05adb7822f8acf914eabc23351"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ea8723fdbd10553ffb142aac7665c2c9b64b3e2","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    def test_get_controller_reserved_names(self):"},{"line_number":599,"context_line":"        expected \u003d [\u0027maintenance\u0027, \u0027management\u0027, \u0027states\u0027,"},{"line_number":600,"context_line":"                    \u0027vendor_passthru\u0027, \u0027validate\u0027, \u0027detail\u0027]"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        self.assertEqual(sorted(expected),"},{"line_number":603,"context_line":"                         sorted(utils.get_controller_reserved_names("},{"line_number":604,"context_line":"                                api_node.NodesController)))"}],"source_content_type":"text/x-python","patch_set":91,"id":"7f231b9d_3b9d8609","line":601,"updated":"2017-06-19 16:17:35.000000000","message":"nit: unrelated empty line addition.","commit_id":"f5bb90aebe3dea99cb82cb3b8acfc112e8bdb9c6"}],"ironic/tests/unit/api/v1/test_volume.py":[{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                               headers\u003dheaders))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_get_volume(self):"},{"line_number":38,"context_line":"        headers \u003d {api_base.Version.string: str(api_v1.MAX_VER)}"},{"line_number":39,"context_line":"        data \u003d self.get_json(\u0027/volume/\u0027, headers\u003dheaders)"},{"line_number":40,"context_line":"        for key in [\u0027links\u0027, \u0027volume_connectors\u0027, \u0027volume_targets\u0027]:"},{"line_number":41,"context_line":"            self._test_links(data, key, headers)"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_ed17ec50","line":38,"updated":"2017-04-03 22:16:26.000000000","message":"this should be 32.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f5a5031806cecee00123cc8e52af512e066a5fb8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertIn(\u0027targets\u0027, data[\u0027volume_targets\u0027][0][\u0027href\u0027])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_get_volume_invalid_api_version(self):"},{"line_number":46,"context_line":"        headers \u003d {api_base.Version.string: str(api_v1.MIN_VER)}"},{"line_number":47,"context_line":"        response \u003d self.get_json(\u0027/volume/\u0027, headers\u003dheaders,"},{"line_number":48,"context_line":"                                 expect_errors\u003dTrue)"},{"line_number":49,"context_line":"        self.assertEqual(http_client.NOT_FOUND, response.status_int)"}],"source_content_type":"text/x-python","patch_set":72,"id":"dfeb2761_48000602","line":46,"updated":"2017-04-03 22:16:26.000000000","message":"this should be 31, so we know any failures are caused *only* by this change.","commit_id":"234aa73f3e4ca125978e28f0895e8bfe6ed2b096"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e68e9f095c79b818404ca47edc57cabc946a0fe2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def test_get_volume(self):"},{"line_number":38,"context_line":"        headers \u003d {api_base.Version.string: str(api_v1.MAX_VER)}"},{"line_number":39,"context_line":"        data \u003d self.get_json(\u0027/volume/\u0027, headers\u003dheaders)"},{"line_number":40,"context_line":"        for key in [\u0027links\u0027, \u0027volume_connectors\u0027, \u0027volume_targets\u0027]:"},{"line_number":41,"context_line":"            self._test_links(data, key, headers)"},{"line_number":42,"context_line":"        self.assertIn(\u0027/volume/connectors\u0027,"},{"line_number":43,"context_line":"                      data[\u0027volume_connectors\u0027][0][\u0027href\u0027])"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_4884a4b1","line":40,"updated":"2017-07-02 11:07:01.000000000","message":"\"connectors\", \"targets\"","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"de7ff5bf11ced67d0db411701f6fda17030bd49a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def test_get_volume(self):"},{"line_number":38,"context_line":"        headers \u003d {api_base.Version.string: str(api_v1.MAX_VER)}"},{"line_number":39,"context_line":"        data \u003d self.get_json(\u0027/volume/\u0027, headers\u003dheaders)"},{"line_number":40,"context_line":"        for key in [\u0027links\u0027, \u0027volume_connectors\u0027, \u0027volume_targets\u0027]:"},{"line_number":41,"context_line":"            self._test_links(data, key, headers)"},{"line_number":42,"context_line":"        self.assertIn(\u0027/volume/connectors\u0027,"},{"line_number":43,"context_line":"                      data[\u0027volume_connectors\u0027][0][\u0027href\u0027])"}],"source_content_type":"text/x-python","patch_set":99,"id":"3f1d235d_63177aa5","line":40,"in_reply_to":"3f1d235d_4884a4b1","updated":"2017-07-03 06:56:14.000000000","message":"Done","commit_id":"f72a6bdf0c985fdafa21a99b864cb3773f7d0a90"}],"ironic/tests/unit/api/v1/test_volume_connectors.py":[{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.node \u003d obj_utils.create_test_node(self.context)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_empty(self):"},{"line_number":65,"context_line":"        data \u003d self.get_json(\u0027/volume_connectors\u0027)"},{"line_number":66,"context_line":"        self.assertEqual([], data[\u0027connectors\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_one(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_0e6f7dfc","line":65,"range":{"start_line":65,"start_character":31,"end_line":65,"end_character":48},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors as per the spec here and below.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"842b8a72b39108008a6f18247072937eea9ea9ef","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.node \u003d obj_utils.create_test_node(self.context)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_empty(self):"},{"line_number":65,"context_line":"        data \u003d self.get_json(\u0027/volume_connectors\u0027)"},{"line_number":66,"context_line":"        self.assertEqual([], data[\u0027connectors\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_one(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_8ebecdab","line":65,"range":{"start_line":65,"start_character":30,"end_line":65,"end_character":48},"updated":"2016-07-21 21:20:43.000000000","message":"This needs to be changed to /volume/connectors\n\nThrough out this file :(","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self.context, node_id\u003dself.node.id)"},{"line_number":128,"context_line":"        fields \u003d \u0027uuid,extra\u0027"},{"line_number":129,"context_line":"        response \u003d self.get_json("},{"line_number":130,"context_line":"            \u0027/volume_connectors/%s?fields\u003d%s\u0027 % (connector.uuid, fields),"},{"line_number":131,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MIN_VER)},"},{"line_number":132,"context_line":"            expect_errors\u003dTrue)"},{"line_number":133,"context_line":"        self.assertEqual(http_client.NOT_ACCEPTABLE, response.status_int)"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_ae575124","line":130,"range":{"start_line":130,"start_character":14,"end_line":130,"end_character":31},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors as per the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def test_detail(self):"},{"line_number":136,"context_line":"        connector \u003d obj_utils.create_test_volume_connector("},{"line_number":137,"context_line":"            self.context, node_id\u003dself.node.id)"},{"line_number":138,"context_line":"        data \u003d self.get_json(\u0027/volume_connectors/detail\u0027)"},{"line_number":139,"context_line":"        self.assertEqual(connector.uuid, data[\u0027connectors\u0027][0][\"uuid\"])"},{"line_number":140,"context_line":"        self.assertIn(\u0027extra\u0027, data[\u0027connectors\u0027][0])"},{"line_number":141,"context_line":"        self.assertIn(\u0027node_uuid\u0027, data[\u0027connectors\u0027][0])"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_2e3a41e7","line":138,"range":{"start_line":138,"start_character":31,"end_line":138,"end_character":48},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors as per the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    def test_detail_against_single(self):"},{"line_number":146,"context_line":"        connector \u003d obj_utils.create_test_volume_connector("},{"line_number":147,"context_line":"            self.context, node_id\u003dself.node.id)"},{"line_number":148,"context_line":"        response \u003d self.get_json(\u0027/volume_connectors/%s/detail\u0027"},{"line_number":149,"context_line":"                                 % connector.uuid,"},{"line_number":150,"context_line":"                                 expect_errors\u003dTrue)"},{"line_number":151,"context_line":"        self.assertEqual(http_client.NOT_FOUND, response.status_int)"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_6e28b99a","line":148,"range":{"start_line":148,"start_character":35,"end_line":148,"end_character":52},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors as per the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                uuid\u003duuidutils.generate_uuid(),"},{"line_number":159,"context_line":"                value\u003d\u0027test-value-%s\u0027 % id_)"},{"line_number":160,"context_line":"            connectors.append(connector.uuid)"},{"line_number":161,"context_line":"        data \u003d self.get_json(\u0027/volume_connectors\u0027)"},{"line_number":162,"context_line":"        self.assertEqual(len(connectors), len(data[\u0027connectors\u0027]))"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        uuids \u003d [n[\u0027uuid\u0027] for n in data[\u0027connectors\u0027]]"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_ee1ae97b","line":161,"range":{"start_line":161,"start_character":31,"end_line":161,"end_character":48},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors as per the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        obj_utils.create_test_volume_connector(self.context,"},{"line_number":170,"context_line":"                                               uuid\u003duuid,"},{"line_number":171,"context_line":"                                               node_id\u003dself.node.id)"},{"line_number":172,"context_line":"        data \u003d self.get_json(\u0027/volume_connectors/%s\u0027 % uuid)"},{"line_number":173,"context_line":"        self.assertIn(\u0027links\u0027, data.keys())"},{"line_number":174,"context_line":"        self.assertEqual(2, len(data[\u0027links\u0027]))"},{"line_number":175,"context_line":"        self.assertIn(uuid, data[\u0027links\u0027][0][\u0027href\u0027])"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_ce1d6574","line":172,"range":{"start_line":172,"start_character":31,"end_line":172,"end_character":48},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors as per the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                uuid\u003duuidutils.generate_uuid(),"},{"line_number":187,"context_line":"                value\u003d\u0027test-value-%s\u0027 % id_)"},{"line_number":188,"context_line":"            connectors.append(connector.uuid)"},{"line_number":189,"context_line":"        data \u003d self.get_json(\u0027/volume_connectors/?limit\u003d3\u0027)"},{"line_number":190,"context_line":"        self.assertEqual(3, len(data[\u0027connectors\u0027]))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        next_marker \u003d data[\u0027connectors\u0027][-1][\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_ae059114","line":189,"range":{"start_line":189,"start_character":31,"end_line":189,"end_character":48},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors as per the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                uuid\u003duuidutils.generate_uuid(),"},{"line_number":203,"context_line":"                value\u003d\u0027test-value-%s\u0027 % id_)"},{"line_number":204,"context_line":"            connectors.append(connector.uuid)"},{"line_number":205,"context_line":"        data \u003d self.get_json(\u0027/volume_connectors\u0027)"},{"line_number":206,"context_line":"        self.assertEqual(3, len(data[\u0027connectors\u0027]))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        next_marker \u003d data[\u0027connectors\u0027][-1][\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_110b2225","line":205,"range":{"start_line":205,"start_character":31,"end_line":205,"end_character":48},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors as per the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                uuid\u003duuidutils.generate_uuid(),"},{"line_number":218,"context_line":"                value\u003d\u0027test-value-%s\u0027 % id_)"},{"line_number":219,"context_line":"            connectors.append(connector.uuid)"},{"line_number":220,"context_line":"        data \u003d self.get_json(\u0027/volume_connectors?sort_key\u003duuid\u0027)"},{"line_number":221,"context_line":"        uuids \u003d [n[\u0027uuid\u0027] for n in data[\u0027connectors\u0027]]"},{"line_number":222,"context_line":"        self.assertEqual(sorted(connectors), uuids)"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_91171244","line":220,"range":{"start_line":220,"start_character":31,"end_line":220,"end_character":48},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors as per the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"14d70914b5507904431ce7c8ed9154a8a0e8b274","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    def test_sort_key_invalid(self):"},{"line_number":225,"context_line":"        invalid_keys_list \u003d [\u0027foo\u0027, \u0027extra\u0027]"},{"line_number":226,"context_line":"        for invalid_key in invalid_keys_list:"},{"line_number":227,"context_line":"            response \u003d self.get_json(\u0027/volume_connectors?sort_key\u003d%s\u0027"},{"line_number":228,"context_line":"                                     % invalid_key,"},{"line_number":229,"context_line":"                                     expect_errors\u003dTrue)"},{"line_number":230,"context_line":"            self.assertEqual(http_client.BAD_REQUEST, response.status_int)"}],"source_content_type":"text/x-python","patch_set":24,"id":"dada55a8_d12b4a80","line":227,"range":{"start_line":227,"start_character":39,"end_line":227,"end_character":56},"updated":"2016-07-21 21:23:55.000000000","message":"Should be volume/connectors as per the spec.","commit_id":"c8c5bbb18cb128a9f472fcfea453d059697c8ac8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"74ea2136fb4880df9c06de517ef65d3d51c906df","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        for i in range(3):"},{"line_number":100,"context_line":"            obj_utils.create_test_volume_connector("},{"line_number":101,"context_line":"                self.context, node_id\u003dself.node.id,"},{"line_number":102,"context_line":"                uuid\u003duuidutils.generate_uuid(), value\u003d\u0027test-value-%s\u0027 % i)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        data \u003d self.get_json("},{"line_number":105,"context_line":"            \u0027/volume/connectors?fields\u003d%s\u0027 % fields,"}],"source_content_type":"text/x-python","patch_set":36,"id":"bacf61ea_dafb3846","line":102,"range":{"start_line":102,"start_character":48,"end_line":102,"end_character":53},"updated":"2016-08-02 19:22:31.000000000","message":"The collection field of value was changed in the specification to be connector_id\n\nhttps://github.com/openstack/ironic-specs/blame/master/specs/approved/volume-connection-information.rst#L80","commit_id":"14ae4e2412e4113954fe84bc8ad05ef6f4888c1b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"74ea2136fb4880df9c06de517ef65d3d51c906df","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                self.context,"},{"line_number":216,"context_line":"                node_id\u003dself.node.id,"},{"line_number":217,"context_line":"                uuid\u003duuidutils.generate_uuid(),"},{"line_number":218,"context_line":"                value\u003d\u0027test-value-%s\u0027 % id_)"},{"line_number":219,"context_line":"            connectors.append(connector.uuid)"},{"line_number":220,"context_line":"        data \u003d self.get_json(\u0027/volume/connectors?sort_key\u003duuid\u0027)"},{"line_number":221,"context_line":"        uuids \u003d [n[\u0027uuid\u0027] for n in data[\u0027connectors\u0027]]"}],"source_content_type":"text/x-python","patch_set":36,"id":"bacf61ea_faf1dc6b","line":218,"range":{"start_line":218,"start_character":16,"end_line":218,"end_character":21},"updated":"2016-08-02 19:22:31.000000000","message":"the value fields was changed in the specification to be connector_id\n\nhttps://github.com/openstack/ironic-specs/blame/master/specs/approved/volume-connection-information.rst#L80","commit_id":"14ae4e2412e4113954fe84bc8ad05ef6f4888c1b"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a1277471a3bde928031c522d24c9f1d7b015b9f3","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        self.assertEqual(http_client.NOT_ACCEPTABLE, data.status_int)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @mock.patch.object(api_volume_connector.VolumeConnectorsController,"},{"line_number":304,"context_line":"                       \u0027_get_volume/connectors_collection\u0027)"},{"line_number":305,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":306,"context_line":"        # GET /v1/volume/connectors/detail specifying node and node_uuid."},{"line_number":307,"context_line":"        # In this case, we expect the node_uuid interface to be used."}],"source_content_type":"text/x-python","patch_set":37,"id":"bacf61ea_1e29e489","line":304,"range":{"start_line":304,"start_character":35,"end_line":304,"end_character":36},"updated":"2016-08-04 11:27:24.000000000","message":"typo: replace \u0027/\u0027 with \u0027_\u0027.","commit_id":"c2c6c500e08208a51cbb11cd9a419f9c5d2bb0d4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8c4fc4738452cecc80a802aa0b6b66f111e44795","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        self.assertEqual(http_client.NOT_ACCEPTABLE, data.status_int)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    @mock.patch.object(api_volume_connector.VolumeConnectorsController,"},{"line_number":306,"context_line":"                       \u0027_get_volume/connectors_collection\u0027)"},{"line_number":307,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":308,"context_line":"        # GET /v1/volume/connectors/detail specifying node and node_uuid."},{"line_number":309,"context_line":"        # In this case, we expect the node_uuid interface to be used."}],"source_content_type":"text/x-python","patch_set":38,"id":"bacf61ea_527abd77","line":306,"range":{"start_line":306,"start_character":23,"end_line":306,"end_character":58},"updated":"2016-08-08 00:05:07.000000000","message":"\u0027_get_volume_connectors_collection\u0027 is correct.\nThis is a method name, which shouldn\u0027t contain a slash.","commit_id":"e6dd3589d54cbba4a2582cacdce8c335342e9729"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8c4fc4738452cecc80a802aa0b6b66f111e44795","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        response \u003d self.patch_json(\u0027/volume/connectors/%s\u0027"},{"line_number":335,"context_line":"                                   % self.connector.uuid,"},{"line_number":336,"context_line":"                                   [{\u0027path\u0027: \u0027/extra/foo\u0027,"},{"line_number":337,"context_line":"                                     \u0027connector_id\u0027: \u0027bar\u0027,"},{"line_number":338,"context_line":"                                     \u0027op\u0027: \u0027add\u0027}])"},{"line_number":339,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":340,"context_line":"        self.assertEqual(http_client.OK, response.status_code)"}],"source_content_type":"text/x-python","patch_set":38,"id":"bacf61ea_729381a3","line":337,"range":{"start_line":337,"start_character":38,"end_line":337,"end_character":50},"updated":"2016-08-08 00:05:07.000000000","message":"\u0027value\u0027 is correct here. This is not a member of a volume_connector but a member of a patch for update.","commit_id":"e6dd3589d54cbba4a2582cacdce8c335342e9729"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8c4fc4738452cecc80a802aa0b6b66f111e44795","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        response \u003d self.patch_json(\u0027/volume/connectors/%s\u0027"},{"line_number":363,"context_line":"                                   % self.connector.uuid,"},{"line_number":364,"context_line":"                                   [{\u0027path\u0027: \u0027/connector_id\u0027,"},{"line_number":365,"context_line":"                                     \u0027connector_id\u0027: connector_id,"},{"line_number":366,"context_line":"                                     \u0027op\u0027: \u0027replace\u0027}])"},{"line_number":367,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":368,"context_line":"        self.assertEqual(http_client.OK, response.status_code)"}],"source_content_type":"text/x-python","patch_set":38,"id":"bacf61ea_57b46f80","line":365,"range":{"start_line":365,"start_character":38,"end_line":365,"end_character":51},"updated":"2016-08-08 00:05:07.000000000","message":"ditto","commit_id":"e6dd3589d54cbba4a2582cacdce8c335342e9729"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8c4fc4738452cecc80a802aa0b6b66f111e44795","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        response \u003d self.patch_json(\u0027/volume/connectors/%s\u0027"},{"line_number":381,"context_line":"                                   % self.connector.uuid,"},{"line_number":382,"context_line":"                                   [{\u0027path\u0027: \u0027/connector_id\u0027,"},{"line_number":383,"context_line":"                                     \u0027connector_id\u0027: connector_id,"},{"line_number":384,"context_line":"                                     \u0027op\u0027: \u0027replace\u0027}],"},{"line_number":385,"context_line":"                                   expect_errors\u003dTrue)"},{"line_number":386,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"}],"source_content_type":"text/x-python","patch_set":38,"id":"bacf61ea_d28ead77","line":383,"range":{"start_line":383,"start_character":38,"end_line":383,"end_character":51},"updated":"2016-08-08 00:05:07.000000000","message":"ditto","commit_id":"e6dd3589d54cbba4a2582cacdce8c335342e9729"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8c4fc4738452cecc80a802aa0b6b66f111e44795","unresolved":false,"context_lines":[{"line_number":546,"context_line":"        response \u003d self.patch_json(\u0027/volume/connectors/%s\u0027"},{"line_number":547,"context_line":"                                   % self.connector.uuid,"},{"line_number":548,"context_line":"                                   [{\u0027path\u0027: \u0027/connector_id\u0027,"},{"line_number":549,"context_line":"                                     \u0027connector_id\u0027: connector_id,"},{"line_number":550,"context_line":"                                     \u0027op\u0027: \u0027add\u0027}])"},{"line_number":551,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":552,"context_line":"        self.assertEqual(http_client.OK, response.status_code)"}],"source_content_type":"text/x-python","patch_set":38,"id":"bacf61ea_b2897971","line":549,"range":{"start_line":549,"start_character":37,"end_line":549,"end_character":51},"updated":"2016-08-08 00:05:07.000000000","message":"ditto","commit_id":"e6dd3589d54cbba4a2582cacdce8c335342e9729"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"779c22236c201fb027eb6c35228dfd6aab898518","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self.assertEqual(0, mock_get_rpc_node.call_count)"},{"line_number":303,"context_line":"        self.assertEqual(http_client.NOT_ACCEPTABLE, data.status_int)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    @mock.patch.object(api_volume_connector.VolumeConnectorsController,"},{"line_number":306,"context_line":"                       \u0027_get_volume_connectors_collection\u0027)"},{"line_number":307,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":308,"context_line":"        # GET /v1/volume/connectors/detail specifying node and node_uuid."},{"line_number":309,"context_line":"        # In this case, we expect the node_uuid interface to be used."}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_67d0ab54","line":306,"range":{"start_line":305,"start_character":0,"end_line":306,"end_character":59},"updated":"2016-08-26 16:34:53.000000000","message":"@mock.patch.object(api_utils, \u0027get_rpc_node\u0027)","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        self.assertEqual(0, mock_get_rpc_node.call_count)"},{"line_number":303,"context_line":"        self.assertEqual(http_client.NOT_ACCEPTABLE, data.status_int)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    @mock.patch.object(api_volume_connector.VolumeConnectorsController,"},{"line_number":306,"context_line":"                       \u0027_get_volume_connectors_collection\u0027)"},{"line_number":307,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":308,"context_line":"        # GET /v1/volume/connectors/detail specifying node and node_uuid."},{"line_number":309,"context_line":"        # In this case, we expect the node_uuid interface to be used."}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_dd9f494e","line":306,"range":{"start_line":305,"start_character":0,"end_line":306,"end_character":59},"in_reply_to":"fa7ab95a_67d0ab54","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"779c22236c201fb027eb6c35228dfd6aab898518","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    @mock.patch.object(api_volume_connector.VolumeConnectorsController,"},{"line_number":306,"context_line":"                       \u0027_get_volume_connectors_collection\u0027)"},{"line_number":307,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":308,"context_line":"        # GET /v1/volume/connectors/detail specifying node and node_uuid."},{"line_number":309,"context_line":"        # In this case, we expect the node_uuid interface to be used."},{"line_number":310,"context_line":"        self.get_json(\u0027/volume/connectors/detail?node\u003d%s\u0026node_uuid\u003d%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_07499f31","line":307,"range":{"start_line":307,"start_character":51,"end_line":307,"end_character":59},"updated":"2016-08-26 16:34:53.000000000","message":"mock_get_rpc_node","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    @mock.patch.object(api_volume_connector.VolumeConnectorsController,"},{"line_number":306,"context_line":"                       \u0027_get_volume_connectors_collection\u0027)"},{"line_number":307,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":308,"context_line":"        # GET /v1/volume/connectors/detail specifying node and node_uuid."},{"line_number":309,"context_line":"        # In this case, we expect the node_uuid interface to be used."},{"line_number":310,"context_line":"        self.get_json(\u0027/volume/connectors/detail?node\u003d%s\u0026node_uuid\u003d%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_fdaecd83","line":307,"range":{"start_line":307,"start_character":51,"end_line":307,"end_character":59},"in_reply_to":"fa7ab95a_07499f31","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"779c22236c201fb027eb6c35228dfd6aab898518","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                       \u0027_get_volume_connectors_collection\u0027)"},{"line_number":307,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":308,"context_line":"        # GET /v1/volume/connectors/detail specifying node and node_uuid."},{"line_number":309,"context_line":"        # In this case, we expect the node_uuid interface to be used."},{"line_number":310,"context_line":"        self.get_json(\u0027/volume/connectors/detail?node\u003d%s\u0026node_uuid\u003d%s\u0027 %"},{"line_number":311,"context_line":"                      (\u0027test-node\u0027, self.node.uuid))"},{"line_number":312,"context_line":"        mock_gpc.assert_called_once_with(self.node.uuid, mock.ANY, mock.ANY,"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_e7c4bb93","line":309,"updated":"2016-08-26 16:34:53.000000000","message":"mock_get_rpc_node.return_value \u003d self.node","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                       \u0027_get_volume_connectors_collection\u0027)"},{"line_number":307,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":308,"context_line":"        # GET /v1/volume/connectors/detail specifying node and node_uuid."},{"line_number":309,"context_line":"        # In this case, we expect the node_uuid interface to be used."},{"line_number":310,"context_line":"        self.get_json(\u0027/volume/connectors/detail?node\u003d%s\u0026node_uuid\u003d%s\u0027 %"},{"line_number":311,"context_line":"                      (\u0027test-node\u0027, self.node.uuid))"},{"line_number":312,"context_line":"        mock_gpc.assert_called_once_with(self.node.uuid, mock.ANY, mock.ANY,"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_3db765d9","line":309,"in_reply_to":"fa7ab95a_e7c4bb93","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"779c22236c201fb027eb6c35228dfd6aab898518","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        # In this case, we expect the node_uuid interface to be used."},{"line_number":310,"context_line":"        self.get_json(\u0027/volume/connectors/detail?node\u003d%s\u0026node_uuid\u003d%s\u0027 %"},{"line_number":311,"context_line":"                      (\u0027test-node\u0027, self.node.uuid))"},{"line_number":312,"context_line":"        mock_gpc.assert_called_once_with(self.node.uuid, mock.ANY, mock.ANY,"},{"line_number":313,"context_line":"                                         mock.ANY, mock.ANY, mock.ANY)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"@mock.patch.object(rpcapi.ConductorAPI, \u0027update_volume_connector\u0027)"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_e772fb7b","line":313,"range":{"start_line":312,"start_character":0,"end_line":313,"end_character":70},"updated":"2016-08-26 16:34:53.000000000","message":"mock_get_rpc_node.assert_called_once_with(self.node.uuid)","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        # In this case, we expect the node_uuid interface to be used."},{"line_number":310,"context_line":"        self.get_json(\u0027/volume/connectors/detail?node\u003d%s\u0026node_uuid\u003d%s\u0027 %"},{"line_number":311,"context_line":"                      (\u0027test-node\u0027, self.node.uuid))"},{"line_number":312,"context_line":"        mock_gpc.assert_called_once_with(self.node.uuid, mock.ANY, mock.ANY,"},{"line_number":313,"context_line":"                                         mock.ANY, mock.ANY, mock.ANY)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"@mock.patch.object(rpcapi.ConductorAPI, \u0027update_volume_connector\u0027)"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_9db4f1d1","line":313,"range":{"start_line":312,"start_character":0,"end_line":313,"end_character":70},"in_reply_to":"fa7ab95a_e772fb7b","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"7cc5b8aee6f3303a22d952667311513e41cb2af0","unresolved":false,"context_lines":[{"line_number":710,"context_line":"                                  expect_errors\u003dTrue)"},{"line_number":711,"context_line":"        self.assertEqual(http_client.CONFLICT, response.status_int)"},{"line_number":712,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":713,"context_line":"        error_msg \u003d response.json[\u0027error_message\u0027]"},{"line_number":714,"context_line":"        self.assertTrue(error_msg)"},{"line_number":715,"context_line":"        self.assertIn(connector_id, error_msg)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"9a89bdaa_a4e2cc01","line":714,"range":{"start_line":713,"start_character":7,"end_line":714,"end_character":34},"updated":"2016-09-05 07:26:25.000000000","message":"Why not consistent with all the others:\n    slef.assertTrue(response.json[\u0027error_message\u0027])","commit_id":"0602204f9feb547284cca8e5038228b3f661bfc2"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9806bc6bece31b670a1b366447b3b02bf9ca51a7","unresolved":false,"context_lines":[{"line_number":710,"context_line":"                                  expect_errors\u003dTrue)"},{"line_number":711,"context_line":"        self.assertEqual(http_client.CONFLICT, response.status_int)"},{"line_number":712,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":713,"context_line":"        error_msg \u003d response.json[\u0027error_message\u0027]"},{"line_number":714,"context_line":"        self.assertTrue(error_msg)"},{"line_number":715,"context_line":"        self.assertIn(connector_id, error_msg)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"ba5da102_7d58fd32","line":714,"range":{"start_line":713,"start_character":7,"end_line":714,"end_character":34},"in_reply_to":"9a89bdaa_a4e2cc01","updated":"2016-11-05 14:20:57.000000000","message":"Done","commit_id":"0602204f9feb547284cca8e5038228b3f661bfc2"}],"ironic/tests/unit/api/v1/test_volume_targets.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"9a4a7c054e0da6c9c4d9a8e37e79c3ee90ed87e0","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.assertEqual(http_client.NOT_ACCEPTABLE, data.status_int)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @mock.patch.object(api_volume_target.VolumeTargetsController,"},{"line_number":294,"context_line":"                       \u0027_get_volume/targets/collection\u0027)"},{"line_number":295,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":296,"context_line":"        # GET /v1/volume/targets/detail specifying node and node_uuid."},{"line_number":297,"context_line":"        # In this case, we expect the node_uuid interface to be used."}],"source_content_type":"text/x-python","patch_set":39,"id":"3ac371cc_62889623","line":294,"range":{"start_line":294,"start_character":22,"end_line":294,"end_character":56},"updated":"2016-08-15 14:06:31.000000000","message":"\u0027_get_volume_targets_collection\u0027 is correct.\nThis is method name, which shouldn\u0027t include \u0027/\u0027.","commit_id":"6a776abd480e83646efb3357864b5f678cb2875e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"779c22236c201fb027eb6c35228dfd6aab898518","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @mock.patch.object(api_volume_target.VolumeTargetsController,"},{"line_number":294,"context_line":"                       \u0027_get_volume_targets_collection\u0027)"},{"line_number":295,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":296,"context_line":"        # GET /v1/volume/targets/detail specifying node and node_uuid."},{"line_number":297,"context_line":"        # In this case, we expect the node_uuid interface to be used."},{"line_number":298,"context_line":"        self.get_json(\u0027/volume/targets/detail?node\u003d%s\u0026node_uuid\u003d%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa7ab95a_87f3ef72","line":295,"updated":"2016-08-26 16:34:53.000000000","message":"Same fix as test_volume_connectors is necessary here.","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0bb3e4b083256b010598a6452284c23e84519c90","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @mock.patch.object(api_volume_target.VolumeTargetsController,"},{"line_number":294,"context_line":"                       \u0027_get_volume_targets_collection\u0027)"},{"line_number":295,"context_line":"    def test_detail_with_incorrect_api_usage(self, mock_gpc):"},{"line_number":296,"context_line":"        # GET /v1/volume/targets/detail specifying node and node_uuid."},{"line_number":297,"context_line":"        # In this case, we expect the node_uuid interface to be used."},{"line_number":298,"context_line":"        self.get_json(\u0027/volume/targets/detail?node\u003d%s\u0026node_uuid\u003d%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":42,"id":"ba5da102_fdc5ed3b","line":295,"in_reply_to":"fa7ab95a_87f3ef72","updated":"2016-11-05 14:20:41.000000000","message":"Done","commit_id":"a9dd0b1f57b25959864cc2351ef2e97cf45dcc26"}],"releasenotes/notes/volume-connector-and-target-api-dd172f121ab3af8e.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"742799e3e829f0abb3db2806facfa0f57bdad8a3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds supports for volume connectors and volume targets with new API"},{"line_number":5,"context_line":"    endpoints ``/v1/volume/connectors`` and ``/v1/volume/targets``. These"},{"line_number":6,"context_line":"    end points are available with API version 1.32 or later. These new"},{"line_number":7,"context_line":"    resources are used to connect a node to a volume. A volume connector"},{"line_number":8,"context_line":"    represents connector information of a node such as iSCSI initiator. A"}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_647b8627","line":5,"updated":"2017-06-27 20:01:28.000000000","message":"what happens if someone does GET /v1/volume ?","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds supports for volume connectors and volume targets with new API"},{"line_number":5,"context_line":"    endpoints ``/v1/volume/connectors`` and ``/v1/volume/targets``. These"},{"line_number":6,"context_line":"    end points are available with API version 1.32 or later. These new"},{"line_number":7,"context_line":"    resources are used to connect a node to a volume. A volume connector"},{"line_number":8,"context_line":"    represents connector information of a node such as iSCSI initiator. A"}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_3a6a3919","line":5,"in_reply_to":"5f201791_647b8627","updated":"2017-06-28 08:00:14.000000000","message":"Links to volume connectors and targets are returned.","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"742799e3e829f0abb3db2806facfa0f57bdad8a3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    endpoints ``/v1/volume/connectors`` and ``/v1/volume/targets``. These"},{"line_number":6,"context_line":"    end points are available with API version 1.32 or later. These new"},{"line_number":7,"context_line":"    resources are used to connect a node to a volume. A volume connector"},{"line_number":8,"context_line":"    represents connector information of a node such as iSCSI initiator. A"},{"line_number":9,"context_line":"    volume target provides volume information such as iSCSI target."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    These endpoints are also added."}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_24ea2ed7","line":8,"updated":"2017-06-27 20:01:28.000000000","message":"nit as iSCSI/as an iSCSI/","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    endpoints ``/v1/volume/connectors`` and ``/v1/volume/targets``. These"},{"line_number":6,"context_line":"    end points are available with API version 1.32 or later. These new"},{"line_number":7,"context_line":"    resources are used to connect a node to a volume. A volume connector"},{"line_number":8,"context_line":"    represents connector information of a node such as iSCSI initiator. A"},{"line_number":9,"context_line":"    volume target provides volume information such as iSCSI target."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    These endpoints are also added."}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_9a26ed67","line":8,"in_reply_to":"5f201791_24ea2ed7","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"742799e3e829f0abb3db2806facfa0f57bdad8a3","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    end points are available with API version 1.32 or later. These new"},{"line_number":7,"context_line":"    resources are used to connect a node to a volume. A volume connector"},{"line_number":8,"context_line":"    represents connector information of a node such as iSCSI initiator. A"},{"line_number":9,"context_line":"    volume target provides volume information such as iSCSI target."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    These endpoints are also added."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_84d22227","line":9,"updated":"2017-06-27 20:01:28.000000000","message":"ditto","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    end points are available with API version 1.32 or later. These new"},{"line_number":7,"context_line":"    resources are used to connect a node to a volume. A volume connector"},{"line_number":8,"context_line":"    represents connector information of a node such as iSCSI initiator. A"},{"line_number":9,"context_line":"    volume target provides volume information such as iSCSI target."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    These endpoints are also added."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_7a29d134","line":9,"in_reply_to":"5f201791_84d22227","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"742799e3e829f0abb3db2806facfa0f57bdad8a3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    represents connector information of a node such as iSCSI initiator. A"},{"line_number":9,"context_line":"    volume target provides volume information such as iSCSI target."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    These endpoints are also added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * ``/v1/node/\u003cnode\u003e/volume/connectors``"},{"line_number":14,"context_line":"    * ``/v1/node/\u003cnode\u003e/volume/targets``"}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_44d9aa1f","line":11,"updated":"2017-06-27 20:01:28.000000000","message":"nit, s/./:/","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    represents connector information of a node such as iSCSI initiator. A"},{"line_number":9,"context_line":"    volume target provides volume information such as iSCSI target."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    These endpoints are also added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * ``/v1/node/\u003cnode\u003e/volume/connectors``"},{"line_number":14,"context_line":"    * ``/v1/node/\u003cnode\u003e/volume/targets``"}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_1a753dfa","line":11,"in_reply_to":"5f201791_44d9aa1f","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"742799e3e829f0abb3db2806facfa0f57bdad8a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    These endpoints are also added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * ``/v1/node/\u003cnode\u003e/volume/connectors``"},{"line_number":14,"context_line":"    * ``/v1/node/\u003cnode\u003e/volume/targets``"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    When a volume connector or a volume target is created, updated, or"},{"line_number":17,"context_line":"    deleted, CRUD notifications can be emitted."}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_449d2a64","line":14,"updated":"2017-06-27 20:01:28.000000000","message":"what happens if someone does GET /v1/node/\u003cnode\u003e/volume ?\n\nI can\u0027t recall, do we allow POST \u0026 DELETE here","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    These endpoints are also added."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * ``/v1/node/\u003cnode\u003e/volume/connectors``"},{"line_number":14,"context_line":"    * ``/v1/node/\u003cnode\u003e/volume/targets``"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    When a volume connector or a volume target is created, updated, or"},{"line_number":17,"context_line":"    deleted, CRUD notifications can be emitted."}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_fadde1dc","line":14,"in_reply_to":"5f201791_449d2a64","updated":"2017-06-28 08:00:14.000000000","message":"Only GET method is allowed.\nGET /v1/nodes/\u003cnode\u003e/volume provides links to volume connectors and targets belonging to the node.","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"742799e3e829f0abb3db2806facfa0f57bdad8a3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    * ``/v1/node/\u003cnode\u003e/volume/targets``"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    When a volume connector or a volume target is created, updated, or"},{"line_number":17,"context_line":"    deleted, CRUD notifications can be emitted."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    * ``baremetal.volumeconnector.create.start``"},{"line_number":20,"context_line":"    * ``baremetal.volumeconnector.create.end``"}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_24a6aeac","line":17,"updated":"2017-06-27 20:01:28.000000000","message":"maybe s/CRUD/these CRUD/\n\nand add a colon at the end, e.g. s/./:/","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"87a9b9b0e37704159ad2f9dbf8ace5e0dbb05530","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    * ``/v1/node/\u003cnode\u003e/volume/targets``"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    When a volume connector or a volume target is created, updated, or"},{"line_number":17,"context_line":"    deleted, CRUD notifications can be emitted."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    * ``baremetal.volumeconnector.create.start``"},{"line_number":20,"context_line":"    * ``baremetal.volumeconnector.create.end``"}],"source_content_type":"text/x-yaml","patch_set":95,"id":"5f201791_da30e5a1","line":17,"in_reply_to":"5f201791_24a6aeac","updated":"2017-06-28 08:00:14.000000000","message":"Done","commit_id":"373bd4294d0dbbd8c750d3c178774fe68614c5cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1df81c2b74048ac22a06689ea3f7580f423e53d1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds supports for volume connectors and volume targets with new API"},{"line_number":5,"context_line":"    endpoints ``/v1/volume/connectors`` and ``/v1/volume/targets``. These"},{"line_number":6,"context_line":"    endpoints are available with API version 1.32 or later. These new"},{"line_number":7,"context_line":"    resources are used to connect a node to a volume. A volume connector"}],"source_content_type":"text/x-yaml","patch_set":96,"id":"5f201791_12474b79","line":4,"updated":"2017-06-28 21:13:00.000000000","message":"nit s/supports/support/","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31dff3fe8a5dae88a519c996bc225a3188a8d79c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds supports for volume connectors and volume targets with new API"},{"line_number":5,"context_line":"    endpoints ``/v1/volume/connectors`` and ``/v1/volume/targets``. These"},{"line_number":6,"context_line":"    endpoints are available with API version 1.32 or later. These new"},{"line_number":7,"context_line":"    resources are used to connect a node to a volume. A volume connector"}],"source_content_type":"text/x-yaml","patch_set":96,"id":"3f1d235d_ba9a97c2","line":4,"in_reply_to":"5f201791_12474b79","updated":"2017-06-30 08:42:19.000000000","message":"Done","commit_id":"d3d59b7833c86ede462299d788e49cb2c248535f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"4d546b2606d74ad8823364ba3d791b8dec7e8124","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    endpoints are available with API version 1.32 or later. These new"},{"line_number":7,"context_line":"    resources are used to connect a node to a volume. A volume connector"},{"line_number":8,"context_line":"    represents connector information of a node such as an iSCSI initiator. A"},{"line_number":9,"context_line":"    volume target provides volume information such as an iSCSI target. These"},{"line_number":10,"context_line":"    endpoints are available:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    * ``GET /v1/volume/connectors`` for listing volume connectors"}],"source_content_type":"text/x-yaml","patch_set":101,"id":"3f1d235d_a7b57480","line":9,"range":{"start_line":9,"start_character":71,"end_line":9,"end_character":76},"updated":"2017-07-04 10:29:58.000000000","message":"nit - the following","commit_id":"c380e05dbf84079b01fb3b0ea099ef9b293b9b3d"}]}
