)]}'
{"ironic/common/utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"720eb5edb72c5ae1dccf5d3a5bc45e19d85d7a60","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"\"\"Convenience wrapper around oslo\u0027s execute() method."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    :param cmd: Passed to processutils.execute."},{"line_number":71,"context_line":"    :param use_standard_locale: True | False. Defaults to False. If set to"},{"line_number":72,"context_line":"                                True, execute command with standard locale"},{"line_number":73,"context_line":"                                added to environment variables."},{"line_number":74,"context_line":"    :returns: (stdout, stderr) from process execution"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_850f8587","line":71,"updated":"2015-08-25 05:05:27.000000000","message":"Need to change documentation","commit_id":"e17d2708f3fe4d786aa07d169cfa3456d71cf208"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"b26fb1438195bde37afabd8815be4447d92e50bc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"\"\"Convenience wrapper around oslo\u0027s execute() method."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    :param cmd: Passed to processutils.execute."},{"line_number":71,"context_line":"    :param use_standard_locale: True | False. Defaults to False. If set to"},{"line_number":72,"context_line":"                                True, execute command with standard locale"},{"line_number":73,"context_line":"                                added to environment variables."},{"line_number":74,"context_line":"    :returns: (stdout, stderr) from process execution"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_1ea54803","line":71,"in_reply_to":"fa1b9901_850f8587","updated":"2015-08-28 00:04:11.000000000","message":"Thanks for your advice. I\u0027m thinking about following to Ruby\u0027s idea and will not change this code :)","commit_id":"e17d2708f3fe4d786aa07d169cfa3456d71cf208"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"620610b85bd6c27964cf42612f9ec6e9d8ab405f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    :raises: ProcessExecutionError"},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    use_standard_locale \u003d kwargs.pop(\u0027use_standard_locale\u0027, True)"},{"line_number":80,"context_line":"    if use_standard_locale:"},{"line_number":81,"context_line":"        env \u003d kwargs.pop(\u0027env_variables\u0027, os.environ.copy())"},{"line_number":82,"context_line":"        env[\u0027LC_ALL\u0027] \u003d \u0027C\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_302260a4","line":79,"updated":"2015-08-25 14:14:08.000000000","message":"I don\u0027t like changing the default value because this could break something else.\n\nMaybe we need to change the code that calls this, to pass use_standard_locale\u003dTrue for your use case?","commit_id":"e17d2708f3fe4d786aa07d169cfa3456d71cf208"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"b26fb1438195bde37afabd8815be4447d92e50bc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    :raises: ProcessExecutionError"},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    use_standard_locale \u003d kwargs.pop(\u0027use_standard_locale\u0027, True)"},{"line_number":80,"context_line":"    if use_standard_locale:"},{"line_number":81,"context_line":"        env \u003d kwargs.pop(\u0027env_variables\u0027, os.environ.copy())"},{"line_number":82,"context_line":"        env[\u0027LC_ALL\u0027] \u003d \u0027C\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_9eb95831","line":79,"in_reply_to":"fa1b9901_302260a4","updated":"2015-08-28 00:04:11.000000000","message":"Nice idea. I will ask to downstream guys...","commit_id":"e17d2708f3fe4d786aa07d169cfa3456d71cf208"}],"ironic/tests/drivers/test_deploy_utils.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b6b29e9ad6d586279de2fc2a7bc99e3924a8f449","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"        expected_calls \u003d [mock.call(\u0027dd\u0027, \u0027if\u003d/dev/zero\u0027, \u0027of\u003dfake-dev\u0027,"},{"line_number":1418,"context_line":"                                    \u0027bs\u003d512\u0027, \u0027count\u003d36\u0027, run_as_root\u003dTrue,"},{"line_number":1419,"context_line":"                                    check_exit_code\u003d[0],"},{"line_number":1420,"context_line":"                                    use_standard_locale\u003dTrue),"},{"line_number":1421,"context_line":"                          mock.call(\u0027dd\u0027, \u0027if\u003d/dev/zero\u0027, \u0027of\u003dfake-dev\u0027,"},{"line_number":1422,"context_line":"                                    \u0027bs\u003d512\u0027, \u0027count\u003d36\u0027, \u0027seek\u003d28\u0027,"},{"line_number":1423,"context_line":"                                    run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_582ef98c","line":1420,"updated":"2015-09-23 17:06:53.000000000","message":"This is likely going to fail, argument order matters here and the dd() call has use_standard_locale before run_as_root","commit_id":"a1ad8d5bd079d8bf832cbc3582caf5e125b361fe"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f5783ee8b1a87ef7f551f9f382b92fea1851fb4c","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"        expected_calls \u003d [mock.call(\u0027dd\u0027, \u0027if\u003d/dev/zero\u0027, \u0027of\u003dfake-dev\u0027,"},{"line_number":1418,"context_line":"                                    \u0027bs\u003d512\u0027, \u0027count\u003d36\u0027, run_as_root\u003dTrue,"},{"line_number":1419,"context_line":"                                    check_exit_code\u003d[0],"},{"line_number":1420,"context_line":"                                    use_standard_locale\u003dTrue),"},{"line_number":1421,"context_line":"                          mock.call(\u0027dd\u0027, \u0027if\u003d/dev/zero\u0027, \u0027of\u003dfake-dev\u0027,"},{"line_number":1422,"context_line":"                                    \u0027bs\u003d512\u0027, \u0027count\u003d36\u0027, \u0027seek\u003d28\u0027,"},{"line_number":1423,"context_line":"                                    run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_651e2c0e","line":1420,"in_reply_to":"ba15a1d1_582ef98c","updated":"2015-09-25 14:29:00.000000000","message":"I\u0027m guessing since the tests pass that mock is smart enough to understand that the ordering of kwargs doesn\u0027t matter.","commit_id":"a1ad8d5bd079d8bf832cbc3582caf5e125b361fe"}]}