)]}'
{"doc/source/dev/architecture.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"179ec62a410c6051c739302b9a865e65cd6094b9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"For example \u0027spacing\u003d5\u0027 means every 5 seconds."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. note::"},{"line_number":101,"context_line":"    Currently the ``parallel`` argument may be passed to driver_periodic_task_."},{"line_number":102,"context_line":"    If it\u0027s set to False, this task will be run in the periodic task loop,"},{"line_number":103,"context_line":"    rather than a separate greenthread."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa1b9901_8e11b206","line":101,"updated":"2015-08-26 00:10:51.000000000","message":"I don\u0027t like to use \u0027currently\u0027 or \u0027now\u0027, because unless otherwise stated, when you read something, it is all current/now.","commit_id":"27101f7d6bd089b8e729044508e7d6307c319fac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6ac099e344a77f651a1b086d44a6ebb4bfb4cc1d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"For example \u0027spacing\u003d5\u0027 means every 5 seconds."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. note::"},{"line_number":101,"context_line":"    Currently the ``parallel`` argument may be passed to driver_periodic_task_."},{"line_number":102,"context_line":"    If it\u0027s set to False, this task will be run in the periodic task loop,"},{"line_number":103,"context_line":"    rather than a separate greenthread."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa1b9901_32a47949","line":101,"in_reply_to":"fa1b9901_8e11b206","updated":"2015-08-26 09:41:39.000000000","message":"Done","commit_id":"27101f7d6bd089b8e729044508e7d6307c319fac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"179ec62a410c6051c739302b9a865e65cd6094b9","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    If it\u0027s set to False, this task will be run in the periodic task loop,"},{"line_number":103,"context_line":"    rather than a separate greenthread."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    This is deprecated, and this parameter will become a noop in Mitaka"},{"line_number":106,"context_line":"    cycle, as such task would cause all other periodic tasks to be blocked"},{"line_number":107,"context_line":"    from starting while the non-parallel task is running."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa1b9901_4ecdda83","line":105,"updated":"2015-08-26 00:10:51.000000000","message":"What do you think about using the text from the original. Then adding this part, eg \u0027This is deprecated and the parallel argument will be ignored starting in the Mitaka cycle.\u0027","commit_id":"27101f7d6bd089b8e729044508e7d6307c319fac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6ac099e344a77f651a1b086d44a6ebb4bfb4cc1d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    If it\u0027s set to False, this task will be run in the periodic task loop,"},{"line_number":103,"context_line":"    rather than a separate greenthread."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    This is deprecated, and this parameter will become a noop in Mitaka"},{"line_number":106,"context_line":"    cycle, as such task would cause all other periodic tasks to be blocked"},{"line_number":107,"context_line":"    from starting while the non-parallel task is running."},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa1b9901_72ae712f","line":105,"in_reply_to":"fa1b9901_4ecdda83","updated":"2015-08-26 09:41:39.000000000","message":"I want to get rid of \"should be used with caution\", as it should NOT be used at all :)","commit_id":"27101f7d6bd089b8e729044508e7d6307c319fac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"da5ed89c0762be158190e07ecb82925cabcc3a8b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"For example \u0027spacing\u003d5\u0027 means every 5 seconds."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. note::"},{"line_number":101,"context_line":"    As of Liberty release, the ``parallel`` argument may be passed to"},{"line_number":102,"context_line":"    driver_periodic_task_. If it\u0027s set to False, this task will be run in"},{"line_number":103,"context_line":"    the periodic task loop, rather than a separate greenthread."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da20952f_59546353","line":101,"updated":"2015-08-26 16:02:05.000000000","message":"I don\u0027t think \"As of Liberty release\" should be here, because we\u0027ve had this argument before Liberty (don\u0027t recall when). I think it goes in line 105, before \u0027this is deprecated\u0027.\n\nOr if you want this entire note to be about the deprecation, start it with \u0027As of Liberty release, the parallel argument is deprecated and will be ignored... The parallel argument defaults to True. If it\u0027s set to False...","commit_id":"26d1edd12ca3de7f0ed3c38889a9f561cfb13ae8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"da5ed89c0762be158190e07ecb82925cabcc3a8b","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    This is deprecated, and the parallel argument will be ignored starting in"},{"line_number":106,"context_line":"    the Mitaka cycle, as such task would cause all other periodic tasks"},{"line_number":107,"context_line":"    to be blocked from starting while the non-parallel task is running."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":"    By default periodic task names are derived from method names,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da20952f_795b6755","line":107,"updated":"2015-08-26 16:02:05.000000000","message":"maybe \u0027to prevent other periodic tasks from being blocked from starting while the non-parallel task is running.\u0027 ?","commit_id":"26d1edd12ca3de7f0ed3c38889a9f561cfb13ae8"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bd2658d11cdaeb338ddfa8639b9207867021a2b4","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    This is deprecated as of Liberty release, and the parallel argument will be"},{"line_number":106,"context_line":"    ignored starting in the Mitaka cycle, as such task would prevent all other"},{"line_number":107,"context_line":"    periodic tasks from starting while it is is running."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":"    By default periodic task names are derived from method names,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da20952f_2d276e65","line":107,"updated":"2015-08-28 15:16:28.000000000","message":"What about something like this??\n\nThe ``parallel`` argument may be passed to driver_periodic_task_.\nIf it\u0027s set to False, this task will be run in the periodic task loop,\nrather than a separate greenthread.\n\n.. warning:: \n    This is deprecated as of Liberty release, and the parallel argument will be\n    ignored starting in the Mitaka cycle, as such task would prevent all other\n    periodic tasks from starting while it is is running.","commit_id":"55e655a01efb48b5f2d0fdb69ca676fca933d1ee"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9c86f2650033c81a08439a8a7c696fb589b55e90","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    This is deprecated as of Liberty release, and the parallel argument will be"},{"line_number":106,"context_line":"    ignored starting in the Mitaka cycle, as such task would prevent all other"},{"line_number":107,"context_line":"    periodic tasks from starting while it is is running."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":"    By default periodic task names are derived from method names,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da20952f_b3a4ea4a","line":107,"in_reply_to":"da20952f_2d276e65","updated":"2015-08-31 18:51:49.000000000","message":"+1 for warning","commit_id":"55e655a01efb48b5f2d0fdb69ca676fca933d1ee"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"66e2dfef25ff4ef2c6741e6986b5c516399e6b2a","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    This is deprecated as of Liberty release, and the parallel argument will be"},{"line_number":106,"context_line":"    ignored starting in the Mitaka cycle, as such task would prevent all other"},{"line_number":107,"context_line":"    periodic tasks from starting while it is is running."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. note::"},{"line_number":110,"context_line":"    By default periodic task names are derived from method names,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da20952f_ae66bdb8","line":107,"in_reply_to":"da20952f_b3a4ea4a","updated":"2015-08-31 19:00:20.000000000","message":"I am fine as is, because it is in a NOTE so it is being highlighted already.\n\nWe don\u0027t tend to put warnings wrt deprecations. The Warning that we do have, shows up in red (eg [1]). I don\u0027t think this warrants being red.\n\n[1] http://docs.openstack.org/developer/ironic/cmds/ironic-dbsync.html","commit_id":"55e655a01efb48b5f2d0fdb69ca676fca933d1ee"}],"ironic/drivers/base.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"179ec62a410c6051c739302b9a865e65cd6094b9","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"                eventlet.greenthread.spawn_n(_internal)"},{"line_number":1044,"context_line":"            else:"},{"line_number":1045,"context_line":"                LOG.warn(_LW(\u0027Using periodic tasks with parallel\u003dFalse is \u0027"},{"line_number":1046,"context_line":"                             \u0027deprecated and will become a no-op in Mitaka \u0027"},{"line_number":1047,"context_line":"                             \u0027release\u0027))"},{"line_number":1048,"context_line":"                func(*args, **kwargs)"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_933d5ddf","line":1046,"updated":"2015-08-26 00:10:51.000000000","message":"wondering if it is clear what \u0027become a no-op\u0027 means to the readers of this. What about mentioning that the periodic tasks will always be done in separate threads.","commit_id":"27101f7d6bd089b8e729044508e7d6307c319fac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6ac099e344a77f651a1b086d44a6ebb4bfb4cc1d","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"                eventlet.greenthread.spawn_n(_internal)"},{"line_number":1044,"context_line":"            else:"},{"line_number":1045,"context_line":"                LOG.warn(_LW(\u0027Using periodic tasks with parallel\u003dFalse is \u0027"},{"line_number":1046,"context_line":"                             \u0027deprecated and will become a no-op in Mitaka \u0027"},{"line_number":1047,"context_line":"                             \u0027release\u0027))"},{"line_number":1048,"context_line":"                func(*args, **kwargs)"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_920ea53b","line":1046,"in_reply_to":"fa1b9901_933d5ddf","updated":"2015-08-26 09:41:39.000000000","message":"Done","commit_id":"27101f7d6bd089b8e729044508e7d6307c319fac"},{"author":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"change_message_id":"6f41f9f51ef84ac5f13abc6492d8cb53c1acfee3","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"            loop, rather than a separate greenthread. False should be used with"},{"line_number":1025,"context_line":"            caution, as it will cause all other periodic tasks to be blocked"},{"line_number":1026,"context_line":"            from starting while the non-parallel task is running. Long running"},{"line_number":1027,"context_line":"            tasks, especially any tasks that make a remote call (to a BMC,"},{"line_number":1028,"context_line":"            HTTP, etc.) must be parallelized."},{"line_number":1029,"context_line":"    :param other: arguments to pass to @periodic_task.periodic_task"},{"line_number":1030,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_c0ab1e1c","line":1027,"updated":"2015-08-28 14:19:45.000000000","message":"For completeness, I feel like this comment should be changed to add a note about the deprecation. Like:\n\nNOTE: The parallel argument is deprecated as of the Liberty release, and will be ignored starting with Mitaka.","commit_id":"09b5ec69ae3c2ed90d30d9f15a7311c54cec1cd5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"dabe32f0502b6ad18e49dec6f268b7208624722f","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"    :param other: arguments to pass to @periodic_task.periodic_task"},{"line_number":1027,"context_line":"    \"\"\""},{"line_number":1028,"context_line":"    # TODO(dtantsur): drop all this magic once"},{"line_number":1029,"context_line":"    # https://review.openstack.org/#/c/134303/ lands"},{"line_number":1030,"context_line":"    semaphore \u003d eventlet.semaphore.BoundedSemaphore()"},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"    def decorator2(func):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_bb41af3b","line":1029,"updated":"2015-09-02 16:58:42.000000000","message":"Is this comment impacted at all?","commit_id":"55e655a01efb48b5f2d0fdb69ca676fca933d1ee"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"df0f55de4cc1fe1215f25172fde5eedf185c085b","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"            else:"},{"line_number":1042,"context_line":"                LOG.warn(_LW("},{"line_number":1043,"context_line":"                    \u0027Using periodic tasks with parallel\u003dFalse is deprecated, \u0027"},{"line_number":1044,"context_line":"                    \u0027\"parallel\" argument will be ignored starting with \u0027"},{"line_number":1045,"context_line":"                    \u0027the Mitaka release\u0027))"},{"line_number":1046,"context_line":"                func(*args, **kwargs)"},{"line_number":1047,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_9b03af0d","line":1044,"updated":"2015-09-02 01:48:38.000000000","message":"wondering if it was worth printing func.__name__ somewhere like\n\n  \u0027\"parallel\" argument will be ignored for %s starting with \u0027\n  \u0027the Mitaka release\u0027,   func.__name__","commit_id":"55e655a01efb48b5f2d0fdb69ca676fca933d1ee"}]}