)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0820626686a73cb980cbc91cf279266ab22c3dcc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-25 08:27:24 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix ensures pass_deploy_info() always calls boot.prepare_instance()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1488338"},{"line_number":10,"context_line":"Change-Id: Ibf03caa9cf8a695f6269a3c2a6886cbf11c04b22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_9bd6e44d","line":7,"updated":"2015-08-25 17:39:00.000000000","message":"s/Fix ensures/Ensure that/","commit_id":"d7fbbdaf6524fa393b2be984a6d63a39425ccf54"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ae8b3c5ef16e455432f04f746351dcfa912ea91d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-25 08:27:24 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix ensures pass_deploy_info() always calls boot.prepare_instance()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1488338"},{"line_number":10,"context_line":"Change-Id: Ibf03caa9cf8a695f6269a3c2a6886cbf11c04b22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_37146be7","line":7,"in_reply_to":"fa1b9901_9bd6e44d","updated":"2015-08-26 09:05:20.000000000","message":"Done","commit_id":"d7fbbdaf6524fa393b2be984a6d63a39425ccf54"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2b3b356fbe38f2756ab1eb978b20fdbb28ca77bb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-08-26 09:04:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure that pass_deploy_info() always calls boot.prepare_instance()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1488338"},{"line_number":10,"context_line":"Change-Id: Ibf03caa9cf8a695f6269a3c2a6886cbf11c04b22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_b7b71b84","line":8,"updated":"2015-08-26 09:14:33.000000000","message":"Can we have a commit message here.  \n\n  Ensure that pass_deploy_info() always calls boot.prepare_instance()\n\n  Currently, when pass_deploy_info vendor passthru is called for local\n  boot, boot.prepare_instance() is not called.  This doesn\u0027t give an\n  opportunity for boot interfaces to do the required things for\n  local boot.  This commit refactors the code so that pass_deploy_info() \n  always calls boot.prepare_instance()","commit_id":"acad634af3bc99e344f69591a1b29f88bf2bfa03"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"968b6afa1249d9c15beee79ef4d9f5bbcb0a5e46","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-08-26 09:04:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure that pass_deploy_info() always calls boot.prepare_instance()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1488338"},{"line_number":10,"context_line":"Change-Id: Ibf03caa9cf8a695f6269a3c2a6886cbf11c04b22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_faefb71a","line":8,"in_reply_to":"fa1b9901_b7b71b84","updated":"2015-08-26 10:21:33.000000000","message":"Done","commit_id":"acad634af3bc99e344f69591a1b29f88bf2bfa03"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0820626686a73cb980cbc91cf279266ab22c3dcc","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        node.save()"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        try:"},{"line_number":838,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"            if deploy_utils.get_boot_option(node) \u003d\u003d \"local\":"},{"line_number":841,"context_line":"                deploy_utils.try_set_boot_device(task, boot_devices.DISK)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_5b592c34","line":838,"updated":"2015-08-25 17:39:00.000000000","message":"Does this need to be in the try block?","commit_id":"d7fbbdaf6524fa393b2be984a6d63a39425ccf54"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ae8b3c5ef16e455432f04f746351dcfa912ea91d","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        node.save()"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        try:"},{"line_number":838,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"            if deploy_utils.get_boot_option(node) \u003d\u003d \"local\":"},{"line_number":841,"context_line":"                deploy_utils.try_set_boot_device(task, boot_devices.DISK)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_f70a73d1","line":838,"in_reply_to":"fa1b9901_5b592c34","updated":"2015-08-26 09:05:20.000000000","message":"yes. any exception from prepare_instance is caught here and action taken.","commit_id":"d7fbbdaf6524fa393b2be984a6d63a39425ccf54"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0820626686a73cb980cbc91cf279266ab22c3dcc","unresolved":false,"context_lines":[{"line_number":847,"context_line":"                    task.process_event(\u0027wait\u0027)"},{"line_number":848,"context_line":"                    return"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"        except Exception as e:"},{"line_number":851,"context_line":"            LOG.error(_LE(\u0027Deploy failed for instance %(instance)s. \u0027"},{"line_number":852,"context_line":"                          \u0027Error: %(error)s\u0027),"},{"line_number":853,"context_line":"                      {\u0027instance\u0027: node.instance_uuid, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_1bdc1472","line":850,"updated":"2015-08-25 17:39:00.000000000","message":"Can this Exception catch be more restrictive? Just seems wrong to have such a big catch.  But I realize unrelated to this patch and there are multiple of them in this file.","commit_id":"d7fbbdaf6524fa393b2be984a6d63a39425ccf54"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ae8b3c5ef16e455432f04f746351dcfa912ea91d","unresolved":false,"context_lines":[{"line_number":847,"context_line":"                    task.process_event(\u0027wait\u0027)"},{"line_number":848,"context_line":"                    return"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"        except Exception as e:"},{"line_number":851,"context_line":"            LOG.error(_LE(\u0027Deploy failed for instance %(instance)s. \u0027"},{"line_number":852,"context_line":"                          \u0027Error: %(error)s\u0027),"},{"line_number":853,"context_line":"                      {\u0027instance\u0027: node.instance_uuid, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_57fa3fbe","line":850,"in_reply_to":"fa1b9901_1bdc1472","updated":"2015-08-26 09:05:20.000000000","message":"Possibly.","commit_id":"d7fbbdaf6524fa393b2be984a6d63a39425ccf54"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0dcfa97ba070b684348285fd0c492cd3804961ed","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        node.save()"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        try:"},{"line_number":838,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"            if deploy_utils.get_boot_option(node) \u003d\u003d \"local\":"},{"line_number":841,"context_line":"                deploy_utils.try_set_boot_device(task, boot_devices.DISK)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_c19a0d62","line":838,"updated":"2015-08-26 08:26:56.000000000","message":"Is there any reason to place this here and not in finish_deploy() ? \n\nEven I don\u0027t really have a reason to choose this place over finish_deploy() except for the reason that - if in finish_deploy(), it gets executed only after everything else.","commit_id":"a7ac145364a9d9535bcf803a0b67b8a95a24de25"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"33bcdd10c141747d694b1f945d376e7d1814a3e8","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        node.save()"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        try:"},{"line_number":838,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"            if deploy_utils.get_boot_option(node) \u003d\u003d \"local\":"},{"line_number":841,"context_line":"                deploy_utils.try_set_boot_device(task, boot_devices.DISK)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_d75e4fe8","line":838,"in_reply_to":"fa1b9901_c19a0d62","updated":"2015-08-26 09:06:11.000000000","message":"We cannot put this in the  finish_deploy(). It is not a class method and is being used by several drivers. All of them would be broken if we add this change over there.","commit_id":"a7ac145364a9d9535bcf803a0b67b8a95a24de25"}]}