)]}'
{"ironic/tests/api/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"aaf911a2cfa283fda1a95875c12f0b45b9daeedb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    node.pop(\u0027conductor_affinity\u0027)"},{"line_number":95,"context_line":"    node.pop(\u0027chassis_id\u0027)"},{"line_number":96,"context_line":"    node.pop(\u0027target_raid_config\u0027)"},{"line_number":97,"context_line":"    node.pop(\u0027raid_config\u0027)"},{"line_number":98,"context_line":"    internal \u003d node_controller.NodePatchType.internal_attrs()"},{"line_number":99,"context_line":"    return remove_internal(node, internal)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_c5aa3971","line":97,"updated":"2015-08-25 17:03:59.000000000","message":"where did the raid ones come from? We don\u0027t have that in the code yet?","commit_id":"7439635d7836cd91d39d9668af2f224f67247ebd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2d67d50ce72a8383bce3b9e645125603f11f657","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    node.pop(\u0027conductor_affinity\u0027)"},{"line_number":95,"context_line":"    node.pop(\u0027chassis_id\u0027)"},{"line_number":96,"context_line":"    node.pop(\u0027target_raid_config\u0027)"},{"line_number":97,"context_line":"    node.pop(\u0027raid_config\u0027)"},{"line_number":98,"context_line":"    internal \u003d node_controller.NodePatchType.internal_attrs()"},{"line_number":99,"context_line":"    return remove_internal(node, internal)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_a0eff31c","line":97,"in_reply_to":"fa1b9901_a566254f","updated":"2015-08-25 17:14:17.000000000","message":"Oops, my bad. Forgot we had added those. Thx.","commit_id":"7439635d7836cd91d39d9668af2f224f67247ebd"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4026207cf52f50d24c7163e01d6700d2b6928fff","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    node.pop(\u0027conductor_affinity\u0027)"},{"line_number":95,"context_line":"    node.pop(\u0027chassis_id\u0027)"},{"line_number":96,"context_line":"    node.pop(\u0027target_raid_config\u0027)"},{"line_number":97,"context_line":"    node.pop(\u0027raid_config\u0027)"},{"line_number":98,"context_line":"    internal \u003d node_controller.NodePatchType.internal_attrs()"},{"line_number":99,"context_line":"    return remove_internal(node, internal)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_a566254f","line":97,"in_reply_to":"fa1b9901_c5aa3971","updated":"2015-08-25 17:06:20.000000000","message":"https://review.openstack.org/#/c/155230/\n\nThey are not part of the API object, only exist in the DB (therefore WSME is complaining about it)","commit_id":"7439635d7836cd91d39d9668af2f224f67247ebd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"792663897c587c665fb0640aefabc6519c516b85","unresolved":false,"context_lines":[{"line_number":91,"context_line":"def node_post_data(**kw):"},{"line_number":92,"context_line":"    node \u003d utils.get_test_node(**kw)"},{"line_number":93,"context_line":"    # These values are not part of the API object"},{"line_number":94,"context_line":"    node.pop(\u0027conductor_affinity\u0027)"},{"line_number":95,"context_line":"    node.pop(\u0027chassis_id\u0027)"},{"line_number":96,"context_line":"    node.pop(\u0027target_raid_config\u0027)"},{"line_number":97,"context_line":"    node.pop(\u0027raid_config\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_c04b07b0","line":94,"updated":"2015-08-25 17:29:34.000000000","message":"nit: maybe should have a default value in case it doesn\u0027t exist?\n\nAs a random thought and feel free to ignore:\n for id in (\u0027chassis_id\u0027, \u0027conductor_affinity\u0027, \u0027raid_config\u0027, \u0027target_raid_config\u0027):\n    node.pop(id, \u0027\u0027)","commit_id":"3d45795abb3eb36937d533904ed48a0755c10b0c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e7f5e8221ce30f4d85f130fb0526018049b7ee18","unresolved":false,"context_lines":[{"line_number":91,"context_line":"def node_post_data(**kw):"},{"line_number":92,"context_line":"    node \u003d utils.get_test_node(**kw)"},{"line_number":93,"context_line":"    # These values are not part of the API object"},{"line_number":94,"context_line":"    node.pop(\u0027conductor_affinity\u0027)"},{"line_number":95,"context_line":"    node.pop(\u0027chassis_id\u0027)"},{"line_number":96,"context_line":"    node.pop(\u0027target_raid_config\u0027)"},{"line_number":97,"context_line":"    node.pop(\u0027raid_config\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_db8d3cd4","line":94,"in_reply_to":"fa1b9901_c04b07b0","updated":"2015-08-25 17:55:09.000000000","message":"I\u0027m not sure we want a default value. These should exist since it is our code. If it doesn\u0027t exist, we should update the test or find out what happened.\n\nYeah, the for... is nicer. Maybe we can change when someone adds another field :)","commit_id":"3d45795abb3eb36937d533904ed48a0755c10b0c"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3ec78fe16a34aa18da064be8fd0888f871db1b74","unresolved":false,"context_lines":[{"line_number":91,"context_line":"def node_post_data(**kw):"},{"line_number":92,"context_line":"    node \u003d utils.get_test_node(**kw)"},{"line_number":93,"context_line":"    # These values are not part of the API object"},{"line_number":94,"context_line":"    node.pop(\u0027conductor_affinity\u0027)"},{"line_number":95,"context_line":"    node.pop(\u0027chassis_id\u0027)"},{"line_number":96,"context_line":"    node.pop(\u0027target_raid_config\u0027)"},{"line_number":97,"context_line":"    node.pop(\u0027raid_config\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_d61431ea","line":94,"in_reply_to":"fa1b9901_db8d3cd4","updated":"2015-08-25 18:06:12.000000000","message":"Uh whoops on my part. Totally spaced this was a test file :( So yes would not want a default value as would want it to fail if it doesn\u0027t exist.","commit_id":"3d45795abb3eb36937d533904ed48a0755c10b0c"}]}
