)]}'
{"ironic/objects/base.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6f49ac0854b8ac369d875ab75736339d77196456","unresolved":false,"context_lines":[{"line_number":28,"context_line":"remotable \u003d object_base.remotable"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class IronicObjectRegistry(object_base.VersionedObjectRegistry):"},{"line_number":32,"context_line":"    pass"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_39157048","line":31,"updated":"2015-09-03 18:16:16.000000000","message":"Is there a reason we shouldn\u0027t use object_base.VersionedObject directly throughout rather than using a wrapper class?","commit_id":"4fcb3e2c9c82689ee5708f8e104973a8a802674c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"60288acd8065e76390c2f0c4d4de99caf591217d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"remotable \u003d object_base.remotable"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class IronicObjectRegistry(object_base.VersionedObjectRegistry):"},{"line_number":32,"context_line":"    pass"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_a355f8fa","line":31,"in_reply_to":"da20952f_1cf6fe8e","updated":"2015-09-09 22:17:12.000000000","message":"Yep, since this becomes the base for a bunch of register calls elsewhere, doing it this way mirrors what projects like nova do. There is one hook function currently that you could be implementing here if you needed it, and there may be more later. If you don\u0027t do this placeholder, then later you just have to go change everywhere you do the register calls, which is messy. If you miss one then the hook for that object doesn\u0027t get called, etc.","commit_id":"4fcb3e2c9c82689ee5708f8e104973a8a802674c"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"4d4cf7a8b7574c39cb112b223239e3b05705f726","unresolved":false,"context_lines":[{"line_number":28,"context_line":"remotable \u003d object_base.remotable"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class IronicObjectRegistry(object_base.VersionedObjectRegistry):"},{"line_number":32,"context_line":"    pass"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_1cf6fe8e","line":31,"in_reply_to":"da20952f_39157048","updated":"2015-09-07 08:49:55.000000000","message":"At the moment, the answer is No. But we can add some hook functions in future when it is necessary. It\u0027s not so bad to keep the flexibility in my mind.","commit_id":"4fcb3e2c9c82689ee5708f8e104973a8a802674c"}],"ironic/tests/objects/test_objects.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"60288acd8065e76390c2f0c4d4de99caf591217d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        pass"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":91,"context_line":"class TestSubclassedObject(MyObj):"},{"line_number":92,"context_line":"    fields \u003d {\u0027new_field\u0027: fields.StringField()}"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_c3210ca0","line":90,"updated":"2015-09-09 22:17:12.000000000","message":"Most of these objects should not be actually registered like this, because they risk being in the registry at runtime due to an import accident. You should use register_if(False) for anything that doesn\u0027t need actual deserialization testing.","commit_id":"4fcb3e2c9c82689ee5708f8e104973a8a802674c"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"dd33605e725e7d38e4029e59563bb39dc687988f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        pass"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":91,"context_line":"class TestSubclassedObject(MyObj):"},{"line_number":92,"context_line":"    fields \u003d {\u0027new_field\u0027: fields.StringField()}"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_dd4f9f68","line":90,"in_reply_to":"da20952f_c3210ca0","updated":"2015-09-10 07:34:52.000000000","message":"Good point. Thanks,","commit_id":"4fcb3e2c9c82689ee5708f8e104973a8a802674c"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"fa3327c7f9ec352d1579bf38dbb2b13d30045442","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        pass"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":91,"context_line":"class TestSubclassedObject(MyObj):"},{"line_number":92,"context_line":"    fields \u003d {\u0027new_field\u0027: fields.StringField()}"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_0e0534c1","line":90,"in_reply_to":"da20952f_c3210ca0","updated":"2015-09-13 21:59:48.000000000","message":"Thanks Dan for reviewing!","commit_id":"4fcb3e2c9c82689ee5708f8e104973a8a802674c"}]}
