)]}'
{"ironic/api/__init__.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"ab1a29babff971a0062f1e123592dd5df39b58b2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                      \"host URL. If the API is operating behind a proxy, you \""},{"line_number":39,"context_line":"                      \"will want to change this to represent the proxy\u0027s URL. \""},{"line_number":40,"context_line":"                      \"Defaults to None.\")),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027api_workers\u0027,"},{"line_number":42,"context_line":"               default\u003dprocessutils.get_worker_count(),"},{"line_number":43,"context_line":"               help\u003d_(\u0027Number of workers for OpenStack Ironic API service. \u0027"},{"line_number":44,"context_line":"                      \u0027The default is equal to the number of CPUs available \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_86b2dd92","line":41,"updated":"2015-10-22 03:37:29.000000000","message":"As you add a new config option, seems you shoud use \u0027tox -egenconfig\u0027 to generate the ironic.conf.sample file.","commit_id":"3414ca35be4737815331e0abab9e8bcbcedd9ae8"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"4952a2467c53245c2d055e3b3a59447308b6f1bf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                      \"host URL. If the API is operating behind a proxy, you \""},{"line_number":39,"context_line":"                      \"will want to change this to represent the proxy\u0027s URL. \""},{"line_number":40,"context_line":"                      \"Defaults to None.\")),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027api_workers\u0027,"},{"line_number":42,"context_line":"               default\u003dprocessutils.get_worker_count(),"},{"line_number":43,"context_line":"               help\u003d_(\u0027Number of workers for OpenStack Ironic API service. \u0027"},{"line_number":44,"context_line":"                      \u0027The default is equal to the number of CPUs available \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_bb660b4f","line":41,"in_reply_to":"3a29b11f_86b2dd92","updated":"2015-10-22 07:58:09.000000000","message":"misssed, thanks","commit_id":"3414ca35be4737815331e0abab9e8bcbcedd9ae8"}],"ironic/cmd/api.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c2fd0fe5769660a39683d386043c4d0b118029b8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    LOG.info(_LI(\"Serving on http://%(host)s:%(port)s\"),"},{"line_number":55,"context_line":"             {\u0027host\u0027: host, \u0027port\u0027: port})"},{"line_number":56,"context_line":"    LOG.debug(\"Configuration:\")"},{"line_number":57,"context_line":"    CONF.log_opt_values(LOG, logging.DEBUG)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    try:"},{"line_number":60,"context_line":"        wsgi.serve_forever()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_6de63d18","side":"PARENT","line":57,"updated":"2015-09-01 15:09:43.000000000","message":"Does launch_service do this? I\u0027m thinking not... let\u0027s not drop this feature.","commit_id":"ec461e7e38cdfe9b59e5b374abf44902784fd9a0"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"43d2f5c2700a2ce4ee14db2bb0c3fdbd8c8611fe","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    LOG.info(_LI(\"Serving on http://%(host)s:%(port)s\"),"},{"line_number":55,"context_line":"             {\u0027host\u0027: host, \u0027port\u0027: port})"},{"line_number":56,"context_line":"    LOG.debug(\"Configuration:\")"},{"line_number":57,"context_line":"    CONF.log_opt_values(LOG, logging.DEBUG)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    try:"},{"line_number":60,"context_line":"        wsgi.serve_forever()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_68c94b5a","side":"PARENT","line":57,"in_reply_to":"da20952f_6de63d18","updated":"2015-09-01 15:25:50.000000000","message":"ProcessLauncher does it: https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L506","commit_id":"ec461e7e38cdfe9b59e5b374abf44902784fd9a0"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"ea2274bb1558c194dba8ba218b7dd1a0e7e378b4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    launcher.wait()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":44,"context_line":"        sys.exit(main())"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_efdfe5d3","line":44,"updated":"2015-10-22 05:49:13.000000000","message":"extra spaces?","commit_id":"3414ca35be4737815331e0abab9e8bcbcedd9ae8"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"4952a2467c53245c2d055e3b3a59447308b6f1bf","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    launcher.wait()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":44,"context_line":"        sys.exit(main())"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_9b7c6fed","line":44,"in_reply_to":"3a29b11f_efdfe5d3","updated":"2015-10-22 07:58:09.000000000","message":"hah, yes)","commit_id":"3414ca35be4737815331e0abab9e8bcbcedd9ae8"}],"ironic/common/service.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c2fd0fe5769660a39683d386043c4d0b118029b8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               help\u003d_(\u0027Number of workers for OpenStack Ironic API service. \u0027"},{"line_number":53,"context_line":"                      \u0027The default is equal to the number of CPUs available \u0027"},{"line_number":54,"context_line":"                      \u0027if that can be determined, else a default worker \u0027"},{"line_number":55,"context_line":"                      \u0027count of 1 is returned.\u0027)),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_e899dbd1","line":55,"updated":"2015-09-01 15:09:43.000000000","message":"I tend to think this should be in the api group.","commit_id":"c27b819498b3a42c163b76e3f67e1975fe516c0f"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"43d2f5c2700a2ce4ee14db2bb0c3fdbd8c8611fe","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               help\u003d_(\u0027Number of workers for OpenStack Ironic API service. \u0027"},{"line_number":53,"context_line":"                      \u0027The default is equal to the number of CPUs available \u0027"},{"line_number":54,"context_line":"                      \u0027if that can be determined, else a default worker \u0027"},{"line_number":55,"context_line":"                      \u0027count of 1 is returned.\u0027)),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_48d7a7ed","line":55,"in_reply_to":"da20952f_e899dbd1","updated":"2015-09-01 15:25:50.000000000","message":"sure, I\u0027ll update","commit_id":"c27b819498b3a42c163b76e3f67e1975fe516c0f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c2fd0fe5769660a39683d386043c4d0b118029b8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        self.app \u003d app.VersionSelectorApplication()"},{"line_number":167,"context_line":"        self.port \u003d CONF.api.port"},{"line_number":168,"context_line":"        worker_name \u003d \u0027%s_workers\u0027 % name"},{"line_number":169,"context_line":"        self.workers \u003d (getattr(CONF, worker_name, None) or"},{"line_number":170,"context_line":"                        processutils.get_worker_count())"},{"line_number":171,"context_line":"        if self.workers is not None and self.workers \u003c 1:"},{"line_number":172,"context_line":"            msg \u003d (_(\"%(worker_name)s value of %(workers)d is invalid, \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_ed2fada5","line":169,"updated":"2015-09-01 15:09:43.000000000","message":"I\u0027m not sure there\u0027s any need to parameterize this at the moment, let\u0027s keep it simple.","commit_id":"c27b819498b3a42c163b76e3f67e1975fe516c0f"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"43d2f5c2700a2ce4ee14db2bb0c3fdbd8c8611fe","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        self.app \u003d app.VersionSelectorApplication()"},{"line_number":167,"context_line":"        self.port \u003d CONF.api.port"},{"line_number":168,"context_line":"        worker_name \u003d \u0027%s_workers\u0027 % name"},{"line_number":169,"context_line":"        self.workers \u003d (getattr(CONF, worker_name, None) or"},{"line_number":170,"context_line":"                        processutils.get_worker_count())"},{"line_number":171,"context_line":"        if self.workers is not None and self.workers \u003c 1:"},{"line_number":172,"context_line":"            msg \u003d (_(\"%(worker_name)s value of %(workers)d is invalid, \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_481c87c1","line":169,"in_reply_to":"da20952f_ed2fada5","updated":"2015-09-01 15:25:50.000000000","message":"sure","commit_id":"c27b819498b3a42c163b76e3f67e1975fe516c0f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c2fd0fe5769660a39683d386043c4d0b118029b8","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        worker_name \u003d \u0027%s_workers\u0027 % name"},{"line_number":169,"context_line":"        self.workers \u003d (getattr(CONF, worker_name, None) or"},{"line_number":170,"context_line":"                        processutils.get_worker_count())"},{"line_number":171,"context_line":"        if self.workers is not None and self.workers \u003c 1:"},{"line_number":172,"context_line":"            msg \u003d (_(\"%(worker_name)s value of %(workers)d is invalid, \""},{"line_number":173,"context_line":"                     \"must be greater than 0.\") %"},{"line_number":174,"context_line":"                   {\u0027worker_name\u0027: worker_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_0803ef0e","line":171,"updated":"2015-09-01 15:09:43.000000000","message":"None would also be invalid at this point, right? Maybe `if self.workers is None or self.workers \u003c 1` is better","commit_id":"c27b819498b3a42c163b76e3f67e1975fe516c0f"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"43d2f5c2700a2ce4ee14db2bb0c3fdbd8c8611fe","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        worker_name \u003d \u0027%s_workers\u0027 % name"},{"line_number":169,"context_line":"        self.workers \u003d (getattr(CONF, worker_name, None) or"},{"line_number":170,"context_line":"                        processutils.get_worker_count())"},{"line_number":171,"context_line":"        if self.workers is not None and self.workers \u003c 1:"},{"line_number":172,"context_line":"            msg \u003d (_(\"%(worker_name)s value of %(workers)d is invalid, \""},{"line_number":173,"context_line":"                     \"must be greater than 0.\") %"},{"line_number":174,"context_line":"                   {\u0027worker_name\u0027: worker_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_88d7ffbe","line":171,"in_reply_to":"da20952f_0803ef0e","updated":"2015-09-01 15:25:50.000000000","message":"I\u0027ve changed self.workers, missed this , `if self.workers and self.workers \u003c 1` should be fine since self.workers never equal `None`","commit_id":"c27b819498b3a42c163b76e3f67e1975fe516c0f"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"ea2274bb1558c194dba8ba218b7dd1a0e7e378b4","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.name \u003d name"},{"line_number":160,"context_line":"        self.app \u003d app.VersionSelectorApplication()"},{"line_number":161,"context_line":"        self.workers \u003d (CONF.api.api_workers or"},{"line_number":162,"context_line":"                        processutils.get_worker_count())"},{"line_number":163,"context_line":"        if self.workers and self.workers \u003c 1:"},{"line_number":164,"context_line":"            raise exception.ConfigInvalid("},{"line_number":165,"context_line":"                _(\"api_workers value of %d is invalid, \""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_8f3431fc","line":162,"updated":"2015-10-22 05:49:13.000000000","message":"Interesting, you assign api_workers \u003d processutils.get_worker_count() in config and try to assign it here again, seems redundancy. So what about left  CONF.api.api_workers without default value like Nova?","commit_id":"3414ca35be4737815331e0abab9e8bcbcedd9ae8"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"4952a2467c53245c2d055e3b3a59447308b6f1bf","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.name \u003d name"},{"line_number":160,"context_line":"        self.app \u003d app.VersionSelectorApplication()"},{"line_number":161,"context_line":"        self.workers \u003d (CONF.api.api_workers or"},{"line_number":162,"context_line":"                        processutils.get_worker_count())"},{"line_number":163,"context_line":"        if self.workers and self.workers \u003c 1:"},{"line_number":164,"context_line":"            raise exception.ConfigInvalid("},{"line_number":165,"context_line":"                _(\"api_workers value of %d is invalid, \""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_fb4323ad","line":162,"in_reply_to":"3a29b11f_8f3431fc","updated":"2015-10-22 07:58:09.000000000","message":"Agree, also it depends on platform, so I\u0027ll remove it from config","commit_id":"3414ca35be4737815331e0abab9e8bcbcedd9ae8"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"ab1a29babff971a0062f1e123592dd5df39b58b2","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                _(\"api_workers value of %d is invalid, \""},{"line_number":166,"context_line":"                  \"must be greater than 0.\") % self.workers)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.server \u003d wsgi.Server(CONF, name, self.app,"},{"line_number":169,"context_line":"                                  host\u003dCONF.api.host_ip,"},{"line_number":170,"context_line":"                                  port\u003dCONF.api.port)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_26c18954","line":168,"updated":"2015-10-22 03:37:29.000000000","message":"should add use_ssl support?","commit_id":"3414ca35be4737815331e0abab9e8bcbcedd9ae8"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"4952a2467c53245c2d055e3b3a59447308b6f1bf","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                _(\"api_workers value of %d is invalid, \""},{"line_number":166,"context_line":"                  \"must be greater than 0.\") % self.workers)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.server \u003d wsgi.Server(CONF, name, self.app,"},{"line_number":169,"context_line":"                                  host\u003dCONF.api.host_ip,"},{"line_number":170,"context_line":"                                  port\u003dCONF.api.port)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_fbec83bc","line":168,"in_reply_to":"3a29b11f_26c18954","updated":"2015-10-22 07:58:09.000000000","message":"I\u0027m planning to add ssl, but in separate patch, it\u0027s new functionality","commit_id":"3414ca35be4737815331e0abab9e8bcbcedd9ae8"}],"ironic/tests/unit/common/test_service.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5158ce9fe8a4b8a6d397c4572bae6d6c112b98b7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Resetting pool size to default"},{"line_number":33,"context_line":"        test_service.reset()"},{"line_number":34,"context_line":"        test_service.start()"},{"line_number":35,"context_line":"        self.assertEqual(1000, test_service.server._pool.size)"},{"line_number":36,"context_line":"        self.assertTrue(mock_app.called)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(service.wsgi, \u0027Server\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_4216254d","line":35,"updated":"2015-11-11 09:52:36.000000000","message":"Not sure that we should use this defaults in test, name of file with options in oslo_service started with underscore (\"_options.py\").","commit_id":"4652759acfc8f357e8fde0da68149b75ae9fb6f0"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6564db935cf6d1f27d0b4ecc45bdd2aa95180ad2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Resetting pool size to default"},{"line_number":33,"context_line":"        test_service.reset()"},{"line_number":34,"context_line":"        test_service.start()"},{"line_number":35,"context_line":"        self.assertEqual(1000, test_service.server._pool.size)"},{"line_number":36,"context_line":"        self.assertTrue(mock_app.called)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(service.wsgi, \u0027Server\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_7d0aec7a","line":35,"in_reply_to":"da85f559_3d98e477","updated":"2015-11-11 10:30:41.000000000","message":"Maybe simple assertTrue(test_service.server._pool.size \u003e 0)?","commit_id":"4652759acfc8f357e8fde0da68149b75ae9fb6f0"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"2364df16163c12038c3faa23c0cdf8a5eb9f9359","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Resetting pool size to default"},{"line_number":33,"context_line":"        test_service.reset()"},{"line_number":34,"context_line":"        test_service.start()"},{"line_number":35,"context_line":"        self.assertEqual(1000, test_service.server._pool.size)"},{"line_number":36,"context_line":"        self.assertTrue(mock_app.called)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(service.wsgi, \u0027Server\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_c27bf5f3","line":35,"in_reply_to":"da85f559_4216254d","updated":"2015-11-11 10:11:07.000000000","message":"Not sure I get your point; I don\u0027t use options from _options.py directly, according to WSGIService interface, pool size could be specified while creating service obj,  but also it\u0027s optional, so in case default is used I want to verify it.","commit_id":"4652759acfc8f357e8fde0da68149b75ae9fb6f0"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"75fd77fd68f03a1f0cafe79603bbef59db86c1a2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Resetting pool size to default"},{"line_number":33,"context_line":"        test_service.reset()"},{"line_number":34,"context_line":"        test_service.start()"},{"line_number":35,"context_line":"        self.assertEqual(1000, test_service.server._pool.size)"},{"line_number":36,"context_line":"        self.assertTrue(mock_app.called)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(service.wsgi, \u0027Server\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_3d98e477","line":35,"in_reply_to":"da85f559_5d3a88cd","updated":"2015-11-11 10:26:02.000000000","message":"Yes, I don\u0027t import pool size option from oslo.service, so do you propose add new one in Ironic or don\u0027t test default at all?","commit_id":"4652759acfc8f357e8fde0da68149b75ae9fb6f0"},{"author":{"_account_id":13636,"name":"Anton A","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a51f105d120b68da574a8e444af1a142afcfd19c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Resetting pool size to default"},{"line_number":33,"context_line":"        test_service.reset()"},{"line_number":34,"context_line":"        test_service.start()"},{"line_number":35,"context_line":"        self.assertEqual(1000, test_service.server._pool.size)"},{"line_number":36,"context_line":"        self.assertTrue(mock_app.called)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(service.wsgi, \u0027Server\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_ddb8b777","line":35,"in_reply_to":"da85f559_7d0aec7a","updated":"2015-11-11 11:06:08.000000000","message":"agree, possibly it\u0027s best solution here; thanks for review","commit_id":"4652759acfc8f357e8fde0da68149b75ae9fb6f0"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f2da21944739764ee114adec901beaebef498bd9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # Resetting pool size to default"},{"line_number":33,"context_line":"        test_service.reset()"},{"line_number":34,"context_line":"        test_service.start()"},{"line_number":35,"context_line":"        self.assertEqual(1000, test_service.server._pool.size)"},{"line_number":36,"context_line":"        self.assertTrue(mock_app.called)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @mock.patch.object(service.wsgi, \u0027Server\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da85f559_5d3a88cd","line":35,"in_reply_to":"da85f559_c27bf5f3","updated":"2015-11-11 10:21:48.000000000","message":"AFAIK default defined here: https://github.com/openstack/oslo.service/blob/master/oslo_service/_options.py#L65 ? Looks like better do not import these options, because filename underscored. And use hardcoded value also is not good, this defaults can be changed.","commit_id":"4652759acfc8f357e8fde0da68149b75ae9fb6f0"}]}