)]}'
{"ironic/common/images.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"318e6680d859c9a313dab4d7a8a829c5edbb0c71","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    try:"},{"line_number":523,"context_line":"        iproperties \u003d get_image_properties(ctx, image_source)"},{"line_number":524,"context_line":"    except Exception:"},{"line_number":525,"context_line":"        return"},{"line_number":526,"context_line":"    if iproperties.get(\u0027iso_ramdisk\u0027):"},{"line_number":527,"context_line":"        is_iso_image \u003d True"},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_93208b4b","line":525,"updated":"2015-09-13 17:13:04.000000000","message":"We should make this exception behavior more explicit. Right now it returns None. It should return False to avoid strange behavior in the caller. Also, a log message would be useful here.","commit_id":"c082e918d8a891a850a34a2d6844ddb83d3523eb"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"318e6680d859c9a313dab4d7a8a829c5edbb0c71","unresolved":false,"context_lines":[{"line_number":375,"context_line":"    elif trusted_boot:"},{"line_number":376,"context_line":"        boot_disk_type \u003d \u0027trusted_boot\u0027"},{"line_number":377,"context_line":"    elif is_ramdisk_iso_image:"},{"line_number":378,"context_line":"        boot_disk_type \u003d \u0027boot_winpe\u0027"},{"line_number":379,"context_line":"    else:"},{"line_number":380,"context_line":"        boot_disk_type \u003d \u0027boot_partition\u0027"},{"line_number":381,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_d325a35c","line":378,"updated":"2015-09-13 17:13:04.000000000","message":"I don\u0027t think we should assume that all ISO ramdisks are WinPE.","commit_id":"c082e918d8a891a850a34a2d6844ddb83d3523eb"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6ced6379de60cc8157fbbfc8f73fa8dbed968ba0","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        if isiso:"},{"line_number":693,"context_line":"            pxe_config_path \u003d pxe_utils.get_pxe_config_file_path("},{"line_number":694,"context_line":"                task.node.uuid)"},{"line_number":695,"context_line":"            deploy_utils.switch_pxe_config("},{"line_number":696,"context_line":"                    pxe_config_path, None,"},{"line_number":697,"context_line":"                    deploy_utils.get_boot_mode_for_deploy(node),"},{"line_number":698,"context_line":"                    False, False, isiso)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_83faef75","line":695,"updated":"2015-09-11 12:47:01.000000000","message":"Shouldn\u0027t it be done before reboot?","commit_id":"c082e918d8a891a850a34a2d6844ddb83d3523eb"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"6902cdeba1f7667987d6beea635219b02f39cb94","unresolved":false,"context_lines":[{"line_number":693,"context_line":"            pxe_config_path \u003d pxe_utils.get_pxe_config_file_path("},{"line_number":694,"context_line":"                task.node.uuid)"},{"line_number":695,"context_line":"            deploy_utils.switch_pxe_config("},{"line_number":696,"context_line":"                    pxe_config_path, None,"},{"line_number":697,"context_line":"                    deploy_utils.get_boot_mode_for_deploy(node),"},{"line_number":698,"context_line":"                    False, False, isiso)"},{"line_number":699,"context_line":"            return states.DEPLOYDONE"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_cc09a685","line":696,"updated":"2015-09-07 15:03:03.000000000","message":"continuation line over-indented for hanging indent","commit_id":"c082e918d8a891a850a34a2d6844ddb83d3523eb"}],"ironic/drivers/modules/pxe_config.template":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"318e6680d859c9a313dab4d7a8a829c5edbb0c71","unresolved":false,"context_lines":[{"line_number":19,"context_line":"kernel mboot"},{"line_number":20,"context_line":"append tboot.gz --- {{pxe_options.aki_path}} root\u003d{{ ROOT }} ro text {{ pxe_options.pxe_append_params|default(\"\", true) }} intel_iommu\u003don --- {{pxe_options.ari_path}}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"label boot_winpe"},{"line_number":23,"context_line":"kernel memdisk"},{"line_number":24,"context_line":"append initrd\u003d{{ pxe_options.deployment_ari_path}} iso raw"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba15a1d1_f32a272c","line":22,"updated":"2015-09-13 17:13:04.000000000","message":"I don\u0027t think we should assume that all ISO ramdisks are necessarily WinPE here either, unless that line is necessary for the pxeboot. If it is, perhaps we could templatize it like some of the other items in this file.","commit_id":"c082e918d8a891a850a34a2d6844ddb83d3523eb"}]}
