)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4507cbcd6f32522738d5a6752de9d4f135ce4815","unresolved":false,"context_lines":[{"line_number":11,"context_line":"can be reused for ISCSIDeploy. It also moves the method"},{"line_number":12,"context_line":"agent.build_agent_options to deploy_utils module."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The following CONF options are also renamed:"},{"line_number":15,"context_line":"[agent]agent_erase_devices_priority \u003d\u003e [deploy]erase_devices_priority"},{"line_number":16,"context_line":"[agent]agent_erase_devices_iterations \u003d\u003e [deploy]erase_devices_iterations"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba15a1d1_2dba30c1","line":14,"updated":"2015-09-15 15:39:54.000000000","message":"if you do another revision, maybe be more explicit: s/are also renamed/have been deprecated and moved/renamed/","commit_id":"a678e1463b9cd4de0ee1ddcfe426e177f5abc618"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1d3486fcbc57b57cfa38eed1ecd36a38617a8884","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                if (step.get(\u0027step\u0027) \u003d\u003d \u0027erase_devices\u0027 and"},{"line_number":259,"context_line":"                        step.get(\u0027interface\u0027) \u003d\u003d \u0027deploy\u0027):"},{"line_number":260,"context_line":"                    # Override with operator set priority"},{"line_number":261,"context_line":"                    step[\u0027priority\u0027] \u003d CONF.deploy.erase_devices_priority"},{"line_number":262,"context_line":"        return steps"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def execute_clean_step(self, task, step):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_285d1b79","line":261,"updated":"2015-09-16 10:24:09.000000000","message":"I think this priority override might move to deploy_utils as well, but we anyway refactor this code","commit_id":"a678e1463b9cd4de0ee1ddcfe426e177f5abc618"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"17445ce3dae18582cd94050837ee62362ff03d4c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               default\u003d\u0027/httpboot\u0027,"},{"line_number":75,"context_line":"               help\u003d\u0027ironic-conductor node\\\u0027s HTTP root path.\u0027,"},{"line_number":76,"context_line":"               deprecated_group\u003d\u0027pxe\u0027),"},{"line_number":77,"context_line":"    cfg.IntOpt(\u0027agent_erase_devices_priority\u0027,"},{"line_number":78,"context_line":"               deprecated_name\u003d\u0027agent_erase_devices_priority\u0027,"},{"line_number":79,"context_line":"               deprecated_group\u003d\u0027agent\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027Priority to run in-band erase devices via the Ironic \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_efc43842","line":77,"updated":"2015-09-09 20:24:18.000000000","message":"Do you think we could just call this \u0027erase_devices_priority\u0027 or do you think this will always be specific to the \u0027agent\u0027? And if it is specific to the \u0027agent\u0027, then why move it to [deploy]?","commit_id":"3e006282c7ddf860df8ae89de232bd54051e6373"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"414bbf10197a82cf7b7330ce8d1401195433f570","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               default\u003d\u0027/httpboot\u0027,"},{"line_number":75,"context_line":"               help\u003d\u0027ironic-conductor node\\\u0027s HTTP root path.\u0027,"},{"line_number":76,"context_line":"               deprecated_group\u003d\u0027pxe\u0027),"},{"line_number":77,"context_line":"    cfg.IntOpt(\u0027agent_erase_devices_priority\u0027,"},{"line_number":78,"context_line":"               deprecated_name\u003d\u0027agent_erase_devices_priority\u0027,"},{"line_number":79,"context_line":"               deprecated_group\u003d\u0027agent\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027Priority to run in-band erase devices via the Ironic \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_7928c885","line":77,"in_reply_to":"da20952f_032056f6","updated":"2015-09-10 20:49:39.000000000","message":"Unless we think we will have some other \u0027spy\u0027 that provides erase_devices() clean step and the user will want to set \u0027agent_erase_devices_priority\u0027 different than \u0027spy_erase_devices_priority\u0027, we should use \u0027erase_devices_priority\u0027 for all things that can erase_devices (and regardless of which interface).","commit_id":"3e006282c7ddf860df8ae89de232bd54051e6373"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"584e4c6749516ea4b9d64e4845d01883ea412b38","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               default\u003d\u0027/httpboot\u0027,"},{"line_number":75,"context_line":"               help\u003d\u0027ironic-conductor node\\\u0027s HTTP root path.\u0027,"},{"line_number":76,"context_line":"               deprecated_group\u003d\u0027pxe\u0027),"},{"line_number":77,"context_line":"    cfg.IntOpt(\u0027agent_erase_devices_priority\u0027,"},{"line_number":78,"context_line":"               deprecated_name\u003d\u0027agent_erase_devices_priority\u0027,"},{"line_number":79,"context_line":"               deprecated_group\u003d\u0027agent\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027Priority to run in-band erase devices via the Ironic \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_205fb2e6","line":77,"in_reply_to":"da20952f_7928c885","updated":"2015-09-15 05:12:37.000000000","message":"Done. Will just remove agent prefix.","commit_id":"3e006282c7ddf860df8ae89de232bd54051e6373"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8070b273ddbb962da6e5f9e05923d89afdaf5b16","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               default\u003d\u0027/httpboot\u0027,"},{"line_number":75,"context_line":"               help\u003d\u0027ironic-conductor node\\\u0027s HTTP root path.\u0027,"},{"line_number":76,"context_line":"               deprecated_group\u003d\u0027pxe\u0027),"},{"line_number":77,"context_line":"    cfg.IntOpt(\u0027agent_erase_devices_priority\u0027,"},{"line_number":78,"context_line":"               deprecated_name\u003d\u0027agent_erase_devices_priority\u0027,"},{"line_number":79,"context_line":"               deprecated_group\u003d\u0027agent\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027Priority to run in-band erase devices via the Ironic \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_032056f6","line":77,"in_reply_to":"da20952f_d110f15b","updated":"2015-09-10 08:47:36.000000000","message":"Hi,\n\nThe idea of the spec is being implemented as part of this patch is that cleaning will be applicable for both: iSCSI and agent methodologies, right?\n\nI know that in the spec this option is presented as \"agent_erase_devices_priority\" but I like ruby suggestion about calling it \"erase_device_priority\", that way one won\u0027t associate the cleaning operation with the deployment methodology (whether it\u0027s iSCSI or agent).","commit_id":"3e006282c7ddf860df8ae89de232bd54051e6373"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c9728e3509ffbfdeb2cceed907aff223c5ad0fb2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               default\u003d\u0027/httpboot\u0027,"},{"line_number":75,"context_line":"               help\u003d\u0027ironic-conductor node\\\u0027s HTTP root path.\u0027,"},{"line_number":76,"context_line":"               deprecated_group\u003d\u0027pxe\u0027),"},{"line_number":77,"context_line":"    cfg.IntOpt(\u0027agent_erase_devices_priority\u0027,"},{"line_number":78,"context_line":"               deprecated_name\u003d\u0027agent_erase_devices_priority\u0027,"},{"line_number":79,"context_line":"               deprecated_group\u003d\u0027agent\u0027,"},{"line_number":80,"context_line":"               help\u003d_(\u0027Priority to run in-band erase devices via the Ironic \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_d110f15b","line":77,"in_reply_to":"da20952f_efc43842","updated":"2015-09-10 04:10:31.000000000","message":"For historical reasons, anything in [agent] group is treated as belonging to the agent driver which deploys by agent downloading image from within the bare metal node.  [deploy] is something that is applicable to all deploy drivers.  In that sense, I feel this belongs to [deploy] group since all deploy drivers - iscsi deploy, agent deploy OR \u003csomething else that we may come up in the future\u003e, they all might need in-band cleaning using agent ramdisk.  Since agent is involved here irrespective of deploy mechanism, I thought of keeping the agent prefix. What do you think ?","commit_id":"3e006282c7ddf860df8ae89de232bd54051e6373"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"17445ce3dae18582cd94050837ee62362ff03d4c","unresolved":false,"context_lines":[{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"    This method deletes the cleaning ports currently existing"},{"line_number":1284,"context_line":"    for all the ports of the node and then creates a new one"},{"line_number":1285,"context_line":"    for each one of them.  It also adds the \u0027vif_port_id\u0027 to port.extra"},{"line_number":1286,"context_line":"    of each Ironic port, after creating the cleaning ports."},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"    :param task: a TaskManager object containing the node"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_0fd2cb5b","line":1285,"updated":"2015-09-09 20:24:18.000000000","message":"s/adds the/adds/","commit_id":"3e006282c7ddf860df8ae89de232bd54051e6373"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c9728e3509ffbfdeb2cceed907aff223c5ad0fb2","unresolved":false,"context_lines":[{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"    This method deletes the cleaning ports currently existing"},{"line_number":1284,"context_line":"    for all the ports of the node and then creates a new one"},{"line_number":1285,"context_line":"    for each one of them.  It also adds the \u0027vif_port_id\u0027 to port.extra"},{"line_number":1286,"context_line":"    of each Ironic port, after creating the cleaning ports."},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"    :param task: a TaskManager object containing the node"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_910b592b","line":1285,"in_reply_to":"da20952f_0fd2cb5b","updated":"2015-09-10 04:10:31.000000000","message":"Done","commit_id":"3e006282c7ddf860df8ae89de232bd54051e6373"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ba6a9d9cb2c6aadbb7e1392b03807b33e5a85e8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                      \u0027during cleaning.\u0027)),"},{"line_number":86,"context_line":"    cfg.IntOpt(\u0027erase_devices_iterations\u0027,"},{"line_number":87,"context_line":"               deprecated_name\u003d\u0027agent_erase_devices_iterations\u0027,"},{"line_number":88,"context_line":"               deprecated_group\u003d\u0027agent\u0027,"},{"line_number":89,"context_line":"               default\u003d1,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Number of iterations to be run for erasing devices.\u0027)),"},{"line_number":91,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_1b168da7","line":88,"updated":"2015-09-15 14:01:38.000000000","message":"when are we going to delete these? We should add a comment about it; otherwise we may forget.\n\nI\u0027m not sure how the user will know that these are deprecated and will be deleted later. Is something logged?","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39145fa1c7cb686e185aac694b298891bc93b247","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                      \u0027during cleaning.\u0027)),"},{"line_number":86,"context_line":"    cfg.IntOpt(\u0027erase_devices_iterations\u0027,"},{"line_number":87,"context_line":"               deprecated_name\u003d\u0027agent_erase_devices_iterations\u0027,"},{"line_number":88,"context_line":"               deprecated_group\u003d\u0027agent\u0027,"},{"line_number":89,"context_line":"               default\u003d1,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Number of iterations to be run for erasing devices.\u0027)),"},{"line_number":91,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_9ccb7053","line":88,"in_reply_to":"ba15a1d1_1b168da7","updated":"2015-09-15 14:45:44.000000000","message":"I guess we can\u0027t know this off to log about them because oslo_config doesn\u0027t say if someone used [agent]agent_erase_devices_iterations or [deploy]erase_devices_iterations. Both are treated as CONF.deploy.erase_devices_iterations.  So I can add a comment above to remove this after Mitaka release, may be add a documentation for this.","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"9953cbf1b02b2988c1d494aa945eaffebc26c7ba","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                      \u0027during cleaning.\u0027)),"},{"line_number":86,"context_line":"    cfg.IntOpt(\u0027erase_devices_iterations\u0027,"},{"line_number":87,"context_line":"               deprecated_name\u003d\u0027agent_erase_devices_iterations\u0027,"},{"line_number":88,"context_line":"               deprecated_group\u003d\u0027agent\u0027,"},{"line_number":89,"context_line":"               default\u003d1,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Number of iterations to be run for erasing devices.\u0027)),"},{"line_number":91,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_f2b733f3","line":88,"in_reply_to":"ba15a1d1_52e85f10","updated":"2015-09-15 15:17:12.000000000","message":"Done","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ee845c1b19d319236cb2ef3cd3856e3183c98860","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                      \u0027during cleaning.\u0027)),"},{"line_number":86,"context_line":"    cfg.IntOpt(\u0027erase_devices_iterations\u0027,"},{"line_number":87,"context_line":"               deprecated_name\u003d\u0027agent_erase_devices_iterations\u0027,"},{"line_number":88,"context_line":"               deprecated_group\u003d\u0027agent\u0027,"},{"line_number":89,"context_line":"               default\u003d1,"},{"line_number":90,"context_line":"               help\u003d_(\u0027Number of iterations to be run for erasing devices.\u0027)),"},{"line_number":91,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_52e85f10","line":88,"in_reply_to":"ba15a1d1_9ccb7053","updated":"2015-09-15 15:15:27.000000000","message":"We discussed in IRC today[0]. oslo_config will log that the config is deprecated but won\u0027t log when it will be deleted.\n\nI think it is sufficient to add a comment here so *we* know when to delete, and to add in the commit message that these config options are deprecated and will be deleted in Mitaka.\n\n[0] 2015-09-15T15:02:47, http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2015-09-15.log","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"7851bfd030c17760100a512b8545b19a9821650a","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"    This method deletes the cleaning port created before cleaning"},{"line_number":1328,"context_line":"    was started."},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"    :param task: a TaskManager object containing the node"},{"line_number":1331,"context_line":"    \"\"\""},{"line_number":1332,"context_line":"    # If we created cleaning ports, delete them"},{"line_number":1333,"context_line":"    provider \u003d dhcp_factory.DHCPFactory()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_66cb7054","line":1330,"updated":"2015-09-15 13:32:27.000000000","message":"raises (mentioned in l1335)","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39145fa1c7cb686e185aac694b298891bc93b247","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"    This method deletes the cleaning port created before cleaning"},{"line_number":1328,"context_line":"    was started."},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"    :param task: a TaskManager object containing the node"},{"line_number":1331,"context_line":"    \"\"\""},{"line_number":1332,"context_line":"    # If we created cleaning ports, delete them"},{"line_number":1333,"context_line":"    provider \u003d dhcp_factory.DHCPFactory()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_d9b01ae0","line":1330,"in_reply_to":"ba15a1d1_66cb7054","updated":"2015-09-15 14:45:44.000000000","message":"Done","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ba6a9d9cb2c6aadbb7e1392b03807b33e5a85e8","unresolved":false,"context_lines":[{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"    This method deletes the cleaning ports which were setup as part"},{"line_number":1407,"context_line":"    of cleaning.  If \u0027manage_boot\u0027 parameter is set to true, it also"},{"line_number":1408,"context_line":"    calls the \u0027tear_down_ramdisk\u0027 method of boot interface to clean up"},{"line_number":1409,"context_line":"    the environment that was set for booting agent ramdisk. It also"},{"line_number":1410,"context_line":"    powers off the bare metal node."},{"line_number":1411,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_06e154d0","line":1408,"updated":"2015-09-15 14:01:38.000000000","message":"is that because driver.boot.clean_up_ramdisk() calls that tear_down_ramdisk() method? To be honest, I don\u0027t know that it helps to mention the method that will be called; one can see that from looking at the code.","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39145fa1c7cb686e185aac694b298891bc93b247","unresolved":false,"context_lines":[{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"    This method deletes the cleaning ports which were setup as part"},{"line_number":1407,"context_line":"    of cleaning.  If \u0027manage_boot\u0027 parameter is set to true, it also"},{"line_number":1408,"context_line":"    calls the \u0027tear_down_ramdisk\u0027 method of boot interface to clean up"},{"line_number":1409,"context_line":"    the environment that was set for booting agent ramdisk. It also"},{"line_number":1410,"context_line":"    powers off the bare metal node."},{"line_number":1411,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_39083691","line":1408,"in_reply_to":"ba15a1d1_06e154d0","updated":"2015-09-15 14:45:44.000000000","message":"Done","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ba6a9d9cb2c6aadbb7e1392b03807b33e5a85e8","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"    of cleaning.  If \u0027manage_boot\u0027 parameter is set to true, it also"},{"line_number":1408,"context_line":"    calls the \u0027tear_down_ramdisk\u0027 method of boot interface to clean up"},{"line_number":1409,"context_line":"    the environment that was set for booting agent ramdisk. It also"},{"line_number":1410,"context_line":"    powers off the bare metal node."},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"    :param task: a TaskManager object containing the node"},{"line_number":1413,"context_line":"    :param manage_boot: If this is set to True, this method calls the"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_66e850e3","line":1410,"updated":"2015-09-15 14:01:38.000000000","message":"It isn\u0027t clear whether it powers off the node if manage_boot is True or not, or whether powering off the node has nothing to do with manage_boot. You could reorder this paragraph, eg : This method: 1. powers off the bm node; 2. if manage_boot is True...; 3. deletes the cleaning ports...","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39145fa1c7cb686e185aac694b298891bc93b247","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"    of cleaning.  If \u0027manage_boot\u0027 parameter is set to true, it also"},{"line_number":1408,"context_line":"    calls the \u0027tear_down_ramdisk\u0027 method of boot interface to clean up"},{"line_number":1409,"context_line":"    the environment that was set for booting agent ramdisk. It also"},{"line_number":1410,"context_line":"    powers off the bare metal node."},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"    :param task: a TaskManager object containing the node"},{"line_number":1413,"context_line":"    :param manage_boot: If this is set to True, this method calls the"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_19053279","line":1410,"in_reply_to":"ba15a1d1_66e850e3","updated":"2015-09-15 14:45:44.000000000","message":"Done","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4507cbcd6f32522738d5a6752de9d4f135ce4815","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"def tear_down_inband_cleaning(task, manage_boot\u003dTrue):"},{"line_number":1409,"context_line":"    \"\"\"Tears down the environment setup for in-band cleaning."},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"    This method does the following:"},{"line_number":1412,"context_line":"    1. Deletes the cleaning ports which were setup as part"},{"line_number":1413,"context_line":"    of cleaning."},{"line_number":1414,"context_line":"    2. If \u0027manage_boot\u0027 parameter is set to true, it also"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_cd8374cb","line":1411,"updated":"2015-09-15 15:39:54.000000000","message":"I would reorder the following so they are ordered based on the order done in code.","commit_id":"a678e1463b9cd4de0ee1ddcfe426e177f5abc618"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4507cbcd6f32522738d5a6752de9d4f135ce4815","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"    1. Deletes the cleaning ports which were setup as part"},{"line_number":1413,"context_line":"    of cleaning."},{"line_number":1414,"context_line":"    2. If \u0027manage_boot\u0027 parameter is set to true, it also"},{"line_number":1415,"context_line":"    calls the \u0027tear_down_ramdisk\u0027 method of boot interface to clean up"},{"line_number":1416,"context_line":"    the environment that was set for booting agent ramdisk."},{"line_number":1417,"context_line":"    3. Powers off the bare metal node."},{"line_number":1418,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_4d78c4f2","line":1415,"updated":"2015-09-15 15:39:54.000000000","message":"not sure about this. is it \u0027tear_down_ramdisk\u0027 or \u0027clean_up_ramdisk\u0027?","commit_id":"a678e1463b9cd4de0ee1ddcfe426e177f5abc618"}],"ironic/tests/drivers/test_deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ba6a9d9cb2c6aadbb7e1392b03807b33e5a85e8","unresolved":false,"context_lines":[{"line_number":2029,"context_line":"        self.ports[0].refresh()"},{"line_number":2030,"context_line":"        self.assertEqual(\u0027vif-port-id\u0027, self.ports[0].extra[\u0027vif_port_id\u0027])"},{"line_number":2031,"context_line":""},{"line_number":2032,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":2033,"context_line":"    def test_prepare_inband_cleaning_ports(self, prepare_ramdisk_mock):"},{"line_number":2034,"context_line":"        self._test_prepare_inband_cleaning_ports()"},{"line_number":2035,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_41d736ed","line":2032,"updated":"2015-09-15 14:01:38.000000000","message":"why do you need this mock?","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39145fa1c7cb686e185aac694b298891bc93b247","unresolved":false,"context_lines":[{"line_number":2029,"context_line":"        self.ports[0].refresh()"},{"line_number":2030,"context_line":"        self.assertEqual(\u0027vif-port-id\u0027, self.ports[0].extra[\u0027vif_port_id\u0027])"},{"line_number":2031,"context_line":""},{"line_number":2032,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":2033,"context_line":"    def test_prepare_inband_cleaning_ports(self, prepare_ramdisk_mock):"},{"line_number":2034,"context_line":"        self._test_prepare_inband_cleaning_ports()"},{"line_number":2035,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_797d4eb0","line":2032,"in_reply_to":"ba15a1d1_41d736ed","updated":"2015-09-15 14:45:44.000000000","message":"My mistake. Done.","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ba6a9d9cb2c6aadbb7e1392b03807b33e5a85e8","unresolved":false,"context_lines":[{"line_number":2033,"context_line":"    def test_prepare_inband_cleaning_ports(self, prepare_ramdisk_mock):"},{"line_number":2034,"context_line":"        self._test_prepare_inband_cleaning_ports()"},{"line_number":2035,"context_line":""},{"line_number":2036,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":2037,"context_line":"    def test_prepare_inband_cleaning_ports_no_vif_port_id("},{"line_number":2038,"context_line":"            self, prepare_ramdisk_mock):"},{"line_number":2039,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_e1044a7f","line":2036,"updated":"2015-09-15 14:01:38.000000000","message":"ditto","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39145fa1c7cb686e185aac694b298891bc93b247","unresolved":false,"context_lines":[{"line_number":2033,"context_line":"    def test_prepare_inband_cleaning_ports(self, prepare_ramdisk_mock):"},{"line_number":2034,"context_line":"        self._test_prepare_inband_cleaning_ports()"},{"line_number":2035,"context_line":""},{"line_number":2036,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":2037,"context_line":"    def test_prepare_inband_cleaning_ports_no_vif_port_id("},{"line_number":2038,"context_line":"            self, prepare_ramdisk_mock):"},{"line_number":2039,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_194bf288","line":2036,"in_reply_to":"ba15a1d1_e1044a7f","updated":"2015-09-15 14:45:44.000000000","message":"Done","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ba6a9d9cb2c6aadbb7e1392b03807b33e5a85e8","unresolved":false,"context_lines":[{"line_number":2069,"context_line":"                states.CLEANWAIT,"},{"line_number":2070,"context_line":"                utils.prepare_inband_cleaning(task, manage_boot\u003dmanage_boot))"},{"line_number":2071,"context_line":"            prepare_cleaning_ports_mock.assert_called_once_with(task)"},{"line_number":2072,"context_line":"            power_mock.assert_called_once_with(task, states.REBOOT)"},{"line_number":2073,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":2074,"context_line":"                             \u0027agent_erase_devices_iterations\u0027), 1)"},{"line_number":2075,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_cc5a9d2a","line":2072,"updated":"2015-09-15 14:01:38.000000000","message":"might want to check if build_options_mock was called?","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39145fa1c7cb686e185aac694b298891bc93b247","unresolved":false,"context_lines":[{"line_number":2069,"context_line":"                states.CLEANWAIT,"},{"line_number":2070,"context_line":"                utils.prepare_inband_cleaning(task, manage_boot\u003dmanage_boot))"},{"line_number":2071,"context_line":"            prepare_cleaning_ports_mock.assert_called_once_with(task)"},{"line_number":2072,"context_line":"            power_mock.assert_called_once_with(task, states.REBOOT)"},{"line_number":2073,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":2074,"context_line":"                             \u0027agent_erase_devices_iterations\u0027), 1)"},{"line_number":2075,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_59596a59","line":2072,"in_reply_to":"ba15a1d1_cc5a9d2a","updated":"2015-09-15 14:45:44.000000000","message":"Done","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ba6a9d9cb2c6aadbb7e1392b03807b33e5a85e8","unresolved":false,"context_lines":[{"line_number":2073,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":2074,"context_line":"                             \u0027agent_erase_devices_iterations\u0027), 1)"},{"line_number":2075,"context_line":""},{"line_number":2076,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":2077,"context_line":"    def test_prepare_inband_cleaning(self, prepare_ramdisk_mock):"},{"line_number":2078,"context_line":"        self._test_prepare_inband_cleaning()"},{"line_number":2079,"context_line":"        prepare_ramdisk_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_4cba0d0c","line":2076,"updated":"2015-09-15 14:01:38.000000000","message":"I\u0027m not sure why you mock prepare_ramdisk here, but build_agent_options is mocked in _test_prepare_inband_cleaning.","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"9953cbf1b02b2988c1d494aa945eaffebc26c7ba","unresolved":false,"context_lines":[{"line_number":2073,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":2074,"context_line":"                             \u0027agent_erase_devices_iterations\u0027), 1)"},{"line_number":2075,"context_line":""},{"line_number":2076,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":2077,"context_line":"    def test_prepare_inband_cleaning(self, prepare_ramdisk_mock):"},{"line_number":2078,"context_line":"        self._test_prepare_inband_cleaning()"},{"line_number":2079,"context_line":"        prepare_ramdisk_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_52f29fd3","line":2076,"in_reply_to":"ba15a1d1_120667ce","updated":"2015-09-15 15:17:12.000000000","message":"Yeah, I am just making it simpler. Please look at next patch set.","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39145fa1c7cb686e185aac694b298891bc93b247","unresolved":false,"context_lines":[{"line_number":2073,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":2074,"context_line":"                             \u0027agent_erase_devices_iterations\u0027), 1)"},{"line_number":2075,"context_line":""},{"line_number":2076,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":2077,"context_line":"    def test_prepare_inband_cleaning(self, prepare_ramdisk_mock):"},{"line_number":2078,"context_line":"        self._test_prepare_inband_cleaning()"},{"line_number":2079,"context_line":"        prepare_ramdisk_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_fc5aac29","line":2076,"in_reply_to":"ba15a1d1_4cba0d0c","updated":"2015-09-15 14:45:44.000000000","message":"The assertions on build_agent_options are same regardless of scenario - whether manage_boot is true or false.   But assertion on prepare_ramdisk is different for those two scenarios - for manage_boot\u003dTrue, it is called. For manage_boot\u003dFalse, it is not called.","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ee845c1b19d319236cb2ef3cd3856e3183c98860","unresolved":false,"context_lines":[{"line_number":2073,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":2074,"context_line":"                             \u0027agent_erase_devices_iterations\u0027), 1)"},{"line_number":2075,"context_line":""},{"line_number":2076,"context_line":"    @mock.patch.object(pxe.PXEBoot, \u0027prepare_ramdisk\u0027, autospec\u003dTrue)"},{"line_number":2077,"context_line":"    def test_prepare_inband_cleaning(self, prepare_ramdisk_mock):"},{"line_number":2078,"context_line":"        self._test_prepare_inband_cleaning()"},{"line_number":2079,"context_line":"        prepare_ramdisk_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_120667ce","line":2076,"in_reply_to":"ba15a1d1_fc5aac29","updated":"2015-09-15 15:15:27.000000000","message":"I might be wrong, but the code in utils.prepare_inband_cleaning() only calls build_agent_options() if manage_boot\u003d\u003dTrue.","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ba6a9d9cb2c6aadbb7e1392b03807b33e5a85e8","unresolved":false,"context_lines":[{"line_number":2105,"context_line":"    def test_tear_down_inband_cleaning_manage_boot_false("},{"line_number":2106,"context_line":"            self, power_mock, neutron_mock,"},{"line_number":2107,"context_line":"            clean_up_ramdisk_mock):"},{"line_number":2108,"context_line":"        self.config(group\u003d\u0027agent\u0027, manage_agent_boot\u003dFalse)"},{"line_number":2109,"context_line":"        with task_manager.acquire("},{"line_number":2110,"context_line":"                self.context, self.node[\u0027uuid\u0027], shared\u003dFalse) as task:"},{"line_number":2111,"context_line":"            self.assertIsNone("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_cc861ddb","line":2108,"updated":"2015-09-15 14:01:38.000000000","message":"Do you need this?","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39145fa1c7cb686e185aac694b298891bc93b247","unresolved":false,"context_lines":[{"line_number":2105,"context_line":"    def test_tear_down_inband_cleaning_manage_boot_false("},{"line_number":2106,"context_line":"            self, power_mock, neutron_mock,"},{"line_number":2107,"context_line":"            clean_up_ramdisk_mock):"},{"line_number":2108,"context_line":"        self.config(group\u003d\u0027agent\u0027, manage_agent_boot\u003dFalse)"},{"line_number":2109,"context_line":"        with task_manager.acquire("},{"line_number":2110,"context_line":"                self.context, self.node[\u0027uuid\u0027], shared\u003dFalse) as task:"},{"line_number":2111,"context_line":"            self.assertIsNone("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_3c78248f","line":2108,"in_reply_to":"ba15a1d1_cc861ddb","updated":"2015-09-15 14:45:44.000000000","message":"Done.","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ba6a9d9cb2c6aadbb7e1392b03807b33e5a85e8","unresolved":false,"context_lines":[{"line_number":2111,"context_line":"            self.assertIsNone("},{"line_number":2112,"context_line":"                utils.tear_down_inband_cleaning(task, manage_boot\u003dFalse))"},{"line_number":2113,"context_line":"            power_mock.assert_called_once_with(task, states.POWER_OFF)"},{"line_number":2114,"context_line":"            neutron_mock.assert_called_once_with(mock.ANY, task)"},{"line_number":2115,"context_line":"            self.assertFalse(clean_up_ramdisk_mock.called)"},{"line_number":2116,"context_line":""},{"line_number":2117,"context_line":"    def test_build_agent_options_conf(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_2cc5593b","line":2114,"updated":"2015-09-15 14:01:38.000000000","message":"I\u0027m not sure you should be mocking this. Wouldn\u0027t it be better to mock tear_down_cleaning_ports, similar to above\u0027s test_tear_down_inband_cleaning? It seems like these two tests should follow a similar pattern as other tests, with an internal _test_tear_down_inband_cleaning(.., manage_boot\u003dTrue)","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"39145fa1c7cb686e185aac694b298891bc93b247","unresolved":false,"context_lines":[{"line_number":2111,"context_line":"            self.assertIsNone("},{"line_number":2112,"context_line":"                utils.tear_down_inband_cleaning(task, manage_boot\u003dFalse))"},{"line_number":2113,"context_line":"            power_mock.assert_called_once_with(task, states.POWER_OFF)"},{"line_number":2114,"context_line":"            neutron_mock.assert_called_once_with(mock.ANY, task)"},{"line_number":2115,"context_line":"            self.assertFalse(clean_up_ramdisk_mock.called)"},{"line_number":2116,"context_line":""},{"line_number":2117,"context_line":"    def test_build_agent_options_conf(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_5c6398dc","line":2114,"in_reply_to":"ba15a1d1_2cc5593b","updated":"2015-09-15 14:45:44.000000000","message":"Done","commit_id":"706e310f2f596ad240a98d760c2b8854e549f261"}]}
