)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"870ded0c24d167b348338ccf292bb7c92acfe2d3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The GET /v1/drivers/DDDD/raid/logical_disk_properties retrieves a"},{"line_number":10,"context_line":"description of the properties for logical disks that can be specified"},{"line_number":11,"context_line":"for a node with driver DDD. Since this information doesn\u0027t change"},{"line_number":12,"context_line":"over the lifetime of a conductor, we cache that information at the"},{"line_number":13,"context_line":"API layer."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_e0d5181b","line":11,"updated":"2015-09-10 08:15:23.000000000","message":"super nit: s/DDD/DDDD/ :)","commit_id":"dc61c9604de25263a16aa378e0120a2c13c92610"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0d873cdf80993b60a19d7168c77879495bd277f9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The GET /v1/drivers/DDDD/raid/logical_disk_properties retrieves a"},{"line_number":10,"context_line":"description of the properties for logical disks that can be specified"},{"line_number":11,"context_line":"for a node with driver DDD. Since this information doesn\u0027t change"},{"line_number":12,"context_line":"over the lifetime of a conductor, we cache that information at the"},{"line_number":13,"context_line":"API layer."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_68031477","line":11,"in_reply_to":"da20952f_e0d5181b","updated":"2015-09-10 19:45:50.000000000","message":"that\u0027s what I get for copy/pasting from somewhere else!","commit_id":"dc61c9604de25263a16aa378e0120a2c13c92610"}],"ironic/api/controllers/v1/driver.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"580df0109f1e7623d2f4b50b8e6bd8f6f56107b7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# versions, the API service should be restarted."},{"line_number":48,"context_line":"_VENDOR_METHODS \u003d {}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# RAID (logical disk) configuration information for drivers:"},{"line_number":51,"context_line":"#   key \u003d driver name;"},{"line_number":52,"context_line":"#   value \u003d dictionary of RAID configuration information of that driver:"},{"line_number":53,"context_line":"#             key \u003d property name."}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_cc5614ce","line":50,"updated":"2015-09-10 04:31:02.000000000","message":"I think we need a more common caching layer/infrastructure as we are starting to add more and more caching.  May be that\u0027s a future work.","commit_id":"d1490d12c288af6eec178b82982c8dccd8266d1e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"36f91bcc142a1bed61fbadbebc4252c23fbf8508","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# versions, the API service should be restarted."},{"line_number":48,"context_line":"_VENDOR_METHODS \u003d {}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# RAID (logical disk) configuration information for drivers:"},{"line_number":51,"context_line":"#   key \u003d driver name;"},{"line_number":52,"context_line":"#   value \u003d dictionary of RAID configuration information of that driver:"},{"line_number":53,"context_line":"#             key \u003d property name."}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_4885f0cc","line":50,"in_reply_to":"da20952f_cc5614ce","updated":"2015-09-10 19:45:40.000000000","message":"I thought about it but this stuff is so simplistic, I didn\u0027t know whether it was worth the effort to try to do a more generalized thing.\n\nWhat we have now is easy to maintain and I feel like there are lots of other things we could focus on that could help ironic more.","commit_id":"d1490d12c288af6eec178b82982c8dccd8266d1e"}],"ironic/tests/api/v1/test_drivers.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"69daebc01bf9a228255ac6c96a7c5ba3b7385db3","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        for i in range(3):"},{"line_number":212,"context_line":"            data \u003d self.get_json(path,"},{"line_number":213,"context_line":"                                 headers\u003d{api_base.Version.string: \"1.12\"})"},{"line_number":214,"context_line":"        self.assertEqual(properties, data)"},{"line_number":215,"context_line":"        disk_prop_mock.assert_called_once_with(mock.ANY, self.d1,"},{"line_number":216,"context_line":"                                               topic\u003dmock.ANY)"},{"line_number":217,"context_line":"        self.assertEqual(properties, driver._RAID_PROPERTIES[self.d1])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_acd7204e","line":214,"updated":"2015-09-10 04:28:23.000000000","message":"This should be within the for loop.","commit_id":"d1490d12c288af6eec178b82982c8dccd8266d1e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"36f91bcc142a1bed61fbadbebc4252c23fbf8508","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        for i in range(3):"},{"line_number":212,"context_line":"            data \u003d self.get_json(path,"},{"line_number":213,"context_line":"                                 headers\u003d{api_base.Version.string: \"1.12\"})"},{"line_number":214,"context_line":"        self.assertEqual(properties, data)"},{"line_number":215,"context_line":"        disk_prop_mock.assert_called_once_with(mock.ANY, self.d1,"},{"line_number":216,"context_line":"                                               topic\u003dmock.ANY)"},{"line_number":217,"context_line":"        self.assertEqual(properties, driver._RAID_PROPERTIES[self.d1])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_88f0e867","line":214,"in_reply_to":"da20952f_acd7204e","updated":"2015-09-10 19:45:40.000000000","message":"thx. Although I really did intend to only check the last copy. But it is fine to check each time too :)","commit_id":"d1490d12c288af6eec178b82982c8dccd8266d1e"}]}