)]}'
{"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5f6dad97f9e65ffc26730c7d6b1a14f24e308e0c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    :returns: A method which registers the given method as a post clean"},{"line_number":113,"context_line":"        step hook."},{"line_number":114,"context_line":"    \"\"\""},{"line_number":115,"context_line":"    def decorator(func):"},{"line_number":116,"context_line":"        POST_CLEAN_STEP_HOOKS.setdefault(interface, {})[step] \u003d func"},{"line_number":117,"context_line":"        return func"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_4b56655d","line":115,"updated":"2015-09-15 18:33:55.000000000","message":"Is this used anywhere? How do I know it works?","commit_id":"45e55a09400a09d09b011cf4b825fcbd1d3bf98e"}],"ironic/tests/drivers/test_agent_base_vendor.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"87dacca5dcd16d9220bec04824e0c7c2f1ecd971","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        status_mock.return_value \u003d [command_status]"},{"line_number":731,"context_line":"        hook_mock \u003d mock.MagicMock(spec\u003dtypes.FunctionType, __name__\u003d\u0027foo\u0027)"},{"line_number":732,"context_line":"        get_hook_mock.return_value \u003d hook_mock"},{"line_number":733,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":734,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":735,"context_line":"            self.passthru.continue_cleaning(task)"},{"line_number":736,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_ebb7071f","line":733,"updated":"2015-09-11 10:04:51.000000000","message":"nit - self.node.uuid","commit_id":"3bd526cc3a2ee5f365d95264d5322715c90ab60d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7d9cf6c986949413aad9048e0232246e84b7f9ea","unresolved":false,"context_lines":[{"line_number":730,"context_line":"        status_mock.return_value \u003d [command_status]"},{"line_number":731,"context_line":"        hook_mock \u003d mock.MagicMock(spec\u003dtypes.FunctionType, __name__\u003d\u0027foo\u0027)"},{"line_number":732,"context_line":"        get_hook_mock.return_value \u003d hook_mock"},{"line_number":733,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":734,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":735,"context_line":"            self.passthru.continue_cleaning(task)"},{"line_number":736,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_03b1748f","line":733,"in_reply_to":"da20952f_ebb7071f","updated":"2015-09-14 14:58:48.000000000","message":"Done","commit_id":"3bd526cc3a2ee5f365d95264d5322715c90ab60d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"87dacca5dcd16d9220bec04824e0c7c2f1ecd971","unresolved":false,"context_lines":[{"line_number":742,"context_line":"                       \u0027_notify_conductor_resume_clean\u0027, autospec\u003dTrue)"},{"line_number":743,"context_line":"    @mock.patch.object(agent_base_vendor,"},{"line_number":744,"context_line":"                       \u0027_get_post_clean_step_hook\u0027, autospec\u003dTrue)"},{"line_number":745,"context_line":"    @mock.patch(\u0027ironic.conductor.manager.cleaning_error_handler\u0027,"},{"line_number":746,"context_line":"                autospec\u003dTrue)"},{"line_number":747,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027get_commands_status\u0027,"},{"line_number":748,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_cbba430b","line":745,"updated":"2015-09-11 10:04:51.000000000","message":"nit - mock.patch.object","commit_id":"3bd526cc3a2ee5f365d95264d5322715c90ab60d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7d9cf6c986949413aad9048e0232246e84b7f9ea","unresolved":false,"context_lines":[{"line_number":742,"context_line":"                       \u0027_notify_conductor_resume_clean\u0027, autospec\u003dTrue)"},{"line_number":743,"context_line":"    @mock.patch.object(agent_base_vendor,"},{"line_number":744,"context_line":"                       \u0027_get_post_clean_step_hook\u0027, autospec\u003dTrue)"},{"line_number":745,"context_line":"    @mock.patch(\u0027ironic.conductor.manager.cleaning_error_handler\u0027,"},{"line_number":746,"context_line":"                autospec\u003dTrue)"},{"line_number":747,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027get_commands_status\u0027,"},{"line_number":748,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_436d2c03","line":745,"in_reply_to":"da20952f_cbba430b","updated":"2015-09-14 14:58:48.000000000","message":"Done","commit_id":"3bd526cc3a2ee5f365d95264d5322715c90ab60d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"87dacca5dcd16d9220bec04824e0c7c2f1ecd971","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        hook_mock \u003d mock.MagicMock(spec\u003dtypes.FunctionType, __name__\u003d\u0027foo\u0027)"},{"line_number":764,"context_line":"        hook_mock.side_effect \u003d RuntimeError(\u0027error\u0027)"},{"line_number":765,"context_line":"        get_hook_mock.return_value \u003d hook_mock"},{"line_number":766,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":767,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":768,"context_line":"            self.passthru.continue_cleaning(task)"},{"line_number":769,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_ab3caf93","line":766,"updated":"2015-09-11 10:04:51.000000000","message":"nit - self.node.uuid","commit_id":"3bd526cc3a2ee5f365d95264d5322715c90ab60d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7d9cf6c986949413aad9048e0232246e84b7f9ea","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        hook_mock \u003d mock.MagicMock(spec\u003dtypes.FunctionType, __name__\u003d\u0027foo\u0027)"},{"line_number":764,"context_line":"        hook_mock.side_effect \u003d RuntimeError(\u0027error\u0027)"},{"line_number":765,"context_line":"        get_hook_mock.return_value \u003d hook_mock"},{"line_number":766,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":767,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":768,"context_line":"            self.passthru.continue_cleaning(task)"},{"line_number":769,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_6372b0e7","line":766,"in_reply_to":"da20952f_ab3caf93","updated":"2015-09-14 14:58:48.000000000","message":"Done","commit_id":"3bd526cc3a2ee5f365d95264d5322715c90ab60d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"87dacca5dcd16d9220bec04824e0c7c2f1ecd971","unresolved":false,"context_lines":[{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        return hook_method, hook_dict"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"    @mock.patch.object(agent_base_vendor, \u0027POST_CLEAN_STEP_HOOKS\u0027)"},{"line_number":915,"context_line":"    def test_post_clean_step_hook(self, hook_dict_mock):"},{"line_number":916,"context_line":"        # This unit test makes sure that hook methods are registered"},{"line_number":917,"context_line":"        # properly and entries are made in"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_8bba0be0","line":914,"updated":"2015-09-11 10:04:51.000000000","message":"Might be also worth adding spec_set\u003ddict in mock decorator","commit_id":"3bd526cc3a2ee5f365d95264d5322715c90ab60d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7d9cf6c986949413aad9048e0232246e84b7f9ea","unresolved":false,"context_lines":[{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        return hook_method, hook_dict"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"    @mock.patch.object(agent_base_vendor, \u0027POST_CLEAN_STEP_HOOKS\u0027)"},{"line_number":915,"context_line":"    def test_post_clean_step_hook(self, hook_dict_mock):"},{"line_number":916,"context_line":"        # This unit test makes sure that hook methods are registered"},{"line_number":917,"context_line":"        # properly and entries are made in"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_c3813c91","line":914,"in_reply_to":"da20952f_8bba0be0","updated":"2015-09-14 14:58:48.000000000","message":"Done","commit_id":"3bd526cc3a2ee5f365d95264d5322715c90ab60d"}]}
