)]}'
{"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2565feefc43fe7c7f5daac7f7fe23ec276d948c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"               help\u003d_(\u0027IP address of ironic-conductor node\\\u0027s TFTP server.\u0027)),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027tftp_root\u0027,"},{"line_number":59,"context_line":"               default\u003d\u0027/tftpboot\u0027,"},{"line_number":60,"context_line":"               help\u003d_(\"ironic-conductor node\u0027s TFTP root path. The \""},{"line_number":61,"context_line":"                      \"ironic-conductor\u0027s process must have read/write access \""},{"line_number":62,"context_line":"                      \"to this path\")),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027tftp_master_path\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_f8ce0d59","line":60,"updated":"2015-09-11 00:38:02.000000000","message":"maybe nits, but the original had single quotes, which is what the rest of the help strings have, so I\u0027d prefer if you left this the same.\n\nGuess you changed it so you wouldn\u0027t have to escape the single quote, but that makes it inconsistent with the tftp_server string above too :-(","commit_id":"5722f9d7a7b70e1ad4c449904aef25d815822f17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c0bed4ac1ce269aac031c7b90d979bd6b061b848","unresolved":false,"context_lines":[{"line_number":57,"context_line":"               help\u003d_(\u0027IP address of ironic-conductor node\\\u0027s TFTP server.\u0027)),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027tftp_root\u0027,"},{"line_number":59,"context_line":"               default\u003d\u0027/tftpboot\u0027,"},{"line_number":60,"context_line":"               help\u003d_(\"ironic-conductor node\u0027s TFTP root path. The \""},{"line_number":61,"context_line":"                      \"ironic-conductor\u0027s process must have read/write access \""},{"line_number":62,"context_line":"                      \"to this path\")),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027tftp_master_path\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_1ecd24b7","line":60,"in_reply_to":"da20952f_f8ce0d59","updated":"2015-10-02 20:52:11.000000000","message":"Updated tftp_server to match","commit_id":"5722f9d7a7b70e1ad4c449904aef25d815822f17"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2565feefc43fe7c7f5daac7f7fe23ec276d948c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.StrOpt(\u0027tftp_root\u0027,"},{"line_number":59,"context_line":"               default\u003d\u0027/tftpboot\u0027,"},{"line_number":60,"context_line":"               help\u003d_(\"ironic-conductor node\u0027s TFTP root path. The \""},{"line_number":61,"context_line":"                      \"ironic-conductor\u0027s process must have read/write access \""},{"line_number":62,"context_line":"                      \"to this path\")),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027tftp_master_path\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027/tftpboot/master_images\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_d8ca294f","line":61,"updated":"2015-09-11 00:38:02.000000000","message":"I think of it as \u0027ironic-conductor process\u0027 (because ironic-conductor is a process), so just \u0027ironic-conductor\u0027 works for me, but maybe that isn\u0027t clear to others.","commit_id":"5722f9d7a7b70e1ad4c449904aef25d815822f17"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2565feefc43fe7c7f5daac7f7fe23ec276d948c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               default\u003d\u0027/tftpboot\u0027,"},{"line_number":60,"context_line":"               help\u003d_(\"ironic-conductor node\u0027s TFTP root path. The \""},{"line_number":61,"context_line":"                      \"ironic-conductor\u0027s process must have read/write access \""},{"line_number":62,"context_line":"                      \"to this path\")),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027tftp_master_path\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027/tftpboot/master_images\u0027,"},{"line_number":65,"context_line":"               help\u003d_(\u0027On ironic-conductor node, directory where master TFTP \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_587939fb","line":62,"updated":"2015-09-11 00:38:02.000000000","message":"Should end with a period.\n\nIf we add this string, should we go through all the configs that are directories/files, and indicate whether the conductor needs read and/or read/write access to them? Eg, below, ipxe_boot_script.","commit_id":"5722f9d7a7b70e1ad4c449904aef25d815822f17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"af9758748c982ed233981546a3a92df3396f9427","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               default\u003d\u0027/tftpboot\u0027,"},{"line_number":60,"context_line":"               help\u003d_(\"ironic-conductor node\u0027s TFTP root path. The \""},{"line_number":61,"context_line":"                      \"ironic-conductor\u0027s process must have read/write access \""},{"line_number":62,"context_line":"                      \"to this path\")),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027tftp_master_path\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027/tftpboot/master_images\u0027,"},{"line_number":65,"context_line":"               help\u003d_(\u0027On ironic-conductor node, directory where master TFTP \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_3e1268b5","line":62,"in_reply_to":"9a1a9d01_1eae8498","updated":"2015-10-02 20:57:17.000000000","message":"Also I am not sure which files/directories require write access.","commit_id":"5722f9d7a7b70e1ad4c449904aef25d815822f17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c0bed4ac1ce269aac031c7b90d979bd6b061b848","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               default\u003d\u0027/tftpboot\u0027,"},{"line_number":60,"context_line":"               help\u003d_(\"ironic-conductor node\u0027s TFTP root path. The \""},{"line_number":61,"context_line":"                      \"ironic-conductor\u0027s process must have read/write access \""},{"line_number":62,"context_line":"                      \"to this path\")),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027tftp_master_path\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027/tftpboot/master_images\u0027,"},{"line_number":65,"context_line":"               help\u003d_(\u0027On ironic-conductor node, directory where master TFTP \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_1eae8498","line":62,"in_reply_to":"da20952f_587939fb","updated":"2015-10-02 20:52:11.000000000","message":"Could be a good thing to do. But might be a yak-shaving exercise :)\n\nI think that read access might be a given. read/write is less common and useful to spell out to the operators.","commit_id":"5722f9d7a7b70e1ad4c449904aef25d815822f17"}]}