)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a519ba57cda9da667d400a7f0ade16d0cacc8cdf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Config drive support for whole disk images for iscsi based deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will work for UEFI only or BIOS only images. It will not work"},{"line_number":10,"context_line":"for hybrid images. Hybrid images can boot from BIOS and UEFI boot"},{"line_number":11,"context_line":"mode."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9a0775a147d5bac711b58b4b6cf0135ec68509f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_3e225153","line":10,"updated":"2015-09-28 09:55:25.000000000","message":"It\u0027s not clear for me what the last sentence mean.\n\n\"Hybrid images can boot from BIOS and UEFI boot mode\" therefor what?\n\nTherefor should this patch work for the hybrid image?\n\nIf so, the conclution contradict the previous sentence \"It will not work for hybrid images\".","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Config drive support for whole disk images for iscsi based deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will work for UEFI only or BIOS only images. It will not work"},{"line_number":10,"context_line":"for hybrid images. Hybrid images can boot from BIOS and UEFI boot"},{"line_number":11,"context_line":"mode."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9a0775a147d5bac711b58b4b6cf0135ec68509f7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_4173aa80","line":10,"in_reply_to":"9a1a9d01_3e225153","updated":"2015-10-05 06:49:02.000000000","message":"This patch does not support hybrid images. Have rephrased commit message a bit for clarification.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":17368,"name":"Ashwini Khandarkar","email":"ashu@coolsvap.net","username":"ashu"},"change_message_id":"3c89e1f61bfd9ead4e2a9c84609bf8e134c7b23f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-14 03:44:00 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Config drive support for whole disk images for iscsi based deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will work for UEFI only or BIOS only images. It will not work"},{"line_number":10,"context_line":"for hybrid images; which are capable of boot from BIOS and UEFI"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1af94dfe_ebe74be2","line":7,"updated":"2016-03-16 08:10:12.000000000","message":"commit summary should be 50 chars or less http://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"d1aa354ad9c1874f2947047d287c2892651b4935"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8499e22e91e483d3b809376e342af5e17054fc2d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"NOTE: jenkins tests would fail till corresponding ironic-lib"},{"line_number":14,"context_line":"side changes in I4c517f63d620b5a9de31ecb2d7c209776d5ded48"},{"line_number":15,"context_line":"gets merged."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: I4c517f63d620b5a9de31ecb2d7c209776d5ded48"},{"line_number":18,"context_line":"Partial-Bug: #1493328"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7aa08908_817a76ef","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":12},"updated":"2016-06-13 12:20:35.000000000","message":"Nit: I think you mean merged, released, and then ironic update it\u0027s requirements.txt file to support it.","commit_id":"74b505cbeea9cdf970bfe14401fd0e49c0833b0e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ab576618d313edd846d796adbaf68e19cbe8eae1","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"NOTE: jenkins tests would fail till corresponding ironic-lib"},{"line_number":14,"context_line":"side changes in I4c517f63d620b5a9de31ecb2d7c209776d5ded48"},{"line_number":15,"context_line":"gets merged."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: I4c517f63d620b5a9de31ecb2d7c209776d5ded48"},{"line_number":18,"context_line":"Partial-Bug: #1493328"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7aa08908_a2a7aa4e","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":12},"in_reply_to":"7aa08908_817a76ef","updated":"2016-06-13 14:58:59.000000000","message":"Yes, till then jenkins will fail for this patch.","commit_id":"74b505cbeea9cdf970bfe14401fd0e49c0833b0e"}],"ironic/common/disk_partitioner.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e0dad5cfbc31bc7954c7155d8714be876c94733d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partx\u0027, \u0027-u\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":223,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        label_arg \u003d \u0027LABEL\u003d%s\u0027 % label"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_4f70180b","line":222,"updated":"2015-09-18 19:47:58.000000000","message":"Because file systems on partitions are not mounted yet AFAIK you can use only \u0027partprobe\u0027 here.","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5ca88eaae71bc93cc8c41535e93256dbb46f7deb","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partx\u0027, \u0027-u\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":223,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        label_arg \u003d \u0027LABEL\u003d%s\u0027 % label"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_78e04b29","line":222,"updated":"2015-09-18 15:48:13.000000000","message":"You\u0027re running these commands as root, but some of them are not present in rootwrap config files, please check it and add necessary commands there.","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8cc73fbb4dcb8688fcf21e5f82f131d3b8481487","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partx\u0027, \u0027-u\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":223,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        label_arg \u003d \u0027LABEL\u003d%s\u0027 % label"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_1ecf9bb4","line":222,"in_reply_to":"ba15a1d1_4f70180b","updated":"2015-09-21 11:33:29.000000000","message":"Done","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8cc73fbb4dcb8688fcf21e5f82f131d3b8481487","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partx\u0027, \u0027-u\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":223,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        label_arg \u003d \u0027LABEL\u003d%s\u0027 % label"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_3ed4df45","line":222,"in_reply_to":"ba15a1d1_78e04b29","updated":"2015-09-21 11:33:29.000000000","message":"Yes, I need to update etc/ironic/rootwrap.d/ironic-utils.filters as well. Missed it... Added.","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e0dad5cfbc31bc7954c7155d8714be876c94733d","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                    \u0027-t\u0027, label_arg, check_exit_code\u003d[0],"},{"line_number":228,"context_line":"                                    use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":229,"context_line":"        if isinstance(output, bytes):"},{"line_number":230,"context_line":"            output \u003d output.decode(\"utf-8\")"},{"line_number":231,"context_line":"        return output"},{"line_number":232,"context_line":"    # blkid will exit with 2 if no matching partition found"},{"line_number":233,"context_line":"    except processutils.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_afe9b480","line":230,"updated":"2015-09-18 19:47:58.000000000","message":"Is there a problem with non-unicode output?","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8cc73fbb4dcb8688fcf21e5f82f131d3b8481487","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                                    \u0027-t\u0027, label_arg, check_exit_code\u003d[0],"},{"line_number":228,"context_line":"                                    use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":229,"context_line":"        if isinstance(output, bytes):"},{"line_number":230,"context_line":"            output \u003d output.decode(\"utf-8\")"},{"line_number":231,"context_line":"        return output"},{"line_number":232,"context_line":"    # blkid will exit with 2 if no matching partition found"},{"line_number":233,"context_line":"    except processutils.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_7eba570c","line":230,"in_reply_to":"ba15a1d1_afe9b480","updated":"2015-09-21 11:33:29.000000000","message":"Not sure. For safety reasons did it. If it can be done in non-unicode. I can change it.","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e0dad5cfbc31bc7954c7155d8714be876c94733d","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    lines \u003d [line for line in output.split(\u0027\\n\u0027) if line.strip()]"},{"line_number":249,"context_line":"    for line in lines:"},{"line_number":250,"context_line":"        if \"GPT: present\" in line:"},{"line_number":251,"context_line":"            return True"},{"line_number":252,"context_line":"    return False"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_8aa93e92","line":250,"updated":"2015-09-18 19:47:58.000000000","message":"Splitting is not needed, if \"GPT: present\" in output:","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8cc73fbb4dcb8688fcf21e5f82f131d3b8481487","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    lines \u003d [line for line in output.split(\u0027\\n\u0027) if line.strip()]"},{"line_number":249,"context_line":"    for line in lines:"},{"line_number":250,"context_line":"        if \"GPT: present\" in line:"},{"line_number":251,"context_line":"            return True"},{"line_number":252,"context_line":"    return False"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_3e3b7f9e","line":250,"in_reply_to":"ba15a1d1_8aa93e92","updated":"2015-09-21 11:33:29.000000000","message":"Done","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e0dad5cfbc31bc7954c7155d8714be876c94733d","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    return False"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"def _get_partition_numbers(device):"},{"line_number":275,"context_line":"    \"\"\"Get list of partition numbers on given device."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    :param device: The device path."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_0a61aed2","line":274,"updated":"2015-09-18 19:47:58.000000000","message":"There is fine list_partitions() function, you can extract numbers from returned dict.","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8cc73fbb4dcb8688fcf21e5f82f131d3b8481487","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    return False"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"def _get_partition_numbers(device):"},{"line_number":275,"context_line":"    \"\"\"Get list of partition numbers on given device."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    :param device: The device path."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_d91e1d5f","line":274,"in_reply_to":"ba15a1d1_0a61aed2","updated":"2015-09-21 11:33:29.000000000","message":"Done","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    :param device: The device path."},{"line_number":218,"context_line":"    :param label: Partition label"},{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c6a27a4b","line":219,"updated":"2015-09-28 04:08:32.000000000","message":"Returns the block device file for the partition ?","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    :param device: The device path."},{"line_number":218,"context_line":"    :param label: Partition label"},{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_41964a4d","line":219,"in_reply_to":"9a1a9d01_c6a27a4b","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    :param device: The device path."},{"line_number":218,"context_line":"    :param label: Partition label"},{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":223,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_46e18a99","line":220,"updated":"2015-09-28 04:08:32.000000000","message":"Something wrong with the docstring.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    :param device: The device path."},{"line_number":218,"context_line":"    :param label: Partition label"},{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":223,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_a1ae4696","line":220,"in_reply_to":"9a1a9d01_46e18a99","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":223,"context_line":"    try:"},{"line_number":224,"context_line":"        label_arg \u003d \u0027LABEL\u003d%s\u0027 % label"},{"line_number":225,"context_line":"        output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_86d7a2be","line":222,"updated":"2015-09-28 04:08:32.000000000","message":"Shouldn\u0027t this be also within the try/except block ?","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7ce745b89d63b12fc8f31377012be212161f922d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":223,"context_line":"    try:"},{"line_number":224,"context_line":"        label_arg \u003d \u0027LABEL\u003d%s\u0027 % label"},{"line_number":225,"context_line":"        output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_98cd6d87","line":222,"in_reply_to":"9a1a9d01_86d7a2be","updated":"2015-09-29 16:18:17.000000000","message":"_iscsi_setup_and_handle_errors and iscsi_deploy.continue_deploy catches this so I think there is no need to wrap it.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    :returns: partition if it exists, else None"},{"line_number":220,"context_line":"              existence and its path if it exists."},{"line_number":221,"context_line":"    \"\"\""},{"line_number":222,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":223,"context_line":"    try:"},{"line_number":224,"context_line":"        label_arg \u003d \u0027LABEL\u003d%s\u0027 % label"},{"line_number":225,"context_line":"        output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c1881a25","line":222,"in_reply_to":"9a1a9d01_98cd6d87","updated":"2015-10-05 06:49:02.000000000","message":"Yes. try/catch is not required here.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            output \u003d output.decode(\"utf-8\")"},{"line_number":230,"context_line":"        return output"},{"line_number":231,"context_line":"    # blkid will exit with 2 if no matching partition found"},{"line_number":232,"context_line":"    except processutils.ProcessExecutionError:"},{"line_number":233,"context_line":"        return None"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5a915a98","line":232,"updated":"2015-09-28 04:08:32.000000000","message":"Can we just wrap around the required portion of code around utils.execute() ?","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            output \u003d output.decode(\"utf-8\")"},{"line_number":230,"context_line":"        return output"},{"line_number":231,"context_line":"    # blkid will exit with 2 if no matching partition found"},{"line_number":232,"context_line":"    except processutils.ProcessExecutionError:"},{"line_number":233,"context_line":"        return None"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_619fce50","line":232,"in_reply_to":"9a1a9d01_5a915a98","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        return output"},{"line_number":231,"context_line":"    # blkid will exit with 2 if no matching partition found"},{"line_number":232,"context_line":"    except processutils.ProcessExecutionError:"},{"line_number":233,"context_line":"        return None"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def is_disk_gpt_partitioned(device):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c6d4babe","line":233,"updated":"2015-09-28 04:08:32.000000000","message":"Should this return None ? I think it should raise some form of IronicException to indicate to the caller that it failed.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        return output"},{"line_number":231,"context_line":"    # blkid will exit with 2 if no matching partition found"},{"line_number":232,"context_line":"    except processutils.ProcessExecutionError:"},{"line_number":233,"context_line":"        return None"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def is_disk_gpt_partitioned(device):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_21a9d67b","line":233,"in_reply_to":"9a1a9d01_c6d4babe","updated":"2015-10-05 06:49:02.000000000","message":"No catch block required. If execute returns exit code other than one being specified in check_exit_code, it would throw exception.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    :param device: The device path."},{"line_number":240,"context_line":"    :returns: Boolean. Returns True if disk is GPT partitioned"},{"line_number":241,"context_line":"    \"\"\""},{"line_number":242,"context_line":"    output, err \u003d utils.execute(\u0027gdisk\u0027, \u0027-l\u0027, device, check_exit_code\u003d[0],"},{"line_number":243,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":244,"context_line":"    if isinstance(output, bytes):"},{"line_number":245,"context_line":"        output \u003d output.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_4602ea0c","line":242,"updated":"2015-09-28 04:08:32.000000000","message":"Might need a try/except block around and need coversion to Ironic exception.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    :param device: The device path."},{"line_number":240,"context_line":"    :returns: Boolean. Returns True if disk is GPT partitioned"},{"line_number":241,"context_line":"    \"\"\""},{"line_number":242,"context_line":"    output, err \u003d utils.execute(\u0027gdisk\u0027, \u0027-l\u0027, device, check_exit_code\u003d[0],"},{"line_number":243,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":244,"context_line":"    if isinstance(output, bytes):"},{"line_number":245,"context_line":"        output \u003d output.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_a1eac6aa","line":242,"in_reply_to":"9a1a9d01_4602ea0c","updated":"2015-10-05 06:49:02.000000000","message":"same as explained above. _iscsi_setup_and_handle_errors and iscsi_deploy.continue_deploy catches this so I think there is no need to wrap it","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7ce745b89d63b12fc8f31377012be212161f922d","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        output \u003d output.decode(\"utf-8\")"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    if \"GPT: present\" in output:"},{"line_number":248,"context_line":"            return True"},{"line_number":249,"context_line":"    return False"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_d8e9a5b8","line":248,"updated":"2015-09-29 16:18:17.000000000","message":"indentation seems to be wrong.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        output \u003d output.decode(\"utf-8\")"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    if \"GPT: present\" in output:"},{"line_number":248,"context_line":"            return True"},{"line_number":249,"context_line":"    return False"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_41d2ca01","line":248,"in_reply_to":"9a1a9d01_d8e9a5b8","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    \"\"\"Check and moves backup GPT data structures to end of device"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    :param device: The device path."},{"line_number":256,"context_line":"    :returns: True if the GPT data struct were preset and fixed."},{"line_number":257,"context_line":"    \"\"\""},{"line_number":258,"context_line":"    output, err \u003d utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0],"},{"line_number":259,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_7aff7eaa","line":256,"updated":"2015-09-28 04:08:32.000000000","message":"s/preset/present","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    \"\"\"Check and moves backup GPT data structures to end of device"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    :param device: The device path."},{"line_number":256,"context_line":"    :returns: True if the GPT data struct were preset and fixed."},{"line_number":257,"context_line":"    \"\"\""},{"line_number":258,"context_line":"    output, err \u003d utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0],"},{"line_number":259,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_61cd8e5c","line":256,"in_reply_to":"9a1a9d01_7aff7eaa","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    :param device: The device path."},{"line_number":256,"context_line":"    :returns: True if the GPT data struct were preset and fixed."},{"line_number":257,"context_line":"    \"\"\""},{"line_number":258,"context_line":"    output, err \u003d utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0],"},{"line_number":259,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":260,"context_line":"    if isinstance(err, bytes):"},{"line_number":261,"context_line":"        err \u003d err.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_da7c8a74","line":258,"updated":"2015-09-28 04:08:32.000000000","message":"Might need a try/except block around and need coversion to Ironic exception.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    :param device: The device path."},{"line_number":256,"context_line":"    :returns: True if the GPT data struct were preset and fixed."},{"line_number":257,"context_line":"    \"\"\""},{"line_number":258,"context_line":"    output, err \u003d utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0],"},{"line_number":259,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":260,"context_line":"    if isinstance(err, bytes):"},{"line_number":261,"context_line":"        err \u003d err.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_01dcd210","line":258,"in_reply_to":"9a1a9d01_da7c8a74","updated":"2015-10-05 06:49:02.000000000","message":"Same as explained above.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    search_str \u003d \"fix the GPT to use all of the space\""},{"line_number":264,"context_line":"    if search_str in err:"},{"line_number":265,"context_line":"        utils.execute(\u0027sgdisk\u0027, \u0027-e\u0027, device, check_exit_code\u003d[0],"},{"line_number":266,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":267,"context_line":"        return True"},{"line_number":268,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_ba92f69d","line":265,"updated":"2015-09-28 04:08:32.000000000","message":"Might need a try/except block around and need coversion to Ironic exception.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    search_str \u003d \"fix the GPT to use all of the space\""},{"line_number":264,"context_line":"    if search_str in err:"},{"line_number":265,"context_line":"        utils.execute(\u0027sgdisk\u0027, \u0027-e\u0027, device, check_exit_code\u003d[0],"},{"line_number":266,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":267,"context_line":"        return True"},{"line_number":268,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c1049a7f","line":265,"in_reply_to":"9a1a9d01_ba92f69d","updated":"2015-10-05 06:49:02.000000000","message":"Same as explained above.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    return False"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def create_partition(device, size_mb, gpt\u003dFalse):"},{"line_number":272,"context_line":"    \"\"\"Create GPT based partition for config drive"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    :param device: The device path."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5a1b9a1b","line":271,"updated":"2015-09-28 04:08:32.000000000","message":"If this method is specific to config drive, it\u0027s better to name it that way.  Because this seems to create partition at the end of the disk.  Why not something like:\n\n  def create_config_drive_partition","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    return False"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def create_partition(device, size_mb, gpt\u003dFalse):"},{"line_number":272,"context_line":"    \"\"\"Create GPT based partition for config drive"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    :param device: The device path."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_81fea269","line":271,"in_reply_to":"9a1a9d01_5a1b9a1b","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def create_partition(device, size_mb, gpt\u003dFalse):"},{"line_number":272,"context_line":"    \"\"\"Create GPT based partition for config drive"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    :param device: The device path."},{"line_number":275,"context_line":"    :param size_mb: Size of disk in MB"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5ae87a10","line":272,"updated":"2015-09-28 04:08:32.000000000","message":"Can it create both gpt and mbr partitions - seeing the gpt argument","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def create_partition(device, size_mb, gpt\u003dFalse):"},{"line_number":272,"context_line":"    \"\"\"Create GPT based partition for config drive"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    :param device: The device path."},{"line_number":275,"context_line":"    :param size_mb: Size of disk in MB"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_41f96a7f","line":272,"in_reply_to":"9a1a9d01_5ae87a10","updated":"2015-10-05 06:49:02.000000000","message":"Yes.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    :param gpt: True if gpt based partition to be created"},{"line_number":277,"context_line":"    :returns: device path of the partition"},{"line_number":278,"context_line":"    \"\"\""},{"line_number":279,"context_line":"    current_parts \u003d [part[\u0027number\u0027] for part in list_partitions(device)]"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    if gpt:"},{"line_number":282,"context_line":"        create_option \u003d \u00270:-%dMB:0\u0027 % size_mb"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_9ac5b28f","line":279,"updated":"2015-09-28 04:08:32.000000000","message":"nit:\n\n  current_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    :param gpt: True if gpt based partition to be created"},{"line_number":277,"context_line":"    :returns: device path of the partition"},{"line_number":278,"context_line":"    \"\"\""},{"line_number":279,"context_line":"    current_parts \u003d [part[\u0027number\u0027] for part in list_partitions(device)]"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    if gpt:"},{"line_number":282,"context_line":"        create_option \u003d \u00270:-%dMB:0\u0027 % size_mb"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_e4668c28","line":279,"in_reply_to":"9a1a9d01_9ac5b28f","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                      check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":285,"context_line":"    else:"},{"line_number":286,"context_line":"        size_mb \u003d \u0027-%dMiB\u0027 % size_mb"},{"line_number":287,"context_line":"        utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":288,"context_line":"                      \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, size_mb, \u0027-0\u0027,"},{"line_number":289,"context_line":"                      check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_7a68de87","line":287,"updated":"2015-09-28 04:08:32.000000000","message":"Might need a try/except block around and need coversion to Ironic exception.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                      check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":285,"context_line":"    else:"},{"line_number":286,"context_line":"        size_mb \u003d \u0027-%dMiB\u0027 % size_mb"},{"line_number":287,"context_line":"        utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":288,"context_line":"                      \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, size_mb, \u0027-0\u0027,"},{"line_number":289,"context_line":"                      check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c4634819","line":287,"in_reply_to":"9a1a9d01_7a68de87","updated":"2015-10-05 06:49:02.000000000","message":"Same as explained above.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                      \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, size_mb, \u0027-0\u0027,"},{"line_number":289,"context_line":"                      check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    updated_parts \u003d [part[\u0027number\u0027] for part in list_partitions(device)]"},{"line_number":292,"context_line":"    new_part \u003d list(set(updated_parts) - set(current_parts))"},{"line_number":293,"context_line":"    return \u0027%s-part%s\u0027 % (device, new_part[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_da580afd","line":291,"updated":"2015-09-28 04:08:32.000000000","message":"nit:\n\n  updated_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                      \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, size_mb, \u0027-0\u0027,"},{"line_number":289,"context_line":"                      check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    updated_parts \u003d [part[\u0027number\u0027] for part in list_partitions(device)]"},{"line_number":292,"context_line":"    new_part \u003d list(set(updated_parts) - set(current_parts))"},{"line_number":293,"context_line":"    return \u0027%s-part%s\u0027 % (device, new_part[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_846d5006","line":291,"in_reply_to":"9a1a9d01_da580afd","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    updated_parts \u003d [part[\u0027number\u0027] for part in list_partitions(device)]"},{"line_number":292,"context_line":"    new_part \u003d list(set(updated_parts) - set(current_parts))"},{"line_number":293,"context_line":"    return \u0027%s-part%s\u0027 % (device, new_part[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_3a0906de","line":293,"updated":"2015-09-28 04:08:32.000000000","message":"This might cause IndexError if the new partition didn\u0027t get reflected because of some reason. Might need to check that.  I think we can check if there is exactly one change.\n\n  new_part \u003d updated_parts - current_parts\n  if len(new_part) !\u003d 1:\n    \u003cerror\u003e\n  return \u0027%s-part%s\u0027 % (device, new_part.pop())","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    updated_parts \u003d [part[\u0027number\u0027] for part in list_partitions(device)]"},{"line_number":292,"context_line":"    new_part \u003d list(set(updated_parts) - set(current_parts))"},{"line_number":293,"context_line":"    return \u0027%s-part%s\u0027 % (device, new_part[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_4fde716e","line":293,"in_reply_to":"9a1a9d01_3a0906de","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6fad9e308386b79937441f729b0cdbf231ae56b5","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    if \"GPT: present\" in output:"},{"line_number":262,"context_line":"        return True"},{"line_number":263,"context_line":"    return False"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def fix_gpt_structs(device):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_644bb42c","line":263,"updated":"2015-10-13 11:26:02.000000000","message":"nit:\n\nreturn \"GPT: present\" in output","commit_id":"4ebb2d5216d2838c928b3d61dda99e37f905a90c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"409907117bc1b2e27184082de6aa1aae5b6b97eb","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    if \"GPT: present\" in output:"},{"line_number":262,"context_line":"        return True"},{"line_number":263,"context_line":"    return False"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def fix_gpt_structs(device):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_ed2480b0","line":263,"in_reply_to":"5a2ca52d_644bb42c","updated":"2015-10-13 14:20:25.000000000","message":"Done","commit_id":"4ebb2d5216d2838c928b3d61dda99e37f905a90c"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8499e22e91e483d3b809376e342af5e17054fc2d","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            if no_proxy is not None:"},{"line_number":461,"context_line":"                image_info[\u0027no_proxy\u0027] \u003d no_proxy"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        image_info[\u0027node_uuid\u0027] \u003d node.uuid"},{"line_number":464,"context_line":"        iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":465,"context_line":"        if not iwdi:"},{"line_number":466,"context_line":"            for label in PARTITION_IMAGE_LABELS:"}],"source_content_type":"text/x-python","patch_set":17,"id":"7aa08908_f3099185","line":463,"updated":"2016-06-13 12:20:35.000000000","message":"What is this attempting to achieve?","commit_id":"74b505cbeea9cdf970bfe14401fd0e49c0833b0e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e80ba9521e8565ba730e9e6332231909e3ebba3a","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            if no_proxy is not None:"},{"line_number":461,"context_line":"                image_info[\u0027no_proxy\u0027] \u003d no_proxy"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        image_info[\u0027node_uuid\u0027] \u003d node.uuid"},{"line_number":464,"context_line":"        iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":465,"context_line":"        if not iwdi:"},{"line_number":466,"context_line":"            for label in PARTITION_IMAGE_LABELS:"}],"source_content_type":"text/x-python","patch_set":17,"id":"dada55a8_db3c8ac1","line":463,"in_reply_to":"7aa08908_c552c012","updated":"2016-07-25 18:43:59.000000000","message":"That makes more sense, thank you.","commit_id":"74b505cbeea9cdf970bfe14401fd0e49c0833b0e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ab576618d313edd846d796adbaf68e19cbe8eae1","unresolved":false,"context_lines":[{"line_number":460,"context_line":"            if no_proxy is not None:"},{"line_number":461,"context_line":"                image_info[\u0027no_proxy\u0027] \u003d no_proxy"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        image_info[\u0027node_uuid\u0027] \u003d node.uuid"},{"line_number":464,"context_line":"        iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":465,"context_line":"        if not iwdi:"},{"line_number":466,"context_line":"            for label in PARTITION_IMAGE_LABELS:"}],"source_content_type":"text/x-python","patch_set":17,"id":"7aa08908_c552c012","line":463,"in_reply_to":"7aa08908_f3099185","updated":"2016-06-13 14:58:59.000000000","message":"This is required for IPA patch (https://review.openstack.org/#/c/296466/4/ironic_python_agent/extensions/standby.py) wherein config drive creation would be done using comon code in ironic-lib (https://review.openstack.org/#/c/230924/)","commit_id":"74b505cbeea9cdf970bfe14401fd0e49c0833b0e"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e0dad5cfbc31bc7954c7155d8714be876c94733d","unresolved":false,"context_lines":[{"line_number":767,"context_line":"        try:"},{"line_number":768,"context_line":"            # If requested, get the configdrive file and determine the size"},{"line_number":769,"context_line":"            # of the configdrive partition"},{"line_number":770,"context_line":"            confdrive_mb \u003d 0"},{"line_number":771,"context_line":"            confdrive_file \u003d None"},{"line_number":772,"context_line":"            if configdrive:"},{"line_number":773,"context_line":"                confdrive_mb, confdrive_file \u003d _get_configdrive(configdrive,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_8ff15003","line":770,"updated":"2015-09-18 19:47:58.000000000","message":"This line is not needed.","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8cc73fbb4dcb8688fcf21e5f82f131d3b8481487","unresolved":false,"context_lines":[{"line_number":767,"context_line":"        try:"},{"line_number":768,"context_line":"            # If requested, get the configdrive file and determine the size"},{"line_number":769,"context_line":"            # of the configdrive partition"},{"line_number":770,"context_line":"            confdrive_mb \u003d 0"},{"line_number":771,"context_line":"            confdrive_file \u003d None"},{"line_number":772,"context_line":"            if configdrive:"},{"line_number":773,"context_line":"                confdrive_mb, confdrive_file \u003d _get_configdrive(configdrive,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_3e629fae","line":770,"in_reply_to":"ba15a1d1_8ff15003","updated":"2015-09-21 11:33:29.000000000","message":"Done","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5ca88eaae71bc93cc8c41535e93256dbb46f7deb","unresolved":false,"context_lines":[{"line_number":772,"context_line":"            if configdrive:"},{"line_number":773,"context_line":"                confdrive_mb, confdrive_file \u003d _get_configdrive(configdrive,"},{"line_number":774,"context_line":"                                                                node_uuid)"},{"line_number":775,"context_line":"                LOG.debug(\"Add config drive partition (%(size)d MB) to device:\""},{"line_number":776,"context_line":"                          \" %(dev)s for node %(node)s\","},{"line_number":777,"context_line":"                          {\u0027dev\u0027: dev, \u0027size\u0027: confdrive_mb,"},{"line_number":778,"context_line":"                           \u0027node\u0027: node_uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_8d6ba31d","line":775,"updated":"2015-09-18 15:48:13.000000000","message":"nit - MiB","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8cc73fbb4dcb8688fcf21e5f82f131d3b8481487","unresolved":false,"context_lines":[{"line_number":772,"context_line":"            if configdrive:"},{"line_number":773,"context_line":"                confdrive_mb, confdrive_file \u003d _get_configdrive(configdrive,"},{"line_number":774,"context_line":"                                                                node_uuid)"},{"line_number":775,"context_line":"                LOG.debug(\"Add config drive partition (%(size)d MB) to device:\""},{"line_number":776,"context_line":"                          \" %(dev)s for node %(node)s\","},{"line_number":777,"context_line":"                          {\u0027dev\u0027: dev, \u0027size\u0027: confdrive_mb,"},{"line_number":778,"context_line":"                           \u0027node\u0027: node_uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_de5603ce","line":775,"in_reply_to":"ba15a1d1_8d6ba31d","updated":"2015-09-21 11:33:29.000000000","message":"Done","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5ca88eaae71bc93cc8c41535e93256dbb46f7deb","unresolved":false,"context_lines":[{"line_number":791,"context_line":"                                                             confdrive_mb,"},{"line_number":792,"context_line":"                                                             gpt\u003dis_gpt)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"                utils.dd(confdrive_file, part, \u0027bs\u003d64K\u0027, \u0027oflag\u003ddirect\u0027)"},{"line_number":795,"context_line":"                LOG.info(_LI(\"Configdrive for node %(node)s successfully \""},{"line_number":796,"context_line":"                             \"copied onto partition %(part)s\"),"},{"line_number":797,"context_line":"                         {\u0027node\u0027: node_uuid, \u0027part\u0027: part})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_b81ee35c","line":794,"updated":"2015-09-18 15:48:13.000000000","message":"In case of partition image dd from this module is used, maybe instead add optional block size parameter to instead of using utils.dd (and change block size for partition image deployment to be consistent)?","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8cc73fbb4dcb8688fcf21e5f82f131d3b8481487","unresolved":false,"context_lines":[{"line_number":791,"context_line":"                                                             confdrive_mb,"},{"line_number":792,"context_line":"                                                             gpt\u003dis_gpt)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"                utils.dd(confdrive_file, part, \u0027bs\u003d64K\u0027, \u0027oflag\u003ddirect\u0027)"},{"line_number":795,"context_line":"                LOG.info(_LI(\"Configdrive for node %(node)s successfully \""},{"line_number":796,"context_line":"                             \"copied onto partition %(part)s\"),"},{"line_number":797,"context_line":"                         {\u0027node\u0027: node_uuid, \u0027part\u0027: part})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_1e047bc4","line":794,"in_reply_to":"ba15a1d1_b81ee35c","updated":"2015-09-21 11:33:29.000000000","message":"Using dd from this module should be fine as minimum config drive size would be 1MiB","commit_id":"672501b6b8e31c847070abd2aa077a39380062f9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6fad9e308386b79937441f729b0cdbf231ae56b5","unresolved":false,"context_lines":[{"line_number":833,"context_line":"                else:"},{"line_number":834,"context_line":"                    is_gpt \u003d disk_partitioner.is_disk_gpt_partitioned(dev)"},{"line_number":835,"context_line":"                    if is_gpt:"},{"line_number":836,"context_line":"                        disk_partitioner.fix_gpt_structs(dev)"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"                    part \u003d disk_partitioner.create_config_drive_partition("},{"line_number":839,"context_line":"                        dev, confdrive_mb, gpt\u003dis_gpt)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_c4eba8af","line":836,"updated":"2015-10-13 11:26:02.000000000","message":"Shouldn\u0027t we check for the return code of this? Whether it has been fixed correctly or not?\n\nAlso as a suggestion, what about putting this logic inside the create_config_drive_partition() function, that would make it easier to use right? \n\nOtherwise, say we need to use this function again in another place, we would need to copy the conditionals above to make it work with GPT correct?","commit_id":"4ebb2d5216d2838c928b3d61dda99e37f905a90c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"409907117bc1b2e27184082de6aa1aae5b6b97eb","unresolved":false,"context_lines":[{"line_number":833,"context_line":"                else:"},{"line_number":834,"context_line":"                    is_gpt \u003d disk_partitioner.is_disk_gpt_partitioned(dev)"},{"line_number":835,"context_line":"                    if is_gpt:"},{"line_number":836,"context_line":"                        disk_partitioner.fix_gpt_structs(dev)"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"                    part \u003d disk_partitioner.create_config_drive_partition("},{"line_number":839,"context_line":"                        dev, confdrive_mb, gpt\u003dis_gpt)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_32a099f4","line":836,"in_reply_to":"5a2ca52d_c4eba8af","updated":"2015-10-13 14:20:25.000000000","message":"Done","commit_id":"4ebb2d5216d2838c928b3d61dda99e37f905a90c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"05a8a8a3f01735930acac3ddd8da89ba43c8da76","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    \u0027trusted_boot\u0027: (\u0027true\u0027, \u0027false\u0027),"},{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"CONFDRIVE_LABEL \u003d \"config-2\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# All functions are called from deploy() directly or indirectly."}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_7256772b","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":15},"updated":"2015-12-21 07:32:21.000000000","message":"this seems useless now, as you already moved the function to ironic-lib.","commit_id":"fc42d37718c683dfe45a45c610a13563df913bbd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"280fba07d6b9b1a1dfd9318e7449c880e2e033f3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    \u0027trusted_boot\u0027: (\u0027true\u0027, \u0027false\u0027),"},{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"CONFDRIVE_LABEL \u003d \"config-2\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# All functions are called from deploy() directly or indirectly."}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_6de3fca4","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":15},"in_reply_to":"3a7e1126_7256772b","updated":"2015-12-21 08:17:00.000000000","message":"Done","commit_id":"fc42d37718c683dfe45a45c610a13563df913bbd"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3503da3ecd17bdabdbaddd450a4ffd2f1e438e29","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        disk_identifier \u003d disk_utils.get_disk_identifier(dev)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        if configdrive:"},{"line_number":357,"context_line":"                disk_utils.create_config_drive_partition(node_uuid, dev,"},{"line_number":358,"context_line":"                                                         configdrive)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    return {\u0027disk identifier\u0027: disk_identifier}"}],"source_content_type":"text/x-python","patch_set":18,"id":"3ac371cc_92bc87dd","line":357,"updated":"2016-08-17 12:42:02.000000000","message":"overindent","commit_id":"804fd1afced5a76ed546e1fc05833b040c7c6d02"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9006b36d3b004ecdd463b73fca1d88fd31eb1c","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        disk_identifier \u003d disk_utils.get_disk_identifier(dev)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        if configdrive:"},{"line_number":357,"context_line":"                disk_utils.create_config_drive_partition(node_uuid, dev,"},{"line_number":358,"context_line":"                                                         configdrive)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    return {\u0027disk identifier\u0027: disk_identifier}"}],"source_content_type":"text/x-python","patch_set":18,"id":"3ac371cc_37b4777e","line":357,"in_reply_to":"3ac371cc_92bc87dd","updated":"2016-08-18 05:25:31.000000000","message":"Done","commit_id":"804fd1afced5a76ed546e1fc05833b040c7c6d02"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"05a8a8a3f01735930acac3ddd8da89ba43c8da76","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            _(\"Parameters %s were not passed to ironic\""},{"line_number":325,"context_line":"              \" for deploy.\") % missing)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    # configdrive are nullable"},{"line_number":328,"context_line":"    params[\u0027configdrive\u0027] \u003d i_info.get(\u0027configdrive\u0027)"},{"line_number":329,"context_line":"    if is_whole_disk_image:"},{"line_number":330,"context_line":"        return params"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_6f045417","line":327,"range":{"start_line":327,"start_character":18,"end_line":327,"end_character":21},"updated":"2015-12-21 07:32:21.000000000","message":"nit:　s/are/is.","commit_id":"fc42d37718c683dfe45a45c610a13563df913bbd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"280fba07d6b9b1a1dfd9318e7449c880e2e033f3","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            _(\"Parameters %s were not passed to ironic\""},{"line_number":325,"context_line":"              \" for deploy.\") % missing)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    # configdrive are nullable"},{"line_number":328,"context_line":"    params[\u0027configdrive\u0027] \u003d i_info.get(\u0027configdrive\u0027)"},{"line_number":329,"context_line":"    if is_whole_disk_image:"},{"line_number":330,"context_line":"        return params"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_4d9c000f","line":327,"range":{"start_line":327,"start_character":18,"end_line":327,"end_character":21},"in_reply_to":"3a7e1126_6f045417","updated":"2015-12-21 08:17:00.000000000","message":"Done","commit_id":"fc42d37718c683dfe45a45c610a13563df913bbd"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"05a8a8a3f01735930acac3ddd8da89ba43c8da76","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    if is_whole_disk_image:"},{"line_number":330,"context_line":"        return params"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    # ephemeral_format are nullable"},{"line_number":333,"context_line":"    params[\u0027ephemeral_format\u0027] \u003d i_info.get(\u0027ephemeral_format\u0027)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    return params"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_8f018008","line":332,"range":{"start_line":332,"start_character":23,"end_line":332,"end_character":26},"updated":"2015-12-21 07:32:21.000000000","message":"ditto.","commit_id":"fc42d37718c683dfe45a45c610a13563df913bbd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"280fba07d6b9b1a1dfd9318e7449c880e2e033f3","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    if is_whole_disk_image:"},{"line_number":330,"context_line":"        return params"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    # ephemeral_format are nullable"},{"line_number":333,"context_line":"    params[\u0027ephemeral_format\u0027] \u003d i_info.get(\u0027ephemeral_format\u0027)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    return params"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_ed9ccc0f","line":332,"range":{"start_line":332,"start_character":23,"end_line":332,"end_character":26},"in_reply_to":"3a7e1126_8f018008","updated":"2015-12-21 08:17:00.000000000","message":"Done","commit_id":"fc42d37718c683dfe45a45c610a13563df913bbd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"55f5a9dff43d566f3a042b9e139f39d785797012","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            _(\"Parameters %s were not passed to ironic\""},{"line_number":184,"context_line":"              \" for deploy.\") % missing)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    # configdrive is nullable"},{"line_number":187,"context_line":"    params[\u0027configdrive\u0027] \u003d i_info.get(\u0027configdrive\u0027)"},{"line_number":188,"context_line":"    if is_whole_disk_image:"},{"line_number":189,"context_line":"        return params"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_018d81d5","line":186,"updated":"2016-09-16 22:52:39.000000000","message":"NIT:\n\nI don\u0027t think this comment is correct. I think that below when it said nullable, it meant that it could not be set at all.\n\nSo if it is_whole_disk_image, then ephermal_format is not set at all.","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1130658d98c65ed9cb6c63f80a026dd611c9ee70","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            _(\"Parameters %s were not passed to ironic\""},{"line_number":184,"context_line":"              \" for deploy.\") % missing)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    # configdrive is nullable"},{"line_number":187,"context_line":"    params[\u0027configdrive\u0027] \u003d i_info.get(\u0027configdrive\u0027)"},{"line_number":188,"context_line":"    if is_whole_disk_image:"},{"line_number":189,"context_line":"        return params"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_b26c1d09","line":186,"in_reply_to":"7a8ec9b2_018d81d5","updated":"2016-09-19 05:54:34.000000000","message":"I did not get this comment. It is not required to pass config drive with the deploy irrespective of image type (partition or whole disk image) and hence its nullable.","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"}],"ironic/tests/common/test_disk_partitioner.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7ce745b89d63b12fc8f31377012be212161f922d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        execute_mock.return_value \u003d (gdisk_output, \u0027\u0027)"},{"line_number":263,"context_line":"        result \u003d disk_partitioner.is_disk_gpt_partitioned(\u0027/dev/fake\u0027)"},{"line_number":264,"context_line":"        self.assertTrue(result)"},{"line_number":265,"context_line":"        execute_mock.assert_called_with(\u0027gdisk\u0027, \u0027-l\u0027, \u0027/dev/fake\u0027,"},{"line_number":266,"context_line":"                                        check_exit_code\u003d[0],"},{"line_number":267,"context_line":"                                        use_standard_locale\u003dTrue,"},{"line_number":268,"context_line":"                                        run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_4c6abab4","line":265,"updated":"2015-09-29 16:18:17.000000000","message":"nit - assert_called_once_with","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        execute_mock.return_value \u003d (gdisk_output, \u0027\u0027)"},{"line_number":263,"context_line":"        result \u003d disk_partitioner.is_disk_gpt_partitioned(\u0027/dev/fake\u0027)"},{"line_number":264,"context_line":"        self.assertTrue(result)"},{"line_number":265,"context_line":"        execute_mock.assert_called_with(\u0027gdisk\u0027, \u0027-l\u0027, \u0027/dev/fake\u0027,"},{"line_number":266,"context_line":"                                        check_exit_code\u003d[0],"},{"line_number":267,"context_line":"                                        use_standard_locale\u003dTrue,"},{"line_number":268,"context_line":"                                        run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_a112c607","line":265,"in_reply_to":"9a1a9d01_4c6abab4","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7ce745b89d63b12fc8f31377012be212161f922d","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        execute_mock.return_value \u003d (gdisk_output, \u0027\u0027)"},{"line_number":300,"context_line":"        result \u003d disk_partitioner.is_disk_gpt_partitioned(\u0027/dev/fake\u0027)"},{"line_number":301,"context_line":"        self.assertFalse(result)"},{"line_number":302,"context_line":"        execute_mock.assert_called_with(\u0027gdisk\u0027, \u0027-l\u0027, \u0027/dev/fake\u0027,"},{"line_number":303,"context_line":"                                        check_exit_code\u003d[0],"},{"line_number":304,"context_line":"                                        use_standard_locale\u003dTrue,"},{"line_number":305,"context_line":"                                        run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_cc832a55","line":302,"updated":"2015-09-29 16:18:17.000000000","message":"ditto","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        execute_mock.return_value \u003d (gdisk_output, \u0027\u0027)"},{"line_number":300,"context_line":"        result \u003d disk_partitioner.is_disk_gpt_partitioned(\u0027/dev/fake\u0027)"},{"line_number":301,"context_line":"        self.assertFalse(result)"},{"line_number":302,"context_line":"        execute_mock.assert_called_with(\u0027gdisk\u0027, \u0027-l\u0027, \u0027/dev/fake\u0027,"},{"line_number":303,"context_line":"                                        check_exit_code\u003d[0],"},{"line_number":304,"context_line":"                                        use_standard_locale\u003dTrue,"},{"line_number":305,"context_line":"                                        run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_61f58ec9","line":302,"in_reply_to":"9a1a9d01_cc832a55","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7ce745b89d63b12fc8f31377012be212161f922d","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                      use_standard_locale\u003dTrue, run_as_root\u003dTrue)]"},{"line_number":335,"context_line":"        result \u003d disk_partitioner.fix_gpt_structs(\u0027/dev/fake\u0027)"},{"line_number":336,"context_line":"        self.assertFalse(result)"},{"line_number":337,"context_line":"        self.assertListEqual(execute_mock.call_args_list, execute_calls)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    @mock.patch.object(disk_partitioner, \u0027list_partitions\u0027,"},{"line_number":340,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_6cdc5e73","line":337,"updated":"2015-09-29 16:18:17.000000000","message":"just assert_called_once_with maybe?","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                      use_standard_locale\u003dTrue, run_as_root\u003dTrue)]"},{"line_number":335,"context_line":"        result \u003d disk_partitioner.fix_gpt_structs(\u0027/dev/fake\u0027)"},{"line_number":336,"context_line":"        self.assertFalse(result)"},{"line_number":337,"context_line":"        self.assertListEqual(execute_mock.call_args_list, execute_calls)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    @mock.patch.object(disk_partitioner, \u0027list_partitions\u0027,"},{"line_number":340,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_2116b6f1","line":337,"in_reply_to":"9a1a9d01_6cdc5e73","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"}],"ironic/tests/drivers/test_deploy_utils.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"218e8809dec5c392f7a10b6ab5c46f97aae544d7","unresolved":false,"context_lines":[{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    @mock.patch.object(common_utils, \u0027unlink_without_raise\u0027, autospec\u003dTrue)"},{"line_number":948,"context_line":"    @mock.patch.object(disk_partitioner, \u0027create_partition\u0027, autospec\u003dTrue)"},{"line_number":949,"context_line":"    @mock.patch.object(disk_partitioner, \u0027is_disk_gpt_partitioned\u0027,"},{"line_number":950,"context_line":"                       autospec\u003dTrue)"},{"line_number":951,"context_line":"    @mock.patch.object(disk_partitioner, \u0027get_labelled_partition\u0027,"},{"line_number":952,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_fab70ef3","line":949,"updated":"2015-09-28 04:08:32.000000000","message":"Might make sense to assert fix_gpt_structs wasn\u0027t called.","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c7f40b9dc4258a84777b6d338d824d4974e75af4","unresolved":false,"context_lines":[{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    @mock.patch.object(common_utils, \u0027unlink_without_raise\u0027, autospec\u003dTrue)"},{"line_number":948,"context_line":"    @mock.patch.object(disk_partitioner, \u0027create_partition\u0027, autospec\u003dTrue)"},{"line_number":949,"context_line":"    @mock.patch.object(disk_partitioner, \u0027is_disk_gpt_partitioned\u0027,"},{"line_number":950,"context_line":"                       autospec\u003dTrue)"},{"line_number":951,"context_line":"    @mock.patch.object(disk_partitioner, \u0027get_labelled_partition\u0027,"},{"line_number":952,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_61ca6e70","line":949,"in_reply_to":"9a1a9d01_fab70ef3","updated":"2015-10-05 06:49:02.000000000","message":"Done","commit_id":"0fc7a9e3e7fee310466f0863ce0fd3d3cf97aae7"}],"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"55f5a9dff43d566f3a042b9e139f39d785797012","unresolved":false,"context_lines":[{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        self.assertEqual(utils_calls_expected, utils_mock.mock_calls)"},{"line_number":913,"context_line":"        self.assertEqual(disk_utils_calls_expected, disk_utils_mock.mock_calls)"},{"line_number":914,"context_line":"        self.assertFalse(create_config_drive_mock.called)"},{"line_number":915,"context_line":"        self.assertEqual(\u00270x12345678\u0027, uuid_dict_returned[\u0027disk identifier\u0027])"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"    @mock.patch.object(disk_utils, \u0027create_config_drive_partition\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_9ca1fafa","line":914,"updated":"2016-09-16 22:52:39.000000000","message":"create_config_drive_mock.assert_not_called()\n\nhttps://docs.python.org/3/library/unittest.mock.html","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"43caaa2113a5bbcf1b7d3cdb1ffb70871aa5efae","unresolved":false,"context_lines":[{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        self.assertEqual(utils_calls_expected, utils_mock.mock_calls)"},{"line_number":913,"context_line":"        self.assertEqual(disk_utils_calls_expected, disk_utils_mock.mock_calls)"},{"line_number":914,"context_line":"        self.assertFalse(create_config_drive_mock.called)"},{"line_number":915,"context_line":"        self.assertEqual(\u00270x12345678\u0027, uuid_dict_returned[\u0027disk identifier\u0027])"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"    @mock.patch.object(disk_utils, \u0027create_config_drive_partition\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_b2b4e8d4","line":914,"in_reply_to":"7a8ec9b2_527cb9b4","updated":"2016-09-19 13:29:46.000000000","message":"It should be available to all Python versions as we import the mock library.\n\nFor example it is in the code here:\n\nhttps://github.com/openstack/ironic/blob/5259a8e24588214f8402a1fcb7fd5ec5c9e9c413/ironic/tests/unit/dhcp/test_neutron.py#L284\n\nJust an FYI","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1130658d98c65ed9cb6c63f80a026dd611c9ee70","unresolved":false,"context_lines":[{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        self.assertEqual(utils_calls_expected, utils_mock.mock_calls)"},{"line_number":913,"context_line":"        self.assertEqual(disk_utils_calls_expected, disk_utils_mock.mock_calls)"},{"line_number":914,"context_line":"        self.assertFalse(create_config_drive_mock.called)"},{"line_number":915,"context_line":"        self.assertEqual(\u00270x12345678\u0027, uuid_dict_returned[\u0027disk identifier\u0027])"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"    @mock.patch.object(disk_utils, \u0027create_config_drive_partition\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_527cb9b4","line":914,"in_reply_to":"7a8ec9b2_9ca1fafa","updated":"2016-09-19 05:54:34.000000000","message":"It seems this method is available from python 3.5 onwards.","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"55f5a9dff43d566f3a042b9e139f39d785797012","unresolved":false,"context_lines":[{"line_number":951,"context_line":"                                                     image_path, node_uuid,"},{"line_number":952,"context_line":"                                                     configdrive\u003dconfig_url)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        self.assertEqual(utils_calls_expected, utils_mock.mock_calls)"},{"line_number":955,"context_line":"        self.assertEqual(disk_utils_calls_expected, disk_utils_mock.mock_calls)"},{"line_number":956,"context_line":"        create_partition_mock.assert_called_once_with(node_uuid, dev,"},{"line_number":957,"context_line":"                                                      config_url)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_fc991ec5","line":954,"updated":"2016-09-16 22:52:39.000000000","message":"nit:\n\n utils_mock.assert_has_calls(utils_calls_expected)","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1130658d98c65ed9cb6c63f80a026dd611c9ee70","unresolved":false,"context_lines":[{"line_number":951,"context_line":"                                                     image_path, node_uuid,"},{"line_number":952,"context_line":"                                                     configdrive\u003dconfig_url)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        self.assertEqual(utils_calls_expected, utils_mock.mock_calls)"},{"line_number":955,"context_line":"        self.assertEqual(disk_utils_calls_expected, disk_utils_mock.mock_calls)"},{"line_number":956,"context_line":"        create_partition_mock.assert_called_once_with(node_uuid, dev,"},{"line_number":957,"context_line":"                                                      config_url)"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_d43356f4","line":954,"in_reply_to":"7a8ec9b2_fc991ec5","updated":"2016-09-19 05:54:34.000000000","message":"Done","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"55f5a9dff43d566f3a042b9e139f39d785797012","unresolved":false,"context_lines":[{"line_number":952,"context_line":"                                                     configdrive\u003dconfig_url)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        self.assertEqual(utils_calls_expected, utils_mock.mock_calls)"},{"line_number":955,"context_line":"        self.assertEqual(disk_utils_calls_expected, disk_utils_mock.mock_calls)"},{"line_number":956,"context_line":"        create_partition_mock.assert_called_once_with(node_uuid, dev,"},{"line_number":957,"context_line":"                                                      config_url)"},{"line_number":958,"context_line":"        self.assertEqual(\u00270x12345678\u0027, uuid_dict_returned[\u0027disk identifier\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_bcf23604","line":955,"updated":"2016-09-16 22:52:39.000000000","message":"nit, can use:\n\n mockobject.assert_has_calls()","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1130658d98c65ed9cb6c63f80a026dd611c9ee70","unresolved":false,"context_lines":[{"line_number":952,"context_line":"                                                     configdrive\u003dconfig_url)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        self.assertEqual(utils_calls_expected, utils_mock.mock_calls)"},{"line_number":955,"context_line":"        self.assertEqual(disk_utils_calls_expected, disk_utils_mock.mock_calls)"},{"line_number":956,"context_line":"        create_partition_mock.assert_called_once_with(node_uuid, dev,"},{"line_number":957,"context_line":"                                                      config_url)"},{"line_number":958,"context_line":"        self.assertEqual(\u00270x12345678\u0027, uuid_dict_returned[\u0027disk identifier\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_d46196d4","line":955,"in_reply_to":"7a8ec9b2_bcf23604","updated":"2016-09-19 05:54:34.000000000","message":"Done","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"}],"releasenotes/notes/config-drive-support-for-whole-disk-images-in-iscsi-deploy-0193c5222a7cd129.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a4cd6384bb8ea166babcd2699a7d907d28ce8a53","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Config drive support for whole disk images for"},{"line_number":4,"context_line":"    iscsi based deploy requires ironic-lib where"},{"line_number":5,"context_line":"    this feature has been enabled."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fa0719c6_039dc2bb","line":2,"range":{"start_line":2,"start_character":9,"end_line":2,"end_character":10},"updated":"2016-03-23 20:20:05.000000000","message":"AFAIK, prelude is more for release notes summary text...  Not a summary of a specific feature addition","commit_id":"df1c232b9548f4fb6aed258f308d0f66cdd1246b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ded7b126b6bd40b4b1d1488ad33a4095594d3a96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Config drive support for whole disk images for"},{"line_number":4,"context_line":"    iscsi based deploy requires ironic-lib where"},{"line_number":5,"context_line":"    this feature has been enabled."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fa0719c6_95b29ee3","line":2,"range":{"start_line":2,"start_character":9,"end_line":2,"end_character":10},"in_reply_to":"fa0719c6_039dc2bb","updated":"2016-03-24 02:12:31.000000000","message":"Done","commit_id":"df1c232b9548f4fb6aed258f308d0f66cdd1246b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a4cd6384bb8ea166babcd2699a7d907d28ce8a53","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    this feature has been enabled."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - Config drive support for whole disk images for"},{"line_number":8,"context_line":"    iscsi based deploy."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fa0719c6_237f2667","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":23},"updated":"2016-03-23 20:20:05.000000000","message":"I would kind of like to see an explanation of the deficiency noted in the commit message that hybrid images will not work in the release notes.","commit_id":"df1c232b9548f4fb6aed258f308d0f66cdd1246b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ded7b126b6bd40b4b1d1488ad33a4095594d3a96","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    this feature has been enabled."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - Config drive support for whole disk images for"},{"line_number":8,"context_line":"    iscsi based deploy."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fa0719c6_35c4723e","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":23},"in_reply_to":"fa0719c6_237f2667","updated":"2016-03-24 02:12:31.000000000","message":"Done","commit_id":"df1c232b9548f4fb6aed258f308d0f66cdd1246b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8499e22e91e483d3b809376e342af5e17054fc2d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are"},{"line_number":7,"context_line":"    capable of boot from BIOS and UEFI boot mode.    "}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7aa08908_46042417","line":7,"updated":"2016-06-13 12:20:35.000000000","message":"nit: Whitespace","commit_id":"74b505cbeea9cdf970bfe14401fd0e49c0833b0e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ab576618d313edd846d796adbaf68e19cbe8eae1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are"},{"line_number":7,"context_line":"    capable of boot from BIOS and UEFI boot mode.    "}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7aa08908_05a7a80b","line":7,"in_reply_to":"7aa08908_46042417","updated":"2016-06-13 14:58:59.000000000","message":"Will fix this during next patch.","commit_id":"74b505cbeea9cdf970bfe14401fd0e49c0833b0e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3503da3ecd17bdabdbaddd450a4ffd2f1e438e29","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Config drive support for whole disk images for"},{"line_number":4,"context_line":"    iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3ac371cc_72962b40","line":3,"updated":"2016-08-17 12:42:02.000000000","message":"s/Config drive support/Added config drive support/","commit_id":"804fd1afced5a76ed546e1fc05833b040c7c6d02"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9006b36d3b004ecdd463b73fca1d88fd31eb1c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Config drive support for whole disk images for"},{"line_number":4,"context_line":"    iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3ac371cc_377bd7c2","line":3,"in_reply_to":"3ac371cc_72962b40","updated":"2016-08-18 05:25:31.000000000","message":"Done","commit_id":"804fd1afced5a76ed546e1fc05833b040c7c6d02"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3503da3ecd17bdabdbaddd450a4ffd2f1e438e29","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Config drive support for whole disk images for"},{"line_number":4,"context_line":"    iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are"},{"line_number":7,"context_line":"    capable of boot from BIOS and UEFI boot mode."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3ac371cc_d280bff9","line":6,"range":{"start_line":6,"start_character":38,"end_line":6,"end_character":39},"updated":"2016-08-17 12:42:02.000000000","message":"; is not needed here.","commit_id":"804fd1afced5a76ed546e1fc05833b040c7c6d02"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1e9006b36d3b004ecdd463b73fca1d88fd31eb1c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Config drive support for whole disk images for"},{"line_number":4,"context_line":"    iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are"},{"line_number":7,"context_line":"    capable of boot from BIOS and UEFI boot mode."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3ac371cc_17769bd6","line":6,"range":{"start_line":6,"start_character":38,"end_line":6,"end_character":39},"in_reply_to":"3ac371cc_d280bff9","updated":"2016-08-18 05:25:31.000000000","message":"Done","commit_id":"804fd1afced5a76ed546e1fc05833b040c7c6d02"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"55f5a9dff43d566f3a042b9e139f39d785797012","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added config drive support for whole disk images"},{"line_number":4,"context_line":"    for iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images which are"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_41adc986","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":22},"updated":"2016-09-16 22:52:39.000000000","message":"I think this should be one word: configdrive","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1130658d98c65ed9cb6c63f80a026dd611c9ee70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added config drive support for whole disk images"},{"line_number":4,"context_line":"    for iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images which are"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_d4e6f642","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":22},"in_reply_to":"7a8ec9b2_41adc986","updated":"2016-09-19 05:54:34.000000000","message":"Done","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"55f5a9dff43d566f3a042b9e139f39d785797012","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added config drive support for whole disk images"},{"line_number":4,"context_line":"    for iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images which are"},{"line_number":7,"context_line":"    capable of boot from BIOS and UEFI boot mode."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_c1af197b","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":13},"updated":"2016-09-16 22:52:39.000000000","message":"iSCSI","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1130658d98c65ed9cb6c63f80a026dd611c9ee70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added config drive support for whole disk images"},{"line_number":4,"context_line":"    for iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images which are"},{"line_number":7,"context_line":"    capable of boot from BIOS and UEFI boot mode."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_74f522eb","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":13},"in_reply_to":"7a8ec9b2_c1af197b","updated":"2016-09-19 05:54:34.000000000","message":"Done","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"55f5a9dff43d566f3a042b9e139f39d785797012","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    for iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images which are"},{"line_number":7,"context_line":"    capable of boot from BIOS and UEFI boot mode."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_4176a93e","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":19},"updated":"2016-09-16 22:52:39.000000000","message":"booting","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1130658d98c65ed9cb6c63f80a026dd611c9ee70","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    for iscsi based deploy."},{"line_number":5,"context_line":"    This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images which are"},{"line_number":7,"context_line":"    capable of boot from BIOS and UEFI boot mode."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_54f2e606","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":19},"in_reply_to":"7a8ec9b2_4176a93e","updated":"2016-09-19 05:54:34.000000000","message":"Done","commit_id":"1c32e91cdc4059ff4f7745eab8cb47dee506ffb2"}]}
