)]}'
{"ironic/drivers/modules/amt/common.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bb70a6974e15e64ffa7bd11c33cd57a8ac8390af","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"from xml.etree import ElementTree"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import amt.client"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_utils import importutils"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_c82d9f47","line":19,"updated":"2015-10-07 12:46:15.000000000","message":"You\u0027ll likely want to use importutils.try_import(\u0027amt\u0027) or (\u0027amt.client\u0027) since the driver will not be present on every user\u0027s system.","commit_id":"01eb3ec4505925af164c85eca40872a6dd58863a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0b12e1ddb9b86b605c6bd753ed13f134087a0ec3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"from xml.etree import ElementTree"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import amt.client"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_utils import importutils"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_a70e098a","line":19,"in_reply_to":"7a2fa921_c82d9f47","updated":"2015-10-08 17:40:03.000000000","message":"Done","commit_id":"01eb3ec4505925af164c85eca40872a6dd58863a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bb70a6974e15e64ffa7bd11c33cd57a8ac8390af","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.username \u003d username"},{"line_number":87,"context_line":"        self.password \u003d password"},{"line_number":88,"context_line":"        self.amt_client \u003d amt.client.Client("},{"line_number":89,"context_line":"            self.address, self.password, username\u003dself.username,"},{"line_number":90,"context_line":"            protocol\u003dself.protocol)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_6879eb2e","line":89,"updated":"2015-10-07 12:46:15.000000000","message":"Nit: I think it would be more readable to be one variable per line in this block of code, but feel free to ignore. :)","commit_id":"01eb3ec4505925af164c85eca40872a6dd58863a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0b12e1ddb9b86b605c6bd753ed13f134087a0ec3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.username \u003d username"},{"line_number":87,"context_line":"        self.password \u003d password"},{"line_number":88,"context_line":"        self.amt_client \u003d amt.client.Client("},{"line_number":89,"context_line":"            self.address, self.password, username\u003dself.username,"},{"line_number":90,"context_line":"            protocol\u003dself.protocol)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_e77f21de","line":89,"in_reply_to":"7a2fa921_6879eb2e","updated":"2015-10-08 17:40:03.000000000","message":"Done","commit_id":"01eb3ec4505925af164c85eca40872a6dd58863a"}],"ironic/drivers/modules/amt/power.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bb70a6974e15e64ffa7bd11c33cd57a8ac8390af","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    elif target_state \u003d\u003d states.POWER_OFF:"},{"line_number":71,"context_line":"        client.power_off()"},{"line_number":72,"context_line":"    else:"},{"line_number":73,"context_line":"        raise exception.InvalidParameterValue(_(\u0027Unsupported target_state: %s\u0027)"},{"line_number":74,"context_line":"                                              % target_state)"},{"line_number":75,"context_line":"    LOG.info(_LI(\"Power state was set to %(state)r for node %(node_id)s\"),"},{"line_number":76,"context_line":"             {\u0027state\u0027: target_state, \u0027node_id\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_48566f5d","line":73,"updated":"2015-10-07 12:46:15.000000000","message":"I kind of suspect that it would be best to return AMTFailure based on the above doc string, but if we also check the calling method to ensure anything required may be caught, I\u0027m okay with InvalidParameterValue.","commit_id":"01eb3ec4505925af164c85eca40872a6dd58863a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0b12e1ddb9b86b605c6bd753ed13f134087a0ec3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    elif target_state \u003d\u003d states.POWER_OFF:"},{"line_number":71,"context_line":"        client.power_off()"},{"line_number":72,"context_line":"    else:"},{"line_number":73,"context_line":"        raise exception.InvalidParameterValue(_(\u0027Unsupported target_state: %s\u0027)"},{"line_number":74,"context_line":"                                              % target_state)"},{"line_number":75,"context_line":"    LOG.info(_LI(\"Power state was set to %(state)r for node %(node_id)s\"),"},{"line_number":76,"context_line":"             {\u0027state\u0027: target_state, \u0027node_id\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_aa84900a","line":73,"in_reply_to":"7a2fa921_48566f5d","updated":"2015-10-08 17:40:03.000000000","message":"Documented it.","commit_id":"01eb3ec4505925af164c85eca40872a6dd58863a"}],"ironic/drivers/modules/image_cache.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bb70a6974e15e64ffa7bd11c33cd57a8ac8390af","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                     \u0027Deleting the cached copy \"%(cached_file)s since it was \u0027"},{"line_number":415,"context_line":"                     \u0027last modified at %(local_time)s and may be outdated.\u0027),"},{"line_number":416,"context_line":"                 {\u0027href\u0027: href, \u0027remote_time\u0027: img_mtime,"},{"line_number":417,"context_line":"                 \u0027local_time\u0027: master_mtime, \u0027cached_file\u0027: master_path})"},{"line_number":418,"context_line":"        os.unlink(master_path)"},{"line_number":419,"context_line":"    return False"},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_a802a36d","line":417,"updated":"2015-10-07 12:46:15.000000000","message":"This seems like an unrelated change?","commit_id":"01eb3ec4505925af164c85eca40872a6dd58863a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0b12e1ddb9b86b605c6bd753ed13f134087a0ec3","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                     \u0027Deleting the cached copy \"%(cached_file)s since it was \u0027"},{"line_number":415,"context_line":"                     \u0027last modified at %(local_time)s and may be outdated.\u0027),"},{"line_number":416,"context_line":"                 {\u0027href\u0027: href, \u0027remote_time\u0027: img_mtime,"},{"line_number":417,"context_line":"                 \u0027local_time\u0027: master_mtime, \u0027cached_file\u0027: master_path})"},{"line_number":418,"context_line":"        os.unlink(master_path)"},{"line_number":419,"context_line":"    return False"},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_e7a721bb","line":417,"in_reply_to":"7a2fa921_a802a36d","updated":"2015-10-08 17:40:03.000000000","message":"Yep, will delete from this patch.","commit_id":"01eb3ec4505925af164c85eca40872a6dd58863a"}],"requirements.txt":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bb70a6974e15e64ffa7bd11c33cd57a8ac8390af","unresolved":false,"context_lines":[{"line_number":43,"context_line":"retrying!\u003d1.3.0,\u003e\u003d1.2.3 # Apache-2.0"},{"line_number":44,"context_line":"oslo.versionedobjects\u003e\u003d0.9.0"},{"line_number":45,"context_line":"jsonschema!\u003d2.5.0,\u003c3.0.0,\u003e\u003d2.0.0"},{"line_number":46,"context_line":"-e git+https://github.com/JohnVillalovos/amt.git#egg\u003damt"}],"source_content_type":"text/plain","patch_set":3,"id":"7a2fa921_e83bbb9a","line":46,"updated":"2015-10-07 12:46:15.000000000","message":"amt should be in driver-requirements.txt and installed from pip.","commit_id":"01eb3ec4505925af164c85eca40872a6dd58863a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0b12e1ddb9b86b605c6bd753ed13f134087a0ec3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"retrying!\u003d1.3.0,\u003e\u003d1.2.3 # Apache-2.0"},{"line_number":44,"context_line":"oslo.versionedobjects\u003e\u003d0.9.0"},{"line_number":45,"context_line":"jsonschema!\u003d2.5.0,\u003c3.0.0,\u003e\u003d2.0.0"},{"line_number":46,"context_line":"-e git+https://github.com/JohnVillalovos/amt.git#egg\u003damt"}],"source_content_type":"text/plain","patch_set":3,"id":"7a2fa921_6701d137","line":46,"in_reply_to":"7a2fa921_e83bbb9a","updated":"2015-10-08 17:40:03.000000000","message":"Done","commit_id":"01eb3ec4505925af164c85eca40872a6dd58863a"}]}