)]}'
{"doc/source/deploy/install-guide.rst":[{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"e4aaddfbb2640da3f2cbc6d70de47956d2d5bc69","unresolved":false,"context_lines":[{"line_number":558,"context_line":"with Neutron to allow for provisioning of the baremetal server onto the tenant network."},{"line_number":559,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"Note that change to port membership of a portgroup can be done only when a node "},{"line_number":562,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state."},{"line_number":563,"context_line":"It might be safest to only allow this when the node is not in a state where "},{"line_number":564,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a1a9d01_f9d0b3f9","line":561,"updated":"2015-10-12 15:57:54.000000000","message":"remove extra space here as well as at other places.","commit_id":"64e8142fa4c906a8e2ccfca0622823d73b7b5a2a"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"e4aaddfbb2640da3f2cbc6d70de47956d2d5bc69","unresolved":false,"context_lines":[{"line_number":566,"context_line":"with any port-update call."},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"#. Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify these::"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    PLACEOLDER for ml2 configuration"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"#. Assuming you alread have a baremetal node available and added in Ironic, create a portgroup::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a1a9d01_b9923bf5","line":569,"updated":"2015-10-12 15:57:54.000000000","message":"I think we should describe the process flow - e.g. \n1) Create a neutron network for provisioning. Add this network into ironic config (/etc/ironic/ironic.conf). Additionally, specify network_provider as neutron_plugin.\n2) Ensure that you have installed a compatible ML2 driver, which supports baremetal deployments with their HW (switches). \n3) ensure that provisioning network is reachable to tftp server. If not, you may want to create a route to ensure the reachability\n4) explain a bit about portgroups and describe when to use port-groups and when not to use them. If you use port groups, then how to create them (it is already specified below)\n5) If no port-groups, how to update port to specify the HW connectivity information - it is already specified below.\n6) verify all the configured information - use show commands \n7) Restart Ironic conductor after modifying the config\n\nAbove is an example only. Feel free to add/delete/update as you feel fit.","commit_id":"64e8142fa4c906a8e2ccfca0622823d73b7b5a2a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"167dc39167ba8472782eec70b243c614c4919ad0","unresolved":false,"context_lines":[{"line_number":554,"context_line":"Configuring Tenant Networks"},{"line_number":555,"context_line":"---------------------------"},{"line_number":556,"context_line":"This configuration allows creating a dedicated tenant network, which extends"},{"line_number":557,"context_line":"the current Ironic capabilities to provide flat networks. This works in conjunction"},{"line_number":558,"context_line":"with Neutron to allow for provisioning of the baremetal server onto the tenant network."},{"line_number":559,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion."},{"line_number":560,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_16339263","line":557,"updated":"2015-09-28 23:57:05.000000000","message":"s/to provide/which provide/\n\nTo me this makes it clearer that we currently have flat networks and we are adding on to it.","commit_id":"307f20a37e1cf7f7924f0e39f398d02c72d69374"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"af89e8fbfd7212dc0d90448a47f7df04a7f0871a","unresolved":false,"context_lines":[{"line_number":557,"context_line":"the current Ironic capabilities to provide flat networks. This works in conjunction"},{"line_number":558,"context_line":"with Neutron to allow for provisioning of the baremetal server onto the tenant network."},{"line_number":559,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"Note that change to port membership of a portgroup can be done only when a node "},{"line_number":562,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state."},{"line_number":563,"context_line":"It might be safest to only allow this when the node is not in a state where "}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_f82d96a8","line":560,"updated":"2015-09-29 12:09:05.000000000","message":"Somewhere, we need to capture limitations as well, like lack of support for net boot for instances, support for single nic, no LAG as of now, no bonding etc.","commit_id":"307f20a37e1cf7f7924f0e39f398d02c72d69374"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"06315aa35ee74bad9fc9cbb94b794be07d7f9443","unresolved":false,"context_lines":[{"line_number":558,"context_line":"with Neutron to allow for provisioning of the baremetal server onto the tenant network."},{"line_number":559,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"Note that change to port membership of a portgroup can be done only when a node "},{"line_number":562,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state."},{"line_number":563,"context_line":"It might be safest to only allow this when the node is not in a state where "},{"line_number":564,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_f6694bbf","line":561,"updated":"2015-09-28 17:32:23.000000000","message":"White spaces","commit_id":"307f20a37e1cf7f7924f0e39f398d02c72d69374"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"06315aa35ee74bad9fc9cbb94b794be07d7f9443","unresolved":false,"context_lines":[{"line_number":560,"context_line":""},{"line_number":561,"context_line":"Note that change to port membership of a portgroup can be done only when a node "},{"line_number":562,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state."},{"line_number":563,"context_line":"It might be safest to only allow this when the node is not in a state where "},{"line_number":564,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"},{"line_number":565,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":566,"context_line":"with any port-update call."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_1665dfdf","line":563,"updated":"2015-09-28 17:32:23.000000000","message":"White spaces","commit_id":"307f20a37e1cf7f7924f0e39f398d02c72d69374"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"167dc39167ba8472782eec70b243c614c4919ad0","unresolved":false,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"#. Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify these::"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    PLACEOLDER for ml2 configuration"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"#. Assuming you alread have a baremetal node available and added in Ironic, create a portgroup::"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_f625be08","line":570,"updated":"2015-09-28 23:57:05.000000000","message":"s/PLACEOLDER/PLACEHOLDER/","commit_id":"307f20a37e1cf7f7924f0e39f398d02c72d69374"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b4edbfdcf8b324bfd2129f2990c9e9646279a7e4","unresolved":false,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":"#. Assuming you alread have a baremetal node available and added in Ironic, create a portgroup::"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    ironic portgroup-create -n $NODE_UUID -a $NEW_MAC_ADDRESS --name $NAME"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"#. Create a port based on the portgroup just created::"},{"line_number":577,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_6b8941ca","line":574,"updated":"2015-10-05 16:35:22.000000000","message":"This feature doesn\u0027t require a portgroup; portgroups are only if we want to group more than one port as a logical interface... tenant networks can be used without one, if the switch info is put on the port.","commit_id":"307f20a37e1cf7f7924f0e39f398d02c72d69374"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"06315aa35ee74bad9fc9cbb94b794be07d7f9443","unresolved":false,"context_lines":[{"line_number":580,"context_line":"    --portgroup-uuid $PORTGROUP_UUID --pxe-enabled true"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"#. Check the port configuration::"},{"line_number":583,"context_line":"   "},{"line_number":584,"context_line":"    ironic port-show $PORT_UUID"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":".. _CleaningNetworkSetup:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_7683fb56","line":583,"updated":"2015-09-28 17:32:23.000000000","message":"White spaces","commit_id":"307f20a37e1cf7f7924f0e39f398d02c72d69374"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    start\u003d$START_IP,end\u003d$END_IP --enable-dhcp"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"Configuring Tenant Networks"},{"line_number":555,"context_line":"---------------------------"},{"line_number":556,"context_line":"This configuration allows creating a dedicated tenant network, which extends"},{"line_number":557,"context_line":"the current Ironic capabilities of providing flat networks. This works in conjunction"},{"line_number":558,"context_line":"with Neutron to allow for provisioning of the baremetal server onto the tenant network."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_da019739","line":555,"updated":"2015-10-21 18:44:27.000000000","message":"nit: please leave a blank line after starting the paragraph","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    start\u003d$START_IP,end\u003d$END_IP --enable-dhcp"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"Configuring Tenant Networks"},{"line_number":555,"context_line":"---------------------------"},{"line_number":556,"context_line":"This configuration allows creating a dedicated tenant network, which extends"},{"line_number":557,"context_line":"the current Ironic capabilities of providing flat networks. This works in conjunction"},{"line_number":558,"context_line":"with Neutron to allow for provisioning of the baremetal server onto the tenant network."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_f1b8f4c9","line":555,"in_reply_to":"3a29b11f_da019739","updated":"2015-10-23 10:13:53.000000000","message":"I compiled it and it looks like the other sections in this document. Please have a look and let me know","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"d7fd57a9b57754d79eb880a91a980057ebc3717d","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    start\u003d$START_IP,end\u003d$END_IP --enable-dhcp"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"Configuring Tenant Networks"},{"line_number":555,"context_line":"---------------------------"},{"line_number":556,"context_line":"This configuration allows creating a dedicated tenant network, which extends"},{"line_number":557,"context_line":"the current Ironic capabilities of providing flat networks. This works in conjunction"},{"line_number":558,"context_line":"with Neutron to allow for provisioning of the baremetal server onto the tenant network."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_122b2184","line":555,"in_reply_to":"3a29b11f_f1b8f4c9","updated":"2015-11-03 14:47:38.000000000","message":"I don\u0027t think this is a compilation matter, just for a better organization of the text, as I can see in other parts (: That said, this is only my opinion anyway. Just a thought but you sure can leave it.","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":562,"context_line":""},{"line_number":563,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":564,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state."},{"line_number":565,"context_line":"It might be safest to only allow this when the node is not in a state where"},{"line_number":566,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"},{"line_number":567,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":568,"context_line":"with any port-update call."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_bd4db53f","line":565,"updated":"2015-10-21 18:44:27.000000000","message":"\"safer\"?","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"d7fd57a9b57754d79eb880a91a980057ebc3717d","unresolved":false,"context_lines":[{"line_number":562,"context_line":""},{"line_number":563,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":564,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state."},{"line_number":565,"context_line":"It might be safest to only allow this when the node is not in a state where"},{"line_number":566,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"},{"line_number":567,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":568,"context_line":"with any port-update call."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_f29a1dc5","line":565,"in_reply_to":"3a29b11f_110a508a","updated":"2015-11-03 14:47:38.000000000","message":"Sure, I know it can. Just wanted to understand if it was what you meant, but thats ok, thanks for the link (:","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":562,"context_line":""},{"line_number":563,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":564,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state."},{"line_number":565,"context_line":"It might be safest to only allow this when the node is not in a state where"},{"line_number":566,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"},{"line_number":567,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":568,"context_line":"with any port-update call."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_110a508a","line":565,"in_reply_to":"3a29b11f_bd4db53f","updated":"2015-10-23 10:13:53.000000000","message":"this was taken from the specs\n\nhttp://specs.openstack.org/openstack/ironic-specs/specs/liberty/ironic-ml2-integration.html\n\nand \"safest\" can be used","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"#. Create a Neutron network for provisioning and add it in ``/etc/ironic/ironic.conf``"},{"line_number":573,"context_line":"   under the ironic section::"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    [ironic]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_bd229550","line":572,"updated":"2015-10-21 18:44:27.000000000","message":"s/neutron for provisioning/provisioning network","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"#. Create a Neutron network for provisioning and add it in ``/etc/ironic/ironic.conf``"},{"line_number":573,"context_line":"   under the ironic section::"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    [ironic]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_b1811cc5","line":572,"in_reply_to":"3a29b11f_bd229550","updated":"2015-10-23 10:13:53.000000000","message":"Done","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":570,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"#. Create a Neutron network for provisioning and add it in ``/etc/ironic/ironic.conf``"},{"line_number":573,"context_line":"   under the ironic section::"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    [ironic]"},{"line_number":576,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_3d91a547","line":573,"updated":"2015-10-21 18:44:27.000000000","message":"s/ironic/[ironic]","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":570,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"#. Create a Neutron network for provisioning and add it in ``/etc/ironic/ironic.conf``"},{"line_number":573,"context_line":"   under the ironic section::"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    [ironic]"},{"line_number":576,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_5b56d706","line":573,"in_reply_to":"3a29b11f_3d91a547","updated":"2015-10-23 10:13:53.000000000","message":"This is to indicate the indicate the ironic section in the conf file. Please see other part of this document, as they use the same","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"d7fd57a9b57754d79eb880a91a980057ebc3717d","unresolved":false,"context_lines":[{"line_number":570,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"#. Create a Neutron network for provisioning and add it in ``/etc/ironic/ironic.conf``"},{"line_number":573,"context_line":"   under the ironic section::"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    [ironic]"},{"line_number":576,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_4d1d8a65","line":573,"in_reply_to":"3a29b11f_5b56d706","updated":"2015-11-03 14:47:38.000000000","message":"Yeah I know. Saw this in only one other part of this text, and ``ironic`` is at least like this. I tend to prefer [ironic], but since the section is right above, you could just follow the text usage. Consistency over personal opinions (:","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    network_provider as neutron_plugin goes here"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"#. Install a compatible ML2 driver which supports baremetal provisioning for your switch."},{"line_number":585,"context_line":"   Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify/add the following::"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    [ml2_vendor]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_9dd6b9ef","line":584,"updated":"2015-10-21 18:44:27.000000000","message":"Noticed you use \u0027baremetal\u0027 in some places and \u0027bare metal\u0027 in others. Please always use the later as (I believe) it\u0027s the convention (:","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    network_provider as neutron_plugin goes here"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"#. Install a compatible ML2 driver which supports baremetal provisioning for your switch."},{"line_number":585,"context_line":"   Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify/add the following::"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    [ml2_vendor]"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_7105c443","line":584,"in_reply_to":"3a29b11f_9dd6b9ef","updated":"2015-10-23 10:13:53.000000000","message":"Done","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":587,"context_line":"    [ml2_vendor]"},{"line_number":588,"context_line":"    param_1\u003d..."},{"line_number":589,"context_line":"    param_2\u003d..."},{"line_number":590,"context_line":"    param_3\u003d..."},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"#. Restart the ironic conductor after the modifications::"},{"line_number":593,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_7d471dbc","line":590,"updated":"2015-10-21 18:44:27.000000000","message":"Hmm, not sure what should I do here. Should I add the whole section? Is there a [ml2_vendor] section already in ml2_conf.ini? I think this bit is a little unclear.","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"d7fd57a9b57754d79eb880a91a980057ebc3717d","unresolved":false,"context_lines":[{"line_number":587,"context_line":"    [ml2_vendor]"},{"line_number":588,"context_line":"    param_1\u003d..."},{"line_number":589,"context_line":"    param_2\u003d..."},{"line_number":590,"context_line":"    param_3\u003d..."},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"#. Restart the ironic conductor after the modifications::"},{"line_number":593,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_8de7f211","line":590,"in_reply_to":"3a29b11f_40c90658","updated":"2015-11-03 14:47:38.000000000","message":"Actually I wasn\u0027t referring to specify each parameter, you\u0027re right, that\u0027s very vendor specific. But I find it a bit unclear as to what is there to do here. Maybe something like \"replace param_1\u003d..., ...., with your specific parameters\"? Also, as I said it is not clear if the section already exists. If not, is it gonna be called [ml2_vendor]? Can I create it as [ml2_oneview] for instance? I think when you want users to replace information it is nice to tell exactly which info should be replaced and by what (options).","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":587,"context_line":"    [ml2_vendor]"},{"line_number":588,"context_line":"    param_1\u003d..."},{"line_number":589,"context_line":"    param_2\u003d..."},{"line_number":590,"context_line":"    param_3\u003d..."},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"#. Restart the ironic conductor after the modifications::"},{"line_number":593,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_40c90658","line":590,"in_reply_to":"3a29b11f_7d471dbc","updated":"2015-10-23 10:13:53.000000000","message":"I didn\u0027t want to write any vendor specific parameter, but please advice otherwise if so","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":591,"context_line":""},{"line_number":592,"context_line":"#. Restart the ironic conductor after the modifications::"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    service ironic restart (check if this apply)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"#. Make sure that the tftp server is reacheable over the provisioning network,"},{"line_number":597,"context_line":"   where FILENAME is in the tftp server::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_7d7f1dab","line":594,"updated":"2015-10-21 18:44:27.000000000","message":"sudo service ironic-conductor restart\n\nReally don\u0027t like a \u0027(blabal)\u0027 information together with a command. Also, since this command is in the install docs already, please refer to both commands, Ubuntu and Fedora/RHEL7/CentOS7 (there are some examples in the text), for the sake of consistency. Better than leaving a \"check if this apply\" thingy.","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":591,"context_line":""},{"line_number":592,"context_line":"#. Restart the ironic conductor after the modifications::"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    service ironic restart (check if this apply)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"#. Make sure that the tftp server is reacheable over the provisioning network,"},{"line_number":597,"context_line":"   where FILENAME is in the tftp server::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_00a8ee75","line":594,"in_reply_to":"3a29b11f_7d7f1dab","updated":"2015-10-23 10:13:53.000000000","message":"the \u0027check if this apply\u0027 wasn\u0027t meant for the final user, but for the people who are reviewing this","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":594,"context_line":"    service ironic restart (check if this apply)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"#. Make sure that the tftp server is reacheable over the provisioning network,"},{"line_number":597,"context_line":"   where FILENAME is in the tftp server::"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    tftp $TFTP_IP -c get $FILENAME"},{"line_number":600,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_e0c38487","line":597,"updated":"2015-10-21 18:44:27.000000000","message":"Confusing sentence. Maybe \n\n\"Make sure the TFTP server is reachable over the provisioning network by trying to download a file from it::\n\n  $ command\n\nWhere $FILENAME is the file located at the TFTP server.\"\n\nIMO is best to explain the parameters after the command so the first instruction to the user \"Make sure...\" is more clear.","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":594,"context_line":"    service ironic restart (check if this apply)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"#. Make sure that the tftp server is reacheable over the provisioning network,"},{"line_number":597,"context_line":"   where FILENAME is in the tftp server::"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    tftp $TFTP_IP -c get $FILENAME"},{"line_number":600,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_fc4f6b68","line":597,"in_reply_to":"3a29b11f_e0c38487","updated":"2015-10-23 10:13:53.000000000","message":"Done","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":599,"context_line":"    tftp $TFTP_IP -c get $FILENAME"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"#. A portgroups is a link aggregation where multiple interfaces on the bare metal server"},{"line_number":602,"context_line":"   connect to switch ports of a single LAG and belong to the same network. Please remember as said,"},{"line_number":603,"context_line":"   that this doesn\u0027t work if interfaces belong to multiple networks."},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"   If you want to group more than one port as a logical interface, add the option in"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_00a9e08f","line":602,"updated":"2015-10-21 18:44:27.000000000","message":"Sentence is too long. That said, I don\u0027t really know how to help you rephrase it because I didn\u0027t quite understand what you were trying to say. But use commas, they help (:","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":600,"context_line":""},{"line_number":601,"context_line":"#. A portgroups is a link aggregation where multiple interfaces on the bare metal server"},{"line_number":602,"context_line":"   connect to switch ports of a single LAG and belong to the same network. Please remember as said,"},{"line_number":603,"context_line":"   that this doesn\u0027t work if interfaces belong to multiple networks."},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"   If you want to group more than one port as a logical interface, add the option in"},{"line_number":606,"context_line":"   ``/etc/nova/nova.conf`` under the ironic section::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_0056c0cd","line":603,"updated":"2015-10-21 18:44:27.000000000","message":"This bit sounds like a note or something. You just broke the cycle of instructions in the  process flow. Try to put this somewhere after the instruction, maybe after line 618?","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":600,"context_line":""},{"line_number":601,"context_line":"#. A portgroups is a link aggregation where multiple interfaces on the bare metal server"},{"line_number":602,"context_line":"   connect to switch ports of a single LAG and belong to the same network. Please remember as said,"},{"line_number":603,"context_line":"   that this doesn\u0027t work if interfaces belong to multiple networks."},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"   If you want to group more than one port as a logical interface, add the option in"},{"line_number":606,"context_line":"   ``/etc/nova/nova.conf`` under the ironic section::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_8014fe4c","line":603,"in_reply_to":"3a29b11f_0056c0cd","updated":"2015-10-23 10:13:53.000000000","message":"Please check the comments from previous patch (e.g. 2) where it was advised to provide an explanation of the portgroups functionality.\nThe reason to have it here, is that portgroups are optional, so they wont apply to the whole process, but only in case one wants to use them.\n\nI can move it, but I would like to have an agreement from the other contributors","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":603,"context_line":"   that this doesn\u0027t work if interfaces belong to multiple networks."},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"   If you want to group more than one port as a logical interface, add the option in"},{"line_number":606,"context_line":"   ``/etc/nova/nova.conf`` under the ironic section::"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    [ironic]"},{"line_number":609,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_80741036","line":606,"updated":"2015-10-21 18:44:27.000000000","message":"s/ironic/[ironic]","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":603,"context_line":"   that this doesn\u0027t work if interfaces belong to multiple networks."},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"   If you want to group more than one port as a logical interface, add the option in"},{"line_number":606,"context_line":"   ``/etc/nova/nova.conf`` under the ironic section::"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    [ironic]"},{"line_number":609,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_bc0d73e9","line":606,"in_reply_to":"3a29b11f_80741036","updated":"2015-10-23 10:13:53.000000000","message":"same as before","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"d7fd57a9b57754d79eb880a91a980057ebc3717d","unresolved":false,"context_lines":[{"line_number":603,"context_line":"   that this doesn\u0027t work if interfaces belong to multiple networks."},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"   If you want to group more than one port as a logical interface, add the option in"},{"line_number":606,"context_line":"   ``/etc/nova/nova.conf`` under the ironic section::"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    [ironic]"},{"line_number":609,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_ada0b691","line":606,"in_reply_to":"3a29b11f_bc0d73e9","updated":"2015-11-03 14:47:38.000000000","message":"Same reply as before.","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    ..."},{"line_number":610,"context_line":"    use_portgroups\u003dTrue"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"   and restatrt nova service::"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    service nova restart"},{"line_number":615,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_209c1c5c","line":612,"updated":"2015-10-21 18:44:27.000000000","message":"s/restatrt/restart\n\nAlso, which nova service do you want to restart? All of them? Be more specific.","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    ..."},{"line_number":610,"context_line":"    use_portgroups\u003dTrue"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"   and restatrt nova service::"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    service nova restart"},{"line_number":615,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_5c669fbb","line":612,"in_reply_to":"3a29b11f_209c1c5c","updated":"2015-10-23 10:13:53.000000000","message":"Done","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    service nova restart"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"   Then create a portgroup in ironic::"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    ironic portgroup-create -n $NODE_UUID -a $NEW_MAC_ADDRESS --name $NAME"},{"line_number":619,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_804730bb","line":616,"updated":"2015-10-21 18:44:27.000000000","message":"Maybe this can be in another #.\n\"Create a portgroup::\"","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    service nova restart"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"   Then create a portgroup in ironic::"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    ironic portgroup-create -n $NODE_UUID -a $NEW_MAC_ADDRESS --name $NAME"},{"line_number":619,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_d4293f9c","line":616,"in_reply_to":"3a29b11f_804730bb","updated":"2015-10-23 10:13:53.000000000","message":"it actually is part of the same step. I think it should stay here","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"12ee05997395958e24c9bd05086cd116738a65b7","unresolved":false,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    ironic portgroup-create -n $NODE_UUID -a $NEW_MAC_ADDRESS --name $NAME"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"#. If using a portgroup, this can be updated in the port as following::"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    ironic port-create -a $HW_MAC_ADDRESS -n $NODE_UUID -l switch_id\u003d$SWITCH_MAC_ADDRESS \\"},{"line_number":623,"context_line":"    -l switch_info\u003d$SWITCH_HOSTNAME -l port_id\u003d$SWITCH_PORT \\"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_4062783f","line":620,"updated":"2015-10-21 18:44:27.000000000","message":"What is \"this\" in \"this can be updated\"? Unclear.\n\nMaybe\n\n\"#. To create a port linked to a portgroup, do::\"","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":12366,"name":"Carmelo Ragusa","email":"carmelo.ragusa@sap.com","username":"ragmel"},"change_message_id":"18d66de7867eb30a82c3f25f3f1efe4613b0f786","unresolved":false,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    ironic portgroup-create -n $NODE_UUID -a $NEW_MAC_ADDRESS --name $NAME"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"#. If using a portgroup, this can be updated in the port as following::"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    ironic port-create -a $HW_MAC_ADDRESS -n $NODE_UUID -l switch_id\u003d$SWITCH_MAC_ADDRESS \\"},{"line_number":623,"context_line":"    -l switch_info\u003d$SWITCH_HOSTNAME -l port_id\u003d$SWITCH_PORT \\"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a29b11f_b7aeec7e","line":620,"in_reply_to":"3a29b11f_4062783f","updated":"2015-10-23 10:13:53.000000000","message":"Done","commit_id":"0f52448f482537f1452c673d75b92c9ee68c552d"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"3c895f43e913df5e7bdd11d53ae83ae91a6091e5","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    Ubuntu:"},{"line_number":598,"context_line":"      sudo service ironic-conductor restart"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"#. Make sure that the tftp server is reacheable over the provisioning network,"},{"line_number":601,"context_line":"   by trying to download a file from it::"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    tftp $TFTP_IP -c get $FILENAME"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_8246514d","line":600,"updated":"2015-11-03 03:26:22.000000000","message":"s/reacheable/reachable","commit_id":"8abf5f430d3ce424c53978e5164a900a7aff4f7a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d233f6243efcab25e262f0565cf76d5ab6b7906f","unresolved":false,"context_lines":[{"line_number":578,"context_line":"    provisioning_network_uuid\u003d$UUID"},{"line_number":579,"context_line":"    network_provider\u003dneutron_plugin"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"   Also specify network_provider as neutron_plugin, such as::"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    network_provider as neutron_plugin goes here"},{"line_number":584,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a7b0d38_20401da5","line":581,"updated":"2015-12-23 18:03:45.000000000","message":"?? Did you mean to delete it/move it up?","commit_id":"1fa362d6668ffdbe582769559ff661389c0d867e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"202bfe4538b3333a216c9c7507150209005eeee5","unresolved":false,"context_lines":[{"line_number":578,"context_line":"    provisioning_network_uuid\u003d$UUID"},{"line_number":579,"context_line":"    network_provider\u003dneutron_plugin"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"   Also specify network_provider as neutron_plugin, such as::"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    network_provider as neutron_plugin goes here"},{"line_number":584,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a7b0d38_b3ebae12","line":581,"in_reply_to":"1a7b0d38_20401da5","updated":"2016-01-05 17:49:23.000000000","message":"I think here should be also explanation of network_provider option.","commit_id":"1fa362d6668ffdbe582769559ff661389c0d867e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d233f6243efcab25e262f0565cf76d5ab6b7906f","unresolved":false,"context_lines":[{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    [ironic]"},{"line_number":616,"context_line":"    ..."},{"line_number":617,"context_line":"    use_portgroups\u003dTrue"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"   and restart nova-conductor service::"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a7b0d38_608385cd","line":617,"updated":"2015-12-23 18:03:45.000000000","message":"I don\u0027t see such option in any of the parent patches.","commit_id":"1fa362d6668ffdbe582769559ff661389c0d867e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"202bfe4538b3333a216c9c7507150209005eeee5","unresolved":false,"context_lines":[{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    [ironic]"},{"line_number":616,"context_line":"    ..."},{"line_number":617,"context_line":"    use_portgroups\u003dTrue"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"   and restart nova-conductor service::"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a7b0d38_53afeae1","line":617,"in_reply_to":"1a7b0d38_608385cd","updated":"2016-01-05 17:49:23.000000000","message":"I\u0027m sure that it is Ie0cfd3100d43a55c6eb6b449b75c4f62be5ce2c4.","commit_id":"1fa362d6668ffdbe582769559ff661389c0d867e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"e3e66c4f3664a2eb4fe7aa3200761d12ab394bff","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"#. Create a neutron provisioning network and add it in ``/etc/ironic/ironic.conf``"},{"line_number":574,"context_line":"   under the ironic section. network_provider should be set to valid network provider that"},{"line_number":575,"context_line":"   is used to swithing to cleaning/provisioning networks. For exaple set to neutron_plugin"},{"line_number":576,"context_line":"   to use Neutron ML2 driver::"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    [ironic]"}],"source_content_type":"text/x-rst","patch_set":28,"id":"7a5de9d1_12e2942f","line":575,"range":{"start_line":575,"start_character":62,"end_line":575,"end_character":68},"updated":"2016-02-01 09:42:46.000000000","message":"s/exaple/example","commit_id":"7338c6db22f5e9f76be187205bd113935710db4d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"18133a7a1e96a25d14ef17dbd15775fc64bb8e50","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"#. Create a neutron provisioning network and add it in ``/etc/ironic/ironic.conf``"},{"line_number":574,"context_line":"   under the ironic section. network_provider should be set to valid network provider that"},{"line_number":575,"context_line":"   is used to swithing to cleaning/provisioning networks. For exaple set to neutron_plugin"},{"line_number":576,"context_line":"   to use Neutron ML2 driver::"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    [ironic]"}],"source_content_type":"text/x-rst","patch_set":28,"id":"5a5ae5dd_c6c81c25","line":575,"range":{"start_line":575,"start_character":62,"end_line":575,"end_character":68},"in_reply_to":"7a5de9d1_12e2942f","updated":"2016-02-04 18:12:14.000000000","message":"Done","commit_id":"7338c6db22f5e9f76be187205bd113935710db4d"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"4362e22a2f81f51e6cf0533c85046a8380ec4dcb","unresolved":false,"context_lines":[{"line_number":631,"context_line":"    ironic port-create -a $HW_MAC_ADDRESS -n $NODE_UUID -l switch_id\u003d$SWITCH_MAC_ADDRESS \\"},{"line_number":632,"context_line":"    -l switch_info\u003d$SWITCH_HOSTNAME -l port_id\u003d$SWITCH_PORT \\"},{"line_number":633,"context_line":"    --portgroup-uuid $PORTGROUP_UUID --pxe-enabled true"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"#. Check the port configuration::"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    ironic port-show $PORT_UUID"}],"source_content_type":"text/x-rst","patch_set":35,"id":"5a5ae5dd_4ad6ee4f","line":634,"updated":"2016-02-08 15:03:50.000000000","message":"we should include an example of updating portgroup membership, too","commit_id":"42f7563b706a8b37a4aa68ecca81204e780a7f2b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ae4452fb984580ea49b562fed8ae0b34876aca8d","unresolved":false,"context_lines":[{"line_number":631,"context_line":"    ironic port-create -a $HW_MAC_ADDRESS -n $NODE_UUID -l switch_id\u003d$SWITCH_MAC_ADDRESS \\"},{"line_number":632,"context_line":"    -l switch_info\u003d$SWITCH_HOSTNAME -l port_id\u003d$SWITCH_PORT \\"},{"line_number":633,"context_line":"    --portgroup-uuid $PORTGROUP_UUID --pxe-enabled true"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"#. Check the port configuration::"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    ironic port-show $PORT_UUID"}],"source_content_type":"text/x-rst","patch_set":35,"id":"5a5ae5dd_ef01b13a","line":634,"in_reply_to":"5a5ae5dd_4ad6ee4f","updated":"2016-02-09 12:05:39.000000000","message":"Done","commit_id":"42f7563b706a8b37a4aa68ecca81204e780a7f2b"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"4a3ae7017ae4381e2b1e5c90560a30871c44a1b9","unresolved":false,"context_lines":[{"line_number":648,"context_line":"as well as a bare metal server that has multiple interfaces belonging to different networks."},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":651,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state."},{"line_number":652,"context_line":"It might be safest to only allow this when the node is not in a state where"},{"line_number":653,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"},{"line_number":654,"context_line":"port updates should only happen during a state change and not automatically"}],"source_content_type":"text/x-rst","patch_set":43,"id":"dae33548_b872a847","line":651,"range":{"start_line":651,"start_character":8,"end_line":651,"end_character":42},"updated":"2016-02-16 08:32:17.000000000","message":"should add maintenance mode here.","commit_id":"654f1542b6d61f770666259f68e2a50460f7780b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"def8740768cd6308f00c75d2648f07f3c842862a","unresolved":false,"context_lines":[{"line_number":648,"context_line":"as well as a bare metal server that has multiple interfaces belonging to different networks."},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":651,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state."},{"line_number":652,"context_line":"It might be safest to only allow this when the node is not in a state where"},{"line_number":653,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"},{"line_number":654,"context_line":"port updates should only happen during a state change and not automatically"}],"source_content_type":"text/x-rst","patch_set":43,"id":"dae33548_9ae0dd2a","line":651,"range":{"start_line":651,"start_character":8,"end_line":651,"end_character":42},"in_reply_to":"dae33548_b872a847","updated":"2016-02-18 14:45:14.000000000","message":"Done","commit_id":"654f1542b6d61f770666259f68e2a50460f7780b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"02ad980348a60b2bfeb5ce2d5eab55b26e854de4","unresolved":false,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    [ironic]"},{"line_number":700,"context_line":"    ..."},{"line_number":701,"context_line":"    use_portgroups\u003dTrue"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"   and restart nova-conductor service::"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"3a57f1b5_d5d97423","line":701,"updated":"2016-02-12 00:48:23.000000000","message":"This has gone away and is always used.","commit_id":"654f1542b6d61f770666259f68e2a50460f7780b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"def8740768cd6308f00c75d2648f07f3c842862a","unresolved":false,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    [ironic]"},{"line_number":700,"context_line":"    ..."},{"line_number":701,"context_line":"    use_portgroups\u003dTrue"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"   and restart nova-conductor service::"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"dae33548_5ac935ab","line":701,"in_reply_to":"3a57f1b5_d5d97423","updated":"2016-02-18 14:45:14.000000000","message":"Done","commit_id":"654f1542b6d61f770666259f68e2a50460f7780b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"02ad980348a60b2bfeb5ce2d5eab55b26e854de4","unresolved":false,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    ironic port-show $PORT_UUID"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"#. Update porgroup membership::"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"    ironic port-update $PORT_UUID replace portgroup_uuid\u003d$NEW_PORTGROUP_UUID"},{"line_number":728,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"3a57f1b5_7501a069","line":725,"updated":"2016-02-12 00:48:23.000000000","message":"Nit: s/porgroup/portgroup","commit_id":"654f1542b6d61f770666259f68e2a50460f7780b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"def8740768cd6308f00c75d2648f07f3c842862a","unresolved":false,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    ironic port-show $PORT_UUID"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"#. Update porgroup membership::"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"    ironic port-update $PORT_UUID replace portgroup_uuid\u003d$NEW_PORTGROUP_UUID"},{"line_number":728,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"dae33548_3acc31ba","line":725,"in_reply_to":"3a57f1b5_7501a069","updated":"2016-02-18 14:45:14.000000000","message":"Done","commit_id":"654f1542b6d61f770666259f68e2a50460f7780b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48b2daa81f4f89e3eb5c1f97cc0558416a9d4610","unresolved":false,"context_lines":[{"line_number":654,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":655,"context_line":"with any port-update call."},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"Portgroups are supported since version 1.16 of ironic API, so it is added to"},{"line_number":658,"context_line":"ironic CLI calls."},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"Below is an example of a process flow to create such a network:"}],"source_content_type":"text/x-rst","patch_set":52,"id":"1af94dfe_eedab477","line":657,"range":{"start_line":657,"start_character":39,"end_line":657,"end_character":43},"updated":"2016-03-16 10:09:59.000000000","message":"I think the version here may be something else? 1.17 maybe ? Cause the 1.6 is already taken for something else:\n\n1.16\n    Add ability to filter nodes by driver. \n\nhttp://docs.openstack.org/developer/ironic/webapi/v1.html#api-versions-history","commit_id":"de62333daaf480eb4fc95276c2fa0378295c8975"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"307c3594f6565fcd477f3efb4d091e382edfce96","unresolved":false,"context_lines":[{"line_number":654,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":655,"context_line":"with any port-update call."},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"Portgroups are supported since version 1.16 of ironic API, so it is added to"},{"line_number":658,"context_line":"ironic CLI calls."},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"Below is an example of a process flow to create such a network:"}],"source_content_type":"text/x-rst","patch_set":52,"id":"1af94dfe_33a8851f","line":657,"range":{"start_line":657,"start_character":39,"end_line":657,"end_character":43},"updated":"2016-03-16 10:01:13.000000000","message":"has been bumped to 1.17, not merged yet.","commit_id":"de62333daaf480eb4fc95276c2fa0378295c8975"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48b2daa81f4f89e3eb5c1f97cc0558416a9d4610","unresolved":false,"context_lines":[{"line_number":660,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"#. Create a neutron provisioning network and add it in ``/etc/ironic/ironic.conf``"},{"line_number":663,"context_line":"   under the ironic section. network_provider should be set to valid network provider that"},{"line_number":664,"context_line":"   is used to swithing to cleaning/provisioning networks. For example set to neutron_plugin"},{"line_number":665,"context_line":"   to use Neutron ML2 driver::"},{"line_number":666,"context_line":""}],"source_content_type":"text/x-rst","patch_set":52,"id":"1af94dfe_aeb54cce","line":663,"range":{"start_line":663,"start_character":13,"end_line":663,"end_character":27},"updated":"2016-03-16 10:09:59.000000000","message":"Do you mean \"neutron\" section ? Because I see the \"cleaning_network_uuid\" UUID there [0].\n\nps, I\u0027m not sure we have an [ironic] section in the ironic.conf, it would be redundant. Maybe you mean DEFAULT section ?!\n\n[0] https://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L1551","commit_id":"de62333daaf480eb4fc95276c2fa0378295c8975"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48b2daa81f4f89e3eb5c1f97cc0558416a9d4610","unresolved":false,"context_lines":[{"line_number":660,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"#. Create a neutron provisioning network and add it in ``/etc/ironic/ironic.conf``"},{"line_number":663,"context_line":"   under the ironic section. network_provider should be set to valid network provider that"},{"line_number":664,"context_line":"   is used to swithing to cleaning/provisioning networks. For example set to neutron_plugin"},{"line_number":665,"context_line":"   to use Neutron ML2 driver::"},{"line_number":666,"context_line":""}],"source_content_type":"text/x-rst","patch_set":52,"id":"1af94dfe_4ec5a83a","line":663,"range":{"start_line":663,"start_character":28,"end_line":663,"end_character":45},"updated":"2016-03-16 10:09:59.000000000","message":"The network_provider configuration option","commit_id":"de62333daaf480eb4fc95276c2fa0378295c8975"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"307c3594f6565fcd477f3efb4d091e382edfce96","unresolved":false,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":"   Create a portgroup in ironic::"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"    ironic portgroup-create --ironic-api-version 1.16 -n $NODE_UUID \\"},{"line_number":702,"context_line":"    -a $NEW_MAC_ADDRESS --name $NAME"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"#. If using a portgroup, create a port as following::"}],"source_content_type":"text/x-rst","patch_set":52,"id":"1af94dfe_f309fd32","line":701,"range":{"start_line":701,"start_character":48,"end_line":701,"end_character":53},"updated":"2016-03-16 10:01:13.000000000","message":"s/1.16/1.17","commit_id":"de62333daaf480eb4fc95276c2fa0378295c8975"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"307c3594f6565fcd477f3efb4d091e382edfce96","unresolved":false,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"#. If using a portgroup, create a port as following::"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    ironic --ironic-api-version 1.16 port-create -a $HW_MAC_ADDRESS \\"},{"line_number":707,"context_line":"    -n $NODE_UUID -l switch_id\u003d$SWITCH_MAC_ADDRESS \\"},{"line_number":708,"context_line":"    -l switch_info\u003d$SWITCH_HOSTNAME -l port_id\u003d$SWITCH_PORT \\"},{"line_number":709,"context_line":"    --portgroup-uuid $PORTGROUP_UUID --pxe-enabled true"}],"source_content_type":"text/x-rst","patch_set":52,"id":"1af94dfe_33040516","line":706,"range":{"start_line":706,"start_character":32,"end_line":706,"end_character":36},"updated":"2016-03-16 10:01:13.000000000","message":"ditto","commit_id":"de62333daaf480eb4fc95276c2fa0378295c8975"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"307c3594f6565fcd477f3efb4d091e382edfce96","unresolved":false,"context_lines":[{"line_number":710,"context_line":""},{"line_number":711,"context_line":"#. Check the port configuration::"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    ironic --ironic-api-version 1.16 port-show $PORT_UUID"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"#. Update portgroup membership::"},{"line_number":716,"context_line":""}],"source_content_type":"text/x-rst","patch_set":52,"id":"1af94dfe_8effb000","line":713,"range":{"start_line":713,"start_character":32,"end_line":713,"end_character":36},"updated":"2016-03-16 10:01:13.000000000","message":"ditto","commit_id":"de62333daaf480eb4fc95276c2fa0378295c8975"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"307c3594f6565fcd477f3efb4d091e382edfce96","unresolved":false,"context_lines":[{"line_number":714,"context_line":""},{"line_number":715,"context_line":"#. Update portgroup membership::"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    ironic --ironic-api-version 1.16 port-update $PORT_UUID replace \\"},{"line_number":718,"context_line":"    portgroup_uuid\u003d$NEW_PORTGROUP_UUID"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":".. _CleaningNetworkSetup:"}],"source_content_type":"text/x-rst","patch_set":52,"id":"1af94dfe_4e35a8d8","line":717,"range":{"start_line":717,"start_character":32,"end_line":717,"end_character":36},"updated":"2016-03-16 10:01:13.000000000","message":"ditto","commit_id":"de62333daaf480eb4fc95276c2fa0378295c8975"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"aaf14024b4779c2b8bce11aca7e28ef265904671","unresolved":false,"context_lines":[{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    [DEFAULT]"},{"line_number":667,"context_line":"    ..."},{"line_number":668,"context_line":"    enabled_network_drivers\u003dflat,neutron"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"    [neutron]"},{"line_number":671,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":54,"id":"fa0719c6_3edf710e","line":668,"range":{"start_line":668,"start_character":4,"end_line":668,"end_character":40},"updated":"2016-03-23 07:55:30.000000000","message":"the spec doesn\u0027t mention this option and I can\u0027t find it in the related patches.\n\nper the spec and related patches https://review.openstack.org/#/c/139687/74/etc/ironic/ironic.conf.sample , we should set network_provider here, not sure why you remove it from the previous patch sets.","commit_id":"b16ff0f53b6d44826320047818a9a87140f95c8b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"41e7187b9eefec4266e022cb24f19ec9bf52d348","unresolved":false,"context_lines":[{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    [DEFAULT]"},{"line_number":667,"context_line":"    ..."},{"line_number":668,"context_line":"    enabled_network_drivers\u003dflat,neutron"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"    [neutron]"},{"line_number":671,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":54,"id":"fa0719c6_82db5e7b","line":668,"range":{"start_line":668,"start_character":4,"end_line":668,"end_character":40},"in_reply_to":"fa0719c6_3edf710e","updated":"2016-03-24 15:19:26.000000000","message":"Zhenguo, it was decided to refactor current driver load. Many work on this was done by Jim already.\nhttps://review.openstack.org/#/q/topic:refactor-driver-load.","commit_id":"b16ff0f53b6d44826320047818a9a87140f95c8b"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9ee5ec2a5d8b69fc3b0f01317d1aaa2ed9f2559d","unresolved":false,"context_lines":[{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    [DEFAULT]"},{"line_number":667,"context_line":"    ..."},{"line_number":668,"context_line":"    enabled_network_drivers\u003dflat,neutron"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"    [neutron]"},{"line_number":671,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":54,"id":"da0c15f0_07642220","line":668,"range":{"start_line":668,"start_character":4,"end_line":668,"end_character":40},"in_reply_to":"fa0719c6_82db5e7b","updated":"2016-03-26 03:01:24.000000000","message":"indeed, thanks for the explanation.","commit_id":"b16ff0f53b6d44826320047818a9a87140f95c8b"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f67605a3274d66f64b7f97545671e6a237c6a521","unresolved":false,"context_lines":[{"line_number":644,"context_line":"the current Ironic capabilities of providing flat networks. This works in conjunction"},{"line_number":645,"context_line":"with Neutron to allow for provisioning of the Bare Metal server onto the tenant network."},{"line_number":646,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion. However,"},{"line_number":647,"context_line":"this configuration doesn\u0027t support trunked ports belonging to multiple networks,"},{"line_number":648,"context_line":"as well as a bare metal server that has multiple interfaces belonging to different networks."},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"Note that change to port membership of a portgroup can be done only when a node"}],"source_content_type":"text/x-rst","patch_set":58,"id":"da0c15f0_87c0172c","line":647,"range":{"start_line":647,"start_character":35,"end_line":647,"end_character":48},"updated":"2016-03-28 06:28:00.000000000","message":"s/trunked ports/trunk ports ??","commit_id":"de24067318d98b25990307b06997d92d1e6bd930"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"54fc7ef7492929ef5c6efa2ae5cc464e8d28e4d8","unresolved":false,"context_lines":[{"line_number":644,"context_line":"the current Ironic capabilities of providing flat networks. This works in conjunction"},{"line_number":645,"context_line":"with Neutron to allow for provisioning of the Bare Metal server onto the tenant network."},{"line_number":646,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion. However,"},{"line_number":647,"context_line":"this configuration doesn\u0027t support trunked ports belonging to multiple networks,"},{"line_number":648,"context_line":"as well as a bare metal server that has multiple interfaces belonging to different networks."},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"Note that change to port membership of a portgroup can be done only when a node"}],"source_content_type":"text/x-rst","patch_set":58,"id":"ba0121b8_16d8b0ee","line":647,"range":{"start_line":647,"start_character":35,"end_line":647,"end_character":48},"in_reply_to":"da0c15f0_87c0172c","updated":"2016-03-30 10:41:10.000000000","message":"Done","commit_id":"de24067318d98b25990307b06997d92d1e6bd930"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f67605a3274d66f64b7f97545671e6a237c6a521","unresolved":false,"context_lines":[{"line_number":660,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":663,"context_line":"   in ``/etc/ironic/ironic.conf``. Network dirvers should be enabled on ironic-conductor"},{"line_number":664,"context_line":"   by adding them to enabled_network_drivers option under default section::"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":58,"id":"da0c15f0_479f1f50","line":663,"range":{"start_line":663,"start_character":43,"end_line":663,"end_character":50},"updated":"2016-03-28 06:28:00.000000000","message":"s/dirvers/drivers","commit_id":"de24067318d98b25990307b06997d92d1e6bd930"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"54fc7ef7492929ef5c6efa2ae5cc464e8d28e4d8","unresolved":false,"context_lines":[{"line_number":660,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":663,"context_line":"   in ``/etc/ironic/ironic.conf``. Network dirvers should be enabled on ironic-conductor"},{"line_number":664,"context_line":"   by adding them to enabled_network_drivers option under default section::"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":58,"id":"ba0121b8_56f9884c","line":663,"range":{"start_line":663,"start_character":43,"end_line":663,"end_character":50},"in_reply_to":"da0c15f0_479f1f50","updated":"2016-03-30 10:41:10.000000000","message":"Done","commit_id":"de24067318d98b25990307b06997d92d1e6bd930"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f67605a3274d66f64b7f97545671e6a237c6a521","unresolved":false,"context_lines":[{"line_number":671,"context_line":"    ..."},{"line_number":672,"context_line":"    provisioning_network_uuid\u003d$UUID"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"#. The network_interface should be set to valid network driver that is used to swithing"},{"line_number":675,"context_line":"   to cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    ironic node-create -n $NAME --network-interface neutron"}],"source_content_type":"text/x-rst","patch_set":58,"id":"da0c15f0_27b14be2","line":674,"range":{"start_line":674,"start_character":79,"end_line":674,"end_character":87},"updated":"2016-03-28 06:28:00.000000000","message":"s/swithing/switching","commit_id":"de24067318d98b25990307b06997d92d1e6bd930"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"54fc7ef7492929ef5c6efa2ae5cc464e8d28e4d8","unresolved":false,"context_lines":[{"line_number":671,"context_line":"    ..."},{"line_number":672,"context_line":"    provisioning_network_uuid\u003d$UUID"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"#. The network_interface should be set to valid network driver that is used to swithing"},{"line_number":675,"context_line":"   to cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    ironic node-create -n $NAME --network-interface neutron"}],"source_content_type":"text/x-rst","patch_set":58,"id":"ba0121b8_d6a3d84d","line":674,"range":{"start_line":674,"start_character":79,"end_line":674,"end_character":87},"in_reply_to":"da0c15f0_27b14be2","updated":"2016-03-30 10:41:10.000000000","message":"Done","commit_id":"de24067318d98b25990307b06997d92d1e6bd930"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f53ba4dcab56f7fabe2696abb07f3799c806377d","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":659,"context_line":"   in ``/etc/ironic/ironic.conf``. Network drivers should be enabled on ironic-conductor"},{"line_number":660,"context_line":"   by adding them to enabled_network_drivers option under default section::"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"},{"line_number":663,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":76,"id":"bab6814e_b7c9f527","line":660,"range":{"start_line":660,"start_character":21,"end_line":660,"end_character":44},"updated":"2016-05-25 09:21:26.000000000","message":"enabled_network_interfaces","commit_id":"657e10c70f4e3dd84b2256cdfa83c8d38fab9800"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c6fa6ea0b225d8bf203b4037a517890f57f2b95c","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":659,"context_line":"   in ``/etc/ironic/ironic.conf``. Network drivers should be enabled on ironic-conductor"},{"line_number":660,"context_line":"   by adding them to enabled_network_drivers option under default section::"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"},{"line_number":663,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":76,"id":"bab6814e_e2fff6fe","line":660,"range":{"start_line":660,"start_character":21,"end_line":660,"end_character":44},"in_reply_to":"bab6814e_b7c9f527","updated":"2016-05-26 14:58:52.000000000","message":"Done","commit_id":"657e10c70f4e3dd84b2256cdfa83c8d38fab9800"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f53ba4dcab56f7fabe2696abb07f3799c806377d","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"},{"line_number":663,"context_line":"    ..."},{"line_number":664,"context_line":"    enabled_network_drivers\u003dflat,neutron"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    [neutron]"},{"line_number":667,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":76,"id":"bab6814e_57540953","line":664,"range":{"start_line":664,"start_character":20,"end_line":664,"end_character":27},"updated":"2016-05-25 09:21:26.000000000","message":"interfaces","commit_id":"657e10c70f4e3dd84b2256cdfa83c8d38fab9800"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c6fa6ea0b225d8bf203b4037a517890f57f2b95c","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"},{"line_number":663,"context_line":"    ..."},{"line_number":664,"context_line":"    enabled_network_drivers\u003dflat,neutron"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    [neutron]"},{"line_number":667,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":76,"id":"bab6814e_c2047216","line":664,"range":{"start_line":664,"start_character":20,"end_line":664,"end_character":27},"in_reply_to":"bab6814e_57540953","updated":"2016-05-26 14:58:52.000000000","message":"Done","commit_id":"657e10c70f4e3dd84b2256cdfa83c8d38fab9800"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f53ba4dcab56f7fabe2696abb07f3799c806377d","unresolved":false,"context_lines":[{"line_number":668,"context_line":"    provisioning_network_uuid\u003d$UUID"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"#. The network_interface should be set to valid network driver that is used to switching"},{"line_number":671,"context_line":"   to cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-rst","patch_set":76,"id":"bab6814e_b79735ea","line":671,"updated":"2016-05-25 09:21:26.000000000","message":"provisioning_network_uuid is required parameter for neutron network driver. It should be mentioned here.","commit_id":"657e10c70f4e3dd84b2256cdfa83c8d38fab9800"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c6fa6ea0b225d8bf203b4037a517890f57f2b95c","unresolved":false,"context_lines":[{"line_number":668,"context_line":"    provisioning_network_uuid\u003d$UUID"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"#. The network_interface should be set to valid network driver that is used to switching"},{"line_number":671,"context_line":"   to cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-rst","patch_set":76,"id":"bab6814e_4294028a","line":671,"in_reply_to":"bab6814e_b79735ea","updated":"2016-05-26 14:58:52.000000000","message":"Done","commit_id":"657e10c70f4e3dd84b2256cdfa83c8d38fab9800"},{"author":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"change_message_id":"87089ed4fbed59a103733f067355202ebaf9e711","unresolved":false,"context_lines":[{"line_number":645,"context_line":""},{"line_number":646,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":647,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state or in maintenance."},{"line_number":648,"context_line":"It might be safest to only allow this when the node is not in a state where"},{"line_number":649,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"},{"line_number":650,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":651,"context_line":"with any port-update call."}],"source_content_type":"text/x-rst","patch_set":80,"id":"9abb7d3a_7c9b6e66","line":648,"range":{"start_line":648,"start_character":3,"end_line":648,"end_character":8},"updated":"2016-06-01 16:43:32.000000000","message":"Minor nit - Not a fan of using \"might be\" here, sounds like a design instead of an install guide. \"It is safest...\" would be better.","commit_id":"c12cd811d6e34e13810d01076164e781d093772a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b52ef5c1e58af2f43c6523331a99f5f0f63605b8","unresolved":false,"context_lines":[{"line_number":690,"context_line":"    Ubuntu:"},{"line_number":691,"context_line":"      sudo service ironic-conductor restart"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"#. Make sure that the tftp server is reachable over the provisioning network,"},{"line_number":694,"context_line":"   by trying to download a file from it::"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"    tftp $TFTP_IP -c get $FILENAME"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"   where FILENAME is the file located at the tftp server."},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"#. A portgroup is a link aggregation, where multiple interfaces on the bare metal server"},{"line_number":701,"context_line":"   connect to switch ports of a single LAG and belong to the same network. Please remember,"}],"source_content_type":"text/x-rst","patch_set":81,"id":"7aa08908_4111f903","line":698,"range":{"start_line":693,"start_character":0,"end_line":698,"end_character":57},"updated":"2016-06-16 12:40:59.000000000","message":"Trying to understand, how is this relevant to configuring a node?  Seems more like a general troubleshooting step?","commit_id":"dfe70f210ebf86421d9f9a0c5a6ef7d647ae5ae8"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"Configuring Tenant Networks"},{"line_number":638,"context_line":"---------------------------"},{"line_number":639,"context_line":"This configuration allows creating a dedicated tenant network, which extends"},{"line_number":640,"context_line":"the current Ironic capabilities of providing flat networks. This works in conjunction"},{"line_number":641,"context_line":"with Neutron to allow for provisioning of the Bare Metal server onto the tenant network."},{"line_number":642,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion. However,"}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_a7d75d22","line":639,"range":{"start_line":639,"start_character":26,"end_line":639,"end_character":36},"updated":"2016-07-15 18:02:48.000000000","message":"maybe \"creation of\"","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"Configuring Tenant Networks"},{"line_number":638,"context_line":"---------------------------"},{"line_number":639,"context_line":"This configuration allows creating a dedicated tenant network, which extends"},{"line_number":640,"context_line":"the current Ironic capabilities of providing flat networks. This works in conjunction"},{"line_number":641,"context_line":"with Neutron to allow for provisioning of the Bare Metal server onto the tenant network."},{"line_number":642,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion. However,"}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_0e80fd45","line":639,"range":{"start_line":639,"start_character":26,"end_line":639,"end_character":36},"in_reply_to":"fad55976_a7d75d22","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":638,"context_line":"---------------------------"},{"line_number":639,"context_line":"This configuration allows creating a dedicated tenant network, which extends"},{"line_number":640,"context_line":"the current Ironic capabilities of providing flat networks. This works in conjunction"},{"line_number":641,"context_line":"with Neutron to allow for provisioning of the Bare Metal server onto the tenant network."},{"line_number":642,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion. However,"},{"line_number":643,"context_line":"this configuration doesn\u0027t support trunk ports belonging to multiple networks,"},{"line_number":644,"context_line":"as well as a bare metal server that has multiple interfaces belonging to different networks."}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_4720214a","line":641,"range":{"start_line":641,"start_character":5,"end_line":641,"end_character":12},"updated":"2016-07-15 18:02:48.000000000","message":"s/Neutron/neutron/","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":638,"context_line":"---------------------------"},{"line_number":639,"context_line":"This configuration allows creating a dedicated tenant network, which extends"},{"line_number":640,"context_line":"the current Ironic capabilities of providing flat networks. This works in conjunction"},{"line_number":641,"context_line":"with Neutron to allow for provisioning of the Bare Metal server onto the tenant network."},{"line_number":642,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion. However,"},{"line_number":643,"context_line":"this configuration doesn\u0027t support trunk ports belonging to multiple networks,"},{"line_number":644,"context_line":"as well as a bare metal server that has multiple interfaces belonging to different networks."}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_6e953987","line":641,"range":{"start_line":641,"start_character":5,"end_line":641,"end_character":12},"in_reply_to":"fad55976_4720214a","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":641,"context_line":"with Neutron to allow for provisioning of the Bare Metal server onto the tenant network."},{"line_number":642,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion. However,"},{"line_number":643,"context_line":"this configuration doesn\u0027t support trunk ports belonging to multiple networks,"},{"line_number":644,"context_line":"as well as a bare metal server that has multiple interfaces belonging to different networks."},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":647,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state or in maintenance."}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_aaba84be","line":644,"range":{"start_line":644,"start_character":0,"end_line":644,"end_character":92},"updated":"2016-07-15 18:02:48.000000000","message":"\"nor are bare metal servers with multiple interfaces belonging to different networks\" (assuming that\u0027s the case, otherwise this needs to be more clear)","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":641,"context_line":"with Neutron to allow for provisioning of the Bare Metal server onto the tenant network."},{"line_number":642,"context_line":"The result is that multiple tenants can now deploy in an isolated fashion. However,"},{"line_number":643,"context_line":"this configuration doesn\u0027t support trunk ports belonging to multiple networks,"},{"line_number":644,"context_line":"as well as a bare metal server that has multiple interfaces belonging to different networks."},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":647,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state or in maintenance."}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_4e92f5a0","line":644,"range":{"start_line":644,"start_character":0,"end_line":644,"end_character":92},"in_reply_to":"fad55976_aaba84be","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":643,"context_line":"this configuration doesn\u0027t support trunk ports belonging to multiple networks,"},{"line_number":644,"context_line":"as well as a bare metal server that has multiple interfaces belonging to different networks."},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":647,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state or in maintenance."},{"line_number":648,"context_line":"It might be safest to only allow this when the node is not in a state where"},{"line_number":649,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_47e78112","line":646,"range":{"start_line":646,"start_character":10,"end_line":646,"end_character":16},"updated":"2016-07-15 18:02:48.000000000","message":"s/change/changes/","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":645,"context_line":""},{"line_number":646,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":647,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state or in maintenance."},{"line_number":648,"context_line":"It might be safest to only allow this when the node is not in a state where"},{"line_number":649,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"},{"line_number":650,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":651,"context_line":"with any port-update call."}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_aa03a40c","line":648,"range":{"start_line":648,"start_character":0,"end_line":648,"end_character":37},"updated":"2016-07-15 18:02:48.000000000","message":"better wording: \"For safety, we recommend only changing portgroup membership when...\" because the operator will initiate this rather than giving permission for it to happen","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":646,"context_line":"Note that change to port membership of a portgroup can be done only when a node"},{"line_number":647,"context_line":"is in a MANAGEABLE/INSPECTING/ENROLL state or in maintenance."},{"line_number":648,"context_line":"It might be safest to only allow this when the node is not in a state where"},{"line_number":649,"context_line":"uninterrupted connectivity is expected. These limitations will also ensure that Neutron"},{"line_number":650,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":651,"context_line":"with any port-update call."},{"line_number":652,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_b9c68d97","line":649,"range":{"start_line":649,"start_character":80,"end_line":649,"end_character":87},"updated":"2016-07-13 02:28:43.000000000","message":"s/Neutron/neutron/","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":650,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":651,"context_line":"with any port-update call."},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"Portgroups are supported since version 1.17 of ironic API, so it is added to"},{"line_number":654,"context_line":"ironic CLI calls."},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"Below is an example of a process flow to create such a network:"}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_59420910","line":653,"range":{"start_line":653,"start_character":39,"end_line":653,"end_character":43},"updated":"2016-07-13 02:28:43.000000000","message":"s/1.17/1.19/g","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":650,"context_line":"port updates should only happen during a state change and not automatically"},{"line_number":651,"context_line":"with any port-update call."},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"Portgroups are supported since version 1.17 of ironic API, so it is added to"},{"line_number":654,"context_line":"ironic CLI calls."},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"Below is an example of a process flow to create such a network:"}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_2e7b417d","line":653,"range":{"start_line":653,"start_character":39,"end_line":653,"end_character":43},"in_reply_to":"1aa78d24_59420910","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d448080d7ec42f7fc00105d64008cbfd9647265c","unresolved":false,"context_lines":[{"line_number":656,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":659,"context_line":"   in ``/etc/ironic/ironic.conf``. Network drivers should be enabled on ironic-conductor"},{"line_number":660,"context_line":"   by adding them to enabled_network_interfaces option under default section::"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_b6a8f8dc","line":659,"updated":"2016-07-14 15:39:48.000000000","message":"We should mention that list of enabled_network_interfaces should be identical on both conductor and api nodes since it is used during node enrollment/update validation.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8cc5279c2b918062a71587a7d8490e7ff20aa1ff","unresolved":false,"context_lines":[{"line_number":656,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":659,"context_line":"   in ``/etc/ironic/ironic.conf``. Network drivers should be enabled on ironic-conductor"},{"line_number":660,"context_line":"   by adding them to enabled_network_interfaces option under default section::"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_bba7130a","line":659,"in_reply_to":"1aa78d24_b6a8f8dc","updated":"2016-07-15 12:01:16.000000000","message":"+1","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":656,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":659,"context_line":"   in ``/etc/ironic/ironic.conf``. Network drivers should be enabled on ironic-conductor"},{"line_number":660,"context_line":"   by adding them to enabled_network_interfaces option under default section::"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_ce85455a","line":659,"in_reply_to":"1aa78d24_bba7130a","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":655,"context_line":""},{"line_number":656,"context_line":"Below is an example of a process flow to create such a network:"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":659,"context_line":"   in ``/etc/ironic/ironic.conf``. Network drivers should be enabled on ironic-conductor"},{"line_number":660,"context_line":"   by adding them to enabled_network_interfaces option under default section::"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"},{"line_number":663,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_d94ef936","line":660,"range":{"start_line":658,"start_character":0,"end_line":660,"end_character":78},"updated":"2016-07-13 02:28:43.000000000","message":"Order wise, I think network drivers should be one line item, then the ensuring that the provisioning network is available and configured should be the second step.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":659,"context_line":"   in ``/etc/ironic/ironic.conf``. Network drivers should be enabled on ironic-conductor"},{"line_number":660,"context_line":"   by adding them to enabled_network_interfaces option under default section::"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"},{"line_number":663,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_6ac1ac2e","line":660,"range":{"start_line":660,"start_character":21,"end_line":660,"end_character":47},"updated":"2016-07-15 18:02:48.000000000","message":"``enabled_network_interfaces``","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":659,"context_line":"   in ``/etc/ironic/ironic.conf``. Network drivers should be enabled on ironic-conductor"},{"line_number":660,"context_line":"   by adding them to enabled_network_interfaces option under default section::"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"},{"line_number":663,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_8a4ea0bf","line":660,"range":{"start_line":660,"start_character":55,"end_line":660,"end_character":68},"updated":"2016-07-15 18:02:48.000000000","message":"under the default","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"#. Create a neutron provisioning network and add it in under the neutron section"},{"line_number":659,"context_line":"   in ``/etc/ironic/ironic.conf``. Network drivers should be enabled on ironic-conductor"},{"line_number":660,"context_line":"   by adding them to enabled_network_interfaces option under default section::"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"},{"line_number":663,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_ee80094c","line":660,"range":{"start_line":660,"start_character":55,"end_line":660,"end_character":68},"in_reply_to":"fad55976_8a4ea0bf","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"},{"line_number":663,"context_line":"    ..."},{"line_number":664,"context_line":"    enabled_network_interfaces\u003dflat,neutron"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    [neutron]"},{"line_number":667,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_196361b2","line":664,"updated":"2016-07-13 02:28:43.000000000","message":"nit: missing noop driver ;)","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    [DEFAULT]"},{"line_number":663,"context_line":"    ..."},{"line_number":664,"context_line":"    enabled_network_interfaces\u003dflat,neutron"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    [neutron]"},{"line_number":667,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_aeb8d12b","line":664,"in_reply_to":"1aa78d24_196361b2","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":667,"context_line":"    ..."},{"line_number":668,"context_line":"    provisioning_network_uuid\u003d$UUID"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"#. Using ``neutron`` network driver requires that ``provision_network_uuid`` is set to valid"},{"line_number":671,"context_line":"   Neutron network UUID, otherwise ironic-conductor will fail to start. The"},{"line_number":672,"context_line":"   network_interface should be set to valid network driver that is used to switching to"},{"line_number":673,"context_line":"   cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_ead59cb9","line":670,"range":{"start_line":670,"start_character":84,"end_line":670,"end_character":92},"updated":"2016-07-15 18:02:48.000000000","message":"to a valid","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":667,"context_line":"    ..."},{"line_number":668,"context_line":"    provisioning_network_uuid\u003d$UUID"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"#. Using ``neutron`` network driver requires that ``provision_network_uuid`` is set to valid"},{"line_number":671,"context_line":"   Neutron network UUID, otherwise ironic-conductor will fail to start. The"},{"line_number":672,"context_line":"   network_interface should be set to valid network driver that is used to switching to"},{"line_number":673,"context_line":"   cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_6eaed9e8","line":670,"range":{"start_line":670,"start_character":84,"end_line":670,"end_character":92},"in_reply_to":"fad55976_ead59cb9","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":669,"context_line":""},{"line_number":670,"context_line":"#. Using ``neutron`` network driver requires that ``provision_network_uuid`` is set to valid"},{"line_number":671,"context_line":"   Neutron network UUID, otherwise ironic-conductor will fail to start. The"},{"line_number":672,"context_line":"   network_interface should be set to valid network driver that is used to switching to"},{"line_number":673,"context_line":"   cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":676,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_25dd2543","line":673,"range":{"start_line":672,"start_character":31,"end_line":673,"end_character":33},"updated":"2016-07-15 18:02:48.000000000","message":"\"set to a valid network driver that can be used to switch between cleaning and provisioning networks\" (maybe include a link to the cleaning network docs here too.)","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":669,"context_line":""},{"line_number":670,"context_line":"#. Using ``neutron`` network driver requires that ``provision_network_uuid`` is set to valid"},{"line_number":671,"context_line":"   Neutron network UUID, otherwise ironic-conductor will fail to start. The"},{"line_number":672,"context_line":"   network_interface should be set to valid network driver that is used to switching to"},{"line_number":673,"context_line":"   cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":676,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_c92edff9","line":673,"range":{"start_line":672,"start_character":31,"end_line":673,"end_character":33},"in_reply_to":"fad55976_25dd2543","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":672,"context_line":"   network_interface should be set to valid network driver that is used to switching to"},{"line_number":673,"context_line":"   cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"#. Install a compatible ML2 driver which supports Bare Metal provisioning for your switch."},{"line_number":678,"context_line":"   Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify/add the following::"}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_595969fc","line":675,"range":{"start_line":675,"start_character":3,"end_line":675,"end_character":59},"updated":"2016-07-13 02:28:43.000000000","message":"We either need to explicitly tell the operator that they need to restart the conductor after editing the configuration, OR hold off on the example command for creating the node until after they have restarted the conductor with the appropriate configuration.  This is because they will expect to be able to follow steps and run commands in the literal order in which they have been conveyed.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":672,"context_line":"   network_interface should be set to valid network driver that is used to switching to"},{"line_number":673,"context_line":"   cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"#. Install a compatible ML2 driver which supports Bare Metal provisioning for your switch."},{"line_number":678,"context_line":"   Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify/add the following::"}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_2a8694b9","line":675,"range":{"start_line":675,"start_character":3,"end_line":675,"end_character":59},"in_reply_to":"1aa78d24_595969fc","updated":"2016-07-15 18:02:48.000000000","message":"Strongly agree.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":672,"context_line":"   network_interface should be set to valid network driver that is used to switching to"},{"line_number":673,"context_line":"   cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"#. Install a compatible ML2 driver which supports Bare Metal provisioning for your switch."},{"line_number":678,"context_line":"   Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify/add the following::"}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_ae48d1cd","line":675,"range":{"start_line":675,"start_character":3,"end_line":675,"end_character":59},"in_reply_to":"fad55976_2a8694b9","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":673,"context_line":"   cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"#. Install a compatible ML2 driver which supports Bare Metal provisioning for your switch."},{"line_number":678,"context_line":"   Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify/add the following::"},{"line_number":679,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_39073dcb","line":676,"updated":"2016-07-13 02:28:43.000000000","message":"We likely need a note indicating what the present default is for a node that has been created and when that setting would differ as a result of configuration.  This is so a user can understand the behavior.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":673,"context_line":"   cleaning/provisioning networks. For example set to neutron to use Neutron ML2 driver::"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"#. Install a compatible ML2 driver which supports Bare Metal provisioning for your switch."},{"line_number":678,"context_line":"   Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify/add the following::"},{"line_number":679,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_541c4213","line":676,"in_reply_to":"1aa78d24_39073dcb","updated":"2016-08-02 17:32:53.000000000","message":"I\u0027ll add the default_network_interface setting description, but I\u0027m not sure if we should mention the dhcp provider logic here, it will be deprecated next cycle, and whoever needs to uprade from dhcp providers can find this info in release notes.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"#. Install a compatible ML2 driver which supports Bare Metal provisioning for your switch."},{"line_number":678,"context_line":"   Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify/add the following::"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    [ml2_vendor]"}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_b9fb2dc0","line":677,"range":{"start_line":677,"start_character":3,"end_line":677,"end_character":10},"updated":"2016-07-13 02:28:43.000000000","message":"Install where?  Operators may take these instructions as literal steps, and if there is anything else they need to know, it should be expressed at this point, otherwise they might just install it right next to the conductor.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"#. Install a compatible ML2 driver which supports Bare Metal provisioning for your switch."},{"line_number":678,"context_line":"   Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify/add the following::"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    [ml2_vendor]"}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_0ab6308a","line":677,"range":{"start_line":677,"start_character":3,"end_line":677,"end_character":10},"in_reply_to":"1aa78d24_b9fb2dc0","updated":"2016-07-15 18:02:48.000000000","message":"Agree.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    ironic node-create -n $NAME --network-interface neutron"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"#. Install a compatible ML2 driver which supports Bare Metal provisioning for your switch."},{"line_number":678,"context_line":"   Edit ``/etc/neutron/plugins/ml2/ml2_conf.ini`` and modify/add the following::"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    [ml2_vendor]"}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_c99edfb7","line":677,"range":{"start_line":677,"start_character":3,"end_line":677,"end_character":10},"in_reply_to":"fad55976_0ab6308a","updated":"2016-08-02 17:32:53.000000000","message":"I\u0027ve added a reference to networking configuration guide instead.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":682,"context_line":"    param_2\u003d..."},{"line_number":683,"context_line":"    param_3\u003d..."},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"#. Restart the ironic conductor after the modifications::"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"    Fedora/RHEL7/CentOS7:"},{"line_number":688,"context_line":"      sudo systemctl restart openstack-ironic-conductor"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    Ubuntu:"},{"line_number":691,"context_line":"      sudo service ironic-conductor restart"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"#. Make sure that the tftp server is reachable over the provisioning network,"},{"line_number":694,"context_line":"   by trying to download a file from it::"}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_5927a962","line":691,"range":{"start_line":685,"start_character":0,"end_line":691,"end_character":43},"updated":"2016-07-13 02:28:43.000000000","message":"Seems like ML2 should be in-place before the conductor is ever restarted...","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":690,"context_line":"    Ubuntu:"},{"line_number":691,"context_line":"      sudo service ironic-conductor restart"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"#. Make sure that the tftp server is reachable over the provisioning network,"},{"line_number":694,"context_line":"   by trying to download a file from it::"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"    tftp $TFTP_IP -c get $FILENAME"},{"line_number":697,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_79a9c58f","line":694,"range":{"start_line":693,"start_character":0,"end_line":694,"end_character":41},"updated":"2016-07-13 02:28:43.000000000","message":"It would likely be a good idea to suggest that the operator explicitly does not attempt this from the conductor, but attempts the configuration sanity check from another node that is somehow attached to the network, but not on a control-plane node.\n\nIt might seem silly, we may also want to explicitly state that the conductor nodes will need to be accessible from the provisioning network, ?either via direct attachment, or logical connectivity.?","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":690,"context_line":"    Ubuntu:"},{"line_number":691,"context_line":"      sudo service ironic-conductor restart"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"#. Make sure that the tftp server is reachable over the provisioning network,"},{"line_number":694,"context_line":"   by trying to download a file from it::"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"    tftp $TFTP_IP -c get $FILENAME"},{"line_number":697,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_74950687","line":694,"range":{"start_line":693,"start_character":0,"end_line":694,"end_character":41},"in_reply_to":"1aa78d24_79a9c58f","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    tftp $TFTP_IP -c get $FILENAME"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"   where FILENAME is the file located at the tftp server."},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"#. A portgroup is a link aggregation, where multiple interfaces on the bare metal server"},{"line_number":701,"context_line":"   connect to switch ports of a single LAG and belong to the same network. Please remember,"},{"line_number":702,"context_line":"   as said, that this doesn\u0027t work if interfaces belong to multiple networks."}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_9992b155","line":699,"updated":"2016-07-13 02:28:43.000000000","message":"nit: I kind of feel like portgroups is a sub topic of tenant networking and should be logically separated instead of a singular list of instructions.  I\u0027m thinking this because the number one documentation gripe I hear from operators is that they need ordered lists of steps that are explicit to what they are trying to do, in order to best comprehend the required actions.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6bf1635235b2e7bfa3a2f6b377f8036550ef0f68","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    tftp $TFTP_IP -c get $FILENAME"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"   where FILENAME is the file located at the tftp server."},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"#. A portgroup is a link aggregation, where multiple interfaces on the bare metal server"},{"line_number":701,"context_line":"   connect to switch ports of a single LAG and belong to the same network. Please remember,"},{"line_number":702,"context_line":"   as said, that this doesn\u0027t work if interfaces belong to multiple networks."}],"source_content_type":"text/x-rst","patch_set":85,"id":"bacf61ea_c9153f9c","line":699,"in_reply_to":"1aa78d24_9992b155","updated":"2016-08-02 17:32:53.000000000","message":"Done","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"   where FILENAME is the file located at the tftp server."},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"#. A portgroup is a link aggregation, where multiple interfaces on the bare metal server"},{"line_number":701,"context_line":"   connect to switch ports of a single LAG and belong to the same network. Please remember,"},{"line_number":702,"context_line":"   as said, that this doesn\u0027t work if interfaces belong to multiple networks."},{"line_number":703,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_39df3d0e","line":700,"range":{"start_line":700,"start_character":20,"end_line":700,"end_character":36},"updated":"2016-07-13 02:28:43.000000000","message":"nit: We should likely explain note that link aggregation \u003d\u003d LAG as line 701 uses LAG with no prior context and the reader may not know what that means in this context.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"#. A portgroup is a link aggregation, where multiple interfaces on the bare metal server"},{"line_number":701,"context_line":"   connect to switch ports of a single LAG and belong to the same network. Please remember,"},{"line_number":702,"context_line":"   as said, that this doesn\u0027t work if interfaces belong to multiple networks."},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"   Create a portgroup in ironic::"},{"line_number":705,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_79aee581","line":702,"range":{"start_line":702,"start_character":17,"end_line":702,"end_character":21},"updated":"2016-07-13 02:28:43.000000000","message":"Can we clarify what this refers to?  I think it means link aggregation.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"#. A portgroup is a link aggregation, where multiple interfaces on the bare metal server"},{"line_number":701,"context_line":"   connect to switch ports of a single LAG and belong to the same network. Please remember,"},{"line_number":702,"context_line":"   as said, that this doesn\u0027t work if interfaces belong to multiple networks."},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"   Create a portgroup in ironic::"},{"line_number":705,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_99c75144","line":702,"range":{"start_line":702,"start_character":38,"end_line":702,"end_character":48},"updated":"2016-07-13 02:28:43.000000000","message":"Interfaces seems confusing in this statement.  Is it referring to the node\u0027s ports?","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"#. A portgroup is a link aggregation, where multiple interfaces on the bare metal server"},{"line_number":701,"context_line":"   connect to switch ports of a single LAG and belong to the same network. Please remember,"},{"line_number":702,"context_line":"   as said, that this doesn\u0027t work if interfaces belong to multiple networks."},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"   Create a portgroup in ironic::"},{"line_number":705,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_7980a5f7","line":702,"range":{"start_line":702,"start_character":22,"end_line":702,"end_character":29},"updated":"2016-07-13 02:28:43.000000000","message":"nit: s/doesn\u0027t/does not/","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":703,"context_line":""},{"line_number":704,"context_line":"   Create a portgroup in ironic::"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    ironic portgroup-create --ironic-api-version 1.17 -n $NODE_UUID \\"},{"line_number":707,"context_line":"    -a $NEW_MAC_ADDRESS --name $NAME"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"#. If using a portgroup, create a port as following::"}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_79e545da","line":706,"range":{"start_line":706,"start_character":27,"end_line":706,"end_character":53},"updated":"2016-07-13 02:28:43.000000000","message":"Ideally, for example commands, we should likely suggest use of the environment variable so the example commands do not have the \"--ironic-api-version\" setting on every single line.  Also, the version needs to be updated.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"dca9417d841c000c93bf775457a39f1cfbb3a7ef","unresolved":false,"context_lines":[{"line_number":706,"context_line":"    ironic portgroup-create --ironic-api-version 1.17 -n $NODE_UUID \\"},{"line_number":707,"context_line":"    -a $NEW_MAC_ADDRESS --name $NAME"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"#. If using a portgroup, create a port as following::"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    ironic --ironic-api-version 1.17 port-create -a $HW_MAC_ADDRESS \\"},{"line_number":712,"context_line":"    -n $NODE_UUID -l switch_id\u003d$SWITCH_MAC_ADDRESS \\"}],"source_content_type":"text/x-rst","patch_set":85,"id":"fad55976_c58c0938","line":709,"range":{"start_line":709,"start_character":39,"end_line":709,"end_character":51},"updated":"2016-07-15 18:02:48.000000000","message":"\"as follows\"","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":706,"context_line":"    ironic portgroup-create --ironic-api-version 1.17 -n $NODE_UUID \\"},{"line_number":707,"context_line":"    -a $NEW_MAC_ADDRESS --name $NAME"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"#. If using a portgroup, create a port as following::"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    ironic --ironic-api-version 1.17 port-create -a $HW_MAC_ADDRESS \\"},{"line_number":712,"context_line":"    -n $NODE_UUID -l switch_id\u003d$SWITCH_MAC_ADDRESS \\"}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_79cf0529","line":709,"range":{"start_line":709,"start_character":3,"end_line":709,"end_character":51},"updated":"2016-07-13 02:28:43.000000000","message":"We likely need to have an example of port creation where it is not part of a portgroup.","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"#. If using a portgroup, create a port as following::"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    ironic --ironic-api-version 1.17 port-create -a $HW_MAC_ADDRESS \\"},{"line_number":712,"context_line":"    -n $NODE_UUID -l switch_id\u003d$SWITCH_MAC_ADDRESS \\"},{"line_number":713,"context_line":"    -l switch_info\u003d$SWITCH_HOSTNAME -l port_id\u003d$SWITCH_PORT \\"},{"line_number":714,"context_line":"    --portgroup-uuid $PORTGROUP_UUID --pxe-enabled true"}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_99ce3158","line":711,"range":{"start_line":711,"start_character":11,"end_line":711,"end_character":36},"updated":"2016-07-13 02:28:43.000000000","message":"ditto","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":715,"context_line":""},{"line_number":716,"context_line":"#. Check the port configuration::"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"    ironic --ironic-api-version 1.17 port-show $PORT_UUID"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"#. Update portgroup membership::"},{"line_number":721,"context_line":""}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_f9d93523","line":718,"range":{"start_line":718,"start_character":11,"end_line":718,"end_character":36},"updated":"2016-07-13 02:28:43.000000000","message":"ditto","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a153696b2a5fb2f4c41ed3c2a57cec3c3b7860c4","unresolved":false,"context_lines":[{"line_number":719,"context_line":""},{"line_number":720,"context_line":"#. Update portgroup membership::"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    ironic --ironic-api-version 1.17 port-update $PORT_UUID replace \\"},{"line_number":723,"context_line":"    portgroup_uuid\u003d$NEW_PORTGROUP_UUID"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":".. _CleaningNetworkSetup:"}],"source_content_type":"text/x-rst","patch_set":85,"id":"1aa78d24_39061d86","line":722,"range":{"start_line":722,"start_character":11,"end_line":722,"end_character":36},"updated":"2016-07-13 02:28:43.000000000","message":"ditto","commit_id":"4ab377c4de36a1b16675e43c30f38b775a75ca04"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1952b41ef3e7cf45638b34fa5f99d345da3b244c","unresolved":false,"context_lines":[{"line_number":649,"context_line":"- ``noop`` interface is used for standalone deployments, and does not perform"},{"line_number":650,"context_line":"  any network switching;"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"- ``flat`` interface allows node provisioning in the flat network;"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"- ``neutron`` interface that provides the tenant isolation."},{"line_number":655,"context_line":""}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_afe60b42","line":652,"updated":"2016-08-02 17:47:31.000000000","message":"let\u0027s clarify this:\n\n  ``flat`` interface places all provisioned nodes into a \n  single layer 2 network, separated from the provisioning\n  and cleaning networks.","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f50663620b7b861e62bb4a566ea095fa503a5287","unresolved":false,"context_lines":[{"line_number":649,"context_line":"- ``noop`` interface is used for standalone deployments, and does not perform"},{"line_number":650,"context_line":"  any network switching;"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"- ``flat`` interface allows node provisioning in the flat network;"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"- ``neutron`` interface that provides the tenant isolation."},{"line_number":655,"context_line":""}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_11c5955a","line":652,"in_reply_to":"bacf61ea_afe60b42","updated":"2016-08-03 11:31:17.000000000","message":"Done, but separated only from cleaning here.","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1952b41ef3e7cf45638b34fa5f99d345da3b244c","unresolved":false,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"- ``flat`` interface allows node provisioning in the flat network;"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"- ``neutron`` interface that provides the tenant isolation."},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"Below is an example flow of how to setup ironic so that node provisioning will"},{"line_number":657,"context_line":"happen in a multitenant environment:"}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_af544bca","line":654,"updated":"2016-08-02 17:47:31.000000000","message":"``neutron`` interface provides for tenant-defined networking\nby integrating with neutron, while also separating tenant\nnetworks from the provisioning and cleaning provider networks.","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f50663620b7b861e62bb4a566ea095fa503a5287","unresolved":false,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"- ``flat`` interface allows node provisioning in the flat network;"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"- ``neutron`` interface that provides the tenant isolation."},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"Below is an example flow of how to setup ironic so that node provisioning will"},{"line_number":657,"context_line":"happen in a multitenant environment:"}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_512f0df6","line":654,"in_reply_to":"bacf61ea_af544bca","updated":"2016-08-03 11:31:17.000000000","message":"Done","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1952b41ef3e7cf45638b34fa5f99d345da3b244c","unresolved":false,"context_lines":[{"line_number":656,"context_line":"Below is an example flow of how to setup ironic so that node provisioning will"},{"line_number":657,"context_line":"happen in a multitenant environment:"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"#. Create a provisioning network in neutron and add it in under the neutron"},{"line_number":660,"context_line":"   section in ironic-conductor configuration file. Using ``neutron`` network"},{"line_number":661,"context_line":"   interface requires that ``provision_network_uuid`` and"},{"line_number":662,"context_line":"   ``cleaning_network_uuid`` configuration options are set to a valid"}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_af19eb24","line":659,"updated":"2016-08-02 17:47:31.000000000","message":"Define a provider network in neutron, which we shall refer to as the \"provisioning\" network, and add it ...","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f50663620b7b861e62bb4a566ea095fa503a5287","unresolved":false,"context_lines":[{"line_number":656,"context_line":"Below is an example flow of how to setup ironic so that node provisioning will"},{"line_number":657,"context_line":"happen in a multitenant environment:"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"#. Create a provisioning network in neutron and add it in under the neutron"},{"line_number":660,"context_line":"   section in ironic-conductor configuration file. Using ``neutron`` network"},{"line_number":661,"context_line":"   interface requires that ``provision_network_uuid`` and"},{"line_number":662,"context_line":"   ``cleaning_network_uuid`` configuration options are set to a valid"}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_f153a16a","line":659,"in_reply_to":"bacf61ea_af19eb24","updated":"2016-08-03 11:31:17.000000000","message":"Done","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1952b41ef3e7cf45638b34fa5f99d345da3b244c","unresolved":false,"context_lines":[{"line_number":660,"context_line":"   section in ironic-conductor configuration file. Using ``neutron`` network"},{"line_number":661,"context_line":"   interface requires that ``provision_network_uuid`` and"},{"line_number":662,"context_line":"   ``cleaning_network_uuid`` configuration options are set to a valid"},{"line_number":663,"context_line":"   neutron network UUID, otherwise ironic-conductor will fail to start::"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    [neutron]"},{"line_number":666,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_0fe117ff","line":663,"updated":"2016-08-02 17:47:31.000000000","message":"The \"provisioning\" and \"cleaning\" networks may be the same neutron provider network, or may be distinct networks.","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f50663620b7b861e62bb4a566ea095fa503a5287","unresolved":false,"context_lines":[{"line_number":660,"context_line":"   section in ironic-conductor configuration file. Using ``neutron`` network"},{"line_number":661,"context_line":"   interface requires that ``provision_network_uuid`` and"},{"line_number":662,"context_line":"   ``cleaning_network_uuid`` configuration options are set to a valid"},{"line_number":663,"context_line":"   neutron network UUID, otherwise ironic-conductor will fail to start::"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    [neutron]"},{"line_number":666,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_915ea574","line":663,"in_reply_to":"bacf61ea_0fe117ff","updated":"2016-08-03 11:31:17.000000000","message":"Done","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1952b41ef3e7cf45638b34fa5f99d345da3b244c","unresolved":false,"context_lines":[{"line_number":665,"context_line":"    [neutron]"},{"line_number":666,"context_line":"    ..."},{"line_number":667,"context_line":"    cleaning_network_uuid\u003d$CLEAN_UUID"},{"line_number":668,"context_line":"    provisioning_network_uuid\u003d$PROVISION_UUID"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"   Please refer to `CleaningNetworkSetup`_ for more information about cleaning."},{"line_number":671,"context_line":""}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_4fe30f06","line":668,"range":{"start_line":668,"start_character":29,"end_line":668,"end_character":45},"updated":"2016-08-02 17:47:31.000000000","message":"it\u0027s worth noting that these may be the same, or may be different","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f50663620b7b861e62bb4a566ea095fa503a5287","unresolved":false,"context_lines":[{"line_number":665,"context_line":"    [neutron]"},{"line_number":666,"context_line":"    ..."},{"line_number":667,"context_line":"    cleaning_network_uuid\u003d$CLEAN_UUID"},{"line_number":668,"context_line":"    provisioning_network_uuid\u003d$PROVISION_UUID"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"   Please refer to `CleaningNetworkSetup`_ for more information about cleaning."},{"line_number":671,"context_line":""}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_d1501d61","line":668,"range":{"start_line":668,"start_character":29,"end_line":668,"end_character":45},"in_reply_to":"bacf61ea_4fe30f06","updated":"2016-08-03 11:31:17.000000000","message":"Done","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1952b41ef3e7cf45638b34fa5f99d345da3b244c","unresolved":false,"context_lines":[{"line_number":681,"context_line":"   ironic-api configuration file too, as its value is used on the API side to"},{"line_number":682,"context_line":"   check if the requested network interface is available."},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"#. It is also possible to set the default network interface via"},{"line_number":685,"context_line":"   ``default_network_interface`` configuration option under the default"},{"line_number":686,"context_line":"   section::"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_ef864315","line":684,"updated":"2016-08-02 17:47:31.000000000","message":"I suggest s/also possible/recommended/","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f50663620b7b861e62bb4a566ea095fa503a5287","unresolved":false,"context_lines":[{"line_number":681,"context_line":"   ironic-api configuration file too, as its value is used on the API side to"},{"line_number":682,"context_line":"   check if the requested network interface is available."},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"#. It is also possible to set the default network interface via"},{"line_number":685,"context_line":"   ``default_network_interface`` configuration option under the default"},{"line_number":686,"context_line":"   section::"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_f1da81e8","line":684,"in_reply_to":"bacf61ea_ef864315","updated":"2016-08-03 11:31:17.000000000","message":"Done","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1952b41ef3e7cf45638b34fa5f99d345da3b244c","unresolved":false,"context_lines":[{"line_number":712,"context_line":"   example, set it to ``neutron`` to use neutron ML2 driver::"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    ironic --ironic-api-version 1.20 node-create \\"},{"line_number":715,"context_line":"    --network-interface neutron --driver agent-ipmitool"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"#. Make sure that the conductor is reachable over the provisioning network"},{"line_number":718,"context_line":"   by trying to download a file from a TFTP server on it, from some"}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_8f722748","line":715,"updated":"2016-08-02 17:47:31.000000000","message":"let\u0027s add a note here that, if default_network_interface was set, the --network-interface option does not need to be specified when defining the node","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f50663620b7b861e62bb4a566ea095fa503a5287","unresolved":false,"context_lines":[{"line_number":712,"context_line":"   example, set it to ``neutron`` to use neutron ML2 driver::"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    ironic --ironic-api-version 1.20 node-create \\"},{"line_number":715,"context_line":"    --network-interface neutron --driver agent-ipmitool"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"#. Make sure that the conductor is reachable over the provisioning network"},{"line_number":718,"context_line":"   by trying to download a file from a TFTP server on it, from some"}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_71621118","line":715,"in_reply_to":"bacf61ea_8f722748","updated":"2016-08-03 11:31:17.000000000","message":"Done","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1952b41ef3e7cf45638b34fa5f99d345da3b244c","unresolved":false,"context_lines":[{"line_number":724,"context_line":""},{"line_number":725,"context_line":"#. Create a port as follows::"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"    ironic --ironic-api-version 1.19 port-create -a $HW_MAC_ADDRESS \\"},{"line_number":728,"context_line":"    -n $NODE_UUID -l switch_id\u003d$SWITCH_MAC_ADDRESS \\"},{"line_number":729,"context_line":"    -l switch_info\u003d$SWITCH_HOSTNAME -l port_id\u003d$SWITCH_PORT \\"},{"line_number":730,"context_line":"    --pxe-enabled true"}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_2ffdfb6e","line":727,"updated":"2016-08-02 17:47:31.000000000","message":"all the examples could use the same API version, 1.20, which could be set at the beginning of the example series, rather than on every line.\n\nI suggest adding the following section at the top of this:\n\n  #. Network interface support was added prior to the 1.20\n  API version. These examples assume you are using a recent release\n  of the python-ironicclient package and that you have set the\n  following variable in your shell environment:\n\n    export IRONIC_API_VERSION\u003d1.20","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f50663620b7b861e62bb4a566ea095fa503a5287","unresolved":false,"context_lines":[{"line_number":724,"context_line":""},{"line_number":725,"context_line":"#. Create a port as follows::"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"    ironic --ironic-api-version 1.19 port-create -a $HW_MAC_ADDRESS \\"},{"line_number":728,"context_line":"    -n $NODE_UUID -l switch_id\u003d$SWITCH_MAC_ADDRESS \\"},{"line_number":729,"context_line":"    -l switch_info\u003d$SWITCH_HOSTNAME -l port_id\u003d$SWITCH_PORT \\"},{"line_number":730,"context_line":"    --pxe-enabled true"}],"source_content_type":"text/x-rst","patch_set":86,"id":"bacf61ea_ac7b927a","line":727,"in_reply_to":"bacf61ea_2ffdfb6e","updated":"2016-08-03 11:31:17.000000000","message":"Done","commit_id":"4e29007c32135621b9f0004e4d79acb89a017243"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6310d4e69fa7ace6ff6ef11de56c06d1d5b22fc6","unresolved":false,"context_lines":[{"line_number":641,"context_line":"conjunction with neutron to allow provisioning of the Bare Metal server in"},{"line_number":642,"context_line":"a separate provisioning network. The result of this is that multiple tenants"},{"line_number":643,"context_line":"can now use nodes in an isolated fashion. However, this configuration supports"},{"line_number":644,"context_line":"neither trunk ports belonging to multiple networks, nor bare metal servers with"},{"line_number":645,"context_line":"multiple interfaces belonging to different networks."},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"Currently there are 3 network interfaces available in ironic:"},{"line_number":648,"context_line":""}],"source_content_type":"text/x-rst","patch_set":87,"id":"bacf61ea_7fddb36f","line":645,"range":{"start_line":644,"start_character":52,"end_line":645,"end_character":51},"updated":"2016-08-03 13:54:19.000000000","message":"Well, this might be a bit confusing - we do support multiple interfaces attached to different switchports, and different networks on each. However, the NIC/network mapping is random and I think it needs to be on the same physical network.\n\nOr am I totally wrong? :)","commit_id":"c8416c973a06a4fd24d24c4c8032f3ae4c405d0e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0fa1e7e5373b5174ad29d4ea8bf46e4a5158e555","unresolved":false,"context_lines":[{"line_number":641,"context_line":"conjunction with neutron to allow provisioning of the Bare Metal server in"},{"line_number":642,"context_line":"a separate provisioning network. The result of this is that multiple tenants"},{"line_number":643,"context_line":"can now use nodes in an isolated fashion. However, this configuration supports"},{"line_number":644,"context_line":"neither trunk ports belonging to multiple networks, nor bare metal servers with"},{"line_number":645,"context_line":"multiple interfaces belonging to different networks."},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"Currently there are 3 network interfaces available in ironic:"},{"line_number":648,"context_line":""}],"source_content_type":"text/x-rst","patch_set":87,"id":"bacf61ea_8b77863a","line":645,"range":{"start_line":644,"start_character":52,"end_line":645,"end_character":51},"in_reply_to":"bacf61ea_7fddb36f","updated":"2016-08-03 15:39:47.000000000","message":"Yep, you\u0027re correct, I just dunno how to say that properly. I guess I\u0027ll just remove this part.","commit_id":"c8416c973a06a4fd24d24c4c8032f3ae4c405d0e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6310d4e69fa7ace6ff6ef11de56c06d1d5b22fc6","unresolved":false,"context_lines":[{"line_number":724,"context_line":""},{"line_number":725,"context_line":"#. Node\u0027s ``network_interface`` field should be set to valid network interface"},{"line_number":726,"context_line":"   that is used to switch between cleaning/provisioning/tenant networks. For"},{"line_number":727,"context_line":"   example, set it to ``neutron`` to use neutron ML2 driver::"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    ironic node-create --network-interface neutron --driver agent-ipmitool"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-rst","patch_set":87,"id":"bacf61ea_1f3e37da","line":727,"updated":"2016-08-03 13:54:19.000000000","message":"I\u0027d just change this to not imply another valid network interface that can do this. While it is pluggable, if someone is deploying ironic with an out-of-tree network interface, they can probably figure out how to use it. :)","commit_id":"c8416c973a06a4fd24d24c4c8032f3ae4c405d0e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0fa1e7e5373b5174ad29d4ea8bf46e4a5158e555","unresolved":false,"context_lines":[{"line_number":724,"context_line":""},{"line_number":725,"context_line":"#. Node\u0027s ``network_interface`` field should be set to valid network interface"},{"line_number":726,"context_line":"   that is used to switch between cleaning/provisioning/tenant networks. For"},{"line_number":727,"context_line":"   example, set it to ``neutron`` to use neutron ML2 driver::"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    ironic node-create --network-interface neutron --driver agent-ipmitool"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-rst","patch_set":87,"id":"bacf61ea_0b2ef6f9","line":727,"in_reply_to":"bacf61ea_1f3e37da","updated":"2016-08-03 15:39:47.000000000","message":"Done","commit_id":"c8416c973a06a4fd24d24c4c8032f3ae4c405d0e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6310d4e69fa7ace6ff6ef11de56c06d1d5b22fc6","unresolved":false,"context_lines":[{"line_number":750,"context_line":"      * - Field"},{"line_number":751,"context_line":"        - Description"},{"line_number":752,"context_line":"      * - ``switch_id``"},{"line_number":753,"context_line":"        - Required. Identifies a switch and can be an LLDP-based MAC address or"},{"line_number":754,"context_line":"          an OpenFlow-based ``datapath_id``."},{"line_number":755,"context_line":"      * - ``port_id``"},{"line_number":756,"context_line":"        - Required. Port ID on the switch, for example, Gig0/1."}],"source_content_type":"text/x-rst","patch_set":87,"id":"bacf61ea_7f0c9342","line":753,"updated":"2016-08-03 13:54:19.000000000","message":"s/LLDP-based//\n\nLLDP is just a method to help find this info, a MAC address is a MAC address no matter how it\u0027s discovered.","commit_id":"c8416c973a06a4fd24d24c4c8032f3ae4c405d0e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0fa1e7e5373b5174ad29d4ea8bf46e4a5158e555","unresolved":false,"context_lines":[{"line_number":750,"context_line":"      * - Field"},{"line_number":751,"context_line":"        - Description"},{"line_number":752,"context_line":"      * - ``switch_id``"},{"line_number":753,"context_line":"        - Required. Identifies a switch and can be an LLDP-based MAC address or"},{"line_number":754,"context_line":"          an OpenFlow-based ``datapath_id``."},{"line_number":755,"context_line":"      * - ``port_id``"},{"line_number":756,"context_line":"        - Required. Port ID on the switch, for example, Gig0/1."}],"source_content_type":"text/x-rst","patch_set":87,"id":"bacf61ea_8b3ae632","line":753,"in_reply_to":"bacf61ea_7f0c9342","updated":"2016-08-03 15:39:47.000000000","message":"Done","commit_id":"c8416c973a06a4fd24d24c4c8032f3ae4c405d0e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6310d4e69fa7ace6ff6ef11de56c06d1d5b22fc6","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        - Required. Port ID on the switch, for example, Gig0/1."},{"line_number":757,"context_line":"      * - ``switch_info``"},{"line_number":758,"context_line":"        - Optional. Used to distinguish different switch models or other"},{"line_number":759,"context_line":"          vendor specific-identifier."},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"   Create a port as follows::"},{"line_number":762,"context_line":""}],"source_content_type":"text/x-rst","patch_set":87,"id":"bacf61ea_8a13075c","line":759,"updated":"2016-08-03 13:54:19.000000000","message":"Maybe add something about some ML2 plugins may require this? That\u0027s the only reason it\u0027s there, right?","commit_id":"c8416c973a06a4fd24d24c4c8032f3ae4c405d0e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0fa1e7e5373b5174ad29d4ea8bf46e4a5158e555","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        - Required. Port ID on the switch, for example, Gig0/1."},{"line_number":757,"context_line":"      * - ``switch_info``"},{"line_number":758,"context_line":"        - Optional. Used to distinguish different switch models or other"},{"line_number":759,"context_line":"          vendor specific-identifier."},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"   Create a port as follows::"},{"line_number":762,"context_line":""}],"source_content_type":"text/x-rst","patch_set":87,"id":"bacf61ea_0b639642","line":759,"in_reply_to":"bacf61ea_8a13075c","updated":"2016-08-03 15:39:47.000000000","message":"Done, tho I changed it to \u0027some network interfaces\u0027 instead of ML2 plugins.","commit_id":"c8416c973a06a4fd24d24c4c8032f3ae4c405d0e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2816d262987edbe6a06fdf0250183a241c59368b","unresolved":false,"context_lines":[{"line_number":634,"context_line":"    --ip-version\u003d4 --gateway\u003d$GATEWAY_IP --allocation-pool \\"},{"line_number":635,"context_line":"    start\u003d$START_IP,end\u003d$END_IP --enable-dhcp"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"Configuring Tenant Networks"},{"line_number":638,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":639,"context_line":"This configuration allows to use a dedicated tenant network, which extends"},{"line_number":640,"context_line":"the current ironic capabilities of providing flat networks. This works in"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_59cd36b6","line":637,"range":{"start_line":637,"start_character":0,"end_line":637,"end_character":27},"updated":"2016-08-04 11:30:04.000000000","message":"please put the whole thing to a separate file, this file is too large already, and we anyway plan on splitting it.","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8274acd4a970deb6ecfe70aaded1e6b74d1ee1b3","unresolved":false,"context_lines":[{"line_number":634,"context_line":"    --ip-version\u003d4 --gateway\u003d$GATEWAY_IP --allocation-pool \\"},{"line_number":635,"context_line":"    start\u003d$START_IP,end\u003d$END_IP --enable-dhcp"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"Configuring Tenant Networks"},{"line_number":638,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":639,"context_line":"This configuration allows to use a dedicated tenant network, which extends"},{"line_number":640,"context_line":"the current ironic capabilities of providing flat networks. This works in"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_249da766","line":637,"range":{"start_line":637,"start_character":0,"end_line":637,"end_character":27},"in_reply_to":"bacf61ea_59cd36b6","updated":"2016-08-04 18:08:24.000000000","message":"Done","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6bcf383a10e7506d888b7a3957351d4c01b18582","unresolved":false,"context_lines":[{"line_number":686,"context_line":""},{"line_number":687,"context_line":"   Please note that ``enabled_network_interfaces`` has to be set in the"},{"line_number":688,"context_line":"   ironic-api configuration file too, as its value is used on the API side to"},{"line_number":689,"context_line":"   check if the requested network interface is available."},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"#. It is recommended to set the default network interface via"},{"line_number":692,"context_line":"   ``default_network_interface`` configuration option under the default"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_f28d18d4","line":689,"updated":"2016-08-04 14:45:07.000000000","message":"Please add that all ironic-conductor\u0027s should share the same value, otherwise it might lead to errors in future.","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8274acd4a970deb6ecfe70aaded1e6b74d1ee1b3","unresolved":false,"context_lines":[{"line_number":686,"context_line":""},{"line_number":687,"context_line":"   Please note that ``enabled_network_interfaces`` has to be set in the"},{"line_number":688,"context_line":"   ironic-api configuration file too, as its value is used on the API side to"},{"line_number":689,"context_line":"   check if the requested network interface is available."},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"#. It is recommended to set the default network interface via"},{"line_number":692,"context_line":"   ``default_network_interface`` configuration option under the default"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_d032825d","line":689,"in_reply_to":"bacf61ea_f28d18d4","updated":"2016-08-04 18:08:24.000000000","message":"Done","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6bcf383a10e7506d888b7a3957351d4c01b18582","unresolved":false,"context_lines":[{"line_number":688,"context_line":"   ironic-api configuration file too, as its value is used on the API side to"},{"line_number":689,"context_line":"   check if the requested network interface is available."},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"#. It is recommended to set the default network interface via"},{"line_number":692,"context_line":"   ``default_network_interface`` configuration option under the default"},{"line_number":693,"context_line":"   section::"},{"line_number":694,"context_line":""}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_6d0b0d25","line":691,"updated":"2016-08-04 14:45:07.000000000","message":"Please add a default interface selection logic to documentation as well, it would be helpful for users, who missed release notes.\n\n1) node.network_interface, if that is None:\n2) CONF.default_network_interface, if that isNone:\n3) flat, if using neutron DHCP\n4) noop, if not using neutron DHCP","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8274acd4a970deb6ecfe70aaded1e6b74d1ee1b3","unresolved":false,"context_lines":[{"line_number":688,"context_line":"   ironic-api configuration file too, as its value is used on the API side to"},{"line_number":689,"context_line":"   check if the requested network interface is available."},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"#. It is recommended to set the default network interface via"},{"line_number":692,"context_line":"   ``default_network_interface`` configuration option under the default"},{"line_number":693,"context_line":"   section::"},{"line_number":694,"context_line":""}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_b3cc38bc","line":691,"in_reply_to":"bacf61ea_6d0b0d25","updated":"2016-08-04 18:08:24.000000000","message":"Done","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6bcf383a10e7506d888b7a3957351d4c01b18582","unresolved":false,"context_lines":[{"line_number":699,"context_line":"   It will be used for all nodes that will be created without explicitly"},{"line_number":700,"context_line":"   specifying the network interface."},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"#. Install and configure a compatible ML2 mechanism driver which supports bare"},{"line_number":703,"context_line":"   metal provisioning for your switch. See `ML2 plugin configuration manual"},{"line_number":704,"context_line":"   \u003chttp://docs.openstack.org/networking-guide/config-ml2-plug-in.html\u003e`_"},{"line_number":705,"context_line":"   for details."}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_2def551f","line":702,"updated":"2016-08-04 14:45:07.000000000","message":"It is only related to Neutron driver, might be move it to the \u0027neutron\u0027 interface description section?","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8274acd4a970deb6ecfe70aaded1e6b74d1ee1b3","unresolved":false,"context_lines":[{"line_number":699,"context_line":"   It will be used for all nodes that will be created without explicitly"},{"line_number":700,"context_line":"   specifying the network interface."},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"#. Install and configure a compatible ML2 mechanism driver which supports bare"},{"line_number":703,"context_line":"   metal provisioning for your switch. See `ML2 plugin configuration manual"},{"line_number":704,"context_line":"   \u003chttp://docs.openstack.org/networking-guide/config-ml2-plug-in.html\u003e`_"},{"line_number":705,"context_line":"   for details."}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_90d48a20","line":702,"in_reply_to":"bacf61ea_2def551f","updated":"2016-08-04 18:08:24.000000000","message":"This whole section is about enabling multitenancy, and the only interface that supports it right now in tree is neutron, so I think it\u0027s fine to have it here.","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6bcf383a10e7506d888b7a3957351d4c01b18582","unresolved":false,"context_lines":[{"line_number":703,"context_line":"   metal provisioning for your switch. See `ML2 plugin configuration manual"},{"line_number":704,"context_line":"   \u003chttp://docs.openstack.org/networking-guide/config-ml2-plug-in.html\u003e`_"},{"line_number":705,"context_line":"   for details."},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"#. Restart the ironic conductor after the modifications:"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"   - Fedora/RHEL7/CentOS7::"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_0dbc1105","line":706,"updated":"2016-08-04 14:45:07.000000000","message":"I think our documentation should already contain section that describe how to restart service, lets add a link there.","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8274acd4a970deb6ecfe70aaded1e6b74d1ee1b3","unresolved":false,"context_lines":[{"line_number":703,"context_line":"   metal provisioning for your switch. See `ML2 plugin configuration manual"},{"line_number":704,"context_line":"   \u003chttp://docs.openstack.org/networking-guide/config-ml2-plug-in.html\u003e`_"},{"line_number":705,"context_line":"   for details."},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"#. Restart the ironic conductor after the modifications:"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"   - Fedora/RHEL7/CentOS7::"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_a432375c","line":706,"in_reply_to":"bacf61ea_0dbc1105","updated":"2016-08-04 18:08:24.000000000","message":"There is no such section, it\u0027s just added everywhere. Might be refactored later.","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6bcf383a10e7506d888b7a3957351d4c01b18582","unresolved":false,"context_lines":[{"line_number":716,"context_line":""},{"line_number":717,"context_line":"#. Multitenancy support was added prior to the 1.20 API version. The following"},{"line_number":718,"context_line":"   examples assume you are using a recent release of the python-ironicclient"},{"line_number":719,"context_line":"   package and that you have set the following variable in your shell"},{"line_number":720,"context_line":"   environment::"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    export IRONIC_API_VERSION\u003d1.20"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_cdfaf9bc","line":719,"updated":"2016-08-04 14:45:07.000000000","message":"OSC plugin already implements this functionality, might be replace ironic with openstack? or add OSC examples, might be done in separate patch.","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8274acd4a970deb6ecfe70aaded1e6b74d1ee1b3","unresolved":false,"context_lines":[{"line_number":716,"context_line":""},{"line_number":717,"context_line":"#. Multitenancy support was added prior to the 1.20 API version. The following"},{"line_number":718,"context_line":"   examples assume you are using a recent release of the python-ironicclient"},{"line_number":719,"context_line":"   package and that you have set the following variable in your shell"},{"line_number":720,"context_line":"   environment::"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    export IRONIC_API_VERSION\u003d1.20"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_c45c8b4d","line":719,"in_reply_to":"bacf61ea_cdfaf9bc","updated":"2016-08-04 18:08:24.000000000","message":"Hm, dunno, I\u0027ll add both options to the examples then.","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2816d262987edbe6a06fdf0250183a241c59368b","unresolved":false,"context_lines":[{"line_number":719,"context_line":"   package and that you have set the following variable in your shell"},{"line_number":720,"context_line":"   environment::"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    export IRONIC_API_VERSION\u003d1.20"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"#. Node\u0027s ``network_interface`` field should be set to valid network interface"},{"line_number":725,"context_line":"   that is used to switch between cleaning/provisioning/tenant networks. Set it"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_7958fafa","line":722,"updated":"2016-08-04 11:30:04.000000000","message":"for using the OSC plugin, the export should be different. let\u0027s recommend both just in case:\n\n export IRONIC_API_VERSION\u003d1.20\n export OS_BAREMETAL_API_VERSION\u003d1.20","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8274acd4a970deb6ecfe70aaded1e6b74d1ee1b3","unresolved":false,"context_lines":[{"line_number":719,"context_line":"   package and that you have set the following variable in your shell"},{"line_number":720,"context_line":"   environment::"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    export IRONIC_API_VERSION\u003d1.20"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"#. Node\u0027s ``network_interface`` field should be set to valid network interface"},{"line_number":725,"context_line":"   that is used to switch between cleaning/provisioning/tenant networks. Set it"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_e46eef2d","line":722,"in_reply_to":"bacf61ea_7958fafa","updated":"2016-08-04 18:08:24.000000000","message":"I was thinking about that but all the examples contain only ironic command, which does not respect the OSC variable.","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6bcf383a10e7506d888b7a3957351d4c01b18582","unresolved":false,"context_lines":[{"line_number":722,"context_line":"    export IRONIC_API_VERSION\u003d1.20"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"#. Node\u0027s ``network_interface`` field should be set to valid network interface"},{"line_number":725,"context_line":"   that is used to switch between cleaning/provisioning/tenant networks. Set it"},{"line_number":726,"context_line":"   to ``neutron`` to use neutron ML2 driver::"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    ironic node-create --network-interface neutron --driver agent-ipmitool"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_ed141dea","line":725,"updated":"2016-08-04 14:45:07.000000000","message":"It is already mentioned at L664, lets not mentioned it twice.","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8274acd4a970deb6ecfe70aaded1e6b74d1ee1b3","unresolved":false,"context_lines":[{"line_number":722,"context_line":"    export IRONIC_API_VERSION\u003d1.20"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"#. Node\u0027s ``network_interface`` field should be set to valid network interface"},{"line_number":725,"context_line":"   that is used to switch between cleaning/provisioning/tenant networks. Set it"},{"line_number":726,"context_line":"   to ``neutron`` to use neutron ML2 driver::"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    ironic node-create --network-interface neutron --driver agent-ipmitool"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_700ab68b","line":725,"in_reply_to":"bacf61ea_ed141dea","updated":"2016-08-04 18:08:24.000000000","message":"Done","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"28ad547b2a2392c621658df97120b345ac536320","unresolved":false,"context_lines":[{"line_number":725,"context_line":"   that is used to switch between cleaning/provisioning/tenant networks. Set it"},{"line_number":726,"context_line":"   to ``neutron`` to use neutron ML2 driver::"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    ironic node-create --network-interface neutron --driver agent-ipmitool"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"   .. note::"},{"line_number":731,"context_line":"      If the ``default_network_interface`` was set, the ``--network-interface``"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_b62aa6e5","line":728,"updated":"2016-08-03 17:54:01.000000000","message":"Do we want to include an example for updating a node\u0027s network interface, for preexisting installations?","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8274acd4a970deb6ecfe70aaded1e6b74d1ee1b3","unresolved":false,"context_lines":[{"line_number":725,"context_line":"   that is used to switch between cleaning/provisioning/tenant networks. Set it"},{"line_number":726,"context_line":"   to ``neutron`` to use neutron ML2 driver::"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    ironic node-create --network-interface neutron --driver agent-ipmitool"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"   .. note::"},{"line_number":731,"context_line":"      If the ``default_network_interface`` was set, the ``--network-interface``"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_249127f2","line":728,"in_reply_to":"bacf61ea_790f5ae1","updated":"2016-08-04 18:08:24.000000000","message":"Umm, it\u0027s the same as any update, nothing is different. But will add anyway.","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2816d262987edbe6a06fdf0250183a241c59368b","unresolved":false,"context_lines":[{"line_number":725,"context_line":"   that is used to switch between cleaning/provisioning/tenant networks. Set it"},{"line_number":726,"context_line":"   to ``neutron`` to use neutron ML2 driver::"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    ironic node-create --network-interface neutron --driver agent-ipmitool"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"   .. note::"},{"line_number":731,"context_line":"      If the ``default_network_interface`` was set, the ``--network-interface``"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_790f5ae1","line":728,"in_reply_to":"bacf61ea_b62aa6e5","updated":"2016-08-04 11:30:04.000000000","message":"+1","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"28ad547b2a2392c621658df97120b345ac536320","unresolved":false,"context_lines":[{"line_number":728,"context_line":"    ironic node-create --network-interface neutron --driver agent-ipmitool"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"   .. note::"},{"line_number":731,"context_line":"      If the ``default_network_interface`` was set, the ``--network-interface``"},{"line_number":732,"context_line":"      option does not need to be specified when defining the node."},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"#. Make sure that the conductor is reachable over the provisioning network"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_b603c675","line":731,"updated":"2016-08-03 17:54:01.000000000","message":"was set in the config file?","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8274acd4a970deb6ecfe70aaded1e6b74d1ee1b3","unresolved":false,"context_lines":[{"line_number":728,"context_line":"    ironic node-create --network-interface neutron --driver agent-ipmitool"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"   .. note::"},{"line_number":731,"context_line":"      If the ``default_network_interface`` was set, the ``--network-interface``"},{"line_number":732,"context_line":"      option does not need to be specified when defining the node."},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"#. Make sure that the conductor is reachable over the provisioning network"}],"source_content_type":"text/x-rst","patch_set":88,"id":"bacf61ea_64bddf67","line":731,"in_reply_to":"bacf61ea_b603c675","updated":"2016-08-04 18:08:24.000000000","message":"Done","commit_id":"b6b339a162a993008d5b7f9e8778a8c7492a33a6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":675,"context_line":"    # UUID of the network to create Neutron ports on, when booting"},{"line_number":676,"context_line":"    # to a ramdisk for cleaning using Neutron DHCP. (string value)"},{"line_number":677,"context_line":"    #cleaning_network_uuid\u003d\u003cNone\u003e"},{"line_number":678,"context_line":"    cleaning_network_uuid \u003d NETWORK_UUID"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"#. Restart the Bare Metal service\u0027s ironic-conductor::"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_4608c72c","line":678,"updated":"2016-08-16 16:37:06.000000000","message":"Do we want to update the above two points? (The config comment definitely needs to be updated.)","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":675,"context_line":"    # UUID of the network to create Neutron ports on, when booting"},{"line_number":676,"context_line":"    # to a ramdisk for cleaning using Neutron DHCP. (string value)"},{"line_number":677,"context_line":"    #cleaning_network_uuid\u003d\u003cNone\u003e"},{"line_number":678,"context_line":"    cleaning_network_uuid \u003d NETWORK_UUID"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"#. Restart the Bare Metal service\u0027s ironic-conductor::"},{"line_number":681,"context_line":""}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_55ad9299","line":678,"in_reply_to":"3ac371cc_4608c72c","updated":"2016-08-18 13:51:32.000000000","message":"Hmm, they are describing cleaning specifically, so I think nothing has to be changed there. As for theconfig option comment, I\u0027d remove it completely, so that we don\u0027t have to sync the docs every time we update the description. The description can be seen in the sample.","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"}],"doc/source/deploy/multitenancy.rst":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8f5219b29f30d374c05d4725ad2c16b99a95410d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is possible to use a dedicated tenant network for provisioned nodes, which"},{"line_number":11,"context_line":"extends the current ironic capabilities of providing flat networks. This works"},{"line_number":12,"context_line":"in conjunction with neutron to allow provisioning of nodes in a separate"},{"line_number":13,"context_line":"provisioning network. The result of this is that multiple tenants can now use"}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_512c4a4a","line":10,"updated":"2016-08-15 13:18:09.000000000","message":"s/a dedicated tenant network/dedicated tenant networks/\n\nthere can be more than one tenant net :)","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a631d312bb5d5f43ca7d04747801f0118e2f70","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is possible to use a dedicated tenant network for provisioned nodes, which"},{"line_number":11,"context_line":"extends the current ironic capabilities of providing flat networks. This works"},{"line_number":12,"context_line":"in conjunction with neutron to allow provisioning of nodes in a separate"},{"line_number":13,"context_line":"provisioning network. The result of this is that multiple tenants can now use"}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_9cfed969","line":10,"in_reply_to":"3ac371cc_512c4a4a","updated":"2016-08-15 13:33:38.000000000","message":"Done","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8f5219b29f30d374c05d4725ad2c16b99a95410d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"   ironic-api configuration file too, as its value is used on the API side to"},{"line_number":66,"context_line":"   check if the requested network interface is available."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   Keep in mind that, ideally, all the conductors should have the same list of"},{"line_number":69,"context_line":"   enabled network interfaces, but it may not to be the case during the"},{"line_number":70,"context_line":"   conductor upgrades. This may cause problems if one of the conductors dies"},{"line_number":71,"context_line":"   and some node that is taken over is mapped to a conductor that does not"}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_11a0129f","line":68,"updated":"2016-08-15 13:18:09.000000000","message":"s/all the conductors/all conductors/","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a631d312bb5d5f43ca7d04747801f0118e2f70","unresolved":false,"context_lines":[{"line_number":65,"context_line":"   ironic-api configuration file too, as its value is used on the API side to"},{"line_number":66,"context_line":"   check if the requested network interface is available."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   Keep in mind that, ideally, all the conductors should have the same list of"},{"line_number":69,"context_line":"   enabled network interfaces, but it may not to be the case during the"},{"line_number":70,"context_line":"   conductor upgrades. This may cause problems if one of the conductors dies"},{"line_number":71,"context_line":"   and some node that is taken over is mapped to a conductor that does not"}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_7c031d74","line":68,"in_reply_to":"3ac371cc_11a0129f","updated":"2016-08-15 13:33:38.000000000","message":"Done","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8f5219b29f30d374c05d4725ad2c16b99a95410d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   check if the requested network interface is available."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   Keep in mind that, ideally, all the conductors should have the same list of"},{"line_number":69,"context_line":"   enabled network interfaces, but it may not to be the case during the"},{"line_number":70,"context_line":"   conductor upgrades. This may cause problems if one of the conductors dies"},{"line_number":71,"context_line":"   and some node that is taken over is mapped to a conductor that does not"},{"line_number":72,"context_line":"   support the node\u0027s network interface. Any actions that involve calling the"}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_31a6eec1","line":69,"updated":"2016-08-15 13:18:09.000000000","message":"s/may not to be/may not be/\n\ns/the conductor upgrades/conductor upgrades/","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a631d312bb5d5f43ca7d04747801f0118e2f70","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   check if the requested network interface is available."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   Keep in mind that, ideally, all the conductors should have the same list of"},{"line_number":69,"context_line":"   enabled network interfaces, but it may not to be the case during the"},{"line_number":70,"context_line":"   conductor upgrades. This may cause problems if one of the conductors dies"},{"line_number":71,"context_line":"   and some node that is taken over is mapped to a conductor that does not"},{"line_number":72,"context_line":"   support the node\u0027s network interface. Any actions that involve calling the"}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_dcf8517f","line":69,"in_reply_to":"3ac371cc_31a6eec1","updated":"2016-08-15 13:33:38.000000000","message":"Done","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8f5219b29f30d374c05d4725ad2c16b99a95410d","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   - Fedora/RHEL7/CentOS7::"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      sudo systemctl restart openstack-ironic-conductor"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"   - Ubuntu::"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_31bb8ec6","line":101,"updated":"2016-08-15 13:18:09.000000000","message":"Is this right? the \"openstack-\" prefix seems odd","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a631d312bb5d5f43ca7d04747801f0118e2f70","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   - Fedora/RHEL7/CentOS7::"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      sudo systemctl restart openstack-ironic-conductor"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"   - Ubuntu::"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_bcd8f5f0","line":101,"in_reply_to":"3ac371cc_31bb8ec6","updated":"2016-08-15 13:33:38.000000000","message":"Seems to be the case, it is like that in other fedora/centos related places.","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8f5219b29f30d374c05d4725ad2c16b99a95410d","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      sudo service ironic-conductor restart"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"#. Multitenancy support was added prior to the 1.20 API version. The following"},{"line_number":108,"context_line":"   examples assume you are using a recent release of the python-ironicclient"},{"line_number":109,"context_line":"   package. They show the usage of both ``ironic`` and ``openstack baremetal``"},{"line_number":110,"context_line":"   commands."}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_51dd6a13","line":107,"updated":"2016-08-15 13:18:09.000000000","message":"s/prior to/in/ ?","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a631d312bb5d5f43ca7d04747801f0118e2f70","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"      sudo service ironic-conductor restart"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"#. Multitenancy support was added prior to the 1.20 API version. The following"},{"line_number":108,"context_line":"   examples assume you are using a recent release of the python-ironicclient"},{"line_number":109,"context_line":"   package. They show the usage of both ``ironic`` and ``openstack baremetal``"},{"line_number":110,"context_line":"   commands."}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_5c2bc1eb","line":107,"in_reply_to":"3ac371cc_51dd6a13","updated":"2016-08-15 13:33:38.000000000","message":"Partially in 1.19 :) changed to 1.20 anyway.","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8f5219b29f30d374c05d4725ad2c16b99a95410d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    export OS_BAREMETAL_API_VERSION\u003d1.20"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"#. Node\u0027s ``network_interface`` field should be set to valid network interface"},{"line_number":123,"context_line":"   that is listed in the ``[DEFAULT]enabled_network_interfaces`` configuration"},{"line_number":124,"context_line":"   option in the ironic-api config. Set it to ``neutron`` to use neutron ML2"},{"line_number":125,"context_line":"   driver:"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_512baaeb","line":123,"updated":"2016-08-15 13:18:09.000000000","message":"nit: / after [DEFAULT]","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a631d312bb5d5f43ca7d04747801f0118e2f70","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    export OS_BAREMETAL_API_VERSION\u003d1.20"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"#. Node\u0027s ``network_interface`` field should be set to valid network interface"},{"line_number":123,"context_line":"   that is listed in the ``[DEFAULT]enabled_network_interfaces`` configuration"},{"line_number":124,"context_line":"   option in the ironic-api config. Set it to ``neutron`` to use neutron ML2"},{"line_number":125,"context_line":"   driver:"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_9c353948","line":123,"in_reply_to":"3ac371cc_512baaeb","updated":"2016-08-15 13:33:38.000000000","message":"Done","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8f5219b29f30d374c05d4725ad2c16b99a95410d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"      --driver agent-ipmitool"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   .. note::"},{"line_number":138,"context_line":"      If the ``[DEFAULT]default_network_interface`` configuration option was"},{"line_number":139,"context_line":"      set, the ``--network-interface`` option does not need to be specified"},{"line_number":140,"context_line":"      when defining the node."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_d13f9a23","line":138,"updated":"2016-08-15 13:18:09.000000000","message":"ditto, needs a /","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a631d312bb5d5f43ca7d04747801f0118e2f70","unresolved":false,"context_lines":[{"line_number":135,"context_line":"      --driver agent-ipmitool"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   .. note::"},{"line_number":138,"context_line":"      If the ``[DEFAULT]default_network_interface`` configuration option was"},{"line_number":139,"context_line":"      set, the ``--network-interface`` option does not need to be specified"},{"line_number":140,"context_line":"      when defining the node."},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_7c3afd37","line":138,"in_reply_to":"3ac371cc_d13f9a23","updated":"2016-08-15 13:33:38.000000000","message":"Done","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8f5219b29f30d374c05d4725ad2c16b99a95410d","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"   - ``ironic`` command::"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"      ironic node-update $NODE_UUID_OR_NAME add network_interface\u003dneutron"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"   - ``openstack`` command::"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_d16dda33","line":146,"updated":"2016-08-15 13:18:09.000000000","message":"s/add/replace/\n\nWe should always have network_interface set, so I don\u0027t think add works.","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a631d312bb5d5f43ca7d04747801f0118e2f70","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"   - ``ironic`` command::"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"      ironic node-update $NODE_UUID_OR_NAME add network_interface\u003dneutron"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"   - ``openstack`` command::"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_fc1d4dbe","line":146,"in_reply_to":"3ac371cc_d16dda33","updated":"2016-08-15 13:33:38.000000000","message":"\"add\" can both add and replace. can change if you feel that replace is better.","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8f5219b29f30d374c05d4725ad2c16b99a95410d","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"   where FILENAME is the file located at the TFTP server."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"#. Bare Metal service provides the ``local_link_connection`` information to the"},{"line_number":162,"context_line":"   Networking service ML2 driver. The ML2 driver uses that information to plug"},{"line_number":163,"context_line":"   the specified port to the tenant network."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_51c72a12","line":161,"updated":"2016-08-15 13:18:09.000000000","message":"The Bare Metal service","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a631d312bb5d5f43ca7d04747801f0118e2f70","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"   where FILENAME is the file located at the TFTP server."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"#. Bare Metal service provides the ``local_link_connection`` information to the"},{"line_number":162,"context_line":"   Networking service ML2 driver. The ML2 driver uses that information to plug"},{"line_number":163,"context_line":"   the specified port to the tenant network."},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_5c7901fc","line":161,"in_reply_to":"3ac371cc_51c72a12","updated":"2016-08-15 13:33:38.000000000","message":"Done","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8f5219b29f30d374c05d4725ad2c16b99a95410d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        - Required. Port ID on the switch, for example, Gig0/1."},{"line_number":175,"context_line":"      * - ``switch_info``"},{"line_number":176,"context_line":"        - Optional. Used to distinguish different switch models or other"},{"line_number":177,"context_line":"          vendor specific-identifier. Some network interfaces may require this"},{"line_number":178,"context_line":"          field."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"   Create a port as follows:"}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_71ed068b","line":177,"updated":"2016-08-15 13:18:09.000000000","message":"It\u0027s ML2 plugins that may require it, right? Not network interfaces?","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a631d312bb5d5f43ca7d04747801f0118e2f70","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        - Required. Port ID on the switch, for example, Gig0/1."},{"line_number":175,"context_line":"      * - ``switch_info``"},{"line_number":176,"context_line":"        - Optional. Used to distinguish different switch models or other"},{"line_number":177,"context_line":"          vendor specific-identifier. Some network interfaces may require this"},{"line_number":178,"context_line":"          field."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"   Create a port as follows:"}],"source_content_type":"text/x-rst","patch_set":90,"id":"3ac371cc_bc6ab518","line":177,"in_reply_to":"3ac371cc_71ed068b","updated":"2016-08-15 13:33:38.000000000","message":"Done","commit_id":"5e6c4f60f0d70d579fc3250df377bba3f464843b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is possible to use dedicated tenant networks for provisioned nodes, which"},{"line_number":11,"context_line":"extends the current ironic capabilities of providing flat networks. This works"},{"line_number":12,"context_line":"in conjunction with neutron to allow provisioning of nodes in a separate"}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_c1e821b7","line":9,"updated":"2016-08-16 16:37:06.000000000","message":"I wonder if it would be useful to mention that the Bare Metal service provides the ability to have separate provisioning, cleaning, and multiple tenant networks.\n\nI know it is mentioned here, but not explicitly.","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Overview"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is possible to use dedicated tenant networks for provisioned nodes, which"},{"line_number":11,"context_line":"extends the current ironic capabilities of providing flat networks. This works"},{"line_number":12,"context_line":"in conjunction with neutron to allow provisioning of nodes in a separate"}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_b5d4c6eb","line":9,"in_reply_to":"3ac371cc_c1e821b7","updated":"2016-08-18 13:51:32.000000000","message":"Yeah, this would basically duplicate the following paragraph so dunno, this wording was suggested by other folks so I\u0027d leave it for now, I think it\u0027s more or less clear from the text.","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is possible to use dedicated tenant networks for provisioned nodes, which"},{"line_number":11,"context_line":"extends the current ironic capabilities of providing flat networks. This works"},{"line_number":12,"context_line":"in conjunction with neutron to allow provisioning of nodes in a separate"},{"line_number":13,"context_line":"provisioning network. The result of this is that multiple tenants can now use"},{"line_number":14,"context_line":"nodes in an isolated fashion. However, this configuration does not support"}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_c12141a1","line":11,"updated":"2016-08-16 16:37:06.000000000","message":"s/ironic/Bare Metal service/","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is possible to use dedicated tenant networks for provisioned nodes, which"},{"line_number":11,"context_line":"extends the current ironic capabilities of providing flat networks. This works"},{"line_number":12,"context_line":"in conjunction with neutron to allow provisioning of nodes in a separate"},{"line_number":13,"context_line":"provisioning network. The result of this is that multiple tenants can now use"},{"line_number":14,"context_line":"nodes in an isolated fashion. However, this configuration does not support"}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_95f6ea8c","line":11,"in_reply_to":"3ac371cc_c12141a1","updated":"2016-08-18 13:51:32.000000000","message":"Done","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is possible to use dedicated tenant networks for provisioned nodes, which"},{"line_number":11,"context_line":"extends the current ironic capabilities of providing flat networks. This works"},{"line_number":12,"context_line":"in conjunction with neutron to allow provisioning of nodes in a separate"},{"line_number":13,"context_line":"provisioning network. The result of this is that multiple tenants can now use"},{"line_number":14,"context_line":"nodes in an isolated fashion. However, this configuration does not support"},{"line_number":15,"context_line":"trunk ports belonging to multiple networks."}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_a17245ab","line":12,"updated":"2016-08-16 16:37:06.000000000","message":"s/neutron/the Networking service/","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"It is possible to use dedicated tenant networks for provisioned nodes, which"},{"line_number":11,"context_line":"extends the current ironic capabilities of providing flat networks. This works"},{"line_number":12,"context_line":"in conjunction with neutron to allow provisioning of nodes in a separate"},{"line_number":13,"context_line":"provisioning network. The result of this is that multiple tenants can now use"},{"line_number":14,"context_line":"nodes in an isolated fashion. However, this configuration does not support"},{"line_number":15,"context_line":"trunk ports belonging to multiple networks."}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_f5f11e96","line":12,"in_reply_to":"3ac371cc_a17245ab","updated":"2016-08-18 13:51:32.000000000","message":"Done","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":10,"context_line":"It is possible to use dedicated tenant networks for provisioned nodes, which"},{"line_number":11,"context_line":"extends the current ironic capabilities of providing flat networks. This works"},{"line_number":12,"context_line":"in conjunction with neutron to allow provisioning of nodes in a separate"},{"line_number":13,"context_line":"provisioning network. The result of this is that multiple tenants can now use"},{"line_number":14,"context_line":"nodes in an isolated fashion. However, this configuration does not support"},{"line_number":15,"context_line":"trunk ports belonging to multiple networks."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_01b19947","line":13,"updated":"2016-08-16 16:37:06.000000000","message":"s/now//","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":10,"context_line":"It is possible to use dedicated tenant networks for provisioned nodes, which"},{"line_number":11,"context_line":"extends the current ironic capabilities of providing flat networks. This works"},{"line_number":12,"context_line":"in conjunction with neutron to allow provisioning of nodes in a separate"},{"line_number":13,"context_line":"provisioning network. The result of this is that multiple tenants can now use"},{"line_number":14,"context_line":"nodes in an isolated fashion. However, this configuration does not support"},{"line_number":15,"context_line":"trunk ports belonging to multiple networks."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_15315a5a","line":13,"in_reply_to":"3ac371cc_01b19947","updated":"2016-08-18 13:51:32.000000000","message":"Done","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":14,"context_line":"nodes in an isolated fashion. However, this configuration does not support"},{"line_number":15,"context_line":"trunk ports belonging to multiple networks."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Network interface is one of the driver interfaces, that manages network"},{"line_number":18,"context_line":"switching for nodes. Currently there are 3 network interfaces available in"},{"line_number":19,"context_line":"ironic:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_61eded24","line":17,"updated":"2016-08-16 16:37:06.000000000","message":"Maybe s/Network interface/``Network interface``/","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":14,"context_line":"nodes in an isolated fashion. However, this configuration does not support"},{"line_number":15,"context_line":"trunk ports belonging to multiple networks."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Network interface is one of the driver interfaces, that manages network"},{"line_number":18,"context_line":"switching for nodes. Currently there are 3 network interfaces available in"},{"line_number":19,"context_line":"ironic:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_95526a65","line":17,"in_reply_to":"3ac371cc_61eded24","updated":"2016-08-18 13:51:32.000000000","message":"I think ```` are used for things that are code-like, here it\u0027s just described what the interface is, if it was network_interface I\u0027d change it.","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Network interface is one of the driver interfaces, that manages network"},{"line_number":18,"context_line":"switching for nodes. Currently there are 3 network interfaces available in"},{"line_number":19,"context_line":"ironic:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- ``noop`` interface is used for standalone deployments, and does not perform"},{"line_number":22,"context_line":"  any network switching;"}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_61304d9f","line":19,"updated":"2016-08-16 16:37:06.000000000","message":"s/ironic/the Bare Metal service/","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Network interface is one of the driver interfaces, that manages network"},{"line_number":18,"context_line":"switching for nodes. Currently there are 3 network interfaces available in"},{"line_number":19,"context_line":"ironic:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- ``noop`` interface is used for standalone deployments, and does not perform"},{"line_number":22,"context_line":"  any network switching;"}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_b5de86da","line":19,"in_reply_to":"3ac371cc_61304d9f","updated":"2016-08-18 13:51:32.000000000","message":"Done","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Configuring Ironic"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Below is an example flow of how to setup ironic so that node provisioning will"},{"line_number":35,"context_line":"happen in a multitenant environment:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"#. Define a provider network in neutron, which we shall refer to as the"}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_611ccd77","line":34,"updated":"2016-08-16 16:37:06.000000000","message":"Does this entire section assume that the \u0027neutron\u0027 interface is specified?  \n\nDo we want to mention how the operator can specify which network interface to use? (Or maybe put a NOTE or something to do this?) OH, I see you describe it in steps 2\u00263 below. I think it might make sense to put those two points in a separate \u0027section\u0027. Eg \u0027Configure the network interface\u0027 ? OR a new section \u0027Network interfaces\u0027 with the stuff from line 17, and the steps 2\u00263 below\u0027. And maybe steps 7\u00268 too?","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Configuring Ironic"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Below is an example flow of how to setup ironic so that node provisioning will"},{"line_number":35,"context_line":"happen in a multitenant environment:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"#. Define a provider network in neutron, which we shall refer to as the"}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_cca9f825","line":34,"in_reply_to":"3ac371cc_611ccd77","updated":"2016-08-18 13:51:32.000000000","message":"Hm, I think the order should remain - first we describe what network interfaces are and which ones we have in tree, then we describe what is needed to enable them (services configuration), and only after that we can make nodes use that feature. I think I\u0027ll move steps 2 and 3 to the top, and all the node or port related actions will be moved to a separate sections.","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":94,"context_line":"   \u003chttp://docs.openstack.org/networking-guide/config-ml2-plug-in.html\u003e`_"},{"line_number":95,"context_line":"   for details."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"#. Restart the ironic conductor after the modifications:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   - Fedora/RHEL7/CentOS7::"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_9c104eaa","line":97,"updated":"2016-08-16 16:37:06.000000000","message":"also need to restart ironic-api service cuz/if enabled_network_interfaces is modified.","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":94,"context_line":"   \u003chttp://docs.openstack.org/networking-guide/config-ml2-plug-in.html\u003e`_"},{"line_number":95,"context_line":"   for details."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"#. Restart the ironic conductor after the modifications:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   - Fedora/RHEL7/CentOS7::"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_95870ab4","line":97,"in_reply_to":"3ac371cc_9c104eaa","updated":"2016-08-18 13:51:32.000000000","message":"Done","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      sudo service ironic-conductor restart"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"#. Multitenancy support was added in the 1.20 API version. The following"},{"line_number":108,"context_line":"   examples assume you are using a recent release of the python-ironicclient"},{"line_number":109,"context_line":"   package. They show the usage of both ``ironic`` and ``openstack baremetal``"},{"line_number":110,"context_line":"   commands."},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_9c5e8e74","line":108,"updated":"2016-08-16 16:37:06.000000000","message":"why recent? can we be more specific and mention the first release.","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":105,"context_line":"      sudo service ironic-conductor restart"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"#. Multitenancy support was added in the 1.20 API version. The following"},{"line_number":108,"context_line":"   examples assume you are using a recent release of the python-ironicclient"},{"line_number":109,"context_line":"   package. They show the usage of both ``ironic`` and ``openstack baremetal``"},{"line_number":110,"context_line":"   commands."},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_b57a06bb","line":108,"in_reply_to":"3ac371cc_9c5e8e74","updated":"2016-08-18 13:51:32.000000000","message":"Done","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"572ac1a6ccd2c974be61c7c26a2290668d24f7ed","unresolved":false,"context_lines":[{"line_number":203,"context_line":"      openstack baremetal port show $PORT_UUID"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"After these steps, the provisioning of the created node will happen in the"},{"line_number":206,"context_line":"provisioning network, and then the node will be moved to a tenant network that"},{"line_number":207,"context_line":"was requested."}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_c1d2e1d1","line":206,"updated":"2016-08-16 16:37:06.000000000","message":"s/a tenant/the tenant/","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7b6bde5a413ad3599a07887e8cc54397b22885","unresolved":false,"context_lines":[{"line_number":203,"context_line":"      openstack baremetal port show $PORT_UUID"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"After these steps, the provisioning of the created node will happen in the"},{"line_number":206,"context_line":"provisioning network, and then the node will be moved to a tenant network that"},{"line_number":207,"context_line":"was requested."}],"source_content_type":"text/x-rst","patch_set":91,"id":"3ac371cc_351bb682","line":206,"in_reply_to":"3ac371cc_c1d2e1d1","updated":"2016-08-18 13:51:32.000000000","message":"Done","commit_id":"6961d523bcb3dc4509b8bbe87a5e8721145fa7dc"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"96465ea9b1320d03c835e37a67bbcaf72aa91b03","unresolved":false,"context_lines":[{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"#. Multitenancy support was added in the 1.20 API version. The following"},{"line_number":122,"context_line":"   examples assume you are using at least 1.5.0 release of the"},{"line_number":123,"context_line":"   python-ironicclient package. They show the usage of both ``ironic`` and"},{"line_number":124,"context_line":"   ``openstack baremetal`` commands."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":92,"id":"3ac371cc_356c4c07","line":122,"updated":"2016-08-18 14:07:09.000000000","message":"suggestion: The following examples assume you are using python-ironicclient version 1.5.0 or higher.","commit_id":"3e074e038c88792ca085cd5fcad61a350d8c8fa9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"74266ca7c1ddd9ec6d5356a2b6213528936867b2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"#. Multitenancy support was added in the 1.20 API version. The following"},{"line_number":122,"context_line":"   examples assume you are using at least 1.5.0 release of the"},{"line_number":123,"context_line":"   python-ironicclient package. They show the usage of both ``ironic`` and"},{"line_number":124,"context_line":"   ``openstack baremetal`` commands."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":92,"id":"3ac371cc_18cce7b9","line":122,"in_reply_to":"3ac371cc_356c4c07","updated":"2016-08-18 14:09:38.000000000","message":"Done","commit_id":"3e074e038c88792ca085cd5fcad61a350d8c8fa9"}]}
