)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e72be8110be078b7f8d85d30bcf16d7848ce010c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit implements baremetal provisioning in UEFI secure boot for"},{"line_number":10,"context_line":"iLO drivers. It add new boolean configuration parameter named"},{"line_number":11,"context_line":"force_deploy_in_secure_boot under ilo section."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1526755"},{"line_number":14,"context_line":"Change-Id: I1fe60ae235b920071023c65f24dea48f5e3b5c6c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa69d971_df3dd1c4","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":27},"updated":"2016-01-06 14:24:27.000000000","message":"Parameter name mentioned in commit message does not match the code.\n\nAdditionally, it would be helpful for someone reviewing the review set to explain why since reviewers may not be online with access to launchpad.","commit_id":"e3cfa15ab053620e57dd4cc64c0f28ad5e9f076e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7841dcd84cb4baceedef671aca2498bc7a7faeaf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit implements baremetal provisioning in UEFI secure boot for"},{"line_number":10,"context_line":"iLO drivers. It add new boolean configuration parameter named"},{"line_number":11,"context_line":"force_deploy_in_secure_boot under ilo section."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1526755"},{"line_number":14,"context_line":"Change-Id: I1fe60ae235b920071023c65f24dea48f5e3b5c6c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa69d971_92ca844e","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":27},"in_reply_to":"fa69d971_df3dd1c4","updated":"2016-01-08 05:41:21.000000000","message":"Done","commit_id":"e3cfa15ab053620e57dd4cc64c0f28ad5e9f076e"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"085eef85f500b1dfaf621e639e8589d07b2ffb96","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                       \u0027is set to False, then Ironic will use Swift \u0027"},{"line_number":68,"context_line":"                       \u0027to host the floppy images and generated \u0027"},{"line_number":69,"context_line":"                       \u0027boot_iso.\u0027)),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027force_deploy_in_secure_boot\u0027,"},{"line_number":71,"context_line":"               default\u003dFalse,"},{"line_number":72,"context_line":"               help\u003d_(\u0027Set this to True to enable UEFI secure boot mode \u0027"},{"line_number":73,"context_line":"                      \u0027during provisioning when baremetal instance is \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_3aa8f9da","line":70,"updated":"2015-10-08 01:37:20.000000000","message":"BoolOpt please","commit_id":"d1187d52f1683b0b62a9f95d1d4a772981303495"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c92444fa9283f6981db4ed9daf4e8f66da785742","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                       \u0027is set to False, then Ironic will use Swift \u0027"},{"line_number":68,"context_line":"                       \u0027to host the floppy images and generated \u0027"},{"line_number":69,"context_line":"                       \u0027boot_iso.\u0027)),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027force_deploy_in_secure_boot\u0027,"},{"line_number":71,"context_line":"               default\u003dFalse,"},{"line_number":72,"context_line":"               help\u003d_(\u0027Set this to True to enable UEFI secure boot mode \u0027"},{"line_number":73,"context_line":"                      \u0027during provisioning when baremetal instance is \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_5506e686","line":70,"in_reply_to":"7a2fa921_3aa8f9da","updated":"2015-10-08 03:21:07.000000000","message":"Done","commit_id":"d1187d52f1683b0b62a9f95d1d4a772981303495"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e72be8110be078b7f8d85d30bcf16d7848ce010c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                default\u003dFalse,"},{"line_number":74,"context_line":"                help\u003d_(\u0027Set this to True to enable UEFI secure boot mode \u0027"},{"line_number":75,"context_line":"                       \u0027during provisioning when baremetal instance is \u0027"},{"line_number":76,"context_line":"                       \u0027requested with capabilities `secure_boot` as True.\u0027)),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_449b5466","line":76,"range":{"start_line":76,"start_character":52,"end_line":76,"end_character":74},"updated":"2016-01-06 14:24:27.000000000","message":"More so, reading through the code, it seems like it is a global control for the driver to only permit the user to utilize secure boot with the ilo driver is leveraged.   If that is the intent, then this help text should be updated to reflect that and the driver documentation should likely be updated in concert with this change.","commit_id":"e3cfa15ab053620e57dd4cc64c0f28ad5e9f076e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7841dcd84cb4baceedef671aca2498bc7a7faeaf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                default\u003dFalse,"},{"line_number":74,"context_line":"                help\u003d_(\u0027Set this to True to enable UEFI secure boot mode \u0027"},{"line_number":75,"context_line":"                       \u0027during provisioning when baremetal instance is \u0027"},{"line_number":76,"context_line":"                       \u0027requested with capabilities `secure_boot` as True.\u0027)),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_d2e6bce7","line":76,"range":{"start_line":76,"start_character":52,"end_line":76,"end_character":74},"in_reply_to":"fa69d971_449b5466","updated":"2016-01-08 05:41:21.000000000","message":"Done","commit_id":"e3cfa15ab053620e57dd4cc64c0f28ad5e9f076e"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e72be8110be078b7f8d85d30bcf16d7848ce010c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":160,"context_line":"    if boot_mode \u003d\u003d \u0027bios\u0027 and CONF.ilo.secure_deploy_mode:"},{"line_number":161,"context_line":"        LOG.error(_LE(\"Boot mode `bios` is not supported when \""},{"line_number":162,"context_line":"                      \"`secure_deploy_mode` is enabled for node %s.\"),"},{"line_number":163,"context_line":"                  task.node.uuid)"},{"line_number":164,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":165,"context_line":"            \"Conflict: `bios` boot mode being used for deploy, but \""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_4437d44c","line":162,"range":{"start_line":162,"start_character":59,"end_line":162,"end_character":63},"updated":"2016-01-06 14:24:27.000000000","message":"While it is for when a node is being deployed,this is a conductor level setting, not a node level setting, and I think the error messages should represent that.","commit_id":"e3cfa15ab053620e57dd4cc64c0f28ad5e9f076e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7841dcd84cb4baceedef671aca2498bc7a7faeaf","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":160,"context_line":"    if boot_mode \u003d\u003d \u0027bios\u0027 and CONF.ilo.secure_deploy_mode:"},{"line_number":161,"context_line":"        LOG.error(_LE(\"Boot mode `bios` is not supported when \""},{"line_number":162,"context_line":"                      \"`secure_deploy_mode` is enabled for node %s.\"),"},{"line_number":163,"context_line":"                  task.node.uuid)"},{"line_number":164,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":165,"context_line":"            \"Conflict: `bios` boot mode being used for deploy, but \""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_52dbac1b","line":162,"range":{"start_line":162,"start_character":59,"end_line":162,"end_character":63},"in_reply_to":"fa69d971_4437d44c","updated":"2016-01-08 05:41:21.000000000","message":"Done","commit_id":"e3cfa15ab053620e57dd4cc64c0f28ad5e9f076e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e72be8110be078b7f8d85d30bcf16d7848ce010c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                      \"`secure_deploy_mode` is enabled for node %s.\"),"},{"line_number":163,"context_line":"                  task.node.uuid)"},{"line_number":164,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":165,"context_line":"            \"Conflict: `bios` boot mode being used for deploy, but \""},{"line_number":166,"context_line":"            \"cannot be used with node %(node_uuid)s configured to use \""},{"line_number":167,"context_line":"            \"`secure_deploy_mode`\") % {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_647c58ec","line":165,"range":{"start_line":165,"start_character":23,"end_line":165,"end_character":39},"updated":"2016-01-06 14:24:27.000000000","message":"Nit: Perhaps point the user to using secure_boot as well?","commit_id":"e3cfa15ab053620e57dd4cc64c0f28ad5e9f076e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7841dcd84cb4baceedef671aca2498bc7a7faeaf","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                      \"`secure_deploy_mode` is enabled for node %s.\"),"},{"line_number":163,"context_line":"                  task.node.uuid)"},{"line_number":164,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":165,"context_line":"            \"Conflict: `bios` boot mode being used for deploy, but \""},{"line_number":166,"context_line":"            \"cannot be used with node %(node_uuid)s configured to use \""},{"line_number":167,"context_line":"            \"`secure_deploy_mode`\") % {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_32071883","line":165,"range":{"start_line":165,"start_character":23,"end_line":165,"end_character":39},"in_reply_to":"fa69d971_647c58ec","updated":"2016-01-08 05:41:21.000000000","message":"Done","commit_id":"e3cfa15ab053620e57dd4cc64c0f28ad5e9f076e"}],"releasenotes/notes/ilo-driver-provisioning-in-uefi-secure-boot-e29b8864e8d9828f.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e72be8110be078b7f8d85d30bcf16d7848ce010c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support added for baremetal provisioning in UEFI"},{"line_number":4,"context_line":"    secure boot mode for iLO drivers."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa69d971_249e6007","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":37},"updated":"2016-01-06 14:24:27.000000000","message":"perhaps?\n  - Support has been added to allow iLO driver users enforce use of\n    secure boot mode.","commit_id":"e3cfa15ab053620e57dd4cc64c0f28ad5e9f076e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7841dcd84cb4baceedef671aca2498bc7a7faeaf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support added for baremetal provisioning in UEFI"},{"line_number":4,"context_line":"    secure boot mode for iLO drivers."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa69d971_f200a068","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":37},"in_reply_to":"fa69d971_249e6007","updated":"2016-01-08 05:41:21.000000000","message":"Done","commit_id":"e3cfa15ab053620e57dd4cc64c0f28ad5e9f076e"}]}