)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"38560d653ef6c8434615d26dc3cbd354e5cdad88","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use server_profile_template_uri to schedule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since Server Profile Templates define configuration options that can change"},{"line_number":10,"context_line":"important properties on a node, it is important to give the user the possibility"},{"line_number":11,"context_line":"use a Nova flavor to define which kind of configuration the server to be"},{"line_number":12,"context_line":"scheduled can have. This patch changes the server_profile_template_uri from"},{"line_number":13,"context_line":"driver_info to properties/capabilities so the user can use a proper configured"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa80f949_abd8821e","line":10,"updated":"2015-11-04 05:40:45.000000000","message":"there is something wrong with this sentence...\nit is important to give the user the possibility use a Nova flavor to define which kind of configuration the server to be scheduled can have.\"\n\nProbably you meant:-\nIt is important to make this property be used in Nova flavor so that Node with accurate server configuration gets selected.","commit_id":"2c93d911be603b7c6fd4148763a375ff523a5875"}],"ironic/drivers/modules/oneview/common.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9bade41da9dc31bd84fdd9cd8a1ca3dcdcd3b45","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \u0027enclosure_group_uri\u0027:"},{"line_number":145,"context_line":"            capabilities_dict.get(\u0027enclosure_group_uri\u0027),"},{"line_number":146,"context_line":"        \u0027server_profile_template_uri\u0027:"},{"line_number":147,"context_line":"            capabilities_dict.get(\u0027server_profile_template_uri\u0027),"},{"line_number":148,"context_line":"    }"},{"line_number":149,"context_line":"    return oneview_info"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_af25fbab","line":147,"updated":"2015-10-28 15:28:56.000000000","message":"Should it follow deprecation process? Or maybe both ways should be allowed? Seems that your 3rd party ci tests are failing because of this change.","commit_id":"16a45d8b749e619c9def44ecb275c231918c10ac"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"c3632bea5b2e10599510ac8b39f664ccd5df4164","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \u0027enclosure_group_uri\u0027:"},{"line_number":145,"context_line":"            capabilities_dict.get(\u0027enclosure_group_uri\u0027),"},{"line_number":146,"context_line":"        \u0027server_profile_template_uri\u0027:"},{"line_number":147,"context_line":"            capabilities_dict.get(\u0027server_profile_template_uri\u0027),"},{"line_number":148,"context_line":"    }"},{"line_number":149,"context_line":"    return oneview_info"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_2347c4bc","line":147,"in_reply_to":"1a26ad4f_0fc50f3b","updated":"2015-10-28 17:39:49.000000000","message":"As Thiago said, this driver has not yet been in an Ironic release. So, if this change comes in before the next release, we won\u0027t have to go through this deprecation process.\n\nPlease, notice I\u0027m implicitly asking for reviews before the next release is cut :-).\n\nThank you.","commit_id":"16a45d8b749e619c9def44ecb275c231918c10ac"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"bd86b4c2bb7a80c90c4b7c922ea99f2f4d3ade9c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \u0027enclosure_group_uri\u0027:"},{"line_number":145,"context_line":"            capabilities_dict.get(\u0027enclosure_group_uri\u0027),"},{"line_number":146,"context_line":"        \u0027server_profile_template_uri\u0027:"},{"line_number":147,"context_line":"            capabilities_dict.get(\u0027server_profile_template_uri\u0027),"},{"line_number":148,"context_line":"    }"},{"line_number":149,"context_line":"    return oneview_info"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_64856605","line":147,"in_reply_to":"1a26ad4f_2347c4bc","updated":"2015-11-02 09:03:19.000000000","message":"There was a discussion around this before. IIRC, we were talking about providing backward compatibility for every commit because some people might be using ironic from master and there is nothing wrong in it. We don\u0027t want to break them too.  Handling this in code with a warning seems pretty easy as well.  So, I am +1 inclined towards doing it.  But would like to get others thought on that.","commit_id":"16a45d8b749e619c9def44ecb275c231918c10ac"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5d06109c5cf15860aa03e86a4622897d047652e8","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \u0027enclosure_group_uri\u0027:"},{"line_number":145,"context_line":"            capabilities_dict.get(\u0027enclosure_group_uri\u0027),"},{"line_number":146,"context_line":"        \u0027server_profile_template_uri\u0027:"},{"line_number":147,"context_line":"            capabilities_dict.get(\u0027server_profile_template_uri\u0027),"},{"line_number":148,"context_line":"    }"},{"line_number":149,"context_line":"    return oneview_info"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_18aa6d1a","line":147,"in_reply_to":"1a26ad4f_64856605","updated":"2015-11-03 10:53:04.000000000","message":"I tend to agree that it should be allowed both ways with a deprecation message for driver_info.","commit_id":"16a45d8b749e619c9def44ecb275c231918c10ac"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"bc09be6224dcaef077bea2a57a4b53431faad672","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \u0027enclosure_group_uri\u0027:"},{"line_number":145,"context_line":"            capabilities_dict.get(\u0027enclosure_group_uri\u0027),"},{"line_number":146,"context_line":"        \u0027server_profile_template_uri\u0027:"},{"line_number":147,"context_line":"            capabilities_dict.get(\u0027server_profile_template_uri\u0027),"},{"line_number":148,"context_line":"    }"},{"line_number":149,"context_line":"    return oneview_info"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_0fc50f3b","line":147,"in_reply_to":"1a26ad4f_af25fbab","updated":"2015-10-28 15:39:39.000000000","message":"Our functional testing code wasn\u0027t yet corrected to consider this. We\u0027re focusing in putting the CI to work first. :)\nDo you think we should go with deprecation process? Since Ironic wasn\u0027t released yet with this code, I think it\u0027s not needed.","commit_id":"16a45d8b749e619c9def44ecb275c231918c10ac"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b4b221e3a052b7dbe1b3ad9a5f6aeb3ee08baed5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \u0027enclosure_group_uri\u0027:"},{"line_number":145,"context_line":"            capabilities_dict.get(\u0027enclosure_group_uri\u0027),"},{"line_number":146,"context_line":"        \u0027server_profile_template_uri\u0027:"},{"line_number":147,"context_line":"            capabilities_dict.get(\u0027server_profile_template_uri\u0027),"},{"line_number":148,"context_line":"    }"},{"line_number":149,"context_line":"    return oneview_info"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_a34f4c91","line":147,"in_reply_to":"fa80f949_18aa6d1a","updated":"2015-11-04 02:54:55.000000000","message":"Deprecation is definitely needed here, whether or not it\u0027s in release. People do run from trunk. The usual rule is a cycle boundary *and* three months - not sure what happens if it isn\u0027t released.\n\nAs suggested in IRC, please send this to the mailing list so we can get stable maint folks\u0027 opinions on this one.\n\nAs for the code, it\u0027s easy - check capabilities, if it isn\u0027t there, check driver_info and warn for deprecation.","commit_id":"16a45d8b749e619c9def44ecb275c231918c10ac"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"38560d653ef6c8434615d26dc3cbd354e5cdad88","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        if spt_from_driver_info is not None:"},{"line_number":158,"context_line":"            LOG.warning("},{"line_number":159,"context_line":"                _(\u0027Using \"server_profile_template_uri\" on driver_info is \u0027"},{"line_number":160,"context_line":"                  \u0027deprecated and will be removed after Mitaka. Node %s \u0027"},{"line_number":161,"context_line":"                  \u0027should have it on properties/capabilities \u0027"},{"line_number":162,"context_line":"                  \u0027instead.\u0027) % node.uuid"},{"line_number":163,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_2b8812e7","line":160,"updated":"2015-11-04 05:40:45.000000000","message":"s/ Mitaka./ Mitaka release./","commit_id":"2c93d911be603b7c6fd4148763a375ff523a5875"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"d272521286b3b80b58c8dd7ef6b6e255b2addf91","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        if spt_from_driver_info is not None:"},{"line_number":158,"context_line":"            LOG.warning("},{"line_number":159,"context_line":"                _(\u0027Using \"server_profile_template_uri\" on driver_info is \u0027"},{"line_number":160,"context_line":"                  \u0027deprecated and will be removed after Mitaka. Node %s \u0027"},{"line_number":161,"context_line":"                  \u0027should have it on properties/capabilities \u0027"},{"line_number":162,"context_line":"                  \u0027instead.\u0027) % node.uuid"},{"line_number":163,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_949b4172","line":160,"in_reply_to":"fa80f949_2b8812e7","updated":"2015-11-04 20:17:36.000000000","message":"Done","commit_id":"2c93d911be603b7c6fd4148763a375ff523a5875"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"38560d653ef6c8434615d26dc3cbd354e5cdad88","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            LOG.warning("},{"line_number":159,"context_line":"                _(\u0027Using \"server_profile_template_uri\" on driver_info is \u0027"},{"line_number":160,"context_line":"                  \u0027deprecated and will be removed after Mitaka. Node %s \u0027"},{"line_number":161,"context_line":"                  \u0027should have it on properties/capabilities \u0027"},{"line_number":162,"context_line":"                  \u0027instead.\u0027) % node.uuid"},{"line_number":163,"context_line":"            )"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_8b77be01","line":161,"updated":"2015-11-04 05:40:45.000000000","message":"s/ on / in/","commit_id":"2c93d911be603b7c6fd4148763a375ff523a5875"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"d272521286b3b80b58c8dd7ef6b6e255b2addf91","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            LOG.warning("},{"line_number":159,"context_line":"                _(\u0027Using \"server_profile_template_uri\" on driver_info is \u0027"},{"line_number":160,"context_line":"                  \u0027deprecated and will be removed after Mitaka. Node %s \u0027"},{"line_number":161,"context_line":"                  \u0027should have it on properties/capabilities \u0027"},{"line_number":162,"context_line":"                  \u0027instead.\u0027) % node.uuid"},{"line_number":163,"context_line":"            )"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_74a01da0","line":161,"in_reply_to":"fa80f949_8b77be01","updated":"2015-11-04 20:17:36.000000000","message":"Done","commit_id":"2c93d911be603b7c6fd4148763a375ff523a5875"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b8f254c11b855451db64c970cbd7050a2082f4bf","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    # TODO(gabriel-bezerra): Remove this after Mitaka"},{"line_number":154,"context_line":"    spt_from_driver_info \u003d driver_info.get(\u0027server_profile_template_uri\u0027)"},{"line_number":155,"context_line":"    if spt_from_driver_info is not None:"},{"line_number":156,"context_line":"        LOG.warning("},{"line_number":157,"context_line":"            _(\u0027Using \"server_profile_template_uri\" in driver_info is \u0027"},{"line_number":158,"context_line":"              \u0027deprecated and will be removed after Mitaka release. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_da93194e","line":155,"updated":"2015-11-05 11:56:46.000000000","message":"I\u0027d rather move this inside the next if, as it was done in PS5, if it is present, it does not mean it will be used.","commit_id":"00ba0504f8b971ffc92ffe3009100b48ee150742"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b8f254c11b855451db64c970cbd7050a2082f4bf","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    spt_from_driver_info \u003d driver_info.get(\u0027server_profile_template_uri\u0027)"},{"line_number":155,"context_line":"    if spt_from_driver_info is not None:"},{"line_number":156,"context_line":"        LOG.warning("},{"line_number":157,"context_line":"            _(\u0027Using \"server_profile_template_uri\" in driver_info is \u0027"},{"line_number":158,"context_line":"              \u0027deprecated and will be removed after Mitaka release. \u0027"},{"line_number":159,"context_line":"              \u0027Node %s should have it in its properties/capabilities \u0027"},{"line_number":160,"context_line":"              \u0027instead.\u0027) % node.uuid"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_1aef61b1","line":157,"updated":"2015-11-05 11:56:46.000000000","message":"Please translate with _LW","commit_id":"00ba0504f8b971ffc92ffe3009100b48ee150742"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f31da65d13ec3e136f5d260984f0889c0bf8d2e7","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if spt_from_driver_info is not None:"},{"line_number":157,"context_line":"        if oneview_info[\u0027server_profile_template_uri\u0027] is None:"},{"line_number":158,"context_line":"            LOG.warning("},{"line_number":159,"context_line":"                _LW(\u0027Using \"server_profile_template_uri\" in driver_info is \u0027"},{"line_number":160,"context_line":"                    \u0027deprecated and will be removed after Mitaka release. \u0027"},{"line_number":161,"context_line":"                    \u0027Node %s should have it in its properties/capabilities \u0027"},{"line_number":162,"context_line":"                    \u0027instead.\u0027) % node.uuid"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_601d9a0e","line":159,"updated":"2015-11-05 12:41:06.000000000","message":"Using \"server_profile_template_uri\" from driver_info. It is deprecated and....\n\nAlso maybe s/removed/ignored/","commit_id":"8c6a51127f6be69e4e928f83d91395493e268f48"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f31da65d13ec3e136f5d260984f0889c0bf8d2e7","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                _LW(\u0027Using \"server_profile_template_uri\" in driver_info is \u0027"},{"line_number":160,"context_line":"                    \u0027deprecated and will be removed after Mitaka release. \u0027"},{"line_number":161,"context_line":"                    \u0027Node %s should have it in its properties/capabilities \u0027"},{"line_number":162,"context_line":"                    \u0027instead.\u0027) % node.uuid"},{"line_number":163,"context_line":"            )"},{"line_number":164,"context_line":"            oneview_info[\u0027server_profile_template_uri\u0027] \u003d spt_from_driver_info"},{"line_number":165,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_0005aeba","line":162,"updated":"2015-11-05 12:41:06.000000000","message":"Missed this one, please also use comma instead of % here.","commit_id":"8c6a51127f6be69e4e928f83d91395493e268f48"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f31da65d13ec3e136f5d260984f0889c0bf8d2e7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            oneview_info[\u0027server_profile_template_uri\u0027] \u003d spt_from_driver_info"},{"line_number":165,"context_line":"        else:"},{"line_number":166,"context_line":"            LOG.info("},{"line_number":167,"context_line":"                _(\u0027Node %s has \"server_profile_template_uri\" defined both in \u0027"},{"line_number":168,"context_line":"                  \u0027driver_info and in its properties/capabilities. Using \u0027"},{"line_number":169,"context_line":"                  \u0027the one in properties/capabilities. Having it in \u0027"},{"line_number":170,"context_line":"                  \u0027driver_info is deprecated and will be removed after Mitaka \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_001cce10","line":167,"updated":"2015-11-05 12:41:06.000000000","message":"_LI","commit_id":"8c6a51127f6be69e4e928f83d91395493e268f48"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f31da65d13ec3e136f5d260984f0889c0bf8d2e7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                  \u0027driver_info and in its properties/capabilities. Using \u0027"},{"line_number":169,"context_line":"                  \u0027the one in properties/capabilities. Having it in \u0027"},{"line_number":170,"context_line":"                  \u0027driver_info is deprecated and will be removed after Mitaka \u0027"},{"line_number":171,"context_line":"                  \u0027release.\u0027) % node.uuid"},{"line_number":172,"context_line":"            )"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    return oneview_info"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_2000f2a9","line":171,"updated":"2015-11-05 12:41:06.000000000","message":"ditto about comma and ignored.","commit_id":"8c6a51127f6be69e4e928f83d91395493e268f48"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"82a32fac419c9ed7a50b562f793994804d5865f6","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                _LI(\u0027Node %s has \"server_profile_template_uri\" defined both \u0027"},{"line_number":170,"context_line":"                    \u0027in driver_info and in its properties/capabilities. Using \u0027"},{"line_number":171,"context_line":"                    \u0027the one in properties/capabilities. Having it in \u0027"},{"line_number":172,"context_line":"                    \u0027driver_info is deprecated and will be ignored after \u0027"},{"line_number":173,"context_line":"                    \u0027Mitaka release.\u0027),"},{"line_number":174,"context_line":"                node.uuid"},{"line_number":175,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_608ca135","line":172,"updated":"2015-11-05 22:09:56.000000000","message":"\"and will be ignored after Mitaka release.\" is not needed here, you are ignoring it already in this case, maybe just reword to state that the entry in driver_info should be removed.","commit_id":"1ff12c563582c3dac6ad5bbd00a86e88d8186155"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d1e0dcbded52174f3ad04a2ed21e9f37eee79c83","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":59,"context_line":"    \u0027server_hardware_uri\u0027: _(\"Server Hardware URI. Required.\"),"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"REQUIRED_ON_PROPERTIES \u003d {"},{"line_number":63,"context_line":"    \u0027server_hardware_type_uri\u0027: _(\"Server Hardware Type URI. Required.\"),"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_19824a01","line":60,"updated":"2015-11-09 10:38:00.000000000","message":"Shouldn\u0027t we leave the option here so the user knows it\u0027s now deprecated?\n\n\u0027server_profile_template_uri\u0027: _(\"Server Profile Template URI to clone from.  This option is now DEPRECATED, please use specify the server profile template URI using the node\u0027s properties/capabilities\")\n\nOr something along those lines","commit_id":"0815f9a17413e796b6b341b01ce9648ce9442dac"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"0e072bf66a6d8991340bef4a0316d80e86335e7b","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"REQUIRED_ON_DRIVER_INFO \u003d {"},{"line_number":59,"context_line":"    \u0027server_hardware_uri\u0027: _(\"Server Hardware URI. Required.\"),"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"REQUIRED_ON_PROPERTIES \u003d {"},{"line_number":63,"context_line":"    \u0027server_hardware_type_uri\u0027: _(\"Server Hardware Type URI. Required.\"),"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_7ded67ee","line":60,"in_reply_to":"da85f559_19824a01","updated":"2015-11-09 21:01:56.000000000","message":"That would make server_profile_template_uri required. I don\u0027t think that requiring a deprecated thing is a good idea. Thoughts?","commit_id":"0815f9a17413e796b6b341b01ce9648ce9442dac"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d1e0dcbded52174f3ad04a2ed21e9f37eee79c83","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# TODO(gabriel-bezerra): Move \u0027server_profile_template_uri\u0027 to"},{"line_number":67,"context_line":"# REQUIRED_ON_PROPERTIES after Mitaka. See method get_oneview_info"},{"line_number":68,"context_line":"# and test_deprecated_spt_in_driver_info* test_common tests."},{"line_number":69,"context_line":"OPTIONAL_ON_PROPERTIES \u003d {"},{"line_number":70,"context_line":"    \u0027enclosure_group_uri\u0027: _(\"Enclosure Group URI.\"),"},{"line_number":71,"context_line":"    \u0027server_profile_template_uri\u0027: _(\"Server Profile Template URI to clone \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_599532e2","line":68,"updated":"2015-11-09 10:38:00.000000000","message":"We probably can move it now. We just need to make sure that the communication is done right, so the helper text should mention that if the \"server_profile_template_uri\" capability is not found in the node\u0027s properties/capabilities the code will try to use the one in the node\u0027s driver_info and this behavior is going to be removed in the future.","commit_id":"0815f9a17413e796b6b341b01ce9648ce9442dac"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"0e072bf66a6d8991340bef4a0316d80e86335e7b","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# TODO(gabriel-bezerra): Move \u0027server_profile_template_uri\u0027 to"},{"line_number":67,"context_line":"# REQUIRED_ON_PROPERTIES after Mitaka. See method get_oneview_info"},{"line_number":68,"context_line":"# and test_deprecated_spt_in_driver_info* test_common tests."},{"line_number":69,"context_line":"OPTIONAL_ON_PROPERTIES \u003d {"},{"line_number":70,"context_line":"    \u0027enclosure_group_uri\u0027: _(\"Enclosure Group URI.\"),"},{"line_number":71,"context_line":"    \u0027server_profile_template_uri\u0027: _(\"Server Profile Template URI to clone \""}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_184b0989","line":68,"in_reply_to":"da85f559_599532e2","updated":"2015-11-09 21:01:56.000000000","message":"If we move it to REQUIRED_ON_PROPERTIES now, all the nodes would fail to validate right away.","commit_id":"0815f9a17413e796b6b341b01ce9648ce9442dac"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d1e0dcbded52174f3ad04a2ed21e9f37eee79c83","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    if spt_from_driver_info is not None:"},{"line_number":158,"context_line":"        if oneview_info[\u0027server_profile_template_uri\u0027] is None:"},{"line_number":159,"context_line":"            LOG.warning("},{"line_number":160,"context_line":"                _LW(\u0027Using \"server_profile_template_uri\" in driver_info. It \u0027"},{"line_number":161,"context_line":"                    \u0027is deprecated and will be ignored after Mitaka release. \u0027"},{"line_number":162,"context_line":"                    \u0027Node %s should have it in its properties/capabilities \u0027"},{"line_number":163,"context_line":"                    \u0027instead.\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_f96ae619","line":160,"updated":"2015-11-09 10:38:00.000000000","message":"It reads a bit odd with that full stop there, perhaps it should be the same phrase?\n\nUsing \"server_profile_template_uri\" in driver_info is now deprecated and will be ignored in future releases. Node %s...","commit_id":"0815f9a17413e796b6b341b01ce9648ce9442dac"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"0e072bf66a6d8991340bef4a0316d80e86335e7b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    if spt_from_driver_info is not None:"},{"line_number":158,"context_line":"        if oneview_info[\u0027server_profile_template_uri\u0027] is None:"},{"line_number":159,"context_line":"            LOG.warning("},{"line_number":160,"context_line":"                _LW(\u0027Using \"server_profile_template_uri\" in driver_info. It \u0027"},{"line_number":161,"context_line":"                    \u0027is deprecated and will be ignored after Mitaka release. \u0027"},{"line_number":162,"context_line":"                    \u0027Node %s should have it in its properties/capabilities \u0027"},{"line_number":163,"context_line":"                    \u0027instead.\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"da85f559_9842993d","line":160,"in_reply_to":"da85f559_f96ae619","updated":"2015-11-09 21:01:56.000000000","message":"Done","commit_id":"0815f9a17413e796b6b341b01ce9648ce9442dac"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"16f380e8471f8efc576bbaf788c2bbcd17161037","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            )"},{"line_number":144,"context_line":"        except exception.MissingParameterValue:"},{"line_number":145,"context_line":"            raise exception.MissingParameterValue("},{"line_number":146,"context_line":"                _(\"Missing \u0027server_profile_template_uri\u0027 parameter value \""},{"line_number":147,"context_line":"                  \"both in properties/capabilities and in driver_info\")"},{"line_number":148,"context_line":"            )"},{"line_number":149,"context_line":"    # end"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba8a016a_7407b51c","line":146,"updated":"2015-11-17 14:48:25.000000000","message":"I\u0027d rather log only properties/capabilities option here, so that people would not add it to driver_info.","commit_id":"189f2eb3ef349da94bbf88937a308dcc4603d3fe"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"6776d88cd9d39dfe4b4c5e0f9c73a016db7f1779","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            )"},{"line_number":144,"context_line":"        except exception.MissingParameterValue:"},{"line_number":145,"context_line":"            raise exception.MissingParameterValue("},{"line_number":146,"context_line":"                _(\"Missing \u0027server_profile_template_uri\u0027 parameter value \""},{"line_number":147,"context_line":"                  \"both in properties/capabilities and in driver_info\")"},{"line_number":148,"context_line":"            )"},{"line_number":149,"context_line":"    # end"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba8a016a_184adbac","line":146,"in_reply_to":"ba8a016a_7407b51c","updated":"2015-11-18 15:24:01.000000000","message":"Done","commit_id":"189f2eb3ef349da94bbf88937a308dcc4603d3fe"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"16f380e8471f8efc576bbaf788c2bbcd17161037","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    if missing_values_keys:"},{"line_number":264,"context_line":"        missing_keys \u003d [\"%s:%s\" % (node_namespace, k)"},{"line_number":265,"context_line":"                        for k in missing_values_keys]"},{"line_number":266,"context_line":"        raise exception.MissingParameterValue("},{"line_number":267,"context_line":"            _(\"Missing parameter value for: \u0027%s\u0027\") % \"\u0027, \u0027\".join(missing_keys)"},{"line_number":268,"context_line":"        )"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba8a016a_ba23c7a6","line":266,"updated":"2015-11-17 14:48:25.000000000","message":"Not really related to this patch - this \"\u0027, \u0027\" seems wrong , did you mean \u0027, \u0027.join(missing_keys)?","commit_id":"189f2eb3ef349da94bbf88937a308dcc4603d3fe"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"6776d88cd9d39dfe4b4c5e0f9c73a016db7f1779","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    if missing_values_keys:"},{"line_number":264,"context_line":"        missing_keys \u003d [\"%s:%s\" % (node_namespace, k)"},{"line_number":265,"context_line":"                        for k in missing_values_keys]"},{"line_number":266,"context_line":"        raise exception.MissingParameterValue("},{"line_number":267,"context_line":"            _(\"Missing parameter value for: \u0027%s\u0027\") % \"\u0027, \u0027\".join(missing_keys)"},{"line_number":268,"context_line":"        )"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba8a016a_fba83879","line":266,"in_reply_to":"ba8a016a_ba23c7a6","updated":"2015-11-18 15:24:01.000000000","message":"I want it to be -\u003e \u0027parameter1\u0027, \u0027parameter2\u0027, \u0027parameter3\u0027","commit_id":"189f2eb3ef349da94bbf88937a308dcc4603d3fe"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8a164cf0eaccc0a4a79cfb8cdb13b7442a580c05","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                    \"Node %s should have it in its properties/capabilities \""},{"line_number":141,"context_line":"                    \"instead.\"),"},{"line_number":142,"context_line":"                node.uuid"},{"line_number":143,"context_line":"            )"},{"line_number":144,"context_line":"        except exception.MissingParameterValue:"},{"line_number":145,"context_line":"            raise exception.MissingParameterValue("},{"line_number":146,"context_line":"                _(\"Missing \u0027server_profile_template_uri\u0027 parameter value in \""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_ab22e2ff","line":143,"updated":"2015-11-20 14:10:23.000000000","message":"It would be cool if we moved it to properties/capabilities for the operator here, but not going to block the review on that.","commit_id":"2f42c507371f2f3de517388404d4f003d69bc4ef"}],"ironic/tests/unit/db/utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"da1aa9dc88c036d75744e783245fb315545a5a93","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        \"cpus\": \"8\","},{"line_number":335,"context_line":"        \"local_gb\": \"10\","},{"line_number":336,"context_line":"        \"memory_mb\": \"4096\","},{"line_number":337,"context_line":"        \"capabilities\": \"server_hardware_type_uri:fake_sht_uri,\""},{"line_number":338,"context_line":"                        \"enclosure_group_uri:fake_eg_uri,\""},{"line_number":339,"context_line":"                        \"server_profile_template_uri:fake_spt_uri\""},{"line_number":340,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_27ed7aef","line":337,"updated":"2015-11-05 02:32:05.000000000","message":"Please wrap value in parenthesis.","commit_id":"f1101f2941057a41fa08aa1062037155473a9f13"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"e8df86c3a9fbd0ab05eca5e0f18d18364e09c264","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        \"cpus\": \"8\","},{"line_number":335,"context_line":"        \"local_gb\": \"10\","},{"line_number":336,"context_line":"        \"memory_mb\": \"4096\","},{"line_number":337,"context_line":"        \"capabilities\": \"server_hardware_type_uri:fake_sht_uri,\""},{"line_number":338,"context_line":"                        \"enclosure_group_uri:fake_eg_uri,\""},{"line_number":339,"context_line":"                        \"server_profile_template_uri:fake_spt_uri\""},{"line_number":340,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_a7388a3e","line":337,"in_reply_to":"fa80f949_27ed7aef","updated":"2015-11-05 02:48:02.000000000","message":"Done","commit_id":"f1101f2941057a41fa08aa1062037155473a9f13"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"da1aa9dc88c036d75744e783245fb315545a5a93","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        \"memory_mb\": \"4096\","},{"line_number":337,"context_line":"        \"capabilities\": \"server_hardware_type_uri:fake_sht_uri,\""},{"line_number":338,"context_line":"                        \"enclosure_group_uri:fake_eg_uri,\""},{"line_number":339,"context_line":"                        \"server_profile_template_uri:fake_spt_uri\""},{"line_number":340,"context_line":"    }"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_e7bd32d8","line":339,"updated":"2015-11-05 02:32:05.000000000","message":"nit: add trailing comma","commit_id":"f1101f2941057a41fa08aa1062037155473a9f13"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"e8df86c3a9fbd0ab05eca5e0f18d18364e09c264","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        \"memory_mb\": \"4096\","},{"line_number":337,"context_line":"        \"capabilities\": \"server_hardware_type_uri:fake_sht_uri,\""},{"line_number":338,"context_line":"                        \"enclosure_group_uri:fake_eg_uri,\""},{"line_number":339,"context_line":"                        \"server_profile_template_uri:fake_spt_uri\""},{"line_number":340,"context_line":"    }"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_87354647","line":339,"in_reply_to":"fa80f949_e7bd32d8","updated":"2015-11-05 02:48:02.000000000","message":"Done","commit_id":"f1101f2941057a41fa08aa1062037155473a9f13"}],"ironic/tests/unit/drivers/modules/oneview/test_common.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"38560d653ef6c8434615d26dc3cbd354e5cdad88","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        )"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # must be valid"},{"line_number":163,"context_line":"        common.verify_node_info(deprecated_node)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def test__verify_node_info(self):"},{"line_number":166,"context_line":"        common._verify_node_info(\"properties\","}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_ebff6a32","line":163,"updated":"2015-11-04 05:40:45.000000000","message":"Validate LOG.warning is called.","commit_id":"2c93d911be603b7c6fd4148763a375ff523a5875"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"d272521286b3b80b58c8dd7ef6b6e255b2addf91","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        )"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # must be valid"},{"line_number":163,"context_line":"        common.verify_node_info(deprecated_node)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def test__verify_node_info(self):"},{"line_number":166,"context_line":"        common._verify_node_info(\"properties\","}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_87e1d19c","line":163,"in_reply_to":"fa80f949_ebff6a32","updated":"2015-11-04 20:17:36.000000000","message":"Done","commit_id":"2c93d911be603b7c6fd4148763a375ff523a5875"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"da1aa9dc88c036d75744e783245fb315545a5a93","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"cpus\": \"8\","},{"line_number":35,"context_line":"    \"local_gb\": \"10\","},{"line_number":36,"context_line":"    \"memory_mb\": \"4096\","},{"line_number":37,"context_line":"    \"capabilities\": \"server_hardware_type_uri:fake_sht_uri,\""},{"line_number":38,"context_line":"                    \"enclosure_group_uri:fake_eg_uri,\""},{"line_number":39,"context_line":"                    \"server_profile_template_uri:fake_spt_uri\""},{"line_number":40,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_c72cae4c","line":37,"updated":"2015-11-05 02:32:05.000000000","message":"It would make me feel better if the value was wrapped in parenthesis. Since it goes across multiple lines.\n\nMakes me think too much of something like this:\n\n x \u003d \"server_hardware_type_uri:fake_sht_uri,\"\n \"enclosure_group_uri:fake_eg_uri,\"\n \"server_profile_template_uri:fake_spt_uri\"\n print x\n\nThe output is:\n server_hardware_type_uri:fake_sht_uri,","commit_id":"f1101f2941057a41fa08aa1062037155473a9f13"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"e8df86c3a9fbd0ab05eca5e0f18d18364e09c264","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"cpus\": \"8\","},{"line_number":35,"context_line":"    \"local_gb\": \"10\","},{"line_number":36,"context_line":"    \"memory_mb\": \"4096\","},{"line_number":37,"context_line":"    \"capabilities\": \"server_hardware_type_uri:fake_sht_uri,\""},{"line_number":38,"context_line":"                    \"enclosure_group_uri:fake_eg_uri,\""},{"line_number":39,"context_line":"                    \"server_profile_template_uri:fake_spt_uri\""},{"line_number":40,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_a7864ad9","line":37,"in_reply_to":"fa80f949_c72cae4c","updated":"2015-11-05 02:48:02.000000000","message":"Done","commit_id":"f1101f2941057a41fa08aa1062037155473a9f13"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"da1aa9dc88c036d75744e783245fb315545a5a93","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \"memory_mb\": \"4096\","},{"line_number":37,"context_line":"    \"capabilities\": \"server_hardware_type_uri:fake_sht_uri,\""},{"line_number":38,"context_line":"                    \"enclosure_group_uri:fake_eg_uri,\""},{"line_number":39,"context_line":"                    \"server_profile_template_uri:fake_spt_uri\""},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"DRIVER_INFO_DICT \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_e7d69226","line":39,"updated":"2015-11-05 02:32:05.000000000","message":"nit: add trailing comma","commit_id":"f1101f2941057a41fa08aa1062037155473a9f13"},{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"e8df86c3a9fbd0ab05eca5e0f18d18364e09c264","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \"memory_mb\": \"4096\","},{"line_number":37,"context_line":"    \"capabilities\": \"server_hardware_type_uri:fake_sht_uri,\""},{"line_number":38,"context_line":"                    \"enclosure_group_uri:fake_eg_uri,\""},{"line_number":39,"context_line":"                    \"server_profile_template_uri:fake_spt_uri\""},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"DRIVER_INFO_DICT \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_878306cc","line":39,"in_reply_to":"fa80f949_e7d69226","updated":"2015-11-05 02:48:02.000000000","message":"Done","commit_id":"f1101f2941057a41fa08aa1062037155473a9f13"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b8f254c11b855451db64c970cbd7050a2082f4bf","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"oneview_states \u003d importutils.try_import(\u0027oneview_client.states\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"PROPERTIES_DICT \u003d {"},{"line_number":33,"context_line":"    \"cpu_arch\": \"x86_64\","},{"line_number":34,"context_line":"    \"cpus\": \"8\","},{"line_number":35,"context_line":"    \"local_gb\": \"10\","}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_7ab1cde0","line":32,"updated":"2015-11-05 11:56:46.000000000","message":"These 2 dicts are not used anymore.","commit_id":"00ba0504f8b971ffc92ffe3009100b48ee150742"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f31da65d13ec3e136f5d260984f0889c0bf8d2e7","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    # TODO(gabriel-bezerra): Remove this after Mitaka"},{"line_number":97,"context_line":"    @mock.patch.object(common, \u0027LOG\u0027)"},{"line_number":98,"context_line":"    def test_deprecated_spt_in_driver_info(self, log_mock):"},{"line_number":99,"context_line":"        # the current model has server_profile_template_uri in"},{"line_number":100,"context_line":"        # properties/capabilities instead of driver_info"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_80ac3ea1","line":97,"updated":"2015-11-05 12:41:06.000000000","message":"autospec\u003dTrue","commit_id":"8c6a51127f6be69e4e928f83d91395493e268f48"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f31da65d13ec3e136f5d260984f0889c0bf8d2e7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        )"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    # TODO(gabriel-bezerra): Remove this after Mitaka"},{"line_number":136,"context_line":"    @mock.patch.object(common, \u0027LOG\u0027)"},{"line_number":137,"context_line":"    def test_deprecated_spt_in_driver_info_and_in_capabilites(self, log_mock):"},{"line_number":138,"context_line":"        # information in capabilities precedes driver_info"},{"line_number":139,"context_line":"        driver_info \u003d db_utils.get_test_oneview_driver_info()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_60927a59","line":136,"updated":"2015-11-05 12:41:06.000000000","message":"ditto","commit_id":"8c6a51127f6be69e4e928f83d91395493e268f48"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5d45fb183e74f289a4ef57fb3c9d3aa22315b7b6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \"local_gb\": \"10\","},{"line_number":55,"context_line":"            \"memory_mb\": \"4096\","},{"line_number":56,"context_line":"            \"capabilities\": \"enclosure_group_uri:fake_eg_uri,\""},{"line_number":57,"context_line":"                            \"server_profile_template_uri:fake_spt_uri\""},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        exc \u003d self.assertRaises("}],"source_content_type":"text/x-python","patch_set":13,"id":"da85f559_0048872c","line":57,"updated":"2015-11-13 15:16:11.000000000","message":"Can we write this as:\n\"capabilities\": (\"enclosure_group_uri:fake_eg_uri,\"\n                 \"server_profile_template_uri:fake_spt_uri\")","commit_id":"2030e62aeec287c63e81301935a4c19f0e789406"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"e21b4a88994f0d09cd25c06fbd5880231faa2ed8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \"local_gb\": \"10\","},{"line_number":55,"context_line":"            \"memory_mb\": \"4096\","},{"line_number":56,"context_line":"            \"capabilities\": \"enclosure_group_uri:fake_eg_uri,\""},{"line_number":57,"context_line":"                            \"server_profile_template_uri:fake_spt_uri\""},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        exc \u003d self.assertRaises("}],"source_content_type":"text/x-python","patch_set":13,"id":"da85f559_20590b8f","line":57,"in_reply_to":"da85f559_0048872c","updated":"2015-11-13 15:22:02.000000000","message":"Done","commit_id":"2030e62aeec287c63e81301935a4c19f0e789406"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5d45fb183e74f289a4ef57fb3c9d3aa22315b7b6","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_verify_node_info_missing_spt(self):"},{"line_number":83,"context_line":"        properties \u003d db_utils.get_test_oneview_properties()"},{"line_number":84,"context_line":"        properties[\"capabilities\"] \u003d \"server_hardware_type_uri:fake_sht_uri,\" \\"},{"line_number":85,"context_line":"                                     \"enclosure_group_uri:fake_eg_uri\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.node.properties \u003d properties"}],"source_content_type":"text/x-python","patch_set":13,"id":"da85f559_a002dbb2","line":84,"updated":"2015-11-13 15:16:11.000000000","message":"Can we write this as:\nproperties[\"capabilities\"] \u003d (\"enclosure_group_uri:fake_eg_uri,\"\n                              \"server_profile_template_uri:fake_spt_uri\")","commit_id":"2030e62aeec287c63e81301935a4c19f0e789406"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"e21b4a88994f0d09cd25c06fbd5880231faa2ed8","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_verify_node_info_missing_spt(self):"},{"line_number":83,"context_line":"        properties \u003d db_utils.get_test_oneview_properties()"},{"line_number":84,"context_line":"        properties[\"capabilities\"] \u003d \"server_hardware_type_uri:fake_sht_uri,\" \\"},{"line_number":85,"context_line":"                                     \"enclosure_group_uri:fake_eg_uri\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        self.node.properties \u003d properties"}],"source_content_type":"text/x-python","patch_set":13,"id":"da85f559_20b58b7d","line":84,"in_reply_to":"da85f559_a002dbb2","updated":"2015-11-13 15:22:02.000000000","message":"Done","commit_id":"2030e62aeec287c63e81301935a4c19f0e789406"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5d45fb183e74f289a4ef57fb3c9d3aa22315b7b6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        driver_info \u003d db_utils.get_test_oneview_driver_info()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        properties \u003d db_utils.get_test_oneview_properties()"},{"line_number":118,"context_line":"        properties[\"capabilities\"] \u003d \"server_hardware_type_uri:fake_sht_uri,\" \\"},{"line_number":119,"context_line":"                                     \"enclosure_group_uri:fake_eg_uri\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        self.node.driver_info \u003d driver_info"}],"source_content_type":"text/x-python","patch_set":13,"id":"da85f559_80beb7d2","line":118,"updated":"2015-11-13 15:16:11.000000000","message":"ditto","commit_id":"2030e62aeec287c63e81301935a4c19f0e789406"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"e21b4a88994f0d09cd25c06fbd5880231faa2ed8","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        driver_info \u003d db_utils.get_test_oneview_driver_info()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        properties \u003d db_utils.get_test_oneview_properties()"},{"line_number":118,"context_line":"        properties[\"capabilities\"] \u003d \"server_hardware_type_uri:fake_sht_uri,\" \\"},{"line_number":119,"context_line":"                                     \"enclosure_group_uri:fake_eg_uri\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        self.node.driver_info \u003d driver_info"}],"source_content_type":"text/x-python","patch_set":13,"id":"da85f559_a0a97b26","line":118,"in_reply_to":"da85f559_80beb7d2","updated":"2015-11-13 15:22:02.000000000","message":"Done","commit_id":"2030e62aeec287c63e81301935a4c19f0e789406"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5d45fb183e74f289a4ef57fb3c9d3aa22315b7b6","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        driver_info[\u0027server_profile_template_uri\u0027] \u003d \u0027fake_spt_uri\u0027"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        properties \u003d db_utils.get_test_oneview_properties()"},{"line_number":147,"context_line":"        properties[\"capabilities\"] \u003d \"server_hardware_type_uri:fake_sht_uri,\" \\"},{"line_number":148,"context_line":"                                     \"enclosure_group_uri:fake_eg_uri\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.node.driver_info \u003d driver_info"}],"source_content_type":"text/x-python","patch_set":13,"id":"da85f559_80a557b6","line":147,"updated":"2015-11-13 15:16:11.000000000","message":"ditto","commit_id":"2030e62aeec287c63e81301935a4c19f0e789406"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"e21b4a88994f0d09cd25c06fbd5880231faa2ed8","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        driver_info[\u0027server_profile_template_uri\u0027] \u003d \u0027fake_spt_uri\u0027"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        properties \u003d db_utils.get_test_oneview_properties()"},{"line_number":147,"context_line":"        properties[\"capabilities\"] \u003d \"server_hardware_type_uri:fake_sht_uri,\" \\"},{"line_number":148,"context_line":"                                     \"enclosure_group_uri:fake_eg_uri\""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.node.driver_info \u003d driver_info"}],"source_content_type":"text/x-python","patch_set":13,"id":"da85f559_206cab07","line":147,"in_reply_to":"da85f559_80a557b6","updated":"2015-11-13 15:22:02.000000000","message":"Done","commit_id":"2030e62aeec287c63e81301935a4c19f0e789406"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"16f380e8471f8efc576bbaf788c2bbcd17161037","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # must be valid"},{"line_number":200,"context_line":"        common.verify_node_info(deprecated_node)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def test__verify_node_info(self):"},{"line_number":203,"context_line":"        common._verify_node_info(\"properties\","}],"source_content_type":"text/x-python","patch_set":14,"id":"ba8a016a_7ad79fbf","line":200,"updated":"2015-11-17 14:48:25.000000000","message":"log_mock is not used, either remove it or maybe assert that it was not called.","commit_id":"189f2eb3ef349da94bbf88937a308dcc4603d3fe"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"6776d88cd9d39dfe4b4c5e0f9c73a016db7f1779","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # must be valid"},{"line_number":200,"context_line":"        common.verify_node_info(deprecated_node)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def test__verify_node_info(self):"},{"line_number":203,"context_line":"        common._verify_node_info(\"properties\","}],"source_content_type":"text/x-python","patch_set":14,"id":"ba8a016a_2c3f6825","line":200,"in_reply_to":"ba8a016a_7ad79fbf","updated":"2015-11-18 15:24:01.000000000","message":"Done","commit_id":"189f2eb3ef349da94bbf88937a308dcc4603d3fe"}]}