)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"d2a346e24a8377842ba525bc69f2cae1bbbb6b74","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"take_over() doesnt recreate boot iso"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"take_over() for iscsi_ilo drivers doesnt recreate"},{"line_number":10,"context_line":"boot iso as the instance_info[\u0027ilo_boot_iso\u0027] is"},{"line_number":11,"context_line":"not cleared before doing recreation of boot iso."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa80f949_24ca7fa2","line":9,"updated":"2015-11-04 07:37:01.000000000","message":"Also commit message is wrong now.  It has nothing to do with cleaning ilo_boot_iso.\n\nShould be something like\n\n  take_over for iscsi_ilo driver doesnt recreate boot iso\n\n  When using web server for hosting images for ilo driver,\n  take_over should recreate the boot ISO, if it was created\n  by Ironic.","commit_id":"1392e2fa5071e8c540569f14f8f7743ca4303b31"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"742f076ea5d1d421b751c95ba76d8346c68ff917","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-12 14:32:08 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds test case for the bug #1510425"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using web server for hosting images for ilo driver,"},{"line_number":10,"context_line":"take_over should recreate the boot ISO, if it was created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da85f559_99c96d5d","line":7,"updated":"2015-11-13 06:45:43.000000000","message":"Mentioning bug ID in commit header is not our way of doing things.  May be we can just mention \n\n  Add a missing test case for iscsi_ilo take_over scenario","commit_id":"25394c4d619b72c1bb2f2fdca358c9295780ab52"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"742f076ea5d1d421b751c95ba76d8346c68ff917","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When using web server for hosting images for ilo driver,"},{"line_number":10,"context_line":"take_over should recreate the boot ISO, if it was created"},{"line_number":11,"context_line":"by Ironic. This fix is done as part of the feature patch"},{"line_number":12,"context_line":"https://review.openstack.org/#/c/216538/ in boot.py from"},{"line_number":13,"context_line":"lines 117-122."},{"line_number":14,"context_line":"The test case for this bug is missing in the feature patch"},{"line_number":15,"context_line":"and hence adding it here in this patch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da85f559_59c30539","line":12,"updated":"2015-11-13 06:45:43.000000000","message":"Please replace this with Change ID","commit_id":"25394c4d619b72c1bb2f2fdca358c9295780ab52"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"742f076ea5d1d421b751c95ba76d8346c68ff917","unresolved":false,"context_lines":[{"line_number":14,"context_line":"The test case for this bug is missing in the feature patch"},{"line_number":15,"context_line":"and hence adding it here in this patch."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"related-to: #1510425"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I6b7f3901f773a5aba906c50dcbd574412f7b6af3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da85f559_f9eaf9ab","line":17,"updated":"2015-11-13 06:45:43.000000000","message":"This should be Related-Bug: \n\nRefer https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"25394c4d619b72c1bb2f2fdca358c9295780ab52"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"737670441fce9e94ca847218b133a07ed10c9ac0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # Recreate the boot iso"},{"line_number":93,"context_line":"            boot_iso \u003d _get_boot_iso(task, root_uuid)"},{"line_number":94,"context_line":"        except Exception as e:"},{"line_number":95,"context_line":"            instance_info[\u0027ilo_boot_iso\u0027] \u003d old_boot_iso"},{"line_number":96,"context_line":"            LOG.warning(_LW(\"Boot iso recreation failed during take over. \""},{"line_number":97,"context_line":"                            \"Reason: %(reason)s. The node %(node)s may not \""},{"line_number":98,"context_line":"                            \"come up with current boot_iso %(boot_iso)s. \"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_e16d3a05","line":95,"updated":"2015-10-29 05:06:26.000000000","message":"Any reasons to  re-assign old_boot_iso which is not going to work. This function gets called only when boot_iso_created_in_web_server is set.","commit_id":"401682a40faef33d58edf702a4d657d022f3b5e4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"adeb9e26f01631e80308f8ac9f95cc7b78e7b803","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # Recreate the boot iso"},{"line_number":93,"context_line":"            boot_iso \u003d _get_boot_iso(task, root_uuid)"},{"line_number":94,"context_line":"        except Exception as e:"},{"line_number":95,"context_line":"            instance_info[\u0027ilo_boot_iso\u0027] \u003d old_boot_iso"},{"line_number":96,"context_line":"            LOG.warning(_LW(\"Boot iso recreation failed during take over. \""},{"line_number":97,"context_line":"                            \"Reason: %(reason)s. The node %(node)s may not \""},{"line_number":98,"context_line":"                            \"come up with current boot_iso %(boot_iso)s. \"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_8f734d15","line":95,"in_reply_to":"1a26ad4f_e16d3a05","updated":"2015-10-29 05:58:33.000000000","message":"Yes else instance_info[\u0027ilo_boot_iso\u0027] would be cleared off and we cannot display it in warning message also below. it will error out there for no key as [\u0027ilo_boot_iso\u0027] in instance_info","commit_id":"401682a40faef33d58edf702a4d657d022f3b5e4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"269737b8d0b9c5e1d622c2b2e27db07aa84dff9f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            boot_iso \u003d _get_boot_iso(task, root_uuid)"},{"line_number":94,"context_line":"        except Exception as e:"},{"line_number":95,"context_line":"            instance_info[\u0027ilo_boot_iso\u0027] \u003d old_boot_iso"},{"line_number":96,"context_line":"            LOG.warning(_LW(\"Boot iso recreation failed during take over. \""},{"line_number":97,"context_line":"                            \"Reason: %(reason)s. The node %(node)s may not \""},{"line_number":98,"context_line":"                            \"come up with current boot_iso %(boot_iso)s. \"),"},{"line_number":99,"context_line":"                        {\u0027boot_iso\u0027: instance_info[\u0027ilo_boot_iso\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_8991009c","line":96,"updated":"2015-10-29 12:42:58.000000000","message":"This will be printed twice if exception occurs, once here and once on L106. We can do return after this log (also in case when we do instance_info \u003d task.node.instance_info.copy() instead of just task.node.instance_info, see below).","commit_id":"401682a40faef33d58edf702a4d657d022f3b5e4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"269737b8d0b9c5e1d622c2b2e27db07aa84dff9f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                         \u0027reason\u0027: e, \u0027node\u0027: task.node.uuid})"},{"line_number":101,"context_line":"        # populate the new ilo_boot_iso in node.instance_info."},{"line_number":102,"context_line":"        if boot_iso:"},{"line_number":103,"context_line":"            instance_info[\u0027ilo_boot_iso\u0027] \u003d boot_iso"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            instance_info[\u0027ilo_boot_iso\u0027] \u003d old_boot_iso"},{"line_number":106,"context_line":"            LOG.warning(_LW(\"Boot iso recreation failed during take over. \""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_891b401b","line":103,"updated":"2015-10-29 12:42:58.000000000","message":"if we did instance_info \u003d task.node.instance_info.copy() we can move task.node.instance_info \u003d instance_info here as this is the only place where we really change something.","commit_id":"401682a40faef33d58edf702a4d657d022f3b5e4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"737670441fce9e94ca847218b133a07ed10c9ac0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        if boot_iso:"},{"line_number":103,"context_line":"            instance_info[\u0027ilo_boot_iso\u0027] \u003d boot_iso"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            instance_info[\u0027ilo_boot_iso\u0027] \u003d old_boot_iso"},{"line_number":106,"context_line":"            LOG.warning(_LW(\"Boot iso recreation failed during take over. \""},{"line_number":107,"context_line":"                            \"The node %(node)s may not come up \""},{"line_number":108,"context_line":"                            \"with current boot_iso %(boot_iso)s. \"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_411c2e77","line":105,"updated":"2015-10-29 05:06:26.000000000","message":"ditto.","commit_id":"401682a40faef33d58edf702a4d657d022f3b5e4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"adeb9e26f01631e80308f8ac9f95cc7b78e7b803","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        if boot_iso:"},{"line_number":103,"context_line":"            instance_info[\u0027ilo_boot_iso\u0027] \u003d boot_iso"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            instance_info[\u0027ilo_boot_iso\u0027] \u003d old_boot_iso"},{"line_number":106,"context_line":"            LOG.warning(_LW(\"Boot iso recreation failed during take over. \""},{"line_number":107,"context_line":"                            \"The node %(node)s may not come up \""},{"line_number":108,"context_line":"                            \"with current boot_iso %(boot_iso)s. \"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_4f645548","line":105,"in_reply_to":"1a26ad4f_411c2e77","updated":"2015-10-29 05:58:33.000000000","message":"ditto","commit_id":"401682a40faef33d58edf702a4d657d022f3b5e4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"269737b8d0b9c5e1d622c2b2e27db07aa84dff9f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    {\u0027boot_iso\u0027: instance_info[\u0027ilo_boot_iso\u0027],"},{"line_number":119,"context_line":"                     \u0027node\u0027: task.node.uuid})"},{"line_number":120,"context_line":"    task.node.instance_info \u003d instance_info"},{"line_number":121,"context_line":"    task.node.save()"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"def _get_boot_iso_object_name(node):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_09e890b3","line":121,"updated":"2015-10-29 12:42:58.000000000","message":"Also I\u0027m not sure if we need to save here, as node is being saved in manager.py - https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1371","commit_id":"401682a40faef33d58edf702a4d657d022f3b5e4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"98a6c565681deea6a6d98c129556e336c62cac56","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            LOG.warning(_LW(\"Boot iso recreation failed during take over. \""},{"line_number":92,"context_line":"                            \"Reason: %(reason)s. The node %(node)s may not \""},{"line_number":93,"context_line":"                            \"come up with current boot_iso %(boot_iso)s. \"),"},{"line_number":94,"context_line":"                        {\u0027boot_iso\u0027: task.node.instance_info[\u0027ilo_boot_iso\u0027],"},{"line_number":95,"context_line":"                         \u0027reason\u0027: e, \u0027node\u0027: task.node.uuid})"},{"line_number":96,"context_line":"        # populate the new ilo_boot_iso in node.instance_info."},{"line_number":97,"context_line":"        if boot_iso:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_246effc9","line":94,"updated":"2015-11-04 07:34:28.000000000","message":"Why do we need this changed from instance_info[\u0027ilo_boot_iso\u0027] to task.node.instance_info[\u0027ilo_boot_iso\u0027] ? Ditto on 105, 114.  \n\nI assume it would have worked well before as well.  _get_boot_iso() doesn\u0027t chance node\u0027s instance_info.","commit_id":"1392e2fa5071e8c540569f14f8f7743ca4303b31"}],"ironic/tests/unit/drivers/modules/ilo/test_deploy.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"98a6c565681deea6a6d98c129556e336c62cac56","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            capability_mock, boot_object_name_mock,"},{"line_number":237,"context_line":"            create_boot_iso_mock, tempfile_mock,"},{"line_number":238,"context_line":"            copy_file_mock):"},{"line_number":239,"context_line":"        CONF.ilo.swift_ilo_container \u003d \u0027ilo-cont\u0027"},{"line_number":240,"context_line":"        CONF.ilo.use_web_server_for_images \u003d True"},{"line_number":241,"context_line":"        CONF.deploy.http_url \u003d \"http://10.10.1.30/httpboot\""},{"line_number":242,"context_line":"        CONF.deploy.http_root \u003d \"/httpboot\""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_6482c754","side":"PARENT","line":239,"updated":"2015-11-04 07:34:28.000000000","message":"Here too, is this part of this change ?","commit_id":"23ea8585395a971018c9090a08d77c28728b7ded"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"98a6c565681deea6a6d98c129556e336c62cac56","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":646,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":647,"context_line":"            driver_internal_info[\u0027root_uuid_or_disk_id\u0027] \u003d \u0027root-uuid\u0027"},{"line_number":648,"context_line":"            instance_info \u003d task.node.instance_info"},{"line_number":649,"context_line":"            instance_info[\u0027ilo_boot_iso\u0027] \u003d \u0027boot-uuid-conductor-1\u0027"},{"line_number":650,"context_line":"            task.node.instance_info \u003d instance_info"},{"line_number":651,"context_line":"            task.node.save()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_44aa23d6","line":648,"updated":"2015-11-04 07:34:28.000000000","message":"Why are we changing this test case ? While changing this is good, I feel it shouldn\u0027t be part of this patch.  I suggest we restrict the changes to what is required to fix the bug and corresponding test case for that bug.","commit_id":"1392e2fa5071e8c540569f14f8f7743ca4303b31"}]}