)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"271bc3c058b083f8559954d7a495d01292f2f88c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Get mandatory patch attrs from WSME properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1284781"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Attributes which are mandatory (ie, required for object creation) should"},{"line_number":12,"context_line":"not be removable. However, some attributes (such as Node.chassis_uuid)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da85f559_9fba5f6d","line":9,"updated":"2015-11-10 10:43:16.000000000","message":"closes-bug usually goes in the end","commit_id":"a072d9089fbdc4d228b8743e6ef42274cf941508"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"271bc3c058b083f8559954d7a495d01292f2f88c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"are not required for object creation, but should not be removable if"},{"line_number":14,"context_line":"they are set. This commit does the following:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":" - rename JsonPatchType.mandatory_attrs to unremovable_attrs to better"},{"line_number":17,"context_line":"   describe its meaning,"},{"line_number":18,"context_line":" - ensure all mandatory attributes on the type being patched are"},{"line_number":19,"context_line":"   included in the list of unremovable attributes,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da85f559_3fb25395","line":16,"updated":"2015-11-10 10:43:16.000000000","message":"I guess more correct would be \"non_removable_attrs\". \"unremovable\" reads like there\u0027s an \"unremove\" operation for them :)","commit_id":"a072d9089fbdc4d228b8743e6ef42274cf941508"}],"ironic/api/controllers/v1/chassis.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"476a21707435e4136409ba1321df7454545d4037","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class ChassisPatchType(types.JsonPatchType):"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    _base_type \u003d Chassis"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class ChassisCollection(collection.Collection):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_0e7df66d","line":123,"updated":"2015-10-29 11:55:44.000000000","message":"_api_base?","commit_id":"d408bba74c945ec33a176bb4b06f0982c78c3de0"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"476a21707435e4136409ba1321df7454545d4037","unresolved":false,"context_lines":[{"line_number":596,"context_line":"    \"\"\"The physical characteristics of this node\"\"\""},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    chassis_uuid \u003d wsme.wsproperty(types.uuid, _get_chassis_uuid,"},{"line_number":599,"context_line":"                                   _set_chassis_uuid)"},{"line_number":600,"context_line":"    \"\"\"The UUID of the chassis this node belongs\"\"\""},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_8e56e6d0","line":599,"updated":"2015-10-29 11:55:44.000000000","message":"This becomes not mandatory.","commit_id":"d408bba74c945ec33a176bb4b06f0982c78c3de0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"69898dc9cd530e136335ef15b26b80c3b5ca0e49","unresolved":false,"context_lines":[{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    _api_base \u003d Node"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    _extra_non_removable_attrs \u003d {\u0027/chassis_uuid\u0027}"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    @staticmethod"},{"line_number":725,"context_line":"    def internal_attrs():"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_64a1b0f7","line":722,"updated":"2015-11-12 12:25:50.000000000","message":"-1 this is the correct syntax","commit_id":"9455f3c62b0817b980b2c028798aa66c0a722903"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"18e481913bdb5d557a96289e1c30980fa2a1f866","unresolved":false,"context_lines":[{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    _api_base \u003d Node"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    _extra_non_removable_attrs \u003d {\u0027/chassis_uuid\u0027}"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    @staticmethod"},{"line_number":725,"context_line":"    def internal_attrs():"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_2f2997e6","line":722,"updated":"2015-11-11 02:51:23.000000000","message":"nit: use set([\u0027/chassis_uuid\u0027]) to keep consistence with other parts in Ironic?","commit_id":"9455f3c62b0817b980b2c028798aa66c0a722903"}],"ironic/api/controllers/v1/types.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"476a21707435e4136409ba1321df7454545d4037","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                    cls._api_base,"},{"line_number":261,"context_line":"                    lambda a: not(inspect.isroutine(a)))"},{"line_number":262,"context_line":"                for name, field in fields:"},{"line_number":263,"context_line":"                    if hasattr(field, \u0027mandatory\u0027) and field.mandatory:"},{"line_number":264,"context_line":"                        cls._mandatory_attrs.append(\u0027/%s\u0027 % name)"},{"line_number":265,"context_line":"        return cls._mandatory_attrs"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_eeabdad4","line":263,"updated":"2015-10-29 11:55:44.000000000","message":"nit - if getattr(field, \u0027mandatory\u0027, False)","commit_id":"d408bba74c945ec33a176bb4b06f0982c78c3de0"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5c4d7459a8a5cdf4f975539c7e43e2dae05f56f2","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        [\u0027/foo\u0027, \u0027/bar\u0027]."},{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        if cls._unremovable_attrs is None:"},{"line_number":264,"context_line":"            cls._unremovable_attrs \u003d cls._extra_unremovable_attrs"},{"line_number":265,"context_line":"            if cls._api_base:"},{"line_number":266,"context_line":"                fields \u003d inspect.getmembers("},{"line_number":267,"context_line":"                    cls._api_base,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_de24c2b0","line":264,"updated":"2015-11-03 15:36:56.000000000","message":"Should it be cls._extra_unremovable_attrs[:]? It does not break anything, just seems to be more correct.","commit_id":"24d6992fa79d54a3e99aa344468cb2112131e1e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5c4d7459a8a5cdf4f975539c7e43e2dae05f56f2","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        if cls._unremovable_attrs is None:"},{"line_number":264,"context_line":"            cls._unremovable_attrs \u003d cls._extra_unremovable_attrs"},{"line_number":265,"context_line":"            if cls._api_base:"},{"line_number":266,"context_line":"                fields \u003d inspect.getmembers("},{"line_number":267,"context_line":"                    cls._api_base,"},{"line_number":268,"context_line":"                    lambda a: not(inspect.isroutine(a)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_1ef32a75","line":265,"updated":"2015-11-03 15:36:56.000000000","message":"Should there be else part of this if? As if it is None, None will be returned from this function, and \u0027patch.path in patch.unremovable_attrs()\u0027 will fail.","commit_id":"24d6992fa79d54a3e99aa344468cb2112131e1e7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"271bc3c058b083f8559954d7a495d01292f2f88c","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        Attributes whose \u0027mandatory\u0027 property is True are automatically added"},{"line_number":259,"context_line":"        to this list. To add additional attributes to the list, override the"},{"line_number":260,"context_line":"        field _extra_unremovable_attrs in subclasses, with a list of the form"},{"line_number":261,"context_line":"        [\u0027/foo\u0027, \u0027/bar\u0027]."},{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        if cls._unremovable_attrs is None:"},{"line_number":264,"context_line":"            cls._unremovable_attrs \u003d cls._extra_unremovable_attrs[:]"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_5fadd72f","line":261,"updated":"2015-11-10 10:43:16.000000000","message":"let\u0027s create a set, not a list - lookups will be slightly more efficient","commit_id":"a072d9089fbdc4d228b8743e6ef42274cf941508"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"271bc3c058b083f8559954d7a495d01292f2f88c","unresolved":false,"context_lines":[{"line_number":265,"context_line":"            if cls._api_base:"},{"line_number":266,"context_line":"                fields \u003d inspect.getmembers("},{"line_number":267,"context_line":"                    cls._api_base,"},{"line_number":268,"context_line":"                    lambda a: not(inspect.isroutine(a)))"},{"line_number":269,"context_line":"                for name, field in fields:"},{"line_number":270,"context_line":"                    if getattr(field, \u0027mandatory\u0027, False):"},{"line_number":271,"context_line":"                        cls._unremovable_attrs.append(\u0027/%s\u0027 % name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_ffab6b1b","line":268,"updated":"2015-11-10 10:43:16.000000000","message":"nit: () are not required for \u0027not\u0027","commit_id":"a072d9089fbdc4d228b8743e6ef42274cf941508"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"18e481913bdb5d557a96289e1c30980fa2a1f866","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    # removed if set. Override in subclasses if needed."},{"line_number":239,"context_line":"    _extra_non_removable_attrs \u003d set()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    # List of non-removable attributes, calculated lazily."},{"line_number":242,"context_line":"    _non_removable_attrs \u003d None"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_2f575759","line":241,"updated":"2015-11-11 02:51:23.000000000","message":"List? a little confuse","commit_id":"9455f3c62b0817b980b2c028798aa66c0a722903"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"69898dc9cd530e136335ef15b26b80c3b5ca0e49","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    @classmethod"},{"line_number":255,"context_line":"    def non_removable_attrs(cls):"},{"line_number":256,"context_line":"        \"\"\"Returns a list of attributes that may not be removed."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        Attributes whose \u0027mandatory\u0027 property is True are automatically added"},{"line_number":259,"context_line":"        to this list. To add additional attributes to the list, override the"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_04a46405","line":256,"updated":"2015-11-12 12:25:50.000000000","message":"+1, it\u0027s a set, not a list","commit_id":"9455f3c62b0817b980b2c028798aa66c0a722903"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"18e481913bdb5d557a96289e1c30980fa2a1f866","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    @classmethod"},{"line_number":255,"context_line":"    def non_removable_attrs(cls):"},{"line_number":256,"context_line":"        \"\"\"Returns a list of attributes that may not be removed."},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        Attributes whose \u0027mandatory\u0027 property is True are automatically added"},{"line_number":259,"context_line":"        to this list. To add additional attributes to the list, override the"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_4fdbbbec","line":256,"updated":"2015-11-11 02:51:23.000000000","message":"Could you explicit specify the type of return values?","commit_id":"9455f3c62b0817b980b2c028798aa66c0a722903"}]}
