)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"14467c77d013aaf21777e3417811eaa9d8e19331","unresolved":false,"context_lines":[{"line_number":14,"context_line":"driver interfaces may handle \"failing\" while raising exceptions[4], too"},{"line_number":15,"context_line":"(iscsi_deploy)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The suggested patch purpose is to advance the FSM only in case an exception"},{"line_number":18,"context_line":"happened while in either DEPLOYWAIT or DEPLOYING states to avoid FSM jam"},{"line_number":19,"context_line":"while handling the exception[4]"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a26ad4f_810d0fea","line":17,"updated":"2015-11-02 10:56:24.000000000","message":"I think your point is to recheck the provision state before calling deploy_utils.set_provision_state().  I am not sure if there is a repetition in the points and can be conveyed in a sentence.\n\nHow about rephrasing the commit message to something like:\n\n  Cautiously fail on unhandled heartbeat exception\n\n  Currently, BaseAgentVendor.hearbeat handles uncaught exceptions by\n  advancing FSM with the \"failed\" event.  However, some drivers may\n  do error handling on their own and may advance FSM with the \u0027fail\u0027\n  event themselves.  The suggested patch purpose is to advance \n  the FSM only in case node is still in DEPLOYWAIT or DEPLOYING state\n  while handling the exception.","commit_id":"c3221875e101b6ce47a2bdf1f48f583937fdb74d"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"0fdef43a9f2c6984a9cb428dd3864f0c506a0d3c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"driver interfaces may handle \"failing\" while raising exceptions[4], too"},{"line_number":15,"context_line":"(iscsi_deploy)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The suggested patch purpose is to advance the FSM only in case an exception"},{"line_number":18,"context_line":"happened while in either DEPLOYWAIT or DEPLOYING states to avoid FSM jam"},{"line_number":19,"context_line":"while handling the exception[4]"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a26ad4f_df274ab4","line":17,"in_reply_to":"1a26ad4f_810d0fea","updated":"2015-11-02 19:16:09.000000000","message":"Done","commit_id":"c3221875e101b6ce47a2bdf1f48f583937fdb74d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"14467c77d013aaf21777e3417811eaa9d8e19331","unresolved":false,"context_lines":[{"line_number":18,"context_line":"happened while in either DEPLOYWAIT or DEPLOYING states to avoid FSM jam"},{"line_number":19,"context_line":"while handling the exception[4]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/"},{"line_number":22,"context_line":"      agent_base_vendor.py#L372"},{"line_number":23,"context_line":"[2] http://docs.openstack.org/developer/ironic/_images/states.svg"},{"line_number":24,"context_line":"[3] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a26ad4f_e4d656f0","line":21,"updated":"2015-11-02 10:56:24.000000000","message":"Specifying lines from github will become stale very fast.  This might point to the wrong code very soon.  This can be removed.\n\nPlease add it as comment in gerrit if you wanted others to check something before looking at code.","commit_id":"c3221875e101b6ce47a2bdf1f48f583937fdb74d"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"0fdef43a9f2c6984a9cb428dd3864f0c506a0d3c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"happened while in either DEPLOYWAIT or DEPLOYING states to avoid FSM jam"},{"line_number":19,"context_line":"while handling the exception[4]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/"},{"line_number":22,"context_line":"      agent_base_vendor.py#L372"},{"line_number":23,"context_line":"[2] http://docs.openstack.org/developer/ironic/_images/states.svg"},{"line_number":24,"context_line":"[3] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a26ad4f_ff2c869a","line":21,"in_reply_to":"1a26ad4f_e4d656f0","updated":"2015-11-02 19:16:09.000000000","message":"Done","commit_id":"c3221875e101b6ce47a2bdf1f48f583937fdb74d"}],"ironic/tests/unit/drivers/modules/test_agent_base_vendor.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"868e5ab353dcab122473e6b4dd72ffc6416cee54","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            # deploy_utils.set_failed_state anymore"},{"line_number":354,"context_line":"            self.assertFalse(failed_mock.called)"},{"line_number":355,"context_line":"        log_mock.assert_called_once_with("},{"line_number":356,"context_line":"            \u0027Asynchronous exception for node \u0027"},{"line_number":357,"context_line":"            \u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123: Failed checking if deploy \u0027"},{"line_number":358,"context_line":"            \u0027is done. exception: LlamaException\u0027)"},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_4f7ee2af","line":356,"updated":"2015-11-03 14:20:08.000000000","message":"We do not mock the exact message, but just validate that LOG being called. But this file has instances of exact log messages being verified.\nself.assertTrue(log_mock.called)","commit_id":"c6c885858a658b0a2d11be200133a3f530f1b6a1"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"c6c9530bb2a03b44e038a21a3141501002995631","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            # deploy_utils.set_failed_state anymore"},{"line_number":354,"context_line":"            self.assertFalse(failed_mock.called)"},{"line_number":355,"context_line":"        log_mock.assert_called_once_with("},{"line_number":356,"context_line":"            \u0027Asynchronous exception for node \u0027"},{"line_number":357,"context_line":"            \u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123: Failed checking if deploy \u0027"},{"line_number":358,"context_line":"            \u0027is done. exception: LlamaException\u0027)"},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_85a2de49","line":356,"in_reply_to":"fa80f949_4f7ee2af","updated":"2015-11-06 12:06:15.000000000","message":"My understanding is since we assert a try--except block, the log message is being used as a sentinel here. Better to check the precise log message to avoid a false-positive here (different block of code using logger making one assume the concerned try--except block was called).","commit_id":"c6c885858a658b0a2d11be200133a3f530f1b6a1"}]}