)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"29553b75118d4300db20d7af1baafd9f86f83269","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-11-18 11:32:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add SSL support to the Ironic API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-bug: #1430213"},{"line_number":10,"context_line":"Change-Id: Id4b84d83f9aa6c7f898b3b9b59158d5b1a00e159"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ba8a016a_4f38a93d","line":8,"updated":"2015-11-18 11:53:02.000000000","message":"The commit message is very shallow here.\n\nThis patch is adding new config options and add a dependency on oslo.service.sslutils, I believe this all should be mentioned in the commit message since it\u0027s suppose to summarize what the patch is doing.","commit_id":"d341195de870dcb88c64bcbbb34ac6fbd6f2bc34"}],"ironic/api/__init__.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c9d91689e1f013e8912e1a00355ddeab1ba62d16","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                      \u0027count of 1 is returned.\u0027)),"},{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027enable_ssl_api\u0027,"},{"line_number":46,"context_line":"                default\u003dFalse,"},{"line_number":47,"context_line":"                help\u003d\u0027Use API with SSL if true.\u0027),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_221e8b5f","line":47,"updated":"2015-11-01 07:34:33.000000000","message":"I feel like a more verbose description may be required here.  From the standpoint of an operator, I would wonder \"What does it enforce behavior wise?\" \"When should I set this, and when should I not?\"","commit_id":"eec2082f162cc771cafccbaf92f5fe5bfa7bc4fc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ff65680faf37bb8258bafad10ca3eab0947222cb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                      \u0027count of 1 is returned.\u0027)),"},{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027enable_ssl_api\u0027,"},{"line_number":46,"context_line":"                default\u003dFalse,"},{"line_number":47,"context_line":"                help\u003d_(\"Allow API to perform SSL (https) requests if true.\")),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_1f5dbd78","line":47,"updated":"2015-11-02 23:06:31.000000000","message":"To me, this reads as \"I as the API will perform all requests to other things behind my API utilizing SSL (HTTPS)\" although I don\u0027t think that is the intention, what about:\n\n\"Enable the integrated stand-alone API to service requests via HTTPS instead of HTTP.  If there is a front-end service performing HTTPS offloading from the service... *insert more words here*\"","commit_id":"1aba58c0a5660892de921d046843f31b0ff3c2a8"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a902f94f7be7d8282b76d92043a3e4753de86996","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                      \u0027count of 1 is returned.\u0027)),"},{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027enable_ssl_api\u0027,"},{"line_number":46,"context_line":"                default\u003dFalse,"},{"line_number":47,"context_line":"                help\u003d_(\"Allow API to perform SSL (https) requests if true.\")),"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_67f990c8","line":47,"in_reply_to":"1a26ad4f_1f5dbd78","updated":"2015-11-03 15:36:44.000000000","message":"Done","commit_id":"1aba58c0a5660892de921d046843f31b0ff3c2a8"}],"ironic/common/service.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ff65680faf37bb8258bafad10ca3eab0947222cb","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def __init__(self, name, use_ssl\u003dFalse):"},{"line_number":154,"context_line":"        \"\"\"Initialize, but do not start the WSGI server."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        :param name: The name of the WSGI server given to the loader."},{"line_number":157,"context_line":"        :returns: None"},{"line_number":158,"context_line":"        \"\"\""},{"line_number":159,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_3f7bd9f6","line":156,"updated":"2015-11-02 23:06:31.000000000","message":"We likely need use_ssl to be defined as a parameter here.","commit_id":"1aba58c0a5660892de921d046843f31b0ff3c2a8"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a902f94f7be7d8282b76d92043a3e4753de86996","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def __init__(self, name, use_ssl\u003dFalse):"},{"line_number":154,"context_line":"        \"\"\"Initialize, but do not start the WSGI server."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        :param name: The name of the WSGI server given to the loader."},{"line_number":157,"context_line":"        :returns: None"},{"line_number":158,"context_line":"        \"\"\""},{"line_number":159,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_3edb8e1d","line":156,"in_reply_to":"1a26ad4f_3f7bd9f6","updated":"2015-11-03 15:36:44.000000000","message":"Done","commit_id":"1aba58c0a5660892de921d046843f31b0ff3c2a8"}]}
