)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d71b66bdfe19fba9cb3937abb2e935fae623f4ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhenguo Niu \u003cniuzhenguo@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-06 17:15:32 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Not reraise exception in _set_console_mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As _set_console_mode runs in a thread worker in the backgroud,"},{"line_number":10,"context_line":"there\u0027s no way to catch the reraise exception, so change to log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa80f949_131c00c0","line":7,"updated":"2015-11-06 09:47:46.000000000","message":"Don\u0027t reraise the exception in _set_console_mode","commit_id":"e7bcad5028c9eaede535391bb48559edfd039df9"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"a67f3ee110e2f010bd7152a25f7085ac25b7ae87","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhenguo Niu \u003cniuzhenguo@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-06 17:15:32 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Not reraise exception in _set_console_mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As _set_console_mode runs in a thread worker in the backgroud,"},{"line_number":10,"context_line":"there\u0027s no way to catch the reraise exception, so change to log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa80f949_5c5e0c45","line":7,"in_reply_to":"fa80f949_131c00c0","updated":"2015-11-06 14:50:00.000000000","message":"Done","commit_id":"e7bcad5028c9eaede535391bb48559edfd039df9"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"d34844decca2ce3c0ff8d3eda90c15f8ffa7a4f0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As _set_console_mode runs in a thread worker in the backgroud,"},{"line_number":10,"context_line":"there\u0027s no way to catch the reraise exception, so change to log"},{"line_number":11,"context_line":"an error message to handle this more gracefully."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0df54e6600a47b627d1442e92f80f0ff8654e616"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa80f949_33610406","line":12,"updated":"2015-11-06 09:50:40.000000000","message":"Any bug for this?","commit_id":"e7bcad5028c9eaede535391bb48559edfd039df9"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"a67f3ee110e2f010bd7152a25f7085ac25b7ae87","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As _set_console_mode runs in a thread worker in the backgroud,"},{"line_number":10,"context_line":"there\u0027s no way to catch the reraise exception, so change to log"},{"line_number":11,"context_line":"an error message to handle this more gracefully."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0df54e6600a47b627d1442e92f80f0ff8654e616"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa80f949_fc56e028","line":12,"in_reply_to":"fa80f949_33610406","updated":"2015-11-06 14:50:00.000000000","message":"Done","commit_id":"e7bcad5028c9eaede535391bb48559edfd039df9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ffa7047a732998dcb3697012b0ed87c92e782256","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t reraise the exception in _set_console_mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As _set_console_mode runs in a thread worker in the backgroud,"},{"line_number":10,"context_line":"there\u0027s no way to catch the reraise exception, so change to log"},{"line_number":11,"context_line":"an error message to handle this more gracefully."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1513858"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_fcdbb9eb","line":10,"updated":"2015-11-09 09:01:06.000000000","message":"(Just a comment, nothing to be done)\n\nOne could set a hook using task\u0027s set_spawn_error_hook() method for it. But I don\u0027t think it\u0027s needed for this case.","commit_id":"bc6312673d6d2cbb301f491e7f39dd3a5eb511ff"}],"ironic/conductor/manager.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d71b66bdfe19fba9cb3937abb2e935fae623f4ff","unresolved":false,"context_lines":[{"line_number":1688,"context_line":"                # take_over() right now."},{"line_number":1689,"context_line":"            else:"},{"line_number":1690,"context_line":"                task.driver.console.stop_console(task)"},{"line_number":1691,"context_line":"        except Exception as e:"},{"line_number":1692,"context_line":"            op \u003d _(\u0027enabling\u0027) if enabled else _(\u0027disabling\u0027)"},{"line_number":1693,"context_line":"            msg \u003d (_(\u0027Error %(op)s the console on node %(node)s. \u0027"},{"line_number":1694,"context_line":"                     \u0027Reason: %(error)s\u0027) % {\u0027op\u0027: op,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_b3f09468","line":1691,"updated":"2015-11-06 09:47:46.000000000","message":"Any ideas on what kind of exceptions are being caught. It would be nice if this could be more specific on what exceptions are expected.\n\nJust curious and I realize somewhat unrelated to this patch.","commit_id":"e7bcad5028c9eaede535391bb48559edfd039df9"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"d34844decca2ce3c0ff8d3eda90c15f8ffa7a4f0","unresolved":false,"context_lines":[{"line_number":1688,"context_line":"                # take_over() right now."},{"line_number":1689,"context_line":"            else:"},{"line_number":1690,"context_line":"                task.driver.console.stop_console(task)"},{"line_number":1691,"context_line":"        except Exception as e:"},{"line_number":1692,"context_line":"            op \u003d _(\u0027enabling\u0027) if enabled else _(\u0027disabling\u0027)"},{"line_number":1693,"context_line":"            msg \u003d (_(\u0027Error %(op)s the console on node %(node)s. \u0027"},{"line_number":1694,"context_line":"                     \u0027Reason: %(error)s\u0027) % {\u0027op\u0027: op,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_137de0b0","line":1691,"in_reply_to":"fa80f949_b3f09468","updated":"2015-11-06 09:50:40.000000000","message":"+1 for more specific exception","commit_id":"e7bcad5028c9eaede535391bb48559edfd039df9"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"a67f3ee110e2f010bd7152a25f7085ac25b7ae87","unresolved":false,"context_lines":[{"line_number":1688,"context_line":"                # take_over() right now."},{"line_number":1689,"context_line":"            else:"},{"line_number":1690,"context_line":"                task.driver.console.stop_console(task)"},{"line_number":1691,"context_line":"        except Exception as e:"},{"line_number":1692,"context_line":"            op \u003d _(\u0027enabling\u0027) if enabled else _(\u0027disabling\u0027)"},{"line_number":1693,"context_line":"            msg \u003d (_(\u0027Error %(op)s the console on node %(node)s. \u0027"},{"line_number":1694,"context_line":"                     \u0027Reason: %(error)s\u0027) % {\u0027op\u0027: op,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_9edc6974","line":1691,"in_reply_to":"fa80f949_b3f09468","updated":"2015-11-06 14:50:00.000000000","message":"yeah, this is out scope of this patch, I think it should be addressed in another one.","commit_id":"e7bcad5028c9eaede535391bb48559edfd039df9"}]}