)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"646ad7782660b23c79fb0622511543c6f4e64f16","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"# Specify a timeout after which a gracefully shutdown server"},{"line_number":391,"context_line":"# will exit. Zero value means endless wait. (integer value)"},{"line_number":392,"context_line":"#graceful_shutdown_timeout\u003d0"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"[agent]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da85f559_e58d7e2b","line":392,"updated":"2015-11-12 20:57:50.000000000","message":"Are you referring to the oslo.service graceful_shutdown_timeout? I\u0027m assuming so since this value isn\u0027t present anywhere in the Ironic codebase.\n\nIf so, the comment should be updated to reflect that graceful_shutdown_timeout refers to the timeout period for Ironic services, not for a server (node) managed by Ironic.","commit_id":"59398276341b393695ea4145bfab8b2c590574fd"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"646ad7782660b23c79fb0622511543c6f4e64f16","unresolved":false,"context_lines":[{"line_number":483,"context_line":"# The IP address on which ironic-api listens. (string value)"},{"line_number":484,"context_line":"#host_ip\u003d0.0.0.0"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"# The TCP port on which ironic-api listens. (port value)"},{"line_number":487,"context_line":"#port\u003d6385"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"# The maximum number of items returned in a single response"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da85f559_e5033ebd","line":486,"updated":"2015-11-12 20:57:50.000000000","message":"A port has to be an integer, right? https://en.wikipedia.org/wiki/Port_(computer_networking)\n\nIt may be worth it to enforce this at the code level instead of changing the config comment here.","commit_id":"59398276341b393695ea4145bfab8b2c590574fd"}]}