)]}'
{"ironic/common/images.py":[{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"f606fa97032ad173ee35ebef74d1d8e26b313118","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"def download_size(context, image_href, image_service\u003dNone):"},{"line_number":400,"context_line":"    return image_show(context, image_href, image_service)[\u0027size\u0027]"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"def converted_size(path):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_7b1d9dbc","line":400,"updated":"2015-11-24 16:42:40.000000000","message":"Can we convert the return to an int?","commit_id":"66020147d7e744cb4c3d30dafd711d3c26ce3415"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b6c695cfceaa59ecffcc0ff97045047428c02c52","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"def download_size(context, image_href, image_service\u003dNone):"},{"line_number":400,"context_line":"    return image_show(context, image_href, image_service)[\u0027size\u0027]"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"def converted_size(path):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_1e81da4a","line":400,"in_reply_to":"9a8ffd7b_7b1d9dbc","updated":"2015-11-24 18:13:59.000000000","message":"Right, I left it untouched cause it\u0027s outside of the patch scope to change the behavior of this function. \n\nBut yeah I agree that this would come handy if the conversion happened here","commit_id":"66020147d7e744cb4c3d30dafd711d3c26ce3415"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0acddb3e59fc12fbb915fa58cdfc3d022de9a269","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    image_show \u003d images.image_show(task.context, image_source)"},{"line_number":153,"context_line":"    if CONF.agent.stream_raw_images and image_show[\u0027disk_format\u0027] \u003d\u003d \u0027raw\u0027:"},{"line_number":154,"context_line":"        LOG.info(\u0027Skip the image size check since the image is going to be \u0027"},{"line_number":155,"context_line":"                 \u0027streamed directly onto the disk for node %s\u0027, task.node.uuid)"},{"line_number":156,"context_line":"        return"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    memory_size \u003d int(properties.get(\u0027memory_mb\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_30365404","line":155,"updated":"2015-11-24 16:28:40.000000000","message":"this should be debug","commit_id":"66020147d7e744cb4c3d30dafd711d3c26ce3415"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a8f3f5a85e37c21ca13af43a34fafbf596dc8f09","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    image_show \u003d images.image_show(task.context, image_source)"},{"line_number":153,"context_line":"    if CONF.agent.stream_raw_images and image_show[\u0027disk_format\u0027] \u003d\u003d \u0027raw\u0027:"},{"line_number":154,"context_line":"        LOG.info(\u0027Skip the image size check since the image is going to be \u0027"},{"line_number":155,"context_line":"                 \u0027streamed directly onto the disk for node %s\u0027, task.node.uuid)"},{"line_number":156,"context_line":"        return"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    memory_size \u003d int(properties.get(\u0027memory_mb\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_7b5fdd0e","line":155,"in_reply_to":"9a8ffd7b_30365404","updated":"2015-11-24 16:36:34.000000000","message":"Done","commit_id":"66020147d7e744cb4c3d30dafd711d3c26ce3415"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"f606fa97032ad173ee35ebef74d1d8e26b313118","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    memory_size \u003d int(properties.get(\u0027memory_mb\u0027))"},{"line_number":159,"context_line":"    image_size \u003d int(image_show[\u0027size\u0027])"},{"line_number":160,"context_line":"    reserved_size \u003d CONF.agent.memory_consumed_by_agent"},{"line_number":161,"context_line":"    if (image_size + (reserved_size * units.Mi)) \u003e (memory_size * units.Mi):"},{"line_number":162,"context_line":"        msg \u003d (_(\u0027Memory size is too small for requested image, if it is \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_7be27da1","line":159,"updated":"2015-11-24 16:42:40.000000000","message":"I think we could just convert the return of \"download_size\" function. If implemented comment in images.py, we don\u0027t need to convert to int anymore.","commit_id":"66020147d7e744cb4c3d30dafd711d3c26ce3415"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b6c695cfceaa59ecffcc0ff97045047428c02c52","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    memory_size \u003d int(properties.get(\u0027memory_mb\u0027))"},{"line_number":159,"context_line":"    image_size \u003d int(image_show[\u0027size\u0027])"},{"line_number":160,"context_line":"    reserved_size \u003d CONF.agent.memory_consumed_by_agent"},{"line_number":161,"context_line":"    if (image_size + (reserved_size * units.Mi)) \u003e (memory_size * units.Mi):"},{"line_number":162,"context_line":"        msg \u003d (_(\u0027Memory size is too small for requested image, if it is \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_1ef8fae4","line":159,"in_reply_to":"9a8ffd7b_7be27da1","updated":"2015-11-24 18:13:59.000000000","message":"commented at image.py\n\nI agree about converting it to int in the download_size() function, but for the scope of this patch this is an unrelated change (changing the behavior of that function)","commit_id":"66020147d7e744cb4c3d30dafd711d3c26ce3415"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"21b841c8658420c7025bdb2c9f146be42a05806e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        return"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    image_show \u003d images.image_show(task.context, image_source)"},{"line_number":155,"context_line":"    if CONF.agent.stream_raw_images and image_show[\u0027disk_format\u0027] \u003d\u003d \u0027raw\u0027:"},{"line_number":156,"context_line":"        LOG.debug(\u0027Skip the image size check since the image is going to be \u0027"},{"line_number":157,"context_line":"                  \u0027streamed directly onto the disk for node %s\u0027, node.uuid)"},{"line_number":158,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_aaa7304e","line":155,"updated":"2015-11-24 17:11:54.000000000","message":"I think this will fail if it is not a glance image, as \u0027disk_format\u0027 is not defined in show for other image_services. Maybe a image_show.get with default to False for now?","commit_id":"71a0223d1dbbff0d4427336ffe79a2c2cd3fdf12"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"998357ecfdefc10ade8b8481ff1889d0200c2b73","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        return"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    image_show \u003d images.image_show(task.context, image_source)"},{"line_number":155,"context_line":"    if CONF.agent.stream_raw_images and image_show[\u0027disk_format\u0027] \u003d\u003d \u0027raw\u0027:"},{"line_number":156,"context_line":"        LOG.debug(\u0027Skip the image size check since the image is going to be \u0027"},{"line_number":157,"context_line":"                  \u0027streamed directly onto the disk for node %s\u0027, node.uuid)"},{"line_number":158,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_5e79a292","line":155,"in_reply_to":"9a8ffd7b_aaa7304e","updated":"2015-11-24 18:14:03.000000000","message":"Oh that\u0027s a good point! I will use a get here","commit_id":"71a0223d1dbbff0d4427336ffe79a2c2cd3fdf12"}]}
