)]}'
{"ironic/tests/unit/common/test_fsm.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6fdefd6c370b47dede29faca4f1f95f0d257e01a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.fsm.initialize(\u0027wakeup\u0027)"},{"line_number":84,"context_line":"        self.fsm.process_event(\u0027walk\u0027, \u0027play\u0027)"},{"line_number":85,"context_line":"        self.assertEqual(\u0027working\u0027, self.fsm.current_state)"},{"line_number":86,"context_line":"        self.assertEqual(\u0027play\u0027, self.fsm.target_state)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # specify an invalid target state"},{"line_number":89,"context_line":"        self.fsm.initialize(\u0027wakeup\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_f3957f32","line":86,"updated":"2015-11-19 14:20:22.000000000","message":"Would it be useful to add a testcase to ensure that the state transition continues seamlessly when target state is overridden and new target state has further transitions.\n\nEx:\nWith respect to above testcase:\n\nself.fsm.add_state(\u0027rest\u0027, stable\u003dTrue)\n\nm.add_transition(\u0027play\u0027, \u0027rest\u0027, \u0027break\u0027)\n\nself.fsm.initialize(\u0027wakeup\u0027)\n\nself.fsm.process_event(\u0027walk\u0027, \u0027play\u0027)\n\nself.fsm.process_event(\u0027break\u0027)\n\nself.assertEqual(\u0027rest\u0027, self.fsm.current_state)\n\nself.assertIsNone(self.fsm.target_state)","commit_id":"30ea86d00539aae3580f06fe0c3b34eb8073541f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d1fdb09d810149a7c62bfe6633dad18f1dc0647c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.fsm.initialize(\u0027wakeup\u0027)"},{"line_number":84,"context_line":"        self.fsm.process_event(\u0027walk\u0027, \u0027play\u0027)"},{"line_number":85,"context_line":"        self.assertEqual(\u0027working\u0027, self.fsm.current_state)"},{"line_number":86,"context_line":"        self.assertEqual(\u0027play\u0027, self.fsm.target_state)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # specify an invalid target state"},{"line_number":89,"context_line":"        self.fsm.initialize(\u0027wakeup\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_c452ec34","line":86,"in_reply_to":"ba8a016a_444363b2","updated":"2015-11-19 16:17:55.000000000","message":"My mistake. Ignore the comment.","commit_id":"30ea86d00539aae3580f06fe0c3b34eb8073541f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7232b57864d984ae46e010fd78db682e0d18198c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.fsm.initialize(\u0027wakeup\u0027)"},{"line_number":84,"context_line":"        self.fsm.process_event(\u0027walk\u0027, \u0027play\u0027)"},{"line_number":85,"context_line":"        self.assertEqual(\u0027working\u0027, self.fsm.current_state)"},{"line_number":86,"context_line":"        self.assertEqual(\u0027play\u0027, self.fsm.target_state)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # specify an invalid target state"},{"line_number":89,"context_line":"        self.fsm.initialize(\u0027wakeup\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_444363b2","line":86,"in_reply_to":"ba8a016a_f3957f32","updated":"2015-11-19 14:52:01.000000000","message":"I\u0027m not sure what you mean. Does that work? I didn\u0027t try it but it seems like self.fsm.process_event(\u0027break\u0027) won\u0027t work, because the fsm\u0027s current state is \u0027working\u0027, but \u0027break\u0027 only applies to \u0027play\u0027.","commit_id":"30ea86d00539aae3580f06fe0c3b34eb8073541f"}],"ironic/tests/unit/drivers/modules/irmc/test_deploy.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"78185036ad70e68e292e994f92a1b01b2df26fc9","unresolved":false,"context_lines":[{"line_number":1404,"context_line":"                                     _configure_vmedia_boot_mock,"},{"line_number":1405,"context_line":"                                     reboot_and_finish_deploy_mock):"},{"line_number":1406,"context_line":"        self.node.provision_state \u003d states.DEPLOYWAIT"},{"line_number":1407,"context_line":"        self.node.target_provision_state \u003d states.ACTIVE"},{"line_number":1408,"context_line":"        self.node.save()"},{"line_number":1409,"context_line":"        do_agent_iscsi_deploy_mock.return_value \u003d {"},{"line_number":1410,"context_line":"            \u0027root uuid\u0027: \u0027some-root-uuid\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_6991b4f0","line":1407,"updated":"2015-11-19 10:02:46.000000000","message":"Oh nice that now we can capture when the target provision state is being set for a non-stable state.","commit_id":"30ea86d00539aae3580f06fe0c3b34eb8073541f"}]}